>
> Signed-off-by: Song Chen
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 32
> +
> 1 file changed, 11 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c
> b/drivers/staging/unisys/v
visornic uses timer to check the response queue and drain
it if needed periodically. On the other hand, visorbus
provides periodic work to serve such request, therefore,
timer should be replaced by channel_interrupt.
Signed-off-by: Song Chen
---
drivers/staging/unisys/visornic/visornic_main.c
visorhba uses kthread to obtain the responses from the IO
Service Partition periodically, on the other hand, visorbus
provides periodic work to serve such request, therefore,
kthread should be replaced by channel_interrupt.
Signed-off-by: Song Chen
---
drivers/staging/unisys/visorhba
Sequence Number api provides interfaces for unsigned atomic up counters
leveraging atomic_t and atomic64_t ops underneath. Convert it to use
seqnum_ops.
atomic_t variable used for error_count are atomic counters. Convert it to
use seqnum_ops.
Signed-off-by: Shuah Khan
---
.../staging/unisys
s. No change to the behavior with
this change.
Signed-off-by: Shuah Khan
---
.../staging/unisys/visorhba/visorhba_main.c | 37 ++-
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/vis
. values. No change to the behavior with
> this change.
>
> Signed-off-by: Shuah Khan
> ---
> .../staging/unisys/visorhba/visorhba_main.c | 37 ++-
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/unisys/vi
guard resource lifetimes, device usage and
open counts that control state changes, and pm states.
atomic_t variables used for error_count and ios_threshold are atomic
counters and guarded by max. values. No change to the behavior with
this change.
Signed-off-by: Shuah Khan
---
.../staging/unisys/vis
rs/staging/unisys/visorhba/visorhba_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/visorhba/visorhba_main.c
index 99c57ceeb357..7ae5306b92fe 100644
--- a/drivers/staging/unisys/visorhba/visor
-by: Christophe JAILLET
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_main.c
index 9d4f1dab0968..40dd573e73c3 100644
--- a/drivers/
-by: Christophe JAILLET
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers/staging/unisys/visornic/visornic_main.c
index 9d4f1dab0968..40dd573e73c3 100644
--- a/drivers/
Commit e99e88a9d2b06 ("treewide: setup_timer() -> timer_setup()") has
updated the parameters of 'poll_for_irq()' but not the comment above the
function.
Update the comment and fix a typo.
s/visronic/visornic/
Signed-off-by: Christophe JAILLET
---
drivers/staging/unisys/v
On Wed, May 22, 2019 at 10:35:30PM +0530, Hariprasad Kelam wrote:
> As per below information
>
> GFP_KERNEL FLAG
>
> This is a normal allocation and might block. This is the flag to use in
> process context code when it is safe to sleep.
>
> GFP_ATOMIC FLAG
>
> The allocation is high-priority
other situations where you
cannot sleep
And we can take advantage of GFP_KERNEL , as when system is in low
memory chances of getting success is high compared to GFP_ATOMIC.
As visornic_probe is in process context we can use GPF_KERNEL.
Signed-off-by: Hariprasad Kelam
---
drivers/staging/unisys
- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"
Signed-off-by: Moses Christopher
---
drivers/staging/unisys/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dr
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote:
> From: Moses Christopher
>
Could you Fix your email From header so this isn't required?
regards,
dan carpenter
On Sat, Apr 20, 2019 at 11:46:46AM +, MosesChristopher wrote:
> From: Moses Christopher
>
> - Resolve the following warning from the Kconfig,
> "WARNING: prefer 'help' over '---help---' for new help texts"
>
> Signed-off-by: Moses Chri
From: Moses Christopher
- Resolve the following warning from the Kconfig,
"WARNING: prefer 'help' over '---help---' for new help texts"
Signed-off-by: Moses Christopher
---
drivers/staging/unisys/Kconfig | 2 +-
drivers/staging/unisys/viso
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li
---
drivers/staging/unisys/visorhba/visorhba_main.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys
asha Levin
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorhba/visorhba_main.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -842,7 +842,7 @@ s
asha Levin
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorhba/visorhba_main.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -792,7 +792,7 @@ s
e issue by moving the variables on stack in
do_scsi_nolinuxstat() to heap memory.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Sasha Levin
---
drivers/staging/unisys/visorhba/visorhba_main.c | 8 +++-
1 file changed, 7
e issue by moving the variables on stack in
do_scsi_nolinuxstat() to heap memory.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Sasha Levin
---
drivers/staging/unisys/visorhba/visorhba_main.c | 8 +++-
1 file changed, 7
undefined reference to `input_event'
drivers/built-in.o: In function `input_sync':
visorinput.c:(.text+0x207fdc): undefined reference to `input_event'
Signed-off-by: Randy Dunlap
Signed-off-by: Greg Kroah-Hartman
---
drivers/staging/unisys/visorinput/Kconfig |2 +-
1 file change
bly did that for
>> a purpose and one driver shouldn't be changing that.
>>
>> Signed-off-by: Randy Dunlap
>> Cc: David Kershner
>> Cc: sparmaintai...@unisys.com (Unisys internal)
>> Cc: de...@driverdev.osuosl.org
>> Cc: Greg Kroah-Hartman
>&g
changing that.
>
> Signed-off-by: Randy Dunlap
> Cc: David Kershner
> Cc: sparmaintai...@unisys.com (Unisys internal)
> Cc: de...@driverdev.osuosl.org
> Cc: Greg Kroah-Hartman
> ---
> drivers/staging/unisys/Kconfig |3 +--
> 1 file changed, 1 insertion(+), 2 dele
sys.com (Unisys internal)
Cc: de...@driverdev.osuosl.org
Cc: Greg Kroah-Hartman
---
drivers/staging/unisys/Kconfig |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
menuco
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -581,7 +581,8 @@ static void *parser_name_get(struct parser_context *ctx)
> struct visor_controlvm_parameters_header *phdr;
>
> phdr = &ctx-&
by: Dan Carpenter
Signed-off-by: David Kershner
Reviewed-by: David Binder
---
drivers/staging/unisys/visorbus/visorchipset.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
Kroah-Hartman
> ; Sameer Wadgaonkar
> ; Sell, Timothy C
>
> Cc: LKML ; kernel-janit...@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorchipset: Use common error handling
> code in setup_crash_devices_work_queue()
>
> From: Markus Elfring
> Date: Fri, 3 Nov 2017 20:37:
Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/unisys/visorbus/visorchipset.c | 36 --
1 file changed, 16 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchips
ompson, Bryan E.
> ; *S-Par-Maintainer
> ; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] staging: unisys/visorbus: add __init/__exit annotations
>
> gcc-4.6 causes a harmless warning about the init function:
>
> WARNING: vmlinux.o(.text+
warning and slightly reduces the runtime code size.
Signed-off-by: Arnd Bergmann
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/visorchipset.c
/staging-unisys-visorbus-Declared-char-array-as-static-const/20170911-161501
config: x86_64-randconfig-it0-09120552 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones
/staging-unisys-visorbus-Declared-char-array-as-static-const/20170911-161501
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by
On Sat, 9 Sep 2017, Greg KH wrote:
> On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote:
> > State explicitly that individual entries in array will not change.
> >
> > Signed-off-by: Harsha Sharma
> > ---
> > drivers/staging/unisys/visorbus/vi
On Sat, Sep 09, 2017 at 12:30:42PM +0530, Harsha Sharma wrote:
> State explicitly that individual entries in array will not change.
>
> Signed-off-by: Harsha Sharma
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
State explicitly that individual entries in array will not change.
Signed-off-by: Harsha Sharma
---
drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys
; *S-Par-Maintainer
> ; de...@driverdev.osuosl.org
> Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][staging-next] staging: unisys: visorbus: make two functions
> static
>
> From: Colin Ian King
>
> The functions sig_queue_offset and sig_da
a list of people to whom
you Cc to.
Thanks for understanding.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/staging/unisys/visorbus/visorchannel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchannel.c
>
27; was not declared. Should it be static?
Signed-off-by: Colin Ian King
---
drivers/staging/unisys/visorbus/visorchannel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchannel.c
b/drivers/staging/unisys/visorbus/visorchannel.
On Wed, Aug 30, 2017 at 02:38:45PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 31, 2017 at 08:20:25PM +0300, Andy Shevchenko wrote:
> > Yep! There are so many conflicts that would be better just to push
> > through your tree.
> >
> > I have just sent a v2 of this patch separately.
>
> Greg, did
On Wed, 2017-08-30 at 14:38 +0200, Christoph Hellwig wrote:
> On Mon, Jul 31, 2017 at 08:20:25PM +0300, Andy Shevchenko wrote:
> > Yep! There are so many conflicts that would be better just to push
> > through your tree.
> >
> > I have just sent a v2 of this patch separately.
>
> Greg, did you pi
On Mon, Jul 31, 2017 at 08:20:25PM +0300, Andy Shevchenko wrote:
> Yep! There are so many conflicts that would be better just to push
> through your tree.
>
> I have just sent a v2 of this patch separately.
Greg, did you pick that patch up?
> -Original Message-
> From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com]
> Sent: Monday, July 31, 2017 1:19 PM
> Subject: [PATCH v2] staging: unisys: Switch to use new generic UUID API
>
> There are new types and helpers that are supposed to be used in n
On Sun, 2017-07-30 at 10:37 -0700, Greg Kroah-Hartman wrote:
> On Sun, Jul 30, 2017 at 08:26:48PM +0300, Andy Shevchenko wrote:
> > On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman
> > wrote:
> > > Doesn't apply to the staging tree at all :(
> >
> > No surprises, it was cooked against uuid tr
...@unisys.com
Cc: de...@driverdev.osuosl.org
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/Documentation/overview.txt | 14 +++
drivers/staging/unisys/include/channel.h | 29 ++
drivers/staging/unisys/include/iochannel.h | 2 +-
drivers/staging/unisys/include
On Sun, Jul 30, 2017 at 08:26:48PM +0300, Andy Shevchenko wrote:
> On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman
> wrote:
> > On Wed, Jul 26, 2017 at 01:01:41PM +0300, Andy Shevchenko wrote:
> >> On Wed, 2017-07-19 at 21:28 +0300, Andy Shevchenko wrote:
> >> > There are new types and helpers
On Sun, Jul 30, 2017 at 6:32 PM, Greg Kroah-Hartman
wrote:
> On Wed, Jul 26, 2017 at 01:01:41PM +0300, Andy Shevchenko wrote:
>> On Wed, 2017-07-19 at 21:28 +0300, Andy Shevchenko wrote:
>> > There are new types and helpers that are supposed to be used in new
>> > code.
>> >
>> > As a preparation
On Wed, Jul 26, 2017 at 01:01:41PM +0300, Andy Shevchenko wrote:
> On Wed, 2017-07-19 at 21:28 +0300, Andy Shevchenko wrote:
> > There are new types and helpers that are supposed to be used in new
> > code.
> >
> > As a preparation to get rid of legacy types and API functions do
> > the conversion
ta bss dec hex filename
> 24124 6216 448 307887844
> drivers/staging/unisys/visorbus/visorchipset.o
>
> File size after:
> text data bss dec hex filename
> 242206120 448 307887844
> drivers/staging/unisys/visorbus/visorc
ta bss dec hex filename
> 142167304 832 223525750
> drivers/staging/unisys/visorbus/visorbus_main.o
>
> File size after:
> text data bss dec hex filename
> 144087112 832 223525750
> drivers/staging/unisys/visorbus/visorbu
Functions working with attribute_groups provided by
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
24124 6216 448 307887844
drivers/staging/unisys
dy Shevchenko
> ---
> drivers/staging/unisys/Documentation/overview.txt | 14 +++
> drivers/staging/unisys/include/channel.h | 45 ++---
> ---
> drivers/staging/unisys/include/iochannel.h | 14 +--
> drivers/staging/unisys/include/visorbus.
Functions working with attribute_groups provided by
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.
File size before:
text data bss dec hex filename
142167304 832 223525750
drivers/staging/unisys
> -Original Message-
> From: Himanshu Jha [mailto:himanshujha199...@gmail.com]
> Subject: [PATCH] Staging : unisys : visorbus : visorbus_main: Fixed a brace
> cdoing style issue
>
> Fixed coding style issue for function declaration.
>
This doesn't apply to Greg
Fixed coding style issue for function declaration.
Signed-off-by: Himanshu Jha
---
drivers/staging/unisys/visorbus/visorbus_main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys
...@unisys.com
Cc: de...@driverdev.osuosl.org
Signed-off-by: Andy Shevchenko
---
drivers/staging/unisys/Documentation/overview.txt | 14 +++
drivers/staging/unisys/include/channel.h | 45 ++--
drivers/staging/unisys/include/iochannel.h | 14 +--
drivers/staging/unisys
:
merge conflict.
Changes in v4:
version change description was missing.
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys
as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
What changed from the previous patches? Always include that below the
--- line as
y: Arvind Yadav
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
What changed from the previous patches? Always include that below the
--- line as maintainers have no sh
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging
y: Arvind Yadav
> ---
> Changes in v2:
> Change log typo was not correct.
>
> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Does not apply to my tree a
/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd..bba10dc 100644
--- a
Bryan E.
> > ; jon.fri...@unisys.com; Binder, David
> > Anthony ; *S-Par-Maintainer
> > ; de...@driverdev.osuosl.org; linux-
> > ker...@vger.kernel.org
> > Subject: Re: [PATCH] staging: unisys: visorbus: constify attribute_group
> > structures.
Why is this in you
de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH] staging: unisys: visorbus: constify attribute_group
> structures.
>
> On Mon, Jul 17, 2017 at 05:43:14PM +0530, Arvind Yadav wrote:
> > Hi Greg,
> >
> >
> > On Monday 17 July 2017
unctions
> > > working with attribute_groups provided by work
> > > with const attribute_group. So mark the non-const structs as const.
> > >
> > > Signed-off-by: Arvind Yadav
> > > ---
> > > drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++
structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Why not just use the ATTRIBUTE_GROUPS() macro for these? Or is there
something that
y: Arvind Yadav
> ---
> drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
> drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Why not just use the ATTRIBUTE_GROUPS() macro for these? Or is there
something that is preventing that?
thanks,
greg k-h
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by work
with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
drivers/staging
On Mon, Jul 10, 2017 at 11:48:26PM -0400, Mitchell Tasman wrote:
> Resolve multiple checkpatch errors by relocating open braces
> following function definitions to the next line.
>
> Signed-off-by: Mitchell Tasman
> ---
> drivers/staging/unisys/visorbus/vi
Resolve multiple checkpatch errors by relocating open braces
following function definitions to the next line.
Signed-off-by: Mitchell Tasman
---
drivers/staging/unisys/visorbus/visorbus_main.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers
On Tue, Jun 27, 2017 at 07:49:05PM -0700, Quytelda Kahja wrote:
> Replace the literal function name "visorbus_create_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
>
> Signed-off-by: Quytelda Kahja
> ---
more import
to mention in the subject than the fact that you "fix some issue
highlighted by checkpatch".
Something like
Subject: [PATCH] staging: unisys: visorbus: use __func__ instead of
function name
Of course you can still mention that checkpatch highlighted the issue
for you in
Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.
Signed-off-by: Quytelda Kahja
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insertion(+), 1 del
.@unisys.com
> Cc: de...@driverdev.osuosl.org; *S-Par-Maintainer
> ; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorbus: constify
> visorchipset_parahotplug_group
>
> File size before:
>text data bss dec hex filename
> 11058 816
*S-Par-Maintainer ;
> de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and
> dev_attr_grp
>
> File size before:
>text data bss dec hex filename
>6712 960 521
Fixed style of permissions to octal.
Found using checkpatch
Signed-off-by: Derek Robson
---
V1 and V2 had vauge subject lines
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b
File size before:
textdata bss dec hex filename
6712 960 52181932001
drivers/staging/unisys/visorbus/visorbus_main.o
File size After adding 'const':
textdata bss dec hex filename
6840 832 52181932001
drive
File size before:
textdata bss dec hex filename
11058 816 24 118982e7a
drivers/staging/unisys/visorbus/visorchipset.o
File size After adding 'const':
textdata bss dec hex filename
11122 752 24 118982e7a
drive
thy C ;
> > Binder, David Anthony ; Wadgaonkar, Sameer
> > Laxmikant ;
> > marcos.souza@gmail.com; robso...@gmail.com
> > Cc: *S-Par-Maintainer ;
> > de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH V2] staging: unisys: visorhba - st
uza@gmail.com; robso...@gmail.com
> Cc: *S-Par-Maintainer ;
> de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson
I
Fixed style of permissions to octal.
Found using checkpatch
Signed-off-by: Derek Robson
V1 has vauge subject
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers
rison isn't appropriate.
This mistake was found by David Binderman .
[arnd: the fix is from 4.4 but needed some minor fixup to adapt
to context changes]
Signed-off-by: Benjamin Romer
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Arnd Bergmann
---
drivers/staging/unisys/visorutil/perio
gt; ; Wadgaonkar, Sameer Laxmikant
> ; Curtin, Alexander Paul
> ; *S-Par-Maintainer
> ; de...@driverdev.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] staging: unisys: Solve sparse warning
>
> The following commit fixes the following sparse report:
>
> driv
The following commit fixes the following sparse report:
drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
restricted __le64
by casting readq (which is unsigned long on x86) to u64, as expected by the
seq_printf call.
Signed-off-by: Marcos Paulo de Souza
---
Just
Straightforward conversion to the new function.
Signed-off-by: Logan Gunthorpe
Acked-by: David Kershner
---
drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b
Great, thanks!
Logan
On 14/04/17 10:07 AM, Kershner, David A wrote:
> Can you add Acked-by for this patch?
>
> Acked-by: David Kershner
>
> Tested on s-Par and no problems.
>
> Thanks,
> David Kershner
>
>> ---
>> drivers/staging/unisys/visorhba/
> -Original Message-
> From: Logan Gunthorpe [mailto:log...@deltatee.com]
...
> Subject: [PATCH 10/22] staging: unisys: visorbus: Make use of the new
> sg_map helper function
>
> Straightforward conversion to the new function.
>
> Signed-off-by: Logan Gunthorpe
Straightforward conversion to the new function.
Signed-off-by: Logan Gunthorpe
---
drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
b/drivers/staging/unisys/visorhba
Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
counterparts
Signed-off-by: Thomas Jespersen
Acked-by: David Kershner
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visornic
On Sat, Mar 04, 2017 at 06:20:50PM +0100, Andrea Ghittino wrote:
> Sparse generates two warnings related to incorrect type in assignment.
> This patch changes the types in the struct defined in unisys
Can you post the Sparse warning? Otherwise when I'm reviewing this
code I have to re-run Sparse
n you post the Sparse warning? Otherwise when I'm reviewing this
> code I have to re-run Sparse to see what you're talking about.
>
> regards,
> dan carpenter
Here you can find sparse warnings:
drivers/staging/unisys/visornic/visornic_main.c:844:50: warning: incorrec
> -Original Message-
> From: Andrea Ghittino [mailto:aghitt...@gmail.com]
> Sent: Saturday, March 4, 2017 12:21 PM
> To: de...@driverdev.osuosl.org; Kershner, David A
> ; gre...@linuxfoundation.org; *S-Par-
> Maintainer ; linux-kernel@vger.kernel.org
> Subject: [P
/unisys/include/iochannel.h
b/drivers/staging/unisys/include/iochannel.h
index 54f4900..41e5b4e 100644
--- a/drivers/staging/unisys/include/iochannel.h
+++ b/drivers/staging/unisys/include/iochannel.h
@@ -308,8 +308,8 @@ struct net_pkt_xmt {
u8 valid; /* 1 = struct is valid - else
This patch replace "the the " with "the". The replacement couldn't be
automated because sometimes the first "the" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insert
This patch replace "the the " with "the". The replacement couldn't be
automated because sometimes the first "the" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insert
This patch replace "the the " with "the". The replacement couldn't be
automated because sometimes the first "the" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insert
This patch replace "the the " with "the". The replacement couldn't be
automated because sometimes the first "the" was meant to be another
word.
Signed-off-by: simran singhal
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed, 1 insert
] [linux-next]staging: unisys: visornic: Fix typo in
> visornic_main.c
>
> This patch fix some spelling typos found in visornic_main.c
>
Acked-by: David Kershner
> Signed-off-by: Masanari Iida
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 22 +++-
This patch fix some spelling typos found in visornic_main.c
Signed-off-by: Masanari Iida
---
drivers/staging/unisys/visornic/visornic_main.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/drivers
1 - 100 of 563 matches
Mail list logo
