Re: stec skd block driver needs updating for immutable biovec

2013-11-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, November 01, 2013 10:34:23 AM Jens Axboe wrote: > On 11/01/2013 10:28 AM, Mike Snitzer wrote: > > On Fri, Nov 01 2013 at 12:02pm -0400, > > Jens Axboe wrote: > > > >> On 11/01/2013 09:50 AM, Christoph Hellwig wrote: > >>> On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer

Re: stec skd block driver needs updating for immutable biovec

2013-11-04 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, November 01, 2013 10:34:23 AM Jens Axboe wrote: On 11/01/2013 10:28 AM, Mike Snitzer wrote: On Fri, Nov 01 2013 at 12:02pm -0400, Jens Axboe ax...@kernel.dk wrote: On 11/01/2013 09:50 AM, Christoph Hellwig wrote: On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
On Fri, Nov 01 2013 at 12:34pm -0400, Jens Axboe wrote: > On 11/01/2013 10:28 AM, Mike Snitzer wrote: > > On Fri, Nov 01 2013 at 12:02pm -0400, > > Jens Axboe wrote: > > > >> On 11/01/2013 09:50 AM, Christoph Hellwig wrote: > >>> On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: >

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Jens Axboe
On 11/01/2013 10:28 AM, Mike Snitzer wrote: > On Fri, Nov 01 2013 at 12:02pm -0400, > Jens Axboe wrote: > >> On 11/01/2013 09:50 AM, Christoph Hellwig wrote: >>> On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: All the bi_sector ones are low hanging fruit, but the conversion

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
On Fri, Nov 01 2013 at 12:02pm -0400, Jens Axboe wrote: > On 11/01/2013 09:50 AM, Christoph Hellwig wrote: > > On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: > >> All the bi_sector ones are low hanging fruit, but the conversion for > >> skd_preop_sg_list_bio()'s bio_vec code is

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Jens Axboe
On 11/01/2013 09:50 AM, Christoph Hellwig wrote: > On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: >> All the bi_sector ones are low hanging fruit, but the conversion for >> skd_preop_sg_list_bio()'s bio_vec code is more involved. >> >> Kent, any chance you could crank through it? >>

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Christoph Hellwig
On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: > All the bi_sector ones are low hanging fruit, but the conversion for > skd_preop_sg_list_bio()'s bio_vec code is more involved. > > Kent, any chance you could crank through it? > > If not I can come back to trying to fix this

stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
Hey Jens and Kent, You're likely already aware of this but building the latest linux-block.git 'for-next' I get: CC [M] drivers/block/skd_main.o drivers/block/skd_main.c: In function ‘skd_request_fn’: drivers/block/skd_main.c:773: error: ‘struct bio’ has no member named ‘bi_sector’

stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
Hey Jens and Kent, You're likely already aware of this but building the latest linux-block.git 'for-next' I get: CC [M] drivers/block/skd_main.o drivers/block/skd_main.c: In function ‘skd_request_fn’: drivers/block/skd_main.c:773: error: ‘struct bio’ has no member named ‘bi_sector’

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Christoph Hellwig
On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: All the bi_sector ones are low hanging fruit, but the conversion for skd_preop_sg_list_bio()'s bio_vec code is more involved. Kent, any chance you could crank through it? If not I can come back to trying to fix this later.. but

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Jens Axboe
On 11/01/2013 09:50 AM, Christoph Hellwig wrote: On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: All the bi_sector ones are low hanging fruit, but the conversion for skd_preop_sg_list_bio()'s bio_vec code is more involved. Kent, any chance you could crank through it? If not I

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
On Fri, Nov 01 2013 at 12:02pm -0400, Jens Axboe ax...@kernel.dk wrote: On 11/01/2013 09:50 AM, Christoph Hellwig wrote: On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: All the bi_sector ones are low hanging fruit, but the conversion for skd_preop_sg_list_bio()'s bio_vec code

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Jens Axboe
On 11/01/2013 10:28 AM, Mike Snitzer wrote: On Fri, Nov 01 2013 at 12:02pm -0400, Jens Axboe ax...@kernel.dk wrote: On 11/01/2013 09:50 AM, Christoph Hellwig wrote: On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike Snitzer wrote: All the bi_sector ones are low hanging fruit, but the conversion

Re: stec skd block driver needs updating for immutable biovec

2013-11-01 Thread Mike Snitzer
On Fri, Nov 01 2013 at 12:34pm -0400, Jens Axboe ax...@kernel.dk wrote: On 11/01/2013 10:28 AM, Mike Snitzer wrote: On Fri, Nov 01 2013 at 12:02pm -0400, Jens Axboe ax...@kernel.dk wrote: On 11/01/2013 09:50 AM, Christoph Hellwig wrote: On Fri, Nov 01, 2013 at 11:43:39AM -0400, Mike