Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Tom Lendacky
On 6/2/2017 9:43 AM, Michal Hocko wrote: On Fri 02-06-17 09:20:54, Tom Lendacky wrote: On 5/31/2017 11:04 AM, Michal Hocko wrote: Hi Tom, Hi Michal, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks

Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Tom Lendacky
On 6/2/2017 9:43 AM, Michal Hocko wrote: On Fri 02-06-17 09:20:54, Tom Lendacky wrote: On 5/31/2017 11:04 AM, Michal Hocko wrote: Hi Tom, Hi Michal, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks

Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Michal Hocko
On Fri 02-06-17 09:20:54, Tom Lendacky wrote: > On 5/31/2017 11:04 AM, Michal Hocko wrote: > >Hi Tom, > > Hi Michal, > > >I have stumbled over the following construct in xgbe_map_rx_buffer > > order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); > >which looks quite suspicious. Why does it

Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Michal Hocko
On Fri 02-06-17 09:20:54, Tom Lendacky wrote: > On 5/31/2017 11:04 AM, Michal Hocko wrote: > >Hi Tom, > > Hi Michal, > > >I have stumbled over the following construct in xgbe_map_rx_buffer > > order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); > >which looks quite suspicious. Why does it

Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Tom Lendacky
On 5/31/2017 11:04 AM, Michal Hocko wrote: Hi Tom, Hi Michal, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks quite suspicious. Why does it PAGE_ALLOC_COSTLY_ORDER - 1? And why do you depend on

Re: strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-06-02 Thread Tom Lendacky
On 5/31/2017 11:04 AM, Michal Hocko wrote: Hi Tom, Hi Michal, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks quite suspicious. Why does it PAGE_ALLOC_COSTLY_ORDER - 1? And why do you depend on

strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-05-31 Thread Michal Hocko
Hi Tom, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks quite suspicious. Why does it PAGE_ALLOC_COSTLY_ORDER - 1? And why do you depend on PAGE_ALLOC_COSTLY_ORDER at all? Thanks! -- Michal Hocko SUSE Labs

strange PAGE_ALLOC_COSTLY_ORDER usage in xgbe_map_rx_buffer

2017-05-31 Thread Michal Hocko
Hi Tom, I have stumbled over the following construct in xgbe_map_rx_buffer order = max_t(int, PAGE_ALLOC_COSTLY_ORDER - 1, 0); which looks quite suspicious. Why does it PAGE_ALLOC_COSTLY_ORDER - 1? And why do you depend on PAGE_ALLOC_COSTLY_ORDER at all? Thanks! -- Michal Hocko SUSE Labs