Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
On Thu, Jul 23, 2015 at 1:50 PM, Andy Shevchenko wrote: > On Thu, 2015-07-23 at 13:36 -0700, Kees Cook wrote: >> On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko >> wrote: >> > On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: >> > > Hi, >> > > >> > > I'm curious why ESCAPE_SPACE doesn't

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 13:36 -0700, Kees Cook wrote: > On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko > wrote: > > On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: > > > Hi, > > > > > > I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? > > > > Space is a printable character. > >

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko wrote: > On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: >> Hi, >> >> I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? > > Space is a printable character. > You perhaps wants something like ESCAPE_SPACE | ESCAPE_HEX. Yeah, I can get

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: > Hi, > > I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? Space is a printable character. You perhaps wants something like ESCAPE_SPACE | ESCAPE_HEX. > That is > surprising to me, especially since things like isspace() include >

string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? That is surprising to me, especially since things like isspace() include 0x20. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
On Thu, Jul 23, 2015 at 1:50 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-23 at 13:36 -0700, Kees Cook wrote: On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: Hi,

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? Space is a printable character. You perhaps wants something like ESCAPE_SPACE |

string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Kees Cook
Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? That is surprising to me, especially since things like isspace() include 0x20. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? Space is a printable character. You perhaps wants something like ESCAPE_SPACE | ESCAPE_HEX. That is surprising to me, especially since things like isspace() include 0x20.

Re: string_escape_mem ESCAPE_SPACE

2015-07-23 Thread Andy Shevchenko
On Thu, 2015-07-23 at 13:36 -0700, Kees Cook wrote: On Thu, Jul 23, 2015 at 1:27 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Thu, 2015-07-23 at 12:59 -0700, Kees Cook wrote: Hi, I'm curious why ESCAPE_SPACE doesn't escape spaces (0x20)? Space is a printable