[PATCH 3.13.y-ckt 118/138] af_unix: fix struct pid memory leak

2016-03-09 Thread Kamal Mostafa
3.13.11-ckt36 -stable review patch. If anyone has any objections, please let me know. ---8< From: Eric Dumazet commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller progr

[PATCH 3.19.y-ckt 157/196] af_unix: fix struct pid memory leak

2016-03-08 Thread Kamal Mostafa
3.19.8-ckt16 -stable review patch. If anyone has any objections, please let me know. ---8< From: Eric Dumazet commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller progra

[PATCH 4.2.y-ckt 222/273] af_unix: fix struct pid memory leak

2016-03-07 Thread Kamal Mostafa
4.2.8-ckt5 -stable review patch. If anyone has any objections, please let me know. ---8< From: Eric Dumazet [ Upstream commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b ] Dmitry reported a struct pid leak detected by a syzkaller progr

[PATCH 2.6.32 16/55] af_unix: fix struct pid memory leak

2016-03-04 Thread Willy Tarreau
2.6.32-longterm review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we brea

[PATCH 3.12 006/116] af_unix: fix struct pid memory leak

2016-03-04 Thread Jiri Slaby
From: Eric Dumazet 3.12-stable review patch. If anyone has any objections, please let me know. === [ Upstream commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b ] Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break th

[PATCH 4.4 007/342] af_unix: fix struct pid memory leak

2016-03-01 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b ] Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break

[PATCH 3.16.y-ckt 120/129] af_unix: fix struct pid memory leak

2016-02-26 Thread Luis Henriques
3.16.7-ckt25 -stable review patch. If anyone has any objections, please let me know. ---8< From: Eric Dumazet commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller progra

Re: [PATCH 3.2 08/67] af_unix: fix struct pid memory leak

2016-02-24 Thread Willy Tarreau
On Wed, Feb 24, 2016 at 09:24:39PM +, Ben Hutchings wrote: (...) > Yes, it looks like the bug was really introduced way back in 2.5.65 by > "[NET]: Simplify scm handling and sendmsg/recvmsg invocation, > consolidate net compat syscalls." > > So I think this is also needed for 2.6.32. Thanks f

Re: [PATCH 3.2 08/67] af_unix: fix struct pid memory leak

2016-02-24 Thread Ben Hutchings
On Tue, 2016-02-23 at 22:07 +, Rainer Weikusat wrote: > Ben Hutchings writes: > > 3.2.78-rc1 review patch.  If anyone has any objections, please let me know. > > > > -- > > > > From: Eric Dumazet > > > > commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. > > [...] >

Re: [PATCH 3.2 08/67] af_unix: fix struct pid memory leak

2016-02-23 Thread Rainer Weikusat
Ben Hutchings writes: > 3.2.78-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Eric Dumazet > > commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. [...] > Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv > ro

[PATCH 3.2 08/67] af_unix: fix struct pid memory leak

2016-02-23 Thread Ben Hutchings
3.2.78-rc1 review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet commit fa0dc04df259ba2df3ce1920e9690c7842f8fa4b upstream. Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break the

Re: [PATCH net] af_unix: fix struct pid memory leak

2016-01-24 Thread Willy Tarreau
Hi Eric, On Sun, Jan 24, 2016 at 01:53:50PM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Dmitry reported a struct pid leak detected by a syzkaller program. > > Bug happens in unix_stream_recvmsg() when we break the loop when a > signal is pending, without properly releasing scm. > > Fix

[PATCH net] af_unix: fix struct pid memory leak

2016-01-24 Thread Eric Dumazet
From: Eric Dumazet Dmitry reported a struct pid leak detected by a syzkaller program. Bug happens in unix_stream_recvmsg() when we break the loop when a signal is pending, without properly releasing scm. Fixes: b3ca9b02b007 ("net: fix multithreaded signal handling in unix recv routines") Repor

Re: struct pid memory leak

2016-01-24 Thread Eric Dumazet
On Sat, Jan 23, 2016 at 7:04 PM, Willy Tarreau wrote: > On Sat, Jan 23, 2016 at 06:50:11PM -0800, Eric Dumazet wrote: >> On Sat, Jan 23, 2016 at 6:38 PM, Willy Tarreau wrote: >> > On Sun, Jan 24, 2016 at 03:11:45AM +0100, Willy Tarreau wrote: >> >> It doesn't report this on 3.10. >> > >> > To be

Re: struct pid memory leak

2016-01-23 Thread Willy Tarreau
On Sat, Jan 23, 2016 at 06:50:11PM -0800, Eric Dumazet wrote: > On Sat, Jan 23, 2016 at 6:38 PM, Willy Tarreau wrote: > > On Sun, Jan 24, 2016 at 03:11:45AM +0100, Willy Tarreau wrote: > >> It doesn't report this on 3.10. > > > > To be more precise, kmemleak reports the issue on 3.13 and not on 3.

Re: struct pid memory leak

2016-01-23 Thread Eric Dumazet
On Sat, Jan 23, 2016 at 6:38 PM, Willy Tarreau wrote: > On Sun, Jan 24, 2016 at 03:11:45AM +0100, Willy Tarreau wrote: >> It doesn't report this on 3.10. > > To be more precise, kmemleak reports the issue on 3.13 and not on 3.12. > I'm not sure if it's reliable enough to run a bisect though. > > W

Re: struct pid memory leak

2016-01-23 Thread Willy Tarreau
On Sun, Jan 24, 2016 at 03:11:45AM +0100, Willy Tarreau wrote: > It doesn't report this on 3.10. To be more precise, kmemleak reports the issue on 3.13 and not on 3.12. I'm not sure if it's reliable enough to run a bisect though. Willy

Re: struct pid memory leak

2016-01-23 Thread Willy Tarreau
On Sat, Jan 23, 2016 at 07:46:45PM +0100, Dmitry Vyukov wrote: > On Sat, Jan 23, 2016 at 7:40 PM, Willy Tarreau wrote: > > On Sat, Jan 23, 2016 at 07:14:33PM +0100, Dmitry Vyukov wrote: > >> I've attached my .config. > >> Also run this program in a parallel loop. I think it's leaking not > >> ever

Re: struct pid memory leak

2016-01-23 Thread Eric Dumazet
On Sat, Jan 23, 2016 at 10:46 AM, Dmitry Vyukov wrote: > On Sat, Jan 23, 2016 at 7:40 PM, Willy Tarreau wrote: >> On Sat, Jan 23, 2016 at 07:14:33PM +0100, Dmitry Vyukov wrote: >>> I've attached my .config. >>> Also run this program in a parallel loop. I think it's leaking not >>> every time, pro

Re: struct pid memory leak

2016-01-23 Thread Dmitry Vyukov
On Sat, Jan 23, 2016 at 7:40 PM, Willy Tarreau wrote: > On Sat, Jan 23, 2016 at 07:14:33PM +0100, Dmitry Vyukov wrote: >> I've attached my .config. >> Also run this program in a parallel loop. I think it's leaking not >> every time, probably some race is involved. > > Thank you. Just in order to c

Re: struct pid memory leak

2016-01-23 Thread Willy Tarreau
On Sat, Jan 23, 2016 at 07:14:33PM +0100, Dmitry Vyukov wrote: > I've attached my .config. > Also run this program in a parallel loop. I think it's leaking not > every time, probably some race is involved. Thank you. Just in order to confirm, am I supposed to see the messages you quoted in dmesg ?

Re: struct pid memory leak

2016-01-23 Thread Willy Tarreau
Hi Eric, Dmitry, On Fri, Jan 22, 2016 at 08:50:01AM -0800, Eric Dumazet wrote: > CC netdev, as it looks some af_unix issue ... > > On Fri, 2016-01-22 at 16:08 +0100, Dmitry Vyukov wrote: > > Hello, > > > > The following program causes struct pid memory leak: &

Re: struct pid memory leak

2016-01-22 Thread Eric Dumazet
CC netdev, as it looks some af_unix issue ... On Fri, 2016-01-22 at 16:08 +0100, Dmitry Vyukov wrote: > Hello, > > The following program causes struct pid memory leak: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include &

struct pid memory leak

2016-01-22 Thread Dmitry Vyukov
Hello, The following program causes struct pid memory leak: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include long r[37]; void* thr(void* arg) { switch ((long)arg) { case 0: r[0] = syscall(SYS_mmap, 0x2000ul