Re: struct should not be named same way as function in sony-laptop

2008-01-03 Thread Pavel Machek
On Thu 2008-01-03 11:15:43, Al Viro wrote: > On Thu, Jan 03, 2008 at 12:01:54PM +0100, Pavel Machek wrote: > > Naming struct and function by same name is evil. Rename the struct. > > Um... why? It's not even particulary bad style per se... Occurs less > frequently than things like > struct

Re: struct should not be named same way as function in sony-laptop

2008-01-03 Thread Al Viro
On Thu, Jan 03, 2008 at 12:01:54PM +0100, Pavel Machek wrote: > Naming struct and function by same name is evil. Rename the struct. Um... why? It's not even particulary bad style per se... Occurs less frequently than things like struct foo *foo; but nothing inherently terrible and not li

struct should not be named same way as function in sony-laptop

2008-01-03 Thread Pavel Machek
Naming struct and function by same name is evil. Rename the struct. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c index b0f6803..31ce39d 100644 --- a/drivers/misc/sony-laptop.c +++ b/drivers/misc/sony-laptop.c @@ -1180,7 +1180