Re: suspicious ALSA empty commit

2007-10-19 Thread Mauro Carvalho Chehab
I'm using stg on top of git for merging and easy tree rebasing, but the version might be old (I'll try upgrade at first): Stacked GIT 0.12 git version 1.5.0.3 stg import / refresh / pick commands are on way to move patches to linus with stgit, you should add stg clean on your workflow. This wi

Re: suspicious ALSA empty commit

2007-10-17 Thread Catalin Marinas
On 17/10/2007, Linus Torvalds <[EMAIL PROTECTED]> wrote: > On Wed, 17 Oct 2007, Jaroslav Kysela wrote: > > I'm using stg on top of git for merging and easy tree rebasing, but the > > version might be old (I'll try upgrade at first): > > Ahh. That may explain it. stg may well be using the low-level

Re: suspicious ALSA empty commit

2007-10-17 Thread Linus Torvalds
On Wed, 17 Oct 2007, Jaroslav Kysela wrote: > > I'm using stg on top of git for merging and easy tree rebasing, but the > version might be old (I'll try upgrade at first): Ahh. That may explain it. stg may well be using the low-level git internal commands (which *do* allow you to create any k

Re: suspicious ALSA empty commit

2007-10-17 Thread Jaroslav Kysela
On Wed, 17 Oct 2007, Linus Torvalds wrote: > On Wed, 17 Oct 2007, Jaroslav Kysela wrote: > > > > I didn't notice, too. I've fixed this commit in my git tree. > > More importantly, how did it get there in the first place? > > As mentioned, normal git tools will not even *allow* you to create an

Re: suspicious ALSA empty commit

2007-10-17 Thread Linus Torvalds
On Wed, 17 Oct 2007, Jaroslav Kysela wrote: > > I didn't notice, too. I've fixed this commit in my git tree. More importantly, how did it get there in the first place? As mentioned, normal git tools will not even *allow* you to create an empty commit by default! So you must be using some real

Re: suspicious ALSA empty commit

2007-10-16 Thread Jaroslav Kysela
On Tue, 16 Oct 2007, Linus Torvalds wrote: > On Tue, 16 Oct 2007, David Miller wrote: > > > > While scanning over today's updates in Linus's tree, I noticed > > the following commit has no changes, and this does not appear > > to be intentional. > > Interesting. You're right, I didn't notice. I

Re: suspicious ALSA empty commit

2007-10-16 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Tue, 16 Oct 2007 16:26:43 -0700 (PDT) > Git shouldn't even allow such commits to be generated, although you can > force it by using the low-level functionality (eg using "git commit-tree" > directly for doing things like importing) That would be us

Re: suspicious ALSA empty commit

2007-10-16 Thread Linus Torvalds
On Tue, 16 Oct 2007, David Miller wrote: > > While scanning over today's updates in Linus's tree, I noticed > the following commit has no changes, and this does not appear > to be intentional. Interesting. You're right, I didn't notice. Git shouldn't even allow such commits to be generated, al

suspicious ALSA empty commit

2007-10-16 Thread David Miller
While scanning over today's updates in Linus's tree, I noticed the following commit has no changes, and this does not appear to be intentional. Someone should check it out. commit e31b6656a81d6332cdf6af17d38a0573128a6aac Author: Krzysztof Helt <[EMAIL PROTECTED]> Date: Tue Oct 16 14:54:58 2007