Hi,
On Wednesday, 16 of March 2005 00:39, Pavel Machek wrote:
> Hi!
>
> > > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> > >
> > > > diff -Nrup linux-2.6.11-bk10-a/arch/x86_64/kernel/suspend_asm.S
> > > > linux-2.6.11-bk10-b/arch/x86_64/kernel/suspend_asm.S
> > > > --- linux-2.6.11-
Hi!
> > > Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
> >
> > > diff -Nrup linux-2.6.11-bk10-a/arch/x86_64/kernel/suspend_asm.S
> > > linux-2.6.11-bk10-b/arch/x86_64/kernel/suspend_asm.S
> > > --- linux-2.6.11-bk10-a/arch/x86_64/kernel/suspend_asm.S 2005-03-15
> > > 09:20:53.0
On Tuesday, 15 of March 2005 21:46, Pavel Machek wrote:
> Hi!
>
> > > > > x86-64 needs this, too Otherwise it looks okay.
> > > >
> > > > It breaks compilation on i386 either, because nr_copy_pages_check
> > > > is static in swsusp.c. May I propose the following patch instead
> > > > (teste
Hi!
> > > > x86-64 needs this, too Otherwise it looks okay.
> > >
> > > It breaks compilation on i386 either, because nr_copy_pages_check
> > > is static in swsusp.c. May I propose the following patch instead (tested
> > > on
> > > x86-64 and i386)?
> >
> >
> > > +asmlinkage int __swsusp_
Hi,
On Tuesday, 15 of March 2005 13:02, Pavel Machek wrote:
> Hi!
>
> > > > > Please kill that swsusp_restore() call that itself calls
> > > > > flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
> > > > > arch specific, and that's all swsusp_restore() does. Then, the asm
> >
>
> > +asmlinkage int __swsusp_flush_tlb(void)
> > +{
> > + swsusp_restore_check();
>
> Someone will certainly forget this one, and it is probably
> nicer/easier to just move BUG_ON into swsusp_suspend(), just after
> restore_processor_state() or something like that...
Agreed.
Ben.
-
To uns
> It breaks compilation on i386 either, because nr_copy_pages_check
> is static in swsusp.c. May I propose the following patch instead (tested on
> x86-64 and i386)?
>
> Greets,
> Rafael
>
> Signed-off-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
>
> diff -Nrup linux-2.6.11-bk10-a/arch/i386/power
Hi!
> > > > Please kill that swsusp_restore() call that itself calls
> > > > flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
> > > > arch specific, and that's all swsusp_restore() does. Then, the asm just
> > > > calls this before returning to C code, so it makes no sense to
Hi,
On Tuesday, 15 of March 2005 12:03, Pavel Machek wrote:
> On Út 15-03-05 14:31:56, Benjamin Herrenschmidt wrote:
> > On Tue, 2005-03-15 at 14:24 +1100, Benjamin Herrenschmidt wrote:
> > > Hi Pavel !
> > >
> > > Please kill that swsusp_restore() call that itself calls
> > > flush_tlb_global(),
On Út 15-03-05 14:31:56, Benjamin Herrenschmidt wrote:
> On Tue, 2005-03-15 at 14:24 +1100, Benjamin Herrenschmidt wrote:
> > Hi Pavel !
> >
> > Please kill that swsusp_restore() call that itself calls
> > flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
> > arch specific, and
On Tue, 2005-03-15 at 14:24 +1100, Benjamin Herrenschmidt wrote:
> Hi Pavel !
>
> Please kill that swsusp_restore() call that itself calls
> flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
> arch specific, and that's all swsusp_restore() does. Then, the asm just
> calls this
Hi Pavel !
Please kill that swsusp_restore() call that itself calls
flush_tlb_global(), it's junk. First, the flush_tlb_global() thing is
arch specific, and that's all swsusp_restore() does. Then, the asm just
calls this before returning to C code, so it makes no sense to have a
hook there. The x8
12 matches
Mail list logo
