On Tue, Dec 03, 2013 at 05:15:43PM -0500, Tejun Heo wrote:
> Hello,
>
> Can you please test whether this patch makes the lockdep warning go
> away?
>
> Thanks a lot!
been running a few hours now, looks good.
Tested-by: Dave Jones
Dave
--
To unsubscribe from this list: send the
Hello,
Can you please test whether this patch makes the lockdep warning go
away?
Thanks a lot!
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index b94f936..fccb645 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -470,6 +470,9 @@ static int sysfs_bin_mmap(struct file *file, struct
vm_area
Hey,
On Tue, Dec 03, 2013 at 04:15:15PM -0500, Dave Jones wrote:
> > > Somehow I just triggered this trace again, even with this commit applied.
> > > The trace is pretty much identical to the old one.
> >
> > Hah, ain't that weird. That's the trace you reported on the other
> > mail, right
On Tue, Dec 03, 2013 at 04:10:28PM -0500, Tejun Heo wrote:
> Hello, Dave.
>
> On Tue, Dec 03, 2013 at 01:43:24PM -0500, Dave Jones wrote:
> > > + /*
> > > +* The following is done to give a different lockdep key to
> > > +* @of->mutex for files which implement mmap.
Hello, Dave.
On Tue, Dec 03, 2013 at 01:43:24PM -0500, Dave Jones wrote:
> > + /*
> > + * The following is done to give a different lockdep key to
> > + * @of->mutex for files which implement mmap. This is a rather
> > + * crude way to avoid false positive lockdep warning around
> > +
: Tejun Heo
> AuthorDate: Sun Nov 17 11:17:36 2013 +0900
> Committer: Greg Kroah-Hartman
> CommitDate: Sat Nov 23 10:52:13 2013 -0800
>
> sysfs: use a separate locking class for open files depending on mmap
>
> The following two commits implemen
>From 0a0e6b9eec8c8c1168b282150e9de43c2445f475 Mon Sep 17 00:00:00 2001
From: Tejun Heo
Date: Sun, 17 Nov 2013 11:17:36 +0900
The following two commits implemented mmap support in the regular file
path and merged bin file support into the regular path.
73d9714627ad ("sysfs: copy bin mmap suppor
On Sun, Nov 17, 2013 at 08:45:23PM -0800, Greg Kroah-Hartman wrote:
> On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote:
> > On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote:
> > > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote:
> > >
> > >
> > > > + if (has_mm
On Sun, Nov 17, 2013 at 12:29:37PM +0900, Tejun Heo wrote:
> On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote:
> > On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote:
> >
> >
> > > +if (has_mmap)
> > > +mutex_init(&of->mutex);
> > > +else
> >
On Sat, Nov 16, 2013 at 10:21:19PM -0500, Dave Jones wrote:
> On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote:
>
>
> > + if (has_mmap)
> > + mutex_init(&of->mutex);
> > + else
> > + mutex_init(&of->mutex);
>
> ummm...
Supposed to look that way. It'll give two
On Sun, Nov 17, 2013 at 11:17:36AM +0900, Tejun Heo wrote:
> +if (has_mmap)
> +mutex_init(&of->mutex);
> +else
> +mutex_init(&of->mutex);
ummm...
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
The following two commits implemented mmap support in the regular file
path and merged bin file support into the regular path.
73d9714627ad ("sysfs: copy bin mmap support from fs/sysfs/bin.c to
fs/sysfs/file.c")
3124eb1679b2 ("sysfs: merge regular and bin file handling")
After the merge, the f
12 matches
Mail list logo
