Re: systemtap broken by removal of register_timer_hook

2013-05-06 Thread Frederic Weisbecker
On Tue, Apr 30, 2013 at 01:27:20PM -0400, Frank Ch. Eigler wrote: > Hi - > > > [...] How about creating trace_tick() in > > include/trace/events/timer.h and call it from tick_periodic() and > > tick_sched_handle(). [...] > > Like this? > > > From facee64445c0dcc717e99c474c5c7dcdd31b9a74 Mon Se

Re: systemtap broken by removal of register_timer_hook

2013-04-30 Thread Frank Ch. Eigler
Hi - > [...] How about creating trace_tick() in > include/trace/events/timer.h and call it from tick_periodic() and > tick_sched_handle(). [...] Like this? >From facee64445c0dcc717e99c474c5c7dcdd31b9a74 Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Wed, 3 Apr 2013 10:35:21 -0400 Sub

Re: systemtap broken by removal of register_timer_hook

2013-04-29 Thread Frederic Weisbecker
On Fri, Apr 19, 2013 at 10:46:55AM -0400, Frank Ch. Eigler wrote: > Hi, Frederic - > > > > > How about this? > > > > > > Author: Frank Ch. Eigler > > > Date: Wed Apr 3 10:35:21 2013 -0400 > > > > > > profiling: add profile_tick tracepoint > > > [...] > > > It would be better not to tie th

Re: systemtap broken by removal of register_timer_hook

2013-04-19 Thread Frank Ch. Eigler
Hi, Frederic - > > How about this? > > > > Author: Frank Ch. Eigler > > Date: Wed Apr 3 10:35:21 2013 -0400 > > > > profiling: add profile_tick tracepoint > > [...] > It would be better not to tie this to CONFIG_PROFILING. > A tracepoint in update_process_times() instead would be great bu

Re: systemtap broken by removal of register_timer_hook

2013-04-10 Thread Ingo Molnar
* Frank Ch. Eigler wrote: > Hi - > > On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > > > Sounds good, would you like to propose a version? We are also > > interested in a timer tick event tracepoint for dynticks debugging. > > How about this? > > Author: Frank Ch. Eigl

Re: systemtap broken by removal of register_timer_hook

2013-04-04 Thread Frederic Weisbecker
2013/4/3 Frank Ch. Eigler : > Hi - > > On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > >> Sounds good, would you like to propose a version? We are also >> interested in a timer tick event tracepoint for dynticks debugging. > > How about this? > > Author: Frank Ch. Eigler > D

Re: systemtap broken by removal of register_timer_hook

2013-04-03 Thread Josh Stone
On 04/03/2013 07:44 AM, Frank Ch. Eigler wrote: > Hi - > > On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > >> Sounds good, would you like to propose a version? We are also >> interested in a timer tick event tracepoint for dynticks debugging. > > How about this? > > Autho

Re: systemtap broken by removal of register_timer_hook

2013-04-03 Thread Frank Ch. Eigler
Hi - On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > Sounds good, would you like to propose a version? We are also > interested in a timer tick event tracepoint for dynticks debugging. How about this? Author: Frank Ch. Eigler Date: Wed Apr 3 10:35:21 2013 -0400 pr

Re: systemtap broken by removal of register_timer_hook

2013-04-03 Thread Frederic Weisbecker
2013/4/3 Frank Ch. Eigler : > Frederic Weisbecker writes: > >> [...] >> Sometimes I don't mind keeping around code in the kernel for out of >> tree users, depending on the case. But in this specific matter we have >> more standard ways to do this kind of hook: kprobes, static >> tracepoints. A tra

Re: systemtap broken by removal of register_timer_hook

2013-04-03 Thread Frank Ch. Eigler
Frederic Weisbecker writes: > [...] > Sometimes I don't mind keeping around code in the kernel for out of > tree users, depending on the case. But in this specific matter we have > more standard ways to do this kind of hook: kprobes, static > tracepoints. A tracepoint on the timer tick would be u

Re: systemtap broken by removal of register_timer_hook

2013-04-03 Thread Frederic Weisbecker
2013/4/3 Mel Gorman : > Commit ba6fdda4 (profiling: Remove unused timer hook) removed > [un]register_timer_hook due to a lack of upstream users and a belief > that there were no out-of-tree users. However, systemtap uses it and > with that patch applied, some stap scripts fail with > > WARNING: "un

systemtap broken by removal of register_timer_hook

2013-04-03 Thread Mel Gorman
Commit ba6fdda4 (profiling: Remove unused timer hook) removed [un]register_timer_hook due to a lack of upstream users and a belief that there were no out-of-tree users. However, systemtap uses it and with that patch applied, some stap scripts fail with WARNING: "unregister_timer_hook" [/tmp/stapJ