Re: task_is_descendant() cleanup

2017-01-30 Thread Oleg Nesterov
On 01/25, Kees Cook wrote: > > On Mon, Jan 23, 2017 at 4:52 AM, Oleg Nesterov wrote: > > On 01/23, Oleg Nesterov wrote: > >> > >> Btw task_is_descendant() looks wrong at first glance. > > > > No, I missed the 2nd ->group_leader dereference. Still this function looks > >

Re: task_is_descendant() cleanup

2017-01-30 Thread Oleg Nesterov
On 01/25, Kees Cook wrote: > > On Mon, Jan 23, 2017 at 4:52 AM, Oleg Nesterov wrote: > > On 01/23, Oleg Nesterov wrote: > >> > >> Btw task_is_descendant() looks wrong at first glance. > > > > No, I missed the 2nd ->group_leader dereference. Still this function looks > > overcomplicated and the

Re: task_is_descendant() cleanup

2017-01-25 Thread Kees Cook
On Mon, Jan 23, 2017 at 4:52 AM, Oleg Nesterov wrote: > On 01/23, Oleg Nesterov wrote: >> >> Btw task_is_descendant() looks wrong at first glance. > > No, I missed the 2nd ->group_leader dereference. Still this function looks > overcomplicated and the usage of

Re: task_is_descendant() cleanup

2017-01-25 Thread Kees Cook
On Mon, Jan 23, 2017 at 4:52 AM, Oleg Nesterov wrote: > On 01/23, Oleg Nesterov wrote: >> >> Btw task_is_descendant() looks wrong at first glance. > > No, I missed the 2nd ->group_leader dereference. Still this function looks > overcomplicated and the usage of thread_group_leader/group_leader

task_is_descendant() cleanup

2017-01-23 Thread Oleg Nesterov
On 01/23, Oleg Nesterov wrote: > > Btw task_is_descendant() looks wrong at first glance. No, I missed the 2nd ->group_leader dereference. Still this function looks overcomplicated and the usage of thread_group_leader/group_leader just add the unnecessary confusion. It can be simplified a little

task_is_descendant() cleanup

2017-01-23 Thread Oleg Nesterov
On 01/23, Oleg Nesterov wrote: > > Btw task_is_descendant() looks wrong at first glance. No, I missed the 2nd ->group_leader dereference. Still this function looks overcomplicated and the usage of thread_group_leader/group_leader just add the unnecessary confusion. It can be simplified a little