Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-14 Thread Markus Elfring
> This is coding style for newly submitted code. > > We do not refactor code to the latest coding style, this would cost a lot. Were any update candidates left over also in this function implementation? >> How do you think about to return an error code like “-ENOMEM” at this place? > >

Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-14 Thread Eric Dumazet
On Mon, Oct 14, 2019 at 5:51 AM Markus Elfring wrote: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306 > https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306 >

Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-14 Thread Markus Elfring
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306 https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306 … >> Can an other error reporting approach be nicer here? > >

Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-14 Thread Eric Dumazet
On 10/13/19 11:51 PM, Markus Elfring wrote: >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306 >>> https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306 > … >> Presumably

Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-14 Thread Markus Elfring
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv4/tcp_minisocks.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n306 >> https://elixir.bootlin.com/linux/v5.4-rc2/source/net/ipv4/tcp_minisocks.c#L306 … > Presumably the BUG would trigger if a really disturbing bug

Re: tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-13 Thread Eric Dumazet
On 10/12/19 7:51 AM, Markus Elfring wrote: > Hello, > > I tried another script for the semantic patch language out. > This source code analysis approach points out that the implementation > of the function “tcp_time_wait” contains also a call of the function > “kmemdup”. >

tcp: Checking a kmemdup() call in tcp_time_wait()

2019-10-12 Thread Markus Elfring
Hello, I tried another script for the semantic patch language out. This source code analysis approach points out that the implementation of the function “tcp_time_wait” contains also a call of the function “kmemdup”.