Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Harald Welte wrote: > > well... the 'true library' doesn't make sense, because of the exclusiveness. > In any case there's only one instance of ip_fw_compat inside the kernel: The patch looks fine, and thanks for the commentary on why it was done this way. The other

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Harald Welte
On Sat, Dec 16, 2000 at 11:57:05AM +0100, Harald Welte wrote: > > As no other netfilter core team member responded yet, I'm going to provide > a patch for the 'true library' solution. well... the 'true library' doesn't make sense, because of the exclusiveness. In any case there's only one

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Harald Welte
On Sat, Dec 16, 2000 at 12:42:53AM -0800, Linus Torvalds wrote: > > - the DRM "true library" solution, as shown by drivers/char/drm/Makefile. > >This is closest to what the code tried to do before, and might be the >right solution for the "ip_nf_compat" module. However, it does result

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Barry K. Nathan
Linus Torvalds wrote: > Does that work for you? It compiles in the module case [note: I haven't been doing a modules_install or actually testing the results of my compiles] but it gives tons of errors in the in-kernel case (these might be word-wrapped in silly places, but it should give you the

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Linus Torvalds wrote: > > So "ip_nf_compat-objs" should really just be > > ip_nf_compat-objs := ip_fw_compat.o ip_fw_compat_redir.o ip_fw_compat_masq.o > > which looks much saner at least for the built-in case (ie no duplicate > object files in the multi-lists, and

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Barry K. Nathan wrote: > > Ok, I tried that, and I tried Andrew Morton's patch as well. Both patches > fix the module case, but not the in-kernel case. With Linus' patch, the > in-kernel case fails with the error message in my previous mail. Ok, the guy who made the

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Barry K. Nathan
Linus Torvalds wrote: > In article <[EMAIL PROTECTED]>, > Barry K. Nathan <[EMAIL PROTECTED]> wrote: > >I got the same error with the ipchains-compatible netfilter compiled as > >modules. Compiling into the kernel instead, I also get an error. I've > >included the error and my .config below. > >

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Harald Welte
On Sat, Dec 16, 2000 at 12:42:53AM -0800, Linus Torvalds wrote: - the DRM "true library" solution, as shown by drivers/char/drm/Makefile. This is closest to what the code tried to do before, and might be the right solution for the "ip_nf_compat" module. However, it does result

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Harald Welte
On Sat, Dec 16, 2000 at 11:57:05AM +0100, Harald Welte wrote: As no other netfilter core team member responded yet, I'm going to provide a patch for the 'true library' solution. well... the 'true library' doesn't make sense, because of the exclusiveness. In any case there's only one

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Harald Welte wrote: well... the 'true library' doesn't make sense, because of the exclusiveness. In any case there's only one instance of ip_fw_compat inside the kernel: The patch looks fine, and thanks for the commentary on why it was done this way. The other module

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Barry K. Nathan
Linus Torvalds wrote: In article [EMAIL PROTECTED], Barry K. Nathan [EMAIL PROTECTED] wrote: I got the same error with the ipchains-compatible netfilter compiled as modules. Compiling into the kernel instead, I also get an error. I've included the error and my .config below. Try removing

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Barry K. Nathan wrote: Ok, I tried that, and I tried Andrew Morton's patch as well. Both patches fix the module case, but not the in-kernel case. With Linus' patch, the in-kernel case fails with the error message in my previous mail. Ok, the guy who made the netfilter

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Linus Torvalds
On Sat, 16 Dec 2000, Linus Torvalds wrote: So "ip_nf_compat-objs" should really just be ip_nf_compat-objs := ip_fw_compat.o ip_fw_compat_redir.o ip_fw_compat_masq.o which looks much saner at least for the built-in case (ie no duplicate object files in the multi-lists, and the

Re: test13pre2 - netfilter modiles compile failure

2000-12-16 Thread Barry K. Nathan
Linus Torvalds wrote: Does that work for you? It compiles in the module case [note: I haven't been doing a modules_install or actually testing the results of my compiles] but it gives tons of errors in the in-kernel case (these might be word-wrapped in silly places, but it should give you the

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Andrew Morton
"Barry K. Nathan" wrote: > > I got the same error with the ipchains-compatible netfilter compiled as > modules. This works for me: --- linux-2.4.0-test13-pre2/net/ipv4/netfilter/Makefile Sat Dec 16 14:23:48 2000 +++ linux-akpm/net/ipv4/netfilter/Makefile Sat Dec 16 15:01:23 2000 @@ -61,6

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Linus Torvalds
In article <[EMAIL PROTECTED]>, Barry K. Nathan <[EMAIL PROTECTED]> wrote: >I got the same error with the ipchains-compatible netfilter compiled as >modules. Compiling into the kernel instead, I also get an error. I've >included the error and my .config below. Try removing "$(ip_conntrack-objs)

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Barry K. Nathan
I got the same error with the ipchains-compatible netfilter compiled as modules. Compiling into the kernel instead, I also get an error. I've included the error and my .config below. -Barry K. Nathan <[EMAIL PROTECTED]> ld -m elf_i386 -r -o netfilter.o ipchains.o ip_nf_compat.o ip_nf_compat.o:

test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Mohammad A. Haque
ld -m elf_i386 -r -o ip_nf_compat.o ipfwadm_core.o ip_fw_compat.o ip_fw_compat_redir.o ip_fw_compat_masq.o ip_conntrack_standalone.o ip_conntrack_core.o ip_conntrack_proto_generic.o ip_conntrack_proto_tcp.o ip_conntrack_proto_udp.o ip_conntrack_proto_icmp.o ip_nat_standalone.o ip_nat_rule.o

test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Mohammad A. Haque
ld -m elf_i386 -r -o ip_nf_compat.o ipfwadm_core.o ip_fw_compat.o ip_fw_compat_redir.o ip_fw_compat_masq.o ip_conntrack_standalone.o ip_conntrack_core.o ip_conntrack_proto_generic.o ip_conntrack_proto_tcp.o ip_conntrack_proto_udp.o ip_conntrack_proto_icmp.o ip_nat_standalone.o ip_nat_rule.o

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Barry K. Nathan
I got the same error with the ipchains-compatible netfilter compiled as modules. Compiling into the kernel instead, I also get an error. I've included the error and my .config below. -Barry K. Nathan [EMAIL PROTECTED] ld -m elf_i386 -r -o netfilter.o ipchains.o ip_nf_compat.o ip_nf_compat.o:

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Linus Torvalds
In article [EMAIL PROTECTED], Barry K. Nathan [EMAIL PROTECTED] wrote: I got the same error with the ipchains-compatible netfilter compiled as modules. Compiling into the kernel instead, I also get an error. I've included the error and my .config below. Try removing "$(ip_conntrack-objs)

Re: test13pre2 - netfilter modiles compile failure

2000-12-15 Thread Andrew Morton
"Barry K. Nathan" wrote: I got the same error with the ipchains-compatible netfilter compiled as modules. This works for me: --- linux-2.4.0-test13-pre2/net/ipv4/netfilter/Makefile Sat Dec 16 14:23:48 2000 +++ linux-akpm/net/ipv4/netfilter/Makefile Sat Dec 16 15:01:23 2000 @@ -61,6