Re: timing of module MODULE_STATE_COMING notifier

2015-09-01 Thread Rusty Russell
"Frank Ch. Eigler" writes: > Hi, Rusty - > > > I wrote: > >> [...] >> > Notifiers suck for stuff like this :( Module state has many steps, >> > so my preference has been to open-code explicit hooks. [...] >> >> You mean something like the trace_module_load()? (We will probably >> experiment wit

Re: timing of module MODULE_STATE_COMING notifier

2015-08-31 Thread Frank Ch. Eigler
Hi, Rusty - I wrote: > [...] > > Notifiers suck for stuff like this :( Module state has many steps, > > so my preference has been to open-code explicit hooks. [...] > > You mean something like the trace_module_load()? (We will probably > experiment with hooking into that tracepoint instead of

Re: timing of module MODULE_STATE_COMING notifier

2015-08-31 Thread Frank Ch. Eigler
Hi, Rusty - Thanks for your response! > [...] > > That patch also moved the MODULE_STATE_COMING notifier call to > > complete_formation(), which is relatively early to its former > > do_init_module() call site. It now precedes the parse_args(), > > mod_sysfs_setup(), and trace_module_load() step

Re: timing of module MODULE_STATE_COMING notifier

2015-08-30 Thread Rusty Russell
"Frank Ch. Eigler" writes: > Hi, Rusty - > > We just [1] came across your patch [2] from last year (merged into > 3.17), wherein the RO/NX mapping settings for module sections were > moved to an earlier point in the module-loading sequence. > > That patch also moved the MODULE_STATE_COMING notifie

timing of module MODULE_STATE_COMING notifier

2015-08-30 Thread Frank Ch. Eigler
Hi, Rusty - We just [1] came across your patch [2] from last year (merged into 3.17), wherein the RO/NX mapping settings for module sections were moved to an earlier point in the module-loading sequence. That patch also moved the MODULE_STATE_COMING notifier call to complete_formation(), which is