Re: tlb_finish_mmu() bogisity

2007-12-26 Thread Christoph Lameter
Argh. This is indeed bogus. The one reporting the problem states that the patch did not address the issue. The report was regarding pgd freeing which is handled slightly differently from pte frees. [PATCH] Revert quicklist need->flush fix Did not fix the reported issue. Apart from other

Re: tlb_finish_mmu() bogisity

2007-12-26 Thread Christoph Lameter
Argh. This is indeed bogus. The one reporting the problem states that the patch did not address the issue. The report was regarding pgd freeing which is handled slightly differently from pte frees. [PATCH] Revert quicklist need-flush fix Did not fix the reported issue. Apart from other

Re: tlb_finish_mmu() bogisity

2007-12-24 Thread Christoph Lameter
On Sun, 23 Dec 2007, Linus Torvalds wrote: > > What did you intend here? s/&//, perhaps? > > I think that thing is bogus in other ways. It plays games with > "needs_flush", just because it seems to want the generic code to then call > "check_pgt_cache()", not because it actually wants any

Re: tlb_finish_mmu() bogisity

2007-12-24 Thread Christoph Lameter
On Sun, 23 Dec 2007, Linus Torvalds wrote: What did you intend here? s///, perhaps? I think that thing is bogus in other ways. It plays games with needs_flush, just because it seems to want the generic code to then call check_pgt_cache(), not because it actually wants any flushing to

Re: tlb_finish_mmu() bogisity

2007-12-23 Thread Linus Torvalds
On Sun, 23 Dec 2007, Al Viro wrote: > > tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0; > makes no sense whatsoever. How the hell can you ever get the address of > __get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have > higher precedence than prefix

tlb_finish_mmu() bogisity

2007-12-23 Thread Al Viro
tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0; makes no sense whatsoever. How the hell can you ever get the address of __get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have higher precedence than prefix ones, so that's

tlb_finish_mmu() bogisity

2007-12-23 Thread Al Viro
tlb-need_flush += __get_cpu_var(quicklist)[0].nr_pages != 0; makes no sense whatsoever. How the hell can you ever get the address of __get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have higher precedence than prefix ones, so that's

Re: tlb_finish_mmu() bogisity

2007-12-23 Thread Linus Torvalds
On Sun, 23 Dec 2007, Al Viro wrote: tlb-need_flush += __get_cpu_var(quicklist)[0].nr_pages != 0; makes no sense whatsoever. How the hell can you ever get the address of __get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have higher precedence than prefix ones, so