Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

2013-11-04 Thread Romain Naour
Hi, Le 04/11/2013 23:20, Darren Hart a écrit : > I'm hardly an expert here, but the appears sane to me. Perhaps a > comment above the PYTHON_VERS describing what valid values are would > be helpful. Otherwise, looks good to me. Expected values are "python" and "python3" for PYTHON_VERS. trace-cm

Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

2013-11-04 Thread Darren Hart
I'm hardly an expert here, but the appears sane to me. Perhaps a comment above the PYTHON_VERS describing what valid values are would be helpful. Otherwise, looks good to me. On Mon, Nov 4, 2013 at 12:32 AM, Johannes Berg wrote: > On Fri, 2013-11-01 at 17:19 -0400, Steven Rostedt wrote: >> Please

Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

2013-11-04 Thread Johannes Berg
On Fri, 2013-11-01 at 17:19 -0400, Steven Rostedt wrote: > Please Cc me on trace-cmd patches. > > Johannes and Darren, > > Since you handle the python bindings in trace-cmd, can you give me an > ack or nack. Looks fine to me, in that it would work on my system :) johannes -- To unsubscribe fro

Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config

2013-11-01 Thread Steven Rostedt
Please Cc me on trace-cmd patches. Johannes and Darren, Since you handle the python bindings in trace-cmd, can you give me an ack or nack. Thanks! -- Steve On Thu, 31 Oct 2013 18:39:42 +0100 Romain Naour wrote: > From: Romain > > trace-cmd use python-config to find out which headers > and

[PATCH 1/1] trace-cmd: use pkg-config instead of python-config

2013-10-31 Thread Romain Naour
From: Romain trace-cmd use python-config to find out which headers and libraries should be used to link against the Python libraries. By default, python-config returns paths that are inappropriate for cross-compilation. Add PYTHON_VERS to build trace-cmd with python2 or python3 Signed-off-by: R

trace-cmd: use pkg-config instead of python-config

2013-10-28 Thread Romain Naour
trace-cmd use python-config to find out which headers and libraries should be used to link against the Python libraries. By default, python-config returns paths that are inappropriate for cross-compilation. Add PYTHON_VERS to build trace-cmd with python2 or python3 Signed-off-by: Romain Naour