On Thu, 8 Oct 2020 15:21:50 -0400
Steven Rostedt wrote:
> On Thu, 8 Oct 2020 18:22:07 +0900
> Masami Hiramatsu wrote:
>
> > Some of those issues are not introduced from this series. I think
> > we'd better fix those before introducing this series so that
> > we can backport it to stable kernels
Hi Masami,
On Thu, 2020-10-08 at 18:22 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Sun, 4 Oct 2020 17:14:06 -0500
> Tom Zanussi wrote:
>
> > Currently, sythetic events only support static string fields such
> > as:
> >
> > # echo 'test_latency u64 lat; char somename[32]' >
> > /sys/kern
On Thu, 8 Oct 2020 18:22:07 +0900
Masami Hiramatsu wrote:
> Some of those issues are not introduced from this series. I think
> we'd better fix those before introducing this series so that
> we can backport it to stable kernels.
I agree that these should be fixed, but I'm not sure I want to hold
Hi Tom,
On Sun, 4 Oct 2020 17:14:06 -0500
Tom Zanussi wrote:
> Currently, sythetic events only support static string fields such as:
>
> # echo 'test_latency u64 lat; char somename[32]' >
> /sys/kernel/debug/tracing/synthetic_events
>
> Which is fine, but wastes a lot of space in the event
owing commit in source
> > kernel/trace/trace_events_synth.c
> >
> > commit bd82631d7ccdc894af2738e47abcba2cb6e7dea9
> > Author: Tom Zanussi
> > Date: Sun Oct 4 17:14:06 2020 -0500
> >
> > tracing: Add support for dynamic strings to synthetic events
> &
trace/trace_events_synth.c
>>
>> commit bd82631d7ccdc894af2738e47abcba2cb6e7dea9
>> Author: Tom Zanussi
>> Date: Sun Oct 4 17:14:06 2020 -0500
>>
>> tracing: Add support for dynamic strings to synthetic events
>>
>> Analysis is as fol
6e7dea9
> Author: Tom Zanussi
> Date: Sun Oct 4 17:14:06 2020 -0500
>
> tracing: Add support for dynamic strings to synthetic events
>
> Analysis is as follows:
>
> 493for (i = 0; i < event->n_fields; i++) {
>
> Same on both sides (CONSTANT_EXPRES
dynamic strings to synthetic events
Analysis is as follows:
493for (i = 0; i < event->n_fields; i++) {
Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression: The expression event->fields[i]->is_dynamic &&
event->fields[i]->is_dynamic does not acco
From: Tom Zanussi
Currently, sythetic events only support static string fields such as:
# echo 'test_latency u64 lat; char somename[32]' >
/sys/kernel/debug/tracing/synthetic_events
Which is fine, but wastes a lot of space in the event.
It also prevents the most commonly-defined strings in
Currently, sythetic events only support static string fields such as:
# echo 'test_latency u64 lat; char somename[32]' >
/sys/kernel/debug/tracing/synthetic_events
Which is fine, but wastes a lot of space in the event.
It also prevents the most commonly-defined strings in the existing
trace e
Hi Masami,
On Fri, 2020-10-02 at 16:17 +0900, Masami Hiramatsu wrote:
> Hi Tom,
>
> On Wed, 30 Sep 2020 13:40:52 -0500
> Tom Zanussi wrote:
>
> > Currently, sythetic events only support static string fields such
> > as:
> >
> > # echo 'test_latency u64 lat; char somename[32]' >
> > /sys/kern
Hi Tom,
On Wed, 30 Sep 2020 13:40:52 -0500
Tom Zanussi wrote:
> Currently, sythetic events only support static string fields such as:
>
> # echo 'test_latency u64 lat; char somename[32]' >
> /sys/kernel/debug/tracing/synthetic_events
>
> Which is fine, but wastes a lot of space in the event
Currently, sythetic events only support static string fields such as:
# echo 'test_latency u64 lat; char somename[32]' >
/sys/kernel/debug/tracing/synthetic_events
Which is fine, but wastes a lot of space in the event.
It also prevents the most commonly-defined strings in the existing
trace e
Currently, sythetic events only support static string fields such as:
# echo 'test_latency u64 lat; char somename[32]' >
/sys/kernel/debug/tracing/synthetic_events
Which is fine, but wastes a lot of space in the event.
It also prevents the most commonly-defined strings in the existing
trace e
On Tue, 29 Sep 2020 15:01:59 -0700
Axel Rasmussen wrote:
> > event->fields[i]->offset = n_u64;
> >
> > - if (event->fields[i]->is_string) {
> > + if (event->fields[i]->is_string &&
> > !event->fields[i]->is_dynamic) {
> > offset
On Tue, Sep 29, 2020 at 1:33 PM Tom Zanussi wrote:
>
> Currently, sythetic events only support static string fields such as:
>
> # echo 'test_latency u64 lat; char somename[32]' >
> /sys/kernel/debug/tracing/synthetic_events
>
> Which is fine, but wastes a lot of space in the event.
>
> It also
Currently, sythetic events only support static string fields such as:
# echo 'test_latency u64 lat; char somename[32]' >
/sys/kernel/debug/tracing/synthetic_events
Which is fine, but wastes a lot of space in the event.
It also prevents the most commonly-defined strings in the existing
trace e
17 matches
Mail list logo
