Re: tty->low_latency + irq context

2007-01-02 Thread Hollis Blanchard
On Tue, 2007-01-02 at 18:38 +, Alan wrote: > > with tty->low_latency set, but it doesn't AFAICS. One possibility > for > > deadlock is if the tty->buf.lock spinlock is taken on behalf of a > user > > process... > > The case to watch out for is > > flip_buffer_push -> ldisc -> driver

Re: tty->low_latency + irq context

2007-01-02 Thread Paul Fulghum
On Tue, 2007-01-02 at 11:17 -0600, Hollis Blanchard wrote: > On Tue, 2006-12-26 at 01:08 +0059, Jiri Slaby wrote: > > * Queue a push of the terminal flip buffers to the line discipline. > > This > > * function must not be called from IRQ context if tty->low_latency is > > set. > > >

Re: tty->low_latency + irq context

2007-01-02 Thread Paul Fulghum
Paul Fulghum wrote: With low_latency == 1, flush_to_ldisc() is deferred until the ISR is complete and the internal spinlock is released. Oops, I meant low_latency == 0 of course. -- Paul Fulghum Microgate Systems, Ltd. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: tty->low_latency + irq context

2007-01-02 Thread Alan
> with tty->low_latency set, but it doesn't AFAICS. One possibility for > deadlock is if the tty->buf.lock spinlock is taken on behalf of a user > process... The case to watch out for is flip_buffer_push -> ldisc -> driver write of echo/^S/^Q if you call flip_buffer_push while holding

Re: tty->low_latency + irq context

2007-01-02 Thread Hollis Blanchard
On Tue, 2006-12-26 at 01:08 +0059, Jiri Slaby wrote: > Hi! > > * tty_flip_buffer_push- terminal > * @tty: tty to push > * > * Queue a push of the terminal flip buffers to the line discipline. This > * function must not be called from IRQ context if

Re: tty-low_latency + irq context

2007-01-02 Thread Hollis Blanchard
On Tue, 2006-12-26 at 01:08 +0059, Jiri Slaby wrote: Hi! * tty_flip_buffer_push- terminal * @tty: tty to push * * Queue a push of the terminal flip buffers to the line discipline. This * function must not be called from IRQ context if tty-low_latency is

Re: tty-low_latency + irq context

2007-01-02 Thread Alan
with tty-low_latency set, but it doesn't AFAICS. One possibility for deadlock is if the tty-buf.lock spinlock is taken on behalf of a user process... The case to watch out for is flip_buffer_push - ldisc - driver write of echo/^S/^Q if you call flip_buffer_push while holding your own

Re: tty-low_latency + irq context

2007-01-02 Thread Paul Fulghum
Paul Fulghum wrote: With low_latency == 1, flush_to_ldisc() is deferred until the ISR is complete and the internal spinlock is released. Oops, I meant low_latency == 0 of course. -- Paul Fulghum Microgate Systems, Ltd. - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: tty-low_latency + irq context

2007-01-02 Thread Paul Fulghum
On Tue, 2007-01-02 at 11:17 -0600, Hollis Blanchard wrote: On Tue, 2006-12-26 at 01:08 +0059, Jiri Slaby wrote: * Queue a push of the terminal flip buffers to the line discipline. This * function must not be called from IRQ context if tty-low_latency is set. But some

Re: tty-low_latency + irq context

2007-01-02 Thread Hollis Blanchard
On Tue, 2007-01-02 at 18:38 +, Alan wrote: with tty-low_latency set, but it doesn't AFAICS. One possibility for deadlock is if the tty-buf.lock spinlock is taken on behalf of a user process... The case to watch out for is flip_buffer_push - ldisc - driver write of

tty->low_latency + irq context

2006-12-25 Thread Jiri Slaby
Hi! * tty_flip_buffer_push- terminal * @tty: tty to push * * Queue a push of the terminal flip buffers to the line discipline. This * function must not be called from IRQ context if tty->low_latency is set. But some drivers (mxser, nozomi, hvsi...) sets

tty-low_latency + irq context

2006-12-25 Thread Jiri Slaby
Hi! * tty_flip_buffer_push- terminal * @tty: tty to push * * Queue a push of the terminal flip buffers to the line discipline. This * function must not be called from IRQ context if tty-low_latency is set. But some drivers (mxser, nozomi, hvsi...) sets