Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-16 Thread Wesley Cheng
On 2/15/2021 5:30 PM, Jung Daehwan wrote: > Hello, Alan > > On Mon, Feb 15, 2021 at 12:41:45PM -0500, Alan Stern wrote: >> On Mon, Feb 15, 2021 at 11:38:58AM +0900, Daehwan Jung wrote: >>> It seems pm_runtime_put calls runtime_idle callback not runtime_suspend >>> callback. >> >> How is this

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-16 Thread Alan Stern
On Tue, Feb 16, 2021 at 10:30:52AM +0900, Jung Daehwan wrote: > Hello, Alan > > On Mon, Feb 15, 2021 at 12:41:45PM -0500, Alan Stern wrote: > > On Mon, Feb 15, 2021 at 11:38:58AM +0900, Daehwan Jung wrote: > > > It seems pm_runtime_put calls runtime_idle callback not runtime_suspend > > >

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-15 Thread Jung Daehwan
Hello, Alan On Mon, Feb 15, 2021 at 12:41:45PM -0500, Alan Stern wrote: > On Mon, Feb 15, 2021 at 11:38:58AM +0900, Daehwan Jung wrote: > > It seems pm_runtime_put calls runtime_idle callback not runtime_suspend > > callback. > > How is this fact related to your patch? I think we should cause

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-15 Thread Alan Stern
On Mon, Feb 15, 2021 at 11:38:58AM +0900, Daehwan Jung wrote: > It seems pm_runtime_put calls runtime_idle callback not runtime_suspend > callback. How is this fact related to your patch? > It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend. Why do you think it is

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-14 Thread Sergei Shtylyov
Hello! On 15.02.2021 5:38, Daehwan Jung wrote: It seems pm_runtime_put calls runtime_idle callback not runtime_suspend callback. It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend. Signed-off-by: Daehwan Jung --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed,

usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-14 Thread Daehwan Jung
It seems pm_runtime_put calls runtime_idle callback not runtime_suspend callback. It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend. Signed-off-by: Daehwan Jung --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git