Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Rafael J. Wysocki
On 5/8/2013 6:32 PM, Konrad Rzeszutek Wilk wrote: On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: [ … snip some funky BIOS code ] [here it shifts and continues on testing each CPU bit] Questions over que

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Toshi Kani
On Wed, 2013-05-08 at 14:42 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, May 08, 2013 at 12:19:45PM -0600, Toshi Kani wrote: > > On Wed, 2013-05-08 at 12:32 -0400, Konrad Rzeszutek Wilk wrote: > > > On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: > > > > On Wed, May 08, 2013 at 10

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Konrad Rzeszutek Wilk
On Wed, May 08, 2013 at 12:19:45PM -0600, Toshi Kani wrote: > On Wed, 2013-05-08 at 12:32 -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: > > > On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: > > > > > > [ … snip some

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Toshi Kani
On Wed, 2013-05-08 at 12:32 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: > > On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: > > > > [ … snip some funky BIOS code ] > > > > > [here it shifts and continues on testing

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Konrad Rzeszutek Wilk
On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: > On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: > > [ … snip some funky BIOS code ] > > > [here it shifts and continues on testing each CPU bit] > > > > > Questions over questions...? > > > > I probably we

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Konrad Rzeszutek Wilk
> > > > > > The comment for calling save_mc_for_early says: > > > > Looks like save_mc_for_early would need another, local mutex to fix that. > > Let me try that. Thanks for the suggestion. Looks to work nicely. Just posted a patch for this. > > > > -- > > Regards/Gruss, > > Boris. > > >

RE: [Xen-devel] v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Ross Philipson
ernel.org; > linux-kernel@vger.kernel.org; mi...@redhat.com; h...@zytor.com; > t...@linutronix.de > Subject: Re: [Xen-devel] v3.9 - CPU hotplug and microcode earlier > loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex) > > On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzes

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread H. Peter Anvin
On 05/08/2013 07:29 AM, Borislav Petkov wrote: > On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: > > [ … snip some funky BIOS code ] > >> [here it shifts and continues on testing each CPU bit] >> >>> Questions over questions...? >> >> I probably went overboard with my answe

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Borislav Petkov
On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: [ … snip some funky BIOS code ] > [here it shifts and continues on testing each CPU bit] > > > Questions over questions...? > > I probably went overboard with my answers :-) Konrad, you're killing me! :-) You actually went

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Konrad Rzeszutek Wilk
On Wed, May 08, 2013 at 02:54:14PM +0200, Borislav Petkov wrote: > On Tue, May 07, 2013 at 03:00:24PM -0400, Konrad Rzeszutek Wilk wrote: > > I dug deeper in how QEMU does it and it looks to be actually doing > > the right thing. It triggers the ACPI SCI, the method that figures > > out the CPU onl

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-08 Thread Borislav Petkov
On Tue, May 07, 2013 at 03:00:24PM -0400, Konrad Rzeszutek Wilk wrote: > I dug deeper in how QEMU does it and it looks to be actually doing > the right thing. It triggers the ACPI SCI, the method that figures > out the CPU online/offline bits kicks off the right OSPM notification > and everything i

Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-07 Thread Konrad Rzeszutek Wilk
On Mon, May 06, 2013 at 08:59:37AM -0400, Konrad Rzeszutek Wilk wrote: > > Hey, > > As I was fixing the PV HVM's broken CPU hotplug mechanism I discovered > a deadlock in the microcode and generic code. > > I am not sure if the ACPI generic mechanism would expose this, but > looking at the flow

v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex)

2013-05-06 Thread Konrad Rzeszutek Wilk
Hey, As I was fixing the PV HVM's broken CPU hotplug mechanism I discovered a deadlock in the microcode and generic code. I am not sure if the ACPI generic mechanism would expose this, but looking at the flow (arch_register_cpu, then expecting user-space to call cpu_up), it should trigger this.