Re: vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-11 Thread James Simmons
> James has just posted a big patch against this code, so you should > coordinate this with him. > > One point: you should have included linux/spinlock.h rather than > asm/spinlock.h. Obviously someone is already including this file, so > you can simply remove the #include altogether. I

Re: vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-11 Thread Andrew Morton
Yong Chi wrote: > > My first contribution to kernel =) Someone please look over this one > carefully =) That's a good patch. It is "obviously correct", it saves seven calls to __global_cli() for each \n-terminated write to the console and it fixes the death-with-dual-deadlock problem which

Re: vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-11 Thread Andrew Morton
Yong Chi wrote: My first contribution to kernel =) Someone please look over this one carefully =) That's a good patch. It is "obviously correct", it saves seven calls to __global_cli() for each \n-terminated write to the console and it fixes the death-with-dual-deadlock problem which

Re: vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-11 Thread James Simmons
James has just posted a big patch against this code, so you should coordinate this with him. One point: you should have included linux/spinlock.h rather than asm/spinlock.h. Obviously someone is already including this file, so you can simply remove the #include altogether. I already

vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-10 Thread Yong Chi
My first contribution to kernel =) Someone please look over this one carefully =) Thanks --- vgacon.c.bakTue Oct 10 13:50:09 2000 +++ vgacon.cTue Oct 10 14:48:06 2000 @@ -27,6 +27,9 @@ * flashing on RHS of screen during heavy console scrolling . * Oct 1996, Paul

vgaconsole driver SMP safe fix against linux-2.4.0-test9

2000-10-10 Thread Yong Chi
My first contribution to kernel =) Someone please look over this one carefully =) Thanks --- vgacon.c.bakTue Oct 10 13:50:09 2000 +++ vgacon.cTue Oct 10 14:48:06 2000 @@ -27,6 +27,9 @@ * flashing on RHS of screen during heavy console scrolling . * Oct 1996, Paul