[PATCH AUTOSEL 5.8 15/24] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 5.8 14/24] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 5.4 09/15] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 5.4 10/15] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 4.4 4/6] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 4.4 3/6] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 4.9 4/6] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 4.9 3/6] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 4.14 05/11] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

[PATCH AUTOSEL 4.19 07/12] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 4.14 06/11] via-rhine: VTunknown1 device is really VT8251 South Bridge

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit aa15190cf2cf25ec7e6c6d7373ae3ca563d48601 ] The VIA Technologies VT8251 South Bridge's integrated Rhine-II Ethernet MAC comes has a PCI revision value of 0x7c. This was verified on ASUS P5V800-VM mainboard. Signed-off-by: Kevin Brace Signed-off-by: David S.

[PATCH AUTOSEL 4.19 06/12] via-rhine: Fix for the hardware having a reset failure after resume

2020-10-12 Thread Sasha Levin
From: Kevin Brace [ Upstream commit d120c9a81e32c43cba8017dec873b6a414898716 ] In rhine_resume() and rhine_suspend(), the code calls netif_running() to see if the network interface is down or not. If it is down (i.e., netif_running() returning false), they will skip any housekeeping work within

Re: [PATCH net-next] via-rhine: use devm_platform_ioremap_resource() to simplify code

2019-08-21 Thread David Miller
From: YueHaibing Date: Wed, 21 Aug 2019 20:50:50 +0800 > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Applied.

[PATCH net-next] via-rhine: use devm_platform_ioremap_resource() to simplify code

2019-08-21 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/net/ethernet/via/via-rhine.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/via/via-rhine.c

Re: [PATCH] net: via: via-rhine: use %p to format void * address instead of %x

2017-11-29 Thread David Miller
From: Colin King Date: Wed, 29 Nov 2017 14:11:49 + > From: Colin Ian King > > Don't use %x and casting to print out an address, instead use %p > and remove the casting. Cleans up smatch warnings: > > drivers/net/ethernet/via/via-rhine.c:998 rhine_init_one_common() > warn: argument 4 to %l

[PATCH] net: via: via-rhine: use %p to format void * address instead of %x

2017-11-29 Thread Colin King
From: Colin Ian King Don't use %x and casting to print out an address, instead use %p and remove the casting. Cleans up smatch warnings: drivers/net/ethernet/via/via-rhine.c:998 rhine_init_one_common() warn: argument 4 to %lx specifier is cast from pointer Signed-off-by: Colin Ian King --- d

Re: [PATCH] via-rhine: add support for changing MTU

2017-06-14 Thread David Miller
From: Magnus Damm Date: Wed, 14 Jun 2017 15:02:30 +0900 > Will update the code with the TX alignment workaround and resend after > some much needed testing. It will most likely take some time, so > please don't block anything on this. Thank you.

Re: [PATCH] via-rhine: add support for changing MTU

2017-06-13 Thread Magnus Damm
On Wed, Jun 14, 2017 at 6:33 AM, David Miller wrote: > From: Magnus Damm > Date: Wed, 14 Jun 2017 02:18:27 +0900 > >> From: Magnus Damm >> >> Allow adjusting the MTU for via-rhine devices in case of no TX alignment >> buffer is used. >> >> Lightly

Re: [PATCH] via-rhine: add support for changing MTU

2017-06-13 Thread David Miller
From: Magnus Damm Date: Wed, 14 Jun 2017 02:18:27 +0900 > From: Magnus Damm > > Allow adjusting the MTU for via-rhine devices in case of no TX alignment > buffer is used. > > Lightly tested on ALIX2D13 hardware by making use of VXLAN with MTU set > to 1500 on top of v

[PATCH] via-rhine: add support for changing MTU

2017-06-13 Thread Magnus Damm
From: Magnus Damm Allow adjusting the MTU for via-rhine devices in case of no TX alignment buffer is used. Lightly tested on ALIX2D13 hardware by making use of VXLAN with MTU set to 1500 on top of via-rhine devices with 1550 MTU. Without this patch the VXLAN MTU is limited to less than 1500

Re: [PATCH] net: via: via-rhine: use new api ethtool_{get|set}_link_ksettings

2017-03-12 Thread David Miller
From: Philippe Reynes Date: Tue, 7 Mar 2017 23:46:16 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

[PATCH] net: via: via-rhine: use new api ethtool_{get|set}_link_ksettings

2017-03-07 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/via/via-rhine.c | 14 -- 1 files cha

[PATCH 4.2 37/61] via-rhine: fix VLAN receive handling regression.

2015-12-12 Thread Greg Kroah-Hartman
rhine_rx_vlan_tag() no longer works as it's reading from an invalid offset. Tested to be working on PCEngines Alix board. Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.") Signed-off-by: Andrej Ota Acked-by: Francois Romieu Signed-off-by: David S. Mil

Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x

2015-10-06 Thread Francois Romieu
Andrej Ota : > Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in > vlan receive code.") which broke VLAN tag parsing on receive. > > Because eth_type_trans() consumes ethernet header worth of bytes, a call > to read TCI from packet using rhine_rx_v

[PATCH] via-rhine: fix VLAN receive handling error in 4.2.x

2015-10-04 Thread Andrej Ota
Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.") which broke VLAN tag parsing on receive. Because eth_type_trans() consumes ethernet header worth of bytes, a call to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's

Re: via-rhine: fix VLAN receive handling error in 4.2.x

2015-10-03 Thread Francois Romieu
Andrej : [...] > Choosing between changing rhine_get_vlan_tci(), which retrieves TCI from > skb->data, or moving eth_type_trans() invocation after rhine_rx_vlan_tag(), > I chose the latter. Can you send a patch with a proper Signed-off-by and a single line 'Fixes: 810f19bcb862

via-rhine: fix VLAN receive handling error in 4.2.x

2015-10-03 Thread Andrej
Hi, via-rhine driver in 4.2.x kernels doesn’t correctly parse VLAN ID on receive. A bug was introduced in the commit 810f19bcb862f8889b27e0c9d9eceac9593925dd. All 4.2.x kernels are affected. 4.1.x and older kernels are not affected. During code refactoring, the sequence of calls changed which

[PATCH] net: via-rhine: remove unneeded include file

2015-06-17 Thread Antonio Borneo
Signed-off-by: Antonio Borneo --- drivers/net/ethernet/via/via-rhine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index de28504..a1aaf3a 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethern

[PATCH 15/16 linux-next] net: via-rhine: constify of_device_id array

2015-03-17 Thread Fabian Frederick
of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick --- drivers/net/ethernet/via/via-rhine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/

[PATCH 20/25] via-rhine: Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Benoit Taine
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by: Benoit Taine --- Tested by compilation without errors. drivers/net/ethernet/via/via-rhine.c |2 +- 1 file changed, 1 insertio

Re: [PATCH] net: via-rhine: Convert #ifdef USE_MMIO to a runtime flag

2014-05-05 Thread David Miller
From: Alexey Charkov Date: Sat, 3 May 2014 16:40:53 +0400 > This introduces another flag in 'quirks' to replace the preprocessor > define (USE_MMIO) used to indicate whether the device needs a > separate enable routine to operate in MMIO mode. > > All of the currently known platform Rhine cores

[PATCH] net: via-rhine: Convert #ifdef USE_MMIO to a runtime flag

2014-05-03 Thread Alexey Charkov
ld Becker"; -/* This driver was written to use PCI memory space. Some early versions - of the Rhine may only work correctly with I/O space accesses. */ -#ifdef CONFIG_VIA_RHINE_MMIO -#define USE_MMIO -#else -#endif - MODULE_AUTHOR("Donald Becker "); MODULE_DESCRIPTION("VI

Re: [PATCH] net: via-rhine: Drop revision property, use quirks instead

2014-05-02 Thread David Miller
revision = (u32)match->data; > ^ > > That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 > ("net: via-rhine: add OF bus binding"). > > Tested in platform configuration on a VIA WM8950 APC Rock board. > > Reported-by: Jan Moskyto Matejka > Signed-off-by: Alexey Charkov This looks a lot better, applied, thanks.

Re: [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit

2014-05-01 Thread Alexey Charkov
2014-05-01 13:30 GMT+04:00 David Laight : > From: Alexey Charkov [mailto:alch...@gmail.com] > ... >> This patch removes the cast altogether, and instead stores an actual >> pointer to u8 in match->data. All instances of 'revision' are also >> unified to u8 instead of an assortment of different inte

RE: [PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit

2014-05-01 Thread David Laight
From: Alexey Charkov [mailto:alch...@gmail.com] ... > This patch removes the cast altogether, and instead stores an actual > pointer to u8 in match->data. All instances of 'revision' are also > unified to u8 instead of an assortment of different integer types, > in line with the definition of 'revi

[PATCH] net: via-rhine: Drop revision property, use quirks instead

2014-04-30 Thread Alexey Charkov
‘rhine_init_one_platform’: drivers/net/ethernet/via/via-rhine.c:1132:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] revision = (u32)match->data; ^ That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 ("net: v

[PATCH] net: via-rhine: Fix compiler warning re: pointer casting on 64bit

2014-04-30 Thread Alexey Charkov
ata; ^ That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 ("net: via-rhine: add OF bus binding"). This patch removes the cast altogether, and instead stores an actual pointer to u8 in match->data. All instances of 'revision' are also u

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
> > Also thanks for suggesting (void*)->(unsigned long), I didn't > > know that these two are defined to have the same size (in kernel code). > > The kernel assumes that throughout - the double cast is common. > The C99 type is uintptr_t - but I don't think that is defined in kernel. > The only pl

RE: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread David Laight
From: Jan Moskyto Matejka > > > So why not just: > > > revision = (unsigned long)match->data; > > > and add a comment that the 0x84 is the revision - #define ?? > > > > There is no particular reason why it should be u32 now - this is a > > leftover from the previous iteration of code where

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Jan Moskyto Matejka
> > So why not just: > > revision = (unsigned long)match->data; > > and add a comment that the 0x84 is the revision - #define ?? > > There is no particular reason why it should be u32 now - this is a > leftover from the previous iteration of code where revision was a > separate property in

RE: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread David Laight
platform: > >> drivers/net/ethernet/via/via-rhine.c:1132:13: warning: cast from > >> pointer to integer of different > >> size [-Wpointer-to-int-cast] > >> revision = (u32)match->data; > >>^ > >> > &g

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread Alexey Charkov
st from >> pointer to integer of different >> size [-Wpointer-to-int-cast] >> revision = (u32)match->data; >>^ >> >> That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 >> ("net: via-rhine: add OF bus

RE: [PATCH] net: via-rhine: fix compiler warning

2014-04-30 Thread David Laight
-Wpointer-to-int-cast] > revision = (u32)match->data; >^ > > That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 > ("net: via-rhine: add OF bus binding"). ... > diff --git a/drivers/net/ethernet/via/via-rhine.c > b/driver

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
On Tue, Apr 29, 2014 at 10:09:01PM +0400, Alexey Charkov wrote: > 2014-04-29 21:36 GMT+04:00 Jan Moskyto Matejka : > > Fixed different size cast warning: > > > > drivers/net/ethernet/via/via-rhine.c: In function > > ‘rhine_init_one_platform’: > > drivers/net/ethernet/via/via-rhine.

Re: [PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Alexey Charkov
of different size [-Wpointer-to-int-cast] > revision = (u32)match->data; > ^ > > That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 > ("net: via-rhine: add OF bus binding"). > > Signed-off-by: Jan Moskyto Matejka Jan,

[PATCH] net: via-rhine: fix compiler warning

2014-04-29 Thread Jan Moskyto Matejka
ata; ^ That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765 ("net: via-rhine: add OF bus binding"). Signed-off-by: Jan Moskyto Matejka --- drivers/net/ethernet/via/via-rhine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 0/3] net: via-rhine: add support for on-chip Rhine controllers

2014-04-23 Thread David Miller
From: Alexey Charkov Date: Tue, 22 Apr 2014 19:28:06 +0400 > This series introduces platform bus (OpenFirmware) binding for > via-rhine, as used in various ARM-based Systems-on-Chip by > VIA/WonderMedia. > > This has been tested in OF configuration by myself on a WM8950-based

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-04-22 Thread Rob Herring
On Tue, Apr 22, 2014 at 10:28 AM, Alexey Charkov wrote: > This should make the driver usable with VIA/WonderMedia ARM-based > Systems-on-Chip integrated Rhine III adapters. Note that these > are always in MMIO mode, and don't have any known EEPROM. > > Signed-off-by: Alexey Charkov For the bindi

[PATCH 1/3] net: via-rhine: switch to generic DMA functions

2014-04-22 Thread Alexey Charkov
Remove legacy PCI DMA wrappers and instead use generic DMA functions directly in preparation for OF bus binding Signed-off-by: Alexey Charkov --- drivers/net/ethernet/via/via-rhine.c | 84 ++-- 1 file changed, 43 insertions(+), 41 deletions(-) diff --git a/driver

[PATCH 2/3] net: via-rhine: reduce usage of the PCI-specific struct

2014-04-22 Thread Alexey Charkov
Use more generic data structures instead of struct pci_dev wherever possible in preparation for OF bus binding Signed-off-by: Alexey Charkov --- drivers/net/ethernet/via/via-rhine.c | 116 +++ 1 file changed, 62 insertions(+), 54 deletions(-) diff --git a/drivers

[PATCH 3/3] net: via-rhine: add OF bus binding

2014-04-22 Thread Alexey Charkov
4eca2 --- /dev/null +++ b/Documentation/devicetree/bindings/net/via-rhine.txt @@ -0,0 +1,17 @@ +* VIA Rhine 10/100 Network Controller + +Required properties: +- compatible : Should be "via,vt8500-rhine" for integrated + Rhine controllers found in VIA VT8500, WonderMedia WM8950 +

[PATCH v2 0/3] net: via-rhine: add support for on-chip Rhine controllers

2014-04-22 Thread Alexey Charkov
This series introduces platform bus (OpenFirmware) binding for via-rhine, as used in various ARM-based Systems-on-Chip by VIA/WonderMedia. This has been tested in OF configuration by myself on a WM8950-based VIA APC Rock development board and on a WM8850-based netbook, and in PCI configuration

[PATCH 3.8 115/124] net,via-rhine: Fix tx_timeout handling

2014-02-10 Thread Kamal Mostafa
3.8.13.18 -stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger [ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ] rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is sti

[PATCH 3.11 216/233] net,via-rhine: Fix tx_timeout handling

2014-02-07 Thread Luis Henriques
3.11.10.4 -stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger commit a926592f5e4e900f3fa903298c4619a131e60963 upstream. rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still

[PATCH 3.5 83/88] net,via-rhine: Fix tx_timeout handling

2014-02-07 Thread Luis Henriques
3.5.7.30 -stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger commit a926592f5e4e900f3fa903298c4619a131e60963 upstream. rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still s

[PATCH 3.4 31/37] net,via-rhine: Fix tx_timeout handling

2014-02-04 Thread Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger [ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ] rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still sched

[PATCH 3.12 105/133] net,via-rhine: Fix tx_timeout handling

2014-02-04 Thread Greg Kroah-Hartman
3.12-stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger [ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ] rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still sche

[PATCH 3.10 078/104] net,via-rhine: Fix tx_timeout handling

2014-02-04 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Richard Weinberger [ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ] rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still sche

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-31 Thread Ben Hutchings
rivers/net/ethernet/via/Kconfig > >> >> +++ b/drivers/net/ethernet/via/Kconfig > >> >> @@ -19,7 +19,7 @@ if NET_VENDOR_VIA > >> >> > >> >> config VIA_RHINE > >> >> tristate "VIA Rhine support" > >> >> -

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-29 Thread Rob Herring
t; >>>>> diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt >>>>> b/Documentation/devicetree/bindings/net/via-rhine.txt >>>>> new file mode 100644 >>>>> index 000..684dd3a >>>>> --- /dev/null >>>>>

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-29 Thread Rob Herring
rhine.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt >>> b/Documentation/devicetree/bindings/net/via-rhine.txt >>> new file mode 100644 >>> index 000..684dd3a >>> --- /dev/null >>> +++ b/Documentation/de

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-28 Thread Alexey Charkov
files changed, 200 insertions(+), 113 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/net/via-rhine.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/via-rhine.txt >>>> b/Documentation/devicetree/bindings/n

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-28 Thread Tony Prisk
+++ b/Documentation/devicetree/bindings/net/via-rhine.txt @@ -0,0 +1,18 @@ +* VIA Rhine 10/100 Network Controller + +Required properties: +- compatible : Should be "via,rhine" This should be more specific rather than... +- reg : Address and length of the io space +- interrupts : Sho

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-28 Thread Alexey Charkov
;> Systems-on-Chip integrated Rhine III adapters. Note that these >> >> are always in MMIO mode, and don't have any known EEPROM. >> > [...] >> >> --- a/drivers/net/ethernet/via/Kconfig >> >> +++ b/drivers/net/ethernet/via/Kconfig >> >> @@

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-28 Thread Alexey Charkov
devicetree/bindings/net/via-rhine.txt >> new file mode 100644 >> index 000..684dd3a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/via-rhine.txt >> @@ -0,0 +1,18 @@ >> +* VIA Rhine 10/100 Network Controller >> + >> +Requir

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-27 Thread Ben Hutchings
s. Note that these > >> are always in MMIO mode, and don't have any known EEPROM. > > [...] > >> --- a/drivers/net/ethernet/via/Kconfig > >> +++ b/drivers/net/ethernet/via/Kconfig > >> @@ -19,7 +19,7 @@ if NET_VENDOR_VIA > >> > >

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-27 Thread Rob Herring
t; --- /dev/null > +++ b/Documentation/devicetree/bindings/net/via-rhine.txt > @@ -0,0 +1,18 @@ > +* VIA Rhine 10/100 Network Controller > + > +Required properties: > +- compatible : Should be "via,rhine" This should be more specific rather than... > +- reg : Addr

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-27 Thread Alexey Charkov
n EEPROM. > [...] >> --- a/drivers/net/ethernet/via/Kconfig >> +++ b/drivers/net/ethernet/via/Kconfig >> @@ -19,7 +19,7 @@ if NET_VENDOR_VIA >> >> config VIA_RHINE >> tristate "VIA Rhine support" >> - depends on PCI &g

Re: [PATCH 1/3] net: via-rhine: switch to generic DMA functions

2014-01-27 Thread Alexey Charkov
2014/1/27 Ben Hutchings : > On Mon, 2014-01-27 at 15:51 +0400, Alexey Charkov wrote: >> Remove legacy PCI DMA wrappers and instead use generic DMA functions >> directly in preparation for OF bus binding >> >> Signed-off-by: Alexey Charkov >> Signed-off-by: Roger Luethi >> --- >> drivers/net/ethe

Re: [PATCH 1/3] net: via-rhine: switch to generic DMA functions

2014-01-27 Thread Ben Hutchings
On Mon, 2014-01-27 at 19:26 +0400, Alexey Charkov wrote: > 2014/1/27 Ben Hutchings : > > On Mon, 2014-01-27 at 15:51 +0400, Alexey Charkov wrote: [...] > >> @@ -1094,20 +1094,22 @@ static int alloc_ring(struct net_device* dev) > >> void *ring; > >> dma_addr_t ring_dma; > >> > >> - r

Re: [PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-27 Thread Ben Hutchings
ernet/via/Kconfig > +++ b/drivers/net/ethernet/via/Kconfig > @@ -19,7 +19,7 @@ if NET_VENDOR_VIA > > config VIA_RHINE > tristate "VIA Rhine support" > - depends on PCI > + depends on (PCI || USE_OF) > select CRC32 > select MII

Re: [PATCH 1/3] net: via-rhine: switch to generic DMA functions

2014-01-27 Thread Ben Hutchings
On Mon, 2014-01-27 at 15:51 +0400, Alexey Charkov wrote: > Remove legacy PCI DMA wrappers and instead use generic DMA functions > directly in preparation for OF bus binding > > Signed-off-by: Alexey Charkov > Signed-off-by: Roger Luethi > --- > drivers/net/ethernet/via/via-rhine.c | 56 > +

[PATCH 3/3] net: via-rhine: add OF bus binding

2014-01-27 Thread Alexey Charkov
git a/Documentation/devicetree/bindings/net/via-rhine.txt b/Documentation/devicetree/bindings/net/via-rhine.txt new file mode 100644 index 000..684dd3a --- /dev/null +++ b/Documentation/devicetree/bindings/net/via-rhine.txt @@ -0,0 +1,18 @@ +* VIA Rhine 10/100 Network Controller + +Required prope

[PATCH 2/3] net: via-rhine: reduce usage of the PCI-specific struct

2014-01-27 Thread Alexey Charkov
Use more generic data structures instead of struct pci_dev wherever possible in preparation for OF bus binding Signed-off-by: Alexey Charkov Signed-off-by: Roger Luethi --- drivers/net/ethernet/via/via-rhine.c | 116 +++ 1 file changed, 62 insertions(+), 54 delet

[PATCH 1/3] net: via-rhine: switch to generic DMA functions

2014-01-27 Thread Alexey Charkov
Remove legacy PCI DMA wrappers and instead use generic DMA functions directly in preparation for OF bus binding Signed-off-by: Alexey Charkov Signed-off-by: Roger Luethi --- drivers/net/ethernet/via/via-rhine.c | 56 +++- 1 file changed, 29 insertions(+), 27 dele

[PATCH 0/3] Resubmit: net: via-rhine: add support for on-chip Rhine controllers

2014-01-27 Thread Alexey Charkov
This series introduces platform bus (OpenFirmware) binding for via-rhine, as used in various ARM-based Systems-on-Chip by VIA/WonderMedia. This has been tested in OF configuration by myself on a WM8950-based VIA APC Rock development board, and in PCI configuration by Roger. Unfortunately, I

Re: [PATCH] net,via-rhine: Fix tx_timeout handling

2014-01-15 Thread David Miller
From: Richard Weinberger Date: Tue, 14 Jan 2014 22:46:36 +0100 > rhine_reset_task() misses to disable the tx scheduler upon reset, > this can lead to a crash if work is still scheduled while we're resetting > the tx queue. > > Fixes: > [ 93.591707] BUG: unable to handle kernel NULL pointer der

[PATCH] net,via-rhine: Fix tx_timeout handling

2014-01-14 Thread Richard Weinberger
rhine_reset_task() misses to disable the tx scheduler upon reset, this can lead to a crash if work is still scheduled while we're resetting the tx queue. Fixes: [ 93.591707] BUG: unable to handle kernel NULL pointer dereference at 004c [ 93.595514] IP: [] rhine_napipoll+0x491/0x6 Signed-o

Re: [PATCH 0/3] net: via-rhine: add support for on-chip Rhine controllers

2013-11-30 Thread Alexey Charkov
2013/11/23, Alexey Charkov : > This series introduces platform bus (OpenFirmware) binding for via-rhine, > as used in various ARM-based Systems-on-Chip by VIA/WonderMedia. > > This has been tested on a WM8950-based VIA APC Rock development board > > Alexey Charkov (3): > n

[PATCH 3.8 49/81] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-29 Thread Kamal Mostafa
3.8.13.12 -stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled

[PATCH 3.2 108/149] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-21 Thread Ben Hutchings
3.2.52-rc1 review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled). The

[ 13/39] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-11 Thread Greg Kroah-Hartman
3.0-stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled). The

[ 14/48] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-11 Thread Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled). The

[ 031/110] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-11 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled). The

[ 036/135] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-11 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi [ Upstream commit 207070f5221e2a901d56a49df9cde47d9b716cd7 ] Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled). The

[PATCH 059/100] via-rhine: fix VLAN priority field (PCP, IEEE 802.1p)

2013-10-11 Thread Luis Henriques
3.5.7.23 -stable review patch. If anyone has any objections, please let me know. -- From: Roger Luethi commit 207070f5221e2a901d56a49df9cde47d9b716cd7 upstream. Outgoing packets sent by via-rhine have their VLAN PCP field off by one (when hardware acceleration is enabled

Re: [PATCH] via-rhine: Fix tx_timeout handling

2013-07-21 Thread Ben Hutchings
On Sun, 2013-07-21 at 18:32 +0200, Richard Weinberger wrote: > Am 21.07.2013 18:18, schrieb Ben Hutchings: > > On Fri, 2013-07-19 at 23:30 +0200, Richard Weinberger wrote: > >> rhine_reset_task() misses to call netif_stop_queue(), > >> this can lead to a crash if work is still scheduled while > >>

Re: [PATCH] via-rhine: Fix tx_timeout handling

2013-07-21 Thread Richard Weinberger
Am 21.07.2013 18:18, schrieb Ben Hutchings: > On Fri, 2013-07-19 at 23:30 +0200, Richard Weinberger wrote: >> rhine_reset_task() misses to call netif_stop_queue(), >> this can lead to a crash if work is still scheduled while >> we're resetting the tx queue. >> >> Fixes: >> [ 93.591707] BUG: unabl

Re: [PATCH] via-rhine: Fix tx_timeout handling

2013-07-21 Thread Ben Hutchings
On Fri, 2013-07-19 at 23:30 +0200, Richard Weinberger wrote: > rhine_reset_task() misses to call netif_stop_queue(), > this can lead to a crash if work is still scheduled while > we're resetting the tx queue. > > Fixes: > [ 93.591707] BUG: unable to handle kernel NULL pointer dereference at > 0

[PATCH] via-rhine: Fix tx_timeout handling

2013-07-19 Thread Richard Weinberger
rhine_reset_task() misses to call netif_stop_queue(), this can lead to a crash if work is still scheduled while we're resetting the tx queue. Fixes: [ 93.591707] BUG: unable to handle kernel NULL pointer dereference at 004c [ 93.595514] IP: [] rhine_napipoll+0x491/0x6e Signed-off-by: Rich

[PATCH 21/86] via-rhine: Fix bugs in NAPI support.

2013-03-26 Thread Steven Rostedt
3.6.11.1 stable review patch. If anyone has any objections, please let me know. -- From: "David S. Miller" [ Upstream commit 559bcac35facfed49ab4f408e162971612dcfdf3 ] 1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq() 2) rhine_slow_event_task's NAPI triggering l

[PATCH 57/81] via-rhine: Fix bugs in NAPI support.

2013-02-19 Thread Herton Ronaldo Krzesinski
3.5.7.6 -stable review patch. If anyone has any objections, please let me know. -- From: "David S. Miller" commit 559bcac35facfed49ab4f408e162971612dcfdf3 upstream. 1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq() 2) rhine_slow_event_task's NAPI triggering log

[ 35/61] via-rhine: Fix bugs in NAPI support.

2013-02-12 Thread Greg Kroah-Hartman
3.7-stable review patch. If anyone has any objections, please let me know. -- From: "David S. Miller" [ Upstream commit 559bcac35facfed49ab4f408e162971612dcfdf3 ] 1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq() 2) rhine_slow_event_task's NAPI triggering logi

[ 21/36] via-rhine: Fix bugs in NAPI support.

2013-02-12 Thread Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know. -- From: "David S. Miller" [ Upstream commit 559bcac35facfed49ab4f408e162971612dcfdf3 ] 1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq() 2) rhine_slow_event_task's NAPI triggering logi

Re: [OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Satyam Sharma
On Sun, 2 Sep 2007, Mark Hindley wrote: > > BUG: unable to handle kernel NULL pointer dereference at virtual address > 0025 > [...] > Call Trace: > [] tcp_rtt_estimator+0xba/0x100 > [...] > EIP: [] tcp_rto_min+0x8/0x12 SS:ESP 0068:c0341dec Third report of this oops within past

[OOPS] 2.6.23-rc5 ? network/via-rhine [was: hang with CONFIG_MCYRIXIII]

2007-09-02 Thread Mark Hindley
I have now got an oops trace out of this box, which I presume has been the cause of the previously observed hangs. To my inexperienced eye it looks like it is related to via-rhine. Thanks Mark BUG: unable to handle kernel NULL pointer dereference at virtual address 0025

[PATCH] [528/2many] MAINTAINERS - VIA RHINE NETWORK DRIVER

2007-08-13 Thread joe
Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 7e4fcce..23efbbc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4987,6 +4987,7 @@ VIA RHINE NETWORK DRIVER P: Roger Luethi M: [EMAIL PROTECT

Re: [BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez
[via_rhine] this is a case of homegrown locking: the via-rhine driver does /* protect against concurrent rx interrupts */ disable_irq(rp->pdev->irq); spin_lock(&rp->lock); /* clear all descriptors */ free_tbufs(dev); free_rbufs(de

Re: [BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Arjan van de Ven
x6f/0xf4 [via_rhine] this is a case of homegrown locking: the via-rhine driver does /* protect against concurrent rx interrupts */ disable_irq(rp->pdev->irq); spin_lock(&rp->lock); /* clear all descriptors */ free_tbufs(dev);

[BUG] ISIC + 2.6.22 (via-rhine)

2007-07-31 Thread Xose Vazquez Perez
-LK1.4.3 2007-03-06 Written by Donald Becker eth0: VIA Rhine II at 0xbc00, 00:11:d8:54:e9:3c, IRQ 19. eth0: MII PHY found at address 1, status 0x786d advertising 01e1 Link 45e1. eth0: link up, 100Mbps, full-duplex, lpa 0x45E1 eth0: no IPv6 routers present ---lspci-- 00:12.0 0200: 1106:3065 (rev

  1   2   >