Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-24 Thread Lai Jiangshan
On 07/23/2013 10:38 PM, Tejun Heo wrote: > Hey, Lai. > > On Tue, Jul 23, 2013 at 09:23:14AM +0800, Lai Jiangshan wrote: >> The problem is that the userS may not know their work_on_cpu() nested, >> especially when work_on_cpu()s are on different subsystems and the call depth >> is deep enough but t

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-23 Thread Tejun Heo
Hey, Lai. On Tue, Jul 23, 2013 at 09:23:14AM +0800, Lai Jiangshan wrote: > The problem is that the userS may not know their work_on_cpu() nested, > especially when work_on_cpu()s are on different subsystems and the call depth > is deep enough but the nested work_on_cpu() depends on some conditions

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Lai Jiangshan
On 07/23/2013 05:32 AM, Tejun Heo wrote: > On Mon, Jul 22, 2013 at 07:52:34PM +0800, Lai Jiangshan wrote: >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c >> index f02c4a4..b021a45 100644 >> --- a/kernel/workqueue.c >> +++ b/kernel/workqueue.c >> @@ -4731,6 +4731,7 @@ struct work_for_cpu { >

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Alexander Duyck
On 07/22/2013 02:38 PM, Bjorn Helgaas wrote: > [+cc Alex, Yinghai, linux-pci] > > On Mon, Jul 22, 2013 at 9:37 AM, Srivatsa S. Bhat > wrote: >> On 07/22/2013 05:22 PM, Lai Jiangshan wrote: >>> On 07/19/2013 04:57 PM, Srivatsa S. Bhat wrote: On 07/19/2013 07:17 AM, Lai Jiangshan wrote: > O

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Yinghai Lu
On Mon, Jul 22, 2013 at 2:38 PM, Bjorn Helgaas wrote: > [+cc Alex, Yinghai, linux-pci] > > Isn't this for the same issue Alex and others have been working on? yes. > > It doesn't feel like we have consensus on how this should be fixed. > You're proposing a change to work_on_cpu(), Alex proposed

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Bjorn Helgaas
[+cc Alex, Yinghai, linux-pci] On Mon, Jul 22, 2013 at 9:37 AM, Srivatsa S. Bhat wrote: > On 07/22/2013 05:22 PM, Lai Jiangshan wrote: >> On 07/19/2013 04:57 PM, Srivatsa S. Bhat wrote: >>> On 07/19/2013 07:17 AM, Lai Jiangshan wrote: On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: > >>>

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Tejun Heo
On Mon, Jul 22, 2013 at 07:52:34PM +0800, Lai Jiangshan wrote: > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index f02c4a4..b021a45 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -4731,6 +4731,7 @@ struct work_for_cpu { > long (*fn)(void *); > void *arg; >

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Srivatsa S. Bhat
On 07/22/2013 05:22 PM, Lai Jiangshan wrote: > On 07/19/2013 04:57 PM, Srivatsa S. Bhat wrote: >> On 07/19/2013 07:17 AM, Lai Jiangshan wrote: >>> On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: --- kernel/workqueue.c |6 ++ 1 file changed, 6 insertions(+) >>>

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-22 Thread Lai Jiangshan
On 07/19/2013 04:57 PM, Srivatsa S. Bhat wrote: > On 07/19/2013 07:17 AM, Lai Jiangshan wrote: >> On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: >>> >>> --- >>> >>> kernel/workqueue.c |6 ++ >>> 1 file changed, 6 insertions(+) >>> >>> >>> diff --git a/kernel/workqueue.c b/kernel/workqueue

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-19 Thread Srivatsa S. Bhat
On 07/19/2013 07:17 AM, Lai Jiangshan wrote: > On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: >> >> --- >> >> kernel/workqueue.c |6 ++ >> 1 file changed, 6 insertions(+) >> >> >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c >> index f02c4a4..07d9a67 100644 >> --- a/kernel/workque

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-18 Thread Lai Jiangshan
On 07/19/2013 04:23 AM, Srivatsa S. Bhat wrote: > > On 07/17/2013 03:37 PM, Lai Jiangshan wrote: >> On 07/16/2013 10:41 PM, Srivatsa S. Bhat wrote: >>> Hi, >>> >>> I have been seeing this warning every time during boot. I haven't >>> spent time digging through it though... Please let me know if >>

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-18 Thread Srivatsa S. Bhat
On 07/17/2013 03:37 PM, Lai Jiangshan wrote: > On 07/16/2013 10:41 PM, Srivatsa S. Bhat wrote: >> Hi, >> >> I have been seeing this warning every time during boot. I haven't >> spent time digging through it though... Please let me know if >> any machine-specific info is needed. >> >> Regards, >> S

Re: workqueue, pci: INFO: possible recursive locking detected

2013-07-17 Thread Lai Jiangshan
On 07/16/2013 10:41 PM, Srivatsa S. Bhat wrote: > Hi, > > I have been seeing this warning every time during boot. I haven't > spent time digging through it though... Please let me know if > any machine-specific info is needed. > > Regards, > Srivatsa S. Bhat > > > --

workqueue, pci: INFO: possible recursive locking detected

2013-07-16 Thread Srivatsa S. Bhat
Hi, I have been seeing this warning every time during boot. I haven't spent time digging through it though... Please let me know if any machine-specific info is needed. Regards, Srivatsa S. Bhat =