Re: x86: kdump failure

2008-01-18 Thread Roland McGrath
Oops, I overlooked the use of elf_core_copy_regs in kernel/kexec.c. It is certainly safe and fine to reintroduce the old macro. Everything removed in the "x86 user_regset cleanup" patch is purely removing code and it doesn't hurt to have it back (it's just all unused except for this kexec nit).

Re: x86: kdump failure

2008-01-18 Thread Subrata Modak
On Fri, 2008-01-18 at 10:02 +0100, Ingo Molnar wrote: > * Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote: > > > kdump needs ELF_CORE_COPY_REGS in crash_save_cpu(). This lack of the > > macro causes the following BUG. > > > > SysRq : Trigger a crashdump > > [ cut here ] > >

Re: x86: kdump failure

2008-01-18 Thread Ingo Molnar
* Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote: > kdump needs ELF_CORE_COPY_REGS in crash_save_cpu(). This lack of the > macro causes the following BUG. > > SysRq : Trigger a crashdump > [ cut here ] > kernel BUG at include/linux/elfcore.h:105! > invalid opcode: [1]

Re: x86: kdump failure

2008-01-18 Thread Ingo Molnar
* Hiroshi Shimamoto [EMAIL PROTECTED] wrote: kdump needs ELF_CORE_COPY_REGS in crash_save_cpu(). This lack of the macro causes the following BUG. SysRq : Trigger a crashdump [ cut here ] kernel BUG at include/linux/elfcore.h:105! invalid opcode: [1] PREEMPT

Re: x86: kdump failure

2008-01-18 Thread Subrata Modak
On Fri, 2008-01-18 at 10:02 +0100, Ingo Molnar wrote: * Hiroshi Shimamoto [EMAIL PROTECTED] wrote: kdump needs ELF_CORE_COPY_REGS in crash_save_cpu(). This lack of the macro causes the following BUG. SysRq : Trigger a crashdump [ cut here ] kernel BUG at

Re: x86: kdump failure

2008-01-18 Thread Roland McGrath
Oops, I overlooked the use of elf_core_copy_regs in kernel/kexec.c. It is certainly safe and fine to reintroduce the old macro. Everything removed in the x86 user_regset cleanup patch is purely removing code and it doesn't hurt to have it back (it's just all unused except for this kexec nit).

x86: kdump failure

2008-01-17 Thread Hiroshi Shimamoto
Hi Ingo, on recent x86.git kernel fails to kdump with following BUG. SysRq : Trigger a crashdump [ cut here ] kernel BUG at include/linux/elfcore.h:105! invalid opcode: [1] PREEMPT SMP In crash_save_cpu(), elf_core_copy_regs() is called and ELF_CORE_COPY_REGS macro

x86: kdump failure

2008-01-17 Thread Hiroshi Shimamoto
Hi Ingo, on recent x86.git kernel fails to kdump with following BUG. SysRq : Trigger a crashdump [ cut here ] kernel BUG at include/linux/elfcore.h:105! invalid opcode: [1] PREEMPT SMP In crash_save_cpu(), elf_core_copy_regs() is called and ELF_CORE_COPY_REGS macro