Re: xarray breaks thrashing detection and cgroup isolation

2019-05-24 Thread Shakeel Butt
On Fri, May 24, 2019 at 10:06 AM Johannes Weiner wrote: > > On Fri, May 24, 2019 at 09:11:46AM -0700, Matthew Wilcox wrote: > > On Thu, May 23, 2019 at 03:59:33PM -0400, Johannes Weiner wrote: > > > My point is that we cannot have random drivers' internal data > > > structures charge to and pin

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-24 Thread Johannes Weiner
On Fri, May 24, 2019 at 09:11:46AM -0700, Matthew Wilcox wrote: > On Thu, May 23, 2019 at 03:59:33PM -0400, Johannes Weiner wrote: > > My point is that we cannot have random drivers' internal data > > structures charge to and pin cgroups indefinitely just because they > > happen to do the

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-24 Thread Matthew Wilcox
On Thu, May 23, 2019 at 03:59:33PM -0400, Johannes Weiner wrote: > My point is that we cannot have random drivers' internal data > structures charge to and pin cgroups indefinitely just because they > happen to do the modprobing or otherwise interact with the driver. > > It makes no sense in

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Johannes Weiner
On Thu, May 23, 2019 at 12:41:30PM -0700, Matthew Wilcox wrote: > On Thu, May 23, 2019 at 03:21:17PM -0400, Johannes Weiner wrote: > > On Thu, May 23, 2019 at 12:00:32PM -0700, Matthew Wilcox wrote: > > > On Thu, May 23, 2019 at 11:49:41AM -0700, Shakeel Butt wrote: > > > > On Thu, May 23, 2019 at

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Matthew Wilcox
On Thu, May 23, 2019 at 03:21:17PM -0400, Johannes Weiner wrote: > On Thu, May 23, 2019 at 12:00:32PM -0700, Matthew Wilcox wrote: > > On Thu, May 23, 2019 at 11:49:41AM -0700, Shakeel Butt wrote: > > > On Thu, May 23, 2019 at 11:37 AM Matthew Wilcox > > > wrote: > > > > On Thu, May 23, 2019 at

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Johannes Weiner
On Thu, May 23, 2019 at 12:00:32PM -0700, Matthew Wilcox wrote: > On Thu, May 23, 2019 at 11:49:41AM -0700, Shakeel Butt wrote: > > On Thu, May 23, 2019 at 11:37 AM Matthew Wilcox wrote: > > > > > > On Thu, May 23, 2019 at 01:43:49PM -0400, Johannes Weiner wrote: > > > > I noticed that recent

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Matthew Wilcox
On Thu, May 23, 2019 at 11:49:41AM -0700, Shakeel Butt wrote: > On Thu, May 23, 2019 at 11:37 AM Matthew Wilcox wrote: > > > > On Thu, May 23, 2019 at 01:43:49PM -0400, Johannes Weiner wrote: > > > I noticed that recent upstream kernels don't account the xarray nodes > > > of the page cache to

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Shakeel Butt
On Thu, May 23, 2019 at 11:37 AM Matthew Wilcox wrote: > > On Thu, May 23, 2019 at 01:43:49PM -0400, Johannes Weiner wrote: > > I noticed that recent upstream kernels don't account the xarray nodes > > of the page cache to the allocating cgroup, like we used to do for the > > radix tree nodes. >

Re: xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Matthew Wilcox
On Thu, May 23, 2019 at 01:43:49PM -0400, Johannes Weiner wrote: > I noticed that recent upstream kernels don't account the xarray nodes > of the page cache to the allocating cgroup, like we used to do for the > radix tree nodes. > > This results in broken isolation for cgrouped apps, allowing

xarray breaks thrashing detection and cgroup isolation

2019-05-23 Thread Johannes Weiner
Hello, I noticed that recent upstream kernels don't account the xarray nodes of the page cache to the allocating cgroup, like we used to do for the radix tree nodes. This results in broken isolation for cgrouped apps, allowing them to escape their containment and harm other cgroups and the