Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-08-06 Thread Tahsin Erdogan
On Sun, Aug 6, 2017 at 5:47 AM, zhangyi (F) wrote: > I think the root cause of this problem is the hash value not updated > when we overwrite the same xattr, please see ext4_xattr_set_entry(): Yes, you are right. Thanks a lot for finding the root cause. I just sent out a fix: ("[PATCH] ext4: add

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-08-06 Thread zhangyi (F)
On 2017/8/3 19:10, Miklos Szeredi Wrote: On Tue, Aug 1, 2017 at 12:34 PM, Amir Goldstein wrote: On Mon, Jul 31, 2017 at 7:08 PM, Miklos Szeredi wrote: On Thu, Jul 27, 2017 at 10:54 PM, Tahsin Erdogan wrote: Still no luck reproducing the error. I am using the test script below at v4.13-rc2.

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-08-03 Thread Miklos Szeredi
On Tue, Aug 1, 2017 at 12:34 PM, Amir Goldstein wrote: > On Mon, Jul 31, 2017 at 7:08 PM, Miklos Szeredi wrote: >> On Thu, Jul 27, 2017 at 10:54 PM, Tahsin Erdogan wrote: >>> Still no luck reproducing the error. I am using the test script below >>> at v4.13-rc2. Do you mind checking my script to

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-08-01 Thread Amir Goldstein
On Mon, Jul 31, 2017 at 7:08 PM, Miklos Szeredi wrote: > On Thu, Jul 27, 2017 at 10:54 PM, Tahsin Erdogan wrote: >> Still no luck reproducing the error. I am using the test script below >> at v4.13-rc2. Do you mind checking my script to see what I am missing? > > Don't know. I can reliably repr

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-31 Thread Miklos Szeredi
On Thu, Jul 27, 2017 at 10:54 PM, Tahsin Erdogan wrote: > Still no luck reproducing the error. I am using the test script below > at v4.13-rc2. Do you mind checking my script to see what I am missing? Don't know. I can reliably reproduce it under UML, but not with a VM. What the hell is going

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-27 Thread Tahsin Erdogan
Still no luck reproducing the error. I am using the test script below at v4.13-rc2. Do you mind checking my script to see what I am missing? #!/bin/bash set -ex while grep /dev/sdb /proc/mounts;do umount /dev/sdb; done mke2fs -F -t ext4 /dev/sdb mount /dev/sdb /mnt/sdb cd /mnt/sdb mkdir xattrhas

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-27 Thread Miklos Szeredi
On Thu, Jul 27, 2017 at 9:28 PM, Miklos Szeredi wrote: > On Thu, Jul 27, 2017 at 8:20 PM, Tahsin Erdogan wrote: >> Hi Miklos, >> I made a first attempt to reproduce the failure but did not get lucky. >> >>> Inode 3093, i_blocks is 16, should be 8. Fix? yes >> Does this inode correspond to foo, b

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-27 Thread Miklos Szeredi
On Thu, Jul 27, 2017 at 8:20 PM, Tahsin Erdogan wrote: > Hi Miklos, > I made a first attempt to reproduce the failure but did not get lucky. > >> Inode 3093, i_blocks is 16, should be 8. Fix? yes > Does this inode correspond to foo, bar or a preexisting file? > > Do you mind sharing the output of

Re: xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-27 Thread Tahsin Erdogan
Hi Miklos, I made a first attempt to reproduce the failure but did not get lucky. > Inode 3093, i_blocks is 16, should be 8. Fix? yes Does this inode correspond to foo, bar or a preexisting file? Do you mind sharing the output of the following command? debugfs -R "stat <3093>" /dev/${ext4_dev}

xattr hash error in 4.13-rc with overlayfs over ext4

2017-07-27 Thread Miklos Szeredi
I get the following error on fsck: Pass 1: Checking inodes, blocks, and sizes Extended attribute in inode 3093 has a hash (2257320705) which is invalid Clear? yes Inode 3093, i_blocks is 16, should be 8. Fix? yes To reproduce: [mount ext4 image] mkdir xattrhashtest cd xattrhashtest/ mkdir upper