Re: your "x86: mm: convert dump_pagetables to use walk_page_range" change

2020-05-12 Thread Peter Zijlstra
On Tue, May 12, 2020 at 02:02:51PM +0100, Steven Price wrote: > > Additionally I'd like to note that note_page()'s "unsigned long val" > > parameter isn't wide enough for 32-bit PAE PTEs, and hence the NX > > flag will always be seen as clear in new_prot in such configs. > > Ah, interesting. I'm

Re: your "x86: mm: convert dump_pagetables to use walk_page_range" change

2020-05-12 Thread Jan Beulich
On 12.05.2020 15:02, Steven Price wrote: > On 12/05/2020 10:39, Jan Beulich wrote: >> Additionally I'd like to note that note_page()'s "unsigned long val" >> parameter isn't wide enough for 32-bit PAE PTEs, and hence the NX >> flag will always be seen as clear in new_prot in such configs. > > Ah,

Re: your "x86: mm: convert dump_pagetables to use walk_page_range" change

2020-05-12 Thread Steven Price
On 12/05/2020 10:39, Jan Beulich wrote: Steven, Hi Jan, in the description of this change you say: "The effective permissions are passed down the chain using new fields in struct pg_state." I don't see how this works, and I suppose this part of the change is (part of) the reason why a

your "x86: mm: convert dump_pagetables to use walk_page_range" change

2020-05-12 Thread Jan Beulich
Steven, in the description of this change you say: "The effective permissions are passed down the chain using new fields in struct pg_state." I don't see how this works, and I suppose this part of the change is (part of) the reason why a W+X warning has magically disappeared in 5.6.x (compared