Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()"

2014-11-04 Thread Jan Kara
On Tue 04-11-14 07:40:20, Jan Beulich wrote: > >>> On 03.11.14 at 23:18, wrote: > > On Mon, Nov 03, 2014 at 04:41:13PM +, Jan Beulich wrote: > >> having run into that warning too, I looked into it a little, and now > >> having found that patch am pretty uncertain: Both truncate_setsize() > >>

Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()"

2014-11-03 Thread Jan Beulich
>>> On 03.11.14 at 23:18, wrote: > On Mon, Nov 03, 2014 at 04:41:13PM +, Jan Beulich wrote: >> having run into that warning too, I looked into it a little, and now >> having found that patch am pretty uncertain: Both truncate_setsize() >> and pagecache_isize_extended() document that they want

Re: your patch "mm: Remove false WARN_ON from pagecache_isize_extended()"

2014-11-03 Thread Dave Chinner
On Mon, Nov 03, 2014 at 04:41:13PM +, Jan Beulich wrote: > Jan, > > having run into that warning too, I looked into it a little, and now > having found that patch am pretty uncertain: Both truncate_setsize() > and pagecache_isize_extended() document that they want to be > called with i_mutex h

your patch "mm: Remove false WARN_ON from pagecache_isize_extended()"

2014-11-03 Thread Jan Beulich
Jan, having run into that warning too, I looked into it a little, and now having found that patch am pretty uncertain: Both truncate_setsize() and pagecache_isize_extended() document that they want to be called with i_mutex held, so removing the WARN_ON() alone seems either incomplete or wrong. Wh