[ 148/221] staging: zram: fix invalid memory references during disk write

2013-01-15 Thread Greg Kroah-Hartman
3.7-stable review patch. If anyone has any objections, please let me know. -- From: Nitin Gupta commit 397c60668aa5ae7130b5ad4e73870d7b8a787085 upstream. Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of incompressible pages") which caused invalid memory refer

Re: zram: fix invalid memory references during disk write

2013-01-15 Thread Greg KH
>>>>>>>> > >> >>>>>>> > >> >>>>>>> Please apply this patch to stable tree asap. > >> >>>>>> > >> >>>>>> 3.6 is now end-of-life, there will not be any more releases for th

Re: zram: fix invalid memory references during disk write

2013-01-14 Thread Nitin Gupta
lease apply this patch to stable tree asap. >> >>>>>> >> >>>>>> 3.6 is now end-of-life, there will not be any more releases for that >> >>>>>> kernel series anymore, sorry. >> >>>>>> >> >>

Re: zram: fix invalid memory references during disk write

2013-01-14 Thread Greg KH
On Wed, Dec 19, 2012 at 11:39:15AM -0600, Mitch Harder wrote: > On Wed, Dec 19, 2012 at 11:21 AM, Nitin Gupta wrote: > > On 12/19/2012 08:17 AM, Greg KH wrote: > >> On Wed, Dec 19, 2012 at 07:53:36AM -0800, Nitin Gupta wrote: > >>> On 12/19/2012 07:08 AM, Greg KH wrote: > On Tue, Dec 18, 2012

Re: [PATCH][RESEND] staging: zram: fix invalid memory references during disk write

2013-01-08 Thread Greg KH
On Tue, Jan 08, 2013 at 02:00:27PM -0800, Nitin Gupta wrote: > On Fri, Jan 4, 2013 at 12:25 PM, Nitin Gupta wrote: > > On Wed, Jan 2, 2013 at 8:53 AM, Nitin Gupta wrote: > >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > >> of incompressible pages") which caused invalid memory

Re: [PATCH][RESEND] staging: zram: fix invalid memory references during disk write

2013-01-08 Thread Nitin Gupta
On Fri, Jan 4, 2013 at 12:25 PM, Nitin Gupta wrote: > On Wed, Jan 2, 2013 at 8:53 AM, Nitin Gupta wrote: >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling >> of incompressible pages") which caused invalid memory references >> during disk write. Invalid references could occur in t

Re: [PATCH][RESEND] staging: zram: fix invalid memory references during disk write

2013-01-04 Thread Nitin Gupta
On Wed, Jan 2, 2013 at 8:53 AM, Nitin Gupta wrote: > Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > of incompressible pages") which caused invalid memory references > during disk write. Invalid references could occur in two cases: > - Incoming data expands on compression: In th

[PATCH][RESEND] staging: zram: fix invalid memory references during disk write

2013-01-02 Thread Nitin Gupta
Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of incompressible pages") which caused invalid memory references during disk write. Invalid references could occur in two cases: - Incoming data expands on compression: In this case, reference was made to kunmap()'ed bio page. - Part

Re: zram: fix invalid memory references during disk write

2012-12-20 Thread Nitin Gupta
On Wed, Dec 19, 2012 at 9:39 AM, Mitch Harder wrote: > On Wed, Dec 19, 2012 at 11:21 AM, Nitin Gupta wrote: >> On 12/19/2012 08:17 AM, Greg KH wrote: >>> On Wed, Dec 19, 2012 at 07:53:36AM -0800, Nitin Gupta wrote: On 12/19/2012 07:08 AM, Greg KH wrote: > On Tue, Dec 18, 2012 at 11:21:28

Re: zram: fix invalid memory references during disk write

2012-12-19 Thread Mitch Harder
On Wed, Dec 19, 2012 at 11:21 AM, Nitin Gupta wrote: > On 12/19/2012 08:17 AM, Greg KH wrote: >> On Wed, Dec 19, 2012 at 07:53:36AM -0800, Nitin Gupta wrote: >>> On 12/19/2012 07:08 AM, Greg KH wrote: On Tue, Dec 18, 2012 at 11:21:28PM -0800, Nitin Gupta wrote: > On 12/18/2012 07:49 PM, G

Re: zram: fix invalid memory references during disk write

2012-12-19 Thread Nitin Gupta
On 12/19/2012 08:17 AM, Greg KH wrote: > On Wed, Dec 19, 2012 at 07:53:36AM -0800, Nitin Gupta wrote: >> On 12/19/2012 07:08 AM, Greg KH wrote: >>> On Tue, Dec 18, 2012 at 11:21:28PM -0800, Nitin Gupta wrote: On 12/18/2012 07:49 PM, Greg KH wrote: > On Tue, Dec 18, 2012 at 01:12:05PM -0800

Re: zram: fix invalid memory references during disk write

2012-12-19 Thread Greg KH
On Wed, Dec 19, 2012 at 07:53:36AM -0800, Nitin Gupta wrote: > On 12/19/2012 07:08 AM, Greg KH wrote: > > On Tue, Dec 18, 2012 at 11:21:28PM -0800, Nitin Gupta wrote: > >> On 12/18/2012 07:49 PM, Greg KH wrote: > >>> On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: > On Tue, Dec 11

Re: zram: fix invalid memory references during disk write

2012-12-19 Thread Nitin Gupta
On 12/19/2012 07:08 AM, Greg KH wrote: > On Tue, Dec 18, 2012 at 11:21:28PM -0800, Nitin Gupta wrote: >> On 12/18/2012 07:49 PM, Greg KH wrote: >>> On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: On Tue, Dec 11, 2012 at 10:27 AM, Greg KH wrote: > On Thu, Nov 29, 2012 at

Re: zram: fix invalid memory references during disk write

2012-12-19 Thread Greg KH
On Tue, Dec 18, 2012 at 11:21:28PM -0800, Nitin Gupta wrote: > On 12/18/2012 07:49 PM, Greg KH wrote: > > On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: > >> On Tue, Dec 11, 2012 at 10:27 AM, Greg KH > >> wrote: > >>> On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: > >>

Re: zram: fix invalid memory references during disk write

2012-12-18 Thread Nitin Gupta
On 12/18/2012 07:49 PM, Greg KH wrote: > On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: >> On Tue, Dec 11, 2012 at 10:27 AM, Greg KH wrote: >>> On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of in

Re: zram: fix invalid memory references during disk write

2012-12-18 Thread Greg KH
On Tue, Dec 18, 2012 at 01:12:05PM -0800, Nitin Gupta wrote: > On Tue, Dec 11, 2012 at 10:27 AM, Greg KH wrote: > > On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: > >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > >> of incompressible pages") which caused invalid

Re: zram: fix invalid memory references during disk write

2012-12-18 Thread Nitin Gupta
On Tue, Dec 11, 2012 at 10:27 AM, Greg KH wrote: > On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling >> of incompressible pages") which caused invalid memory references >> during disk write. Invalid references could occu

Re: zram: fix invalid memory references during disk write

2012-12-12 Thread Nitin Gupta
On 12/11/2012 10:27 AM, Greg KH wrote: > On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: >> Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling >> of incompressible pages") which caused invalid memory references >> during disk write. Invalid references could occur in two ca

Re: zram: fix invalid memory references during disk write

2012-12-11 Thread Greg KH
On Thu, Nov 29, 2012 at 10:45:09PM -0800, Nitin Gupta wrote: > Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > of incompressible pages") which caused invalid memory references > during disk write. Invalid references could occur in two cases: > - Incoming data expands on compressi

Re: zram: fix invalid memory references during disk write

2012-12-08 Thread Greg KH
On Fri, Dec 07, 2012 at 04:50:37PM -0800, Nitin Gupta wrote: > On Thu, Nov 29, 2012 at 10:45 PM, Nitin Gupta wrote: > > Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > > of incompressible pages") which caused invalid memory references > > during disk write. Invalid references cou

Re: zram: fix invalid memory references during disk write

2012-12-07 Thread Nitin Gupta
On Thu, Nov 29, 2012 at 10:45 PM, Nitin Gupta wrote: > Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling > of incompressible pages") which caused invalid memory references > during disk write. Invalid references could occur in two cases: > - Incoming data expands on compression: In

Re: zram: fix invalid memory references during disk write

2012-11-29 Thread Nitin Gupta
(somehow mail didn't go to the stable email alias and [PATCH] prefix was not added. CC'ed stable now) On 11/29/2012 10:45 PM, Nitin Gupta wrote: Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of incompressible pages") which caused invalid memory references during disk write. In

zram: fix invalid memory references during disk write

2012-11-29 Thread Nitin Gupta
Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of incompressible pages") which caused invalid memory references during disk write. Invalid references could occur in two cases: - Incoming data expands on compression: In this case, reference was made to kunmap()'ed bio page. - Part

Re: [PATCH v3] zram: fix invalid memory references during disk write

2012-11-29 Thread Nitin Gupta
On Thu, Nov 29, 2012 at 6:13 PM, Greg KH wrote: > On Fri, Nov 30, 2012 at 09:36:09AM +0900, Minchan Kim wrote: >> Hi Greg, >> >> I would like to tidy zram_bvec_write up but it needs more churn >> than needed to fix this bug and makes review hard. So I want you to pick up >> this patch asap because

Re: [PATCH v3] zram: fix invalid memory references during disk write

2012-11-29 Thread Greg KH
On Fri, Nov 30, 2012 at 09:36:09AM +0900, Minchan Kim wrote: > Hi Greg, > > I would like to tidy zram_bvec_write up but it needs more churn > than needed to fix this bug and makes review hard. So I want you to pick up > this patch asap because it's a candidate of stable. Ok, I have way too many d

Re: [PATCH v3] zram: fix invalid memory references during disk write

2012-11-29 Thread Greg KH
On Fri, Nov 30, 2012 at 09:36:09AM +0900, Minchan Kim wrote: > Hi Greg, > > I would like to tidy zram_bvec_write up but it needs more churn > than needed to fix this bug and makes review hard. So I want you to pick up > this patch asap because it's a candidate of stable. It is? How come no one s

Re: [PATCH v3] zram: fix invalid memory references during disk write

2012-11-29 Thread Minchan Kim
Hi Greg, I would like to tidy zram_bvec_write up but it needs more churn than needed to fix this bug and makes review hard. So I want you to pick up this patch asap because it's a candidate of stable. Thanks. On Thu, Nov 29, 2012 at 01:18:48AM -0800, Nitin Gupta wrote: > Changelog v3 vs v2: > -

[PATCH v3] zram: fix invalid memory references during disk write

2012-11-29 Thread Nitin Gupta
Changelog v3 vs v2: - Further changes to changelog message to explain the bug case of incorrect use of kunmapped buffer Changelog v2 vs v1: - Changelog message now correctly explains the problem Fixes a bug introduced by commit c8f2f0db1 ("zram: Fix handling of incompressible pages") which cause