Re: Linux 2.6.20-rc1

2006-12-14 Thread Alistair John Strachan
Hi Jens, On Thursday 14 December 2006 20:48, Jens Axboe wrote: > On Thu, Dec 14 2006, Jens Axboe wrote: > > > I'll do that if nobody comes up with anything obvious. > > > > If you can just test 2.6.19-git1, then we'll know if it's the SG_IO > > patch again. > > Actually, you should test

Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core

2006-12-14 Thread Doug Thompson
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 14 Dec 2006 10:58:09 + > Alan <[EMAIL PROTECTED]> wrote: > > > > +void edac_mc_handle_fbd_ue(struct mem_ctl_info *mci, > > > + unsigned int csrow, > > > + unsigned int channela, > > > +

Abolishing the DMCA (was GPL only modules)

2006-12-14 Thread Michael ODonald
Linus Torvalds wrote: > DMCA is bad because it puts technical limits over > the rights expressly granted by copyright law. The best ways to get rich corporations on our side in fighting the DMCA is to use the DMCA to hurt their profits. Companies that rely on binary drivers would have several

Re: Linux 2.6.20-rc1

2006-12-14 Thread Jens Axboe
On Thu, Dec 14 2006, Alistair John Strachan wrote: > Hi Jens, > > On Thursday 14 December 2006 20:48, Jens Axboe wrote: > > On Thu, Dec 14 2006, Jens Axboe wrote: > > > > I'll do that if nobody comes up with anything obvious. > > > > > > If you can just test 2.6.19-git1, then we'll know if it's

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Greg KH
On Thu, Dec 14, 2006 at 06:26:26PM +, Alan wrote: > > Think of uio as just a "class" of driver, like input or v4l. It's still > > up to the driver writer to provide a proper bus interface to the > > hardware (pci, usb, etc.) in order for the device to work at all. > > Understood. That leads

Re: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread dann frazier
On Thu, Dec 14, 2006 at 01:44:34PM -0600, Miller, Mike (OS Dev) wrote: > > > > -Original Message- > > From: Jens Axboe [mailto:[EMAIL PROTECTED] > > Sent: Thursday, December 14, 2006 12:51 PM > > To: Steve Roemen > > Cc: LKML; ISS StorageDev; Miller, Mike (OS Dev) > > Subject: Re:

Re: Linux 2.6.20-rc1

2006-12-14 Thread Jeff Garzik
Alistair John Strachan wrote: Hi Jens, On Thursday 14 December 2006 20:48, Jens Axboe wrote: On Thu, Dec 14 2006, Jens Axboe wrote: I'll do that if nobody comes up with anything obvious. If you can just test 2.6.19-git1, then we'll know if it's the SG_IO patch again. Actually, you should

Re: Abolishing the DMCA (was GPL only modules)

2006-12-14 Thread Greg KH
On Thu, Dec 14, 2006 at 01:09:06PM -0800, Michael ODonald wrote: > PS: I encourage Greg and all developers who were initially in favor > of enforcing the GPL-only module policy to stand strong on this > important issue. I think you missed the point that my patch prevents valid usages of non-GPL

Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)

2006-12-14 Thread Bill Davidsen
Andrew Morton wrote: Generally speaking, if sysfs file creation went wrong, it's due to a bug. The result is that the driver isn't working as intended: tunables or instrumentation which it is designed to make available are not present. We want to know about that bug asap so we can get it

Re: [PATCH 3/3] Import fw-sbp2 driver.

2006-12-14 Thread Stefan Richter
Kristian Høgsberg wrote: > Jeff Garzik wrote: >> doesn't allowing the stack to issue REPORT LUNS take care of this? > > Possibly, I don't have firewire multi-LUN devices to test with here. > The LUNs are also discoverable from the firewire config rom, which is > why I put the comment there.

Re: Linux 2.6.20-rc1

2006-12-14 Thread Alistair John Strachan
On Thursday 14 December 2006 21:33, Jeff Garzik wrote: > Alistair John Strachan wrote: > > Hi Jens, > > > > On Thursday 14 December 2006 20:48, Jens Axboe wrote: > >> On Thu, Dec 14 2006, Jens Axboe wrote: > I'll do that if nobody comes up with anything obvious. > >>> > >>> If you can just

Re: Linux 2.6.20-rc1

2006-12-14 Thread Jeff Garzik
Alistair John Strachan wrote: Before I proceed with the horrors of an -rc1 bisection, could somebody send me the ADMA patches so I can eliminate those first? Run git-whatchanged drivers/ata/sata_nv.c and that will give you a list of recent changes. To obtain the "diff -u" patch for

Re: Linux 2.6.20-rc1

2006-12-14 Thread Jeff Garzik
Alistair John Strachan wrote: Before I proceed with the horrors of an -rc1 bisection, could somebody send me the ADMA patches so I can eliminate those first? BTW a bisection need not be blindly horrific... You can look at the commit ids from git-whatchanged output mentioned in the previous

[PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious

2006-12-14 Thread nuxdoors
From: Fabrice Knevez <[EMAIL PROTECTED]> "sunkbd_enable(sunkbd, 0);" has no effect. Adding "sunkbd->enabled = enable" in sunkbd_enable (obvious) Signed-off-by: Fabrice Knevez <[EMAIL PROTECTED]> --- Sorry about thunderbird mangling the patch in the first email... I don't have any sun

Re: noexec=on doesn't work

2006-12-14 Thread Bill Davidsen
John Richard Moser wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm running on an Athlon 64 in 32-bit mode, running 32-bit Ubuntu with kernel 2.6.19 (Ubuntu version 2.6.19-7-generic for the curious; compiled for 586). Apparently, 'noexec=on' on the kernel command line does nothing; the

Re: Userspace I/O driver core

2006-12-14 Thread Ben Nizette
linux-os (Dick Johnson) wrote: On Wed, 13 Dec 2006, Greg KH wrote: If anyone has any questions on how to use this interface, or anything else about it, please let me and Thomas know. thanks, greg k-h [snip] There are well thought-out methods of creating hardware interfaces that > have a

Re: Temporary random kernel hang

2006-12-14 Thread Andrew Morton
On Mon, 11 Dec 2006 10:46:25 -0800 (PST) seven <[EMAIL PROTECTED]> wrote: > > > > > A kernel profile will tell us were the kernel is burning CPU. Something > > like this (run as root): > > > > #!/bin/sh > > while true > > do > > opcontrol --stop > > opcontrol --shutdown > > rm

RE: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Frazier, Daniel Kent > Sent: Thursday, December 14, 2006 3:12 PM > To: Miller, Mike (OS Dev) > Cc: Jens Axboe; Steve Roemen; LKML; ISS StorageDev > Subject: Re: 2.6.19-git20 cciss: cmd f7b0 timedout > > On Thu, Dec 14, 2006 at 01:44:34PM -0600, Miller,

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Dave Airlie
On 12/15/06, Jeff Garzik <[EMAIL PROTECTED]> wrote: Alan wrote: > Another thing we should do more is aggressively merge prototype open > drivers for binary only hardware - lets get Nouveau's DRM bits into the > kernel ASAP for example. ACK++ We should definitely push Nouveau[1] as hard as we

Re: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread Steve Roemen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yes, 32bit Debian Miller, Mike (OS Dev) wrote: > > >> -Original Message- >> From: Frazier, Daniel Kent >> Sent: Thursday, December 14, 2006 3:12 PM >> To: Miller, Mike (OS Dev) >> Cc: Jens Axboe; Steve Roemen; LKML; ISS StorageDev >>

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Michael Buesch
On Thursday 14 December 2006 23:21, Dave Airlie wrote: > On 12/15/06, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Alan wrote: > > > Another thing we should do more is aggressively merge prototype open > > > drivers for binary only hardware - lets get Nouveau's DRM bits into the > > > kernel ASAP

Re: lots of code could be simplified by using ARRAY_SIZE()

2006-12-14 Thread Robert P. J. Day
On Thu, 14 Dec 2006, Zach Brown wrote: > > there are numerous places throughout the source tree that > > apparently calculate the size of an array using the construct > > "sizeof(fubar)/sizeof(fubar[0])". see for yourself: > > $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" * > > Indeed,

Re: Linux 2.6.20-rc1

2006-12-14 Thread Alistair John Strachan
On Thursday 14 December 2006 21:50, Jeff Garzik wrote: > Alistair John Strachan wrote: > > Before I proceed with the horrors of an -rc1 bisection, could somebody > > send me the ADMA patches so I can eliminate those first? > > Run > > git-whatchanged drivers/ata/sata_nv.c > > and that will

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Dave Airlie
> > It'll get in when the developers feel it is at a stage where it can be > supported, at the moment (I'm not speaking for all the nouveau team > only my own opinion) the API isn't stable and putting it into the > kernel only means we've declared the API supportable, I know in theory > marking

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Randy Dunlap
David Weinehall wrote: On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote: [snip] +but no space after unary operators: + sizeof ++ -- & * + - ~ ! defined Uhm, that doesn't compute... If you don't put a space after sizeof, the program won't compile. int c;

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Michael Buesch
On Thursday 14 December 2006 23:39, Dave Airlie wrote: > > > > > > It'll get in when the developers feel it is at a stage where it can be > > > supported, at the moment (I'm not speaking for all the nouveau team > > > only my own opinion) the API isn't stable and putting it into the > > > kernel

kernel.org lies about latest -mm kernel

2006-12-14 Thread Pavel Machek
Hi! [EMAIL PROTECTED]:/data/pavel$ finger @www.kernel.org [zeus-pub.kernel.org] ... The latest -mm patch to the stable Linux kernels is: 2.6.19-rc6-mm2 [EMAIL PROTECTED]:/data/pavel$ head /data/l/linux-mm/Makefile VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 19 EXTRAVERSION = -mm1 ... [EMAIL

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread David Weinehall
On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote: [snip] > +but no space after unary operators: > + sizeof ++ -- & * + - ~ ! defined Uhm, that doesn't compute... If you don't put a space after sizeof, the program won't compile. int c; printf("%d", sizeofc);

Re: [GIT PATCH] more Driver core patches for 2.6.19

2006-12-14 Thread Linus Torvalds
On Thu, 14 Dec 2006, Thomas Gleixner wrote: > > The kernel part of the UIO driver also knows how to shut the interrupt > up, so where is the difference ? Thomas, you've been discussing some totally different and private Thomas-only thread than everybody else in this thread has been. The

Re: kernel.org lies about latest -mm kernel

2006-12-14 Thread Randy Dunlap
On Thu, 14 Dec 2006 23:37:18 +0100 Pavel Machek wrote: > Hi! > > [EMAIL PROTECTED]:/data/pavel$ finger @www.kernel.org > [zeus-pub.kernel.org] > ... > The latest -mm patch to the stable Linux kernels is: 2.6.19-rc6-mm2 > [EMAIL PROTECTED]:/data/pavel$ head /data/l/linux-mm/Makefile > VERSION = 2

Re: lots of code could be simplified by using ARRAY_SIZE()

2006-12-14 Thread Stefan Richter
Robert P. J. Day wrote: > On Thu, 14 Dec 2006, Zach Brown wrote: ... >> Indeed, there seems to be lots of potential clean-up there. >> Including duplicate macros like: >> >> ./drivers/ide/ide-cd.h:#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0]))) > > not surprisingly, i have a script

Re: lots of code could be simplified by using ARRAY_SIZE()

2006-12-14 Thread Miguel Ojeda
On 12/13/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote: there are numerous places throughout the source tree that apparently calculate the size of an array using the construct "sizeof(fubar)/sizeof(fubar[0])". see for yourself: $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" * but we

Re: Linux 2.6.20-rc1

2006-12-14 Thread Jeff Garzik
Nicolas Mailhot wrote: Alistair John Strachan sms.ed.ac.uk> writes: `hddtemp' has stopped working on 2.6.20-rc1: → http://bugzilla.kernel.org/show_bug.cgi?id=7581 I'm not sure I quite follow your bug report. Are you saying that the patch you attached causes the problem? Jeff

[Fwd: Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-14 Thread Ben Nizette
Linus Torvalds wrote: On Thu, 14 Dec 2006, Thomas Gleixner wrote: The kernel part of the UIO driver also knows how to shut the interrupt up, so where is the difference ? Thomas, you've been discussing some totally different and private Thomas-only thread than everybody else in this

Re: [PATCH 2.6.19.1] sunkbd.c: fix sunkbd_enable(sunkbd, 0); obvious

2006-12-14 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 14 Dec 2006 21:25:20 +0100 > "sunkbd_enable(sunkbd, 0);" has no effect. Adding "sunkbd->enabled = enable" > in sunkbd_enable (obvious) > > Signed-off-by: Fabrice Knevez <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line

Re: [PATCH 2.6.19] tg3: replace kmalloc+memset with kzalloc

2006-12-14 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 12 Dec 2006 12:30:28 -0800 > On Tue, 2006-12-12 at 21:10 +0200, Yan Burman wrote: > > Replace kmalloc+memset with kzalloc > > > > Signed-off-by: Yan Burman <[EMAIL PROTECTED]> > > Acked-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks

Re: [GIT PATCH] more Driver core patches for 2.6.19

2006-12-14 Thread Thomas Gleixner
Linus, On Thu, 2006-12-14 at 14:59 -0800, Linus Torvalds wrote: > > The kernel part of the UIO driver also knows how to shut the interrupt > > up, so where is the difference ? > > Thomas, you've been discussing some totally different and private > Thomas-only thread than everybody else in this

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Scott Preece
Outside of comments, documentation and except in Kconfig, spaces are never used for indentation, and the above example is deliberately broken. --- I realize it isn't text you added, but what's that supposed to mean? Surely the 8-character indents are made up of spaces. Does it mean "spaces

Re: Temporary random kernel hang

2006-12-14 Thread seven
Andrew Morton wrote: > > No, I wasn't ignoring you for four days. Please, always do reply-to-all. > I am using nabble's interface to post messages ( www.nabble.com ) and I am not subscribed to the mailing list, so it's possible that this is the cause of the direct mail. Andrew Morton

2.6.19-git19, Intel 945 + ICH7 SATA - long delay in boot (30 seconds to a minute timeout).

2006-12-14 Thread Teunis Peters
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 still has 30+ second (up to a minute or more) delay in SATA init. It's a laptop - so such delays are costly. Okay - working from "single": no real change in configuration from past. ipw3945 still broken - I'm not surprised... (I know - patience!)

Re: amd64 agpgart aperture base value

2006-12-14 Thread Daniel Drake
Dave Jones wrote: On Wed, Dec 13, 2006 at 10:47:32PM -0500, Daniel Drake wrote: > In amd64-agp.c, would it be dangerous to remove the "aperture base > 4G" > thing and instead simply only read the rightmost 7 bits to ensure the > aperture base is always in range? (This is coming from

[ANNOUNCE] Updated PS3 Linux Distributor's Starter Kit released

2006-12-14 Thread Geoff Levand
Just to let anyone interested know, an updated PS3 Linux Distributor's Starter Kit was released. The release note is here: http://www.kernel.org/pub/linux/kernel/people/geoff/cell/ps3-linux-distro-kit-20061208/README-e.txt I extracted the ISO contents for browsing here:

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Randy Dunlap
Scott Preece wrote: [1] Outside of comments, documentation and except in Kconfig, spaces are never used for indentation, and the above example is deliberately broken. --- I realize it isn't text you added, but what's that supposed to mean? Surely the 8-character indents are made up of

Re: kernel.org lies about latest -mm kernel

2006-12-14 Thread Sergio Monteiro Basto
kernel.org don't lie is not updated , this problem should be snd to webmaster isn't ? -- Sérgio M. B. On Thu, 2006-12-14 at 23:37 +0100, Pavel Machek wrote: > Hi! > > [EMAIL PROTECTED]:/data/pavel$ finger @www.kernel.org > [zeus-pub.kernel.org] > ... > The latest -mm patch to the stable Linux

Re: [patch 1/1] oprofile: Add a special cookie for the VDSO region

2006-12-14 Thread Andrew Morton
On Mon, 11 Dec 2006 15:26:26 +0530 "Amitabha Roy" <[EMAIL PROTECTED]> wrote: > Emit a special VDSO_COOKIE for VDSO regions instead of simply marking > them as anon. Why? > Signed-off-by: Amitabha Roy <[EMAIL PROTECTED]> > --- > diff --git a/drivers/oprofile/buffer_sync.c

RE: kref refcnt and false positives

2006-12-14 Thread Pallipadi, Venkatesh
>-Original Message- >From: Eric Dumazet [mailto:[EMAIL PROTECTED] >Sent: Wednesday, December 13, 2006 11:57 PM >To: Andrew Morton >Cc: Greg KH; Pallipadi, Venkatesh; Arjan; linux-kernel; Eric >W. Biederman >Subject: Re: kref refcnt and false positives > > >I agree this 'optimization'

Re: 2.6.19-mm1: gotemp: memset(..., 0) error

2006-12-14 Thread Greg KH
On Wed, Dec 13, 2006 at 02:05:59PM +0100, Adrian Bunk wrote: > <-- snip --> > > ... > NOT FOR MAINLINE! > > This is for the driver tutorial I give. It will not be included in the > mainline kernel tree ever. Use the ldusb driver that is already there > instead for this device. > > This is

Re: Linux 2.6.20-rc1

2006-12-14 Thread Nicolas Mailhot
Le jeudi 14 décembre 2006 à 18:22 -0500, Jeff Garzik a écrit : > Nicolas Mailhot wrote: > > Alistair John Strachan sms.ed.ac.uk> writes: > > > >> `hddtemp' has stopped working on 2.6.20-rc1: > > > > → http://bugzilla.kernel.org/show_bug.cgi?id=7581 > > I'm not sure I quite follow your bug

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Scott Preece
On 12/14/06, Randy Dunlap <[EMAIL PROTECTED]> wrote: Scott Preece wrote: [1] >> Outside of comments, documentation and except in Kconfig, spaces are >> never >> used for indentation, and the above example is deliberately broken. > --- > > I realize it isn't text you added, but what's that

Re: amd64 agpgart aperture base value

2006-12-14 Thread Dave Jones
On Thu, Dec 14, 2006 at 06:35:30PM -0500, Daniel Drake wrote: > So, you think that the aperture moving to a different location on every > boot is what the BIOS desires? Is it normal for it to move so much? Beats me. I gave up trying to understand BIOS authors motivations years ago. > The

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Robert P. J. Day
On Thu, 14 Dec 2006, Randy Dunlap wrote: > David Weinehall wrote: > > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote: > > > > [snip] > > > > > +but no space after unary operators: > > > + sizeof ++ -- & * + - ~ ! defined > > > > Uhm, that doesn't compute... If you

Re: data corruption with nvidia chipsets and IDE/SATA drives // memory hole mapping related bug?!

2006-12-14 Thread Dax Kelson
On Sat, 2006-12-02 at 01:56 +0100, Christoph Anton Mitterer wrote: > Hi. > > Perhaps some of you have read my older two threads: > http://marc.theaimsgroup.com/?t=11631244001=1=2 and the even > older http://marc.theaimsgroup.com/?t=11629131451=1=2 > > The issue was basically the

[PATCH] [AGP] Fix detection of aperture size versus GTT size on G965.

2006-12-14 Thread eric
From: Eric Anholt <[EMAIL PROTECTED]> On the G965, the GTT size may be larger than is required to cover the aperture. (In fact, on all hardware we've seen, the GTT is 512KB to the aperture's 256MB). A previous commit forced the aperture size to 512MB on G965 to match GTT, which would likely

Re: kref refcnt and false positives

2006-12-14 Thread Eric W. Biederman
"Pallipadi, Venkatesh" <[EMAIL PROTECTED]> writes: >>But I believe Venkatesh problem comes from its release() >>function : It is >>supposed to free the object. >>If not, it should properly setup it so that further uses are OK. >> >>ie doing in release(kref) >>atomic_set(>count, 0); >> > >

Re: lots of code could be simplified by using ARRAY_SIZE()

2006-12-14 Thread Robert P. J. Day
On Fri, 15 Dec 2006, Miguel Ojeda wrote: > On 12/13/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > > there are numerous places throughout the source tree that apparently > > calculate the size of an array using the construct > > "sizeof(fubar)/sizeof(fubar[0])". see for yourself: > > > >

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Randy Dunlap
On Thu, 14 Dec 2006 19:07:27 -0500 (EST) Robert P. J. Day wrote: > On Thu, 14 Dec 2006, Randy Dunlap wrote: > > > David Weinehall wrote: > > > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote: > > > > > > [snip] > > > > > > > +but no space after unary operators: > > > > +

Re: kref refcnt and false positives

2006-12-14 Thread Andrew Morton
On Thu, 14 Dec 2006 17:19:55 -0700 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> writes: > > >>But I believe Venkatesh problem comes from its release() > >>function : It is > >>supposed to free the object. > >>If not, it should properly setup it so

Re: libata-pata with ICH4, rootfs

2006-12-14 Thread Alan
On Thu, 14 Dec 2006 18:32:50 + Alistair John Strachan <[EMAIL PROTECTED]> wrote: > Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and > greater. The kernel help text agrees with me. > > My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was interested in > using

Re: Linux 2.6.20-rc1

2006-12-14 Thread Alistair John Strachan
On Thursday 14 December 2006 21:20, Jens Axboe wrote: > On Thu, Dec 14 2006, Alistair John Strachan wrote: > > Hi Jens, > > > > On Thursday 14 December 2006 20:48, Jens Axboe wrote: > > > On Thu, Dec 14 2006, Jens Axboe wrote: > > > > > I'll do that if nobody comes up with anything obvious. > > >

[patch 4/4] Distinguish /proc/kmsg access from sys_syslog

2006-12-14 Thread Zack Weinberg
Finally, add a new security class for access to /proc/kmsg, distinct from the class used for the "read current messages" operations on sys_syslog. The dummy and capability modules permit access to /proc/kmsg to any user (who has somehow acquired an open fd on it); SELinux is unchanged. This

Re: [PATCH/RFC] CodingStyle updates

2006-12-14 Thread Robert P. J. Day
On Thu, 14 Dec 2006, Randy Dunlap wrote: > On Thu, 14 Dec 2006 19:07:27 -0500 (EST) Robert P. J. Day wrote: > > > On Thu, 14 Dec 2006, Randy Dunlap wrote: > > > > > David Weinehall wrote: > > > > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote: > > > > > > > > [snip] > > > > > > > >

[patch 3/4] Refactor do_syslog interface

2006-12-14 Thread Zack Weinberg
This patch breaks out the read operations in do_syslog() into their own functions (klog_read, klog_readhist) and adds a klog_poll. klog_read grows the ability to do a nonblocking read, which I expose in the sys_syslog interface because there doesn't seem to be any reason not to. do_syslog itself

[patch 2/4] permission mapping for sys_syslog operations

2006-12-14 Thread Zack Weinberg
As suggested by Stephen Smalley: map the various sys_syslog operations to a smaller set of privilege codes before calling security modules. This patch changes the security module interface! There should be no change in the actual security semantics enforced by dummy, capability, nor SELinux (with

[patch 0/4] /proc/kmsg permissions, take three

2006-12-14 Thread Zack Weinberg
Here's a re-revised version of my patch set to allow klogd to drop privileges and continue reading from /proc/kmsg (currently, even if klogd has a legitimately opened fd on /proc/kmsg, it cannot read from it unless it has CAP_SYS_ADMIN asserted). SELinux's pickier and finer-grained privilege

[patch 1/4] Add

2006-12-14 Thread Zack Weinberg
This patch introduces with symbolic constants for the various sys_syslog() opcodes, and changes all in-kernel references to those opcodes to use the constants. The header is added to the set of user/kernel interface headers. (Unlike the previous revision of this patch series, no kernel-private

Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

2006-12-14 Thread Alan
> Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work > correctly. The help text is a bit confusing: The help text is out of date - thanks that is a real bug - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: kref refcnt and false positives

2006-12-14 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > Guys, we have about 100 reports of weirdo > crashes, smashes, bashes and splats in the kref code. The last thing we > need is some obscure, tricksy little optimisation which leads legitimate > uses of the API to mysteriously

Re: [patch 1/4] Add

2006-12-14 Thread Randy Dunlap
On Thu, 14 Dec 2006 16:16:40 -0800 Zack Weinberg wrote: > This patch introduces with symbolic constants for the > various sys_syslog() opcodes, and changes all in-kernel references to > those opcodes to use the constants. The header is added to the set of > user/kernel interface headers.

Re: Abolishing the DMCA (was GPL only modules)

2006-12-14 Thread Alan
> The best ways to get rich corporations on our side in fighting the > DMCA is to use the DMCA to hurt their profits. Companies that rely on > binary drivers would have several options: > > 1) Lobby politicians to repeal the DMCA, They already are. The tech industry is mostly anti DMCA and

Re: 2.6.19-git20 cciss: cmd f7b00000 timedout

2006-12-14 Thread dann frazier
On Thu, Dec 14, 2006 at 04:16:39PM -0600, Miller, Mike (OS Dev) wrote: > H. Dann, did you see this on 32-bit Debian? yep - all reports I've seen so far are on i386 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

[PATCH] procfs: Fix race between proc_readdir and remove_proc_entry

2006-12-14 Thread Darrick J. Wong
Hi, While running a insmod/rmmod loop with the mptsas driver (vanilla 2.6.19, IBM Intellistation Z30, SAS1064E controller if it matters), I encountered the following messages from the kernel: [53092.441412] general protection fault: [1] PREEMPT SMP [53092.447058] CPU 4 [53092.449108]

Re: [patch 2/4] permission mapping for sys_syslog operations

2006-12-14 Thread Randy Dunlap
On Thu, 14 Dec 2006 16:16:41 -0800 Zack Weinberg wrote: > As suggested by Stephen Smalley: map the various sys_syslog operations > to a smaller set of privilege codes before calling security modules. > This patch changes the security module interface! There should be no > change in the actual

Re: Linux 2.6.20-rc1

2006-12-14 Thread Robert Hancock
Alistair John Strachan wrote: I bisected all the way down to 0e75f9063f5c55fb0b0b546a7c356f8ec186825e, which git reckons is the culprit. I wasn't able to revert this commit to test, because it has conflicts. Any ideas? That would be this one I assume? [PATCH] block: support larger block pc

Problem in EHCI 2.6.15

2006-12-14 Thread Conio sandiago
Hi all, I am working on a ARM based SOV and i am tryig to add glue logic for EHCI controller. But i am facing some problem. I want to know ,are there any known problem in 2.6.15? Thanks Ashwini - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [patch 2/4] permission mapping for sys_syslog operations

2006-12-14 Thread Zack Weinberg
On 12/14/06, Randy Dunlap <[EMAIL PROTECTED]> wrote: > +#define security_syslog_or_fail(type) do { \ > + int error = security_syslog(type); \ > + if (error) \ > + return error; \ > + }

Re: [patch 1/4] Add

2006-12-14 Thread Zack Weinberg
On 12/14/06, Randy Dunlap <[EMAIL PROTECTED]> wrote: > - (void) do_syslog(0,NULL,0); > + (void) do_syslog(KLOG_CLOSE,NULL,0); Please use a space after the commas (even though you just left it as it already was). Will change for the next revision. zw - To unsubscribe from this list:

Re: [patch 00/24] -stable review

2006-12-14 Thread Chris Wright
patch roll-up is available at: http://www.kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.18.6-rc1.{gz,bz2} once mirroring has completed. thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

[patch 10/24] SUNHME: Fix for sunhme failures on x86

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Jurij Smakov <[EMAIL PROTECTED]> The following patch fixes the failure of sunhme drivers on x86 hosts due to missing pci_enable_device() and pci_set_master() calls, lost during code

[patch 01/24] softmac: remove netif_tx_disable when scanning

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Michael Buesch <[EMAIL PROTECTED]> In the scan section of ieee80211softmac, network transmits are disabled. When SoftMAC re-enables transmits, it may override the wishes of a driver that may

[patch 12/24] dm snapshot: fix freeing pending exception

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Milan Broz <[EMAIL PROTECTED]> Fix oops when removing full snapshot kernel bugzilla bug 7040 If a snapshot became invalid (full) while there is outstanding pending_exception,

[patch 00/24] -stable review

2006-12-14 Thread Chris Wright
This is the start of the stable review cycle for the 2.6.18.6 release. There are 24 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let us know. If anyone is a maintainer of the proper subsystem, and wants to add a

[patch 07/24] dm crypt: Fix data corruption with dm-crypt over RAID5

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Christophe Saout <[EMAIL PROTECTED]> Fix corruption issue with dm-crypt on top of software raid5. Cancelled readahead bio's that report no error, just have BIO_UPTODATE cleared were reported

[patch 15/24] bonding: incorrect bonding state reported via ioctl

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Andy Gospodarek <[EMAIL PROTECTED]> This is a small fix-up to finish out the work done by Jay Vosburgh to add carrier-state support for bonding devices. The output in /proc/net/bonding/bondX

[patch 22/24] m32r: make userspace headers platform-independent

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Hirokazu Takata <[EMAIL PROTECTED]> The m32r kernel 2.6.18-rc1 or after cause build errors of "unknown isa configuration" for userspace application programs, such as glibc, gdb, etc. This is

[patch 13/24] IPSEC: Fix inetpeer leak in ipv4 xfrm dst entries.

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: David Miller <[EMAIL PROTECTED]> We grab a reference to the route's inetpeer entry but forget to release it in xfrm4_dst_destroy(). Bug discovered by Kazunori MIYAZAWA <[EMAIL PROTECTED]>

Re: Linux 2.6.20-rc1

2006-12-14 Thread Alistair John Strachan
On Friday 15 December 2006 00:48, Alistair John Strachan wrote: > On Thursday 14 December 2006 21:20, Jens Axboe wrote: > > On Thu, Dec 14 2006, Alistair John Strachan wrote: > > > Hi Jens, > > > > > > On Thursday 14 December 2006 20:48, Jens Axboe wrote: > > > > On Thu, Dec 14 2006, Jens Axboe

[patch 19/24] ARM: Add sys_*at syscalls

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Russell King <[EMAIL PROTECTED]> Later glibc requires the *at syscalls. Add them. Signed-off-by: Russell King <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> ---

[patch 16/24] DVB: lgdt330x: fix signal / lock status detection bug

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Michael Krufky <[EMAIL PROTECTED]> In some cases when using VSB, the AGC status register has been known to falsely report "no signal" when in fact there is a carrier lock. The datasheet

[patch 02/24] EBTABLES: Fix wraparounds in ebt_entries verification.

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Al Viro <[EMAIL PROTECTED]> We need to verify that a) we are not too close to the end of buffer to dereference b) next entry we'll be checking won't be _before_ our While we

[patch 17/24] V4L: Fix broken TUNER_LG_NTSC_TAPE radio support

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Hans Verkuil <[EMAIL PROTECTED]> The TUNER_LG_NTSC_TAPE is identical in all respects to the TUNER_PHILIPS_FM1236_MK3. So use the params struct for the Philips tuner. Also add this LG_NTSC_TAPE

[patch 24/24] Bluetooth: Add packet size checks for CAPI messages (CVE-2006-6106)

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Marcel Holtmann <[EMAIL PROTECTED]> With malformed packets it might be possible to overwrite internal CMTP and CAPI data structures. This patch adds additional length checks to prevent these

[patch 03/24] EBTABLES: Verify that ebt_entries have zero ->distinguisher.

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Al Viro <[EMAIL PROTECTED]> We need that for iterator to work; existing check had been too weak. Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]>

[patch 23/24] forcedeth: Disable INTx when enabling MSI in forcedeth

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Daniel Barkalow <[EMAIL PROTECTED]> At least some nforce cards continue to send legacy interrupts when MSI is enabled, and these interrupts are treated as unhandled by the kernel. This patch

[patch 18/24] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Stefan Richter <[EMAIL PROTECTED]> Fixes http://bugzilla.kernel.org/show_bug.cgi?id=7431 iBook G3 threw a machine check exception and put the display backlight to full brightness after

[patch 06/24] NET_SCHED: policer: restore compatibility with old iproute binaries

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Patrick McHardy <[EMAIL PROTECTED]> The tc actions increased the size of struct tc_police, which broke compatibility with old iproute binaries since both the act_police and the old

[patch 20/24] skip data conversion in compat_sys_mount when data_page is NULL

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Andrey Mirkin <[EMAIL PROTECTED]> OpenVZ Linux kernel team has found a problem with mounting in compat mode. Simple command "mount -t smbfs ..." on Fedora Core 5 distro in 32-bit mode leads

[patch 05/24] EBTABLES: Prevent wraparounds in checks for entry components sizes.

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Al Viro <[EMAIL PROTECTED]> --- net/bridge/netfilter/ebtables.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) ---

[patch 04/24] EBTABLES: Deal with the worst-case behaviour in loop checks.

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Al Viro <[EMAIL PROTECTED]> No need to revisit a chain we'd already finished with during the check for current hook. It's either instant loop (which we'd just detected) or a duplicate work.

Re: [PATCH] procfs: Fix race between proc_readdir and remove_proc_entry

2006-12-14 Thread Darrick J. Wong
Oops, sent a corrupt and old version of the patch. Here's the correct patch. While running a insmod/rmmod loop with the mptsas driver (vanilla 2.6.19, IBM Intellistation Z30, SAS1064E controller if it matters), I encountered a bad dereference of the pointer "de": spin_unlock(_subdir_lock); if

[patch 08/24] NETFILTER: ip_tables: revision support for compat code

2006-12-14 Thread Chris Wright
2.6.18-stable review patch. If anyone has any objections, please let us know. -- From: Patrick McHardy <[EMAIL PROTECTED]> --- commit 79030ed07de673e8451a03aecb9ada9f4d75d491 tree 4ba8bd843c8bc95db0ea6877880b73d06da620e5 parent bec71b162747708d4b45b0cd399b484f52f2901a author

<    3   4   5   6   7   8   9   >