[PATCH] tty: Clarify documentation of ->write()

2007-02-21 Thread Alan
The tty driver write method is different to the usual fops device write methods as the buffer is already in kernel space. Clarify the docs since someone writing a driver made that mistake. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH] [MTD] CHIPS: oops in cfi_amdstd_sync

2007-02-21 Thread Josh Boyer
On Wed, 2007-02-21 at 14:54 +, Jörn Engel wrote: > On Tue, 20 February 2007 17:46:13 -0800, Vijay Sampath wrote: > > > > The files cfi_cmdset_0002.c and cfi_cmdset_0020.c do not initialize > > their wait queues like is done in cfi_cmdset_0001.c. This causes an > > oops when the wait queue is a

Re: SATA problems

2007-02-21 Thread Pablo Sebastian Greco
Tejun Heo wrote: Pablo Sebastian Greco wrote: Tejun Heo wrote: * Pablo, the bug you saw was bad interaction between blacklisted NCQ device and dynamic queue depth adjustment. Patches are submitted to fix the problem. Just drop the blacklist patch. Your drives should work fine in NCQ

Re: [BUG] PATA_PCMCIA does not work

2007-02-21 Thread Manuel Lauss
On Wed, Feb 21, 2007 at 03:37:29PM +, Alan wrote: > Does this fix the oops ? > > Alan > > > diff -u --new-file --recursive --exclude-from /usr/src/exclude > linux.vanilla-2.6.20-mm2/drivers/ata/pata_pcmcia.c > linux-2.6.20-mm2/drivers/ata/pata_pcmcia.c > --- linux.vanilla-2.6.20-mm2/driver

Re: High CPU usage with sata_nv

2007-02-21 Thread Matthew Fredrickson
On Feb 20, 2007, at 9:43 PM, Robert Hancock wrote: Matthew Fredrickson wrote: I have noticed something that might be related as well. I am working on a device driver that would have periodic data errors due to exceptionally long interrupt handling latency. I have come to the point that I s

Re: 2.6.20-git15 BUG: soft lockup detected on CPU#0! - timers?

2007-02-21 Thread Thomas Gleixner
On Tue, 2007-02-20 at 23:37 +0100, Michal Piotrowski wrote: > On 20/02/07, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-02-20 at 19:54 +0100, Michal Piotrowski wrote: > > > > > > Might it be 6ba9b346e1e0eca65ec589d32de3a9fe32dc5de6 commit? > > > > I doubt that it is, but can you reve

[PATCH 2.6.21-rc1] serial: serial_txx9 driver update

2007-02-21 Thread Atsushi Nemoto
Update the serial_txx9 driver. * Use platform_device. * Fix and cleanup suspend/resume codes. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> --- diff --git a/drivers/serial/serial_txx9.c b/drivers/serial/serial_txx9.c index f4440d3..124d056 100644 --- a/drivers/serial/serial_txx9.c +++ b/dri

Re: 2.6.20-git15 BUG: soft lockup detected on CPU#0! - timers?

2007-02-21 Thread Michal Piotrowski
On 21/02/07, Thomas Gleixner <[EMAIL PROTECTED]> wrote: On Tue, 2007-02-20 at 23:37 +0100, Michal Piotrowski wrote: > On 20/02/07, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > On Tue, 2007-02-20 at 19:54 +0100, Michal Piotrowski wrote: > > > > > > Might it be 6ba9b346e1e0eca65ec589d32de3a9fe32d

Re: Kernel oops in 2.6.18.3 with RAID5

2007-02-21 Thread Andrew Robinson
Update: I think that you can ignore this error. I am getting segmentation faults when I attempt to rebuild the kernel. This is exactly the same problem I had with slackware 10.1 with the 2.6.10 kernel. So I think it is a hardware issue. Memtest86 didn't show any errors after 35 passes, so I'll hav

Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update

2007-02-21 Thread Alan
> +static void serial_txx9_initialize(struct uart_port *port) > +{ > + struct uart_txx9_port *up = (struct uart_txx9_port *)port; > + > + sio_out(up, TXX9_SIFCR, TXX9_SIFCR_SWRST); > +#ifdef CONFIG_CPU_TX49XX > + /* TX4925 BUG WORKAROUND. Accessing SIOC register > + * immediately

Re: [RFC PATCH(Experimental) 2/4] Revert changes to workqueue.c

2007-02-21 Thread Srivatsa Vaddagiri
On Wed, Feb 21, 2007 at 05:30:10PM +0300, Oleg Nesterov wrote: > Agreed. Note that we don't need the new "del_work". It is always safe to > use cancel_work_sync() if we know that the workqueue is frozen, it won't > block. We can also do > > if (!cancel_delayed_work()) > cancel_

Re: Linux 2.6.21-rc1

2007-02-21 Thread Kok, Auke
Thomas Gleixner wrote: On Tue, 2007-02-20 at 20:53 -0800, Linus Torvalds wrote: But there's a ton of architecture updates (arm, mips, powerpc, x86, you name it), ACPI updates, and lots of driver work. And just a lot of cleanups. Have fun, Yup. Fun starts in drivers/net/e1000 e1000 is not w

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-21 Thread Paul Sokolovsky
Hello Rodolfo, Wednesday, February 21, 2007, 4:53:53 PM, you wrote: > Backlight control support for the PXA fram buffer. Here're some comments: backlight support is already confusing matter, and your patch IMHO makes it even more confusing for PXAFB. Before even start with details, let's f

Advice on backlight support

2007-02-21 Thread Rodolfo Giometti
Hello, I'd like to add backlight support for input devices since my custom board has a backlighted mini keyboard. It could be acceptable to move the code from drivers/video/backlight/ to drivers/backlight/ renaming the "Backlight & LCD" name into "Backlight" and adding two new entries "LCD" and,

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-21 Thread Rodolfo Giometti
On Wed, Feb 21, 2007 at 06:00:37PM +0200, Paul Sokolovsky wrote: > > On the other hand, there's already > drivers/video/backlight/backlight.c which provides generic BL support, > implemented using notifier callback for FB core. Moreover, there's My patch _uses_ that support. > corgi_bl.c drive

The purpose and implementation of cond_resched()

2007-02-21 Thread Dong Feng
I have a question about cond_resched(). What is the condition under which I should invoke cond_resched() irreplaceably? For example, I see the following code in ksoftirqd(), preempt_enable_no_resched(); cond_resched(); preempt_disable(); But I do not understand why I should not write the follo

Re: Advice on backlight support

2007-02-21 Thread Paul Sokolovsky
Hello Rodolfo, Wednesday, February 21, 2007, 6:02:13 PM, you wrote: > Hello, > I'd like to add backlight support for input devices since my custom > board has a backlighted mini keyboard. There's already generic indicator API, currently mostly known as "[new] LED [classdev] API", even though

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-02-21 Thread H. Peter Anvin
Rodolfo Giometti wrote: The problem is that sometimes you cannot have a filedescriptor at all. Think about a PPS source connected with a CPU's GPIO pin. You have no filedes to use and defining one just for a PPS source or for a class of PPS sources, I think, is a non sense. If you have a kern

Re: 2.6.20-git and 2.6.21-rc1, failed to boot on sata_via

2007-02-21 Thread Markus Trippelsdorf
On Wed, Feb 21, 2007 at 03:01:54PM +0100, Jean-Luc Coulon (f5ibh) wrote: > > At boot time, I've the following messages: > > ACPI: PCI Interrupt :00:0f.0[B] GSI 20(level, low) -> IRQ 20 > sata_via :00:0f.0: failed on iomap PCI BAR 0 > sata_via :00:0f.0: out of memory > ACPI: PCI interru

request_module: runaway loop modprobe net-pf-1 (is Re: Linux 2.6.21-rc1)

2007-02-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Tue, 20 Feb 2007 20:53:45 -0800 (PST)), Linus Torvalds <[EMAIL PROTECTED]> says: > But there's a ton of architecture updates (arm, mips, powerpc, x86, you > name it), ACPI updates, and lots of driver work. And just a lot of > cleanups. I cannot boot 2

Re: [PATCH 1/1] PXAFB: Support for backlight control

2007-02-21 Thread Paul Sokolovsky
Hello Rodolfo, Wednesday, February 21, 2007, 6:12:10 PM, you wrote: > On Wed, Feb 21, 2007 at 06:00:37PM +0200, Paul Sokolovsky wrote: >> >> On the other hand, there's already >> drivers/video/backlight/backlight.c which provides generic BL support, >> implemented using notifier callback for F

Re: Linux 2.6.21-rc1

2007-02-21 Thread Daniel Walker
On Tue, 2007-02-20 at 20:53 -0800, Linus Torvalds wrote: > Ok, the merge window for 2.6.21 has closed, and -rc1 is out there. > > There's a lot of changes, as is usual for an -rc1 thing, but at least so > far it would seem that 2.6.20 has been a good base, and I don't think we > have anything *r

Re: [PATCH] Fix trivial help text typos in Kconfig* files

2007-02-21 Thread Randy Dunlap
On Wed, 21 Feb 2007 09:16:28 +0100 David Sterba wrote: > (patch against 2.6.21-rc1) > > Fix several typos in help text in Kconfig* files. > > Signed-off-by: David Sterba <[EMAIL PROTECTED]> Looks good except for one item below. Thanks. > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 08

Re: [patch 00/21] 2.6.19-stable review

2007-02-21 Thread Chuck Ebbert
Greg KH wrote: > This is the start of the stable review cycle for the 2.6.19.5 release. > > This will probably be the last release of the 2.6.19-stable series, so > if there are patches that you feel should be applied to that tree, > please let me know. The attached patch is in 2.6.20 and fixes p

Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver

2007-02-21 Thread Jaya Kumar
On 2/20/07, Jaya Kumar <[EMAIL PROTECTED]> wrote: On 2/19/07, Paul Mundt <[EMAIL PROTECTED]> wrote: > That works for me, though I'd prefer for struct page_list to be done with > a scatterlist, then it's trivial to setup from the workqueue context > without having to shuffle things around. > Ok.

Re: SATA ahci Bug in 2.6.19.x

2007-02-21 Thread Manuel Metz
Tejun Heo wrote: > Does it work if you give 'irqpoll' kernel parameter? > Yes this works with "irqpoll". But as you can see in the attached dmesg output, now I get a bunch of APIC errors ... ? Linux version 2.6.20.1 ([EMAIL PROTECTED]) (gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21

Re: Kernel oops in 2.6.18.3 with RAID5

2007-02-21 Thread Jan Engelhardt
> > Update: I think that you can ignore this error. I am getting > segmentation faults when I attempt to rebuild the kernel. This is > exactly the same problem I had with slackware 10.1 with the 2.6.10 > kernel. So I think it is a hardware issue. Memtest86 didn't show any > errors after 35 passes,

Re: [patch 00/21] 2.6.19-stable review

2007-02-21 Thread Chuck Ebbert
Greg KH wrote: > This is the start of the stable review cycle for the 2.6.19.5 release. > > This will probably be the last release of the 2.6.19-stable series, so > if there are patches that you feel should be applied to that tree, > please let me know. > The attached fixes an oops in the usbnet

Re: [PATCH 2.6.20 1/1] fbdev,mm: hecuba/E-Ink fbdev driver

2007-02-21 Thread Jaya Kumar
On 2/20/07, Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: Don't you need a way to specify the maximum deferral time? E.g. a field in fb_info. You are right. I will need that. I could put that into struct fb_deferred_io. So drivers would setup like: static struct fb_deferred_io hecubafb_defio

[PATCH] namespaces: update some function names

2007-02-21 Thread Serge E. Hallyn
From: Serge E. Hallyn <[EMAIL PROTECTED]> Subject: [PATCH] namespaces: update some function names The {get,exit}_task_namespaces do not grab references to the individual namespaces, only to the nsproxy. Reflect that in the function names. Not so important right now, but when pid_ns gets pulled o

Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update

2007-02-21 Thread Ralf Baechle
On Wed, Feb 21, 2007 at 04:48:26PM +, Alan wrote: > Given this costs 1uS in a path that is not performance critical is it > worth putting the #ifdef/#endif in instead of having one set of code that > works for all ? > > > + while (sio_in(up, TXX9_SIFCR) & TXX9_SIFCR_SWRST) > > + ;

Re: Linux 2.6.21-rc1

2007-02-21 Thread Thomas Gleixner
On Wed, 2007-02-21 at 08:24 -0800, Daniel Walker wrote: > > The most interesting core change may be the dyntick/nohz one, where timer > > ticks will only happen when needed. It's been brewing for a _loong_ time, > > but it's in the standard kernel now as an option. > > On i386 I get the followi

Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update

2007-02-21 Thread Atsushi Nemoto
On Wed, 21 Feb 2007 16:48:26 +, Alan <[EMAIL PROTECTED]> wrote: > > +#ifdef CONFIG_CPU_TX49XX > > + /* TX4925 BUG WORKAROUND. Accessing SIOC register > > +* immediately after soft reset causes bus error. */ > > + iob(); > > + udelay(1); > > +#endif > > Given this costs 1uS in a path

Re: data corruption with nvidia chipsets and IDE/SATA drives (k8 cpu errata needed?)

2007-02-21 Thread Chip Coldwell
On Wed, 17 Jan 2007, Andi Kleen wrote: > On Wednesday 17 January 2007 07:31, Chris Wedgwood wrote: > > On Tue, Jan 16, 2007 at 08:52:32PM +0100, Christoph Anton Mitterer wrote: > > > I agree,... it seems drastic, but this is the only really secure > > > solution. > > > > I'd like to here from Andi

Re: The purpose and implementation of cond_resched()

2007-02-21 Thread Dong Feng
I re-checked the code. And this time, I think cond_resched() is useful while a kernel is compiled with no full preemption function but only voluntary kernel preemption is enabled (i.e. CONFIG_PREEMPT_VOLUNTARY is set but CONFIG_PREEMPT is not set). In this case, kernel performs scheduling at expli

Re: [PATCH] namespaces: update some function names

2007-02-21 Thread Kirill Korotaev
Acked-By: Kirill Korotaev <[EMAIL PROTECTED]> > From: Serge E. Hallyn <[EMAIL PROTECTED]> > Subject: [PATCH] namespaces: update some function names > > The {get,exit}_task_namespaces do not grab references to the individual > namespaces, only to the nsproxy. Reflect that in the function names. >

Re: securityfs_create_dir strange comment

2007-02-21 Thread Jan Engelhardt
Hello Greg, On Feb 20 2007 20:05, Greg KH wrote: > >Try this instead: > if (!de) > return -ENOMEM; > if ((IS_ERR(de)) && (PTR_ERR(de) != -ENODEV)) > return PTR_ERR(de); > return 0; > >That should cover everything properly, right? In case memory could

Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update

2007-02-21 Thread Alan
> Then I'll put udelay() and a timeout counter for it. If udelay() was > in the busy loop, cpu_relax() is still recommended? The udelay should deal with it for you. > Here is a patch on top of the previous one. If this was OK I'll fold > it into one patch. Looks good to me > + while ((si

[PATCH] Fix misspellings collected by members of KJ list.

2007-02-21 Thread Robert P. J. Day
Fix the misspellings of "propogate", "writting" and (oh, the shame :-) "kenrel" in the source tree. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- Documentation/sysctl/kernel.txt |2 +- arch/powerpc/oprofile/op_model_cell.c |2 +- arch/x86_64/kernel/io_apic.c

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Jan Engelhardt
On Feb 21 2007 11:00, Giuseppe Bilotta wrote: >On Wednesday 21 February 2007 02:49, Greg KH wrote: > >> /* frame pointer must be last for get_wchan */ >> -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" >> +#define SAVE_

[PATCH 2.6.21-rc1] serial: serial_txx9 driver update (take 2)

2007-02-21 Thread Atsushi Nemoto
Update the serial_txx9 driver. * Use platform_device. * Fix and cleanup suspend/resume/initialization codes. Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> --- diff --git a/drivers/serial/serial_txx9.c b/drivers/serial/serial_txx9.c index f4440d3..509ac

Re: Linux 2.6.21-rc1

2007-02-21 Thread Daniel Walker
On Wed, 2007-02-21 at 18:07 +0100, Thomas Gleixner wrote: > On Wed, 2007-02-21 at 08:24 -0800, Daniel Walker wrote: > > > The most interesting core change may be the dyntick/nohz one, where timer > > > ticks will only happen when needed. It's been brewing for a _loong_ time, > > > but it's in the

Re: [patch 03/18] Dont leak NT bit into next task

2007-02-21 Thread Chuck Ebbert
Giuseppe Bilotta wrote: > On Wednesday 21 February 2007 02:49, Greg KH wrote: > >> /* frame pointer must be last for get_wchan */ >> -#define SAVE_CONTEXT"pushq %%rbp ; movq %%rsi,%%rbp\n\t" >> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" >> +#define SAVE_CONTEXT"pushf ; p

Re: Expertise required:USB bulk-throughput and memory leak detection

2007-02-21 Thread Michael Richardson
[EMAIL PROTECTED] wrote: 1.) detecting memory leaks caused by our driver code. Your code will of course be allocating buffers. If you are allocating from a specific slab, if you have leaks, they will show up in /proc/slabinfo I wrote some code last month, which I called slabwatch, to track eac

Re: [PATCH] Fix misspellings collected by members of KJ list.

2007-02-21 Thread Randy Dunlap
On Wed, 21 Feb 2007 12:10:44 -0500 (EST) Robert P. J. Day wrote: > > Fix the misspellings of "propogate", "writting" and (oh, the shame > :-) "kenrel" in the source tree. We also knohow to spel "depreciated". (well, only 6 in 2.6.21-rc1) --- ~Randy *** Remember to use Documentation/SubmitChec

Re: securityfs_create_dir strange comment

2007-02-21 Thread Greg KH
On Wed, Feb 21, 2007 at 06:07:56PM +0100, Jan Engelhardt wrote: > Hello Greg, > > > On Feb 20 2007 20:05, Greg KH wrote: > > > >Try this instead: > > if (!de) > > return -ENOMEM; > > if ((IS_ERR(de)) && (PTR_ERR(de) != -ENODEV)) > > return PTR_ERR(de); > > retu

Re: 2.6.20-git and 2.6.21-rc1, failed to boot on sata_via

2007-02-21 Thread Jean-Luc Coulon (f5ibh)
Le 21.02.2007 17:18:23, Markus Trippelsdorf a écrit : On Wed, Feb 21, 2007 at 03:01:54PM +0100, Jean-Luc Coulon (f5ibh) wrote: At boot time, I've the following messages: ACPI: PCI Interrupt :00:0f.0[B] GSI 20(level, low) -> IRQ 20 sata_via :00:0f.0: failed on iomap PCI BAR 0 sata_via 0

Re: Linux 2.6.21-rc1

2007-02-21 Thread Thomas Gleixner
On Wed, 2007-02-21 at 09:19 -0800, Daniel Walker wrote: > > At this point the PIT / HPET _is_ active and incrementing jiffies. The > > switch to local apic timers happens afterwards. > > Could be the switch over then which confuses the NMI . Why? The switch just stops the PIT/HPET. It does not

Re: [stable] [patch 00/18] 2.6.18-stable review

2007-02-21 Thread Greg KH
On Wed, Feb 21, 2007 at 01:55:04PM +0200, S.??a??lar Onur wrote: > 21 ??ub 2007 ??ar tarihinde, Greg KH ??unlar?? yazmt??: > > Responses should be made by Friday February 23 00:00 UTC. Anything > > received after that time might be too late. > > We have still some CVEish patches in our packa

Re: Linux 2.6.21-rc1

2007-02-21 Thread Daniel Walker
On Wed, 2007-02-21 at 18:41 +0100, Thomas Gleixner wrote: > On Wed, 2007-02-21 at 09:19 -0800, Daniel Walker wrote: > > > At this point the PIT / HPET _is_ active and incrementing jiffies. The > > > switch to local apic timers happens afterwards. > > > > Could be the switch over then which confus

[PATCH] cleanup up symlinks

2007-02-21 Thread James Simmons
When a device fails to register the class symlinks where not cleaned up. This left a symlink in the /sys/class/"device"/ directory that pointed to no where. This caused the sysfs_follow_link Oops I reported earlier. This patch cleanups up the symlink. Please apply. Thank you. Signed-Off: James

[2.6 patch] drivers/hid/hid-debug.c should #include

2007-02-21 Thread Adrian Bunk
Every file should include the headers containing the prototypes for it's global functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.20-mm2/drivers/hid/hid-debug.c.old2007-02-20 23:07:32.0 +0100 +++ linux-2.6.20-mm2/drivers/hid/hid-debug.c2007-02-21 00:

Re: [2.6 patch] drivers/hid/hid-debug.c should #include

2007-02-21 Thread Jiri Kosina
On Wed, 21 Feb 2007, Adrian Bunk wrote: > Every file should include the headers containing the prototypes for > it's global functions. Applied, thanks. -- Jiri Kosina - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: [PATCH] UML utrace support, step 1

2007-02-21 Thread Roland McGrath
> Below is the first step in your Fix-Your-Broken-Arch-HOWTO for UML. Great! Thanks for tackling this. > Do you want incremental patches as I go along, or replacement ones? The way I've organized my patch series is with the arch support split up along with the separate infrastructure patches in

x86_64: PTRACE_[GS]ET_THREAD_AREA should be accepted

2007-02-21 Thread Paolo 'Blaisorblade' Giarrusso
This patch backports from 2.6.19 a fix to a 2.6.18 regression. Like for PTRACE_OLDSETOPTIONS, we should fix PTRACE_[GS]ET_THREAD_AREA. This had been done already for 2.6.19, so this is for 2.6.18-stable only. This was tested with UML/32bit as API consumer, both before and after this patch. Cc: An

Re: securityfs_create_dir strange comment

2007-02-21 Thread Jan Engelhardt
Hi Greg, >> >Try this instead: >> >if (!de) >> >return -ENOMEM; >> >if ((IS_ERR(de)) && (PTR_ERR(de) != -ENODEV)) >> >return PTR_ERR(de); >> >return 0; >> > >> >That should cover everything properly, right? >> >> In case memory could not be allocated, why does

Re: [PATCH] slab: ensure cache_alloc_refill terminates

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka J Enberg wrote: > + */ > + BUG_ON(slabp->inuse < 0 || slabp->inuse >= cachep->num); > + > while (slabp->inuse < cachep->num && batchcount--) { I think you only need to check for <0. If slabp->inuse > cachep->num then the loop will

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka Enberg wrote: > On 2/21/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > please mark this one __must_check.. not storing realloc() return values > > is one of the more nasty types of bugs... but gcc can help us greatly > > here ;) > > So I guess we want the same thin

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka J Enberg wrote: > +void *krealloc(const void *p, size_t new_size, gfp_t flags) > +{ > + void *ret; > + > + if (unlikely(!p)) > + return kmalloc_track_caller(new_size, flags); > + > + if (unlikely(!new_size)) { > + kfree(p); > +

Re: High CPU usage with sata_nv

2007-02-21 Thread Lee Revell
On 2/21/07, Matthew Fredrickson <[EMAIL PROTECTED]> wrote: It's a 2.6.18 kernel. What we're seeing (by means of the interrupt pin on another card) is extremely large interrupt latency (measured from the time the interrupt pin goes low to the first couple lines of code in the IRQ handler to clear

[patch 1/1] MM: detach_vmas_to_be_unmapped fix

2007-02-21 Thread akuster
--- mm/mmap.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN mm/mmap.c~Avoiding-mmap-fragmentation_fixup mm/mmap.c --- linux-2.6_clean/mm/mmap.c~Avoiding-mmap-fragmentation_fixup 2007-02-21 09:49:32.0 -0800 +++ linux-2.6_clean-akuster/mm/mmap.c 2007-02-21 09:

Re: PCI riser cards and PCI irq routing, etc

2007-02-21 Thread Udo van den Heuvel
BTW: Is the situation, with default DN setting of 19 as displayed below, `normal` w.r.t. interrupts? I mean: Both the DVB card with DN19 and the Unichrome Pro video adapter have the same irq although they are on different busses. (...) 00:13.0 Multimedia controller: Philips Semiconductors SAA7146

Re: Linux 2.6.21-rc1

2007-02-21 Thread Thomas Gleixner
On Wed, 2007-02-21 at 09:38 -0800, Daniel Walker wrote: > > > > > > Could be the switch over then which confuses the NMI . > > > > Why? The switch just stops the PIT/HPET. It does not fiddle with IO_APIC > > and friends at all. > > I'm not an expert on the io-apic, but the check_timer() functio

Re: freezer problems

2007-02-21 Thread Paul E. McKenney
On Tue, Feb 20, 2007 at 07:29:01PM +0100, Rafael J. Wysocki wrote: > On Tuesday, 20 February 2007 01:32, Rafael J. Wysocki wrote: > > On Tuesday, 20 February 2007 01:12, Oleg Nesterov wrote: > > Hm. In the case discussed above we have a task that's right before calling > > frozen_process(), so we

Re: freezer problems

2007-02-21 Thread Rafael J. Wysocki
On Wednesday, 21 February 2007 19:14, Paul E. McKenney wrote: > On Tue, Feb 20, 2007 at 07:29:01PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, 20 February 2007 01:32, Rafael J. Wysocki wrote: > > > On Tuesday, 20 February 2007 01:12, Oleg Nesterov wrote: > > > Hm. In the case discussed above w

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Pekka Enberg
Christoph Lameter wrote: Well could you check ksize for the old object first and if ksize <= new size then just skip the copy? I think this may allow you to get rid of the ksize callers. And not reallocate at all, right? I thought about that but then you wouldn't be able to use realloc() to m

Re: [PATCH] slab: ensure cache_alloc_refill terminates

2007-02-21 Thread Pekka Enberg
On Wed, 21 Feb 2007, Pekka J Enberg wrote: > + */ > + BUG_ON(slabp->inuse < 0 || slabp->inuse >= cachep->num); > + > while (slabp->inuse < cachep->num && batchcount--) { On 2/21/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: I think you only need to che

Re: Linux 2.6.21-rc1

2007-02-21 Thread Daniel Walker
On Wed, 2007-02-21 at 19:18 +0100, Thomas Gleixner wrote: > On Wed, 2007-02-21 at 09:38 -0800, Daniel Walker wrote: > > > > > > > > Could be the switch over then which confuses the NMI . > > > > > > Why? The switch just stops the PIT/HPET. It does not fiddle with IO_APIC > > > and friends at all

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Zach Brown
On Feb 21, 2007, at 12:35 AM, Ken Chen wrote: On 2/20/07, Ananiev, Leonid <[EMAIL PROTECTED]> wrote: 1) mem=1G in kernel boot param if you have more 2) unmount; mk2fs; mount 3) dd if=/dev/zero of= bs=1M count=1200 4) aiostress -s 1200m -O -o 2 -i 1 -r 16k 5) if i++<50 goto 2). Would you ple

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka Enberg wrote: > Christoph Lameter wrote: > > Well could you check ksize for the old object first and if ksize <= new size > > then just skip the copy? I think this may allow you to get rid of the ksize > > callers. > > And not reallocate at all, right? I thought about t

Re: freezer problems

2007-02-21 Thread Paul E. McKenney
On Wed, Feb 21, 2007 at 07:13:40PM +0100, Rafael J. Wysocki wrote: > On Wednesday, 21 February 2007 19:14, Paul E. McKenney wrote: > > On Tue, Feb 20, 2007 at 07:29:01PM +0100, Rafael J. Wysocki wrote: > > > On Tuesday, 20 February 2007 01:32, Rafael J. Wysocki wrote: > > > > On Tuesday, 20 Februar

Re: [PATCH] slab: ensure cache_alloc_refill terminates

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka Enberg wrote: > ...and batchcount is not decremented and we're effectively in an > infinite loop. Or am I missing something here? No you are right. Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [stable] [patch 00/18] 2.6.18-stable review

2007-02-21 Thread S.Çağlar Onur
Hi; 21 Şub 2007 Çar tarihinde, Greg KH şunları yazmıştı: > On Wed, Feb 21, 2007 at 01:55:04PM +0200, S.??a??lar Onur wrote: > > 21 ??ub 2007 ??ar tarihinde, Greg KH ??unlar?? yazmt??: > > > Responses should be made by Friday February 23 00:00 UTC. Anything > > > received after that time migh

Re: [ANNOUNCE] DualFS: File System with Meta-data and Data Separation

2007-02-21 Thread Juan Piernas Canovas
Hi Jörn, On Wed, 21 Feb 2007, [utf-8] Jörn Engel wrote: On Wed, 21 February 2007 05:36:22 +0100, Juan Piernas Canovas wrote: I don't see how you can guarantee 50% free segments. Can you explain that bit? It is quite simple. If 50% of your segments are busy, and the other 50% are free, and t

Re: [PATCH 2/3] slab: export ksize to modules

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Muli Ben-Yehuda wrote: > On Wed, Feb 21, 2007 at 10:06:52AM +0200, Pekka J Enberg wrote: > > From: Pekka Enberg <[EMAIL PROTECTED]> > > > > This exports ksize in slab and slob allocators to modules. > > That's a pretty generic name... if it's going to be part of the module >

Re: Linux 2.6.21-rc1

2007-02-21 Thread Andreas Schwab
I'm getting an undefined symbol with CONFIG_AGP=m: WARNING: "compat_agp_ioctl" [drivers/char/agp/agpgart.ko] undefined! Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D

Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Zach Brown
This is an interesting trick, but I'd like to consider hard whether the added complexity is worth it. Could you list the various other cases you have in mind which would want to use it ? I'm happy to report that the sync case and the invalidate_inode_pages2_range() case are the only two wh

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Pekka Enberg
Hi Christoph, Christoph Lameter wrote: 1. Just do not allow shrinking via realloc. Probably no big loss and best performance. Not a big loss if you can afford the wasted memory. But, I don't think we should do this, there's no way for the caller to know that we will hold on to the memory ind

Re: Linux 2.6.21-rc1

2007-02-21 Thread Dave Jones
On Wed, Feb 21, 2007 at 07:34:01PM +0100, Andreas Schwab wrote: > I'm getting an undefined symbol with CONFIG_AGP=m: > > WARNING: "compat_agp_ioctl" [drivers/char/agp/agpgart.ko] undefined! Fix went to Linus an hour ago. It's been in -mm for a week, and agpgart.git for a day or so.

Re: Linux 2.6.21-rc1

2007-02-21 Thread Jiri Slaby
Faik Uygur napsal(a): Hi, Hi. 21 Şub 2007 Çar 06:53 tarihinde, Linus Torvalds şunları yazmıştı: Ok, the merge window for 2.6.21 has closed, and -rc1 is out there. CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h CC [M] drivers/char

Re: [stable] [patch 00/18] 2.6.18-stable review

2007-02-21 Thread Ismail Dönmez
On Wednesday 21 February 2007 19:34:45 Greg KH wrote: > On Wed, Feb 21, 2007 at 01:55:04PM +0200, S.??a??lar Onur wrote: > > 21 ??ub 2007 ??ar tarihinde, Greg KH ??unlar?? yazmt??: > > > Responses should be made by Friday February 23 00:00 UTC. Anything > > > received after that time might be

Re: [PATCH 2.6.21-rc1] serial: serial_txx9 driver update (take 2)

2007-02-21 Thread Ralf Baechle
On Thu, Feb 22, 2007 at 02:17:28AM +0900, Atsushi Nemoto wrote: > Update the serial_txx9 driver. > > * Use platform_device. > * Fix and cleanup suspend/resume/initialization codes. > > Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]> > Acked-by: Alan Cox <[EMAIL PROTECTED]> Andrew, I've appl

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka Enberg wrote: > Christoph Lameter wrote: > > 2. Check if the size specified is larger than the next smallest general > > cache and only copy if we would really would allocate from a different > > cache. > > Yeah, I was thinking about this too but decided against it (for

Re: Linux 2.6.21-rc1

2007-02-21 Thread Jiri Slaby
Jiri Slaby napsal(a): Faik Uygur napsal(a): Hi, Hi. 21 Şub 2007 Çar 06:53 tarihinde, Linus Torvalds şunları yazmıştı: Ok, the merge window for 2.6.21 has closed, and -rc1 is out there. CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h

Re: PCI riser cards and PCI irq routing, etc

2007-02-21 Thread Udo van den Heuvel
Lennart Sorensen wrote: > On Wed, Feb 21, 2007 at 10:24:28AM +0100, Udo van den Heuvel wrote: >> Udo van den Heuvel wrote: >> So, if not (as in my situation) how can I find out what is wrong? >> Or find out if the BIOS works OK with the card? >> How can I verify that the correct routing for the IRQ

Re: 2.6.21-rc1 build error on ARM with modular IPV6

2007-02-21 Thread Michael-Luke Jones
Kernel Bugzilla bug created: http://bugzilla.kernel.org/show_bug.cgi?id=8050 Michael-Luke Jones On 21 Feb 2007, at 14:36, Michael-Luke Jones wrote: Apologies for brain failure, below should read 2.6.21-rc1. Everything else should be correct. Michael-Luke Jones On 21 Feb 2007, at 10:50, M.L.

RE: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event

2007-02-21 Thread Ananiev, Leonid I
> kjournald submited buffers for IO and waiting for them to finish. It is means that the patch incorrectly moves internal kernel synchronization problem into user space as EIO instead of fixing a root cause or perform iterative synchronization. After patching users will be surprised a lot of EIO (

Re: Linux 2.6.21-rc1

2007-02-21 Thread Thomas Gleixner
On Wed, 2007-02-21 at 10:23 -0800, Daniel Walker wrote: > Right, but eventually there isn't a regular timer interrupt through the > io-apic. I don't think in the past IRQ0 stops without the system > crashing, so check_timer() could assume the timer (IRQ0) is _always_ > regular. > > do you know wha

Re: Linux 2.6.21-rc1

2007-02-21 Thread Linus Torvalds
On Wed, 21 Feb 2007, Faik Uygur wrote: > > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CHK include/linux/compile.h > CC [M] drivers/char/ip2/ip2main.o > In file included from drivers/char/ip2/ip2main.c:285: > drivers/char/ip2/i2lib.c: In function `iiSendPe

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Pekka Enberg
On 2/21/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: Why not? Its a realloc call and these are the classic semantics of realloc. Otherwise realloc will always move the memory. Well, as a reference, the user-space equivalent is defined in SUSv3 as: "The realloc() function shall change the s

Re: cat problem in tiny_tty driver (the source included)

2007-02-21 Thread Lennart Sorensen
On Wed, Feb 21, 2007 at 06:03:16PM +0300, Mockern wrote: > I tried to check cat operations for tiny_tty driver from LDD book. > > What is wrong with cat operation here? > > Here is the output from strace cat hello > /dev/my_tty1 > > [EMAIL PROTECTED]:/home# strace cat hello > /dev/my_tty1 > exe

Re: PCI riser cards and PCI irq routing, etc

2007-02-21 Thread Lennart Sorensen
On Wed, Feb 21, 2007 at 03:59:51PM +0100, Udo van den Heuvel wrote: > But the IRQ for the DVB-T card doesn't work. > I would need to test the DVB-T card alone to be sure it has working IRQ. > If so, what would be the conclusion? Well the BIOS makes an assumption about the irq routing on the board,

Re: [PATCH 1/3] slab: introduce krealloc

2007-02-21 Thread Christoph Lameter
On Wed, 21 Feb 2007, Pekka Enberg wrote: > Well, as a reference, the user-space equivalent is defined in SUSv3 as: > > "The realloc() function shall change the size of the memory object > pointed to by ptr to the size specified by size." The realloc functions intent is to leave the object in pla

Re: Linux 2.6.21-rc1

2007-02-21 Thread Linus Torvalds
On Wed, 21 Feb 2007, Kok, Auke wrote: > > I think we need to drop this now. The report that says that this *fixes* > something might have been on regular interrupts only. I currently suspect that > it breaks all MSI interrupts, which would make sense if I look a the code. > Very bad indeed. > >

Re: Linux 2.6.21-rc1

2007-02-21 Thread Daniel Walker
On Wed, 2007-02-21 at 20:23 +0100, Thomas Gleixner wrote: > On Wed, 2007-02-21 at 10:23 -0800, Daniel Walker wrote: > > Right, but eventually there isn't a regular timer interrupt through the > > io-apic. I don't think in the past IRQ0 stops without the system > > crashing, so check_timer() could a

Re: [ANNOUNCE] DualFS: File System with Meta-data and Data Separation

2007-02-21 Thread Jörn Engel
On Wed, 21 February 2007 19:31:40 +0100, Juan Piernas Canovas wrote: > > I do not understand. Do you mean that if I have 10 segments, 5 busy and 5 > free, after cleaning I could need 6 segments? How? Where the extra blocks > come from? This is a fairly complicated subject and I have trouble exp

Re: cat problem in tiny_tty driver (the source included)

2007-02-21 Thread Mockern
Thank you very much for you help. BTW, for cat < /dev/my_tty1 can see here something wrong? as I understand tiny_timer function sends data to tty level by calling tty_flip_buffer_push(tty). Is this enough to support cat < /dev/my_tty1? >On Wed, Feb 21, 2007 at 06:03:16PM +0300, Mockern wrote: >

Re: [patch 00/21] 2.6.19-stable review

2007-02-21 Thread Chuck Ebbert
Greg KH wrote: > This is the start of the stable review cycle for the 2.6.19.5 release. > > This will probably be the last release of the 2.6.19-stable series, so > if there are patches that you feel should be applied to that tree, > please let me know. > > There are 21 patches in this series, al

Re: PCI riser cards and PCI irq routing, etc

2007-02-21 Thread Krzysztof Halasa
Udo van den Heuvel <[EMAIL PROTECTED]> writes: > But the IRQ for the DVB-T card doesn't work. That's because the card drives incorrect INT line. The system (BIOS, Linux) thinks the card would drive INT_D (as seen at the MB PCI slot) and and card drives (its INT_A) INT_B. > I would need to test t

Re: [RFC PATCH(Experimental) 0/4] Freezer based Cpu-hotplug

2007-02-21 Thread Pavel Machek
Hi! > Rafael, > On Sat, Feb 17, 2007 at 12:24:45PM +0100, Rafael J. Wysocki wrote: > > > > Pavel, do you think we can remove the PF_NOFREEZE from bluetooth, BTW? > > The create_workqueue by default marks the worker_threads to be > non_freezable. For cpu hotplug, all workqueues can be frozen > e

<    1   2   3   4   5   6   >