Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Satyam Sharma
On 5/12/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > > Because volatile is ill-defined? Or actually, *undefined* (well, > implementation-defined is as good as that)? It's *so* _vague_, > one doesn't _feel_ like using it at all! > Sorry, that's just utter crap. Linux isn'

Re: [PATCH 1/1] LinuxPPS: Pulse per Second support for Linux

2007-05-12 Thread Greg KH
On Fri, May 11, 2007 at 11:17:11PM -0700, Andrew Morton wrote: > On Fri, 11 May 2007 23:55:37 +0200 > Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > here my new patch with a lot of fixes. > > > > The only issue not still fixed is the one related with: > > > > #define NETLI

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread H. Peter Anvin
Satyam Sharma wrote: >> >> Sorry, that's just utter crap. Linux isn't written in some mythical C >> which only exists in standard document, it is written in a particular >> subset of GNU C. "volatile" is well enough defined in that context, it >> is just frequently misused. > > Of course, volati

Re: [PATCH] module_author: don't advice putting in an email address

2007-05-12 Thread Adrian Bunk
On Fri, May 11, 2007 at 10:35:00PM +0100, Alan Cox wrote: > > This still wouldn't solve the following problems: > > - I doubt it will be kept up to date for all > 2800 modules in the kernel > > - the 3 year old kernel of your distribution would contain 3 year old > > maintainership information >

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Stefan Richter
Satyam Sharma wrote: > Coming back to the document, we do need to document / find > consensus on the "preferred" way to do similar business in the > kernel, and my opinion as far as that is concerned is to shun > volatile wherever possible (which includes the case originally > discussed above). I

Re: [PATCH] mm: swap prefetch improvements

2007-05-12 Thread Con Kolivas
On Saturday 12 May 2007 15:51, Paul Jackson wrote: > Con wrote: > > Hmm I'm not really sure what it takes to make it cpuset aware; > > ... > > It is numa aware to some degree. It stores the node id and when it starts > > prefetching it only prefetches to nodes that are suitable for prefetching > >

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Satyam Sharma
On 5/12/07, H. Peter Anvin <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: >> >> Sorry, that's just utter crap. Linux isn't written in some mythical C >> which only exists in standard document, it is written in a particular >> subset of GNU C. "volatile" is well enough defined in that context,

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread jimmy bahuleyan
Stefan Richter wrote: > Satyam Sharma wrote: >> Coming back to the document, we do need to document / find >> consensus on the "preferred" way to do similar business in the >> kernel, and my opinion as far as that is concerned is to shun >> volatile wherever possible (which includes the case origin

Re: [PATCH 1/2] scalable rw_mutex

2007-05-12 Thread Peter Zijlstra
On Sat, 2007-05-12 at 03:00 +0400, Oleg Nesterov wrote: > On 05/11, Peter Zijlstra wrote: > > > > +static inline int __rw_mutex_read_trylock(struct rw_mutex *rw_mutex) > > +{ > > + preempt_disable(); > > + if (likely(!__rw_mutex_reader_slow(rw_mutex))) { > > --- WINDOW --- > > > +

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Jeff Garzik
jimmy bahuleyan wrote: i believe, the doc here is pretty unambiguous regarding the fact that volatile should be avoided. And as Stefan pointed out, anyone who feels the need to use, must surely _know_ what he is doing & hence is in a position t make that decision Honestly, the above quoted para

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Stefan Richter
H. Peter Anvin wrote: [slightly off topic: GCCisms in Linux kernel] > It contains *many* constructs that are not defined in, for > example, C99, and it would in fact be impossible to write the Linux > kernel using only C99-compliant constructs. True. On the other hand, it is possible to keep larg

Re: [PATCH] spelling fixes: arch/frv/

2007-05-12 Thread David Howells
Simon Arlott <[EMAIL PROTECTED]> wrote: > Spelling fixes in arch/frv/. Acked-By: David Howells <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread David Chinner
On Fri, May 11, 2007 at 07:48:26AM -0700, Jeremy Fitzhardinge wrote: > David Chinner wrote: > >> Yes, that does look like a good candidate. Should I try to > >> before-and-after this change? > >> > > > > Yes please! > > > > OK, definite result. Before ba87ea699ebd9dd577bf055ebc4a98200e33

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-12 Thread David Chinner
On Fri, May 11, 2007 at 04:33:01PM +0530, Suparna Bhattacharya wrote: > On Fri, May 11, 2007 at 08:39:50AM +1000, David Chinner wrote: > > All I'm really interested in right now is that the fallocate > > _interface_ can be used as a *complete replacement* for the > > pre-existing XFS-specific ioctl

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Simon Arlott
On 12/05/07 02:03, Finn Thain wrote: On Fri, 11 May 2007, Simon Arlott wrote: - * Local routines to interrcept the standard I/O and vector handling - * code. Don't include this 'till now - initialization code above needs + * Local routines to intercept the standard I/O and vector h

Re: [PATCH] mm: swap prefetch improvements

2007-05-12 Thread Paul Jackson
> Ummm this is what I've been saying for over a year now but noone has been > listening. Well ... if there is a problem using prefetch and cpusets together, it doesn't look like the two of us are going to find it. I should probably look at your patch to answer this next question, but being a laz

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Gautham R Shenoy
On Sat, May 12, 2007 at 02:01:41AM +0200, Rafael J. Wysocki wrote: > > > So you migt as well not return any value at all, since the returned value > > is apparently meaningless once the lock has been released. > > No, it is not meaningless. Right. Agreed that the returned value might not neces

Re: [PATCH] mm: swap prefetch improvements

2007-05-12 Thread Con Kolivas
On Saturday 12 May 2007 18:14, Paul Jackson wrote: > > Ummm this is what I've been saying for over a year now but noone has been > > listening. > > Well ... if there is a problem using prefetch and cpusets together, > it doesn't look like the two of us are going to find it. > > I should probably lo

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Fri, 2007-05-11 at 23:56 -0700, Andrew Morton wrote: > On Fri, 11 May 2007 23:09:15 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > > > > > > > hm, Fedora don't seem to want to give me an RPM which contains acpidump > > > > and > > > > all the yum servers are featuring scrogged

Re: [PATCH] mm: swap prefetch improvements

2007-05-12 Thread Paul Jackson
Con wrote: > Ok so change the default value for swap_prefetch to 0 when CPUSETS is > enabled? I don't see why that special case for cpusets is needed. I'm suggesting making no special cases for CPUSETS at all, until and unless we find reason to. In other words, I'm suggesting simply removing t

Re: [PATCH] spelling fixes: arch/um/

2007-05-12 Thread Jeff Dike
On Fri, May 11, 2007 at 08:43:47PM +0100, Simon Arlott wrote: > Spelling fixes in arch/um/. ACK -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 03:24, Linus Torvalds wrote: > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > However, in my opininon THAT PATCH has nothing to do with this problem. > > It just improves the code that we already have. > > Sure. > > However, I think it does it THE WRONG WAY, and d

[PATCH respin] mm: swap prefetch improvements

2007-05-12 Thread Con Kolivas
On Saturday 12 May 2007 18:37, Paul Jackson wrote: > Con wrote: > > Ok so change the default value for swap_prefetch to 0 when CPUSETS is > > enabled? > > I don't see why that special case for cpusets is needed. > > I'm suggesting making no special cases for CPUSETS at all, until and > unless we fi

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 02:00 -0700, Andrew Morton wrote: > > Still hangs in the same fashion, sorry. I did not really expect that it fixes the problem. It just restored the local APIC suspend/resume register fiddling which we had before the resume logic patch. > It's peculiar that the hang happens

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 10:46:03 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-11 at 23:56 -0700, Andrew Morton wrote: > > On Fri, 11 May 2007 23:09:15 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > > wrote: > > > > > > > > > > > > hm, Fedora don't seem to want to give me an R

Re: Request to mailing list Linux-arm-kernel rejected

2007-05-12 Thread Simon Arlott
On 12/05/07 08:52, [EMAIL PROTECTED] wrote: Your request to the Linux-arm-kernel mailing list Posting of your message titled "[PATCH] spelling fixes: arch/arm/" has been rejected by the list moderator. The moderator gave the following reason for rejecting your request: "Non-members are no

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 10:16, Gautham R Shenoy wrote: > On Sat, May 12, 2007 at 02:01:41AM +0200, Rafael J. Wysocki wrote: > > > > > So you migt as well not return any value at all, since the returned value > > > is apparently meaningless once the lock has been released. > > > > No, it is not

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Esben Nielsen
On Fri, 11 May 2007, Peter Zijlstra wrote: I was toying with a scalable rw_mutex and found that it gives ~10% reduction in system time on ebizzy runs (without the MADV_FREE patch). You break priority enheritance on user space futexes! :-( The problems is that the futex waiter have to take

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > return statement. Any theories there? > > Only stack or memory corruption come into mind, but I have no clue how > this is related to the

Re: [PATCH] UDF: check for allocated memory for inode data

2007-05-12 Thread Cyrill Gorcunov
Christoph, you know I've got a question (may be it's stupid) - what a sense to discard UDF_I_* macroses? I mean as I see they don't slow down execution of the code... Cyrill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMA

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Peter Zijlstra
On Sat, 2007-05-12 at 11:27 +0200, Esben Nielsen wrote: > > On Fri, 11 May 2007, Peter Zijlstra wrote: > > > > > I was toying with a scalable rw_mutex and found that it gives ~10% > > reduction in > > system time on ebizzy runs (without the MADV_FREE patch). > > > > You break priority enheritan

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Gautham R Shenoy
On Sat, May 12, 2007 at 11:27:36AM +0200, Rafael J. Wysocki wrote: > On Saturday, 12 May 2007 10:16, Gautham R Shenoy wrote: > > > > But I am not sure if this is the case with suspend/hibernate, since we > > need to do a sys_sync() between try_freeze_tasks(FREEZE_USER_SPACE) and > > try_to_freeze_

Re: [PATCH] UDF: check for allocated memory for inode data

2007-05-12 Thread Pekka Enberg
Hi Cyrill On 5/12/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: you know I've got a question (may be it's stupid) - what a sense to discard UDF_I_* macroses? I mean as I see they don't slow down execution of the code... They make the code harder to read and maintain. - To unsubscribe from thi

Re: getcpu after sched_setaffinity

2007-05-12 Thread Bert Wesarg
Hello, (Please CC me, thank you) Ulrich Drepper wrote: > The attached test program fails on a dual core (and probably SMP) > machine on x86-64. Depending on where the thread starts, in one of the > iterations the sched_setffinity() call succeeds but then sched_getcpu() > fails to report the c

undefined "pm3fb_setup()"

2007-05-12 Thread Robert P. J. Day
i'm guessing someone's already spotted this but, with "make allyesconfig" on x86: ... LD .tmp_vmlinux1 drivers/built-in.o: In function `pm3fb_init': drivers/video/pm3fb.c:977: undefined reference to `pm3fb_setup' ... the reason seems to be this excerpt from drivers/video/pm3fb.c: ===

Re: Please assist in locating NFS race in old vendor kernel

2007-05-12 Thread Jan Engelhardt
On May 9 2007 21:14, Nikita V. Youshchenko wrote: >Subject: Please assist in locating NFS race in old vendor kernel > >Hello. > >I'm currently working with an embedded system based on very old, >2.4.17-based, vendor kernel. Ask your vendor :-/ Jan -- - To unsubscribe from this list: s

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 12:13, Gautham R Shenoy wrote: > On Sat, May 12, 2007 at 11:27:36AM +0200, Rafael J. Wysocki wrote: > > On Saturday, 12 May 2007 10:16, Gautham R Shenoy wrote: > > > > > > But I am not sure if this is the case with suspend/hibernate, since we > > > need to do a sys_sync()

Re: [PATCH] Performance Stats: Kernel patch

2007-05-12 Thread Andrea Righi
Maxim Uvarov wrote: > diff --git a/Documentation/accounting/taskstats-struct.txt > b/Documentation/accounting/taskstats-struct.txt > index 661c797..606aef6 100644 > --- a/Documentation/accounting/taskstats-struct.txt > +++ b/Documentation/accounting/taskstats-struct.txt > @@ -22,6 +22,8 @@ There a

Re: [PATCH] Add LZO1X compression support to the kernel

2007-05-12 Thread devzero
oh - and think of linux software suspend. take a notebook with 2 GB of ram - that takes a while to write that to disk and read that back again. using lzo compression for this may probably halve the time for suspend/resume using a fast compression scheme > -Ursprüngliche Nachricht- > Von:

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Finn Thain
On Sat, 12 May 2007, Simon Arlott wrote: > On 12/05/07 02:03, Finn Thain wrote: > > > > On Fri, 11 May 2007, Simon Arlott wrote: > > > > > - * Local routines to interrcept the standard I/O and vector > > > handling > > > - * code. Don't include this 'till now - initialization code

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 11:01, Rafael J. Wysocki wrote: > On Saturday, 12 May 2007 03:24, Linus Torvalds wrote: > > > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > > > However, in my opininon THAT PATCH has nothing to do with this problem. > > > It just improves the code that we already ha

Re: "modularized" 2.4.34.4 -> ide-core "unresolved symbols"

2007-05-12 Thread Willy Tarreau
Hi Zbigniew, On Thu, May 10, 2007 at 12:05:44AM +0200, Zbigniew Baniewski wrote: > So, I changed the config (below) and made another compilation - still the > same: > > ...ordinary boot messages, ending with "hda:... sectors... w/Cache..." > hda: attached ide-disk driver >

Re: CONFIG_HIGHMEM4G and 1GB RAM

2007-05-12 Thread Alejandro Riveira Fernández
El Mon, 30 Apr 2007 23:18:28 +0100 Matt Keenan <[EMAIL PROTECTED]> escribió: > William Lee Irwin III wrote: > > The CONFIG_VMSPLIT config options were merged for such cases. > > > > It should be able to split on any 4MB-aligned boundary in > > CONFIG_HIGHMEM4G. CONFIG_VMSPLIT_3G_OPT appears to do

linux-2.6.21-gitN - versioning question

2007-05-12 Thread Jan Engelhardt
Hi list, I notice that people refer to certain git snapshots as e.g. -git16; kernel.org does so too. Hovering over the link on kernel.org reveals http://kernel.org/pub/linux/kernel/v2.6/snapshots/patch-2.6.21-git16.bz2 but where do I actually find -git16 in Linus's git tree? git16 is neither a

Re: [PATCH] Add LZO1X compression support to the kernel

2007-05-12 Thread Adrian Bunk
On Wed, May 02, 2007 at 09:56:23AM +0100, Richard Purdie wrote: >... > I've asked the LZO author about the comments on lzo_copyright function > but the code is GPLv2 licensed so is suitable for inclusion in the > kernel. This sounds as if LZO is GPL incompatible similar to code under the 4 clause

Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-12 Thread Jan Engelhardt
On May 11 2007 16:07, Arjan van de Ven wrote: > > A typical Linux distribution has many components that wake the processor up > frequently for no good reason. In our testing with PowerTOP, we have seen many > cases where with some simple fixes, the battery life of typical laptops was > increased b

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Gautham R Shenoy
On Sat, May 12, 2007 at 12:41:54PM +0200, Rafael J. Wysocki wrote: > > Still, the following scenario is possible while we're freezing users space > tasks: > > (1) user space task calls daemonize() > (2) freezer checks if this is a user space task and the test returns 'true' > (3) task calls exit_

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread Jan Engelhardt
On May 10 2007 14:54, Jeremy Fitzhardinge wrote: What CPU architecture is this happening on? Not i686 with PAE by any chance? >>> Yes. Why? >> >> I have a bug report where NFS files are corrupted only with PAE clients. >> Corruption is at the end of the (newly untarred) file

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 12:52, Gautham R Shenoy wrote: > On Sat, May 12, 2007 at 12:41:54PM +0200, Rafael J. Wysocki wrote: > > > > Still, the following scenario is possible while we're freezing users space > > tasks: > > > > (1) user space task calls daemonize() > > (2) freezer checks if this i

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 03:07 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > > return statement. Any theories there? > > > > Only stack or memory corrup

Re: [PATCH] Add LZO1X compression support to the kernel

2007-05-12 Thread Jindrich Makovicka
On Sat, 12 May 2007 12:41:03 +0200 [EMAIL PROTECTED] wrote: > oh - and think of linux software suspend. > take a notebook with 2 GB of ram - that takes a while to write that > to disk and read that back again. using lzo compression for this may > probably halve the time for suspend/resume There w

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 03:07 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > > return statement. Any theories there? > > > > Only stack or memory corrup

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread Adrian Bunk
On Sat, May 12, 2007 at 01:19:23PM +0200, Jan Engelhardt wrote: > Hi list, > > > I notice that people refer to certain git snapshots as e.g. -git16; > kernel.org does so too. Hovering over the link on kernel.org reveals > http://kernel.org/pub/linux/kernel/v2.6/snapshots/patch-2.6.21-git16.bz2

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread Jan Engelhardt
On May 10 2007 10:38, Matt Mackall wrote: >> >> for i in `seq 20`; do >> hg clone -U --pull a b-$i >> hg verify b-$i # always OK >> umount /home >> sleep 5 >> mount /home >> hg verify b-$i # often found truncated files >> done >> [...

Re: [PATCH] UDF: check for allocated memory for inode data

2007-05-12 Thread Cyrill Gorcunov
[Pekka Enberg - Sat, May 12, 2007 at 01:15:14PM +0300] | Hi Cyrill | | On 5/12/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: | >you know I've got a question (may be it's stupid) - what a | >sense to discard UDF_I_* macroses? I mean as I see they | >don't slow down execution of the code... | | Th

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sat, 12 May 2007 13:19:23 +0200 (MEST)), Jan Engelhardt <[EMAIL PROTECTED]> says: > I notice that people refer to certain git snapshots as e.g. -git16; > kernel.org does so too. Hovering over the link on kernel.org reveals > http://kernel.org/pub/linux/kernel/

Re: [BUG][debian-2.6.20-1-686] bridging + vlans + "vconfig rem" == stuck kernel

2007-05-12 Thread Kyle Moffett
On May 11, 2007, at 01:49:27, Kyle Moffett wrote: On May 10, 2007, at 00:34:11, Kyle Moffett wrote: On May 10, 2007, at 00:25:54, Ben Greear wrote: Looks like a deadlock in the vlan code. Any chance you can run this test with lockdep enabled? You could also add a printk in vlan_device_event

Re: [PATCH] module_author: don't advice putting in an email address

2007-05-12 Thread Alan Cox
> > I'd prefer not. I get reports from people about drivers that got "lost" > > by vendors, regularly. Nor am I pointing fingers at specific vendors here, > > last month I sorted out a two year old "lost in Red Hat Bugzilla" kernel > > bug for example. > > How many maintainers want to get bug repo

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread Matt Mackall
On Sat, May 12, 2007 at 01:21:41PM +0200, Jan Engelhardt wrote: > > On May 10 2007 10:38, Matt Mackall wrote: > >> > >> for i in `seq 20`; do > >>hg clone -U --pull a b-$i > >>hg verify b-$i # always OK > >>umount /home > >>sleep 5 > >>

Re: [PATCH] "volatile considered harmful", take 3

2007-05-12 Thread Heikki Orsila
On Sat, May 12, 2007 at 09:53:03AM +0200, Stefan Richter wrote: > H. Peter Anvin wrote: > [slightly off topic: GCCisms in Linux kernel] > > It contains *many* constructs that are not defined in, for > > example, C99, and it would in fact be impossible to write the Linux > > kernel using only C99-co

Re: x86 setup rewrite tree ready for flamage^W review

2007-05-12 Thread Alexander van Heukelum
On Thu, May 10, 2007 at 03:48:08PM -0700, H. Peter Anvin wrote: > > It doesn't probe the hardware in dangerous ways. (Search for mode_scan > > in video.S) It works by trying to set a mode via the normal > > AH=0/AL=mode/int 0x10 method for all possible values of mode. It then > > checks if the bios

Re: [PATCH] module_author: don't advice putting in an email address

2007-05-12 Thread Adrian Bunk
On Sat, May 12, 2007 at 01:15:30PM +0100, Alan Cox wrote: > > > I'd prefer not. I get reports from people about drivers that got "lost" > > > by vendors, regularly. Nor am I pointing fingers at specific vendors here, > > > last month I sorted out a two year old "lost in Red Hat Bugzilla" kernel > >

Re: [PATCH] Fix UCB1x00 driver to use sched_setscheduler

2007-05-12 Thread Thomas Gleixner
On Fri, 2007-05-11 at 19:39 +0900, Satoru Takeuchi wrote: > Fix Touchscreen driver for UCB1x00-based touchscreens to use > sched_setscheduler() instead of setting the fields of task_struct directly. > > Signed-off-by: Satoru Takeuchi <[EMAIL PROTECTED]> > > Index: linux-2.6.21-fix-ucb-drivers/dri

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread Cyrill Gorcunov
[YOSHIFUJI Hideaki / ?$B5HF#1QL@ - Sat, May 12, 2007 at 09:03:08PM +0900] | In article <[EMAIL PROTECTED]> (at Sat, 12 May 2007 13:19:23 +0200 (MEST)), Jan Engelhardt <[EMAIL PROTECTED]> says: | | > I notice that people refer to certain git snapshots as e.g. -git16; | > kernel.org does so too. H

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Esben Nielsen
On Sat, 12 May 2007, Peter Zijlstra wrote: On Sat, 2007-05-12 at 11:27 +0200, Esben Nielsen wrote: On Fri, 11 May 2007, Peter Zijlstra wrote: I was toying with a scalable rw_mutex and found that it gives ~10% reduction in system time on ebizzy runs (without the MADV_FREE patch). You br

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread David Woodhouse
On Sat, 2007-05-12 at 17:19 +0400, Cyrill Gorcunov wrote: > Actually I think it would be convenient if such tags (like > v.2.6.21-git16) were in Linus' git tree too. Then there would be _lots_ of tags in the master tree -- I'm not sure we want that. I suppose I could put a tree on kernel.org whic

Re: [PATCH 1/2] scalable rw_mutex

2007-05-12 Thread Peter Zijlstra
It has grown a few undocumented barriers again; but I'd like some feedback on them. /me still hopes some can go.. but these things still mess my head up. --- Scalable reader/writer lock. Its scalable in that the read count is a percpu counter and the reader fast path does not write to a shared c

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread David Chinner
On Sat, May 12, 2007 at 01:23:27PM +0200, Jan Engelhardt wrote: > > On May 10 2007 14:54, Jeremy Fitzhardinge wrote: > What CPU architecture is this happening on? Not i686 with PAE by > any chance? > > >>> Yes. Why? > >> > >> I have a bug report where NFS files are corrupted

Re: undefined "pm3fb_setup()"

2007-05-12 Thread Antonino A. Daplas
On Sat, 2007-05-12 at 06:32 -0400, Robert P. J. Day wrote: > i'm guessing someone's already spotted this but, with "make > allyesconfig" on x86: > > ... > LD .tmp_vmlinux1 > drivers/built-in.o: In function `pm3fb_init': > drivers/video/pm3fb.c:977: undefined reference to `pm3fb_setup' > .

Re: [PATCH] spelling fixes: arch/m68k/

2007-05-12 Thread Geert Uytterhoeven
On Fri, 11 May 2007, Simon Arlott wrote: > Spelling fixes in arch/m68k/. > > Signed-off-by: Simon Arlott <[EMAIL PROTECTED]> Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread Cyrill Gorcunov
[David Woodhouse - Sat, May 12, 2007 at 09:44:56PM +0800] | On Sat, 2007-05-12 at 17:19 +0400, Cyrill Gorcunov wrote: | > Actually I think it would be convenient if such tags (like | > v.2.6.21-git16) were in Linus' git tree too. | | Then there would be _lots_ of tags in the master tree -- I'm not

Dell Optiplex GX240, ACPI and APIC

2007-05-12 Thread Tear
Summary: If ACPI is not enabled but APIC is, then there is trouble on Dell Optiplex GX240. If both are enabled or if both are disabled, then everything is fine. The attached patch removes Dell Optiplex GX240 from the ACPI blacklist. --- Hello, I have a Dell Optiplex GX240 and when I boot Linux,

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Finn Thain
On Sat, 12 May 2007, Kolbj??rn Barmen wrote: > On Sat, 12 May 2007, Finn Thain wrote: > > > To answer your question, I find it easier to parse the original idiom, > > "'til now". Your corruption, "until now", loses information available to > > anyone who can recognise the idiom. Granted, this

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Oleg Nesterov
On 05/12, Rafael J. Wysocki wrote: > > ... user space tasks that call deamonize() can also be frozen prematurely. > We didn't take this possibility into consideration before, which was obviously > wrong. No, no, sorry for the confusion. User space tasks never call deamonize(). Kernel threads call

Re: x86 setup rewrite tree ready for flamage^W review

2007-05-12 Thread Eric W. Biederman
Alexander van Heukelum <[EMAIL PROTECTED]> writes: > On Thu, May 10, 2007 at 03:48:08PM -0700, H. Peter Anvin wrote: > I can confirm that it works for at least one computer over here (a six > months old x86_64 machine with ATI ES1000-based on-board graphics). Some > non-vesa modes including a nic

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Kolbjørn Barmen
On Sat, 12 May 2007, Finn Thain wrote: > To answer your question, I find it easier to parse the original idiom, > "'til now". Your corruption, "until now", loses information available to > anyone who can recognise the idiom. Granted, this is not the worst example > of that effect... It is eith

Re: APIC error on 32-bit kernel

2007-05-12 Thread Jay Cliburn
Thank you very much for looking at this, Len. On Fri, 11 May 2007 23:28:58 -0400 Len Brown <[EMAIL PROTECTED]> wrote: > > > [ 94.754852] APIC error on CPU0: 08(40) > > > [ 94.806045] APIC error on CPU0: 40(08) > > /* Here is what the APIC error bits mean: >0: Send CS err

[PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t

2007-05-12 Thread Olof Johansson
ppc64 really needs ioaddr_t to be 64-bit, since I/O addresses really are MMIO addresses, and remapped to a high range. While the type is exported to userspace, there hasn't been any platforms with PCMCIA on 64-bit powerpc until now, so changing it won't regress any existing users. Signed-off-by:

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Ingo Molnar
* Esben Nielsen <[EMAIL PROTECTED]> wrote: > I notice that the rwsems used now isn't priority inversion safe (thus > destroying the perpose of having PI futexes). We thus already have a > bug in the mainline. you see everything in black and white, ignoring all the grey scales! Upstream PI fut

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-12 Thread Oleg Nesterov
On 05/12, Rafael J. Wysocki wrote: > > Hmm, I'm not sure if the task can call try_to_freeze() after doing exit(). > May it happen? It can, note the do_exit()->ptrace_notify(). But this doesn't matter, I think. >From the freezer POV an exiting task has 2 "interesting" events exit_mm()

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Kolbjørn Barmen
On Sun, 13 May 2007, Finn Thain wrote: > On Sat, 12 May 2007, Kolbjørn Barmen wrote: > > > On Sat, 12 May 2007, Finn Thain wrote: > > > > > To answer your question, I find it easier to parse the original idiom, > > > "'til now". Your corruption, "until now", loses information available to > >

clockevent questions

2007-05-12 Thread Francis Moreau
Hi, I'm trying to use clocksource and clockevent new subsystem. My platform has a timer that I'd like to use both as a clocksource and a clockevent devices. This timer is continueous in sense that it can run without any interruption so I assume I can flag the clocksource device with "CLOCK_SOURCE

Re: 2.6.21-git10/11: files getting truncated on xfs? or maybe an nlink problem?

2007-05-12 Thread Jeremy Fitzhardinge
David Chinner wrote: > What I don't understand is that on unmount dirty xfs inodes get > written out. Clearly this is not happening - either there's a hole > in the writeback logic (unlikely - it was unchanged) or we've missed > some case where we need to update the filesize and mark the inode > di

migrate_dead_tasks() vs sleep-after-exit_notify() problems?

2007-05-12 Thread Oleg Nesterov
On 05/12, Oleg Nesterov wrote: > > exit_notify() ->exit_state != 0, and perhaps the task disappears > from global process list This, btw, means that do_exit()->__free_pipe_info() is not cpu-hotplug friendly. The task may sleep on mutex_lock(->i_mutex), and dequeue

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread Jan Engelhardt
On May 12 2007 21:44, David Woodhouse wrote: >On Sat, 2007-05-12 at 17:19 +0400, Cyrill Gorcunov wrote: >> Actually I think it would be convenient if such tags (like >> v.2.6.21-git16) were in Linus' git tree too. > >Then there would be _lots_ of tags in the master tree -- I'm not sure we >want th

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-12 Thread Russell King
On Sat, May 12, 2007 at 04:26:16PM +0200, Kolbjørn Barmen wrote: > On Sun, 13 May 2007, Finn Thain wrote: > > > On Sat, 12 May 2007, Kolbjørn Barmen wrote: > > > > > On Sat, 12 May 2007, Finn Thain wrote: > > > > > > > To answer your question, I find it easier to parse the original idiom, > > >

Re: kernel oops after unloading nf_conntrack_netbios_ns_module

2007-05-12 Thread Patrick McHardy
Gabor Burjan wrote: > EIP is at destroy_conntrack+0x52/0x127 [nf_conntrack] > >>>nmblookup >>>cat /proc/net/ip_conntrack >>> >>>sleep 3 >>> >>>rmmod nf_conntrack_netbios_ns Thanks for the report and good testcase, the crash can only happen with a sleep of >= 3s after the last nmblookup packet wa

Re: clockevent questions

2007-05-12 Thread Thomas Gleixner
Francis, On Sat, 2007-05-12 at 16:54 +0200, Francis Moreau wrote: > I'm trying to use clocksource and clockevent new subsystem. My > platform has a timer that I'd like to use both as a clocksource and a > clockevent devices. See arch/i386/kernel/hpet.c > This timer is continueous in sense that i

Re: [PATCH] Add LZO1X compression support to the kernel

2007-05-12 Thread Richard Purdie
On Sat, 2007-05-12 at 13:17 +0200, Adrian Bunk wrote: > On Wed, May 02, 2007 at 09:56:23AM +0100, Richard Purdie wrote: > >... > > I've asked the LZO author about the comments on lzo_copyright function > > but the code is GPLv2 licensed so is suitable for inclusion in the > > kernel. > > This soun

Re: [patch] x86_64: use signalfd and timerfd compat syscalls

2007-05-12 Thread Andi Kleen
On Saturday 12 May 2007 01:04:06 Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > Looks like these two are wired up in a wrong way. Thanks for spotting. I think it would have been ok for signalfd because sigset_t should be the same size, but it's clearly broken for timerfd -A

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Eric Dumazet
Esben Nielsen a écrit : On Sat, 12 May 2007, Peter Zijlstra wrote: On Sat, 2007-05-12 at 11:27 +0200, Esben Nielsen wrote: On Fri, 11 May 2007, Peter Zijlstra wrote: I was toying with a scalable rw_mutex and found that it gives ~10% reduction in system time on ebizzy runs (without the

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Esben Nielsen
On Sat, 12 May 2007, Ingo Molnar wrote: * Esben Nielsen <[EMAIL PROTECTED]> wrote: I notice that the rwsems used now isn't priority inversion safe (thus destroying the perpose of having PI futexes). We thus already have a bug in the mainline. you see everything in black and white, ignorin

Re: [GIT PULL] MMC updates

2007-05-12 Thread Nicolas Pitre
On Thu, 10 May 2007, Nicolas Pitre wrote: > On Thu, 10 May 2007, Pierre Ossman wrote: > > > You seem to be the source of this workaround, and also the maintainer of > > PXA. > > Well... I used to. Actually, I'm not the author of this workaround. And looking at it closer, the current workaroun

[PATCH 2/2] i386: sched_clock() follows percpu frequency changes

2007-05-12 Thread Daniel Walker
Considering that Andi has a similar patch, I'm going to assume there is already justification for this.. What it ends up doing is allows the TSC to be used in cases which we didn't use it before, and hope it's still mostly accurate. For instance, when the frequency changes due to cpufreq we updat

[PATCH 1/2] non-string based tsc unstable reasons

2007-05-12 Thread Daniel Walker
Just passing a string to mark_tsc_unstable() doesn't allow real code to change based on the reason for the instablility. I changed mark_tsc_unstable() to accept a string and a flag which denotes a general reason why the tsc is unstable, and can be evaluated in code. This is based off John Stultz p

Re: [PATCH 0/2] convert mmap_sem to a scalable rw_mutex

2007-05-12 Thread Ingo Molnar
* Esben Nielsen <[EMAIL PROTECTED]> wrote: > Yeah, after sending that mail I realized I accepted this fact way > back... But I disagree in that it is easy to avoid not write-lcling > the mm semaphore: A simple malloc() might lead to a mmap() call > creating trouble. Am I right? yeah - that's

[PATCH] pcmcia: export pcmcia_bus_type

2007-05-12 Thread Olof Johansson
Export pcmcia_bus_type so modules can register bus notifiers. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Index: powerpc/drivers/pcmcia/ds.c === --- powerpc.orig/drivers/pcmcia/ds.c +++ powerpc/drivers/pcmcia/ds.c @@ -1515,6 +

Re: linux-2.6.21-gitN - versioning question

2007-05-12 Thread Cyrill Gorcunov
[Jan Engelhardt - Sat, May 12, 2007 at 05:01:19PM +0200] | | On May 12 2007 21:44, David Woodhouse wrote: | >On Sat, 2007-05-12 at 17:19 +0400, Cyrill Gorcunov wrote: | >> Actually I think it would be convenient if such tags (like | >> v.2.6.21-git16) were in Linus' git tree too. | > | >Then there

Re: undefined "pm3fb_setup()"

2007-05-12 Thread Robert P. J. Day
On Sat, 12 May 2007, Antonino A. Daplas wrote: > On Sat, 2007-05-12 at 06:32 -0400, Robert P. J. Day wrote: > > i'm guessing someone's already spotted this but, with "make > > allyesconfig" on x86: > > > > ... > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `pm3fb_init': > > driv

Re: [PATCH 1/2] scalable rw_mutex

2007-05-12 Thread Oleg Nesterov
On 05/12, Peter Zijlstra wrote: > > +static inline void rw_mutex_readers_dec(struct rw_mutex *rw_mutex) > +{ > + percpu_counter_dec(&rw_mutex->readers); > + smp_wmb(); > +} > > +void rw_mutex_read_unlock(struct rw_mutex *rw_mutex) > +{ > + rw_mutex_readers_dec(rw_mutex); > + /* > +

  1   2   3   >