[GIT PULL] Additional x86 setup fixes

2007-08-02 Thread H. Peter Anvin
Hi Linus, One more batch of x86setup bug fixes. Of these, one is a manifest bug (EDID query failure), one is a non-manifest bug, and one is documentation (Grub < 0.93 buggy.) Please pull: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git for-linus Antonino A. Daplas (

[PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

2007-08-02 Thread Nico Erfurth
This patch adds the new iowarrior module to the Makefile in drivers/usb. Currently the module isn't build unless another driver from usb/misc is selected. Signed-off-by: Nico Erfurth <[EMAIL PROTECTED]> --- --- linux/drivers/usb/Makefile.orig 2007-08-02 21:54:16.0 +0200 +++ linux/drive

Re: error: implicit declaration of function 'rcu_dereference' - current -git fails to build

2007-08-02 Thread Jesper Juhl
On 02/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > On 02/08/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Thu, Aug 02, 2007 at 09:57:07PM +0200, Jesper Juhl wrote: > > > I get this build error with the current mainline git tree. > > > Let me know if further details are needed... > > >... > >

Re: ACPI on Averatec 2370

2007-08-02 Thread Frank Hale
Here is my /proc/cpuinfo, I have SMP disabled at the moment. Looks like my model is slightly older than Cal's. processor : 0 vendor_id : AuthenticAMD cpu family : 15 model : 72 model name : AMD Turion(tm) 64 X2 Mobile Technology TL-50 stepping: 2 cpu MHz

Re: Is PIE randomization breaking klibc binaries?

2007-08-02 Thread Jiri Kosina
On Thu, 2 Aug 2007, H. Peter Anvin wrote: > Yup... it should probably be pointed out the reason the old kernel > worked was nothing but pure dumb luck. This was a GNU ld change which > needed to be undone for klibc. It's unfortunate that stock x86-64 > binaries leave as little of a null point

Re: [PATCH] ehca: map 4k firmware context of cq, qp to user space

2007-08-02 Thread Roland Dreier
> remap_4k_pfn is defined in terms of remap_pfn_range if the base page > size if 4k, so you don't need this #ifdef afaics. Good point. I'll wait for an updated patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated)

2007-08-02 Thread Rafael J. Wysocki
On Thursday, 2 August 2007 20:40, Oleg Nesterov wrote: > On 08/02, Rafael J. Wysocki wrote: > > > > @@ -171,6 +186,10 @@ static int try_to_freeze_tasks(int freez > > > > end_time = jiffies + TIMEOUT; > > do { > > + DEFINE_WAIT(wait); > > + > > + add_wait_queue(&refrige

[PATCH 1/6] UML - Stop using libc asm/page.h

2007-08-02 Thread Jeff Dike
Remove includes of asm/page.h from libc code. This header seems to be disappearing, and UML doesn't make much use of it anyway. The one use, PAGE_SHIFT in stub.h, is handled by copying the constant from the kernel side of the house in common_offsets.h. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]

[PATCH 4/6] UML - Stop specially protecting kernel stacks

2007-08-02 Thread Jeff Dike
Map all of physical memory as executable to avoid having to change stack protections during fork and exit. unprotect_stack is now called only from MODE_TT code, so it is marked as such. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/kern_util.h |2 ++ arch/um/kernel/init_tas

[PATCH 0/6] UML - Cleanups and small fixes for 2.6.24

2007-08-02 Thread Jeff Dike
These are more cleanups and small fixes. They should wait for 2.6.24. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 3/6] UML - Fix nonremovability of watchdog

2007-08-02 Thread Jeff Dike
The UML watchdog driver was using the wrong config variable to control whether it can be unloaded once active. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/drivers/harddog_kern.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.21-mm/arch/um/drivers/harddog_ke

[PATCH 6/6] UML - physmem code tidying

2007-08-02 Thread Jeff Dike
Tidying of the UML physical memory system. These are mostly style fixes, however the includes were cleaned as well. This uncovered a need for mem_user.h to be included in mode_kern_skas.h. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/skas/mode_kern_skas.h |3 +- arch/um/k

Re: [PATCH 2.6.23 2/2] iw_cxgb3: Always call low level send function via cxgb3_ofld_send().

2007-08-02 Thread Roland Dreier
thanks, applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 5/6] UML - Stop saving process FP state

2007-08-02 Thread Jeff Dike
Throw out a lot of code dealing with saving and restoring floating-point state. In skas mode, where processes run in a different host process (and have a different register set), saving and restoring floating-point state on kernel entry and exit is pointless. This eliminates most of arch/um/os-Li

[PATCH 2/6] UML - Fix an IPV6 libc vs kernel symbol clash

2007-08-02 Thread Jeff Dike
On some systems, with IPV6 configured, there is a clash between the kernel's in6addr_any and the one in libc. This is handled in the usual (gross) way of defining the kernel symbol out of the way on the gcc command line. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/Makefile |3 ++-

Re: Scheduling the highest priority task

2007-08-02 Thread Martin Roehricht
On 02.08.2007 21:48, Ingo Molnar wrote: * Martin Roehricht <[EMAIL PROTECTED]> wrote: On 08/02/2007 05:19 PM, Ingo Molnar wrote: >* Martin Roehricht <[EMAIL PROTECTED]> wrote: > >>That's fine with me, that within the same priority-queue any task can >>be chosen. But assume two tasks with highl

Re: [PATCH 2.6.23 1/2] Make the iw_cxgb3 module parameters writable.

2007-08-02 Thread Roland Dreier
thanks... I actually applied this for 2.6.24, since it's not really a fix for anything, and the 2.6.23 window is closed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-i

Re: Distributed storage.

2007-08-02 Thread Daniel Phillips
On Tuesday 31 July 2007 10:13, Evgeniy Polyakov wrote: > Hi. > > I'm pleased to announce first release of the distributed storage > subsystem, which allows to form a storage on top of remote and local > nodes, which in turn can be exported to another storage as a node to > form tree-like storages.

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Thu, Aug 02, 2007 at 10:26:37PM +0200, Guennadi Liakhovetski wrote: > > Worse yet, K&R explicitely writes: > > > > char pattern[] = "ould"; > > is a shorthand for the longer but equivalent > > char pattern[] = { 'o', 'u', 'l', 'd', '\0' }; > > > > In the latter spelling gcc

Re: ACPI on Averatec 2370

2007-08-02 Thread Linus Torvalds
On Thu, 2 Aug 2007, Cal Peake wrote: > > Figured I should have sent that right after I hit the send key... > > processor : 0 > vendor_id : AuthenticAMD > cpu family: 15 > model : 72 > model name: AMD Turion(tm) 64 X2 Mobile Technology TL-52 Sadly, this doesn't show the

Re: ICH8 CF timeout (regression)...

2007-08-02 Thread Daniel J Blueman
On 02/08/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Daniel J Blueman wrote: > > I'll grab kernel logs from the legacy ATA boot; what else can help > > debug this issue? No problem testing patches too. > > Yeap, please post the old log. Not much actually - perhaps I need to enable some debugging:

Re: [PATCH] debugfs helper for decimal challenged

2007-08-02 Thread Greg KH
On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote: > From: Robin Getz <[EMAIL PROTECTED]> > > Allows debugfs helper functions to have a hex output, rather than just decimal > > Signed-off-by: Robin Getz <[EMAIL PROTECTED]> > --- > fs/debugfs/file.c | 36 +

[RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-02 Thread Oleg Nesterov
With or without this patch, multi-threaded init's are not fully supported, but do_exit() is completely wrong. This becomes a real problem when we support pid namespaces. 1. do_exit() panics when the main thread of /sbin/init exits. It should not until the whole thread group exits. Move the code

Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated)

2007-08-02 Thread Oleg Nesterov
On 08/02, Rafael J. Wysocki wrote: > > On Thursday, 2 August 2007 20:40, Oleg Nesterov wrote: > > On 08/02, Rafael J. Wysocki wrote: > > > > > > @@ -171,6 +186,10 @@ static int try_to_freeze_tasks(int freez > > > > > > end_time = jiffies + TIMEOUT; > > > do { > > > + DEFINE_WAIT(wait)

Re: [PATCH 2.6.22] Adding drivers/usb/misc/iowarrior.c to the Makefile

2007-08-02 Thread Sam Ravnborg
On Thu, Aug 02, 2007 at 10:25:20PM +0200, Nico Erfurth wrote: > This patch adds the new iowarrior module to the Makefile in drivers/usb. > Currently the module isn't build unless another driver from usb/misc is > selected. Can we please just always vist misc like this: obj-y := misc/ Then we do n

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Thu, 2 Aug 2007, Al Viro wrote: > On Thu, Aug 02, 2007 at 10:26:37PM +0200, Guennadi Liakhovetski wrote: > > > > Worse yet, K&R explicitely writes: > > > > > > > > char pattern[] = "ould"; > > > > is a shorthand for the longer but equivalent > > > > char pattern[] = { 'o', 'u', 'l

OOPS in shrink_dcache_for_umount

2007-08-02 Thread Chakri n
Hi, We are seeing this problem while unmounting file systems. It happens once in a while. I am able to grab the trace and core from linux-2.6.18-1.8.el5, but I have observed the same problem with linux-2.6.20.1 kernel. Has this problem fixed in recent kernel? BUG: Dentry f7498f70{i=12803e,n=clie

[PATCH, RESEND] pi-futex: set PF_EXITING without taking ->pi_lock

2007-08-02 Thread Oleg Nesterov
It is a bit annoying that do_exit() takes ->pi_lock to set PF_EXITING. All we need is to synchronize with lookup_pi_state() which saw this task without PF_EXITING under ->pi_lock. Change do_exit() to use spin_unlock_wait(). Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> Acked-by: Ingo Molnar <[

Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated)

2007-08-02 Thread Rafael J. Wysocki
On Thursday, 2 August 2007 23:23, Oleg Nesterov wrote: > On 08/02, Rafael J. Wysocki wrote: > > > > On Thursday, 2 August 2007 20:40, Oleg Nesterov wrote: > > > On 08/02, Rafael J. Wysocki wrote: > > > > > > > > @@ -171,6 +186,10 @@ static int try_to_freeze_tasks(int freez > > > > > > > >

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Robert Hancock
Guennadi Liakhovetski wrote: On Thu, 2 Aug 2007, Andi Kleen wrote: Guennadi Liakhovetski <[EMAIL PROTECTED]> writes: char c[4] = "0123"; and - a wonder - no warning. It's required by the C standard. 6.7.8.14 of C99: `` An array of character type may be initialized by a character st

Re: ACPI on Averatec 2370

2007-08-02 Thread Cal Peake
On Thu, 2 Aug 2007, Linus Torvalds wrote: > On Thu, 2 Aug 2007, Cal Peake wrote: > > > > Figured I should have sent that right after I hit the send key... > > > > processor : 0 > > vendor_id : AuthenticAMD > > cpu family : 15 > > model : 72 > > model name : AMD Turion(tm) 64

Re: 2.6.22 regression: thermal trip points

2007-08-02 Thread Len Brown
On Thursday 02 August 2007 04:40, Knut Petersen wrote: > Kernel 2.6.22 decreases performance by about 50% on my system. > No, I do not like that. The reason is a broken BIOS, granted, but there > was a perfect workaround in the kernel that has been dropped. > > mainboard: AOpen i915GMm-hfs, AWARD

Re: 2.6.22 regression: thermal trip points

2007-08-02 Thread Len Brown
On Thursday 02 August 2007 05:45, Adrian Schröter wrote: > On Thursday 02 August 2007 11:42:27 wrote Thomas Renninger: > > On Thu, 2007-08-02 at 10:40 +0200, Knut Petersen wrote: > > > Hi everybody! > > > > > > Kernel 2.6.22 decreases performance by about 50% on my system. > > > No, I do not like t

Re: VIA EPIA EK: strange eth dev numbering

2007-08-02 Thread Kay Sievers
On 8/2/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > I know I have seen my kernel outputting "A renamed to B". Since you two > however wanted that information in the first place, I grepped a bit > around, and actually found, (drumroll), that the SUSE kernel has had a > proper patch for [I can't r

[PATCH] kernel-parameters.txt : watchdog.txt should be wdt.txt

2007-08-02 Thread Gabriel C
Documentation/watchdog/watchdog.txt does not exist, it is Documentation/watchdog/wdt.txt Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/kernel-parameters.txt

Re: [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated)

2007-08-02 Thread Oleg Nesterov
On 08/02, Rafael J. Wysocki wrote: > > On Thursday, 2 August 2007 23:23, Oleg Nesterov wrote: > > On 08/02, Rafael J. Wysocki wrote: > > > > > > On Thursday, 2 August 2007 20:40, Oleg Nesterov wrote: > > > > On 08/02, Rafael J. Wysocki wrote: > > > > > > > > > > @@ -171,6 +186,10 @@ static int try_

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 02 Aug 2007 12:10:29 -0700 > On Thu, 2007-08-02 at 02:23 -0700, David Miller wrote: > > From: "Joachim Deguara" <[EMAIL PROTECTED]> > > Date: Thu, 2 Aug 2007 11:15:05 +0200 > > > > > Seams like even if powersave shuts down the network that the d

RE: scripts/mod/file2alias.c cross compile problem

2007-08-02 Thread Rusty Russell
On Thu, 2007-08-02 at 09:25 -0700, Luck, Tony wrote: > > Adrian Bunk: scripts/mod/file2alias.c is compiled with HOSTCC and ensures > > that > > kernel_ulong_t is correct, but it can't cope with different padding on > > different architectures. > > Surely this is the root cause ... you can't expec

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Guennadi Liakhovetski wrote: > On Thu, 2 Aug 2007, Andi Kleen wrote: >> 6.7.8.14 of C99: >> `` >> An array of character type may be initialized by a character string literal, >> optionally >> enclosed in braces. Successive characters of the character string literal >> (including the >> terminatin

Re: [PATCH] debugfs helper for decimal challenged

2007-08-02 Thread Robin Getz
On Thu 2 Aug 2007 17:09, Greg KH pondered: > On Wed, Aug 01, 2007 at 11:13:51PM -0400, Robin Getz wrote: > > From: Robin Getz <[EMAIL PROTECTED]> > > > > Allows debugfs helper functions to have a hex output, rather than just > decimal > > > > Signed-off-by: Robin Getz <[EMAIL PROTECTED]> > > --

[PATCH] debugfs helper for decimal challenged

2007-08-02 Thread Robin Getz
From: Robin Getz <[EMAIL PROTECTED]> Allows debugfs helper functions to have a hex output, rather than just decimal Signed-off-by: Robin Getz <[EMAIL PROTECTED]> --- fs/debugfs/file.c | 36 include/linux/debugfs.h | 27 ++

Re: mmap behavior on out-of-space conditions

2007-08-02 Thread David Chinner
On Thu, Aug 02, 2007 at 03:06:15PM +0200, Peter Zijlstra wrote: > On Thu, 2007-08-02 at 14:41 +0200, Petr Tesarik wrote: > > Hello, > > > > while solving a different issue, my colleague Libor Pechacek found a > > problem with handling mmapped sparse files. If you mmap the hole insidea > > sparse f

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Guennadi Liakhovetski wrote: > with > > char c[4] = "012345"; > > the compiler warns, but actually allocates a 6-byte long array... Off-topic here, but: sizeof c / sizeof *c == 4. -- Stefan Richter -=-=-=== =--- ---== http://arcgraph.de/sr/ - To unsubscribe from this list: send the l

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Thu, 2 Aug 2007, Robert Hancock wrote: > Because 5 characters will not fit in a 4 character array, even without the > null terminator. On Fri, 3 Aug 2007, Stefan Richter wrote: > How should gcc know whether you actually wanted that char foo[len] to > contain a \0 as last element? Robert, Ste

[PATCH] do_sigaction: remove now unneeded recalc_sigpending()

2007-08-02 Thread Oleg Nesterov
With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the thread without any reason. Harmless, but unneeded and wastes CPU. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> --- t/kernel/signal.c~ 2007-08-03

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250

[PATCH 1/2] hysdn: convert to PCI hotplug API

2007-08-02 Thread Jeff Garzik
This patch has been committed to the 'hysdn' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit b025c86cba3bb9fd7218ce6e8a60f0c65b414d0c Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu Aug 2 18:51:14 2007 -0400 [ISDN] hysdn: convert to PCI hotplug API

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Fri, Aug 03, 2007 at 12:51:16AM +0200, Guennadi Liakhovetski wrote: > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > Guennadi Liakhovetski wrote: > > > with > > > > > > char c[4] = "012345"; > > > > > > the compiler warns, but actually allocates a 6-byte long array... > > > > Off-topic he

REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Daniel Ritz
commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250_early.c:serial8250_f

Re: scripts/mod/file2alias.c cross compile problem

2007-08-02 Thread Adrian Bunk
On Fri, Aug 03, 2007 at 08:08:20AM +1000, Rusty Russell wrote: >... > scripts/mod/file2alias is the program that reads this: although it can > be altered to parse 32-vs-64, Adrian's fix is the simplest. s/Adrian/Thomas/ > Hope that clarifies, > Rusty. cu Adrian -- "Is there not promise

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Fri, Aug 03, 2007 at 12:36:40AM +0200, Guennadi Liakhovetski wrote: > On Thu, 2 Aug 2007, Robert Hancock wrote: > > > Because 5 characters will not fit in a 4 character array, even without the > > null terminator. > > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > How should gcc know whether

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: [snip] > > y'know, we could have a debug option which will spit warnings if someone > > does a !__GFP_WAIT allocation while !in_atomic() (only works if > > CONFIG_PREEMPT). > > > > But ple

Re: [RFC, PATCH] handle the multi-threaded init's exit() properly

2007-08-02 Thread Roland McGrath
This looks fine to me, though I don't know anything about the nsproxy bit. Now that choose_new_parent is one trivial line, you might go on to get rid of it and roll its one line into reparent_thread. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Randy Dunlap
On Fri, 3 Aug 2007 00:36:40 +0200 (CEST) Guennadi Liakhovetski wrote: > On Thu, 2 Aug 2007, Robert Hancock wrote: > > > Because 5 characters will not fit in a 4 character array, even without the > > null terminator. > > On Fri, 3 Aug 2007, Stefan Richter wrote: > > > How should gcc know whether

Re: [REGRESSION] tg3 dead after s2ram

2007-08-02 Thread Michael Chan
On Thu, 2007-08-02 at 15:06 -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Thu, 02 Aug 2007 12:10:29 -0700 > > > Alternatively, we can also fix it by calling pci_enable_device() again > > in tg3_open(). But I think it is better to just always save and restore > > in

(off-topic) Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Guennadi Liakhovetski wrote: > Robert, Stefan, I am sorry, I think, you are VERY wrong here. You meant to say "C99 is very wrong". > And, Stefan, there is a perfect way to specify a "0123" without the '\0' - > {'0', '1', '2', '3'}. C99 says char c[4] = "0123"; is a perfect way to say char c[4]

Re: VIA EPIA EK: strange eth dev numbering

2007-08-02 Thread Jan Engelhardt
On Aug 3 2007 00:00, Kay Sievers wrote: >On 8/2/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: >> I know I have seen my kernel outputting "A renamed to B". Since you two >> however wanted that information in the first place, I grepped a bit >> around, and actually found, (drumroll), that the SUSE k

Re: CFS review

2007-08-02 Thread Roman Zippel
Hi, On Thu, 2 Aug 2007, Ingo Molnar wrote: > Most importantly, CFS _already_ includes a number of measures that act > against too frequent math. So even though you can see 64-bit math code > in it, it's only rarely called if your clock has a low resolution - and > that happens all automaticall

Re: [PATCH] do_sigaction: remove now unneeded recalc_sigpending()

2007-08-02 Thread Roland McGrath
> With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can > never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the > thread without any reason. Harmless, but unneeded and wastes CPU. > > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> ACK. (We agreed months

Re: ICH8 CF timeout (regression)...

2007-08-02 Thread Mark Lord
Daniel J Blueman wrote: On 02/08/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Daniel J Blueman wrote: I'll grab kernel logs from the legacy ATA boot; what else can help debug this issue? No problem testing patches too. Yeap, please post the old log. Not much actually - perhaps I need to enable s

Re: VIA EPIA EK: strange eth dev numbering

2007-08-02 Thread Kay Sievers
On Fri, 2007-08-03 at 00:39 +0200, Jan Engelhardt wrote: > On Aug 3 2007 00:00, Kay Sievers wrote: > >On 8/2/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > >> I know I have seen my kernel outputting "A renamed to B". Since you two > >> however wanted that information in the first place, I grepped

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Fri, 3 Aug 2007, Stefan Richter wrote: > Guennadi Liakhovetski wrote: > > with > > > > char c[4] = "012345"; > > > > the compiler warns, but actually allocates a 6-byte long array... > > Off-topic here, but: sizeof c / sizeof *c == 4. Don't think it is OT here - kernel depends on gcc.

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-08-02 Thread Linas Vepstas
On Thu, Jul 05, 2007 at 12:54:06PM -0600, Matthew Wilcox wrote: > On Thu, Jul 05, 2007 at 11:28:38AM -0700, Andrew Morton wrote: > > Well you've sent it a couple of times, and I've sent it in five more times > > over the past year. Once we were told "awaiting maintainer ack". > > > > This situati

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Al Viro
On Thu, Aug 02, 2007 at 03:54:34PM -0700, Randy Dunlap wrote: > > > > And, Stefan, there is a perfect way to specify a "0123" without the '\0' - > > {'0', '1', '2', '3'}. > > We are actually a bit beyond traditional K&R, fwiw. Not in that area - this behaviour is precisely what traditional K&R

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 00:53:44 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > [snip] > > > y'know, we could have a debug option which will spit warnings if someone > > > does a !__GFP_WA

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On 03/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 3 Aug 2007 00:53:44 +0200 > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > On Thursday 02 August 2007 10:20:47 Jesper Juhl wrote: > > > On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > [snip] > > > > y'know, we could have a debu

[PATCH 2/2] hysdn: fix SMP brokenness

2007-08-02 Thread Jeff Garzik
This patch has been committed to the 'hysdn' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git commit 4ef2632c0fdf4598cf6a417f39514257ecbb2ba2 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu Aug 2 19:08:10 2007 -0400 [ISDN] hysdn: fix SMP brokenness Si

Re: 2.6.23-rc1-git3 init failure

2007-08-02 Thread Sid Boyce
Michal Piotrowski wrote: Hi Sid, On 29/07/07, Sid Boyce <[EMAIL PROTECTED]> wrote: > Boot failure on x86_64 (64X2), says it can't find init, specifically > /init. 2.6.23-rc1-git1 boots and runs successfully. I haven't tried > -git2. I shall reboot on 2.6.23-rc1-git3 tomorrow and record th

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 01:06:32 +0200 Daniel Ritz <[EMAIL PROTECTED]> wrote: > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > with an oops, completely killing PCMCIA. > > register_console() now calls console->early_setup(). which in case of > 8250.c (the only user anyway) is

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 01:10:02 +0200 "Jesper Juhl" <[EMAIL PROTECTED]> wrote: > > > So, where do we go from here? > > > > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add > > that flag to known-to-be-OK callsites, such as mempool_alloc(). > > > Ok, I'll try to play around with

Re: CFS review

2007-08-02 Thread Roman Zippel
Hi, On Wed, 1 Aug 2007, Linus Torvalds wrote: > So I think it would be entirely appropriate to > > - do something that *approximates* microseconds. > >Using microseconds instead of nanoseconds would likely allow us to do >32-bit arithmetic in more areas, without any real overflow. Th

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Thu, 2 Aug 2007, Randy Dunlap wrote: > C99 spec that Al referred you to (available for around US$18 as a pdf) > says in 6.7.8, para. 14 (where Al said): > > "An array of character type may be initialized by a character string literal, > optionally > enclosed in braces. Successive characters o

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Jesper Juhl
On 03/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 3 Aug 2007 01:10:02 +0200 > "Jesper Juhl" <[EMAIL PROTECTED]> wrote: > > > > > So, where do we go from here? > > > > > > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add > > > that flag to known-to-be-OK callsite

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > Daniel Ritz wrote: > > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > > with an oops, completely killing PCMCIA. > > > > register_console() now calls console->early_setup(). which in case of > > 8

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Rene Herman
On 08/03/2007 01:26 AM, Guennadi Liakhovetski wrote: On Thu, 2 Aug 2007, Randy Dunlap wrote: C99 spec that Al referred you to (available for around US$18 as a pdf) says in 6.7.8, para. 14 (where Al said): "An array of character type may be initialized by a character string literal, optionall

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Jakub Jelinek
On Thu, Aug 02, 2007 at 09:55:51PM +0200, Guennadi Liakhovetski wrote: > I've run across the following gcc "feature": > > char c[4] = "01234"; > > gcc emits a nice warning > > warning: initializer-string for array of chars is too long > > But do a > > char c[4] = "0123"; > > and -

[PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Matthew Garrett
We're seeing a large number of problems with devices not appreciating USB autosuspend, especially printers and scanners. According to http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a subset of drivers support it in Windows XP, meaning that most devices are probably untested

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Guennadi Liakhovetski
On Fri, 3 Aug 2007, Al Viro wrote: > It doesn't change the fact that use of c[4] or strlen(c) or strcpy(..., c) > means nasal demon country for you. Haha, funny. You, certainly, may think whatever you want, I'm anyway greatful to you and to all the rest for the trouble you took to find THE quot

Re: gcc fixed size char array initialization bug - known?

2007-08-02 Thread Stefan Richter
Al Viro wrote: > On Fri, Aug 03, 2007 at 12:51:16AM +0200, Guennadi Liakhovetski wrote: >> On Fri, 3 Aug 2007, Stefan Richter wrote: >> >>> Guennadi Liakhovetski wrote: with char c[4] = "012345"; the compiler warns, but actually allocates a 6-byte long array... >>> Off-t

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 05:52:28PM -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Nick Piggin wrote: > > > > Add a (slow) kmalloc_policy? Strict Object round robin for interleave > > > right? It probably needs its own RR counter otherwise it disturbs the per > > > task page RR. > > > > I

Re: [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Greg KH
On Fri, Aug 03, 2007 at 12:56:13AM +0100, Matthew Garrett wrote: > We're seeing a large number of problems with devices not appreciating > USB autosuspend, especially printers and scanners. According to > http://www.microsoft.com/whdc/system/bus/USB/USBFAQ_intro.mspx only a > subset of drivers s

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > > Ok. So MPOL_BIND on a single node. We would have to save the current > > memory policy on the stack and then restore it later. Then you would need > > a special call anyways. > > Well the memory policy will already be set to MPOL_BIND at this point. >

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > > Add a (slow) kmalloc_policy? Strict Object round robin for interleave > > right? It probably needs its own RR counter otherwise it disturbs the per > > task page RR. > > I guess interleave could be nice for other things, but for this, I > just want MPO

Re: [PATCH] 2.6.23-rc1-mm1 - fix missing numa_zonelist_order sysctl

2007-08-02 Thread KAMEZAWA Hiroyuki
On Thu, 02 Aug 2007 11:07:38 -0400 Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > Of course, I don't have any idea of what is a "reasonable amount". > Guess I could look at non-movable zone memory usage in a system at > typical or peak load to get an idea. Anyone have any data in this > regard? >

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 11:33:39AM -0700, Martin Bligh wrote: > Nick Piggin wrote: > >On Wed, Aug 01, 2007 at 03:52:11PM -0700, Martin Bligh wrote: > >>>And so forth. Initial forks will balance. If the children refuse to > >>>die, forks will continue to balance. If the parent starts seeing short

Re: lmbench ctxsw regression with CFS

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 05:44:47PM +0200, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > > > One thing to check out is whether the lmbench numbers are > > > > > "correct". Especially on SMP systems, the lmbench numbers are > > > > > actually *best* when the two processe

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Andrew Morton wrote: On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case o

Re: [ck] Re: ck vs. cfs : realtime audio performance

2007-08-02 Thread Carlo Florendo
Martin Steigerwald wrote: Am Donnerstag 02 August 2007 schrieb Martin Steigerwald: The tone I see on responses to posts that are CCed to LKML in my perception often is just completely and utterly awfully unfriendly. And often those responses actual include factual inaccuracies and preliminary a

Re: [2.6 patch] mm/migrate.c: cleanups

2007-08-02 Thread KAMEZAWA Hiroyuki
On Thu, 2 Aug 2007 11:43:21 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Thu, 2 Aug 2007, Yasunori Goto wrote: > > > But, this patch is the cause of compile error of memory unplug code of > > 2.6.23-rc1-mm2. It uses putback_lru_pages(). > > Don't make it static please... :-( >

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 12:58:13PM -0700, Christoph Lameter wrote: > On Thu, 2 Aug 2007, Nick Piggin wrote: > > > > It does in the sense that slabs are allocated following policies. If you > > > want to place individual objects then you need to use kmalloc_node(). > > > > Is there no way to plac

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-02 Thread Christoph Lameter
Mempools do not want to wait if there is an allocation failure. Its like GFP_THISNODE in that we want a failure. I had to add a if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) == GFP_THISNODE) goto nopage; in page_alloc.c to make GFP_THISNODE fail. Maybe add a GFP_FAIL and check fo

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Nick Piggin
On Thu, Aug 02, 2007 at 06:02:56PM -0700, Christoph Lameter wrote: > On Fri, 3 Aug 2007, Nick Piggin wrote: > > > > Ok. So MPOL_BIND on a single node. We would have to save the current > > > memory policy on the stack and then restore it later. Then you would need > > > a special call anyways. >

Problem with USB Gadget Filesystem

2007-08-02 Thread Park Sangsu
Hi, everyone. Now I'm developing USB Mass Storage App with GadgetFS(drivers/usb/gadget/inode.c). (linux kernel version is 2.6.17. We ported it to arm(s5c7329). The target board is now FPGA board. USB chip is 3884-0 DWC USB 2.0 HS OTG of Synopsys.) But, when plug in USB to Desktop PC(Win xp pro), ke

Re: eurotechwdt will cause reboot

2007-08-02 Thread Dave Young
>On 8/1/07, Dave Young <[EMAIL PROTECTED]> wrote: > >On 8/1/07, Wim Van Sebroeck <[EMAIL PROTECTED]> wrote: > > Hi Dave, > > > > > config eurotechwdt to yes will cause system silent reboot. Is it right > > > behaviour or a bug? > > > > I think this might be a bug. I'll look at the code and will ask

Re: [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Matthew Garrett
On Thu, Aug 02, 2007 at 06:15:05PM -0700, Greg KH wrote: > Well, if you do this, then you can pretty much delete the whole quirk > table we have, right? At the moment, yes. > And personally, I want to do better than Windows XP when it comes to > power management. This patch is only going to sus

Re: [rfc] balance-on-fork NUMA placement

2007-08-02 Thread Christoph Lameter
On Fri, 3 Aug 2007, Nick Piggin wrote: > Yeah it only gets set if the parent is initially using a default policy > at this stage (and then is restored afterwards of course). Uggh. Looks like more hackery ahead. I think this cannot be done in the desired clean way until we have some revving of th

patch usb-u132-hcd.c-fix-a-warning-when-config_pm-n.patch added to gregkh-2.6 tree

2007-08-02 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: USB: u132-hcd.c - Fix a warning when CONFIG_PM=n to my gregkh-2.6 tree. Its filename is usb-u132-hcd.c-fix-a-warning-when-config_pm-n.patch This tree can be found at http://www.kernel.org/pub/linux/ke

[NFSD OOPS] 2.6.23-rc1-git10

2007-08-02 Thread Andrew Clayton
Hi, Got the following oopsen just now from 2.6.23-rc1-git10 on a 2 processor Opteron with 2GB RAM. System is running 64bit Fedora Core 6. nfsd is exporting directories from a XFS filesystem on top a software RAID 5 array comprising 3 x 250GB SATA disks using the sata_sil driver. Amongst other th

Re: [linux-usb-devel] [PATCH] USB: Only enable autosuspend by default on certain device classes

2007-08-02 Thread Alan Stern
On Fri, 3 Aug 2007, Matthew Garrett wrote: > On Thu, Aug 02, 2007 at 06:15:05PM -0700, Greg KH wrote: > > > Well, if you do this, then you can pretty much delete the whole quirk > > table we have, right? > > At the moment, yes. > > > And personally, I want to do better than Windows XP when it c

[PATCH] mtd: Makefile fix (was Re: [PATCH] mtdsuper: licensce = GPL)

2007-08-02 Thread Satyam Sharma
Hi, On Thu, 2 Aug 2007, Rafał Bilski wrote: > [...] > CC drivers/mtd/chips/chipreg.mod.o > LD [M] drivers/mtd/chips/chipreg.ko > CC drivers/mtd/devices/block2mtd.mod.o > LD [M] drivers/mtd/devices/block2mtd.ko > CC drivers/mtd/mtd_blkdevs.mod.o > LD [M] drivers/mtd/mtd_bl

  1   2   3   4   5   >