Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 13:59, Sam Ravnborg pondered: > That seems to explain why I could not follow your code changes. > A more fine grained splitup would have helped here. Sorry - see below. These aren't proper patches anymore, since it was faster for me to split them by hand (but should be OK for re

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Mike Frysinger wrote: > On 8/17/07, David Brownell <[EMAIL PROTECTED]> wrote: > > ... > > Just for the record, this is an unusual way to use these calls. > > > > Other platforms completely decouple these issues from the > > IRQ infrastructure ... doing the pinmux and gpio

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Paul E. McKenney
On Fri, Aug 17, 2007 at 12:49:00PM -0700, Arjan van de Ven wrote: > > On Fri, 2007-08-17 at 12:49 -0700, Paul E. McKenney wrote: > > > > What about reading values modified in interrupt handlers, as in your > > > > "random" case? Or is this a bug where the user of atomic_read() is > > > > invali

[PATCH 1/6] Use zonelists instead of zones when direct reclaiming pages

2007-08-17 Thread Mel Gorman
The allocator deals with zonelists which indicate the order in which zones should be targeted for an allocation. Similarly, direct reclaim of pages iterates over an array of zones. For consistency, this patch converts direct reclaim to use a zonelist. No functionality is changed by this patch. Thi

[PATCH 0/6] Use one zonelist per node instead of multiple zonelists v4

2007-08-17 Thread Mel Gorman
Biggest changes are altering the embedding of zone IDs so that the type is unsigned long instead of struct zone * and the removal of MPOL_BIND-specific zonelists and filering based on node data instead. The biggest concern is the last patch where FASTCALL doesn't appear to do the right thing in all

[PATCH 2/6] Use one zonelist that is filtered instead of multiple zonelists

2007-08-17 Thread Mel Gorman
Currently a node has a number of zonelists, one for each zone type in the system. Based on the zones allowed by a gfp mask, one of these zonelists is selected. All of these zonelists occupy memory and consume cache lines. This patch replaces the multiple zonelists in the node with a single zoneli

[PATCH 3/6] Embed zone_id information within the zonelist->zones pointer

2007-08-17 Thread Mel Gorman
Using one zonelist per node requires very frequent use of zone_idx(). This is costly as it involves a lookup of another structure and a substraction operation. struct zone is aligned on a node-interleave boundary so the pointer values of plenty of 0's at the least significant bits of the address.

[PATCH 4/6] Record how many zones can be safely skipped in the zonelist

2007-08-17 Thread Mel Gorman
This patch is mainly the work of Kamezawa-san. As there is only one zonelist, it must be filtered for zones that are unusable by the GFP flags. As the zonelists very rarely change during the lifetime of the system, it is known in advance how many zones can be skipped from the beginning of the zon

[PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

2007-08-17 Thread Mel Gorman
The MPOL_BIND policy creates a zonelist that is used for allocations belonging to that thread that can use the policy_zone. As the zonelist is already being filtered based on a zone id, this patch adds a version of __alloc_pages() that takes a nodemask for further filtering. This eliminates the ne

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread Mike Frysinger
On 8/17/07, David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 17 August 2007, Mike Frysinger wrote: > > On 8/17/07, David Brownell <[EMAIL PROTECTED]> wrote: > > > ... > > > Just for the record, this is an unusual way to use these calls. > > > > > > Other platforms completely decouple these iss

Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Jan Engelhardt wrote: > >> We exchanges several mails a few weeks ago after the Debian bug caused > >> by a modprobe loop. > > > >Which has been fixed for some time now; it was caused by legacy > >drivers, which are incapable of hotplugging. > > Speaking of which ... doe

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread Mike Frysinger
On 8/17/07, Mike Frysinger <[EMAIL PROTECTED]> wrote: > as Michael pointed out, in the Blackfin world we tend to keep things > very dynamic as we have dev systems which allow for dropping in of > optional cards at will, so doing this in the bootloader is way too > inflexible. oh, and another [smal

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-17 Thread Valdis . Kletnieks
On Fri, 17 Aug 2007 12:45:47 PDT, Andrew Morton said: > On Fri, 17 Aug 2007 06:59:18 -0400 > Neil Horman <[EMAIL PROTECTED]> wrote: > > > Currently, there exists no method for a process to query the resource > > limits of another process. They can be inferred via some mechanisms but > > they > >

[PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask()

2007-08-17 Thread Mel Gorman
One PPC64 machine using gcc 3.4.6 the machine fails to boot when __alloc_pages_nodemask() uses the FASTCALL calling convention. It is not clear why this machine in particular is affected as other PPC64 machines boot. The only usual aspect of the machine is that it has memoryless nodes but I couldn

RE: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread Hennerich, Michael
>-Original Message- >From: David Brownell [mailto:[EMAIL PROTECTED] > >On Friday 17 August 2007, Mike Frysinger wrote: >> On 8/17/07, David Brownell <[EMAIL PROTECTED]> wrote: >> > ... >> > Just for the record, this is an unusual way to use these calls. >> > >> > Other platforms completel

Re: [PATCH 00/23] per device dirty throttling -v9

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Peter Zijlstra wrote: > Currently we do: > dirty = total_dirty * bdi_completions_p * task_dirty_p > > As dgc pointed out before, there is the issue of bdi/task correlation, > that is, we do not track task dirty rates per bdi, so now a task that > heavily dirties on one bdi

Re: [PATCH 7/7] Simple Performance Counters: SLUB instrumentation

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mathieu Desnoyers wrote: > Why do you printk inside the timing period ? Filling the printk buffers > or outputting on things such as serial console could really hurt your > results. It was easier to code? > I hope you run your system with idle=poll and without frequency scal

Re: [PATCH 1/7] Simple Performance Counters: Core Piece

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mathieu Desnoyers wrote: > Actually, get_cycles() at least on some AMD cpus, do not synchronize the > core, which can skew the results. You might want to use > get_cycles_sync() there. get_cycle() results as used here are bound to a single processor. If we end up on a differ

Re: kfree(0) - ok?

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Andrew Morton wrote: > are we seeing a pattern here? We could stick the unlikely inside > ZERO_OR_NULL_PTR() itself. That's a little bit sleazy though - there might > be future callsites at which it is likely, who knows? Thought about that myself but then there would be a w

how to add debug information into the vmlinux

2007-08-17 Thread Xu Yang
Hello everyone, I am trying to port kernel 2.6.19 onto my system.so I need the c code , which can show me where the program is running. I add -g when I compile it. after I got the vmlinux( uncompressed) I used arm-none-eabi-objcopy --change-addresses 0x4000 to change the start address. it se

[PATCH] Fix section mismatch in the Adaptec DPT SCSI Raid driver

2007-08-17 Thread Joe Korty
Fix section mismatch in the Adaptec DPT SCSI Raid driver. Signed-off-by: Joe Korty <[EMAIL PROTECTED]> Index: 2.6.23-rc3-git1/drivers/scsi/dpt_i2o.c === --- 2.6.23-rc3-git1.orig/drivers/scsi/dpt_i2o.c 2007-08-17 16:36:05.0 -

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-08-17 Thread Neil Horman
On Fri, Aug 17, 2007 at 11:41:20AM -0400, John Blackwood wrote: > Hi Neil, > > We've been having problems with this select patch change. > > Specifically -- previously, when a ptrace attach was done to a task > blocked in a select() call and that task had a timeout value, > the task would restart

Re: [PATCH RFC] CPU hotplug support for preemptible RCU

2007-08-17 Thread Paul E. McKenney
On Thu, Aug 16, 2007 at 06:26:18PM -0700, Paul E. McKenney wrote: > On Tue, Aug 14, 2007 at 04:41:16PM -0700, Paul E. McKenney wrote: > > Hello! > > > > Work in progress, not for inclusion. > > > > The attached patch passes multiple hours of rcutorture while hotplugging > > CPUs every ten seconds

Re: [PATCH 2/6] Use one zonelist that is filtered instead of multiple zonelists

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mel Gorman wrote: > +/* Returns the first zone at or below highest_zoneidx in a zonelist */ > +static inline struct zone **first_zones_zonelist(struct zonelist *zonelist, > + enum zone_type highest_zoneidx) > +{ > + struct zone **z; > +

Re: Early printk behaviour

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 03:49, Gerd Hoffmann pondered: > Mike Frysinger wrote: > >> Hmm, sort of, although I didn't think about the case of no real console > >> replacing the early console. The intention of the patch is to have a > >> smooth handover from the boot console to the real console. And, yes

Re: kfree(0) - ok?

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Andrew Morton wrote: > On Wed, 15 Aug 2007 05:12:41 +0530 (IST) > Satyam Sharma <[EMAIL PROTECTED]> wrote: > > > [PATCH] {slub, slob}: use unlikely() for kfree(ZERO_OR_NULL_PTR) check > > > > Considering kfree(NULL) would normally occur only in error paths and > > kfree(ZE

Re: [PATCH]: proc: export a processes resource limits via proc/

2007-08-17 Thread Neil Horman
On Fri, Aug 17, 2007 at 12:45:47PM -0700, Andrew Morton wrote: > On Fri, 17 Aug 2007 06:59:18 -0400 > Neil Horman <[EMAIL PROTECTED]> wrote: > > > Currently, there exists no method for a process to query the resource > > limits of another process. They can be inferred via some mechanisms but > >

Re: [PATCH 3/6] Embed zone_id information within the zonelist->zones pointer

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mel Gorman wrote: > +/* > + * SMP will align zones to a large boundary so the zone ID will fit in the > + * least significant biuts. Otherwise, ZONES_SHIFT must be 2 or less to > + * fit ZONES_SHIFT is always 2 or less Acked-by: Christoph Lameter <[EMAIL PROTECTED]> - To

Re: [PATCH 4/6] Record how many zones can be safely skipped in the zonelist

2007-08-17 Thread Christoph Lameter
Is there any performance improvement because of this patch? It looks like processing got more expensive since an additional cacheline needs to be fetches to get the skip factor. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

Re: kfree(0) - ok?

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Christoph Lameter wrote: > On Fri, 17 Aug 2007, Andrew Morton wrote: > > > are we seeing a pattern here? We could stick the unlikely inside > > ZERO_OR_NULL_PTR() itself. That's a little bit sleazy though - there might > > be future callsites at which it is likely, who kn

Re: [PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask()

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mel Gorman wrote: > Opinions as to why FASTCALL breaks on one machine are welcome. Could we get rid of FASTCALL? AFAIK the compiler should automatically choose the right calling convention? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] Cyclades: Avoid label defined but not used warning

2007-08-17 Thread Jesper Juhl
Hi, I don't like compiler warnings, especially not when they are easy to avoid. Building cyclades driver without CONFIG_PCI currently results in this : CC drivers/char/cyclades.o drivers/char/cyclades.c: In function 'cy_init': drivers/char/cyclades.c:5488: warning: label 'err_unr' def

Re: [PATCH -mm] x86_64: Save registers in saved_context during suspend and hibernation

2007-08-17 Thread Andrew Morton
On Fri, 17 Aug 2007 15:26:22 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > During hibernation and suspend on x86_64 save CPU registers in the > saved_context > structure rather than in a handful of separate variables. You have "-mm" in the subject but afaict this patch is not dependent

Re: Early printk behaviour

2007-08-17 Thread Mike Frysinger
On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > On Fri 17 Aug 2007 03:49, Gerd Hoffmann pondered: > > Mike Frysinger wrote: > > >> Hmm, sort of, although I didn't think about the case of no real console > > >> replacing the early console. The intention of the patch is to have a > > >> smooth h

Re: kfree(0) - ok?

2007-08-17 Thread Christoph Lameter
On Sat, 18 Aug 2007, Satyam Sharma wrote: > > page = get_object_page(object); > > Hmm, I didn't know ksize(NULL) was also allowed to succeed (and > return 0). That was merged over my objections. IMHO ksize(NULL) should fail since we are determining the size of an unallocated object. > Oh y

Re: [PATCH] Fix section mismatch in the Adaptec DPT SCSI Raid driver

2007-08-17 Thread Andrew Morton
On Fri, 17 Aug 2007 16:51:15 -0400 Joe Korty <[EMAIL PROTECTED]> wrote: > Fix section mismatch in the Adaptec DPT SCSI Raid driver. > > Signed-off-by: Joe Korty <[EMAIL PROTECTED]> > > Index: 2.6.23-rc3-git1/drivers/scsi/dpt_i2o.c > ===

Re: kfree(0) - ok?

2007-08-17 Thread Satyam Sharma
On Sat, 18 Aug 2007, Satyam Sharma wrote: > On Fri, 17 Aug 2007, Christoph Lameter wrote: > > > On Fri, 17 Aug 2007, Andrew Morton wrote: > > > > > are we seeing a pattern here? We could stick the unlikely inside > > > ZERO_OR_NULL_PTR() itself. That's a little bit sleazy though - there > >

[PATCH] IRDA: Avoid a label defined but not used warning in irda_init()

2007-08-17 Thread Jesper Juhl
Hi, Easily avoidable compiler warnings bug me. Building irmod without CONFIG_SYSCTL currently results in : net/irda/irmod.c:132: warning: label 'out_err_2' defined but not used But that can easily be avoided by simply moving the label inside the existing "#ifdef CONFIG_SYSCTL" one line above

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-17 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Fri, 17 Aug 2007 12:52:39 -0700 > > When using RDMA you lose the capability to do packet shaping, > > classification, and all the other wonderful networking facilities > > you've grown to love and use over the years. > > Same thing with TSO and LRO

Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Mel Gorman wrote: > @@ -696,6 +696,16 @@ static inline struct zonelist *node_zone > return &NODE_DATA(nid)->node_zonelist; > } > > +static inline int zone_in_nodemask(unsigned long zone_addr, > + nodemask_t *nodes) > +{ > +#ifdef CONFIG_NUM

Re: Early printk behaviour

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 17:09, Mike Frysinger pondered: > On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > > > > Something like: > > > > Index: kernel/printk.c > > === > > --- kernel/printk.c (revision 3568) > > +++ kernel/printk.c

Re: [PATCH 01/12] Blackfin arch: add peripheral resource allocation support

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Hennerich, Michael wrote: > Hi Dave, > > Right - our patch descriptions needs to be worked on. Yes, please ... that makes reviewing easier! > For a well experienced > systems engineer being the same time the same guy who does the Hardware > and the Software this i

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Mike Frysinger wrote: > as Michael pointed out, in the Blackfin world we tend to keep things > very dynamic as we have dev systems which allow for dropping in of > optional cards at will, so doing this in the bootloader is way too > inflexible. That's the tradeoff: opti

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Hennerich, Michael wrote: > What Mike wants to point out is that a external IRQ is first a GPIO and > needs to be configured like an INPUT GPIO and then a specific bit needs > to be set unmask it as IRQ. > > So why not use the GPIO infrastructure to setup this pin as GPIO

Re: how to add debug information into the vmlinux

2007-08-17 Thread Jesper Juhl
On 17/08/07, Xu Yang <[EMAIL PROTECTED]> wrote: > Hello everyone, > > I am trying to port kernel 2.6.19 onto my system.so I need the c code > , which can show me where the program is running. I add -g when I > compile it. > You shouldn't need to do that manually, simply go into "make menuconfig", e

Re: kfree(0) - ok?

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Christoph Lameter wrote: > On Sat, 18 Aug 2007, Satyam Sharma wrote: > > > Hmm, I didn't know ksize(NULL) was also allowed to succeed (and > > return 0). > > That was merged over my objections. IMHO ksize(NULL) should fail since we > are determining the size of an unalloc

Re: kfree(0) - ok?

2007-08-17 Thread Pekka Enberg
On 8/18/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > That was merged over my objections. IMHO ksize(NULL) should fail since we > are determining the size of an unallocated object. Agreed, especially as we have real zero-sized objects returned from kmalloc() et al now. - To unsubscribe from t

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 14:24, David Brownell pondered: > Just for the record, this is an unusual way to use these calls. That is part of the natural evolution of the kernel isn't it - per James's keynote at OLS - you release something, and see how people [ab]use it until it either grows, evolves, or

Re: [PATCH -mm] x86_64: Save registers in saved_context during suspend and hibernation

2007-08-17 Thread Rafael J. Wysocki
On Friday, 17 August 2007 23:08, Andrew Morton wrote: > On Fri, 17 Aug 2007 15:26:22 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > During hibernation and suspend on x86_64 save CPU registers in the > > saved_context > > structure rather than in a handful of separate variables. > >

RE: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread Hennerich, Michael
>-Original Message- >From: David Brownell [mailto:[EMAIL PROTECTED] > >On Friday 17 August 2007, Hennerich, Michael wrote: >> What Mike wants to point out is that a external IRQ is first a GPIO and >> needs to be configured like an INPUT GPIO and then a specific bit needs >> to be set unm

Re: [PATCH][kprobes] support kretprobe-blacklist

2007-08-17 Thread Andrew Morton
On Fri, 17 Aug 2007 15:43:04 -0400 Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > This patch introduces architecture dependent kretprobe > blacklists to prohibit users from inserting return > probes on the function in which kprobes can be inserted > but kretprobes can not. > > Signed-off-by: Masam

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
Of course, since *normal* accesses aren't necessarily limited wrt re-ordering, the question then becomes one of "with regard to *what* does it limit re-ordering?". A C compiler that re-orders two different volatile accesses that have a sequence point in between them is pretty clearly a buggy co

Re: [PATCH 01/12] Blackfin arch: add peripheral resource allocation support

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 17:10, David Brownell pondered: > On the other hand, maybe you want your "typical" customer to > be more of a systems integrator than anything else. We are getting yelled at by our customers (I was on the phone yesterday), because the kernel build environment we distribute (the

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
(and yes, it is perfectly legitimate to want a non-volatile read for a data type that you also want to do atomic RMW operations on) ...which is undefined behaviour in C (and GCC) when that data is declared volatile, which is a good argument against implementing atomics that way in itself. Segh

Re: + cifs-check-for-granted-memory.patch added to -mm tree

2007-08-17 Thread Jesper Juhl
On 17/08/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > The patch titled > CIFS: check for granted memory > has been added to the -mm tree. Its filename is > cifs-check-for-granted-memory.patch > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See

Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

2007-08-17 Thread Oleg Nesterov
Neil Horman wrote: > > +static int proc_pid_limits(struct task_struct *task, char *buffer) > +{ > + unsigned int i; > + int count = 0; > + char *bufptr = buffer; > + > + struct rlimit rlim[RLIM_NLIMITS]; > + > + read_lock(&tasklist_lock); > + memcpy(rlim, task->signal->rlim

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
In a reasonable world, gcc should just make that be (on x86) addl $1,i(%rip) on x86-64, which is indeed what it does without the volatile. But with the volatile, the compiler gets really nervous, and doesn't dare do it in one instruction, and thus generates crap like movl

Re: [PATCH 02/12] Blackfin arch: Add label to call new GPIO API

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Robin Getz wrote: > On Fri 17 Aug 2007 14:24, David Brownell pondered: > > Just for the record, this is an unusual way to use these calls. > > That is part of the natural evolution of the kernel isn't it - per James's > keynote at OLS - you release something, and see how

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
Now the second wording *IS* technically correct, but come on, it's 24 words long whereas the original one was 3 -- and hopefully anybody reading the shorter phrase *would* have known anyway what was meant, without having to be pedantic about it :-) Well you were talking pretty formal (and detail

Re: [PATCH 01/12] Blackfin arch: add peripheral resource allocation support

2007-08-17 Thread David Brownell
On Friday 17 August 2007, Robin Getz wrote: > On Fri 17 Aug 2007 17:10, David Brownell pondered: > > On the other hand, maybe you want your "typical" customer to > > be more of a systems integrator than anything else. > > We are getting yelled at by our customers (I was on the phone yesterday), >

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
#define forget(a) __asm__ __volatile__ ("" :"=m" (a) :"m" (a)) [ This is exactly equivalent to using "+m" in the constraints, as recently explained on a GCC list somewhere, in response to the patch in my bitops series a few weeks back where I thought "+m" was bogus. ] [It wasn't ex

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
Here, I should obviously admit that the semantics of *(volatile int *)& aren't any neater or well-defined in the _language standard_ at all. The standard does say (verbatim) "precisely what constitutes as access to object of volatile-qualified type is implementation-defined", but GCC does help u

Re: [PATCH] Fix section mismatch in the Adaptec DPT SCSI Raid driver

2007-08-17 Thread Joe Korty
On Fri, Aug 17, 2007 at 02:18:56PM -0700, Andrew Morton wrote: > Please always provide at least a copy of the error message when providing > patches which fix warnings, or build errors, or section mismatches. > > For section mismatches, an analysis of what caused the problem would help, > too. It

Re: [PATCH][kprobes] support kretprobe-blacklist

2007-08-17 Thread Masami Hiramatsu
Hi Andrew, Thank you for comments. Andrew Morton wrote: >> Index: 2.6-mm/include/asm-i386/kprobes.h >> === >> --- 2.6-mm.orig/include/asm-i386/kprobes.h >> +++ 2.6-mm/include/asm-i386/kprobes.h >> @@ -44,6 +44,7 @@ typedef u8 kprobe_

Re: kfree(0) - ok?

2007-08-17 Thread Christoph Lameter
On Sat, 18 Aug 2007, Pekka Enberg wrote: > Agreed, especially as we have real zero-sized objects returned from > kmalloc() et al now. Slab allocators: Fail if ksize is called with a NULL parameter A NULL pointer means that the object was not allocated. One cannot determine the size of an objec

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-17 Thread Roland Dreier
> > > When using RDMA you lose the capability to do packet shaping, > > > classification, and all the other wonderful networking facilities > > > you've grown to love and use over the years. > > > > Same thing with TSO and LRO and who knows what else. > > Not true at all. Full classifi

[PATCH] serial: keep the DTR setting for serial console.

2007-08-17 Thread Yinghai Lu
[PATCH] serial: keep the DTR setting for serial console. with reverting "x86, serial: convert legacy COM ports to platform devices", we will have the serial console before the port is probled again. uart_add_one_port==>uart_configure_port==>set_mcttrl(port, 0) will clear the DTR setting by uart

[PATCH] x86-64: memset optimization

2007-08-17 Thread Stephen Hemminger
Optimize uses of memset with small constant offsets. This will generate smaller code, and avoid the slow rep/string instructions. Code copied from i386 with a little cleanup. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/asm-x86_64/string.h 2007-08-17 15:14:32.0

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Sat, 18 Aug 2007, Segher Boessenkool wrote: > > #define forget(a) __asm__ __volatile__ ("" :"=m" (a) :"m" (a)) > > > > [ This is exactly equivalent to using "+m" in the constraints, as recently > > explained on a GCC list somewhere, in response to the patch in my bitops > > series a fe

Re: kfree(0) - ok?

2007-08-17 Thread Thomas Gleixner
On Sat, 2007-08-18 at 00:42 +0300, Pekka Enberg wrote: > On 8/18/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > That was merged over my objections. IMHO ksize(NULL) should fail since we > > are determining the size of an unallocated object. > > Agreed, especially as we have real zero-sized o

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Sat, 18 Aug 2007, Segher Boessenkool wrote: > > > > No it does not have any volatile semantics. atomic_dec() can be > > > > reordered > > > > at will by the compiler within the current basic unit if you do not add > > > > a > > > > barrier. > > > > > > "volatile" has nothing to do with reord

Re: kfree(0) - ok?

2007-08-17 Thread Satyam Sharma
On Sat, 18 Aug 2007, Thomas Gleixner wrote: > On Sat, 2007-08-18 at 00:42 +0300, Pekka Enberg wrote: > > On 8/18/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > That was merged over my objections. IMHO ksize(NULL) should fail since we > > > are determining the size of an unallocated objec

[PATCH] i386: optimize memset of 6 and 8 bytes

2007-08-17 Thread Stephen Hemminger
Tne network code does memset for 6 and 8 byte values, that can easily be optimized into simple assignments without string instructions. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/asm-i386/string.h 2007-08-17 15:14:37.0 -0700 +++ b/include/asm-i386/string.h 2007-08

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Paul E. McKenney
On Thu, Aug 16, 2007 at 08:50:30PM -0700, Linus Torvalds wrote: > Just try it yourself: > > volatile int i; > int j; > > int testme(void) > { > return i <= 1; > } > > int testme2(void) > { > return j <= 1; > } > > and c

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
#define forget(a) __asm__ __volatile__ ("" :"=m" (a) :"m" (a)) [ This is exactly equivalent to using "+m" in the constraints, as recently explained on a GCC list somewhere, in response to the patch in my bitops series a few weeks back where I thought "+m" was bogus. ] [It wasn't ex

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-17 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Fri, 17 Aug 2007 16:31:07 -0700 > > > > When using RDMA you lose the capability to do packet shaping, > > > > classification, and all the other wonderful networking facilities > > > > you've grown to love and use over the years. > > > > > > Sa

[announce] Updated PS3 Linux Distro Kit released

2007-08-17 Thread Geoff Levand
For those interested, an updated PS3 Linux Distributor's Starter Kit (v1.4) was released. The release note is here: http://www.kernel.org/pub/linux/kernel/people/geoff/cell/CELL-Linux-CL_20070817-ADDON/README-e.txt And the CD-ROM iso image is here (169 MiB): ftp://ftp.infradead.org/pub/Son

Re: Marvell 88E8056 gigabit ethernet controller

2007-08-17 Thread Stephen Hemminger
On Fri, 17 Aug 2007 05:42:13 -0700 (PDT) Kevin E <[EMAIL PROTECTED]> wrote: > Hi all, > > I've read where the onboard Marvell lan controller on > some Gigabyte boards don't work. I've got two systems > using the same Gigabyte board, on one the LAN works on > the other it dies like describe

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-17 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > Commit 19d36ccdc34f5ed444f8a6af0cbfdb6790eb1177 "x86: Fix alternatives > and kprobes to remap write-protected kernel text" uses code which is > being patched for patching. > > In particular, paravirt_ops does patching in two stages: first it > calls paravirt_ops.patch, then it f

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
atomic_dec() writes to memory, so it _does_ have "volatile semantics", implicitly, as long as the compiler cannot optimise the atomic variable away completely -- any store counts as a side effect. I don't think an atomic_dec() implemented as an inline "asm volatile" or one that uses a "forget" m

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Herbert Xu
On Fri, Aug 17, 2007 at 04:59:12PM -0700, Paul E. McKenney wrote: > > gcc bugzilla bug #33102, for whatever that ends up being worth. ;-) I had totally forgotten that I'd already filed that bug more than six years ago until they just closed yours as a duplicate of mine :) Good luck in getting it

Re: [PATCH] [5/12] x86_64: Make patching more robust, fix paravirt issue

2007-08-17 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > This patch breaks Xen booting. I get infinite recursive faults during > patching when this patch is present. If I boot with > "noreplace-paravirt" it works OK, and it works as expected if I back > this patch out. I haven't tracked down the exact

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Segher Boessenkool
No it does not have any volatile semantics. atomic_dec() can be reordered at will by the compiler within the current basic unit if you do not add a barrier. "volatile" has nothing to do with reordering. If you're talking of "volatile" the type-qualifier keyword, then http://lkml.org/lkml/200

[PATCH 0/3] allow drivers to flush in-flight DMA

2007-08-17 Thread akepner
Altix supports "posted DMA", so that DMA may complete out of order. In some cases it's necessary for a driver to ensure that in-flight DMA has been flushed to memory for correct operation. In particular this can be a problem with Infiniband, where writes to Completion Queues can race with DMA

[PATCH 1/3] dma: introduce no-op stub "dma_flags_set_dmaflush"

2007-08-17 Thread akepner
Introduce a no-op stub function "dma_flags_set_dmaflush". Arches can override this if necessary to associate a "dmaflush" attribute with a DMA-able memory region. In-flight DMA will be flushed to host memory when a memory region with the dmaflush attribute is written to. Signed-off-by: Arthur

[PATCH 2/3] dma: override "dma_flags_set_dmaflush" for sn-ia64

2007-08-17 Thread akepner
Define ARCH_DOES_POSTED_DMA, and override the dma_flags_set_dmaflush function. Also define dma_flags_get_direction, dma_flags_get_dmaflush to retrieve the direction and "dmaflush attribute" from flags passed to the sn_dma_map_* functions. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- a

[PATCH 3/3] dma: use dma_flags_set_dmaflush in ib_umem_get

2007-08-17 Thread akepner
Add a new parameter "dmaflush" to ib_umem_get, and update all callers. For now only the mthca IB driver makes use of the new parameter. Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- drivers/infiniband/core/umem.c |8 ++-- drivers/infiniband/hw/amso1100/c2_provider.

Re: [PATCH] - git-send-email.perl

2007-08-17 Thread Junio C Hamano
Joe Perches <[EMAIL PROTECTED]> writes: > Here's a path to enable a command line option > that takes a string argument > > cc-cmd > > This modifies the @cc array to include whatever > output is produced by cc_cmd $patchfile > > cccmd can be stored in a config settings file > > previous versi

[PATCH 0/6] UML - Code cleanups for 2.6.24

2007-08-17 Thread Jeff Dike
These patches are 2.6.24 material. They are code cleanup, plus a minor bug fix. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majo

[PATCH 4/6] UML - Clean up tlb flush path

2007-08-17 Thread Jeff Dike
Tidy the tlb flushing code. With tt mode gone, there is no reason to have the capability to have different host-level address space updating routines. So, do_op is called directly from do_mmap, do_mprotect, and do_munmap, rather than calling a function pointer that it is given. There was a large

[PATCH 3/6] UML - Userspace files should call libc directly

2007-08-17 Thread Jeff Dike
A number of files that were changed in the recent removal of tt mode are userspace files which call the os_* wrappers instead of calling libc directly. A few other files were affected by this, through This patch makes these call glibc directly. There are also style fixes in the affected areas.

[PATCH 1/6] UML - Fix inlines

2007-08-17 Thread Jeff Dike
"extern inline" will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- include/asm-um/pgalloc.h |2 +- include/asm-um/pgtable-3level.h |2 +- include/asm-um/processor-x86_64.h |2 +- include

[PATCH 2/6] UML - Use 64-bits for block size on x86_64

2007-08-17 Thread Jeff Dike
The BLKGETSIZE ioctl expects a pointer to a long, os_file_size was providing an int. Therefore, ubd access to host block devices caused a segmentation fault on 64 bits systems. Signed-off-by: Nicolas George <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/os-Linux/file.

[PATCH 5/6] UML - Remove unneeded if from hostfs

2007-08-17 Thread Jeff Dike
Get rid of an empty if statement which might look like a bug to a casual reader. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- fs/hostfs/hostfs_user.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/fs/hostfs/hostfs_user.c ==

[PATCH 6/6] UML - Fix hostfs style

2007-08-17 Thread Jeff Dike
Style fixes in hostfs. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- fs/hostfs/hostfs.h |9 + fs/hostfs/hostfs_kern.c | 226 fs/hostfs/hostfs_user.c | 139 + 3 files changed, 202 insertions(+), 172 deletions

Re: kfree(0) - ok?

2007-08-17 Thread Christoph Lameter
On Sat, 18 Aug 2007, Thomas Gleixner wrote: > If yes, who invented this 1980s reminiscence, where you got valid > pointers for malloc(0) ? I believe his first name started with an L and ended with an s ;-) Seriously the kmalloc(0) pointer allowed us to detect cases in which people tried to stor

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Paul E. McKenney
On Sat, Aug 18, 2007 at 08:09:13AM +0800, Herbert Xu wrote: > On Fri, Aug 17, 2007 at 04:59:12PM -0700, Paul E. McKenney wrote: > > > > gcc bugzilla bug #33102, for whatever that ends up being worth. ;-) > > I had totally forgotten that I'd already filed that bug more > than six years ago until t

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Christoph Lameter
On Fri, 17 Aug 2007, Paul E. McKenney wrote: > On Sat, Aug 18, 2007 at 08:09:13AM +0800, Herbert Xu wrote: > > On Fri, Aug 17, 2007 at 04:59:12PM -0700, Paul E. McKenney wrote: > > > > > > gcc bugzilla bug #33102, for whatever that ends up being worth. ;-) > > > > I had totally forgotten that I'

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-17 Thread Satyam Sharma
On Fri, 17 Aug 2007, Christoph Lameter wrote: > On Fri, 17 Aug 2007, Paul E. McKenney wrote: > > > On Sat, Aug 18, 2007 at 08:09:13AM +0800, Herbert Xu wrote: > > > On Fri, Aug 17, 2007 at 04:59:12PM -0700, Paul E. McKenney wrote: > > > > > > > > gcc bugzilla bug #33102, for whatever that ends

Re: [PATCH] powerpc: Implement atomic{,64}_{read,write}() without volatile

2007-08-17 Thread Segher Boessenkool
Instead, use asm() like all other atomic operations already do. +static __inline__ long atomic64_read(const atomic_t *v) +static __inline__ void atomic64_set(atomic_t *v, long i) s/atomic_t/atomic64_t/ in both lines. I've edited my copy of the patch. Ouch, sorry about that. Segher -

<    1   2   3   4   >