[2.6.20.21 review 16/35] setpgid(child) fails if the child was forked by sub-thread

2007-10-13 Thread Willy Tarreau
commit b07e35f94a7b6a059f889b904529ee907dc0634d in mainline tree Spotted by Marcin Kowalczyk <[EMAIL PROTECTED]>. sys_setpgid(child) fails if the child was forked by sub-thread. Fix the "is it our child" check. The previous commit ee0acf90d320c29916ba8c5c1b2e908d81f5057d was not complete. (this

[2.6.20.21 review 07/35] SNAP: Fix SNAP protocol header accesses.

2007-10-13 Thread Willy Tarreau
The snap_rcv code reads 5 bytes so we should make sure that we have 5 bytes in the head before proceeding. Based on diagnosis and fix by Evgeniy Polyakov, reported by Alan J. Wylie. Patch also kills the skb->sk assignment before kfree_skb since it's redundant. Signed-off-by: Herbert Xu <[EMAIL P

[2.6.20.21 review 26/35] dir_index: error out instead of BUG on corrupt dx dirs

2007-10-13 Thread Willy Tarreau
commit 3d82abae9523c33d4a16fdfdfd2bdde316d7b56a in mainline. Convert asserts (BUGs) in dx_probe from bad on-disk data to recoverable errors with helpful warnings. With help catching other asserts from Duane Griffin <[EMAIL PROTECTED]> Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]> Acked-by: Dua

[2.6.20.21 review 27/35] ieee1394: ohci1394: fix initialization if built non-modular

2007-10-13 Thread Willy Tarreau
Initialization of ohci1394 was broken according to one reporter if the driver was statically linked, i.e. not built as loadable module. Dmesg: PCI: Device :02:07.0 not available because of resource collisions ohci1394: Failed to enable OHCI hardware. This was reported for a Toshiba Satel

[2.6.20.21 review 29/35] crypto: blkcipher_get_spot() handling of buffer at end of page

2007-10-13 Thread Willy Tarreau
This corresponds to upstream changesets e4630f9fd8cdc14eb1caa08dafe649eb5ae09985 and 32528d0fbda1093eeeaa7d0a2c498bbb5154099d. [CRYPTO] blkcipher: Fix handling of kmalloc page straddling The function blkcipher_get_spot tries to return a buffer of the specified length that does not straddle a page

[2.6.20.21 review 31/35] Fix IPV6 append OOPS.

2007-10-13 Thread Willy Tarreau
commit e1f52208bb968291f7d9142eff60b62984b4a511 in mainline. [IPv6]: Fix NULL pointer dereference in ip6_flush_pending_frames Some of skbs in sk->write_queue do not have skb->dst because we do not fill skb->dst when we allocate new skb in append_data(). BTW, I think we may not need to (or we sho

[2.6.20.21 review 33/35] Fix ipv6 double-sock-release with MSG_CONFIRM

2007-10-13 Thread Willy Tarreau
commit 3ef9d943d26dea764f4fecf3767001c90b778b0c in mainline Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Signed-off-by: David S. Miller <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- net/ipv6/raw.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)

[2.6.20.21 review 35/35] sysfs: store sysfs inode nrs in s_ino to avoid readdir oopses

2007-10-13 Thread Willy Tarreau
Backport of ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc1/2.6.22-rc1-mm1/broken-out/gregkh-driver-sysfs-allocate-inode-number-using-ida.patch For regular files in sysfs, sysfs_readdir wants to traverse sysfs_dirent->s_dentry->d_inode->i_ino to get to the inode number. Bu

[2.6.20.21 review 23/35] futex_compat: fix list traversal bugs

2007-10-13 Thread Willy Tarreau
commit 179c85ea53bef807621f335767e41e23f86f01df in mainline. The futex list traversal on the compat side appears to have a bug. It's loop termination condition compares: while (compat_ptr(uentry) != &head->list) But that can't be right because "uentry" has the special "pi" indicator bit

[2.6.20.21 review 30/35] fix realtek phy id in forcedeth

2007-10-13 Thread Willy Tarreau
commit ba685fb2abd71162bea6895a99449c1071b01402 in mainline. As noticed by Chuck Ebbert, commit c5e3ae8823693b260ce1f217adca8add1bc0b3de introduced a copy-paste typo, as realtek phy is 0x732 and not 0x1c1. Obvious fix below suggested by Ayaz Abdulla. Signed-off-by: Willy Tarreau <[EMAIL PROTECTED

[2.6.20.21 review 34/35] Fix datagram recvmsg NULL iov handling regression.

2007-10-13 Thread Willy Tarreau
commit ef8aef55ce61fd0e2af798695f7386ac756ae1e7 in mainline Subject: [2.6.20.21 review 34/35] [PATCH] [NET]: Do not dereference iov if length is zero When msg_iovlen is zero we shouldn't try to dereference msg_iov. Right now the only thing that tries to do so is skb_copy_and_csum_datagram_iovec

[2.6.20.21 review 24/35] Leases can be hidden by flocks

2007-10-13 Thread Willy Tarreau
commit 0e2f6db88a6900bc9db576d6b478b12ee60d61f7 in mainline. The inode->i_flock list contains the leases, flocks and posix locks in the specified order. However, the flocks are added in the head of this list thus hiding the leases from F_GETLEASE command, from time_out_leases() and other code that

[2.6.20.21 review 25/35] nfs: fix oops re sysctls and V4 support

2007-10-13 Thread Willy Tarreau
commit 49af7ee181f4f516ac99eba85d3f70ed42cabe76 in mainline. NFS unregisters sysctls only if V4 support is compiled in. However, sysctl table is not V4 specific, so unregister it always. Steps to reproduce: [build nfs.ko with CONFIG_NFS_V4=n] modrobe nfs rmmod nfs

[2.6.20.21 review 28/35] Fix race with shared tag queue maps

2007-10-13 Thread Willy Tarreau
The commit in Linus upstream git tree is f3da54ba140c6427fa4a32913e1bf406f41b5dda. Fix race with shared tag queue maps There's a race condition in blk_queue_end_tag() for shared tag maps, users include stex (promise supertrak thingy) and qla2xxx. The former at least has reported bugs in this are

[2.6.20.21 review 18/35] USB: fix linked list insertion bugfix for usb core

2007-10-13 Thread Willy Tarreau
commit e5dd01154c1e9ca2400f4682602d1a4fa54c25dd in mainline. This patch fixes the order of list_add_tail() arguments in usb_store_new_id() so the list can have more than one single element. Signed-off-by: Nathael Pajani <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> Sig

[2.6.20.21 review 05/35] DCCP: Fix DCCP GFP_KERNEL allocation in atomic context

2007-10-13 Thread Willy Tarreau
This fixes the following bug reported in syslog: [ 4039.051658] BUG: sleeping function called from invalid context at /usr/src/davem-2.6/mm/slab.c:3032 [ 4039.051668] in_atomic():1, irqs_disabled():0 [ 4039.051670] INFO: lockdep is turned off. [ 4039.051674] [] show_trace_log_lvl+0x1a/0x30 [ 403

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

2007-10-13 Thread Andy Whitcroft
On Sat, Oct 13, 2007 at 02:55:01PM +0200, Jan Engelhardt wrote: > > On Oct 13 2007 14:47, Adrian Bunk wrote: > >On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: > >> scripts/checkpatch.pl doesn't seem to like this patch: > >> > >> $ scripts/checkpatch.pl m68k-export-asm-cachect

[PATCH] Double-free in cx23885_initdev

2007-10-13 Thread Florin Malita
Both cx23885_initdev and cx23885_dev_setup free the device in their error path so a failure in the latter causes a double-free. Since cx23885_dev_setup is only called from cx23885_initdev, it should be safe to remove its deallocation and leave the cleanup up to the allocating function. Coveri

[2.6.20.21 review 17/35] sigqueue_free: fix the race with collect_signal()

2007-10-13 Thread Willy Tarreau
commit 60187d2708caa870f0825d753df1612ea688eb9e in mainline. Spotted by taoyue <[EMAIL PROTECTED]> and Jeremy Katz <[EMAIL PROTECTED]>. collect_signal: sigqueue_free: list_del_init(&first->list); if (!list_empty(&q->

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > Wait! > > I think I found the bug: Its a evil interaction between the above > patch and the swncq patch that is applied later. > The qc_defer patch removes the old ata_scmd_need_defer that was always > called for all drivers and substitutes i

Re: [patch 7/8] b43 wireless needs

2007-10-13 Thread Michael Buesch
On Saturday 13 October 2007 14:31:30 Geert Uytterhoeven wrote: > b43 wireless needs > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of > function 'mmiowb' > > linux/drivers/net/wireless/b43/phy.c: In f

Re: [patch 7/8] b43 wireless needs

2007-10-13 Thread Larry Finger
Geert Uytterhoeven wrote: > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of > function 'mmiowb' > > linux/drivers/net/wireless/b43/phy.c: In function 'b43_phy_write': > linux/drivers/net/wireless/b43/phy.

Re: [patch 8/8] ssb bus needs

2007-10-13 Thread Michael Buesch
On Saturday 13 October 2007 14:31:31 Geert Uytterhoeven wrote: > ssb bus needs > > linux/drivers/ssb/main.c: In function 'ssb_ssb_read16': > linux/drivers/ssb/main.c:518: error: implicit declaration of function 'readw' > linux/drivers/ssb/main.c: In function 'ssb_ssb_read32': > linux/drivers/ssb/

Re: [patch 2/8] m68k: Atari keyboard ACIA driver cleanup

2007-10-13 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > --- a/arch/m68k/atari/atakeyb.c > +++ b/arch/m68k/atari/atakeyb.c > @@ -1,5 +1,5 @@ > /* > - * linux/atari/atakeyb.c > + * linux/arch/m68k/atari/atakeyb.c Please kill that line. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linu

Re: [PATCH] Double-free in cx23885_initdev [sls][spam-bayes]

2007-10-13 Thread Steven Toth
Thanks for the patch, much appreciated. - Steve Florin Malita wrote: Both cx23885_initdev and cx23885_dev_setup free the device in their error path so a failure in the latter causes a double-free. Since cx23885_dev_setup is only called from cx23885_initdev, it should be safe to remove its dea

Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without

2007-10-13 Thread Joseph Fannin
On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ Domen Puncer's change to support "MPC5200 low power mode" (in powerpc-git, which is in Linus's tree now) adds new code calling mpc52xx_pm_prepare and

[patch 3/8] m68k: ignore restart_syscall

2007-10-13 Thread Geert Uytterhoeven
m68k: ignore restart_syscall, which is not needed on m68k. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- include/asm-m68k/unistd.h |3 +++ 1 file changed, 3 insertions(+) --- a/include/asm-m68k/unistd.h +++ b/include/asm-m68k/unistd.h @@ -351,6 +351,9 @@ #define __ARCH_WANT_SYS_

Re: Hitachi disk: spurious completions during NCQ

2007-10-13 Thread Luca
On 10/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 10 Oct 2007 21:03:43 +0200 > Luca Tettamanti <[EMAIL PROTECTED]> wrote: > > > Hello, > > sometimes kernel complains about spurious completions on my new > > notebook: > > > > ata3.00: exception Emask 0x2 SAct 0x407fd SErr 0x0 action 0x

[PATCH] mmc: possible leak in mmc_read_ext_csd

2007-10-13 Thread Florin Malita
The exception path associated with an invalid ext_csd_struct returns without freeing ext_csd. Coverity CID 1909. Signed-off-by: Florin Malita --- drivers/mmc/core/mmc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Randy Dunlap
Jan Engelhardt wrote: On Oct 13 2007 16:01, Stefan Richter wrote: .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice .config:176:warning: override: PREEMPT_VOLUNTARY modifies state choice "turns" is just o

Re: [PATCH] Allow kconfig to accept overrides

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 09:25, Randy Dunlap wrote: > Jan Engelhardt wrote: >> On Oct 13 2007 16:01, Stefan Richter wrote: >> > > .config:176:warning: override: reassigning to symbol PREEMPT_VOLUNTARY >> > > .config:176:warning: override: PREEMPT_VOLUNTARY turns state choice > > .config:176:warning: overrid

Compiling kernel 2.6.23.1 HELP

2007-10-13 Thread animesh saxena
Hi, I am a kernel newbie, so need some help trying to compile it. I have fedora 7 installed. While compiling it, I get errors as follows. HOSTCC scripts/basic/fixdep scripts/basic/fixdep.c:107:23: error: sys/types.h: No such file or directory scripts/basic/fixdep.c:108:22: error: sys/s

[PATCH] x86: trivial header merges

2007-10-13 Thread Brian Gerst
Merge 32/64-bit headers that simply redirect to asm-generic Signed-off-by: Brian Gerst <[EMAIL PROTECTED]> --- include/asm-x86/cputime.h |6 +- include/asm-x86/cputime_32.h |6 -- include/asm-x86/cputime_64.h |6 -- include/asm-x86/errno.h | 14 +-

Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without

2007-10-13 Thread Rafael J. Wysocki
On Saturday, 13 October 2007 17:50, Joseph Fannin wrote: > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ > > > Domen Puncer's change to support "MPC5200 low power mode" (in > powerpc-git, whi

wierd file perms

2007-10-13 Thread vignesh babu
Hi all, Was having trouble with the latest source-in compiling it and did an mrproper which fixed things...well-temporarily. I was hitting another issue with permissions-as root :( I was surprised and did an ls -l on the files and guess what I found: total 0 ?- ? ? ? ??

Re: 2.6.23-mm1

2007-10-13 Thread Gabriel C
Andrew Morton wrote: Hi, > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ > > - I've been largely avoiding applying anything since rc8-mm2 in an attempt > to stabilise things for the 2.6.23 merge. > > But that didn't stop all the subsystem maintainers from

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-13 Thread Ilpo Järvinen
On Sat, 13 Oct 2007, Willy Tarreau wrote: > It's possible that new SACK blocks that should trigger new LOST > markings arrive with new data (which previously made is_dupack > false). In addition, I think this fixes a case where we get > a cumulative ACK with enough SACK blocks to trigger the fast

Re: Compiling kernel 2.6.23.1 HELP

2007-10-13 Thread Kristoffer Ericson
Greetings, This is not the proper forum for compilation help (if nothing is broken of course). You would probably get good help asking on fedora forum (or simply do a search there). Looking at your log it seems to more reflect headers missing than anything wrong with the kernel in it self. If

2.6.23-git3 jfs/bio bug

2007-10-13 Thread Randy Dunlap
[ 9158.155844] JFS: nTxBlock = 8192, nTxLock = 65536 [ 9159.199567] BUG at fs/jfs/jfs_logmgr.c:2333 assert(bp->l_flag & lbmRELEASE) [ 9159.206566] [ cut here ] [ 9159.211189] kernel BUG at fs/jfs/jfs_logmgr.c:2333! [ 9159.216066] invalid opcode: [1] SMP [ 9159.220108]

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-13 Thread Willy Tarreau
Hi Ilpo, On Sat, Oct 13, 2007 at 08:15:52PM +0300, Ilpo Järvinen wrote: > On Sat, 13 Oct 2007, Willy Tarreau wrote: > > > It's possible that new SACK blocks that should trigger new LOST > > markings arrive with new data (which previously made is_dupack > > false). In addition, I think this fixes

Re: Compiling kernel 2.6.23.1 HELP

2007-10-13 Thread Willy Tarreau
On Sat, Oct 13, 2007 at 10:16:08PM +0530, animesh saxena wrote: > Hi, >I am a kernel newbie, so need some help trying to compile it. > I have fedora 7 installed. > > While compiling it, I get errors as follows. > > HOSTCC scripts/basic/fixdep > scripts/basic/fixdep.c:107:23: error: sy

Re: [PATCH] hiddev: Add 32bit ioctl compatibilty

2007-10-13 Thread Philip Langdale
Al Viro wrote: >> >> +static long hiddev_compat_ioctl(struct file *file, unsigned int cmd, >> unsigned long arg) >> +{ >> +struct inode *inode = file->f_path.dentry->d_inode; >> +return hiddev_ioctl(inode, file, cmd, compat_ptr(arg)); >> +} > > Just how many instances of that sucker do we

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/13/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: Wait! I think I found the bug: Its a evil interaction between the above patch and the swncq patch that is applied later. The qc_defer patch removes the old ata_scmd_need_defer that was always called for all drivers and

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-13 Thread Adrian Bunk
On Sat, Oct 13, 2007 at 07:22:14PM +0200, Willy Tarreau wrote: >... > Thanks for your help, I really appreciate it. In fact, I've reviewed them > four, but two of them did not apply and the code looked somewhat different, > so I considered them irrelevant to 2.6.20. I didn't understand that they >

Re: 2.6.23-mm1 thread exit_group issue

2007-10-13 Thread Andrew Morton
On Sat, 13 Oct 2007 16:02:30 +0400 Oleg Nesterov <[EMAIL PROTECTED]> wrote: > On 10/13, Oleg Nesterov wrote: > > > > On 10/12, Andrew Morton wrote: > > > > > > Bisection shows that this problem is caused by these two patches: > > > > > > pid-namespaces-allow-cloning-of-new-namespace.patch > > > >

Re: wierd file perms

2007-10-13 Thread Jan-Benedict Glaw
On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> wrote: > > I was surprised and did an ls -l on the files and guess what I found: > > total 0 > ?- ? ? ? ?? fcntl.c > ?- ? ? ? ?? fifo.c > ?- ? ? ? ?? filesys

Re: 2.6.23-git3 jfs/bio bug

2007-10-13 Thread Dave Kleikamp
On Sat, 2007-10-13 at 10:25 -0700, Randy Dunlap wrote: > [ 9158.155844] JFS: nTxBlock = 8192, nTxLock = 65536 > [ 9159.199567] BUG at fs/jfs/jfs_logmgr.c:2333 assert(bp->l_flag & lbmRELEASE) > [ 9159.206566] [ cut here ] > [ 9159.211189] kernel BUG at fs/jfs/jfs_logmgr.c:233

Re: 2.6.23-mm1

2007-10-13 Thread Andrew Morton
On Sat, 13 Oct 2007 19:12:49 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Hi, > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ > > > > - I've been largely avoiding applying anything since rc8-mm2 in an attempt > > to stabilise thi

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > 3 boots, all worked. So I'm very sure that was the bug, but I will now > > do a little load testing... > > > > The only strange thing about 2.6.23-mm1 is, that it takes ~4 second > > more to boot. > > So, you basically

Re: 2.6.23-mm1

2007-10-13 Thread Gabriel C
Andrew Morton wrote: > On Sat, 13 Oct 2007 19:12:49 +0200 Gabriel C <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >> >> Hi, >> >>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ >>> >>> - I've been largely avoiding applying anything since rc8-mm2 in an atte

Re: [PATCH 00/52] Introduce credential record

2007-10-13 Thread Theodore Tso
Hi David, I'm going to ask a stupid question, and I probably missed something in the 52 patches, but I see how the credential is used to do access checks, but why does the credentials record need to passed all the way into block allocator? What is it used for there?

regression(?): starting with 2.6.21 sending packets became broken.

2007-10-13 Thread Peter Volkov
Hello, all on the list. Please CC me in answers, I'm not subscribed. Please, if this is wrong list tell me what is correct. Starting with 2.6.21 (or may be 2.6.20 as I have not tried it) kernel I have problem that most tcp based services freeze at some point of operation. I've noticed this first

Re: Suspend Broken (Re: 2.6.23-mm1)

2007-10-13 Thread Rafael J. Wysocki
Hi, On Saturday, 13 October 2007 19:58, Dhaval Giani wrote: > Hi, > > I just tried 2.6.23-mm1 and suspend is not working there. automount > refuses to go in the freezer. I've attached dmesg (three attempts to > suspend so it gets a bit big). Suspend works on 2.6.23 and sched-devel. > > Another f

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-13 Thread Willy Tarreau
Hi Adrian, On Sat, Oct 13, 2007 at 07:50:36PM +0200, Adrian Bunk wrote: > On Sat, Oct 13, 2007 at 07:22:14PM +0200, Willy Tarreau wrote: > >... > > Thanks for your help, I really appreciate it. In fact, I've reviewed them > > four, but two of them did not apply and the code looked somewhat differe

Re: 2.6.23-mm1

2007-10-13 Thread Andrew Morton
On Sat, 13 Oct 2007 20:05:19 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > The only thing I noted during load testing (updating Gentoo == > compiling and installing) was, that there seems to be memory leak. > After ~2h 2.5 of my 4Gb where gone. But there where to many things > going on to pi

Re: [PATCH 00/52] Introduce credential record

2007-10-13 Thread Al Viro
On Sat, Oct 13, 2007 at 02:11:37PM -0400, Theodore Tso wrote: > Hi David, > >I'm going to ask a stupid question, and I probably missed something > in the 52 patches, but I see how the credential is used to do > access checks, but why does the credentials record need to passed all > the wa

Re: [patch 2/8] m68k: Atari keyboard ACIA driver cleanup

2007-10-13 Thread Geert Uytterhoeven
On Sat, 13 Oct 2007, Andreas Schwab wrote: > Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > > --- a/arch/m68k/atari/atakeyb.c > > +++ b/arch/m68k/atari/atakeyb.c > > @@ -1,5 +1,5 @@ > > /* > > - * linux/atari/atakeyb.c > > + * linux/arch/m68k/atari/atakeyb.c > > Please kill that line. Done. Ne

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sat, 13 Oct 2007 20:05:19 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > The only thing I noted during load testing (updating Gentoo == > > compiling and installing) was, that there seems to be memory leak. > > After ~2h 2.5 of my

Re: [PATCH] checkpatch: Fix line number reporting

2007-10-13 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > On Fri, Oct 12, 2007 at 03:26:54PM -0400, Mike D. Day wrote: > > Fix line number reporting when checking source files (as opposed to > > patches) > > > > Signed-off-by: Mike D. Day <[EMAIL PROTECTED]> > > Sorry you've had to fix this about

Re: [patch 7/8] b43 wireless needs

2007-10-13 Thread Geert Uytterhoeven
On Sat, 13 Oct 2007, Larry Finger wrote: > Geert Uytterhoeven wrote: > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of > > function 'mmiowb' > > > > linux/drivers/net/wireless/b43/phy.c: In function 'b

[PATCH] missing includes in arch/powerpc/platforms/52xx/lite5200.c

2007-10-13 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/platforms/52xx/lite5200.c b/arch/powerpc/platforms/52xx/lite5200.c index 0caa3d9..774f249 100644 --- a/arch/powerpc/platforms/52xx/lite5200.c +++ b/arch/powerpc/platforms/52xx/lite5200.c @@ -18,6 +18,8 @@ #include #include

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Torsten Kaiser wrote: 3 boots, all worked. So I'm very sure that was the bug, but I will now do a little load testing... The only strange thing about 2.6.23-mm1 is, that it takes ~4 second more to boot. So, you basicall

[PATCH] fallout from elsa setup split

2007-10-13 Thread Al Viro
... and yes, caller wants it to return int. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- diff --git a/drivers/isdn/hisax/elsa.c b/drivers/isdn/hisax/elsa.c index 0c1351b..948a9b2 100644 --- a/drivers/isdn/hisax/elsa.c +++ b/drivers/isdn/hisax/elsa.c @@ -1088,7 +1088,7 @@ setup_elsa_pci(struct Is

Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without

2007-10-13 Thread Joseph Fannin
On Sat, Oct 13, 2007 at 07:22:48PM +0200, Rafael J. Wysocki wrote: > On Saturday, 13 October 2007 17:50, Joseph Fannin wrote: > > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ > > > > > > D

Re: [patch 7/8] b43 wireless needs

2007-10-13 Thread Michael Buesch
On Saturday 13 October 2007 20:38:43 Geert Uytterhoeven wrote: > On Sat, 13 Oct 2007, Larry Finger wrote: > > Geert Uytterhoeven wrote: > > > linux/drivers/net/wireless/b43/pio.h: In function 'b43_pio_write': > > > linux/drivers/net/wireless/b43/pio.h:89: error: implicit declaration of > > > funct

Re: [PATCH] fallout from elsa setup split

2007-10-13 Thread Jeff Garzik
Al Viro wrote: ... and yes, caller wants it to return int. Signed-off-by: Al Viro <[EMAIL PROTECTED]> ACK (I was just about to send same) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [patch 3/8] m68k: ignore restart_syscall

2007-10-13 Thread Roman Zippel
Hi, On Sat, 13 Oct 2007, Geert Uytterhoeven wrote: > m68k: ignore restart_syscall, which is not needed on m68k. It's somewhat needed, but nobody has gotten around to actually implement it yet... bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] 0/3 checkpatch updates, new checkfiles script

2007-10-13 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Ingo Molnar writes: > > * Erez Zadok <[EMAIL PROTECTED]> wrote: > > > So, I ran the above script and it found nearly 1.5 million reported > > warnings/errors, with drivers being the largest abuser, not > > surprisingly. [...] > > have you tried that with the lat

Re: 2.6.23-mm1 pm_prepare() and _finish() w/ args vs. without

2007-10-13 Thread Rafael J. Wysocki
On Saturday, 13 October 2007 20:40, Joseph Fannin wrote: > On Sat, Oct 13, 2007 at 07:22:48PM +0200, Rafael J. Wysocki wrote: > > On Saturday, 13 October 2007 17:50, Joseph Fannin wrote: > > > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: > > > > > > > > ftp://ftp.kernel.org/pub/li

[PATCH] 2.6.23-mm1 gdth doesn't compile with CONFIG_ISA && !CONFIG_EISA

2007-10-13 Thread Bernhard Rosenkraenzer
gdth_irq_tab is defined only in #ifdef CONFIG_EISA, but used in gdth_init_isa() Signed-off-by: Bernhard Rosenkraenzer <[EMAIL PROTECTED]> --- linux-2.6.23/drivers/scsi/gdth.c.ark2007-10-13 20:51:32.0 +0200 +++ linux-2.6.23/drivers/scsi/gdth.c2007-10-13 20:52:05.0 +020

[PATCH] drivers/block/cpqarray,cciss: kill unused var

2007-10-13 Thread Jeff Garzik
The recent bio work and subsequent fixups created unused variables. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/block/cciss.c|1 - drivers/block/cpqarray.c |3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.

[PATCH] drivers/char/ip2: fix used-uninit'd bug

2007-10-13 Thread Jeff Garzik
Fix bug flagged by a variable-used-uninitialized warning. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/char/ip2/ip2main.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index bd94d5f..2a566a0 10064

[PATCH] drivers/pci, drivers/dma: kill unused vars

2007-10-13 Thread Jeff Garzik
Kill two never-used (not even in hidden debug macros) variables, noticed by the compiler. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c |1 - drivers/pci/hotplug/pci_hotplug_core.c |2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/dm

What still uses the block layer?

2007-10-13 Thread Rob Landley
My impression from asking questions on the linux-scsi mailing list is that the scsi upper/middle/lower layers doesn't use the block layer described in Documentation/block/*. For example, the scsi guys say: http://marc.info/?l=linux-scsi&m=118633268527856&w=2 Instead of using the block layer, SC

Re: Scsi on sparc build break in 2.6.23.

2007-10-13 Thread Rob Landley
On Thursday 11 October 2007 6:56:59 pm Adrian Bunk wrote: > On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote: > > On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote: > > > I assume you have the full .config in your build directory, and could > > > have taken it from there? > > > >

linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-13 Thread Rafael J. Wysocki
Hi, There are many traces like this in my dmesg from 2.6.23-git3 (they don't appear for vanilla 2.6.23): <4>sysfs: duplicate filename 'ethxx1' can not be created WARNING: at /home/rafael/src/linux-2.6/fs/sysfs/dir.c:425 sysfs_add_one() Call Trace: [] sysfs_add_one+0x5c/0xc9 [] sysfs_create_lin

[PATCH] JFS: Bio cleanup: Replace missing return statements

2007-10-13 Thread Jeff Garzik
From: Dave Kleikamp <[EMAIL PROTECTED]> commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" statements, rather than changing them to null returns. Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- Dave sent this under a diffe

[PATCH] Input: Refactor evdev 32bit compat to be shareable with uinput

2007-10-13 Thread Philip Langdale
Currently, evdev has working 32bit compatibility and uinput does not. uinput needs the input_event code that evdev uses, so let's refactor it so it can be shared. Signed-off-by: Philip Langdale <[EMAIL PROTECTED]> --- drivers/input/Makefile |2 drivers/input/evdev.c| 118 ++-

Re: Scsi on sparc build break in 2.6.23.

2007-10-13 Thread Adrian Bunk
On Sat, Oct 13, 2007 at 02:09:35PM -0500, Rob Landley wrote: > On Thursday 11 October 2007 6:56:59 pm Adrian Bunk wrote: > > On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote: > > > On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote: > > > > I assume you have the full .config in yo

Re: [PATCH] Version 6 (2.6.23) Smack: Simplified Mandatory Access Control Kernel

2007-10-13 Thread Casey Schaufler
--- Al Viro <[EMAIL PROTECTED]> wrote: > On Fri, Oct 12, 2007 at 10:01:17PM -0700, Casey Schaufler wrote: > > What do you need smk_sb for? Looks like dead weight... Reminant of an abandoned thought process. Cleaning. > smk_read_load(): obvious seq_file candidate. > smk_read_cipso(): ditto. >

Re: regression(?): starting with 2.6.21 sending packets became broken.

2007-10-13 Thread David
Peter Volkov wrote: > Hello, all on the list. > > Please CC me in answers, I'm not subscribed. Please, if this is wrong > list tell me what is correct. > > Starting with 2.6.21 (or may be 2.6.20 as I have not tried it) kernel I > have problem that most tcp based services freeze at some point of > o

Re: [PATCH] JFS: Bio cleanup: Replace missing return statements

2007-10-13 Thread Randy Dunlap
On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote: > > From: Dave Kleikamp <[EMAIL PROTECTED]> > > commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" > statements, rather than changing them to null returns. Is my git tree mucked up? It looks to me like it was commit e3

Re: 2.6.23-git3 jfs/bio bug

2007-10-13 Thread Linus Torvalds
On Sat, 13 Oct 2007, Dave Kleikamp wrote: > > commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" > statements, rather than changing them to null returns. Not commit 6712ecf8f648118c3363c142196418f89a510b90. It was the later e30408b2a99cb7b8bf529c7dc2328a19d71894cf commit

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
On Sat, 13 Oct 2007 18:25:24 +0200 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > Hi, > > highlights of this update: > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > duplicated from the IDE core and conversion to use the generic > DMA tuning code path (the rew

[git pull] Input updates for 2.6.24-rc0

2007-10-13 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get a bunch new drivers, fixes for existing ones and als

Re: regression(?): starting with 2.6.21 sending packets became broken.

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 19:59, David wrote: >Try > >echo 0 > /proc/sys/net/ipv4/tcp_window_scaling > >I bet you have broken router(s) between your machine and the problem >site(s). There is an xt_TCPOPTSTRIP module in the works that allows you to strip Window Scaling only on the connections you want (rath

Re: [PATCH] missing includes in arch/powerpc/platforms/52xx/lite5200.c

2007-10-13 Thread Grant Likely
On 10/13/07, Al Viro <[EMAIL PROTECTED]> wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> Nak, this patch should be used to fix it instead. A change to lite5200 got dropped during merging. http://patchwork.ozlabs.org/linuxppc/patch?id=14077 Cheers, g. > --- > diff --git a/arch/powerpc/platf

Re: [PATCH] missing includes in arch/powerpc/platforms/52xx/lite5200.c

2007-10-13 Thread Al Viro
On Sat, Oct 13, 2007 at 02:35:26PM -0600, Grant Likely wrote: > On 10/13/07, Al Viro <[EMAIL PROTECTED]> wrote: > > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > > Nak, this patch should be used to fix it instead. A change to > lite5200 got dropped during merging. > > http://patchwork.ozlabs.org/

x86: merge some trivially mergeable headers

2007-10-13 Thread Roland Dreier
Merge errno.h, resource.h, rtc.h, sections.h, serial.h and sockios.h, where i386 and x86_64 have no or only trivial comment/include guard differences. Build tested on both 32-bit and 64-bit, and booted on 64-bit. Signed-off-by: Roland Dreier <[EMAIL PROTECTED]> --- Not sure who's merging this typ

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > On Sat, 13 Oct 2007 18:25:24 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > highlights of this update: > > > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > > duplicated from the IDE core an

Re: x86: merge some trivially mergeable headers

2007-10-13 Thread Thomas Gleixner
On Sat, 13 Oct 2007, Roland Dreier wrote: > Merge errno.h, resource.h, rtc.h, sections.h, serial.h and sockios.h, > where i386 and x86_64 have no or only trivial comment/include guard > differences. > > Build tested on both 32-bit and 64-bit, and booted on 64-bit. > > Signed-off-by: Roland Dreie

[GIT PULL] please pull infiniband.git for-linus

2007-10-13 Thread Roland Dreier
Linus, please pull from master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This tree is also available from kernel.org mirrors at: git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-linus This will get one bug fix for a problem that complet

[PATCH] ohci-ssb with !CONFIG_PM

2007-10-13 Thread Al Viro
ohci_bus_{suspend,resume} exists only if we have CONFIG_PM; do the same thing as other subdrivers... Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- b0b4f616f9ca381aa6a8559923137ce7cadc4108 diff --git a/drivers/usb/host/ohci-ssb.c b/drivers/usb/host/ohci-ssb.c index bc3e785..fe70e72 100644

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
> Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > can be called outside ide-pmac driver through ppc_ide_md). Follow the code you pasted > pmif->regbase = (unsigned long) base + 0x2000

Re: 2.6.23-rc4-mm1 myri10ge module link error on x86_64

2007-10-13 Thread Avuton Olrich
On 9/7/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > David Miller wrote: > > From: David Miller <[EMAIL PROTECTED]> > > Date: Thu, 06 Sep 2007 13:40:38 -0700 (PDT) > > > >> From: Mathieu Desnoyers <[EMAIL PROTECTED]> > >> Date: Thu, 6 Sep 2007 15:37:51 -0400 > >> > >>> I got a link error on myri10ge

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > > Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > > can be called outside ide-pmac driver through ppc_ide_md). > > Follow the code you pasted

Re: What still uses the block layer?

2007-10-13 Thread Matthew Wilcox
On Thu, Oct 11, 2007 at 08:11:21PM -0500, Rob Landley wrote: > My impression from asking questions on the linux-scsi mailing list is that > the > scsi upper/middle/lower layers doesn't use the block layer described in > Documentation/block/*. Entirely incorrect. > Instead of using the block la

[GIT PULL] i2c updates for 2.6.24

2007-10-13 Thread Jean Delvare
Linus, Please pull the i2c subsystem updates for Linux 2.6.24 from: git://jdelvare.pck.nerim.net/jdelvare-2.6 i2c-for-linus There is one new I2C bus driver (i2c-davinci), support for the Intel Tolapai SMBus, some more conversions to the new i2c model, and a dozen random fixes and cleanups. Doc

[2.6.23-mm1] CONFIG_LOCALVERSION handling broken

2007-10-13 Thread Tilman Schmidt
Something seems to be amiss with CONFIG_LOCALVERSION handling. I am routinely building with CONFIG_LOCALVERSION="-testing" CONFIG_LOCALVERSION_AUTO=y My usual sequence of "make ; sudo make modules_install install" has worked fine for all of 2.6.23{-rc?{,-mm?},}. For 2.6.23-mm1 it fails with: [EMA

Re: [PATCH] NTFS error messages: replace static char pointers by static char arrays

2007-10-13 Thread Folkert van Heusden
>>> The patch below contains a small code clean-up for the NTFS driver: all >>> static char pointers to error message strings have been replaced by >>> static char arrays. While doing that clean-up, shouldn't these be converted as well? [EMAIL PROTECTED]:/usr/src/linux$ find . -name \*.c -print0

<    1   2   3   >