Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-12 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Mon, 12 Nov 2007 08:58:36 +0100 > On Sun, Nov 11, 2007 at 04:09:40PM +0900, Simon Horman wrote: > > On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote: > > > This patch removes the following unused EXPORT_SYMBOL's: > > > - ip_vs_try_bind_dest >

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 11, 2007, 11:23 +0200, James Courtier-Dutton <[EMAIL PROTECTED]> wrote: > DervishD wrote: >> Bonjour Xavier :) >> >> * Xavier Bestel <[EMAIL PROTECTED]> dixit: >> >>> Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : >>> * Benny Halevy <[EMAIL PROTECTED]> dixit

linux-nfs created at vger

2007-11-12 Thread David Miller
Because the sourceforge lists are a huge collection of spam and subscriber-posting only, and someone reminded me of this recently, I've decided to sort-of force the issue wrt. the NFS mailing lists by putting up a [EMAIL PROTECTED] I'll let the masses decide whether to use it or not :-) - To unsu

Re: [rfc][patch] remove nopage

2007-11-12 Thread Jon Masters
On Mon, 2007-11-12 at 02:56 +0100, Nick Piggin wrote: > This is a patch to remove 'nopage' from the tree. Interesting, but why now? What precipitated this? Jon. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordom

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread Benny Halevy
On Nov. 08, 2007, 17:58 +0200, Chris Snook <[EMAIL PROTECTED]> wrote: > Benny Halevy wrote: >> Greetings, >> >> I would like to hear peoples opinion about the indentation convention >> described below that I personally found the most practical with >> several different editors. >> >> The gist of it

Re: [rfc][patch] remove nopage

2007-11-12 Thread Jon Masters
On Mon, 2007-11-12 at 03:17 -0500, Jon Masters wrote: > On Mon, 2007-11-12 at 02:56 +0100, Nick Piggin wrote: > > > This is a patch to remove 'nopage' from the tree. > > Interesting, but why now? What precipitated this? Actually reading said patch and thinking helps. I'll go hide back under my

Re: [kvm-devel] [PATCH 0/24] paravirt_ops for unified x86 - that's me again!

2007-11-12 Thread Amit Shah
On Saturday 10 November 2007 00:12:41 Glauber de Oliveira Costa wrote: > Hey folks, > > Here's a new spin of the pvops64 patch series. > We didn't get that many comments from the last time, > so it should be probably almost ready to get in. Heya! > > >From the last version, the most notable changes

Re: linux-nfs created at vger

2007-11-12 Thread Benny Halevy
Dave, this sounds like a good idea. How about cross posting this message also to [EMAIL PROTECTED] Benny On Nov. 12, 2007, 10:16 +0200, David Miller <[EMAIL PROTECTED]> wrote: > Because the sourceforge lists are a huge collection of spam and > subscriber-posting only, and someone reminded me of t

Re: linux-nfs created at vger

2007-11-12 Thread David Miller
From: Benny Halevy <[EMAIL PROTECTED]> Date: Mon, 12 Nov 2007 10:44:10 +0200 > Dave, this sounds like a good idea. > How about cross posting this message also to [EMAIL PROTECTED] Feel free to forward it for me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: dio_get_page() lockdep complaints

2007-11-12 Thread Martin Schwidefsky
On Sun, 2007-11-11 at 20:49 +0100, Peter Zijlstra wrote: > Right, which gets us into all kinds of trouble because some sites need > mmap_sem to resolve some races, notably s390 31-bit and shm. You are refering to the mmap_sem use in compat_linux.c:do_mmap2, aren't you? That check for adresses > 2G

Re: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

2007-11-12 Thread Andy Whitcroft
On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote: > Andrew, > > I'm getting minor warnings when applying two patches from > > > It's probably not serious but I wonder if checkpatch catches this. > > Applying patch..git-net.patch > Warning: commi

Re: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)

2007-11-12 Thread Thomas Renninger
On Sun, 2007-11-11 at 20:10 +0100, Eric Piel wrote: > Hello, > > I've tried kernel 2.6.24-rc2 and I have a problem with the new option > for setting up the cpufreq ondemand governor as default: a kernel panic > happens early at boot time. If I boot first with performance governor > and later ch

Re: dio_get_page() lockdep complaints

2007-11-12 Thread Peter Zijlstra
On Mon, 2007-11-12 at 09:45 +0100, Martin Schwidefsky wrote: > On Sun, 2007-11-11 at 20:49 +0100, Peter Zijlstra wrote: > > Right, which gets us into all kinds of trouble because some sites need > > mmap_sem to resolve some races, notably s390 31-bit and shm. > > You are refering to the mmap_sem

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-12 Thread Frank Seidel
On Montag 12 November 2007 08:54:52, you (Adrian Bunk) wrote: > On Sat, Nov 10, 2007 at 11:04:41PM +0100, Jiri Slaby wrote: > > Why? Anyway I think this is the case. The body of the then branch is > > executed at > > most once, while the else branch each time but last. If you write/read 1002 > > b

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

2007-11-12 Thread Eric W. Biederman
Tetsuo Handa <[EMAIL PROTECTED]> writes: > Hello. > > Thanks for reformatting my patch > and sorry for surprising you with directory name > (I meant to type linux-2.6.24-rc2, not linux-2.6.22-rc2). > > According to linux-2.6.23, > it seems that I should return -ENOTDIR > for invalid args->nlen val

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Peter Zijlstra
On Mon, 2007-11-12 at 10:14 +0800, Zhang, Yanmin wrote: > > Subject: mm: speed up writeback ramp-up on clean systems > > I tested kernel 2.6.23, 2,6,24-rc2, 2.6.24-rc2_peter(2.6.24-rc2+this patch). > > 1) Compare among first/second/following running > 2.6.23: second run of iozone will get about

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Zhang, Yanmin
On Mon, 2007-11-12 at 10:45 +0100, Peter Zijlstra wrote: > On Mon, 2007-11-12 at 10:14 +0800, Zhang, Yanmin wrote: > > > > Subject: mm: speed up writeback ramp-up on clean systems > > > > I tested kernel 2.6.23, 2,6,24-rc2, 2.6.24-rc2_peter(2.6.24-rc2+this patch). > > > > 1) Compare among first/s

[PATCH] USB: power-management.txt - disconnect clarification

2007-11-12 Thread Tilman Schmidt
From: Tilman Schmidt <[EMAIL PROTECTED]> Add a paragraph to Documentation/usb/power-management.txt about the interaction between suspend and disconnect. Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]> --- --- linux-2.6/Documentation/usb/power-management.txt2007-10-14 00:41:08.0 +0

Re: [PATCH] x86: fix cpu-hotplug regression

2007-11-12 Thread Andreas Herrmann
On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2007 23:15:38 +0900 > "Akinobu Mita" <[EMAIL PROTECTED]> wrote: > > > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on > > > CPU_UP_PREPARE) > > > > > > Fix regression introduced with d435d862

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Peter Zijlstra
On Sun, 2007-11-11 at 23:52 +0100, Jan Engelhardt wrote: > >> Nack, we shoiuld never include userspace headers in kernel headers, > >> an even more never add !__KERNEL__ ifdefs. Just make sure your > >> programs include limit.h before including linux/cdrom.h. > > > >I think header files should be

Re: KPROBES: Instrumenting a function's call site

2007-11-12 Thread Ananth N Mavinakayanahalli
On Thu, Nov 08, 2007 at 02:42:33PM -0500, Avishay Traeger wrote: > Sorry for reviving a thread from two months ago... :) > > On Wed, 2007-09-26 at 10:09 +0530, Ananth N Mavinakayanahalli wrote: > > On Tue, Sep 25, 2007 at 06:12:38PM -0400, Avishay Traeger wrote: > > > Hello, > > > I am trying to u

Re: [2.6 patch] usb/serial/oti6858.c: cleanups

2007-11-12 Thread Adrian Bunk
On Mon, Nov 05, 2007 at 09:40:43PM +0100, Oliver Neukum wrote: > Am Montag 05 November 2007 schrieb Adrian Bunk: > > This patch containsthe following cleanups: > > - make the needlessly global send_data() static > > - an author without anemail address is OK, not a FIXME > > That should be up to th

Re: Problems using quickcam_messenger on ARM (FYI)

2007-11-12 Thread Mauro Carvalho Chehab
Em Ter, 2007-11-06 às 18:25 +0100, Markus Hirschmann escreveu: > Hello Kernel-Developer, > > Module quickcam_messenger seems to be broken (tried 2.6.18 and 2.6.22) > on 2 different NSLU2 (ARM). Picture is attached. Same kernel and module > can be used without any problems on x86 here. I don't ha

Re: [PATCH] x86: unification of cfufreq/Kconfig

2007-11-12 Thread Adrian Bunk
On Fri, Nov 09, 2007 at 07:36:02PM +0100, Andreas Herrmann wrote: >... > Mostly I have seen the ususal suspects (e.g. missing firmware and >... Not related to this patch, but you can set CONFIG_STANDALONE=y with KCONFIG_ALLCONFIG for your randconfig compiles. > Regards, > > Andreas cu Adrian

KVM fixes for 2.6.24-rc2

2007-11-12 Thread Avi Kivity
Linus, Please pull the tree at git://git.kernel.org/pub/scm/linux/kernel/git/avi/kvm.git for-linus Containing some fairly critical fixes for 2.6.24's KVM, including hard host hangs on AMD. Avi Kivity (5): KVM: x86 emulator: fix 'push imm8' emulation KVM: SVM: Fix SMP with kernel

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > No, because I be damn sure that some developers try compiling programs > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you > name it) which do not have to adhere to . It might use > instead, or whatever. Every C compiler has .

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Muli Ben-Yehuda
On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > We make the dma_mapping_ops structure to point to our structure so > that every DMA access goes through us. (This is the reason this only > works for 64-bit guest. 32-bit guest doesn't yet have a dma_ops > struct.) I need the same facil

Re: [kvm-devel] [PATCH 4/8] KVM: PVDMA: Introduce is_pv_device() dma operation

2007-11-12 Thread Muli Ben-Yehuda
On Wed, Nov 07, 2007 at 04:21:05PM +0200, Amit Shah wrote: > A guest can call dma_ops->is_pv_device() to find out if a device is > a passthrough'ed device (device passed on to a guest by the > host). If this is true, a hypercall will be made to translate DMA > mapping operations. Doesn't really b

Re: [patch 0/7] [RFC] SLUB: Improve allocpercpu to reduce per cpu access overhead

2007-11-12 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > Each IP compression tunnel instance does an alloc_percpu(). Actually all IPComp tunnels share one set of objects which are allocated per-cpu. So only the first tunnel would do that. In fact that was precisely the reason why per-cpu is used in IPComp a

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Robert P. J. Day
On Mon, 12 Nov 2007, Andreas Schwab wrote: > Jan Engelhardt <[EMAIL PROTECTED]> writes: > > > No, because I be damn sure that some developers try compiling programs > > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you > > name it) which do not have to adhere to . It might use

Re: [kvm-devel] [PATCH 5/8] KVM: PVDMA: Update dma_alloc_coherent to make it paravirt-aware

2007-11-12 Thread Muli Ben-Yehuda
On Wed, Nov 07, 2007 at 04:21:06PM +0200, Amit Shah wrote: > Of all the DMA calls, only dma_alloc_coherent might not actually > call dma_ops->alloc_coherent. We make sure that gets called if the > device that's being worked on is a PV device I always thougt that's a mess... the reason it's done t

RE: 2.6.24-rc1 and 2.6.24.rc2 hangs while running udev on my lapt op

2007-11-12 Thread SANGOI DINO LEONARDO
On Saturday, November 10, 2007 1:53 AM, Venki Pallipadi [mailto:[EMAIL PROTECTED] wrote: > > Dino, > > Can you try the patch below over rc2 and see whether it fixes > the problem. > Looking at the code, it should fix the problem. If it does > not, can you send me the output of acpidump from you

Re: snd_hda_intel 2.6.24-rc2 bug: interrupts don't always work on Lenovo X60s

2007-11-12 Thread Takashi Iwai
At Thu, 08 Nov 2007 14:48:32 -0800, Roland Dreier wrote: > > With 2.6.24-rc2 on my Lenovo X60s, I sometimes get: > > hda_intel: No response from codec, disabling MSI: last cmd=0x002f0d00 > hda_intel: azx_get_response timeout, switching to polling mode: last > cmd=0x002f0d00 > > when loa

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Eric W. Biederman
ciol <[EMAIL PROTECTED]> writes: > Hi, I'd like to ask you a few questions: > > * Do you like the way linux distributions integrate the kernel? > > * Wouldn't you prefer they ship with the stable and still maintained 2.6.16.X, > while providing optionally the latest kernel for those who want or ju

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

2007-11-12 Thread Tetsuo Handa
Hello. Eric W. Biederman wrote: > name[CTL_MAXNAME} is not valid. > name[0...CTL_MAXNAME-1] is valid. Yes. > The check that got lost in the refactoring was specfically: > > - if (tmp.nlen <= 0 || tmp.nlen >= CTL_MAXNAME) > - return -ENOTDIR; Thus I think tmp.nlen == CTL_MAXNA

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Amit Shah
On Monday 12 November 2007 16:20:01 Muli Ben-Yehuda wrote: > On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > > We make the dma_mapping_ops structure to point to our structure so > > that every DMA access goes through us. (This is the reason this only > > works for 64-bit guest. 32-bit

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-12 Thread Frans Pop
Sam Ravnborg wrote: > With this patchset the former ARCH=i386 / ARCH=x86_64 are > replaced by ARCH=x86. [...] > x86: drop backward compatibility symlinks to i386/boot and > > The fist kill the symlinks to bzImage. > Now that we changed everything else to x86 there is no reason to > keep the

Re: [kvm-devel] [PATCH 5/8] KVM: PVDMA: Update dma_alloc_coherent to make it paravirt-aware

2007-11-12 Thread Amit Shah
On Monday 12 November 2007 16:26:37 Muli Ben-Yehuda wrote: > On Wed, Nov 07, 2007 at 04:21:06PM +0200, Amit Shah wrote: > > Of all the DMA calls, only dma_alloc_coherent might not actually > > call dma_ops->alloc_coherent. We make sure that gets called if the > > device that's being worked on is a

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Andreas Schwab
"Robert P. J. Day" <[EMAIL PROTECTED]> writes: > On Mon, 12 Nov 2007, Andreas Schwab wrote: > >> Jan Engelhardt <[EMAIL PROTECTED]> writes: >> >> > No, because I be damn sure that some developers try compiling programs >> > in non-linux environments (cygwin, solaris, andyourpersonaldistro, you >>

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-12 Thread David Howells
Alan Cox <[EMAIL PROTECTED]> wrote: > > Some are part of the CPU core and affect things like CPU core itself, CPU > > caches, MMU/TLB and exceptions/interrupts. Others are on-silicon devices > > such as the serial ports, the bus controller, the SDRAM controller. > > How are they addressed - as C

Re: [patch 1/6] x86: apicdef unification: some constants made unsigned

2007-11-12 Thread Maciej W. Rozycki
On Tue, 6 Nov 2007, Robert Richter wrote: > -#define GET_APIC_VERSION(x) ((x)&0xFF) > -#define GET_APIC_MAXLVT(x) (((x)>>16)&0xFF) > -#define APIC_INTEGRATED(x) ((x)&0xF0) > +#define GET_APIC_VERSION(

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Vegard Nossum
On Nov 12, 2007 1:06 PM, Andreas Schwab <[EMAIL PROTECTED]> wrote: > "Robert P. J. Day" <[EMAIL PROTECTED]> writes: > > > On Mon, 12 Nov 2007, Andreas Schwab wrote: > > > >> Jan Engelhardt <[EMAIL PROTECTED]> writes: > >> > >> > No, because I be damn sure that some developers try compiling programs

Re: [patch] prepare kprobes code for x86 unification

2007-11-12 Thread Masami Hiramatsu
Hi Arjan, Arjan van de Ven wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Subject: prepare kprobes code for x86 unification > > This patch is a first step towards unification of the kprobes > infrastructure between 32 and 64 bit x86; the patch is mostly > about removing spurious whitespace

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Martin Knoblauch
- Original Message > From: "Zhang, Yanmin" <[EMAIL PROTECTED]> > To: Martin Knoblauch <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED]; LKML > Sent: Monday, November 12, 2007 1:45:57 AM > Subject: Re: iozone write 50% regression in kernel 2.6.24-rc1 > > On Fri, 2007-11-09 at 04:36 -0800, Mart

Re: Module init call vs symbols exporting race?

2007-11-12 Thread Jan Glauber
On Sat, 2007-11-10 at 18:27 +1100, Rusty Russell wrote: > We fail rather than sleep in the "dependency isn't ready" case. Partially > because it's not happened before, but partially because we risk nasty loops. If we fail since we have to in the "dependency isn't ready" case then the warning see

Re: [linux-usb-devel] [2.6 patch] usb/serial/oti6858.c: cleanups

2007-11-12 Thread Oliver Neukum
Am Montag 12 November 2007 schrieb Adrian Bunk: > On Mon, Nov 05, 2007 at 09:40:43PM +0100, Oliver Neukum wrote: > > Am Montag 05 November 2007 schrieb Adrian Bunk: > > > This patch containsthe following cleanups: > > > - make the needlessly global send_data() static > > > - an author without anema

[PATCH] module loader should not complain about unknown symbol

2007-11-12 Thread Jan Glauber
If module A depends on module B and module B has not yet finished its init() the module loader may print a warning about an unknown symbol. This happens if module B is still in state MODULE_STATE_COMING, as module A runs into resolve_symbol() for a symbol from module B. resolve_symbol() return 0 i

[PATCH] proc: loadavg reading race

2007-11-12 Thread Michal Schmidt
The avenrun[] values are supposed to be protected by xtime_lock. loadavg_read_proc does not use it. Theoretically this may result in an occasional glitch when the value read from /proc/loadavg would be as much as 1<<11 times higher than it should be. Signed-off-by: Michal Schmidt <[EMAIL PROTECTED

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Peter Zijlstra
Single socket, dual core opteron, 2GB memory Single SATA disk, ext3 x86_64 kernel and userland (dirty_background_ratio, dirty_ratio) tunables (5,10) - default 2.6.23.1-42.fc8 #1 SMP 524288 4 59580 60356 524288 4 59247 61101 524288 4

Re: question about sata-error on boot.

2007-11-12 Thread Tejun Heo
(cc Robert Hancock, maybe we need ATA_LFLAG_HRST_TO_RESUME for these controllers?) Andrew Morton wrote: >> On Fri, 2 Nov 2007 19:34:20 +0100 "Hemmann, Volker Armin" <[EMAIL >> PROTECTED]> wrote: >> Hi, > > (cc linux-ide) > >> for some time (and I can't say for how long, but the board is less tha

Re: [linux-usb-devel] [2.6 patch] usb/serial/oti6858.c: cleanups

2007-11-12 Thread Adrian Bunk
On Mon, Nov 12, 2007 at 02:14:36PM +0100, Oliver Neukum wrote: > Am Montag 12 November 2007 schrieb Adrian Bunk: > > On Mon, Nov 05, 2007 at 09:40:43PM +0100, Oliver Neukum wrote: > > > Am Montag 05 November 2007 schrieb Adrian Bunk: > > > > This patch containsthe following cleanups: > > > > - make

Re: Temporary lockup on loopback block device

2007-11-12 Thread Miklos Szeredi
> On 2.6.23 it could happen even without loopback Let's focus on this point, because we already know how the lockup happens _with_ loopback and any other kind of bdi stacking. Can you describe the setup? Or better still, can you reproduce it and post the sysrq-t output? Thanks, Miklos - To unsu

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Muli Ben-Yehuda
On Mon, Nov 12, 2007 at 05:26:24PM +0530, Amit Shah wrote: > On Monday 12 November 2007 16:20:01 Muli Ben-Yehuda wrote: > > On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > > > We make the dma_mapping_ops structure to point to our structure so > > > that every DMA access goes through us

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Jan Engelhardt
On Nov 12 2007 13:57, Vegard Nossum wrote: > >This seems like a good time to ask why the kernel doesn't use > for its INT_MAX and type definitions like uint32_t., etc. >>From the manpage: "The header is a subset of the > header more suitable for use in freestanding >environments, which might not

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Amit Shah
On Monday 12 November 2007 19:02:07 Muli Ben-Yehuda wrote: > On Mon, Nov 12, 2007 at 05:26:24PM +0530, Amit Shah wrote: > > On Monday 12 November 2007 16:20:01 Muli Ben-Yehuda wrote: > > > On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > > > > We make the dma_mapping_ops structure to po

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Muli Ben-Yehuda
On Mon, Nov 12, 2007 at 07:25:27PM +0530, Amit Shah wrote: > Selectively? What happens in the case when some iommu doesn't want > to invoke the prev_op, but the mapping depends on it being called > (eg, the hypercalling op is embedded somewhere in the prev_op chain) Bad things :-) There needs to

Re: [PATCH] sysfs: fix off-by-one error in fill_read_buffer

2007-11-12 Thread Tejun Heo
Miao Xie wrote: > Hi,everyone. > I found that there is a off-by-one problem in the following code. > > Version:2.6.24-rc2 > File:fs/sysfs/file.c:118-122 > Function:fill_read_buffer > > count = ops->show(kobj

Re: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)

2007-11-12 Thread Eric Piel
11/12/2007 10:16 AM, Thomas Renninger wrote/a écrit: On Sun, 2007-11-11 at 20:10 +0100, Eric Piel wrote: Hello, I've tried kernel 2.6.24-rc2 and I have a problem with the new option for setting up the cpufreq ondemand governor as default: a kernel panic happens early at boot time. If I boot f

Re: [v4l-dvb-maintainer] [RFC: 2.6 patch] remove saa7134-oss

2007-11-12 Thread Mauro Carvalho Chehab
Hi Adrian, Em Sex, 2007-11-09 às 07:03 +0100, Adrian Bunk escreveu: > The saa7134-oss is deprecated for quite some time, it's the only > remaining OSS user outside of sound/oss/, and considering how few and > what kind of soundcards are left supported by OSS I hardly see any use > cases left.

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Tuomo Valkonen
On 2007-11-12, Eric W. Biederman <[EMAIL PROTECTED]> wrote: > I think a megafreeze development model is sane. Finding a collection > of software versions that are all known to work together is very > interesting, and useful. Making it so you can deliver something that > just works to end users is

PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Yoav Artzi
According to my knowledge the PAGE_SIZE on 32bit architectures in 4KB. Logically, the PAGE_SIZE on 64bit architectures should be 8KB. That's at least the way I understand it. However, looking at the kernel code of x86_64, I see the PAGE_SIZE is 4KB. Can anyone explain to me what am I missing

[patch 3/3] arch_rebalance_pgtables call

2007-11-12 Thread schwidefsky
From: Martin Schwidefsky <[EMAIL PROTECTED]> In order to change the layout of the page tables after an mmap has crossed the adress space limit of the current page table layout a architecture hook in get_unmapped_area is needed. The arguments are the address of the new mapping and the length of it.

[patch 0/3] page table changes

2007-11-12 Thread schwidefsky
Hi Andrew, more than 2 weeks have passed since I posted my six page table patches to linux-kernel/linux-arch. Nobody complained so far (keeping fingers crossed..) and Ben has a use for the first two patches on powerpc as well. Next logical step would be to add the patches that affect common code to

[patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2007-11-12 Thread schwidefsky
From: Martin Schwidefsky <[EMAIL PROTECTED]> Background: I've implemented 1K/2K page tables for s390. These sub-page page tables are required to properly support the s390 virtualization instruction with KVM. The SIE instruction requires that the page tables have 256 page table entries (pte) follow

[patch 1/3] add mm argument to pte/pmd/pud/pgd_free.

2007-11-12 Thread schwidefsky
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> From: Martin Schwidefsky <[EMAIL PROTECTED]> The pgd/pud/pmd/pte page table allocation functions get a mm_struct pointer as first argument. The free functions do not get the mm_struct argument. This is 1) asymmetrical and 2) to do mm related page ta

Re: [PATCH] mm/memory.c follow_hugetlb_page compiler error (MMOTM)

2007-11-12 Thread aglitke
Argh. Who runs with CONFIG_HUGETLB_PAGE not set anyway ;) Acked-by: Adam Litke <[EMAIL PROTECTED]> On Sat, 2007-11-10 at 19:54 -0500, Erez Zadok wrote: > Using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 > 22:46". CONFIG_HUGETLB_PAGE not set. > > $ make > CC mm/memory

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Gerd Hoffmann
Muli Ben-Yehuda wrote: > On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > >> We make the dma_mapping_ops structure to point to our structure so >> that every DMA access goes through us. (This is the reason this only >> works for 64-bit guest. 32-bit guest doesn't yet have a dma_ops >>

Re: [RFC 7/13] Char: nozomi, remove struct irq

2007-11-12 Thread Frank Seidel
On Samstag 10 November 2007 00:47:31, you (Jiri Slaby) wrote: > nozomi, remove struct irq > struct irq (named as my_irq) is used only in ISR and its called functions. > We might silently use u16 variable on stack and remove all references to > this structure. This is the first step of struct nozomi

Re: [2.6 patch] libata: remove unused functions

2007-11-12 Thread Tejun Heo
Adrian Bunk wrote: > This patch removes the following obsolete functions: > - libata-core.c: __sata_phy_reset() > - libata-core.c: sata_phy_reset() > - libata-eh.c: ata_qc_timeout() > - libata-eh.c: ata_eng_timeout() > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Queued in #tj-upstream-fixes

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Jiri Slaby
On 11/12/2007 03:39 PM, Yoav Artzi wrote: > According to my knowledge the PAGE_SIZE on 32bit architectures in 4KB. > Logically, the PAGE_SIZE on 64bit architectures should be 8KB. That's at > least the way I understand it. However, looking at the kernel code of > x86_64, I see the PAGE_SIZE is 4KB.

Re: [Lksctp-developers] [PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()

2007-11-12 Thread Vlad Yasevich
Jesper Juhl wrote: > From: Jesper Juhl <[EMAIL PROTECTED]> > > In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak > the storage allocated for 'abort' by returning from the function > without using or freeing it. This happens in case > "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is

Re: build #338 failed for 2.6.24-rc2-g6e800af in linux/drivers/md/dm-mpath-hp-sw.c

2007-11-12 Thread Alasdair G Kergon
On Mon, Nov 12, 2007 at 01:33:21PM +0100, Toralf Förster wrote: > the build with the attached .config failed, make ends with: > drivers/built-in.o: In function `hp_sw_end_io': > dm-mpath-hp-sw.c:(.text+0xb0596): undefined reference to `__scsi_print_sense' > make: *** [.tmp_vmlinux1] Error 1 Does

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Adrian Bunk
On Mon, Nov 12, 2007 at 01:51:25PM +, Tuomo Valkonen wrote: > On 2007-11-12, Eric W. Biederman <[EMAIL PROTECTED]> wrote: > > I think a megafreeze development model is sane. Finding a collection > > of software versions that are all known to work together is very > > interesting, and useful.

Re: Kernel panic at boot with ondemand governor as default (2.6.24-rc2)

2007-11-12 Thread Thomas Renninger
On Mon, 2007-11-12 at 15:02 +0100, Eric Piel wrote: > 11/12/2007 10:16 AM, Thomas Renninger wrote/a écrit: > > On Sun, 2007-11-11 at 20:10 +0100, Eric Piel wrote: > >> Hello, > >> > >> I've tried kernel 2.6.24-rc2 and I have a problem with the new option > >> for setting up the cpufreq ondemand go

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-12 Thread Tejun Heo
Will Trives wrote: > Hello, > > > My mistake, it looks like the issue is to do with writing only. > > Mounting a standard DVD works fine with 2.6.24-rc2-git2. > > As soon as I try to use wodim or load k3b, that's when drive gets locked > up. > > The issue was still there with 2.6.23-git15 , I

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Yoav Artzi
Well, since the size of the kernel stack is one page, I figured it will grow when switching to 64-bit, because some of the types grow and a similar flow/stack will be bigger in 64-bit in comparison to 32-bit. Keeping the page size at 4kb and so keeping the stack at 4kb is a bit dangerous. Isn'

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

2007-11-12 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > +# -*- makefile -*- > > what's that? Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its an Assembly file and not a makefile. This causes it to attempt to do automatic indentation on it. Do you want me to drop these annotat

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread J. Bruce Fields
On Mon, Nov 12, 2007 at 10:13:08AM +0200, Benny Halevy wrote: > checkpatch allows to indent with any number of tabs and up to 7 spaces. > This is consistent with Documentation/CodingStyle and therefore can be > considered "correct". However, forcing everybody to the same tab expansion > setup is t

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Adrian Bunk
On Mon, Nov 12, 2007 at 05:32:36PM +0200, Yoav Artzi wrote: > Well, since the size of the kernel stack is one page, >... That's not true. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days.

Re: [PATCH] CRISv10 improve and bugfix fasttimer

2007-11-12 Thread Jesper Nilsson
On Fri, Nov 09, 2007 at 03:19:32PM -0800, Andrew Morton wrote: > On Thu, 8 Nov 2007 09:54:30 +0100 > Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > Improve and bugfix CRIS v10 fast timers. > > I'm trying to work out what's going on with all this cris activity. Is the > current code really that

[PATCH 1/2] UML - Fix recvmsg return value checking

2007-11-12 Thread Jeff Dike
Stupid bug - we need to compare the return value of recvmsg to the value of iov_len, not its size. This caused port_helper processes not to be killed on shutdown on x86_64 because the pids weren't being passed out properly. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/os-Linux/file.c

[PATCH 2/2] UML - Update address space affected by pud_clear

2007-11-12 Thread Jeff Dike
pud_clear wasn't setting the _PAGE_NEWPAGE bit, fooling tlb_flush into thinking that this area of the address space was up-to-date and not unmapping whatever was covered by the pud. This manifested itself as ldconfig on x86_64 complaining about the first library it looked at not being a valid ELF

[PATCH 0/2] UML - Two for 2.6.24

2007-11-12 Thread Jeff Dike
These two patches are bug fixes which need to get into 2.6.24. Jeff -- Work email - jdike at linux dot intel dot com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [kvm-devel] [PATCH 1/8] KVM: PVDMA Host: Handle reqeusts for guest DMA mappings

2007-11-12 Thread Joerg Roedel
On Wed, Nov 07, 2007 at 04:21:02PM +0200, Amit Shah wrote: > @@ -1649,6 +1913,15 @@ int kvm_emulate_hypercall(struct kvm_vcpu *vcpu) > } > > switch (nr) { > + case KVM_PV_DMA_MAP: > + ret = pv_map_hypercall(vcpu, a0, a1); > + break; > + case KVM_PV_DMA_

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Yoav Artzi
Looking at the source, I see: #ifdef CONFIG_4KSTACKS #define THREAD_SIZE(4096) #else #define THREAD_SIZE(8192) #endif So if I configure the option CONFIG_4KSTACK, I will get a 4KB kernel stack. Am I missing something here? Original Message Subject: Re

Re: [kvm-devel] [PATCH 3/8] KVM: PVDMA Guest: Guest-side routines for paravirtualized DMA

2007-11-12 Thread Joerg Roedel
On Mon, Nov 12, 2007 at 12:50:01PM +0200, Muli Ben-Yehuda wrote: > On Wed, Nov 07, 2007 at 04:21:04PM +0200, Amit Shah wrote: > > > We make the dma_mapping_ops structure to point to our structure so > > that every DMA access goes through us. (This is the reason this only > > works for 64-bit guest

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Jiri Slaby
On 11/12/2007 04:58 PM, Yoav Artzi wrote: > Looking at the source, I see: > > #ifdef CONFIG_4KSTACKS > #define THREAD_SIZE(4096) > #else > #define THREAD_SIZE(8192) > #endif > > > So if I configure the option CONFIG_4KSTACK, I will get a 4KB kernel > stack. Am I missing somet

Re: [patch 1/6] x86: apicdef unification: some constants made unsigned

2007-11-12 Thread Robert Richter
On 12.11.07 12:31:44, Maciej W. Rozycki wrote: > > -#defineGET_APIC_VERSION(x) ((x)&0xFF) > > -#defineGET_APIC_MAXLVT(x) (((x)>>16)&0xFF) > > -#defineAPIC_INTEGRATED(x) ((x)&0xF0) > > +#defineGET_APIC_VERS

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Tuomo Valkonen
On 2007-11-12 16:20 +0100, Adrian Bunk wrote: > The problem is not what the distributions ship, the problem is simply > that problems with distribution packaged software should be reported > to the distribution, not upstream. > > And for becoming at least marginally on-topic again: > Assuming yo

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Rogelio M. Serrano Jr.
Adrian Bunk wrote: > On Mon, Nov 12, 2007 at 01:51:25PM +, Tuomo Valkonen wrote: > >> On 2007-11-12, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> >>> I think a megafreeze development model is sane. Finding a collection >>> of software versions that are all known to work together is

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Yoav Artzi
I see. Thanks, guys. Original Message Subject: Re: PAGE_SIZE on 64bit and 32bit machines From: Kyle McMartin <[EMAIL PROTECTED]> To: Yoav Artzi <[EMAIL PROTECTED]> Date: Monday, November 12, 2007 6:11:06 PM On Mon, Nov 12, 2007 at 05:58:08PM +0200, Yoav Artzi wrote: Loo

Re: Coding Style: indenting with tabs vs. spaces

2007-11-12 Thread DervishD
Hi Benny :) * Benny Halevy <[EMAIL PROTECTED]> dixit: > Using only spaces as DervishD suggested works around that using brute > force by forcing the user to the author's preference which is > legitimate but may not be the most productive way. I admit it. > I think that my proposal of using

Re: 2.6.23-mm1 breaks C-state support on Intel T7200 x86_64

2007-11-12 Thread mark gross
On Fri, Nov 09, 2007 at 03:24:44PM -0500, [EMAIL PROTECTED] wrote: > On Thu, 08 Nov 2007 14:30:07 PST, Mark Gross said: > > > wing patch fixes up the cpuidle / pm-qos integration. > > > > I suspect that this is folded into another mm patch but it should fix > > C-state issue identified. > > Conf

Re: [RFC: 2.6 patch] add -fno-tree-scev-cprop to KBUILD_CFLAGS

2007-11-12 Thread Adrian Bunk
On Mon, Nov 12, 2007 at 05:24:18PM +0100, Bernd Schmidt wrote: > Adrian Bunk wrote: > > The gcc from svn that will become gcc 4.3 generates libgcc calls in > > cases like the following (on 32bit architectures): > > > > <-- snip --> > > > > static inline void timespec_add_ns(struct timespec *a,

Re: PAGE_SIZE on 64bit and 32bit machines

2007-11-12 Thread Kyle McMartin
On Mon, Nov 12, 2007 at 05:58:08PM +0200, Yoav Artzi wrote: > Looking at the source, I see: > > #ifdef CONFIG_4KSTACKS > #define THREAD_SIZE(4096) > #else > #define THREAD_SIZE(8192) > #endif > > > So if I configure the option CONFIG_4KSTACK, I will get a 4KB kernel > stack.

Re: iozone write 50% regression in kernel 2.6.24-rc1

2007-11-12 Thread Peter Zijlstra
On Mon, 2007-11-12 at 17:05 +0200, Benny Halevy wrote: > On Nov. 12, 2007, 15:26 +0200, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > Single socket, dual core opteron, 2GB memory > > Single SATA disk, ext3 > > > > x86_64 kernel and userland > > > > (dirty_background_ratio, dirty_ratio) tunables

Re: [RFC: 2.6 patch] add -fno-tree-scev-cprop to KBUILD_CFLAGS

2007-11-12 Thread Bernd Schmidt
Adrian Bunk wrote: > The gcc from svn that will become gcc 4.3 generates libgcc calls in > cases like the following (on 32bit architectures): > > <-- snip --> > > static inline void timespec_add_ns(struct timespec *a, u64 ns) > { > ... > while(ns >= NSEC_PER_SEC) { > ns

[PATCH] SLUB: killed the unused "end" variable

2007-11-12 Thread Denis Cheng
Since the macro "for_each_object" introduced, the "end" variable becomes unused anymore. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- mm/slub.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 84f59fd..9acb413 100644 --- a/mm/slub.c +++

Re: [PATCH] powerpc: Add EXPORT_SYMBOL for symbols required by fs_enet and cpm_uart

2007-11-12 Thread Scott Wood
Christoph Hellwig wrote: On Sun, Nov 11, 2007 at 06:01:37PM +0100, Jochen Friedrich wrote: --- a/arch/powerpc/sysdev/commproc.c +++ b/arch/powerpc/sysdev/commproc.c @@ -51,6 +51,8 @@ static void m8xx_cpm_dpinit(void); static uint host_buffer; /* One page of host buffer */ static uint host_end;

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Adrian Bunk
On Mon, Nov 12, 2007 at 06:02:54PM +0200, Tuomo Valkonen wrote: > On 2007-11-12 16:20 +0100, Adrian Bunk wrote: > > The problem is not what the distributions ship, the problem is simply > > that problems with distribution packaged software should be reported > > to the distribution, not upstream.

  1   2   3   4   >