Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Herbert Xu
Paul Mackerras [EMAIL PROTECTED] wrote: Well you must mean something different by strong typing from the rest of us. Strong typing means that the compiler can check that you have passed in the correct types of arguments, but the compiler doesn't have any visibility into what structures are

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Wed, 14 Nov 2007, Christian Kujau wrote: Yes, the nfsd process only got stuck when I did ls(1) (with or without -l) on a NFS share which contained a XFS partition. Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 17:28, David Brownell wrote: On Tuesday 13 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's wrong.

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 06:19, Nick Piggin wrote: On Thursday 15 November 2007 19:17, David Brownell wrote: On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hi, On Thu, Nov 15, 2007 at 12:11:10PM +1100, Paul Mackerras wrote: David Miller writes: From: Paul Mackerras [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 10:12:22 +1100 *I* never had a problem with a few extra system calls. I don't understand why you (apparently) do. We're

Re: OT: Does Linux have any Perfect Code

2007-11-15 Thread Philippe Elie
On Wed, 14 Nov 2007 at 20:21 +, Russell Leighton wrote: Bryan Cantrill of Sun (ala DTrace) has a notion of perfect code: http://blogs.sun.com/bmc/entry/on_i_dreaming_in_code He also has some examples (from bottom comment section of above): Can you list a small number of

Re: OT: Does Linux have any Perfect Code

2007-11-15 Thread Andi Kleen
Eric Dumazet [EMAIL PROTECTED] writes: http://cvs.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/os/timers.c#1106 I would say this code was OK 10 years ago. I would have expected 1997 compilers to already do these standard muliplication optimizations. Now that a processor

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Dave Young
On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote: On Wed, 14 Nov 2007, Kay Sievers wrote: Could it

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-15 Thread Jesper Nilsson
On Wed, Nov 14, 2007 at 06:29:17PM -0800, Denys Vlasenko wrote: On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: /* Not true gettimeofday, only checks the jiffies (uptime) + useconds */ -void __INLINE__ do_gettimeofday_fast(struct fasttime_t *tv) +inline void

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Andi Kleen
Herbert Xu [EMAIL PROTECTED] writes: That's strong static typing. Netlink is 90% strong static typing plus 10% strong dynamic typing. That is, it'll tell you at run-time if you give it the wrong netlink attribute. Well it tells you EINVAL no matter what is wrong. That's roughly similar to

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Thomas Gleixner wrote: On Wed, 14 Nov 2007, David Brownell wrote: The protection of the chip list can be converted to a mutex and does not need to be a spinlock at all. No, we still need to use a spinlock to protect table changes. The reason for that is

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 22:50:17 -0800 David Brownell [EMAIL PROTECTED] wrote: Since this is the code that runs under the lock No, there's more than that. This is what runs under it in the hot paths, yes, but the gpio request/free paths do more work than this. (That includes direction

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-15 Thread Jens Axboe
On Thu, Nov 15 2007, Rusty Russell wrote: On Wednesday 14 November 2007 23:39:31 Jens Axboe wrote: On Wed, Nov 14 2007, Rusty Russell wrote: Hi Jens, As you asked for some time ago. Of course, it turns out that the eject command ignores the error anyway, but it's nice that it

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 13:29:19 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Fixes for memory hotplug compile and .section handling. This patch fixes following bugs == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f ind_e820_area (between

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hello, On Wed, Nov 14, 2007 at 08:20:22PM -0800, dean gaudet wrote: On Wed, 14 Nov 2007, Andi Kleen wrote: Later a syscall might be needed with event multiplexing, but that seems more like a far away non essential feature. actually multiplexing is the main feature i am in need of. there

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 19:17, David Brownell wrote: On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's

Re: [PATCH] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-15 Thread Jonas Stare
Hi, thanks for the reply. :) Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 12 November 2007, Andrew Morton wrote: On Fri, 09 Nov 2007 11:22:41 +0100 Jonas Stare [EMAIL PROTECTED] wrote: Hi. This week I ran into a strange hardware problem. During boot I got a 35 second delay while waiting

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Kay Sievers
On Thu, 2007-11-15 at 16:14 +0800, Dave Young wrote: On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote:

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's wrong. Certainly it's right for the mainstream kernel.  

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Thu, 15 Nov 2007 00:20:33 -0800 David Brownell [EMAIL PROTECTED] wrote: - gpio_direction_input()/gpio_direction_output() implicitly request the pins, if they weren't already requested. Eek, that's completely wrong. Allowing to access a resource _before_ it is assigned and

EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at device_shutdown+0x32/0x60 which corresponds to the following place: c110659c

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 00:56:57 -0800 Andrew Morton [EMAIL PROTECTED] wrote: eek. What I now need to do with this patch is - Work out which patches in -mm it is actually fixing. - If that is more than one patch then split this patch up into multiple ones. - Stage the one or more fixup

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Patric Karlsson wrote: Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always put into PIO4 mode: [

[PATCH] fs: remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol

2007-11-15 Thread Jiri Olsa
remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- fs/compat.c| 49 include/linux/compat.h |8 --- 2 files changed, 0 insertions(+), 57 deletions(-) diff --git

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andy Whitcroft
On Thu, Nov 15, 2007 at 01:29:19PM +0900, KAMEZAWA Hiroyuki wrote: Fixes for memory hotplug compile and .section handling. This patch fixes following bugs == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f ind_e820_area (between 'init_memory_mapping' and

Re: tg3: strange errors and non-working-ness

2007-11-15 Thread Jarek Poplawski
On 13-11-2007 19:57, Jon Nelson wrote: I'm not sure if this is the right place, Me too. Looks more like acpi or pci problem. Did you try to experiment with something like: pci=noacpi or acpi=off boot parameters? Probably some point to your .config and dmesg should be useful too, so taking it to

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
On Thu, Nov 15, 2007 at 01:44:46AM -0800, Andrew Morton wrote: On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-15 Thread Andy Whitcroft
When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three of our test systems one job from each batch (1/4) failed. In each case the machine appears to have booted normally all the way to a login: prompt. However in the failed boots the networking though apparently initialised

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 09:39:15 + Andy Whitcroft [EMAIL PROTECTED] wrote: Can you explain this is bug for me. The routine was __init_refok and therefore ! __init and therefore always present. The logic there must guarentee it only calls the bootmem allocator in early boot, and the logic

Re: 2.6.24-rc2 panic: (non-exitent) NFS root f/s

2007-11-15 Thread Shane
On Wed, 2007-11-14 at 22:42 +0100, Rafael J. Wysocki wrote: Perhaps it just can't find the root filesystem at all? Indeed - thanks for the input. My supposed good source config didn't match the running kernel. A work in progress I had obviously forgotten about. Apologies for having disturbed

[PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the machine. With legacy machines such as iSeries that do not support hugepages,

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [0/3]

2007-11-15 Thread KAMEZAWA Hiroyuki
memory hotplug fix against 2.6.23-rc2-mm1. Changelog - Divided into 3 patches - dropped patch against mm/sparse.c ( This was my misunderstanding.) - merged Andy's suggestion. All patches are related to memory hotplug. [1/3] ... export memory_add_physaddr_to_nid to acpi memory hotplug [2/3]

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [1/3] memory_add_physaddr_to_nid export for acpi memhotplug.ko

2007-11-15 Thread KAMEZAWA Hiroyuki
Fix following reference error (when CONFIG_ACPI_HOTPLUG_MEMORY=m) == ERROR: memory_add_physaddr_to_nid [drivers/acpi/acpi_memhotplug.ko] undefined! == Changelog: - EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/x86/mm/srat_64.c |1 + 1

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

2007-11-15 Thread KAMEZAWA Hiroyuki
Changes __meminit to __init_refok. == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:find_e820_area (between 'init_memory_mapping' and 'arch_add_memory') == Changelog: * changes __init_refok from find_early_table_space() to init_memory_mapping(). Signed-off-by:

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [2/3] fix section mismatch in vmammap_allock_block

2007-11-15 Thread KAMEZAWA Hiroyuki
Fixes section mismatch below. WARNING: vmlinux.o(.text+0x946b5): Section mismatch: reference to .init.text:' __alloc_bootmem_node (between 'vmemmap_alloc_block' and 'vmemmap_pgd_populate') Changelog - changed bootmem alloc wrapper function's name to be __earlyonly_bootmem_alloc().

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the

[PATCH 1/2]: drivers/char: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // smpl @@ expression dev; expression E; @@ * pci_dev_put(dev)

[PATCH 2/2]: drivers/video: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // smpl @@ expression dev; expression E; @@ * pci_dev_put(dev)

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to switch to another allocator with more extensive debugging facilities. Ok, so the thing we still can do

Re: 2.6.24-rc2-mm1 -- QLogics ISP1020 gone missing

2007-11-15 Thread Andy Whitcroft
All of our machines with QLogics ISP1020 cards seem to have lost them on boot with 2.6.24-rc1-mm1+hotfixes. # lspci :00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 05) # lspci -n :00:0a.0 0100: 1077:1020 (rev 05) # lspci -v -v :00:0a.0 SCSI storage

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 11:43:32 +0100 The crash logs contain this: VFS: Mounted root (ext3 filesystem) readonly. Freeing unused kernel memory: 396k freed Write protecting the kernel read-only data: 2056k udev: renamed network interface eth1 to eth0

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
On (15/11/07 02:39), Andrew Morton didst pronounce: On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 21:43, Ingo Molnar wrote: * David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to switch to another allocator with more extensive

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:52:38 + [EMAIL PROTECTED] (Mel Gorman) wrote: Shouldn't this have been HUGETLB_PAGE_ORDER? As a #define, possibly but as a static inline - definitly not. In this context, the define is not used because set_pageblock_order() is a no-op when

[PATCH] trivial: SERIAL_NETX_CONSOLE provides console for NetX, not IMX

2007-11-15 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] --- drivers/serial/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index d6ae38e..6d0c97a 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@

[PATCH Documentation] use the newc archive format as requested by initramfs

2007-11-15 Thread Uwe Kleine-König
This is a documentation followup to 2e591bbc0d563e12f5a260fbbca0df7d5810910e Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] --- Documentation/initrd.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/initrd.txt b/Documentation/initrd.txt index

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: Yeah I wish udev would just leave the damn devices alone. It even does things like try to rename a network device to the same name it already has, and other strange stuff. But that log difference is a good clue. Because udev can try to rename a

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 12:03:25 +0100 now that it's reproducible again i'll try more direct debugging. (Networking might not even be the cause of this - that was just a quick first impression that i had.) Btw., the .config is the result of automated

Re: [patch 5/8] Immediate Values - x86 Optimization

2007-11-15 Thread Rusty Russell
On Thursday 15 November 2007 16:37:51 Mathieu Desnoyers wrote: * Rusty Russell ([EMAIL PROTECTED]) wrote: On Thursday 15 November 2007 15:06:10 Mathieu Desnoyers wrote: A - the NMI or MCE code calls any external kernel code (printk, notify_die, spin_lock/unlock, die_nmi, lapic_wd_event

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
On (15/11/07 02:32), Andrew Morton didst pronounce: On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is

[2.6.24-rc2-git5] kernel panic when config_sysfs = n

2007-11-15 Thread Daniel Lezcano
Hi, When I tryed to boot with qemu a 2.6.24-rc2-git5 with sysfs disabled, the boot fails when trying to mount root partition: VFS: Cannot open root device hda2 or unknown-block(0,0) Please append a correct root= boot option; here are the available partitions: 03002097152 hda0300

Re: [2.6.24-rc2-git5] kernel panic when config_sysfs = n

2007-11-15 Thread Daniel Lezcano
Alexey Dobriyan wrote: On 11/15/07, Daniel Lezcano [EMAIL PROTECTED] wrote: When I tryed to boot with qemu a 2.6.24-rc2-git5 with sysfs disabled, the boot fails when trying to mount root partition: VFS: Cannot open root device hda2 or unknown-block(0,0) Please append a correct root= boot

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-15 Thread Jens Axboe
On Thu, Nov 15 2007, Rusty Russell wrote: On Thursday 15 November 2007 19:47:05 Jens Axboe wrote: On Thu, Nov 15 2007, Rusty Russell wrote: If blk_rq_map_sg returns more than was allocated, it's a bug, and something's already been overwritten. BUG_ON() is probably the right thing

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 22:28, Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: Anyway, I'm really happy to see you're testing and using SLOB upstream :) Is there any particular reason that you're using it? i sometimes test SLOB for -rt, but this time it's the result of my

[PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?)

2007-11-15 Thread Jonas Danielsson
Fix arp reply when received arp probe with sender ip 0. Can't find any ground in RFC2131 to send a non-valid arp-reply in the special case of sender ip being set to 0. - Bug fix for arp handling when sender ip is set to 0. Send a correct arp reply instead of one with sender ip and sender

[PATCH 1/2] fuse: fix uninitialized field in fuse_inode

2007-11-15 Thread Miklos Szeredi
Andrew, Please queue these two fixes for 2.6.24, along with the rest of the fuse patches currently in -mm. Thanks, Miklos From: John Muir [EMAIL PROTECTED] I found problems accessing (executing) previously existing files, until I did chmod on them (or setattr). If the fi-attr_version is

[PATCH 2/2] fuse: fix attribute caching after rename

2007-11-15 Thread Miklos Szeredi
Invalidate attributes on rename, since some filesystems may update st_ctime. Reported by Szabolcs Szakacsits Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux-2.6.24-rc2/fs/fuse/dir.c === ---

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* Nick Piggin [EMAIL PROTECTED] wrote: On Thursday 15 November 2007 21:43, Ingo Molnar wrote: * David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to

Re: [2.6.24-rc2-git5] kernel panic when config_sysfs = n

2007-11-15 Thread Alexey Dobriyan
On 11/15/07, Daniel Lezcano [EMAIL PROTECTED] wrote: When I tryed to boot with qemu a 2.6.24-rc2-git5 with sysfs disabled, the boot fails when trying to mount root partition: VFS: Cannot open root device hda2 or unknown-block(0,0) Please append a correct root= boot option; here are the

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-15 Thread Rusty Russell
On Thursday 15 November 2007 19:47:05 Jens Axboe wrote: On Thu, Nov 15 2007, Rusty Russell wrote: If blk_rq_map_sg returns more than was allocated, it's a bug, and something's already been overwritten. BUG_ON() is probably the right thing here. It really just means that it mapped more

mmap dirty limits on 32 bit kernels (Was: [BUG] New Kernel Bugs)

2007-11-15 Thread Bron Gondwana
On Wed, Nov 14, 2007 at 09:53:38PM -0800, Linus Torvalds wrote: On Wed, 14 Nov 2007, Linus Torvalds wrote: So even at 100% dirty limits, it won't let you dirty more than 1GB on the default 32-bit setup. Side note: all of these are obviously still just heuristics. If you really

Re: [PATCH 2/5] Construct one fakephp slot per pci slot

2007-11-15 Thread Rolf Eike Beer
Am Mittwoch, 14. November 2007 schrieb Alex Chiang: * Matthew Wilcox [EMAIL PROTECTED]: On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang wrote: Register one slot per slot, rather than one slot per function. Change the name of the slot to fake%d instead of the pci address.

[patch] slob: fix memory corruption

2007-11-15 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: I had implemented SLOB in userspace, so I resynched and think I found your problem. Sorry for the attachment format -- this mailer isn't the best. I'm really computer illiterate when it comes to userspace... thx, i'll try your fix in a minute.

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Bron Gondwana
On Thu, Nov 15, 2007 at 06:59:34AM +0100, Rene Herman wrote: On 15-11-07 05:16, Bron Gondwana wrote: Totally unrelated - I sent something to the kolab mailing list a couple [ ... ] I'm sure if I had something that I considered worth informing the ALSA project of, I'd be wary of spending

Re: [patch 00/16] 2.6.23-stable review, network driver changes

2007-11-15 Thread Heikki Orsila
On Wed, Nov 14, 2007 at 10:39:21PM -0800, Greg KH wrote: This is the start of the stable review cycle for the 2.6.23.X release. There are 16 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let us know. ...

[PATCH] chelsio - Fix skb-dev setting

2007-11-15 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] eth_type_trans() now sets skb-dev. Access skb-def after it gets set. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/chelsio/sge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/chelsio/sge.c

Re: [PATCH] More CFI fixups for Atmel chips

2007-11-15 Thread Haavard Skinnemoen
On Tue, 30 Oct 2007 16:33:07 +0100 Haavard Skinnemoen [EMAIL PROTECTED] wrote: This patch (or some variation of it) has been posted a couple of times before to the MTD list, and I find myself applying it over and over again when testing stuff against the latest mainline tree. I'd appreciate

Re: [PATCH] ata_sg_setup_one vs ata_sg_setup?

2007-11-15 Thread Rusty Russell
On Thursday 15 November 2007 15:08:00 Tejun Heo wrote: Rusty Russell wrote: Hi Jeff, Was looking through libata, and it seems to me that ata_sg_setup is a superset of ata_sg_setup_one. Am I missing something? Seems like it could be simplified. My machine never seems to do an

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-15 Thread Jean Delvare
Hi all, On Wed, 14 Nov 2007 04:21:51 -0500 (EST), Robert P. J. Day wrote: On Wed, 14 Nov 2007, Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] Drop #include linux/moduleparam.h in files that also include #include linux/module.h. module.h includes moduleparam.h

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Rene Herman
On 15-11-07 13:02, Bron Gondwana wrote: I get the same information from both project websites: moderated for non-members, public archives - no way of knowing that ALSA will accept me informing them of something they would be interested without committing to reading or bit-bucketing their list.

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Dave Haywood
Ingo Molnar wrote: * Nick Piggin [EMAIL PROTECTED] wrote: On Thursday 15 November 2007 21:43, Ingo Molnar wrote: * David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for

[PATCH] [CIFS] fix potential data corruption when there are errors writing out dirty pages

2007-11-15 Thread Jeff Layton
The idea here is separate conscious from unconscious flushes. Conscious flushes are those due to a fsync() or close(). Unconscious ones are flushes that occur as a side effect of some other operation or due to memory pressure. Currently, when an error occurs during an unconscious flush (ENOSPC or

Re: [PATCH 1/4] drivers/i2c: Drop redundant includes of moduleparam.h

2007-11-15 Thread Robert P. J. Day
On Thu, 15 Nov 2007, Jean Delvare wrote: ... snip ... I share Robert's point of view here. Relying on header files including each other is usually not a good idea, as build then breaks when the headers are cleaned up or reorganized. ... more snip ... If there's a fundamental reason why

Re: [patch] slob: fix memory corruption

2007-11-15 Thread Ingo Molnar
From: Nick Piggin [EMAIL PROTECTED] - if (free_slob_pages.next != prev-next) + if (prev != free_slob_pages.prev + free_slob_pages.next != prev-next) list_move_tail(free_slob_pages, prev-next); btw., exactly how did

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Yasunori Goto
On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Jörn Engel
On Thu, 15 November 2007 13:26:51 +0100, Rene Herman wrote: Can you please just shelve this crap? You have a way of knowing that ALSA will accept you and that is knowing or assuming that the ALSA project doesn't consist of drooling retards. Well, my experience with moderation has been that

[Patch] UML: building error fix

2007-11-15 Thread WANG Cong
include/asm-um/arch points to the non-existed include/asm-i386 directory. This patch fixed it. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Jeff Dike [EMAIL PROTECTED] --- diff --git a/arch/um/Makefile b/arch/um/Makefile index 31999bc..ba6813a 100644 --- a/arch/um/Makefile +++

[GIT PULL] avr32 fixes for 2.6.24-rc3

2007-11-15 Thread Haavard Skinnemoen
Linus, Please pull from ssh://master.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6.git for-linus to receive the following updates. Adrian Bunk (1): [AVR32] remove UID16 option Haavard Skinnemoen (4): [AVR32] pcmcia ioaddr_t should be 32 bits on AVR32 [AVR32]

Re: [PATCH][RFC] kprobes: Add user entry-handler in kretprobes

2007-11-15 Thread Abhishek Sagar
On Nov 15, 2007 4:21 AM, Jim Keniston [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 19:00 +0530, Abhishek Sagar wrote: First of all, some general comments. We seem to be trying to solve two problems here: 1. Prevent the asymmetry in entry- vs. return-handler calls that can develop when we

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Cornelia Huck
On Thu, 15 Nov 2007 21:55:34 +0900, Yasunori Goto [EMAIL PROTECTED] wrote: /** * device_shutdown - call -shutdown() on each device to shutdown. */ void device_shutdown(void) { struct device * dev, *devn; list_for_each_entry_safe_reverse(dev, devn, devices_kset-list,

Re: question on odd APIC behavior

2007-11-15 Thread Maciej W. Rozycki
On Thu, 15 Nov 2007, Oliver Neukum wrote: is there a way to so misprogramm an APIC that a physical interrupt results in two interrupts delivered? Certainly. One possibility is to have multiple processors marked as the destination, e.g. a logical delivery mode destination programmed with

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Olivier Galibert
On Thu, Nov 15, 2007 at 06:59:34AM +0100, Rene Herman wrote: Totally unrelated indeed so why are spouting crap? If the kohab list has a problem take it up with them but keep ALSA out of it. alsa-devel has only ever moderated out spam -- nothing else. That is incorrect. Hopefully it is the

[Patch] mm/sparse.c: Check the return value of sparse_index_alloc().

2007-11-15 Thread WANG Cong
Since sparse_index_alloc() can return NULL on memory allocation failure, we must deal with the failure condition when calling it. Signed-off-by: WANG Cong [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Cc: Rik van Riel [EMAIL PROTECTED] --- diff --git a/Makefile b/Makefile diff

[RFC PATCH 3/3] cpu-hotplug: Replace per-subsystem mutexes with get_online_cpus()

2007-11-15 Thread Gautham R Shenoy
From: Gautham R Shenoy [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 18:14:29 +0530 Subject: [PATCH 3/3] cpu-hotplug: Replace per-subsystem mutexes with get_online_cpus() This patch converts the known per-subsystem mutexes to get_online_cpus put_online_cpus. It also eliminates the CPU_LOCK_ACQUIRE

[RFC PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online_cpus()

2007-11-15 Thread Gautham R Shenoy
From: Gautham R Shenoy [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 18:14:29 +0530 Subject: [PATCH 2/3] cpu-hotplug: Replace lock_cpu_hotplug() with get_online_cpus() Replace all lock_cpu_hotplug/unlock_cpu_hotplug from the kernel and use get_online_cpus and put_online_cpus instead as it highlights

Re: OT: Does Linux have any Perfect Code

2007-11-15 Thread Michael Gerdau
This code is far to be perfect, some part is outdated, bcopy() use instead of memcpy() for example. More annoying are the comment, the file is 3306 lines while there is only 1640 line of code, nothing bad per se but looking some comments: /* * Before we begin

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Takashi Iwai
At Thu, 15 Nov 2007 14:17:27 +0100, Olivier Galibert wrote: On Thu, Nov 15, 2007 at 06:59:34AM +0100, Rene Herman wrote: Totally unrelated indeed so why are spouting crap? If the kohab list has a problem take it up with them but keep ALSA out of it. alsa-devel has only ever moderated

[RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation

2007-11-15 Thread Gautham R Shenoy
From: Gautham R Shenoy [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 18:14:20 +0530 Subject: [PATCH 1/3] cpu-hotplug: Refcount based Cpu Hotplug implementation This patch implements a Refcount + Waitqueue based model for cpu-hotplug. Now, a thread which wants to prevent cpu-hotplug, will bump up a

Re: [RFC PATCH 0/3] Refcount Based Cpu Hotplug V3

2007-11-15 Thread Ingo Molnar
* Gautham R Shenoy [EMAIL PROTECTED] wrote: Hi, This is Try #3 for the Refcount + Waitqueue based implementation for cpu-hotplug locking. The earlier versions can be found at http://lkml.org/lkml/2007/10/24/36 and http://lkml.org/lkml/2007/10/16/118. This version drops the patch 4

Re: [RFC PATCH 1/3] cpu-hotplug: Refcount Based Cpu Hotplug implementation

2007-11-15 Thread Ingo Molnar
* Gautham R Shenoy [EMAIL PROTECTED] wrote: void lock_cpu_hotplug(void) { - struct task_struct *tsk = current; - - if (tsk == recursive) { - static int warnings = 10; - if (warnings) { - printk(KERN_ERR Lukewarm IQ detected in hotplug

[RFC PATCH 0/3] Refcount Based Cpu Hotplug V3

2007-11-15 Thread Gautham R Shenoy
Hi, This is Try #3 for the Refcount + Waitqueue based implementation for cpu-hotplug locking. The earlier versions can be found at http://lkml.org/lkml/2007/10/24/36 and http://lkml.org/lkml/2007/10/16/118. This version drops the patch 4 from the earlier series, which was basically removing

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Thu, November 15, 2007 08:51, Christian Kujau wrote: Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and the same client). That should read: Since NFS was not working (the nfsd processes were already in D state), I

Re: [PATCH] Fix build failure when CONFIG_INFINIBAND_IPOIB_CM is not defined.

2007-11-15 Thread Mel Gorman
On (14/11/07 14:40), Tony Breeds didst pronounce: Fixes: CC [M] drivers/infiniband/ulp/ipoib/ipoib_main.o drivers/infiniband/ulp/ipoib/ipoib_main.c: In function ???ipoib_init_module???: drivers/infiniband/ulp/ipoib/ipoib_main.c:1269: error: invalid lvalue in assignment In the case

Re: statically allocated input_dev

2007-11-15 Thread Tomas Carnecky
CC: lkml, because that's a question anyone familiar with the driver subsystem can answer. Dmitry Torokhov wrote: On Nov 15, 2007 9:20 AM, Tomas Carnecky [EMAIL PROTECTED] wrote: Dmitry Torokhov wrote: No, sorry. Current object lifetime rules require input devices (as well as platform devices)

Re: [PATCH][RFC] kprobes: Add user entry-handler in kretprobes

2007-11-15 Thread Abhishek Sagar
On Nov 15, 2007 4:21 AM, Jim Keniston [EMAIL PROTECTED] wrote: 2. Simplify the task of correlating data (e.g., timestamps) between function entry and function return. Would adding of data and len fields in ri help? Instead of pouching data in one go at registration time, this would let user

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Jeff Dike
On Thu, Nov 15, 2007 at 01:44:46AM -0800, Andrew Morton wrote: Yes, all my test boxes did that - it's what I referred to in the releaee notes. Greg is pondering the problem - seem he's the only person who cannot reproduce it ;) UML does it reliably too, in case Greg is still looking for a way

Re: [alsa-devel] [BUG] New Kernel Bugs

2007-11-15 Thread Rene Herman
On 15-11-07 14:00, Jörn Engel wrote: And even without mails being held hostage for weeks, every single moderation mail is annoying. Like the one I'm sure to receive after sending this out. Certainly. Upto this thread I wasn't actually aware the list was doing that. While it might be

  1   2   3   4   5   6   7   8   9   >