Re: [PATCH] x86: kprobes change kprobe_handler flow

2007-12-30 Thread Masami Hiramatsu
Hello Harvey, Thank you for your great works! Harvey Harrison wrote: > Make the control flow of kprobe_handler more obvious. > > Collapse the separate if blocks/gotos with if/else blocks > this unifies the duplication of the check for a breakpoint > instruction race with another cpu. I agree it

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

2007-12-30 Thread Masami Hiramatsu
Hi, H. Peter Anvin wrote: >> Could you use a macro same as the stack_addr() macro, like as below? >> >> #defile is_REX_prefix(insn) ((insn & 0xf0) == 0x40)) >> >> This is just a bit checker, so I think a macro is better to do that. >> > > Why is a macro better than an inline, and why the odd mIXe

[PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

2007-12-30 Thread Sam Ravnborg
Combine the 32 and 64 bit specific Makefiles in one file. While doing so link order was (almost) preserved on 32 bit but on 64 bit link order changed a lot. Patch was checked with defconfig + allyesconfig builds. The same .o files were linked in these configurations. To keep readability of the Ma

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

2007-12-30 Thread Masami Hiramatsu
Masami Hiramatsu wrote: > (in case of CONFIG_X86_64) > static inline int is_rex_prefix(int op) Oops, s/int op/kprobe_opcode_t opcode/ > About the name, I just used the previous inline function name. I re-think "is_REX_prefix" is better, because it is an architecture dependent notation(intel's so

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Linus Torvalds
On Sun, 30 Dec 2007, Rene Herman wrote: > > This fixes "hwclock" triggered boottime hangs for a few HP/Compaq laptops > and might as such be applicable to 2.6.24 still. It's not a regression as far as I can see (ie we've always done that port 80 access for slow-down), and quite frankly, I thin

Idle loadavg of ~1, maybe MD related

2007-12-30 Thread Robin H. Johnson
0 minutes: http://dev.gentoo.org/~robbat2/20071230-g5-loadavg-bug.png Processed data for the graph here: http://dev.gentoo.org/~robbat2/20071230-g5-loadavg-bug.txt For the entire 230 minute period, there was _no_ disk I/O. Not recorded by iostat, nor generated. # while true ; do uptime ; iostat -t 60 2 -N

Re: [PATCH] include/asm-alpha/core_cia.h, kernel 2.6.23.12

2007-12-30 Thread Ivan Kokshaysky
On Sun, Dec 30, 2007 at 07:23:53AM +0100, Anders Hammarquist wrote: > Trying to compile 2.6.23.12 on alpha (a miata) resulted in this > failure: > > cc1: warnings being treated as errors > include/asm/io_trivial.h: In function 'cia_readb': > include/asm/io_trivial.h:75: warning: passing argument 1

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

2007-12-30 Thread Eduard-Gabriel Munteanu
On Sun, 30 Dec 2007 03:49:21 +0200 Islam Amer <[EMAIL PROTECTED]> wrote: > So what I understand now is that AMD C1E state saves battery like > dynticks, so we don't need dynticks ? No, it's not true. C1E currently saves more power than dynticks just because these platforms do not support higher

Re: [PATCH] x86: unify x86 Makefile(s)

2007-12-30 Thread Adrian Bunk
On Sun, Dec 30, 2007 at 03:00:51AM +0100, Andi Kleen wrote: > > > Without inlining the maxmimum stack usage inside foobar() is > > max(stack usage foo(), stack usage bar()). [1] > > It's a little more complicated. gcc 4.x (not sure which x, might 0) > is clever enough to not use max() stack, but

Re: [RFC] sleepy linux

2007-12-30 Thread Ingo Molnar
* Pavel Machek <[EMAIL PROTECTED]> wrote: > Todays hardware is mostly capable of doing better: with correctly set > up wakeups, machine can sleep and successfully pretend it is not > sleeping -- by waking up whenever something interesting happens. Of > course, it is easier on machines not conn

[PATCH] Get NUMLOCK from PC BIOS

2007-12-30 Thread Bodo Eggert
This patch enables reading the default NUMLOCK status from the BIOS data area as defined for IBM PCs (1981). Using this area has been a reliable way to detect (or set) the NUMLOCK status for about 27 years, and it will continue to work on any IBM-compatible system that might run DOS. Especially, t

Re: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0

2007-12-30 Thread Thomas Bogendoerfer
On Thu, Dec 20, 2007 at 01:27:20PM +, Mel Gorman wrote: > On (20/12/07 13:43), Thomas Bogendoerfer didst pronounce: > > On Thu, Dec 20, 2007 at 11:44:06AM +, Mel Gorman wrote: > > > --- a/include/asm-mips/page.h > > > +++ b/include/asm-mips/page.h > > > @@ -37,13 +37,6 @@ > > > #include >

Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

2007-12-30 Thread Peter Zijlstra
On Sat, 2007-12-29 at 22:42 -0800, David Brownell wrote: > On Saturday 29 December 2007, Alan Stern wrote: > > There's no way to remove these, which means there's > > no way to prevent lockdep from issuing a warning. > > There may be no *efficient* way to do that. If it tracked > every lock in

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Andi Kleen
> drivers that then are shown to really need it could use their *own* ports. The i8259 driver uses it and it is known to be needed on some old chipsets. But it doesn't really have any "own" ports to use afaik. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

2007-12-30 Thread Ingo Molnar
* Islam Amer <[EMAIL PROTECTED]> wrote: > Sorry, pressed send too soon. here is the line in dmesg: > > Compaq Presario v6000: using alternate I/O delay port > > Thanks, please tell me if you need anymore info. thanks Islam for testing this. I've added your DMI strings to x86.git, so v2.6.25 s

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > > This fixes "hwclock" triggered boottime hangs for a few HP/Compaq > > laptops and might as such be applicable to 2.6.24 still. > > It's not a regression as far as I can see (ie we've always done that > port 80 access for slow-down), and quite fra

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > > drivers that then are shown to really need it could use their *own* > > ports. > > The i8259 driver uses it and it is known to be needed on some old > chipsets. But it doesn't really have any "own" ports to use afaik. we'll solve that via an i8259-s

Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64

2007-12-30 Thread Rafael J. Wysocki
On Sunday, 30 of December 2007, Pavel Machek wrote: > Hi! > > > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Document the fact that __save_processor_state() has to save all CPU > > registers referred to by the kernel in case a different kernel is > > used to load and restore a hibernation

Re: 2.6.24-rc6-mm1

2007-12-30 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > > Ingo, it's not good that we have cond_resched() definitions > > conditionally duplicated in kernel.h - that's increasing the risk of > > bugs like this one. > > Actually, why do we even have cond_resched when real preemption is on? > It seems to be

Re: [PATCH]: 2.6.24-rc5: mtd: PNC-2000 oops

2007-12-30 Thread devzero
while doing some systematical driver load/unload testing i have also come across this one. searched lkml and found/tried this patch - seems to work fine, at least driver now behaves as expected: insmod: error inserting 'pnc2000.ko': -1 No such device or address if it really _works_ is another s

[00/06] typo and whitespace fixes

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
In some documentation and comments changed the destory typo to destroy and litle whitespace cleanups -- Thanks, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

[00/06] [typo fix] net/sctp/sm_statefuns.c

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 8f194e70a58d3455033a9788014619423857fba9 Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] net/sctp/sm_statefuns.c typo fix in net/sctp/sm_statefuns.c foo-destory -> foo-destroy Signed-off-by: Oliver P

[02/06] [typo fix] net/rfkill/rfkill.c

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 389af6f5ba7be9e79f8cbcc5929e602470d5fe29 Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] net/rfkill/rfkill.c typo fix in net/rfkill/rfkill.c foo-destory -> foo-destroy Signed-off-by: Oliver Pinter <[

[03/06] [typo fix] net/core/net_namespace.c

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 8558bc25d31a1d70879819f28f94485abc289b6b Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] net/core/net_namespace.c typo fix in net/core/net_namespace.c foo-destory -> foo-destroy Signed-off-by: Oliver

[04/06] [typo fix] drivers/infiniband/ulp/iser/iser_verbs.c

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 1621e01cc28c34c3f17169011bb2750d89f9ebb5 Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] drivers/infiniband/ulp/iser/iser_verbs.c typo fix in drivers/infiniband/ulp/iser/iser_verbs.c foo-destory -> foo-destro

[05/06] [typo fix] Documentation/scsi/ChangeLog.lpfc

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 135c0d1c711a4d423162d75a771d015f79b23cfd Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] Documentation/scsi/ChangeLog.lpfc typo fix in Documentation/scsi/ChangeLog.lpfc foo-destory -> foo-destroy && whitespac

[06/06] [typo fix] Documentation/filesystems/porting

2007-12-30 Thread Oliver Pinter (Pintér Olivér)
-- Thanks, Oliver commit 93d021f12d5370d06b1eee0659d83d1e7095df6c Author: Oliver Pinter <[EMAIL PROTECTED]> Commit: Oliver Pinter <[EMAIL PROTECTED]> [typo fix] Documentation/filesystems/porting typo fix in Documentation/filesystems/porting foo-destory -> foo-destroy && whitespac

[PATCH] x86: unify arch/x86/boot/compressed/Makefile(s)

2007-12-30 Thread Sam Ravnborg
Trivial unification of the two Makefiles. Tested doing a defconfig build for both 32 and 64 bit and no build changes occured. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: "H. Peter Anvin" <[EMAIL PROTECTED]> --- Made on top of the mm branch of the x86 tree, but expect it to apply cleanly t

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

2007-12-30 Thread Ingo Molnar
* Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > > Why is a macro better than an inline, and why the odd mIXed case? > > I thought we can use macro because it just check a bit mask. And if we > use this as a macro, it will be defined in #ifdef block at the top of > kprobes.c. It is simple in th

Re: [PATCH] x86: kprobes remove fix_riprel #ifdef

2007-12-30 Thread Ingo Molnar
* Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > Hello Harvey, > > A similar idea was already nack-ed by Ananth. > http://sources.redhat.com/ml/systemtap/2007-q4/msg00468.html > And I agree his thought. > > Especially, "riprel" does not exist on x86_32, so fix_riprel() > is meaningless on it. >

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > On Mon, 24 Dec 2007, Andi Kleen wrote: > > > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > > are more

[PATCH corrected] x86: unify arch/x86/boot/compressed/Makefile(s)

2007-12-30 Thread Sam Ravnborg
So trivial that I sent the wrong patch - sorry. The correct version is below. Sam Trivial unification of the two Makefiles. Tested doing a defconfig build for both 32 and 64 bit and no build changes occured. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: "H. Peter Anvin" <[EMAIL PRO

Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-30 Thread Adrian McMenamin
On Thu, 2007-12-27 at 14:58 -0800, Joe Perches wrote: > On Thu, 2007-12-27 at 16:52 +, Adrian McMenamin wrote: > > This patch adds support for the CD-Rom drive on the SEGA Dreamcast. > > Because it was already so close, might as well make it checkpatch clean. > > I also added a function gdro

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

2007-12-30 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > Fold some small ifdefs into a helper function. > > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> thanks, applied. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

[PATCH corrected again] x86: unify arch/x86/boot/compressed/Makefile(s)

2007-12-30 Thread Sam Ravnborg
Last patch contained some additional changes to lib/*. Lets see if I can do this correct in third attempt... Time for coffee to minimize further stupidity. >From c6caa6154d4d6d86305c732284abb3dedd4eca98 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Sun, 30 Dec 2007 14:40:00

Re: [PATCH] x86: Cosmetic fixes fault_{32|64}.c

2007-12-30 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > First step towards unifying these files. > - Checkpatch trailing whitespace fixes > - Checkpatch indentation of switch statement fixes > - Checkpatch single statement ifs need no braces fixes > - Checkpatch consistent spacing after comma fixes > - In

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-30 Thread Ingo Molnar
* H. Peter Anvin <[EMAIL PROTECTED]> wrote: >>> The right way to do it is: >>> >>> memset(&info.vm86plus, 0, sizeof info.vm86plus); >> >> If it's just one field _and_ we don't have padding we want to zero out - >> certainly... > > It is - [comments removed for clarity]: > > struct kernel_vm86

Re: [PATCH] x86: kprobes change kprobe_handler flow

2007-12-30 Thread Ingo Molnar
* Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > And also, I prefer "return 1" to "{ret = 1; goto out;}" for > simplicity. it seems that the code already uses 'ret', and sets it to 1 in certain cases - in that light it's a tiny bit cleaner to just have a single return code flow. Ingo

[PATCH 1/5] Char: mxser, remove special baudrate processing

2007-12-30 Thread Jiri Slaby
If you, Sergei, can test it, it would be great. [Note, that this is actually a patch for mxser_new after renaming.] -- Let it on the tty layer. Also remove set/get_special_rate ioctls introduced in commit f64c84a1668930d1ca2b7dbaa92146c2139cb508, since it is no longer needed. Signed-off-by: Jiri

[PATCH 2/5] Char: mxser, 0 to NULL in pointer

2007-12-30 Thread Jiri Slaby
Don't test a pointer against 0. Use NULL instead. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- drivers/char/mxser.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c index fe7944c..a66ae57 100644 --- a/drivers/char/mxser.c +

[PATCH 3/5] Char: mxser, reorder mxser_cardinfo fields

2007-12-30 Thread Jiri Slaby
Reorder fields to save some memory and code on 64bit due to alignment as suggested by Jan. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/char/mxser.c | 60 +- 1 files changed, 30 insertions(+), 30

[PATCH 5/5] Char: mxser, ioctl cleanup

2007-12-30 Thread Jiri Slaby
- remove dead MOXA_GET_CONF (always returned -ENXIO) - remove useless MOXA_GET_CUMAJOR (unused) - use get/put_user instead of copy_from/to_user for simple types - cleanup TIOCMIWAIT -- return -ERESTARTSYS on signal, move condition into separate function Signed-off-by: Jiri Slaby <[EMAIL PROTECTE

[PATCH 4/5] Char: mxser, simplify mxser_get_serial_info

2007-12-30 Thread Jiri Slaby
Initialize temp structure directly with proper values without first zeroing it and setting later as suggested by Jan. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/char/mxser.c | 27 --- 1 files changed, 12 insertions(+)

Re: 2.6.22-stable causes oomkiller to be invoked

2007-12-30 Thread Ingo Molnar
* Christoph Lameter <[EMAIL PROTECTED]> wrote: > Index: linux-2.6/arch/x86/mm/pgtable_32.c > === > --- linux-2.6.orig/arch/x86/mm/pgtable_32.c 2007-12-26 12:55:10.0 > -0800 > +++ linux-2.6/arch/x86/mm/pgtable_32.c2

Re: [PATCH]: 2.6.24-rc5: mtd: PNC-2000 oops

2007-12-30 Thread Josh Boyer
On Sun, 30 Dec 2007 14:15:13 +0100 [EMAIL PROTECTED] wrote: > while doing some systematical driver load/unload testing i have also come > across this one. > > searched lkml and found/tried this patch - seems to work fine, at least > driver now behaves as expected: > insmod: error inserting 'pnc

Re: [patch?] s2ram + P4 + tsc = annoyance

2007-12-30 Thread Ingo Molnar
* Mike Galbraith <[EMAIL PROTECTED]> wrote: > Or, reset to pristine prior to testing, though that's more lines to > accomplish the same thing. Either way, or some other way... > > If check_tsc_warp() is called after initial boot, and the TSC has in > the meantime been set (BIOS, user, silicon

[PATCH] x86: unify arch/x86/lib/Makefile(s)

2007-12-30 Thread Sam Ravnborg
Trivial unification of Makefiles for the x86 specific library part. Linking order is slightly modified but should be harmless. Tested doing a defconfig build before and after and saw no build changes. It adds almost as many lines as it deletes - bacause I broke a few lines up fo readability in th

Re: [patch?] s2ram + P4 + tsc = annoyance

2007-12-30 Thread Ingo Molnar
> ok, i prefer this fix a bit more. (we dont want to set last_tsc > outside of the sync_lock - which your initial patch does) i've added your patch to x86.git - thanks Mike! (patch below) I think this would be too dangerous for v2.6.24 though - we can put it back into -stable for 2.6.24.1, onc

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Rene Herman
On 30-12-07 10:30, Linus Torvalds wrote: On Sun, 30 Dec 2007, Rene Herman wrote: This fixes "hwclock" triggered boottime hangs for a few HP/Compaq laptops and might as such be applicable to 2.6.24 still. It's not a regression as far as I can see (ie we've always done that port 80 access fo

Re: [PATCH 05/10] x86_64: Use generic percpu

2007-12-30 Thread Ingo Molnar
* Mike Travis <[EMAIL PROTECTED]> wrote: > > Also for such changes .text size comparisons before/after are a good > > idea. > > x86_64-defconfig: > > pre-percpu post-percpu > 159373 .init.text +3 .init.text > 1411137 .rodata

Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64

2007-12-30 Thread Ingo Molnar
* Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > From: Rafael J. Wysocki <[EMAIL PROTECTED]> > > Document the fact that __save_processor_state() has to save all CPU > registers referred to by the kernel in case a different kernel is used > to load and restore a hibernation image containing it.

Re: [PATCH] x86: export 'leave_mm' symbol

2007-12-30 Thread Ingo Molnar
* Miguel Botón <[EMAIL PROTECTED]> wrote: > This patch fixes a linking error if CONFIG_ACPI_PROCESSOR=m (this > error occurs in the 'mm' branch of linux-2.6-x86.git). > > We need to export the 'leave_mm' symbol so it can be accessible for > the ACPI processor module. ok - i've added this as E

Re: [PATCH -mm] EFI : Split EFI tables parsing code from EFI runtime service support code

2007-12-30 Thread Ingo Molnar
* Huang, Ying <[EMAIL PROTECTED]> wrote: > +struct efi_tables efi_tables; > +EXPORT_SYMBOL(efi_tables); > +enum bios_type bios_type = BIOS_LEGACY; > +EXPORT_SYMBOL(bios_type); please make all the new exports EXPORT_SYMBOL_GPL(). Ingo -- To unsubscribe from this list: send the line "uns

Re: WARNING: at kernel/lockdep.c:2658 check_flags()

2007-12-30 Thread Ingo Molnar
* Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > softirqs last disabled at (3521): [] > > call_softirq+0x1c/0x30 > > more early fixups for notify_die().. thanks - i've picked this up into sched.git, for more testing. Ingo -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)

2007-12-30 Thread Andi Kleen
Eduard-Gabriel Munteanu <[EMAIL PROTECTED]> writes: > > Other kernel developers, as discussed previously in this thread, are > working on a HPET-driven dynticks (as opposed to the current > LAPIC-driven one), but the change isn't that easy to make. No, actually HPET based dyntick has been implemen

Re: [PATCH] forcedeth: seperate handler for msix and normal int.

2007-12-30 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > [PATCH] forcedeth: seperate handler for msix and normal int. > > so we don't need to keep checking np->msi_flags to see if > NV_MSI_X_ENABLED is set in handler hm, why is this patch needed and what's the effect of this patch? i'm also wondering, what

Re: [PATCH 0/5] x86 makefile unification and cleaning

2007-12-30 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > Patches follows. > > And they all list my mail address as "[EMAIL PROTECTED]". > Ingo - can I ask you to manually fix it up or do you want a resend? sure - fixed it up. I've picked up the first 4 patches of yours into x86.git and folded the 5t

Re: [PATCH] x86: kprobes remove fix_riprel #ifdef

2007-12-30 Thread Masami Hiramatsu
Hello Ingo, Ingo Molnar wrote: > * Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > >> Hello Harvey, >> >> A similar idea was already nack-ed by Ananth. >> http://sources.redhat.com/ml/systemtap/2007-q4/msg00468.html >> And I agree his thought. >> >> Especially, "riprel" does not exist on x86_32, so

Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2

2007-12-30 Thread Ingo Molnar
* Yinghai Lu <[EMAIL PROTECTED]> wrote: > please check if you can replace the one in the x86-mm > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76 > > the updated one avoid one link warning. please send delta patches inst

Re: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

2007-12-30 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > Combine the 32 and 64 bit specific Makefiles in one file. While doing > so link order was (almost) preserved on 32 bit but on 64 bit link > order changed a lot. > > Patch was checked with defconfig + allyesconfig builds. The same .o > files were lin

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Julia Lawall
On Sun, 30 Dec 2007, Ingo Molnar wrote: > > * Julia Lawall <[EMAIL PROTECTED]> wrote: > > > On Mon, 24 Dec 2007, Andi Kleen wrote: > > > > > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > > > > > The functions time_before, t

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Alan Cox
> slowdown entirely (obviously that is not for 2.6.24 either, though!), and > drivers that then are shown to really need it could use their *own* ports. *No* - that is the one thing they cannot do. The _p cycles on ISA for 2MHz parts on a standard ISA bus needs the delay to come off another devic

Re: [BUG] 2.6.21-rc1,2,3 regressions on my system that I found so far

2007-12-30 Thread Ingo Molnar
* Mike Galbraith <[EMAIL PROTECTED]> wrote: > > Is this after resume ? If yes, then something (probably BIOS) is > > fiddling with the TSC of one CPU when the resume happens. > > My P4 box has the same "problem", which is remedied by.. > - start = get_cycles_sync(); > + start = last_ts

Re: [PATCH] x86: unify arch/x86/lib/Makefile(s)

2007-12-30 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > Trivial unification of Makefiles for the > x86 specific library part. thanks, applied to x86.git. > Linking order is slightly modified but should be harmless. the link order in this code is indeed expected to be harmless. (unlike the Makefile_64 lin

Re: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

2007-12-30 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Combine the 32 and 64 bit specific Makefiles in one file. While > > doing so link order was (almost) preserved on 32 bit but on 64 bit > > link order changed a lot. > > > > Patch was checked with defconfig + allyesconfig builds. The same .o > > fil

Re: [PATCH corrected again] x86: unify arch/x86/boot/compressed/Makefile(s)

2007-12-30 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > Last patch contained some additional changes to lib/*. > Lets see if I can do this correct in third attempt... > Time for coffee to minimize further stupidity. thanks, applied to x86.git. Ingo -- To unsubscribe from this list: send the line "u

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Alan Cox <[EMAIL PROTECTED]> wrote: > For modern systems we should just use tsc delays, but we have to fix > all the drivers first as right now 0x80 causes posting and we have > some PCI users (I think probably all bogus), and we need to fix the > tons of locking errors that are mostly cover

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > comparisons and they all seem to be correct. So picked those three > > up into x86.git - let me know if there's any breakage in them that i > > missed. > > Only #7 is ok. The other tw

Re: [PATCH] x86: kprobes remove fix_riprel #ifdef

2007-12-30 Thread Ingo Molnar
* Masami Hiramatsu <[EMAIL PROTECTED]> wrote: > Indeed. > By the way, flush_cache_page() is defined as a do-while(0) on x86. > Would it better to define fix_riprel() as a do-while(0) on x86-32? > I think this obviously indicates that function has no effect. NOPs should always be an inline. flush

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Alan Cox
> i dont get your last point. Firstly, we do an "outb $0x80" not an inb. outb not inb sorry yes > Secondly, outb $0x80 has no PCI posting side-effects AFAICS. Thirdly, It does. The last mmio write cycle to the bridge gets pushed out before the 0x80 cycle goes to the PCI bridge, times out and g

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Rene Herman
On 30-12-07 16:28, Ingo Molnar wrote: Reading from the 0x3cc port does not impact the cursor position update sequence IIRC - i think the vidport is even ignored for the input direction by most hardware, there's a separate input register. The 0x3cc port is a well-defined VGA register which shou

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Julia Lawall
On Sun, 30 Dec 2007, Ingo Molnar wrote: > > * Julia Lawall <[EMAIL PROTECTED]> wrote: > > > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > > comparisons and they all seem to be correct. So picked those three > > > up into x86.git - let me know if there's any breakage in them

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Alan Cox <[EMAIL PROTECTED]> wrote: > > i dont get your last point. Firstly, we do an "outb $0x80" not an > > inb. > > outb not inb sorry yes > > > Secondly, outb $0x80 has no PCI posting side-effects AFAICS. > > Thirdly, > > It does. The last mmio write cycle to the bridge gets pushed out

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > > hm, #include file order in a .c file should normally not matter - > > why are they in the wrong place? > > Because they are under #ifdefs, but the code that uses the time > functions is not under the same #ifdef. ah, ok - you are right. I fixed th

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Andi Kleen
On Sun, Dec 30, 2007 at 02:05:44PM +0100, Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > drivers that then are shown to really need it could use their *own* > > > ports. > > > > The i8259 driver uses it and it is known to be needed on some old > > chipsets. But it doesn

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Rene Herman <[EMAIL PROTECTED]> wrote: > On 30-12-07 16:28, Ingo Molnar wrote: > >> Reading from the 0x3cc port does not impact the cursor position update >> sequence IIRC - i think the vidport is even ignored for the input >> direction by most hardware, there's a separate input register. The

Re: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

2007-12-30 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > i've added your full patch meanwhile - maybe we can get away with it. i needed the trivial fix below. You did not test-build it on 32-bit it appears :-) Ingo --- arch/x86/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Ind

[usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-30 Thread Ingo Molnar
* Andreas Mohr <[EMAIL PROTECTED]> wrote: > (yes, that's all there is, despite CONFIG_USB_DEBUG being set) > > The LED of a usb stick isn't active either, for obvious reasons. > > And keep in mind that this is a (relatively old) OHCI-only machine... > (which had the 2.6.19 lsmod showing ohci-h

Re: [PATCH] Exporting capability code/name pairs

2007-12-30 Thread Andrew Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 KaiGai Kohei wrote: > Remaining issues: > - We have to mount securityfs explicitly, or use /etc/fstab. > It can cause a matter when we want to use this feature on > very early phase on boot. (like /sbin/init) I'm not altogether clear how you inten

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Rene Herman
On 30-12-07 17:07, Ingo Molnar wrote: * Rene Herman <[EMAIL PROTECTED]> wrote: On 30-12-07 16:28, Ingo Molnar wrote: hardware. (which makes it a perfect delay register in any case) Hardly. Duron 1300 on AMD756: but that does not matter at all: that's not '90s era hardware that we are (

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > > > The i8259 driver uses it and it is known to be needed on some old > > > chipsets. But it doesn't really have any "own" ports to use afaik. > > > > we'll solve that via an i8259-specific quirk. That is a lot cleaner > > and maintainable than the cur

[git pull] scheduler updates

2007-12-30 Thread Ingo Molnar
Linus, please pull the latest scheduler git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git Warning fix for sparc64 - no code changed. Thanks! Ingo --> Ingo Molnar (1): sched: fix gcc warnings sched_debug.c |8

Re: [RFC] sleepy linux

2007-12-30 Thread Oliver Neukum
Am Sonntag, 30. Dezember 2007 00:51:34 schrieb Pavel Machek: > Hi! > > > > ... I also don't need to call any suspend() routines, because all the > > > drivers are already suspended, right? > > > > Well, you have a number of devices which cannot do runtime pm. > > They can do suspend/resume with t

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Alan Cox
> ok. Is it more of a "gets flushed due to timing out", or a > specified-for-sure POST flushing property of all out 0x80 cycles going > to the PCI bridge? I thought PCI posting policy is up to the CPU, it can > delay PCI space writes arbitrarily (within reasonable timeouts) as long > as no read

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Rene Herman <[EMAIL PROTECTED]> wrote: >>> Hardly. Duron 1300 on AMD756: >> >> but that does not matter at all: that's not '90s era hardware that we >> are (slightly) worried about wrt. IO delays in misc_32.c. (i.e. on >> _real_ ISA systems) > > Real ISA systems will also generally respond fa

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Juergen Beisert
On Sunday 30 December 2007 16:38, Alan Cox wrote: > > do you have any memories about the outb_p() use of misc_32.c: > > > > pos = (x + cols * y) * 2; /* Update cursor position */ > > outb_p(14, vidport); > > outb_p(0xff & (pos >> 9), vidport+1); > > outb_p(15,

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Alan Cox <[EMAIL PROTECTED]> wrote: > > ah, i understand. So i guess a stupid udelay_serialized() which > > takes a global spinlock would solve these sort of races? But i guess > > making them more likely to trigger would lead to a better kernel in > > the end ... > > Better to just fix the

Re: [x86] is checkpatch.pl broken

2007-12-30 Thread Ingo Molnar
* Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > orig: > mbr_base = (buf_base+sector_size-1) & ~(sector_size-1); > new (could be): > mbr_base = (buf_base + sector_size - 1) & ~(sector_size - 1); > > Is a new version that bad? it's certainly acceptable as newly introduced code but only borderline

Re: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

2007-12-30 Thread Bartlomiej Zolnierkiewicz
On Saturday 29 December 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > * Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap. > > > * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers. > > > * Convert ide-tape device driver to check for IDE_H

[PATCH 1/3] au1xxx-ide: device tree bugfix

2007-12-30 Thread Bartlomiej Zolnierkiewicz
Add missing hw.dev setup (so hwif->gendev.parent will be set by ide_init_port_hw() to point to the parent device). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/mips/au1xxx-ide.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/mips/au1xxx-ide.c =

Re: [PATCH 1/9] piix: remove stale comments

2007-12-30 Thread Bartlomiej Zolnierkiewicz
On Friday 28 December 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > > Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> > > > Index: b/drivers/ide/pci/piix.c > > ==

[PATCH 2/3] ide-pmac: macio resource freeing bugfix

2007-12-30 Thread Bartlomiej Zolnierkiewicz
Release DMA resource before zeroing pmif. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ppc/pmac.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ppc/pmac.c ===

[PATCH 3/3] au1xxx-ide/rapide: use hwif->index for ide_unregister()

2007-12-30 Thread Bartlomiej Zolnierkiewicz
Cc: Russell King <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/arm/rapide.c |4 ++-- drivers/ide/mips/au1xxx-ide.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/arm/rapide.c ===

Re: [PATCH] x86: Introduce REX prefix helper for kprobes

2007-12-30 Thread Harvey Harrison
On Sat, 2007-12-29 at 23:04 -0800, H. Peter Anvin wrote: > Masami Hiramatsu wrote: > > Hi Harvey, > > > > Harvey Harrison wrote: > >> Fold some small ifdefs into a helper function. > >> > >> Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > >> --- > >> Masami, Ingo, I had this left in some unse

Re: [patch?] s2ram + P4 + tsc = annoyance

2007-12-30 Thread Mike Galbraith
On Sun, 2007-12-30 at 15:08 +0100, Ingo Molnar wrote: > > ok, i prefer this fix a bit more. (we dont want to set last_tsc > > outside of the sync_lock - which your initial patch does) > > i've added your patch to x86.git - thanks Mike! (patch below) I think > this would be too dangerous for v2.

Re: [2.6 patch] make I/O schedulers non-modular

2007-12-30 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/27/2007 11:15 PM: > Adrian Bunk wrote, On 11/27/2007 05:47 PM: ... >> There is nothing like a "right of choice". (very late) PS: ...I was a bit confused with this, wondering: so, we've envied you (the West) this "thing" for so many years, and now it seems, you ha

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Bodo Eggert
Ingo Molnar <[EMAIL PROTECTED]> wrote: > do you have any memories about the outb_p() use of misc_32.c: > > pos = (x + cols * y) * 2; /* Update cursor position */ > outb_p(14, vidport); > outb_p(0xff & (pos >> 9), vidport+1); > outb_p(15, vidport); > o

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Rene Herman
On 30-12-07 18:06, Ingo Molnar wrote: * Rene Herman <[EMAIL PROTECTED]> wrote: Real ISA systems will also generally respond faster to it than the unused port (this thing actually has an ISA bus but not VGA on it ofcourse) which means that "a perfect delay register" it is not. But yes, I hav

Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override

2007-12-30 Thread Ingo Molnar
* Bodo Eggert <[EMAIL PROTECTED]> wrote: > BTW: The error function in > linux-2.6.23/arch/i386/boot/compressed/misc.c uses while(1) without > cpu_relax() in order to halt the machine. Is this fixed? Should it be > fixed? this is early bootup so there's no need to be "nice" to other cores or

Re: SATA buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2007-12-30 Thread Robert Hancock
Linda Walsh wrote: I needed to get a new hard disk for one of my systems and thought that it was about time to start going with SATA. I picked up a Promise 4-Port Sata300-TX4 to go with a 750G Seagate SATA -- I'd had good luck with a Promise ATA100 (P)ATA and lower capacity Seagates and thought

  1   2   3   >