[PATCH resend] drivers/video/aty/radeon_base.c: compilation warning fix

2008-02-17 Thread Leonardo Potenza
From: Leonardo Potenza <[EMAIL PROTECTED]> Add a check for the sysfs_create_bin_file() return value. In case of error the framebuffer creation is not aborted, but a warning message is generated instead. Signed-off-by: Leonardo Potenza <[EMAIL PROTECTED]> --- The aim of this patch is to remove t

Re: [RFC] [PATCH] x86: Use ELF section to list CPU vendor specific code (Linux Tiny)

2008-02-17 Thread Ingo Molnar
* Thomas Petazzoni <[EMAIL PROTECTED]> wrote: > Le Mon, 11 Feb 2008 16:54:30 -0800, > "H. Peter Anvin" <[EMAIL PROTECTED]> a écrit : > > > b) would be my first choice, and yes, it would be a good thing to > > have a generalized mechanism for this. For the registrant, it's > > pretty easy: just

Re: [PATCH] Add PCI_DEVICE_TABLE macro

2008-02-17 Thread Randy Dunlap
On Sun, 17 Feb 2008 13:10:05 +0100 Jonas Bonn wrote: > The definitions of struct pci_device_id arrays should generally follow > the same pattern across the entire kernel. This macro defines this > array as static const and puts it into the __devinitconst section. > > Signed-off-by: Jonas Bonn <[

[PATCH 1/7] fs/affs/file.c: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @ disab

Re: 2.6.25-rc2-mm1 (build failure)

2008-02-17 Thread Randy Dunlap
Rafael J. Wysocki wrote: On Sunday, 17 of February 2008, Randy Dunlap wrote: On Sat, 16 Feb 2008 00:25:22 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ When SMP=n, x86_64 build gets: arch/x86/kernel/built-in.o: In function

Re: [PATCH] linux/hdsmart.h: fix goofups

2008-02-17 Thread Robert P. J. Day
On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wrote: > On Sunday 17 February 2008, Adrian Bunk wrote: > > On Sun, Feb 17, 2008 at 06:40:31PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > On Sunday 17 February 2008, Robert P. J. Day wrote: > > > > On Sun, 17 Feb 2008, Bartlomiej Zolnierkiewicz wro

[PATCH] firewire: fw-sbp2: fix NULL pointer deref in scsi_remove_device

2008-02-17 Thread Stefan Richter
I wrote: > There is unfortunately another bug. If the user manually removes the > scsi_device by writing into its "delete" sysfs attribute, the following > will happen when the SBP-2 device is plugged out: > > BUG: unable to handle kernel NULL pointer dereference at 00b8 > IP: [] mute

[PATCH 3/7] fs/ocfs2: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @ disab

[PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. fs/ext2/balloc.c |3 +-- fs/ext2/dir.c|3 +-- fs/ext3/balloc.c |3 +-- fs/ext4/balloc.c |

[PATCH 4/7] fs/udf/truncate.c: Use BUG_ON

2008-02-17 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @ disab

Re: [PATCH] x86 cleanup: suspend_asm_64.S - use X86_CR4_PGE instead of numeric value

2008-02-17 Thread Ingo Molnar
* Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: > By including we're allowed to use X86_CR4_PGE > instead of numeric constant. > > md5 sums of compiled files are differ due to this inclusion but .text > section remains the same. thanks Cyrill, picked it up. (the merged version is below - the ta

Re: [PATCH 2/2] x86: coding style fixes arch/x86/lib/csum-wrappers_64.c

2008-02-17 Thread Paolo Ciarrocchi
On 2/17/08, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: > > > [PATCH 2/2] x86: coding style fixes arch/x86/lib/csum-wrappers_64.c > > > > On top of the previous patch makes the file errors free according to > > checkpatch.pl > > thanks Paolo, applied. (i

[PATCH 1/5] ide: remove PIO "downgrade" quirk

2008-02-17 Thread Bartlomiej Zolnierkiewicz
No need for it nowadays so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-lib.c | 10 -- drivers/ide/pci/amd74xx.c |1 - drivers/ide/pci/via82cxxx.c |1

Re: [PATCH] x86 cleanup: suspend_asm_64.S - use X86_CR4_PGE instead of numeric value

2008-02-17 Thread Cyrill Gorcunov
[Ingo Molnar - Sun, Feb 17, 2008 at 07:17:16PM +0100] | | * Cyrill Gorcunov <[EMAIL PROTECTED]> wrote: | | > By including we're allowed to use X86_CR4_PGE | > instead of numeric constant. | > | > md5 sums of compiled files are differ due to this inclusion but .text | > section remains the sam

Re: What's needed for a PCIe card to be recognized?

2008-02-17 Thread Hans J. Koch
Am Sun, 17 Feb 2008 07:29:27 -0800 schrieb Arjan van de Ven <[EMAIL PROTECTED]>: > On Sun, 17 Feb 2008 13:37:53 +0100 > "Hans J. Koch" <[EMAIL PROTECTED]> wrote: > > > Of course there's no driver for the wlan, but that's a different > > > story ;) > > > > I replaced that unsupported Atheros 5007

[PATCH 3/5] ide: use ide_find_port() in legacy VLB host drivers

2008-02-17 Thread Bartlomiej Zolnierkiewicz
* Add IDE_HFLAG_QD_2ND_PORT host flag to indicate the need of skipping first ide_hwifs[] slot for the second port of QD65xx controller. * Handle this new host flag in ide_find_port_slot(). * Convert legacy VLB host drivers to use ide_find_port(). While at it: * Fix couple of printk()-s in qd6

[PATCH 2/5] ide: merge ide_match_hwif() and ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
* Change ide_match_hwif() argument from 'u8 bootable' to 'struct ide_port_info *d'. * Move ide_match_hwif() to ide-probe.c from setup-pci.c and rename it to ide_find_port_slot(). Update some comments while at it. * ide_find_port() can be now just a wrapper for ide_find_port_slot(). There sh

[PATCH 4/5] ide-generic: use ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-generic.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-generic.c ===

[PATCH 5/5] ide: unexport ide_hwifs[]

2008-02-17 Thread Bartlomiej Zolnierkiewicz
All modular users have been fixed to not reference ide_hwifs[] directly. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/ide/ide.c ===

Re: [REGRESSION 2.6.23] no vga console and no messages

2008-02-17 Thread Daniel Barkalow
As far as I can tell, the only differences in either dmesg or lspci between the broken one and the working one are the phrasing of messages, not what's happening. Out of curiousity, what do you see for the "Console: " line when you boot? It's possible that the VGA console code somehow got broke

Re: [PATCH 0/2] x86 - Move laptop drivers out of x86 Kconfig

2008-02-17 Thread Ingo Molnar
* Carlos Corbacho <[EMAIL PROTECTED]> wrote: > The following patch series moves the two laptop drivers from x86 > Kconfig (i8k and toshiba) to drivers/char, which is where the source > for them lives anyway. > > Given they are not x86 processor features, the x86 Kconfig menu is not > really a

Re: [PATCH 0/2] x86 - Move laptop drivers out of x86 Kconfig

2008-02-17 Thread Ingo Molnar
* Carlos Corbacho <[EMAIL PROTECTED]> wrote: > On Sunday 17 February 2008 18:20:08 Ingo Molnar wrote: > > i suspect this should be merged by the char driver tree which is > > affected by the addition of these new entries. > > Where is such a tree, and who's responsible for it though? I grep'ed

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Cyrill Gorcunov
[Sam Ravnborg - Sun, Feb 17, 2008 at 07:59:36PM +0100] | On Sun, Feb 17, 2008 at 06:17:18PM +0300, Cyrill Gorcunov wrote: | > Though we use PDA for regular task stack but that | > is not acceptable for init_task wich is special | > one. We still have to allocate init_task's stack | > in that manner

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Sun, Feb 17, 2008 at 06:17:18PM +0300, Cyrill Gorcunov wrote: > > Though we use PDA for regular task stack but that > > is not acceptable for init_task wich is special > > one. We still have to allocate init_task's stack > > in that manner. > > hpa

Re: [patch 1/2] x86: lds - Use PAGE_SIZE instead of numeric constant

2008-02-17 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Sun, Feb 17, 2008 at 06:17:17PM +0300, Cyrill Gorcunov wrote: > > It's much better to use PAGE_SIZE then magic 4096 > > (though it's almost synonym in most cases on x86 but > > not for *all* cases ;) > > Thanks Cyrill. > > > > > Signed-off-by: Cyr

Re: arch/x86/mm/ioremap unification grew by 10x

2008-02-17 Thread Ian Campbell
On Fri, 2008-02-15 at 17:17 -0600, Matt Mackall wrote: > On Fri, 2008-02-15 at 15:21 -0600, Matt Mackall wrote: > > On Fri, 2008-02-15 at 21:32 +0100, Sam Ravnborg wrote: > > > On Fri, Feb 15, 2008 at 02:25:54PM -0600, Matt Mackall wrote: > > > > In 2.6.24 defconfig, my build stats show ioremap_32

Re: linux-next: first tree

2008-02-17 Thread Mark M. Hoffman
Hi Stephen: * Stephen Rothwell <[EMAIL PROTECTED]> [2008-02-15 00:35:37 +1100]: > I have created the first cut of the linux-next tree at > git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git. > > Things to know about this tree: > > It has two branches - master and stable. Stable is

Re: 2.6.25-rc1 xen pvops regression

2008-02-17 Thread Ian Campbell
On Fri, 2008-02-15 at 12:23 -0800, Joel Becker wrote: > On Thu, Feb 14, 2008 at 06:50:52PM +1100, Jeremy Fitzhardinge wrote: > >>I'm seeing the same problem, with no messages at all from xen > >> other than "domain crashed, restart disabled" in xend.log. I got a > >> different commit in my bi

Re: PCI Bursting with PIO

2008-02-17 Thread Robert Hancock
Dan Gora wrote: On Feb 15, 2008 10:00 PM, Robert Hancock <[EMAIL PROTECTED]> wrote: Well, in order for the CPU to batch up more writes you'd have to map the BAR as either write-combining or write-back. If it's not listed in /proc/mtrr it will be the default setting of uncacheable. Ok, this i

Re: [PATCH 0/2] x86 - Move laptop drivers out of x86 Kconfig

2008-02-17 Thread Carlos Corbacho
On Sunday 17 February 2008 18:20:08 Ingo Molnar wrote: > i suspect this should be merged by the char driver tree which is > affected by the addition of these new entries. Where is such a tree, and who's responsible for it though? I grep'ed MAINTAINERS and didn't turn up anyone. -Carlos -- E-Mai

Re: [patch 1/2] x86: lds - Use PAGE_SIZE instead of numeric constant

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 06:17:17PM +0300, Cyrill Gorcunov wrote: > It's much better to use PAGE_SIZE then magic 4096 > (though it's almost synonym in most cases on x86 but > not for *all* cases ;) Thanks Cyrill. > > Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> Acked-by: Sam Ravnborg <[EMAI

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 06:17:18PM +0300, Cyrill Gorcunov wrote: > Though we use PDA for regular task stack but that > is not acceptable for init_task wich is special > one. We still have to allocate init_task's stack > in that manner. hpa had some comments about this particular alignment. If we k

Re: arch/x86/mm/ioremap unification grew by 10x

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 07:09:42PM +, Ian Campbell wrote: > > On Fri, 2008-02-15 at 17:17 -0600, Matt Mackall wrote: > > On Fri, 2008-02-15 at 15:21 -0600, Matt Mackall wrote: > > > On Fri, 2008-02-15 at 21:32 +0100, Sam Ravnborg wrote: > > > > On Fri, Feb 15, 2008 at 02:25:54PM -0600, Matt Ma

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-17 Thread Jens Axboe
On Sat, Feb 16 2008, Kamalesh Babulal wrote: > Hi, > > The softlockup is seen from 2.6.25-rc1-git{1,3} and is visible in the > 2.6.24-rc2 kernel, > While booting up with the 2.6.25-rc1-git{1,3} and 2.6.25-rc2 kernel(s) on the > powerbox > > Loading st.ko module > BUG: soft lockup - CPU#1 stuck

Re: [PATCH 4/7] fs/udf/truncate.c: Use BUG_ON

2008-02-17 Thread Marcin Slusarz
On Sun, Feb 17, 2008 at 06:56:18PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. The same change is in my patch which i

Re: [PATCH] modpost: Fix reversed symbol name order

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 02:12:10PM +0100, Geert Uytterhoeven wrote: > XXXINIT_TO_INIT and XXXEXIT_TO_EXIT warnings use the reversed symbol name > order > in the suggestion, e.g.: > > WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference > from the function free_area_init_cor

Re: 2.6.25-rc2 vdso_install breaks user "make install"

2008-02-17 Thread Sam Ravnborg
On Sat, Feb 16, 2008 at 12:36:10PM +0100, Sam Ravnborg wrote: > On Fri, Feb 15, 2008 at 07:42:11PM -0800, Roland McGrath wrote: > > Perhaps it makes more sense to have vdso_install be a dependency of > > modules_install rather than install, since they both put things in > > /lib/modules. > > The i

[PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-17 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-disk.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/

[PATCH 3/4] ide-disk: add proc_idedisk_read_smart() helper

2008-02-17 Thread Bartlomiej Zolnierkiewicz
* Factor out common code from proc_idedisk_read_smart_{thresholds,values}() to proc_idedisk_read_smart() helper. * Rename proc_idedisk_read_smart_thresholds() to proc_idedisk_read_st() and proc_idedisk_read_smart_values() to proc_idedisk_read_sv(). There should be no functional changes caused

Re: 2.6.25-rc2, Problem running 'make install' as root with different gcc

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 05:36:37PM +0200, Avi Kivity wrote: > Trying to install a built 2.5.25-rc2 on a machine with a different gcc > installed fails with > > LDS arch/x86/vdso/vdso.lds > cc1: fatal error: opening output file arch/x86/vdso/vdso.lds: Permission > denied > compilation termin

[PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There are no changes to the resulting drivers/ide/ide-disk.o binary file (md5sum-s after and before the patch match). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-disk.c | 120 - 1 file changed, 70 insertions(+),

Re: Current git very broken on the Dreamcast

2008-02-17 Thread Kristoffer Ericson
On Sat, 16 Feb 2008 18:38:00 + Adrian McMenamin <[EMAIL PROTECTED]> wrote: > Will seek to bisect this, but I have just updated my sources to the > latest git and it is not booting at all on the Dreamcast. > > With early printk on, I get nothing more than this before an instant > reboot: I ha

Re: Current git very broken on the Dreamcast

2008-02-17 Thread Kristoffer Ericson
On Sat, 16 Feb 2008 19:59:48 + Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-16 at 19:48 +, Adrian McMenamin wrote: > > On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > > > Will seek to bisect this, but I have just updated my sources to the > > > latest git a

Re: [PATCH] mm: setup_usemap() must be __meminit

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 01:31:14PM +0100, Geert Uytterhoeven wrote: > On Sun, 17 Feb 2008, Geert Uytterhoeven wrote: > > On m68k (CONFIG_SPARSEMEM is not set), I get: > > > > WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference > > from the function free_area_init_core() to

kernel BUG at mm/rmap.c:631!

2008-02-17 Thread Ignacy Gawedzki
Hi, I was printing on the parallel port and suddenly the "parallel" CUPS backend went 50% CPU (obviously endless-looping), while the other 50% were eaten by ghostscript (strace didn't show anything, so this might be an "internal" loop). When I eventually killed the latter, I got this: Eeek! page

Re: Geode GX/LX watchdog timer (RESEND)

2008-02-17 Thread Arnd Hannemann
Iain Paton schrieb: > Adrian Bunk wrote: >> On Sun, Feb 17, 2008 at 03:46:01PM +0100, Arnd Hannemann wrote: >>> Never tried to built it as a module. >>> Probably there are issues with that. If I remember correctly I saw a >>> patch in 2.6.25-rc which >>> mentioned that using mfgpt in modules won't

Re: [RFC] [PATCH] x86: Use ELF section to list CPU vendor specific code (Linux Tiny)

2008-02-17 Thread H. Peter Anvin
Ingo Molnar wrote: * Thomas Petazzoni <[EMAIL PROTECTED]> wrote: Le Mon, 11 Feb 2008 16:54:30 -0800, "H. Peter Anvin" <[EMAIL PROTECTED]> a écrit : b) would be my first choice, and yes, it would be a good thing to have a generalized mechanism for this. For the registrant, it's pretty easy: j

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread H. Peter Anvin
Cyrill Gorcunov wrote: Yes Sam, I've read Peter and Ingo comments on this patch (actually I sent the same patch maybe week ago and Peter and Ingo told me that we use %fs,%gs now for stack) but as I pointed in comment - this alignment is still using by Xen and lguest and even x86. So - it would b

Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-17 Thread Sam Ravnborg
Hi Karsten et al. Seeing the work Jeff puts into ISDN I was wondering what are the state of mISDN. Will we soon see mISDN hit the tree or has development stalled? I was wondering if Jeff should go for the much simpler patch: diff --git a/drivers/isdn/Kconfig b/drivers/isdn/Kconfig index 66f946a.

Re: 2.6.25-rc2-mm1 (build failure)

2008-02-17 Thread Pavel Machek
Hi! > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ > > > > When SMP=n, x86_64 build gets: > > > > arch/x86/kernel/built-in.o: In function `acpi_save_state_mem': > > (.text+0xfd7f): undefined reference to `setup_trampoline' > > make[1]: *** [.tmp_vm

Re: 2.6.25-rc2 vdso_install breaks user "make install"

2008-02-17 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > Roland - if you agree will you please submit the patch > to the x86 people. > You can tag it: > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > or Acked-by: Sam Ravnborg <[EMAIL PROTECTED]> i've picked it up, thanks. Ingo -- To unsubscribe f

getting uninterruptible sleep processes after upgrade from 2.6.20.20 to 2.6.24.2

2008-02-17 Thread allied internet ag- Stefan Priebe
Hello! One week ago we upgraded about 300 servers from 2.6.20.20 to 2.6.24.2. Now we get sometimes dozent of processes in state DN. The system is completely idle - but the load is 20 or 90 or whatever. And it can only be "repaired" by rebooting the system. I'm NOT on the LIST so please CC me

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Cyrill Gorcunov
[H. Peter Anvin - Sun, Feb 17, 2008 at 11:48:58AM -0800] > Cyrill Gorcunov wrote: >> Yes Sam, I've read Peter and Ingo comments on this patch >> (actually I sent the same patch maybe week ago and Peter >> and Ingo told me that we use %fs,%gs now for stack) but >> as I pointed in comment - this alig

Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc

2008-02-17 Thread Rafael J. Wysocki
On Saturday, 16 of February 2008, Kamalesh Babulal wrote: > Hi, Hi, > The softlockup is seen from 2.6.25-rc1-git{1,3} and is visible in the > 2.6.24-rc2 kernel, > While booting up with the 2.6.25-rc1-git{1,3} and 2.6.25-rc2 kernel(s) on the > powerbox Can you update the Bugzilla entry at: htt

cobalt_btns.c <-> struct platform_device compile error

2008-02-17 Thread Adrian Bunk
Commit b037b08e59633d939d79f1df9c43c6625f8db904 broke the compilation of cobalt_btns.c: <-- snip --> ... CC drivers/input/misc/cobalt_btns.o ... /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/misc/cobalt_btns.c: In function 'cobalt_buttons_probe': /home/bunk/linux/kernel-2.6/g

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Adrian Bunk
On Sun, Feb 17, 2008 at 08:24:56PM +0100, Tilman Schmidt wrote: > Am 17.02.2008 14:16 schrieb Adrian Bunk: >> The real problem is that the kernel seems to lack functionality you >> require for doing some work. >> >> Why does your work on the Debian Installer depend on VirtualBox and >> can't be d

Re: kernel BUG at mm/rmap.c:631!

2008-02-17 Thread Rafael J. Wysocki
On Sunday, 17 of February 2008, Ignacy Gawedzki wrote: > Hi, Hi, > I was printing on the parallel port and suddenly the "parallel" CUPS backend > went 50% CPU (obviously endless-looping), while the other 50% were eaten by > ghostscript (strace didn't show anything, so this might be an "internal"

Re: [lm-sensors] [PATCH] adt7473: New driver for Analog Devices ADT7473 sensor chip

2008-02-17 Thread Mark M. Hoffman
Hi Darrick: Sorry this took forever for me to review. Just a few little things... * Darrick J. Wong <[EMAIL PROTECTED]> [2007-12-19 15:14:38 -0800]: > This driver also had that funny alarm1/alarm2 thing; here's a revision > of yesterday's patch with that straightened out. > --- > This driver rep

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Cyrill Gorcunov
[H. Peter Anvin - Sun, Feb 17, 2008 at 12:11:45PM -0800] > Cyrill Gorcunov wrote: >> Thanks Peter for comments. Peter could you clarify for me a bit >> more on the string: >> x86/kernel/head_32.S:339 >> /* Set up the stack pointer */ >> lss stack_start,%esp >> but stack_start is defined a

Re: 2.6.25-rc2-mm1 (build failure)

2008-02-17 Thread Rafael J. Wysocki
On Sunday, 17 of February 2008, Pavel Machek wrote: > Hi! > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/ > > > > > > When SMP=n, x86_64 build gets: > > > > > > arch/x86/kernel/built-in.o: In function `acpi_save_state_mem': > > > (.text+0xfd7f):

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Tilman Schmidt
Am 17.02.2008 14:16 schrieb Adrian Bunk: The real problem is that the kernel seems to lack functionality you require for doing some work. Why does your work on the Debian Installer depend on VirtualBox and can't be done with what the kernel already ships? No, that's not the real problem. Even

Re: [2.6.25-rc2] System freezes ca. 1 minute after logging into KDE

2008-02-17 Thread Benjamin Thery
On Feb 17, 2008 11:39 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > (resend a third time because previous attempts never reached the lists > due to a bug in my MUA; my apologies to David for spamming his inbox) > > Linus Torvalds wrote: > > But hey, you can try to prove me wrong. I dare you. > Me too

Re: [2.6 patch] make vfs_ioctl() static

2008-02-17 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Christoph Hellwig writes: > On Sun, Feb 17, 2008 at 10:18:42AM +0200, Adrian Bunk wrote: > > This patch makes the needlessly global vfs_ioctl() static. > > I think the point was toa eventually export it for stackable filesystem > use. But until they start using it

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 08:08:29PM +0100, Ingo Molnar wrote: > > * Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Sun, Feb 17, 2008 at 06:17:18PM +0300, Cyrill Gorcunov wrote: > > > Though we use PDA for regular task stack but that > > > is not acceptable for init_task wich is special > > > one

mips SMBUS_PSC_BASE compile errors

2008-02-17 Thread Adrian Bunk
Commit 8b798c4d16b762d15f4055597ff8d87f73b35552 causes compile errors like the following for several system types: <-- snip --> ... CC arch/mips/au1000/common/platform.o /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/au1000/common/platform.c:277: error: 'PSC0_BASE_ADDR' undeclared

[2.6 patch] mips: finish the Qemu platform removal

2008-02-17 Thread Adrian Bunk
The following files can now be removed: - arch/mips/configs/qemu_defconfig - include/asm-mips/qemu.h Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/mips/configs/qemu_defconfig | 800 --- include/asm-mips/qemu.h | 30 - 2 files changed, 830 deleti

Re: [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs_trapnum'

2008-02-17 Thread Christian Kujau
On Sun, 17 Feb 2008, Sergio Luis wrote: It doesn't fix the problem totally. If we select Virtualization->Linux hypervisor example code (CONFIG_LGUEST) as a module, we will get the same build errors, Confirmed, the build errors persist with CONFIG_LGUEST=m and Rusty's patch applied. thanks, C

Re: Current git very broken on the Dreamcast

2008-02-17 Thread Kristoffer Ericson
On Sat, 16 Feb 2008 19:59:48 + Adrian McMenamin <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-16 at 19:48 +, Adrian McMenamin wrote: > > On Sat, 2008-02-16 at 18:38 +, Adrian McMenamin wrote: > > > Will seek to bisect this, but I have just updated my sources to the > > > latest git a

mips/bcm47xx/setup.c compile error

2008-02-17 Thread Adrian Bunk
Commit d3c319f9c8d9ee2c042c60b8a1bbd909dcc42782 causes the following compile error: <-- snip --> ... CC arch/mips/bcm47xx/setup.o /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mips/bcm47xx/setup.c: In function 'bcm47xx_get_invariants': /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/mi

cdev removal broke cobalt_btns.c compilation

2008-02-17 Thread Adrian Bunk
Commit 0c1efd365306c9b04df5abdd41e9b4dc721e84fb broke the compilation of cobalt_btns.c: <-- snip --> ... CC drivers/input/misc/cobalt_btns.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/misc/cobalt_btns.c: In function 'cobalt_buttons_probe': /home/bunk/linux/kernel-2.6/git/l

[2.6.25 patch] CRYPTO_NULL must select CRYPTO_BLKCIPHER

2008-02-17 Thread Adrian Bunk
This patch fixes the following build error caused by commit 3631c650c495d61b1dabf32eb26b46873636e918: <-- snip --> ... LD .tmp_vmlinux1 crypto/built-in.o: In function `skcipher_null_crypt': crypto_null.c:(.text+0x3d14): undefined reference to `blkcipher_walk_virt' crypto_null.c:(.text+0

Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

2008-02-17 Thread H. Peter Anvin
Cyrill Gorcunov wrote: Thanks Peter for comments. Peter could you clarify for me a bit more on the string: x86/kernel/head_32.S:339 /* Set up the stack pointer */ lss stack_start,%esp but stack_start is defined as head_32.S:647 .data ENTRY(stack_start) .long init_thre

Re: Disk schedulers

2008-02-17 Thread Linda Walsh
Lukas Hejtmanek wrote: whom should I blame about disk schedulers? I have the following setup: 1Gb network 2GB RAM disk write speed about 20MB/s If I'm scping file (about 500MB) from the network (which is faster than the local disk), any process is totally unable to read anything from the local

[PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-17 Thread Bartlomiej Zolnierkiewicz
drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide.c | 13 + 1 file changed, 5 inse

Re: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c

2008-02-17 Thread Ingo Molnar
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > > config attached. The include file dependencies in this area are a > > bit of a mess - perhaps they need some cleanups? > > OK, I'm building all(yes|mod)configs and didn't see this. Agreed > about the file dependencies here, I'll take a look. I

Re: arch/x86/mm/ioremap unification grew by 10x

2008-02-17 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > static __initdata int after_paging_init; > > -static __initdata pte_t bm_pte[PAGE_SIZE/sizeof(pte_t)] > > - __attribute__((aligned(PAGE_SIZE))); > > +static pte_t bm_pte[PAGE_SIZE/sizeof(pte_t)] > > Replace > > +

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Paul Jackson
Adrian wrote: > So let's fix the problem (kernel lacks functionality) That's the problem as understood by Adrian. I hear another problem as well ... Frans wrote: > Please allow external users some decent period for transitioning. The > initial plan to "remove the old function in 2.6.27" was en

Re: [PATCH] mm: setup_usemap() must be __meminit

2008-02-17 Thread Geert Uytterhoeven
On Sun, 17 Feb 2008, Sam Ravnborg wrote: > On Sun, Feb 17, 2008 at 01:31:14PM +0100, Geert Uytterhoeven wrote: > > On Sun, 17 Feb 2008, Geert Uytterhoeven wrote: > > > On m68k (CONFIG_SPARSEMEM is not set), I get: > > > > > > WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in > > >

Re: git-xtensa doesn't like my cross compiler

2008-02-17 Thread Chris Zankel
Hi Adrian, Thanks for pointing this out. I'm working on a fix. BTW, which branch do you use? release or testing? Thanks, -CHris Adrian Bunk wrote: With git-xtensa I'm getting: <-- snip --> ... /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/xtensa/Makefile:30: *** No Xtensa toolchain foun

Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

2008-02-17 Thread Rafael J. Wysocki
On Sunday, 17 of February 2008, Randy Dunlap wrote: > H. Peter Anvin wrote: > > Randy Dunlap wrote: > >> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote: > >> > >>> Randy Dunlap wrote: > Yes, adding -m32 to the X86_32 config ccflags (as is done for the > X86_64 case) makes it buil

Re: getting uninterruptible sleep processes after upgrade from 2.6.20.20 to 2.6.24.2

2008-02-17 Thread allied internet ag- Stefan Priebe
>> One week ago we upgraded about 300 servers from 2.6.20.20 to 2.6.24.2. > > Painfull. OK not really - i've tested the new kernel on all models. And it works fine... the DN state only comes sometimes - absolutely not reproducable. So my tests went OK and then we've done the update. I've now se

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Arjan van de Ven
On Sun, 17 Feb 2008 10:25:30 +0100 Frans Pop <[EMAIL PROTECTED]> wrote: > Yesterday, after spending quite a few hours over the last days on > bisecting some serious regressions and finding workarounds for them, > I thought I could start using 2.6.25-rc2 as the new kernel for my > desktop. Unfortun

Re: [PATCH 1/2] workqueues: shrink cpu_populated_map when CPU dies

2008-02-17 Thread Jarek Poplawski
Hi Oleg, This patch looks OK to me. But while reading this I got some doubts in nearby places, so BTW 2 small questions: 1) ... workqueue_cpu_callback(...) { ... list_for_each_entry(wq, &workqueues, list) { cwq = per_cpu_ptr(wq->cpu_wq, cpu); switc

Re: getting uninterruptible sleep processes after upgrade from 2.6.20.20 to 2.6.24.2

2008-02-17 Thread Jiri Slaby
On 02/17/2008 09:02 PM, allied internet ag- Stefan Priebe wrote: Hello! One week ago we upgraded about 300 servers from 2.6.20.20 to 2.6.24.2. Painfull. Now we get sometimes dozent of processes in state DN. The system is completely idle - but the load is 20 or 90 or whatever. And it can only

Re: 2.6.24-git4+ regression

2008-02-17 Thread Lukas Hejtmanek
On Thu, Feb 14, 2008 at 10:25:51PM +0530, Srivatsa Vaddagiri wrote: > The patch is against 2.6.25-rc1. I would request you to check for > difference it makes with CONFIG_FAIR_GROUP_SCHED and > CONFIG_FAIR_USER_SCHED turned on. well, I tried the patch against 2.6.25-rc2-git1. It seems to be better

Re: [PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON

2008-02-17 Thread Theodore Tso
On Sun, Feb 17, 2008 at 06:55:06PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > if (...) BUG(); should be replaced with BUG_ON(...) when the test has no > side-effects to allow a definition of BUG_ON that drops the code completely. Hi, in the future, please separate ext

Re: Linux 2.6.25-rc2

2008-02-17 Thread Rafael J. Wysocki
On Saturday, 16 of February 2008, Torsten Kaiser wrote: > On Feb 15, 2008 10:23 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > Ok, > > this kernel is a winner. > > Sadly not for me: > [ 5282.056415] [ cut here ] > [ 5282.059757] kernel BUG at lib/list_debug.c:33! >

Re: getting uninterruptible sleep processes after upgrade from 2.6.20.20 to 2.6.24.2

2008-02-17 Thread Christian Kujau
On Sun, 17 Feb 2008, allied internet ag- Stefan Priebe wrote: One week ago we upgraded about 300 servers from 2.6.20.20 to 2.6.24.2. Did you test with *one* server before upgrading all 300? If not, please do and try to upgrade in smaller steps, e.g. 2.6.20->2.6.21 and see when it breaks. Add

Re: getting uninterruptible sleep processes after upgrade from 2.6.20.20 to 2.6.24.2

2008-02-17 Thread Arjan van de Ven
On Sun, 17 Feb 2008 21:49:10 +0100 allied internet ag- Stefan Priebe <[EMAIL PROTECTED]> wrote: > >> One week ago we upgraded about 300 servers from 2.6.20.20 to > >> 2.6.24.2. > > > > Painfull. > > OK not really - i've tested the new kernel on all models. And it > works fine... the DN state

Re: [PATCH 4/5] [PATCH] introduce paravirt helpers

2008-02-17 Thread Glauber Costa
On Feb 17, 2008 4:05 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Glauber Costa <[EMAIL PROTECTED]> wrote: > > > config X86_VSMP > > bool "Support for ScaleMP vSMP" > > depends on X86_64 && PCI > > - help > > + select PARAVIRT > > + help > > hm, what's the idea here?

Re: Suspend doesn't work when SD card is inserted

2008-02-17 Thread Rafael J. Wysocki
On Sunday, 17 of February 2008, Zdenek Kabelac wrote: > Hello Hi, Thanks for the report. > I've noticed that my system (T61) doesn't want to suspend when SD card > is in the card reader slot with 2.6.25-rc2 (no problem when the card > is outside) > Also the card is not even mounted, it's just i

[no subject]

2008-02-17 Thread dpreed
>From David P. Reed <[EMAIL PROTECTED]> Sat Feb 16 15:05:17 2008 Message-Id: <[EMAIL PROTECTED]>> References: <[EMAIL PROTECTED]>> User-Agent: quilt/0.46-1 Date: Sat, 16 Feb 2008 15:05:19 -0500 From: David P. Reed <[EMAIL PROTECTED]> To: Thomas Gleixner <[EMAIL PROTECTED]>, Ingo Molnar <[EMAIL PRO

Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 09:40:15PM +0100, Rafael J. Wysocki wrote: > On Sunday, 17 of February 2008, Randy Dunlap wrote: > > H. Peter Anvin wrote: > > > Randy Dunlap wrote: > > >> On Sat, 16 Feb 2008 19:58:06 -0800 H. Peter Anvin wrote: > > >> > > >>> Randy Dunlap wrote: > > Yes, adding -m32 t

Re: [PATCH] ieee1394: sbp2: fix rescan-scsi-bus

2008-02-17 Thread Stefan Richter
>> On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote: >>> rescan-scsi-bus used to add SBP-2 targets which weren't there. PS: It probably wasn't clear: rescan-scsi-bus.sh is *not* necessary for sbp2 (under Linux 2.6, that is). The patch merely prevents weird things from happening if the us

Re: git-xtensa doesn't like my cross compiler

2008-02-17 Thread Adrian Bunk
On Sun, Feb 17, 2008 at 12:29:58PM -0800, Chris Zankel wrote: > Hi Adrian, Hi Chris, > Thanks for pointing this out. I'm working on a fix. thanks. > BTW, which branch do you use? release or testing? I tried #testing. > Thanks, > -CHris cu Adrian -- "Is there not promise of rain?" L

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Arjan van de Ven
On Sun, 17 Feb 2008 14:38:51 -0600 Paul Jackson <[EMAIL PROTECTED]> wrote: > Adrian wrote: > > So let's fix the problem (kernel lacks functionality) > > That's the problem as understood by Adrian. > > I hear another problem as well ... > > Frans wrote: > > Please allow external users some dece

Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

2008-02-17 Thread H. Peter Anvin
Sam Ravnborg wrote: But I assume in less obvious way. It is a bit more intuitive to error out on missing -m32 support than gcc failing to support .code16 or some other inline assembler magic. No, you will get the message "the selected CPU doesn't support the x86-64 architecture". -

Re: Linux 2.6.25-rc2

2008-02-17 Thread Torsten Kaiser
On Feb 17, 2008 9:25 PM, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > There's the Bugzilla entry for it at > http://bugzilla.kernel.org/show_bug.cgi?id=9973 Thank you. > Please update it with the current information. Crash for 2.6.25-rc2-mm1 added. That one had a complete stacktrace, but the t

Re: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c

2008-02-17 Thread Harvey Harrison
On Sun, 2008-02-17 at 21:09 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > > config attached. The include file dependencies in this area are a > > > bit of a mess - perhaps they need some cleanups? > > > > OK, I'm building all(yes|mod)configs and didn't see this.

Re: [PATCH v2] Re: 2.6.25-rc2-mm1 (wakeup)

2008-02-17 Thread Sam Ravnborg
On Sun, Feb 17, 2008 at 01:31:37PM -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > > > >But I assume in less obvious way. > >It is a bit more intuitive to error out on missing > >-m32 support than gcc failing to support .code16 > >or some other inline assembler magic. > > > > No, you will get

<    1   2   3   4   5   >