From: "Maxin B. John"
Date: Sun, 23 Sep 2012 13:03:30 -0400
> scm_destroy_cred() dereferences 'scm' before null check
>
> Signed-off-by: Maxin B. John
Every caller of scm_destroy() passes a non-NULL scm, so the
NULL test can be removed entirely.
I'll do this in net-next, thanks.
--
To
Am 23.08.2012 16:14, schrieb p...@google.com:
> From: Paul Turner
>
> Now that our measurement intervals are small (~1ms) we can amortize the
> posting
> of update_shares() to be about each period overflow. This is a large cost
> saving for frequently switching tasks.
[snip]
> @@ -1181,6
On Thu, Sep 20, 2012 at 10:48 AM, Roland Stigge wrote:
> For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument
> (initial value of output). This patch fixes this by setting the level
> accordingly.
>
> Signed-off-by: Roland Stigge
Applied with Alexandre's ACK, should go
Hi Tejun,
May be I misunderstood, I read in the documentation about max_active.
In this case, max_active is 1, but I created three workqueues, do you
mean to say for this case, single thread can process three requests
queued up in the three different workqueues.
Sorry, if I misunderstood.
On Mon, Sep 24, 2012 at 03:46:22PM -0300, Gustavo Padovan wrote:
> * Luis R. Rodriguez [2012-09-21 18:06:42 -0700]:
>
> > On Tue, Sep 18, 2012 at 6:31 PM, Gustavo Padovan
> > wrote:
> >
> > > Johan Hedberg (2):
> > > Bluetooth: mgmt: Implement support for passkey notification
> >
> >
On Monday 24 September 2012, Mark Salter wrote:
>
> Commit d97b46a64 added a new syscall (__NR_kcmp) to support checkpoint
> restore. It is currently x86-only, but that restriction will be removed
> in a subsequent patch. Unfortunately, the kernel checksyscalls script
> had a bug which suppressed
On 24/09/12 21:55, Linus Walleij wrote:
For GPIOs of gpio-lpc32xx, gpio_direction_output() ignores the value argument
(initial value of output). This patch fixes this by setting the level
accordingly.
Signed-off-by: Roland Stigge
Applied with Alexandre's ACK, should go into stable right?
So
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Subject: Re: [RFC] mm: add support for zsmalloc and zcache
> On Sat, 2012-09-22 at 02:07 +0100, Mel Gorman wrote:
> > > The two proposals:
> > > A) Recreate all the work done for zcache2 as a proper sequence of
> > >
Srikar, sorry for delay, somehow I missed this email.
And I am still confused...
On 09/20, Srikar Dronamraju wrote:
>
> * Oleg Nesterov [2012-09-18 18:07:38]:
>
> > > > I compiled this program
> > > >
> > > > int main(void)
> > > > {
> > > > asm volatile (".word
On Mon 24-09-12 21:31:35, Borislav Petkov wrote:
> On Tue, Sep 25, 2012 at 12:18:46AM +0530, Srivatsa S. Bhat wrote:
> > >> Sure thing.
> > >> Out of ~25 runs I only triggered it once, without the patch the
> > >> trigger-rate is higher.
> > >>
> > >> [ 55.098249] Broke affinity for irq 81
> >
Hello,
On Mon, Sep 24, 2012 at 08:57:40PM +0100, Deepawali Verma wrote:
> May be I misunderstood, I read in the documentation about max_active.
> In this case, max_active is 1, but I created three workqueues, do you
I see. Why are you doing that? Is there ordering requirement? Why
not just
On Mon, Sep 24, 2012 at 10:11 AM, Lee Jones wrote:
> The PRCMU has its own USB, Thermal, GPIO, Modem, HSI and RTC drivers,
> amongst other things. This patch allows those subordinate devices to
> use it as an interrupt controller as and when they are DT enabled.
>
> CC: Samuel Ortiz
>
On Mon 24-09-12 22:07:37, Jan Kara wrote:
> On Mon 24-09-12 21:31:35, Borislav Petkov wrote:
> > On Tue, Sep 25, 2012 at 12:18:46AM +0530, Srivatsa S. Bhat wrote:
> > > >> Sure thing.
> > > >> Out of ~25 runs I only triggered it once, without the patch the
> > > >> trigger-rate is higher.
> > > >>
On 09/22/12 03:06, Russell King - ARM Linux wrote:
> On Tue, Sep 18, 2012 at 11:05:27PM -0700, Stephen Boyd wrote:
>> The first patch in this series fixes error checking in the wm831x clock
>> driver and is here to prevent context conflicts in the third patch.
>> I split it out in case it needed
On 09/24/2012 09:48 AM, John Stultz wrote:
Hey Thomas, Ingo,
[snip]
PS: Just a reminder that there is still a pending change in
tip/timers/urgent that I'd hope to get into 3.6.
Oh, ignore that. Just updated my tree and it looks like it landed over
the weekend.
Sorry for the noise.
-john
On 09/22/2012 08:16 AM, Len Brown wrote:
> This isn't a NAK, but I'm at best, "like warm" on this.
>
> I'm not convinced it is a good thing to have - enabled by default -
> the ability for users to easily over-ride ACPI tables.
For the record: I'm fine with the implementation from a technical
On 09/22/2012 04:32 AM, Ingo Molnar wrote:
>
> * H. Peter Anvin wrote:
>
>> On 09/21/2012 03:08 PM, Dave Jones wrote:
>>>
>>> Perhaps add a printk somewhere to show that it's actually been enabled
>>> maybe ?
>>>
>>> Also, would it be feasible to add something like we have for test_nx ?
>>> If
On Mon, Sep 24, 2012 at 10:51:19PM +0400, Cyrill Gorcunov wrote:
> > I expect what you want is a call to access_ok, rather than hard coding
> > details about task layout here. This test certainly looks wrong
> > for a 32bit process on a 64bit kernel. If I read your test right it
> > appears I can
On Mon, Sep 24, 2012 at 01:20:42PM -0700, Stephen Boyd wrote:
> On 09/22/12 03:06, Russell King - ARM Linux wrote:
> > On Tue, Sep 18, 2012 at 11:05:27PM -0700, Stephen Boyd wrote:
> >> The first patch in this series fixes error checking in the wm831x clock
> >> driver and is here to prevent
On 09/24, Geert Uytterhoeven wrote:
>
> On Sun, Aug 26, 2012 at 9:12 PM, Oleg Nesterov wrote:
> > + while ((work = ACCESS_ONCE(*pprev))) {
> > + read_barrier_depends();
Hmm. This should be smp_read_barrier_depends(), but this doesn't matter.
> Woops, h8300 doesn't have
> From: Mel Gorman [mailto:mgor...@suse.de]
> Subject: Re: [RFC] mm: add support for zsmalloc and zcache
>
> On Sat, Sep 22, 2012 at 02:18:44PM -0700, Dan Magenheimer wrote:
> > > From: Mel Gorman [mailto:mgor...@suse.de]
> > > Subject: Re: [RFC] mm: add support for zsmalloc and zcache
> > >
> >
clk_register() returns an ERR_PTR upon failure, not NULL. Fix
these error paths.
Acked-by: Mark Brown
Signed-off-by: Stephen Boyd
---
v2: No changes
drivers/clk/clk-wm831x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk-wm831x.c
On Mon, 2012-09-24 at 20:01 +, Arnd Bergmann wrote:
> On Monday 24 September 2012, Mark Salter wrote:
> >
> > Commit d97b46a64 added a new syscall (__NR_kcmp) to support checkpoint
> > restore. It is currently x86-only, but that restriction will be removed
> > in a subsequent patch.
Move this driver to use devm_clk_register() to simplify some
error paths and reduce lines of code.
Acked-by: Mark Brown
Signed-off-by: Stephen Boyd
---
v2: No changes
drivers/clk/clk-wm831x.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git
Some clock drivers can be simplified if devres takes care of
unregistering any registered clocks along error paths. Introduce
devm_clk_register() so that clock drivers get unregistration for
free along with simplified error paths.
Signed-off-by: Stephen Boyd
---
v2: Use devres_release()
blocked_load_avg ~= \sum_child child.runnable_avg_sum/child.runnable_avg_period
* child.weight
The thought was: So if all the children have hit zero runnable_avg_sum
(or in the case of a child task, will when they wake up), then
blocked_avg sum should also hit zero at the same and we're in
Hello, Lai.
On Mon, Sep 24, 2012 at 06:07:02PM +0800, Lai Jiangshan wrote:
> The core patch is patch6, it makes all flusher can start and the same time
> and allow us do more cleanup.
>
> Only patch1 and patch6 change the behavior of the code.
> All other patches do not change any behavior.
It
On Mon, Sep 24, 2012 at 1:31 PM, H. Peter Anvin wrote:
> On 09/22/2012 04:32 AM, Ingo Molnar wrote:
>>
>> * H. Peter Anvin wrote:
>>
>>> On 09/21/2012 03:08 PM, Dave Jones wrote:
Perhaps add a printk somewhere to show that it's actually been enabled
maybe ?
Also, would
Cyrill Gorcunov writes:
> On Mon, Sep 24, 2012 at 10:51:19PM +0400, Cyrill Gorcunov wrote:
>> > I expect what you want is a call to access_ok, rather than hard coding
>> > details about task layout here. This test certainly looks wrong
>> > for a 32bit process on a 64bit kernel. If I read your
arch/x86/kernel/alternative.c:
static int __init bootonly(char *str)
{
smp_alt_once = 1;
return 1;
}
__setup("smp-alt-boot", bootonly);
kernel-parameters.txt:
smp-alt-once[X86-32,SMP] On a
From: Srivatsa S. Bhat
The CPU hotplug callback related to writeback calls writeback_set_ratelimit()
during every state change in the hotplug sequence. This is unnecessary
since num_online_cpus() changes only once during the entire hotplug operation.
So invoke the function only once per
On 09/24/2012 01:43 PM, Kees Cook wrote:
>
> How about this...
>
> mem protection : nx smap smep
>
> Maybe the "why" of a cpu feature being missing from the "mem
> protection" line can stay in printk?
>
Come to think about it, since we use setup_set/clear_cpu_cap we aready
don't list the
Hi Tejun,
I do not have ordering as requirement. I can use system work queue as
well. what is max_active by default for system wq per cpu?
Regards,
Deepa
On Mon, Sep 24, 2012 at 9:08 PM, Tejun Heo wrote:
> Hello,
>
> On Mon, Sep 24, 2012 at 08:57:40PM +0100, Deepawali Verma wrote:
>> May be I
On Mon, Sep 24, 2012 at 01:44:47PM -0700, Eric W. Biederman wrote:
> Cyrill Gorcunov writes:
>
> > On Mon, Sep 24, 2012 at 10:51:19PM +0400, Cyrill Gorcunov wrote:
> >> > I expect what you want is a call to access_ok, rather than hard coding
> >> > details about task layout here. This test
On Mon, Sep 24, 2012 at 09:52:14PM +0100, Deepawali Verma wrote:
> I do not have ordering as requirement. I can use system work queue as
> well. what is max_active by default for system wq per cpu?
For system_unbound_wq, it's the larger one of 512 and 4 * #cpus.
--
tejun
--
To unsubscribe from
Hi Linus,
On Mon, Sep 24, 2012 at 10:14:02PM +0200, Linus Walleij wrote:
> On Mon, Sep 24, 2012 at 10:11 AM, Lee Jones wrote:
>
> > The PRCMU has its own USB, Thermal, GPIO, Modem, HSI and RTC drivers,
> > amongst other things. This patch allows those subordinate devices to
> > use it as an
drivers/scsi/sd.c |4
drivers/scsi/sd.h |2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 4df73e5..d15074b 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -92,6 +92,10 @@ MODULE_ALIAS_SCSI_DEVICE(TYPE_DISK);
On Mon, Sep 24, 2012 at 1:04 PM, Geert Uytterhoeven
wrote:
> On Mon, Sep 24, 2012 at 9:00 PM, Jason Baron wrote:
>>> - pr_warn("expected <%d bytes into control\n", USER_BUF_PAGE);
>
> %u?
>
>>> + pr_warn("expected <%d bytes into control, you wrote %d\n",
>>> +
On Mon, 24 Sep 2012 22:17:26 +0200
Jan Kara wrote:
> In the attachment is a fix. Fengguang, can you please merge it? Thanks!
I grabbed it. I also added the (missing, important) text "This bug causes
a divide-by-zero oops in bdi_dirty_limit() in Borislav's 3.6.0-rc6
based kernel." And I stuck
On Mon, 24 Sep 2012 10:39:38 +0100
Mel Gorman wrote:
> On Fri, Sep 21, 2012 at 02:36:56PM -0700, Andrew Morton wrote:
>
> > Also, what has to be done to avoid the polling altogether? eg/ie, zap
> > a pageblock's PB_migrate_skip synchronously, when something was done to
> > that pageblock which
On Mon, Sep 24, 2012 at 05:46:09AM -0500, Jason Wessel wrote: [...]
> You can add my ack to the series, for what you have in:
> "git://git.infradead.org/users/cbou/linux-nmi-kdb.git master", and then
> drop a pull request to Greg for the next merge window. Thank you for
> your hard work through
2012/9/23 Sasha Levin :
> On 09/23/2012 02:21 AM, Paul E. McKenney wrote:
>> On Sat, Sep 22, 2012 at 02:27:35PM -0700, Paul E. McKenney wrote:
>>> On Sat, Sep 22, 2012 at 07:50:29PM +0200, Sasha Levin wrote:
On 09/22/2012 05:56 PM, Paul E. McKenney wrote:
> And now the prime suspect is
Hi all,
Here comes v9...
Greg, patches 1-7 have gotten all the needed acks from Alan and Jason, so
it would be awesome if you could apply them to your tty-next tree.
ARM patches still need Russell's acks, but these can wait, plus if the
core support hits v3.7, it would be much easier to handle
The new arch callback should manage NMIs that usually cause KGDB to
enter. That is, not all NMIs should be enabled/disabled, but only
those that issue kgdb_handle_exception().
We must mask it as serial-line interrupt can be used as an NMI, so
if the original KGDB-entry cause was say a breakpoint,
This command disables NMI-entry. If NMI source has been previously shared
with a serial console ("debug port"), this effectively releases the port
from KDB exclusive use, and makes the console available for normal use.
Of course, NMI can be reenabled, enable_nmi modparam is used for that:
This makes the stubs actually usable, since e.g. 'foo = kdb_register();'
leads to build errors in !KGDB_KDB case. Plus, with static inlines we
do type checking.
Signed-off-by: Anton Vorontsov
Acked-by: Jason Wessel
---
include/linux/kdb.h | 29 -
1 file changed, 16
It was noticed that polling drivers (like KGDB) are not able to use
serial ports if the ports were not previously initialized via console.
I.e. when booting with console=ttyAMA0 kgdboc=ttyAMA0, everything works
fine, but with console=ttyFOO kgdboc=ttyAMA0, the kgdboc doesn't work.
This is
The callback is used to initialize the hardware, nothing else should be
done, i.e. we should not request interrupts (but we can and do unmask
some of them, as they might be useful for NMI entry).
As a side-effect, the patch also fixes a division by zero[1] when booting
with kgdboc options
We need to quiesce interrupts in the poll_get_char routine, otherwise,
if used with KGDB NMI debugger, we'll keep reentering the NMI.
Quiescing interrupts is pretty straightforward, except for TXIM
interrupt. The interrupt has "ready to transmit" meaning, so it's
almost always raised, and the
This special driver makes it possible to temporary use NMI debugger port
as a normal console by issuing 'nmi_console' command (assuming that the
port is attached to KGDB).
Unlike KDB's disable_nmi command, with this driver you are always able
to go back to the debugger using KGDB escape sequence
Just move the macros into header file as we would want to use them for
KGDB FIQ entry code.
The following macros were moved:
- svc_entry
- usr_entry
- kuser_cmpxchg_check
- vector_stub
To make kuser_cmpxchg_check actually work across different files, we
also have to make
The FIQ debugger may be used to debug situations when the kernel stuck
in uninterruptable sections, e.g. the kernel infinitely loops or
deadlocked in an interrupt or with interrupts disabled.
By default KGDB FIQ is disabled in runtime, but can be enabled with
kgdb_fiq.enable=1 kernel command line
Just a couple of calls to manage VIC FIQ routing. We'll use them for
KGDB FIQ support on ARM Versatile machines.
Signed-off-by: Anton Vorontsov
---
arch/arm/common/vic.c | 28
arch/arm/include/asm/hardware/vic.h | 2 ++
2 files changed, 30
If enabled, kernel will able to enter KGDB upon serial line activity on
UART ports.
Note that even with this patch and CONFIG_KGDB_FIQ is enabled, you still
need to pass kgdb_fiq.enable=1 kernel command line option, otherwise UART
will behave in a normal way.
By default UART0 is used, but this
I have here a cubox running v3.5, and I've been watching top while it's
playing back an mpeg stream from NFS using vlc. rootfs on SD card, and
it's uniprocessor.
Top reports the following:
top - 20:38:35 up 44 min, 3 users, load average: 1.26, 1.10, 1.10
Tasks: 125 total, 1 running, 124
Commit 1ad75b9e1 added some address checking to prctl_set_mm()
used by checkpoint-restore. This causes a build error for no-MMU
systems:
kernel/sys.c: In function 'prctl_set_mm':
kernel/sys.c:1868:34: error: 'mmap_min_addr' undeclared (first use in this
function)
The test for
Hi Amit,
> I'm sorry for not being able to look at this earlier.
No worries. I'll try to respin and retest this patch by tomorrow.
If you by any chance could find time to review so could make it in time
for 3.7 it would be great :-)
> A general comment is to base this patchset on linux-next;
On Sat, 22 Sep 2012, Paul E. McKenney wrote:
> On Sat, Sep 22, 2012 at 10:20:19PM +, Paul Walmsley wrote:
> > On Sat, 22 Sep 2012, Paul E. McKenney wrote:
> >
> > > This thing has been in the kernel since about 2004, not sure why you
> > > didn't hit it earlier.
> >
> > One other data point
On Mon, Sep 24, 2012 at 05:41:32PM -0400, Mark Salter wrote:
> Commit 1ad75b9e1 added some address checking to prctl_set_mm()
> used by checkpoint-restore. This causes a build error for no-MMU
> systems:
>
>kernel/sys.c: In function 'prctl_set_mm':
>kernel/sys.c:1868:34: error:
On Mon, Sep 24, 2012 at 09:54:00PM +, Paul Walmsley wrote:
> On Sat, 22 Sep 2012, Paul E. McKenney wrote:
>
> > On Sat, Sep 22, 2012 at 10:20:19PM +, Paul Walmsley wrote:
> > > On Sat, 22 Sep 2012, Paul E. McKenney wrote:
> > >
> > > > This thing has been in the kernel since about 2004,
Hi,
On Mon, Sep 24, 2012 at 1:54 PM, selso wrote:
> From: sli
>
>
> Signed-off-by: sli
> ---
> drivers/staging/tidspbridge/core/dsp-clock.c |3 ++
> drivers/staging/tidspbridge/core/tiomap3430.c |4 ++
> drivers/staging/tidspbridge/core/wdt.c |2 +-
>
On Wed, Aug 22, 2012 at 9:16 AM, Jiang Liu wrote:
> From: Jiang Liu
>
> Commit 0d52f54e2ef64c189dedc332e680b2eb4a34590a (PCI / ACPI: Make acpiphp
> ignore root bridges using PCIe native hotplug) added code that made the
> acpiphp driver completely ignore PCIe root complexes for which the kernel
On 09/24/2012 07:53 AM, Stephen Rothwell wrote:
> Hi all,
>
> Today was a train wreck, with lots of new conflicts across several trees
> and a few build failures as well.
>
> Changes since 201209021:
>
on x86_64:
drivers/built-in.o: In function `rproc_virtio_finalize_features':
From: "Mathieu J. Poirier"
The last version of this patch was sent a week ago but did not
generate comments or an acknowledgement. It is being resent
after a rebase on 3.6-rc7.
This patch adds keyreset functionality to the sysrq driver. It
allows certain button/key combinations to be used in
On 09/24/2012 05:04 AM, Paul Bolle wrote:
>
> 4) So, without even understanding why tsc calibration is needed, it does
> look unnecessary to print "Fast TSC calibration failed" at error level.
> If that's correct, I'd be happy to submit the trivial patch to downgrade
> it to (say) informational
On Thu 20-09-12 16:44:22, Wu Fengguang wrote:
> On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote:
> > From: Namjae Jeon
> >
> > This patch is based on suggestion by Wu Fengguang:
> > https://lkml.org/lkml/2011/8/19/19
> >
> > kernel has mechanism to do writeback as per dirty_ratio
On Fri, 21 Sep 2012, Raghavendra K T wrote:
> I think you meant we can read data only once. second time onwards we don't see
> any data. (except when fd is forked by child/ races in
> threads).
>
You can read(2) as many times as you want after it's opened and will get
persistent data.
--
To
On Mon 24-09-12 14:21:00, Andrew Morton wrote:
> On Mon, 24 Sep 2012 22:17:26 +0200
> Jan Kara wrote:
>
> > In the attachment is a fix. Fengguang, can you please merge it? Thanks!
>
> I grabbed it. I also added the (missing, important) text "This bug causes
> a divide-by-zero oops in
* John W. Linville [2012-09-24 15:54:22 -0400]:
> On Mon, Sep 24, 2012 at 03:46:22PM -0300, Gustavo Padovan wrote:
> > * Luis R. Rodriguez [2012-09-21 18:06:42 -0700]:
> >
> > > On Tue, Sep 18, 2012 at 6:31 PM, Gustavo Padovan
> > > wrote:
> > >
> > > > Johan Hedberg (2):
> > > >
On 09/20/2012 07:26 PM, Stephen Boyd wrote:
Add calls to clk_prepare and unprepare so that MSM can migrate to
the common clock framework. We never unprepare the clocks until
driver remove because the clocks are enabled and disabled in irq
context. Finer grained power management is possible in
On 09/20/2012 07:26 PM, Stephen Boyd wrote:
Nobody is using this API upstream and it's just contributing
cruft. Remove it so the MSM clock API is closer to the generic
struct clock API.
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
arch/arm/mach-msm/clock-pcom.c | 10 --
Random assortment of refactoring and trivial cleanups;
Previous posting: http://thread.gmane.org/gmane.linux.kernel.bcache.devel/1055
No big changes since v2 - incorporated review feedback - mostly documentation,
did more testing, and fixed the deadlock Vivek noticed in my "convert integrity
to
This is prep work for immutable bio vecs; we first want to centralize
where bvecs are modified.
Next two patches convert some existing code to use this function.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
---
fs/bio.c| 41 +
In the current code bio_split() won't be seeing partially completed bios
so this doesn't change any behaviour, but this makes the code a bit
clearer as to what bio_split() actually requires.
The immediate purpose of the patch is removing unnecessary bi_idx
references, but the end goal is to allow
This is for the new bio splitting code. When we split a bio, if the
split occured on a bvec boundry we reuse the bvec for the new bio. But
that means bio_free() can't free it, hence the explicit flag.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
Acked-by: Tejun Heo
---
fs/bio.c
BIO_CLONED wasn't very useful, and didn't have very clear semantics, so
kill it.
Replace it with a more useful flag - BIO_SUBMITTED means the bio has
been passed to generic_make_request() and the bvec can no longer be
modified.
Roll both changes into the same patch so we can steal the old bit
This gets open coded quite a bit and it's tricky to get right, so make a
generic version and convert some existing users over to it instead.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
---
fs/bio.c| 70 +
include/linux/bio.h |
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: Jiri Kosina
---
drivers/block/pktcdvd.c | 79 -
1 file changed, 12 insertions(+), 67 deletions(-)
diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 2c27744..783c96c 100644
---
This was the only real user of BIO_CLONED, which didn't have very clear
semantics. Convert to its own flag so we can get rid of BIO_CLONED.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: Martin K. Petersen
---
fs/bio-integrity.c | 5 ++---
include/linux/bio.h | 1 +
2 files changed, 3
More utility code to replace stuff that's getting open coded.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/raid1.c | 16 +++-
fs/bio.c| 28
include/linux/bio.h | 1 +
3 files changed, 32 insertions(+), 13
More prep work for immutable bvecs:
A few places in the code were either open coding or using the wrong
version - fix.
After we introduce the bvec iter, it'll no longer be possible to modify
the biovec through bio_for_each_segment_all() - it doesn't increment a
pointer to the current bvec, you
On 09/20/2012 07:26 PM, Stephen Boyd wrote:
There are no users of this API anymore so let's just remove it.
If a need arises in the future we can extend the common clock API
to handle it.
Cc: Saravana Kannan
Signed-off-by: Stephen Boyd
---
arch/arm/mach-msm/clock-debug.c | 9 +
More bi_idx removal. This code was just open coding bio_clone(). This
could probably be further improved by using bio_advance() instead of
skipping over null pages, but that'd be a larger rework.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/raid1.c | 36
__bio_for_each_segment() iterates bvecs from the specified index
instead of bio->bv_idx. Currently, the only usage is to walk all the
bvecs after the bio has been advanced by specifying 0 index.
For immutable bvecs, we need to split these apart;
bio_for_each_segment() is going to have a
A bunch of what __blk_queue_bounce() was doing was problematic for the
immutable bvec work; this cleans that up and the code is quite a bit
smaller, too.
The __bio_for_each_segment() in copy_to_high_bio_irq() was changed
because that one's looping over the original bio, not the bounce bio -
a
This doesn't really delete any code _yet_, but once immutable bvecs are
done we can just delete the rest of the code in that loop.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/raid1.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
In the short term this'll help with code auditing, and if this code ever
gets used now it's converted :)
Signed-off-by: Kent Overstreet
CC: Jiri Kosina
---
drivers/block/pktcdvd.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/block/pktcdvd.c
Bunch of places in the code weren't using it where they could be -
this'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx
into a struct bvec_iter.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: "Ed L. Cashin"
CC: Nick Piggin
CC: Jiri Kosina
CC: Jim Paris
CC: Geoff Levand
Had to shuffle the code around a bit (where bi_rw and bi_end_io were
set), but shouldn't really be anything tricky here
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/raid5.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/raid1.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 28f506a..4614b9e 100644
--- a/drivers/md/raid1.c
+++
On Sat, Sep 22, 2012 at 8:11 AM, Yinghai Lu wrote:
> On Sat, Sep 22, 2012 at 1:10 AM, Fengguang Wu wrote:
>>
>>> > Please check attached patch that should fix the problem.
>>>
>>> updated more aggressive version. two patches.
>>
>> Yes they work nicely. Thank you very much!
>
> Thanks.
>
> v2
More prep work for immutable bio vecs, mainly getting rid of references
to bi_idx.
bio_reset was being open coded in a few places. The one in sync_request
was a bit nontrivial to convert, so could use some extra eyeballs.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
Acked-by:
Random cleanup - this code was duplicated and it's not really specific
to md.
Also added the ability to return the actual error code.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
Acked-by: Tejun Heo
---
drivers/md/raid1.c | 19 ---
drivers/md/raid10.c | 19
For immutable bvecs, all bi_idx usage needs to be audited - so here
we're removing all the unnecessary uses.
Most of these are places where it was being initialized on a bio that
was just allocated, a few others are conversions to standard macros.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
Just a little convenience macro - main reason to add it now is preparing
for immutable bio vecs, it'll reduce the size of the patch that puts
bi_sector/bi_size/bi_idx into a struct bvec_iter.
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: Lars Ellenberg
CC: Jiri Kosina
CC: Alasdair Kergon
More prep work for immutable bvecs/effecient bio splitting - usage of
bi_vcnt has to be auditing, so getting rid of all the unnecessary usage
makes that easier.
Plus, bio_segments() is really what this code wanted, as it respects the
current value of bi_idx.
Signed-off-by: Kent Overstreet
CC:
Signed-off-by: Kent Overstreet
CC: Jens Axboe
CC: NeilBrown
---
drivers/md/md.c | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7a2b079..51ce48c 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -190,25
This adds a pointer to the bvec array to struct bio_integrity_payload,
instead of the bvecs always being inline; then the bvecs are allocated
with bvec_alloc_bs().
Changed bvec_alloc_bs() and bvec_free_bs() to take a pointer to a
mempool instead of the bioset, so that bio integrity can use a
Converts it to use bio_advance(), simplifying it quite a bit in the
process.
Note that req_bio_endio() now always calls bio_advance() - which means
it always loops over the biovec, not just on partial completions. Don't
expect it to affect performance, but worth noting.
Tested it by forcing
bio_integrity_split() seemed to be confusing pointers and arrays -
bip_vec in bio_integrity_payload is an array appended to the end of the
payload, so the bio_vecs in struct bio_pair need to come immediately
after the bio_integrity_payload they're for, and there was an assignment
in
501 - 600 of 1416 matches
Mail list logo
