[PATCH 1/1] Staging: iio: Coding Style Correction

2015-02-08 Thread Tolga Ceylan
Indentation corrections in struct initializations and one line over 80 characters split into two lines Signed-off-by: Tolga Ceylan --- drivers/staging/iio/magnetometer/hmc5843_i2c.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/i

[PATCH] i2c: ismt: fix type of return var of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. As ret is in used for other calls a new appropriately typed variable timeout is added to handle wait_for_completion_timeout Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with x86_64_defconfig + CONFIG_I2C

Re: [PATCH v2 0/3] More Line 6 cleanup

2015-02-08 Thread Takashi Iwai
At Sat, 7 Feb 2015 10:43:16 -0600, Chris Rorvick wrote: > > Changes in v2: > > * return true/false instead of 1/0 > * do not include spaces in driver name > * drop patch altering struct names (unnecessary) Thanks, applied all three patches now. Takashi > > Chris Rorvick (3): > ALSA:

[PATCH] i2c: axxia: match var to return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as ret is only used for wait_for_completion_timeout here the type is simply changed unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with axm55xx_defconfig (implies CONFIG_I2C_AXXIA=y) Patch is

Re: Re: [PATCH perf/core 1/2] [BUGFIX] perf-probe: Fix to handle optimized not-inlined but has no instance

2015-02-08 Thread Masami Hiramatsu
(2015/01/30 23:21), Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 30, 2015 at 06:37:44PM +0900, Masami Hiramatsu escreveu: >> Fix to handle optimized no-inline functions which have >> only function definition but no actual instance at >> that point. To fix this problem, we need to find actual >> in

Re: [PATCH 0/2] Add device_create_files() and device_remove_files() helpers

2015-02-08 Thread Takashi Iwai
At Sat, 7 Feb 2015 18:10:48 +0800, Greg Kroah-Hartman wrote: > > On Fri, Jan 30, 2015 at 05:31:51PM +0100, Takashi Iwai wrote: > > If we export device_add_groups() and device_remove_groups(), is it > > safe to call it before device_add()? If yes, some drivers/subsystems > > can have a code flow l

[PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. As rc is used here only for wait_for_completion_timeout the type is simply changed to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with x86_64_defconfig + CONFIG_IEEE802154=m, CONFIG_MAC802

Re: [PATCH v3] kernel: Conditionally support non-root users, groups and capabilities

2015-02-08 Thread Geert Uytterhoeven
Hi Iulia, On Fri, Feb 6, 2015 at 2:10 PM, Iulia Manda wrote: > On 6 February 2015 at 02:03, Iulia Manda wrote: >> There are a lot of embedded systems that run most or all of their >> functionality >> in init, running as root:root. For these systems, supporting multiple users >> is >> not neces

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-08 Thread Lauri Kasanen
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use output_report cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --- drivers/

[PATCH 0/2] dma: at_hdmac: Fix residue calculation and add mem to mem sg support

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This series fixes the calculation of the residual bytes and adds support for memory to memory scatter-gather transfers. Torsten Fleischer (2): dma: at_hdmac: Fix calculation of the residual bytes dma: at_hdmac: Add support for memory to memory sg transfers drivers/d

[PATCH 2/2] dma: at_hdmac: Add support for memory to memory sg transfers

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This patch adds support for memory to memory scatter-gather transfers. Signed-off-by: Torsten Fleischer --- drivers/dma/at_hdmac.c | 165 + 1 file changed, 154 insertions(+), 11 deletions(-) diff --git a/drivers/dma/at_hd

[PATCH 1/2] dma: at_hdmac: Fix calculation of the residual bytes

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This patch fixes the following issues regarding to the calculation of the residue: 1. The residue is always calculated for the current transfer even if the cookie is associated to a pending transfer. 2. For scatter/gather DMA the calculation of the residue for the curren

Re: [PATCH] at86rf230: assign wait_for_completion_timeout to appropriately typed var

2015-02-08 Thread Alexander Aring
On Sun, Feb 08, 2015 at 03:55:00AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. > As rc is used here only for wait_for_completion_timeout the type is simply > changed to unsigned long. > > Signed-off-by: Nicholas Mc Guire Acked-by: Alexan

[PATCH 1/1] Staging: rtl8192u: Coding Style Improvements

2015-02-08 Thread Tolga Ceylan
Lines over 80 were corrected Signed-off-by: Tolga Ceylan --- drivers/staging/rtl8192u/r8190_rtl8256.c | 244 ++- 1 file changed, 174 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c index

Re: [PATCH 0/5] virtio 1.0 cleanups and one fix.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:51PM +1030, Rusty Russell wrote: > Hi all, > > Some minor fixes for my virtio-next tree. Michael, does > QEMU implement the (compuslory!) VIRTIO_PCI_CAP_PCI_CFG field? I'm > guessing not, since it wasn't defined in the Linux header :( Not yet, thanks for the

Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements

2015-02-08 Thread Joe Perches
On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote: > Lines over 80 were corrected [] > diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c > b/drivers/staging/rtl8192u/r8190_rtl8256.c [] > @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, > HT_CHANNEL_WIDTH Bandwidth)

Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy"

2015-02-08 Thread SF Markus Elfring
> Your proposed patch (while technically correct) hurts code clarity. How many source code readability and understanding challenges does each additional condition check cause? Can the affected place become also a bit more efficient? Regards, Markus -- To unsubscribe from this list: send the line

[PATCH] i2c: axxia: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as ret is only used for wait_for_completion_timeout here the type is simply changed unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with axm55xx_defconfig (implies CONFIG_I2C_AXXIA=y) Patch is

[PATCH] i2c: wmt: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as wait_result is only used for wait_for_completion_timeout here the type is simply changed to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with vt8500_v6_v7_defconfig (implies CONFIG_I2C_

Re: thunderbolt: Deletion of unnecessary checks before the function call "ring_free"

2015-02-08 Thread SF Markus Elfring
> Do symbols which are not exported (no EXPORT_SYMBOL_(GPL)) cause conflicts? How do you think about to mark more functions from your software module as static? > I was under the impression that those are module private. > If they are indeed private then I would prefer to not rename them. Would

Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: > In particular, the virtio header always has the u16 num_buffers field. > We define a new 'struct virtio_net_modern_hdr' for this (rather than > simply calling it 'struct virtio_net_hdr', to avoid nasty type errors > if some parts of a

Re: [PATCH 1/5] virtio: define VIRTIO_PCI_CAP_PCI_CFG in header.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:52PM +1030, Rusty Russell wrote: > This provides backdoor access to the device MMIOs, and every device should > have one. From the virtio 1.0 spec (CS03): > > 4.1.4.7.1 Device Requirements: PCI configuration access capability > > The device MUST present at least

Re: [PATCH 2/5] virtio: Don't expose legacy block features when VIRTIO_BLK_NO_LEGACY defined.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:53PM +1030, Rusty Russell wrote: > This allows modern implementations to ensure they don't use legacy > feature bits or SCSI commands (which are not used in v1.0 non-legacy). > > Signed-off-by: Rusty Russell Acked-by: Michael S. Tsirkin > --- > include/uapi/linux

Re: [PATCH 1/2] staging: unisys: remove unused variable

2015-02-08 Thread Sudip Mukherjee
On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote: > On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote: > > we were getting lots of warnings about _tempresult set but not used. > > _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY > > which was again

Re: [PATCH 4/5] virtio: Don't expose legacy config features when VIRTIO_CONFIG_NO_LEGACY defined.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:55PM +1030, Rusty Russell wrote: > The VIRTIO_F_ANY_LAYOUT and VIRTIO_F_NOTIFY_ON_EMPTY features are pre-1.0 > only. > > Signed-off-by: Rusty Russell Acked-by: Michael S. Tsirkin > --- > include/uapi/linux/virtio_config.h | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 5/5] virtio: don't require a config space on the console device.

2015-02-08 Thread Michael S. Tsirkin
On Fri, Feb 06, 2015 at 03:36:56PM +1030, Rusty Russell wrote: > Strictly, it's only needed when we have features (size or multiport). > > Signed-off-by: Rusty Russell > --- > drivers/char/virtio_console.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/dri

Re: [PATCH v8 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-02-08 Thread Wolfram Sang
> > Is it really a HW limitation? Could the driver later be extended to > > continue filling the FIFO if a certain threshold is reached? > > > > Will return -EOPNOTSUPP. This really depends on whether or not we expect > one sequence of START + SLV ADDR + DATA + STOP per i2c message. I can > late

[PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as time_left is used for wait_for_completion_timeout exclusively here its type is simply changed to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with Patch is against 3.19.0-rc7 (localver

Re: [PATCH 3/6] drivers: usb: core: hcd.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
Hello. On 2/8/2015 12:55 AM, Bas Peters wrote: This patch removes assignment of variables in if conditions, as specified in CodingStyle. Signed-off-by: Bas Peters --- drivers/usb/core/hcd.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/usb

Re: [PATCH 4/6] drivers: usb: core: hub.c: remove NULL initialization of static variables.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: NULL Rather 0-. initialization of static variables is unnecessary as GCC kindly does this for us. It's rather the C run-time library that does this. Signed-off-by: Bas Peters [...] WBR, Sergei -- To unsubscribe from this list: send the l

Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: As specified in the CodingStyle. Signed-off-by: Bas Peters --- drivers/usb/core/hub.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 82983d9..9afe8b0 100644 --- a/dr

Re: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 1:42 AM, Bas Peters wrote: Fixes errors thrown by checkpatch over a space issue and the incorrect indentation of a switch statement. Signed-off-by: Bas Peters --- drivers/usb/storage/cypress_atacb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) dif

Re: [PATCH] media:firewire:Remove unneeded function definition,avc_tuner_host2ca

2015-02-08 Thread Stefan Richter
On Feb 08 Nicholas Krause wrote: > Removes the function,avc_tuner_host2ca and the ifdef marco statements > around this function as there are no more callers of this function > and therefor no need for it's definition anymore. > > Signed-off-by: Nicholas Krause Your changelog is incorrect. If yo

[PATCH] i2c: imx: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. An appropriate variable of type unsigned long is introduced and the assignments fixed up. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with imx_v6_v7_defconfig (implies CONFIG_I2C_IMX=y) Patch is against

Re: [PATCH v12 04/20] mm: Allow page fault handlers to perform the COW

2015-02-08 Thread Yigal Korman
On Thu, Feb 5, 2015 at 11:39 PM, Matthew Wilcox wrote: > > On Thu, Feb 05, 2015 at 11:16:53AM +0200, Yigal Korman wrote: > > I have a question on a related issue (I think). > > I've noticed that for pfn-only mappings (VM_FAULT_NOPAGE) > > do_shared_fault only maps the pfn with r/o permissions. > >

Re: [PATCH 1/1] Staging: iio: Coding Style Correction

2015-02-08 Thread Jonathan Cameron
On 08/02/15 08:04, Tolga Ceylan wrote: > Indentation corrections in struct initializations and > one line over 80 characters split into two lines > > Signed-off-by: Tolga Ceylan Whilst I find it hard to be inspired by these sort of patches, you have presented the patch well and it's entirely sens

Re: [PATCH 1/1] Staging: iio: Coding style correction

2015-02-08 Thread Jonathan Cameron
On 08/02/15 07:40, Tolga Ceylan wrote: > Line over 80 characters corrected > > Signed-off-by: Tolga Ceylan Applied, again with an amended patch title to reflect the driver it is changing rather that simply the subsystem. > --- > drivers/staging/iio/meter/ade7854-i2c.c | 3 ++- > 1 file changed,

Re: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 21:32, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'unsigned int' > but the argument type is 'int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Whilst you have identified a bug, I think th

Re: [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:18, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Sorry, you were beaten to this one by Asaf V

[PATCH v4 0/5] sched_clock: Optimize and avoid deadlock during read from NMI

2015-02-08 Thread Daniel Thompson
This patchset optimizes the generic sched_clock implementation by removing branches and significantly reducing the data cache profile. It also makes it safe to call sched_clock() from NMI (or FIQ on ARM). The data cache profile of sched_clock() in the original code is somewhere between 2 and 3 (64

[PATCH v4 1/5] sched_clock: Match scope of read and write seqcounts

2015-02-08 Thread Daniel Thompson
Currently the scope of the raw_write_seqcount_begin/end in sched_clock_register far exceeds the scope of the read section in sched_clock. This gives the impression of safety during cursory review but achieves little. Note that this is likely to be a latent issue at present because sched_clock_regi

Re: [PATCH] staging: iio: light: tsl2583: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:19, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist This one is already fixed as well I'm afraid

[PATCH v4 3/5] sched_clock: Remove suspend from clock_read_data

2015-02-08 Thread Daniel Thompson
Currently cd.read_data.suspended is read by the hotpath function sched_clock(). This variable need not be accessed on the hotpath. In fact, once it is removed, we can remove the conditional branches from sched_clock() and install a dummy read_sched_clock function to suspend the clock. The new mast

[PATCH v4 4/5] sched_clock: Remove redundant notrace from update function

2015-02-08 Thread Daniel Thompson
Currently update_sched_clock() is marked as notrace but this function is not called by ftrace. This is trivially fixed by removing the mark up. Signed-off-by: Daniel Thompson --- kernel/time/sched_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/sched_clock

Re: [PATCH] staging: iio: magnetometer: hmc5843_core: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:21, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist This one is fixed to I'm afraid. Very bad l

Re: [PATCH] staging: iio: light: tsl2x7x_core: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:20, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Another one with a fix already in place. > -

[PATCH v4 5/5] sched_clock: Avoid deadlock during read from NMI

2015-02-08 Thread Daniel Thompson
Currently it is possible for an NMI (or FIQ on ARM) to come in and read sched_clock() whilst update_sched_clock() has locked the seqcount for writing. This results in the NMI handler locking up when it calls raw_read_seqcount_begin(). This patch fixes the NMI safety issues by providing banked cloc

[PATCH v4 2/5] sched_clock: Optimize cache line usage

2015-02-08 Thread Daniel Thompson
Currently sched_clock(), a very hot code path, is not optimized to minimise its cache profile. In particular: 1. cd is not cacheline_aligned, 2. struct clock_data does not distinguish between hotpath and coldpath data, reducing locality of reference in the hotpath, 3. Some hotpath

Re: [PATCH] staging: iio: resolver: ad2s1210: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:22, Rickard Strandqvist wrote: > Wrong type in printf format string, requires 'int' > but the argument type is 'unsigned int' > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist Finally one I don't already have a fix in pl

Re: [PATCH] staging: iio: adc: mxs-lradc: Change type in printf format string

2015-02-08 Thread Jonathan Cameron
On 27/01/15 22:59, Marek Vasut wrote: > On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote: >> Wrong type in printf format string, requires 'int' >> but the argument type is 'unsigned int' >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off

Re: [PATCH v3 0/4] sched_clock: Optimize and avoid deadlock during read from NMI

2015-02-08 Thread Daniel Thompson
On 05/02/15 17:05, Daniel Thompson wrote: > On 05/02/15 00:50, Stephen Boyd wrote: >> On 01/30, Daniel Thompson wrote: >>> This patchset optimizes the generic sched_clock implementation to >>> significantly reduce the data cache profile. It also makes it safe to call >>> sched_clock() from NMI (or

[PATCH v3] ext4: fix indirect punch hole corruption

2015-02-08 Thread Omar Sandoval
Commit 4f579ae7de56 (ext4: fix punch hole on files with indirect mapping) rewrote FALLOC_FL_PUNCH_HOLE for ext4 files with indirect mapping. However, there are a bugs in a few cases. In the case where the punch happens within one level of indirection, we expect the start and end shared branches to

Re: 1e918876 breaks r8169 (linux-3.18+)

2015-02-08 Thread Holger Hoffstätte
On Fri, 06 Feb 2015 15:04:50 +0100, Tomas Szepe wrote: > Unfortunately, I have to take this back. I made the conclusion too early. > The problem appears with this patch applied, too, only perhaps later and > with a different frequency pattern. +1 can confirm - I also see the stack trace in quest

Re: [PATCH v3] net: bluetooth: hci_sock: Use 'const u32 *' instead of 'void *' for 2nd parameter of hci_test_bit()

2015-02-08 Thread Chen Gang S
On 2/8/15 08:00, Chen Gang S wrote: > On 2/8/15 03:52, Joe Perches wrote: >> On Sat, 2015-02-07 at 21:24 +0800, Chen Gang S wrote: >>> hci_test_bit() does not modify 2nd parameter, so it is better to let it >>> be constant, or may cause build warning. The related warning (with >>> allmodconfig unde

[PATCH] [Bugfix] x86/boot/compressed: Fix serial I/O during compressed boot

2015-02-08 Thread Alexander Kuleshov
Previously it used early_serial_base from the arch/x86/boot/compressed/early_serial_console.c, and it's zero everytime, so serial I/O didn't work/print anything in the kernel decompressing code. Let's define early_serial_base in the arch/x86/boot/early_serial_console.c and make it extern, so code

[PATCH 1/2] i2c: nomadik: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as timeout is used for wait_for_completion_timeout exclusively here its type is simply changed to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with multi_v5_defconfig (implies CONFIG_I2C_NOM

[PATCH 2/2] i2c: nomadik: match status to return type of read_i2c

2015-02-08 Thread Nicholas Mc Guire
return type of read_i2c() is int not u32. As the assignments to status are consistent with int here its type is changed to int. Signed-off-by: Nicholas Mc Guire --- This patch depends on "[PATCH 1/2] i2c: nomadik: match return type of wait_for_completion_timeout" Patch was only compile tested

[PATCH] i2c: cadence: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as ret is only used for wait_for_completion_timeout anyway the type is simply changed to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with multi_v7_defconfig (implies CONFIG_I2C_CADENCE=y)

BENEFICIAL TRANSACTION

2015-02-08 Thread DENNIS WALKER ATTORNEYS
View the file for details of the inheritance. Dennis Walker Esq. +27 78 3449667 INHERITANCE.rtf Description: MS-Word document

[PATCH] acpi: Remove unneeded nested #ifdef

2015-02-08 Thread Andreas Ruprecht
In commit 5de21bb998b8 ("ACPI / PM: Drop CONFIG_PM_RUNTIME from the ACPI core"), all occurrences of CONFIG_PM_RUNTIME were replaced with CONFIG_PM. This created the following structure of #ifdef blocks in the code: [...] #ifdef CONFIG_PM #ifdef CONFIG_PM /* always on / undead */ #ifdef CONFIG

DRM edid logspam even with loading edid data from file

2015-02-08 Thread Sander Eikelenboom
Hi, I have a monitor connected via a KVM to a radeon card (ATI RV620 LE [Radeon HD 3450]), since it's a server i previously used "nomodeset", however i just tried using DRM/KMS but my logs get spammed with messages about invalid EDID. I have tried to circumvent this by loading the edid data from

Re: [PATCH] [Bugfix] x86/boot/compressed: Fix serial I/O during compressed boot

2015-02-08 Thread Alexander Kuleshov
rejected 2015-02-08 18:33 GMT+06:00 Alexander Kuleshov : > Previously it used early_serial_base from the > arch/x86/boot/compressed/early_serial_console.c, and it's zero everytime, > so serial I/O didn't work/print anything in the kernel decompressing code. > > Let's define early_serial_base in th

Re: [PATCH] i2c: ismt: fix type of return var of wait_for_completion_timeout

2015-02-08 Thread Neil Horman
On Sun, Feb 08, 2015 at 03:03:30AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. As > ret is in used for other calls a new appropriately typed variable timeout > is added to handle wait_for_completion_timeout > > Signed-off-by: Nicholas Mc

Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy"

2015-02-08 Thread Mike Snitzer
On Sun, Feb 8, 2015 at 4:55 AM, SF Markus Elfring wrote: >> Your proposed patch (while technically correct) hurts code clarity. > > How many source code readability and understanding challenges does each > additional condition check cause? Please don't make a mountain out of a mole hill in an att

[PATCH v3 0/3] lib: find_*_bit reimplementation

2015-02-08 Thread Yury Norov
This patchset does rework find_bit functions family to achieve better performance, and decrease size of text. All rework is done in patch 1. Patches 2 and 3 are about code moving and renaming. It was boot-tested on x86_64 and MIPS (big-endian) machines. Performance tests were ran on userspace with

[PATCH v3 3/3] lib: rename lib/find_next_bit.c to lib/find_bit.c

2015-02-08 Thread Yury Norov
This file contains implementation for all find_*_bit{,_le} So giving it more generic name looks reasonable. Signed-off-by: Yury Norov --- lib/Makefile| 2 +- lib/{find_next_bit.c => find_bit.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename lib/{find_next_bit

[PATCH v3 2/3] lib: move find_last_bit to lib/find_next_bit.c

2015-02-08 Thread Yury Norov
Currently all 'find_*_bit' family is located in lib/find_next_bit.c, except 'find_last_bit', which is in lib/find_last_bit.c. It seems, there's no major benefit to have it separated. Signed-off-by: Yury Norov --- lib/Makefile| 2 +- lib/find_last_bit.c | 35 -

[PATCH v3 1/3] lib: find_*_bit reimplementation

2015-02-08 Thread Yury Norov
New implementations takes less space in source file (see diffstat) and in object. For me it's 710 vs 453 bytes of text. It also shows better performance. Signed-off-by: Yury Norov --- lib/find_last_bit.c | 30 ++ lib/find_next_bit.c | 275

Re: [PATCH 6/6 v2] perf: Make perf aware of tracefs

2015-02-08 Thread Namhyung Kim
Hi Steve, On Mon, Feb 02, 2015 at 02:35:07PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > As tracefs may be mounted instead of debugfs to get to the event directories, > have perf know about tracefs, and use that file system over debugfs if it > is present. > > Signed-off

Re: [PATCH] i2c: axxia: match return type of wait_for_completion_timeout

2015-02-08 Thread Wolfram Sang
On Sun, Feb 08, 2015 at 05:31:25AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. as ret > is only used for wait_for_completion_timeout here the type is simply changed > unsigned long. > > Signed-off-by: Nicholas Mc Guire > --- > > Patch wa

Re: [PATCH v2 1/2] sched/rt: Check to push the task when changing its affinity

2015-02-08 Thread Xunlei Pang
Hi Steve, On 7 February 2015 at 05:09, Steven Rostedt wrote: > On Thu, 5 Feb 2015 23:59:33 +0800 >> + >> + if (task_running(rq, p) && >> + cpumask_test_cpu(task_cpu(p), new_mask) && > > Why the check for task_cpu being in new_mask? If the current cpu of this task is

Re: [PATCH v3] pinctrl: exynos: Add support for Exynos5433

2015-02-08 Thread Tomasz Figa
Hi, 2015-01-29 18:48 GMT+09:00 Linus Walleij : > On Wed, Jan 21, 2015 at 7:43 AM, Chanwoo Choi wrote: > >> This patch adds driver data for Exynos5433 SoC. Exynos5433 includes 228 >> multi- >> functional input/output port pins and 135 memory port pins. There are 41 >> general >> port groups and

[PATCH] spi: bcm53xx: use msecs_to_jiffies for conversion

2015-02-08 Thread Nicholas Mc Guire
Converting milliseconds to jiffies by "val * HZ / 1000" is technically ok but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is only an API consolidation and should make things more readable Signed-off-by: Nicholas Mc Guire --- Patch was compile-test

Re: [PATCH v2 1/2] sched/rt: Check to push the task when changing its affinity

2015-02-08 Thread Xunlei Pang
On 8 February 2015 at 22:55, Xunlei Pang wrote: > Hi Steve, > > On 7 February 2015 at 05:09, Steven Rostedt wrote: >> On Thu, 5 Feb 2015 23:59:33 +0800 >> >> if (task_running(rq, p)) { >> if (cpumask_test_cpu() && cpupri_find()) { >> } >> } else {

Re: [RFC PATCH 3/8] kmod - teach call_usermodehelper() to use a namespace

2015-02-08 Thread Jeff Layton
On Sun, 08 Feb 2015 11:07:32 +0800 Ian Kent wrote: > On Fri, 2015-02-06 at 07:08 -0500, Jeff Layton wrote: > > On Thu, 05 Feb 2015 10:34:11 +0800 > > Ian Kent wrote: > > > > > The call_usermodehelper() function executes all binaries in the > > > global "init" root context. This doesn't allow a

[PATCH] usb: phy: am335x-control: check return value of bus_find_device

2015-02-08 Thread David Dueck
This fixes a potential null pointer dereference. Signed-off-by: David Dueck --- drivers/usb/phy/phy-am335x-control.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c index 403fab7..7b3035f 100644 --- a/drivers/usb

[PATCH] CRIS: enable GPIOLIB

2015-02-08 Thread Rabin Vincent
Enable GPIOLIB on CRIS so that we can use the generic GPIO APIs. Signed-off-by: Rabin Vincent --- arch/cris/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig index 52731e2..8474c66 100644 --- a/arch/cris/Kconfig +++ b/arch/cris/Kconfig @@ -52,6 +52

[PATCH 1/4] CRIS: add device tree support

2015-02-08 Thread Rabin Vincent
Add support for booting CRIS with a built-in device tree. Signed-off-by: Rabin Vincent --- arch/cris/Kconfig | 6 ++ arch/cris/Makefile| 4 arch/cris/boot/dts/Makefile | 6 ++ arch/cris/kernel/Makefile | 1 + arch/cris/kernel/devicetree.c | 14 +

[PATCH 4/4] CRIS: add Axis 88 board device tree

2015-02-08 Thread Rabin Vincent
Add a minimal device tree for the ETRAX FS SoC and the Axis 88 developer board. Signed-off-by: Rabin Vincent --- arch/cris/boot/dts/dev88.dts| 18 ++ arch/cris/boot/dts/etraxfs.dtsi | 38 ++ 2 files changed, 56 insertions(+) create mode 10

[PATCH 3/4] CRIS: document CRISv32 intc bindings

2015-02-08 Thread Rabin Vincent
Add the DT bindings documentation for the CRISV32 interrupt controller. Signed-off-by: Rabin Vincent --- .../interrupt-controller/axis,crisv32-intc.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ax

[PATCH 2/4] CRISv32: add irq domains support

2015-02-08 Thread Rabin Vincent
Add support for IRQ domains to the CRISv32 interrupt controller. Signed-off-by: Rabin Vincent --- arch/cris/Kconfig | 1 + arch/cris/arch-v32/kernel/irq.c | 28 +--- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/arch/cris/Kconfig b/arch/cr

Re: [PATCH] lib/int_sqrt.c: Optimize square root function

2015-02-08 Thread Anshul Garg
Dear Mr. linus, Thanks for quick replies. Yes performance numbers are not conclusive enough. So its better to discard this patch as of now. I will try to explore more in this area. Thanks & regards Anshul Garg On Fri, Feb 6, 2015 at 1:07 AM, Linus Torvalds wrote: > On Thu, Feb 5, 2015 at 1

[PATCH v2] i2c: axxia: fixup return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. The return variable is renamed to reflect its use and the type adjusted to unsigned long. Signed-off-by: Nicholas Mc Guire --- v2: variable renamed rather than just changing the type as suggested by Wolfram Sang . Further t

Re: [PATCH] i2c: axxia: match return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
On Sun, 08 Feb 2015, Wolfram Sang wrote: > On Sun, Feb 08, 2015 at 05:31:25AM -0500, Nicholas Mc Guire wrote: > > return type of wait_for_completion_timeout is unsigned long not int. as ret > > is only used for wait_for_completion_timeout here the type is simply changed > > unsigned long. > > > >

Re: [PATCH] usb: gadget: fix sparse warnings

2015-02-08 Thread Laurent Pinchart
Hi Felipe, On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote: > On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote: > > Hi Prabhakar, > > > > Thank you for the patch. > > > > On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote: > > > From: "Lad, Prabhakar" > > > > >

Re: [PATCH v5 1/3] irqchip: vf610-mscm-ir: add support for MSCM interrupt router

2015-02-08 Thread Stefan Agner
On 2015-02-07 11:56, Paul Bolle wrote: > On Fri, 2015-02-06 at 20:51 +0100, Stefan Agner wrote: >> This adds support for Vybrid's interrupt router. On VF6xx models, >> almost all peripherals can be used by either of the two CPU's, >> the Cortex-A5 or the Cortex-M4. The interrupt router routes the >

[PATCH v3 1/2] sched/rt: Check to push the task when changing its affinity

2015-02-08 Thread Xunlei Pang
We may suffer from extra rt overload rq due to the affinity, so when the affinity of any runnable rt task is changed, we should check to trigger balancing, otherwise it will cause some unnecessary delayed real-time response. Unfortunately, current RT global scheduler doesn't trigger anything. For

[PATCH v3 2/2] sched/rt: Add check_preempt_equal_prio() logic in pick_next_task_rt()

2015-02-08 Thread Xunlei Pang
check_preempt_curr() doesn't call sched_class::check_preempt_curr when the class of current is a higher level. So if there is a DL task running when doing this for RT, check_preempt_equal_prio() will definitely miss, which may result in some response latency for this RT task if it is pinned and the

Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy"

2015-02-08 Thread SF Markus Elfring
> FYI, I did stage your other patch for 3.20, see: > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-for-3.20&id=d0ce7e911c97c7c6df1081dcedfefced82a0c6bf Thanks for your acceptance of the suggested clean-up around vfree() function calls at least. Additional sou

Re: [PATCH] usb: phy: am335x-control: check return value of bus_find_device

2015-02-08 Thread Sebastian Andrzej Siewior
On 02/08/2015 04:29 PM, David Dueck wrote: > This fixes a potential null pointer dereference. > > Signed-off-by: David Dueck Acked-by: Sebastian Andrzej Siewior Fixes: d4332013919a ("driver core: dev_get_drvdata: Don't check for NULL dev") Greg, this is a regression since d43320139 ("driver co

[PATCH] i2c: at91: fixup return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
Return type of wait_for_completion_timeout is unsigned long not int. This patch adds a timeout variable of appropriate type and fixes up the assignment. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with at91_dt_defconfig (implies CONFIG_I2C_AT91=y) Patch is against 3.19.0-

[V3 PATCH 0/2] Introduce ACPI support for ahci_platform driver

2015-02-08 Thread Suravee Suthikulpanit
This patch series introduce ACPI support for non-PCI AHCI platform driver. Existing ACPI support for AHCI assumes the device controller is a PCI device. Also, since there is no ACPI _HID/_CID for generic AHCI controller, the driver could not use them for matching devices. Therefore, this patch int

[V3 PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device matching

2015-02-08 Thread Suravee Suthikulpanit
Device drivers typically use ACPI _HIDs/_CIDs listed in struct device_driver acpi_match_table to match devices. However, for generic drivers, we do not want to list _HID for all supported devices, and some device classes do not have _CID (e.g. SATA, USB). Instead, we can leverage ACPI _CLS, which s

Re: [PATCH v9 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-02-08 Thread Wolfram Sang
On Sat, Feb 07, 2015 at 09:25:25PM -0800, Ray Jui wrote: > Add initial support to the Broadcom iProc I2C controller found in the > iProc family of SoCs. > > The iProc I2C controller has separate internal TX and RX FIFOs, each has > a size of 64 bytes. The iProc I2C controller supports two bus spee

Re: [V2 PATCH 1/2] ACPI / scan: Add support for ACPI _CLS device matching

2015-02-08 Thread Suravee Suthikulpanit
Thank you for review comment. I am sending out V3 with your suggestions. Suravee On 01/22/2015 06:40 AM, Rafael J. Wysocki wrote: On Monday, January 05, 2015 03:11:14 PM Suravee Suthikulpanit wrote: Device drivers typically use ACPI _HIDs/_CIDs listed in struct device_driver acpi_match_table

[V3 PATCH 2/2] ata: ahci_platform: Add ACPI _CLS matching

2015-02-08 Thread Suravee Suthikulpanit
This patch adds ACPI supports for AHCI platform driver, which uses _CLS method to match the device. The following is an example of ASL structure in DSDT for a SATA controller, which contains _CLS package to be matched by the ahci_platform driver: Device (AHC0) // AHCI Controller { Name(_H

Предлагаю высококачественный кофе от швейцарского производителя

2015-02-08 Thread Степанова Злата
Предлагаем высококачественный кофе от швейцарского производителя http://bit.ly/1xqBJAo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read th

[PATCH] mtd: nand: gpmi: fixup return type of wait_for_completion_timeout

2015-02-08 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. The return variable is renamed to reflect its use and the type adjusted to unsigned long. Signed-off-by: Nicholas Mc Guire --- Patch was only compile tested with imx_v6_v7_defconfig (implies CONFIG_MTD_NAND_GPMI_NAND=y) Patch

Re: [PATCH] i2c: cadence: match return type of wait_for_completion_timeout

2015-02-08 Thread Sören Brinkmann
On Sun, 2015-02-08 at 07:55AM -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. as > ret is only used for wait_for_completion_timeout anyway the type is simply > changed to unsigned long. > > Signed-off-by: Nicholas Mc Guire Reviewed-by: Sören

Re: [PATCH] sb_edac: Fix detection on SNB machines

2015-02-08 Thread Andy Lutomirski
On Feb 5, 2015 4:37 AM, "Borislav Petkov" wrote: > > On Thu, Feb 05, 2015 at 12:50:35PM +0100, Borislav Petkov wrote: > > From: Borislav Petkov > > > > Commit 50d1bb93672f ("sb_edac: add support for Haswell based systems") > > broke the driver on my SNB box with PCI ID 0x3ca0: > > > > 3f:0e.0 Sys

  1   2   3   >