Re: f_op->read seems to be always NULL since Linux 4.1

2015-06-28 Thread Richard Weinberger
Am 28.06.2015 um 08:36 schrieb Andreas Hartmann: > On Sat, Jun 27, 2015 at 8:10 PM, Richard Weinberger wrote: >> On Sat, Jun 27, 2015 at 7:32 PM, Andreas Hartmann >> wrote: > [...] >> See __vfs_read(). >> Your module most not rely on such internals. > > Thanks for your hint to the function which

Re: [!GIT PULL] kdbus for 4.2

2015-06-28 Thread Richard Weinberger
On Fri, Jun 26, 2015 at 9:36 PM, Tom Gundersen wrote: > On Fri, Jun 26, 2015 at 9:33 PM, Andy Lutomirski wrote: >> What's a good distro on which to poke at a full running system? > > Fedora Rawhide is probably currently your best bet. > >> Fedora Rawhide seems to still build systemd with --disabl

Re: f_op->read seems to be always NULL since Linux 4.1

2015-06-28 Thread Al Viro
On Sun, Jun 28, 2015 at 08:36:18AM +0200, Andreas Hartmann wrote: > On Sat, Jun 27, 2015 at 8:10 PM, Richard Weinberger wrote: > >On Sat, Jun 27, 2015 at 7:32 PM, Andreas Hartmann > > wrote: > [...] > >See __vfs_read(). > >Your module most not rely on such internals. > > Thanks for your hint to th

[PATCH] drm/amdgpu: Delete an unnecessary check before the function call "kfree"

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 10:27:35 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu

Re: [PATCH 3.10 14/46] d_walk() might skip too much

2015-06-28 Thread Jari Ruusu
On 6/27/15, Greg Kroah-Hartman wrote: > That's insane, and not how my tools work :( I asked you to do that apply-patch-two-more-times thing because I assumed that you trust Al Viro's Signed-off-by more than you trust my Signed-off-by. > Can you provide the needed backport? If it was in an earli

[PATCH] nvdimm: Fix return value of nvdimm_bus_init() if class_create() fails

2015-06-28 Thread Axel Lin
Return proper error if class_create() fails. Signed-off-by: Axel Lin --- drivers/nvdimm/bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index ca80270..f6f6a91 100644 --- a/drivers/nvdimm/bus.c +++ b/drivers/nvdimm/bus.c @@

[PATCH] ALSA: hda: Delete an unnecessary check before the function call "snd_info_free_entry"

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 11:15:28 +0200 The snd_info_free_entry() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

atomic64 on 32-bit vs 64-bit (was: Re: Add virtio gpu driver.)

2015-06-28 Thread Geert Uytterhoeven
On Fri, Jun 26, 2015 at 10:52 PM, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/linus/;a=commit;h=dc5698e80cf724770283e10414054662bdf6ccfa > Commit: dc5698e80cf724770283e10414054662bdf6ccfa > Parent: 16e3247da7f71f8c31f4330f739f6192a00c8b51 > Refname:refs/head

Re: [PATCH] SCSI-OSD: Delete an unnecessary check before the function call "put_disk"

2015-06-28 Thread Boaz Harrosh
On 06/24/2015 05:16 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Jun 2015 16:06:21 +0200 > > The put_disk() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coc

[PATCH] clk: stm32: Fix out-by-one error path in the index lookup

2015-06-28 Thread Daniel Thompson
If stm32f4_rcc_lookup() is called with primary == 0 and secondary == 192 then it will read beyond the end of the table array due to an out-by-one error in the range check. In addition to the fixing the inequality we also modify the r.h.s. to make it even more explicit that we are comparing against

[PATCH] PM-wakeup: Delete unnecessary checks before two function calls

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 12:14:43 +0200 The functions dev_pm_disarm_wake_irq() and wakeup_source_unregister() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software

Re: [PATCH] drbd: Deletion of an unnecessary check before the function call "lc_destroy"

2015-06-28 Thread SF Markus Elfring
> From: Markus Elfring > Date: Wed, 19 Nov 2014 13:33:32 +0100 > > The lc_destroy() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus El

Re: [PATCH] block-rsxx: Deletion of an unnecessary check before the function call "vfree"

2015-06-28 Thread SF Markus Elfring
> From: Markus Elfring > Date: Mon, 1 Dec 2014 19:19:25 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/block

Re: [PATCH] block-skd: Deletion of an unnecessary check before the function call "kfree"

2015-06-28 Thread SF Markus Elfring
> From: Markus Elfring > Date: Mon, 1 Dec 2014 18:15:46 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring

[PATCH] SCSI: dtc: Fixed a brace issue on return 0

2015-06-28 Thread Rudhresh
From: rudhresh Return is not a function so parenthesis is not required Signed-off-by: Rudhresh --- drivers/scsi/dtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c index 4c74c7b..c793ecf 100644 --- a/drivers/scsi/dtc.c +++ b/dri

Re: [PATCH] HID-picoLCD: Deletion of unnecessary checks before three function calls

2015-06-28 Thread SF Markus Elfring
> From: Markus Elfring > Date: Wed, 19 Nov 2014 18:30:22 +0100 > > The functions backlight_device_unregister(), lcd_device_unregister() and > rc_unregister_device() test whether their argument is NULL and then > return immediately. Thus the test around the call is not needed. > > This issue was

Re: [PATCH v2] backlight: lp8788: Deletion of a check before backlight_device_unregister()

2015-06-28 Thread SF Markus Elfring
> From: Markus Elfring > > The backlight_device_unregister() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers

[PATCH] video: fbdev: omap2: displays-new: Delete a check before backlight_device_unregister()

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 14:30:17 +0200 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-28 Thread Maciej S. Szmigiero
W dniu 28.06.2015 06:27, Timur Tabi pisze: > Maciej S. Szmigiero wrote: >> +if (newbinding && fsl_ssi_is_ac97(ssi_private)) { > > Is the "newbinding" necessary? I thought only the original PowerPC device > trees were the only one that have the old binding, and they never supported > AC97.

[PATCH] USB-mxuport: Delete an unnecessary check before the function call "release_firmware"

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 14:59:04 +0200 The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead

2015-06-28 Thread Mikulas Patocka
From: Joe Perches Date: Thu, 26 Mar 2015 20:47:10 -0700 Removing unnecessary static buffers is good. Use the vsprintf %pV extension instead. Signed-off-by: Joe Perches Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org # v2.6.36+ --- fs/hpfs/super.c | 11 +++ 1 file chan

[PATCH] hpfs: kstrdup() out of memory handling

2015-06-28 Thread Mikulas Patocka
From: Sanidhya Kashyap Date: Sat, 21 Mar 2015 12:57:50 -0400 There is a possibility of nothing being allocated to the new_opts in case of memory pressure, therefore return ENOMEM for such case. Signed-off-by: Sanidhya Kashyap Signed-off-by: Mikulas Patocka Cc: sta...@vger.kernel.org --- fs/h

[PATCH] hpfs: add fstrim support

2015-06-28 Thread Mikulas Patocka
This patch adds support for fstrim to the HPFS filesystem. Signed-off-by: Mikulas Patocka --- fs/hpfs/alloc.c | 95 ++ fs/hpfs/dir.c |4 ++ fs/hpfs/file.c|4 ++ fs/hpfs/hpfs_fn.h |7 +++ fs/hpfs/super.c | 35 +++

[PATCH RFC 4/5] kdbus: handle WARN_ON cases properly when decrementing quota

2015-06-28 Thread Sergei Zviagintsev
If we spotted inconsistency, fix it by setting values to zero. Signed-off-by: Sergei Zviagintsev --- ipc/kdbus/connection.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index 1d44e280eff0..12e32de310f5 100644 --- a

[PATCH] hpfs: Remove unessary cast

2015-06-28 Thread Mikulas Patocka
From: Firo Yang Date: Thu, 23 Apr 2015 17:28:45 +0800 Avoid a pointless kmem_cache_alloc() return value cast in fs/hpfs/super.c::hpfs_alloc_inode() Signed-off-by: Firo Yang Signed-off-by: Mikulas Patocka --- fs/hpfs/super.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linu

[PATCH RFC 2/5] kdbus: use standard kernel types in struct kdbus_quota

2015-06-28 Thread Sergei Zviagintsev
uint{8,16,32}_t -> u{8,16,32} Signed-off-by: Sergei Zviagintsev --- ipc/kdbus/connection.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index df072487e23c..af044f93c14f 100644 --- a/ipc/kdbus/connection.c +++ b/ipc/kdbu

[PATCH RFC 3/5] kdbus: do explicit overflow check in kdbus_conn_quota_inc()

2015-06-28 Thread Sergei Zviagintsev
Replace the use of max() with explicit and obvious overflow check. Signed-off-by: Sergei Zviagintsev --- ipc/kdbus/connection.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index af044f93c14f..1d44e280eff0 100644 --- a/

[PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc()

2015-06-28 Thread Sergei Zviagintsev
Signed-off-by: Sergei Zviagintsev --- ipc/kdbus/connection.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c index 9993753d11de..df072487e23c 100644 --- a/ipc/kdbus/connection.c +++ b/ipc/kdbus/connection.c @@ -646,7 +646,7 @

[PATCH RFC 0/5] kdbus: minor quota code improvements

2015-06-28 Thread Sergei Zviagintsev
Hi, Main points here are to use conventional types, rewrite tests in obvious way, add couple of new WARN_ONs and do a bit more work in the others. Keeping in mind the number of mistakes I made while preparing this patchset, I decided to mark it as RFC :) I'd appreciate any feedback on these. Se

[PATCH RFC 5/5] kdbus: improve tests on incrementing quota

2015-06-28 Thread Sergei Zviagintsev
1) Rewrite quota->memory + memory > U32_MAX as U32_MAX - quota->memory < memory and provide the comment on why we need that check. We have no overflow issue in the original expression when size_t is 32-bit because the previous one (available - quota->memory < me

[GIT PULL] UML updates for 4.2

2015-06-28 Thread Richard Weinberger
Linus, the following changes since commit ba155e2d21f6bf05de86a78dbe5bfd8757604a65: Linux 4.1-rc5 (2015-05-24 18:22:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-4.2-rc1 for you to fetch changes up to da028d5e5463dabb6e

Re: [PATCH] ASoC: fsl_ssi: fix AC'97 mode

2015-06-28 Thread Timur Tabi
Maciej S. Szmigiero wrote: If there isn't going to be new platforms added with old bindings then this won't be needed - I'll remove it. I would love it if someone would port those original device trees to the new binding, so that we can get rid of the old one. But we should definitely not a

[PATCH 1/6] ASoC: fsl_ssi: enable IPG clock during AC'97 reg access

2015-06-28 Thread Maciej S. Szmigiero
IPG clock have to be enabled during AC'97 CODEC register access in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index c7647

[PATCH 2/6] ASoC: fsl_ssi: AC'97 DAI driver needs probe method too

2015-06-28 Thread Maciej S. Szmigiero
AC'97 DAI driver struct need the same probe method as I2S one to setup DMA params in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 9c46c7

[PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-06-28 Thread Maciej S. Szmigiero
AC'97 bus can support asymmetric playback/capture rates so enable them in this case in fsl_ssi driver. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 2

[PATCH 4/6] ASoC: fsl_ssi: add AC'97 ops setting check and cleanup

2015-06-28 Thread Maciej S. Szmigiero
Check whether setting AC'97 ops succeeded and clean them on removal so the fsl_ssi driver can be reloaded. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.

[PATCH 5/6] ASoC: fsl_ssi: instantiate AC'97 CODEC

2015-06-28 Thread Maciej S. Szmigiero
Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 0b4fcd9..e79dc16 100644 --- a/so

[PATCH 6/6] ASoC: fsl_ssi: adjust set DAI format in AC'97 mode

2015-06-28 Thread Maciej S. Szmigiero
Adjust set DAI format function in fsl_ssi driver so it doesn't fail and clears RXDIR in AC'97 mode. Signed-off-by: Maciej Szmigiero --- sound/soc/fsl/fsl_ssi.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-06-28 Thread Timur Tabi
Maciej S. Szmigiero wrote: /* Are the RX and the TX clocks locked? */ if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { - ssi_private->cpu_dai_drv.symmetric_rates = 1; + if (!fsl_ssi_is_ac97(ssi_private)) + ssi_private->cp

[PATCH] iommu/arm-smmu: Delete an unnecessary check before the function call "free_io_pgtable_ops"

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 15:55:11 +0200 The free_io_pgtable_ops() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --

Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr

2015-06-28 Thread Prarit Bhargava
On 06/27/2015 11:52 AM, Andy Lutomirski wrote: > On Sat, Jun 27, 2015 at 1:39 AM, Ingo Molnar wrote: >> >> * Ingo Molnar wrote: >> >>> So what's wrong with exposing them as a simplified PMU driver? >>> >>> That way we only expose the ones we want to - plus tooling can use all the >>> rich >>>

Re: [PATCH v7] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2015-06-28 Thread Vinod Koul
On Sat, Jun 27, 2015 at 05:44:38PM +0300, Nicolae Rosia wrote: > On Sat, Jun 27, 2015 at 5:40 PM, Vinod Koul wrote: > [...] > >> Please let me know if you are not clear. > > No sorry am not... > > > > I asked how the device address in configured. For both MM2S S2MM you are > > using sg for memory

[PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 16:42:04 +0200 The functions phy_exit() and phy_power_off() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

Re: [all better] Re: regression: massive trouble with fpu rework

2015-06-28 Thread Henrique de Moraes Holschuh
On Sun, 28 Jun 2015, Mike Galbraith wrote: > > > > > BIOS setting "Limit CPUID Maximum" upsets new fpu code mightily. > > > > Well, it is supposed to disable CPUID levels >= 0x04. This thing should > > *NEVER* be enabled, the last operating system that required it to be enabled > > was Windows 98

Re: [PATCH v7] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2015-06-28 Thread Nicolae Rosia
HI, On Sun, Jun 28, 2015 at 5:45 PM, Vinod Koul wrote: [...] >> > I asked how the device address in configured. For both MM2S S2MM you are >> > using sg for memory address, where are you getting device adress, are you >> > assuming/hardcoding or getting somehow, if so how? >> As the name says, one

Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr

2015-06-28 Thread Henrique de Moraes Holschuh
On Sun, 28 Jun 2015, Prarit Bhargava wrote: > Is it easier to blacklist MSRs we don't want generally exposed, or only expose > the ones that we think are safe? That's sort of a devil's advocate sort of > question ;) and I'm wondering what the shorter list is. The only way to make MSR access safe

Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr

2015-06-28 Thread Henrique de Moraes Holschuh
On Fri, 26 Jun 2015, Prarit Bhargava wrote: > > The proper way to do this is to write a driver to only expose the MSRs > > that the user tools need, and nothing else. > > Will do -- At least I got everyone's attention with this :). IMHO we need both a new driver that exposes semanthic functionali

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/27/2015 08:51 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. kill_pgrp() obtains tasklist_lock, so I don't see an unsafe deref. > Signed-

Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.

2015-06-28 Thread Jörg Otte
2015-06-26 16:28 GMT+02:00 Jörg Otte : > 2015-06-26 12:03 GMT+02:00 Jörg Otte : >> 2015-06-26 11:37 GMT+02:00 Marcel Holtmann : >>> Hi Joerg, >>> Bluetooth is inoperable in current Linus tree and the first bad commit is: 835a6a2f8603237a3e6cded5a6765090ecb06ea5 is the first bad

Re: [all better] Re: regression: massive trouble with fpu rework

2015-06-28 Thread Mike Galbraith
On Sun, 2015-06-28 at 12:06 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 28 Jun 2015, Mike Galbraith wrote: > > > > > > BIOS setting "Limit CPUID Maximum" upsets new fpu code mightily. > > > > > > Well, it is supposed to disable CPUID levels >= 0x04. This thing should > > > *NEVER* be enab

Re: [PATCH v2 2/2] tty: check tcsetpgrp p is a process group

2015-06-28 Thread Peter Hurley
On 06/27/2015 08:51 PM, Patrick Donnelly wrote: > This fixes a bug where a process can set the foreground process group to its > pid even if its pid is not a valid pgrp. > > Signed-off-by: Patrick Donnelly > --- > drivers/tty/tty_io.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/

Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.

2015-06-28 Thread Alexey Dobriyan
On Sun, Jun 28, 2015 at 05:36:04PM +0200, Jörg Otte wrote: > 2015-06-26 16:28 GMT+02:00 Jörg Otte : > > 2015-06-26 12:03 GMT+02:00 Jörg Otte : > >> 2015-06-26 11:37 GMT+02:00 Marcel Holtmann : > >>> Hi Joerg, > >>> > Bluetooth is inoperable in current Linus tree and the > first bad commit

Re: [RFC PATCH 0/3] restartable sequences: fast user-space percpu critical sections

2015-06-28 Thread Mathieu Desnoyers
- On Jun 27, 2015, at 12:25 PM, Andy Lutomirski l...@amacapital.net wrote: > Let me try to summarize some of the approaches with their pros and cons: > I can try summarizing a desiderata that I gather from this thread so far: - *very fast* accesses for per-cpu push/pop, per-cpu lock acqui

[PATCH 0/2] vfio: powerpc/spapr: Deletion of an unnecessary check

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Delete an unnecessary check before the function call "kfree" One function call less in tce_iommu_attach_group() after kzalloc() failure driv

[PATCH 1/2] vfio: powerpc/spapr: Delete an unnecessary check before the function call "kfree"

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 17:43:48 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/vfi

[PATCH 2/2] vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 17:58:42 +0200 The kfree() function was called even if a previous memory allocation try failed. This implementation detail could be improved by the introduction of another jump label. Signed-off-by: Markus Elfring --- drivers/vfio/vfio_iommu_spapr_t

[PATCH] un-improve strrchr()

2015-06-28 Thread Alexey Dobriyan
Commit 8da53d4595a53fb9a3380dd4d1c9bc24c7c9aab8 ("lib/string.c: improve strrchr()") changed strrchr() implementation from "rewind to the end and search backwards" to "search forward" optimizing for characher not found case. However, common case is exactly the opposite: string is absolute pathname,

[PATCH]drivers:staging:visorbus:Fix checkpatch warnings

2015-06-28 Thread Ravi Teja
This patch fixes checkpatch warnings Signed-off-by: Ravi Teja Darbha --- drivers/staging/unisys/visorbus/visorchipset.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Patrick Donnelly
On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley wrote: > On 06/27/2015 08:51 PM, Patrick Donnelly wrote: >> task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid >> is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the >> duration of use. > > kill_pgrp() ob

RE

2015-06-28 Thread Info
-- I am Mrs. Gloria C. Mackenzie, the power-ball lottery winner and I have donated $2,000,000.00 USD to you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

[PATCH RESEND 00/10] Drivers: hv: vmbus: Enable kexec and other misc cleanup

2015-06-28 Thread K. Y. Srinivasan
In addition to enabling kexec, this patch-set has a bunch of miscellaneous fixes. I have been having mail issues and hence resending the series. Alex Ng (1): Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts K. Y. Srinivasan (1): Drivers: hv: vmbus: P

[PATCH RESEND 09/10] Drivers: hv: balloon: Enable dynamic memory protocol negotiation with Windows 10 hosts

2015-06-28 Thread K. Y. Srinivasan
From: Alex Ng Support Win10 protocol for Dynamic Memory. Thia patch allows guests on Win10 hosts to hot-add memory even when dynamic memory is not enabled on the guest. Signed-off-by: Alex Ng Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c | 26 -- 1 fil

[PATCH RESEND 10/10] Drivers: hv: vmbus: Permit sending of packets without payload

2015-06-28 Thread K. Y. Srinivasan
The guest may have to send a completion packet back to the host. To support this usage, permit sending a packet without a payload - we would be only sending the descriptor in this case. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c |4 +++- 1 files changed, 3 insertions(+), 1 dele

[PATCH RESEND 05/10] Drivers: hv: vmbus: add special crash handler

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov Full kernel hang is observed when kdump kernel starts after a crash. This hang happens in vmbus_negotiate_version() function on wait_for_completion() as Hyper-V host (Win2012R2 in my testing) never responds to CHANNELMSG_INITIATE_CONTACT as it thinks the connection is alrea

[PATCH RESEND 01/10] Drivers: hv: vmbus: remove hv_synic_free_cpu() call from hv_synic_cleanup()

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov We already have hv_synic_free() which frees all per-cpu pages for all CPUs, let's remove the hv_synic_free_cpu() call from hv_synic_cleanup() so it will be possible to do separate cleanup (writing to MSRs) and final freeing. This is going to be used to assist kexec. Signed

[PATCH RESEND 04/10] Drivers: hv: don't do hypercalls when hypercall_page is NULL

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov At the very late stage of kexec a driver (which are not being unloaded) can try to post a message or signal an event. This will crash the kernel as we already did hv_cleanup() and the hypercall page is NULL. Move all common (between 32 and 64 bit code) declarations to the

[PATCH RESEND 03/10] Drivers: hv: vmbus: add special kexec handler

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov When general-purpose kexec (not kdump) is being performed in Hyper-V guest the newly booted kernel fails with an MCE error coming from the host. It is the same error which was fixed in the "Drivers: hv: vmbus: Implement the protocol for tearing down vmbus state" commit - mo

[PATCH RESEND 02/10] kexec: define kexec_in_progress in !CONFIG_KEXEC case

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov If some piece of code wants to check kexec_in_progress it has to be put in #ifdef CONFIG_KEXEC block to not break the build in !CONFIG_KEXEC case. Overcome this limitation by defining kexec_in_progress to false. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Sriniva

[PATCH RESEND 07/10] Drivers: hv: kvp: check kzalloc return value

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov kzalloc() return value check was accidentally lost in 11bc3a5fa91f: "Drivers: hv: kvp: convert to hv_utils_transport" commit. We don't need to reset kvp_transaction.state here as we have the kvp_timeout_func() timeout function and in case we're in OOM situation it is prefe

[PATCH REESEND 06/10] Drivers: hv: vmbus: prefer 'die' notification chain to 'panic'

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov current_pt_regs() sometimes returns regs of the userspace process and in case of a kernel crash this is not what we need to report. E.g. when we trigger crash with sysrq we see the following: ... RIP: 0010:[] [] sysrq_handle_crash+0x16/0x20 RSP: 0018:8800db0a7d88 E

[PATCH RESEND 08/10] Drivers: hv: fcopy: dynamically allocate smsg_out in fcopy_send_data()

2015-06-28 Thread K. Y. Srinivasan
From: Vitaly Kuznetsov struct hv_start_fcopy is too big to be on stack on i386, the following warning is reported: >> drivers/hv/hv_fcopy.c:159:1: warning: the frame size of 1088 bytes is larger >> than 1024 bytes [-Wframe-larger-than=] Reported-by: kbuild test robot Signed-off-by: Vitaly Kuz

Re: [PATCH] un-improve strrchr()

2015-06-28 Thread Joe Perches
On Sun, 2015-06-28 at 19:44 +0300, Alexey Dobriyan wrote: > Commit 8da53d4595a53fb9a3380dd4d1c9bc24c7c9aab8 > ("lib/string.c: improve strrchr()") changed strrchr() implementation > from "rewind to the end and search backwards" to "search forward" > optimizing for characher not found case. However,

Re: [tip:irq/urgent] avr32/at32ap: Fix race in installing chained IRQ handler

2015-06-28 Thread Hans-Christian Egtvedt
Around Fri 26 Jun 2015 12:47:18 -0700 or thereabout, tip-bot for Thomas Gleixner wrote: > avr32/at32ap: Fix race in installing chained IRQ handler > > Reported-by: Russell King > Signed-off-by: Thomas Gleixner > Cc: Julia Lawall > Cc: Haavard Skinnemoen > Cc: Hans-Christian Egtvedt > ---

[PATCH] SCSI: DTC: Removed 0 initialization for statics

2015-06-28 Thread Rudhresh
Removed unneccessary initialization of zero to a static variable Signed-off-by: Rudhresh Kumar J --- drivers/scsi/dtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c index 4c74c7b..99164d6 100644 --- a/drivers/scsi/dtc.c +++ b/dri

Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates

2015-06-28 Thread Maciej S. Szmigiero
W dniu 28.06.2015 16:01, Timur Tabi pisze: > Maciej S. Szmigiero wrote: >> /* Are the RX and the TX clocks locked? */ >> if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { >> -ssi_private->cpu_dai_drv.symmetric_rates = 1; >> +if (!fsl_ssi_is_ac97(ssi_private)) >>

Re: [PATCH V2 4/6] slim: qcom: Add Qualcomm Slimbus controller driver

2015-06-28 Thread Sagar Dharia
On 6/17/2015 7:53 AM, Mark Brown wrote: On Tue, Jun 16, 2015 at 07:46:02PM -0600, Sagar Dharia wrote: + - dmaengine, and pipes used to communicate between controller and memory if + sps-BAM HW is used This needs more detail. +*/ + mb(); + if (

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
On 06/28/2015 01:20 PM, Patrick Donnelly wrote: > On Sun, Jun 28, 2015 at 11:23 AM, Peter Hurley > wrote: >> On 06/27/2015 08:51 PM, Patrick Donnelly wrote: >>> task_pgrp requires an rcu or tasklist lock to be obtained if the returned >>> pid >>> is to be dereferenced, which kill_pgrp does. Obta

Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

2015-06-28 Thread Peter Hurley
Hi Patrick, On 06/27/2015 08:51 PM, Patrick Donnelly wrote: > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the > duration of use. > > Signed-off-by: Patrick Donnelly > --- > drivers/tty/tty_io

[PATCH] gpu: host1x: Fix MLOCK's debug info

2015-06-28 Thread Dmitry Osipenko
MLOCK's debug info, spewed on CDMA timeout, contains meaningless MLOCK owner channel ID because HOST1X_SYNC_MLOCK_OWNER_CHID_F() returns shifted value, while unshifted should be used. Fix it by changing '_F' to '_V'. Signed-off-by: Dmitry Osipenko --- drivers/gpu/host1x/hw/debug_hw.c | 2

[PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's

2015-06-28 Thread Dmitry Osipenko
Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings for ACPI") removed possibility to request GPIO by table index for non-ACPI platforms without changing it users. As result "shutdown" GPIO request will fail if request for "reset" GPIO succeeded or "reset" will be requested in

Re: [PATCH] un-improve strrchr()

2015-06-28 Thread Alexey Dobriyan
Joe Perches wrote: > On Sun, 2015-06-28 at 19:44 +0300, Alexey Dobriyan wrote: > > Commit 8da53d4595a53fb9a3380dd4d1c9bc24c7c9aab8 > > ("lib/string.c: improve strrchr()") changed strrchr() implementation > > from "rewind to the end and search backwards" to "search forward" > > optimizing for chara

[PATCH RFC v2 0/3] UART slave device support

2015-06-28 Thread Marek Belisko
Post RFC V2 (test on 4.1) as it seems that V1 wasn't sent properly. Hi all, this patch series is our proposal to add hooks so that the driver for a device connected to an UART can monitor modem control lines and data activity of the connected chip. It contains an example for such a device driver

[PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Marek Belisko
From: "H. Nikolaus Schaller" 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by phandle. This copies the mechanism how devm_usb_get_phy_by_phandle() works Signed-off-by: H. Nikolaus Schaller Signed-off-by: Marek Belisko --- Documentation/serial/sl

[PATCH RFC v2 2/3] tty: serial_core: Add hooks for uart slave drivers

2015-06-28 Thread Marek Belisko
From: "H. Nikolaus Schaller" 1. allow drivers to get notified in mctrl changes 2. allow drivers to get notified on rx data (indicating to the driver that the connected chip is active) Signed-off-by: H. Nikolaus Schaller Signed-off-by: Marek Belisko --- drivers/tty/serial/serial_core.c | 10

[PATCH RFC v2 3/3] misc: Add w2g0004 gps receiver driver

2015-06-28 Thread Marek Belisko
From: "H. Nikolaus Schaller" Add driver for Wi2Wi w2g004 GPS module connected through uart. Use uart slave + notification hooks to glue with tty. Signed-off-by: H. Nikolaus Schaller Signed-off-by: Marek Belisko --- .../devicetree/bindings/misc/wi2wi,w2sg0004.txt| 18 + drivers/misc/Kcon

Re: [PATCH] hpfs: add fstrim support

2015-06-28 Thread Linus Torvalds
On Sun, Jun 28, 2015 at 6:16 AM, Mikulas Patocka wrote: > This patch adds support for fstrim to the HPFS filesystem. ... > +#ifdef CONFIG_COMPAT > + .compat_ioctl = hpfs_compat_ioctl, > +#endif ... > +#ifdef CONFIG_COMPAT > + .compat_ioctl = hpfs_compat_ioctl, > +#endif ... > +#ifd

Re: [RFC PATCH v3] arm DMA: Fix allocation from CMA for coherent DMA

2015-06-28 Thread Lorenzo Nava
On Fri, Jun 26, 2015 at 6:25 PM, Catalin Marinas wrote: > On Thu, Jun 18, 2015 at 11:44:22PM +0200, Lorenzo Nava wrote: >> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c >> index 7e7583d..8e7f402 100644 >> --- a/arch/arm/mm/dma-mapping.c >> +++ b/arch/arm/mm/dma-mapping.c >> @@

Re: [RFCv4 PATCH 00/34] sched: Energy cost model for energy-aware scheduling

2015-06-28 Thread Abel Vesa
Hi, So I tried to play around a little bit with this patchset. I did a checkout from: git://linux-arm.org/linux-power.git energy_model_rfc_v4 and then, when I tried to enable the ENERGY_AWARE from sysfs inside qemu (x86_64) and I got this: [69452.750245] BUG: unable to handle kernel paging requ

Re: [PATCH] tty/vt: Fix the memory leak in visual_init

2015-06-28 Thread Peter Hurley
On 06/10/2015 03:21 AM, Dongxing Zhang wrote: > If vc->vc_uni_pagedir_loc is not NULL, its refcount needs to be > decreased before vc_uni_pagedir_loc is re-assigned. Reviewed-by: Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v6 1/2] serial_core: add pci uart early console support

2015-06-28 Thread Peter Hurley
On 06/08/2015 02:17 PM, Bin Gao wrote: > On some Intel Atom SoCs, the legacy IO port UART(0x3F8) is not available. > Instead, a 8250 compatible PCI uart can be used as early console. > This patch adds pci support to the 8250 early console driver uart8250. > For example, to enable pci uart(00:21.3)

Re: [Bug 100491] New: Oops under bitmap_start_sync [md_mod] at boot

2015-06-28 Thread Sami Liedes
On Thu, Jun 25, 2015 at 09:02:45PM +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=100491 > > Bug ID: 100491 >Summary: Oops under bitmap_start_sync [md_mod] at boot [...] > Reading all physical valumes. This may take a while

Re: [PATCH] hpfs: add fstrim support

2015-06-28 Thread Al Viro
On Sun, Jun 28, 2015 at 12:52:11PM -0700, Linus Torvalds wrote: > On Sun, Jun 28, 2015 at 6:16 AM, Mikulas Patocka > wrote: > > This patch adds support for fstrim to the HPFS filesystem. > ... > > +#ifdef CONFIG_COMPAT > > + .compat_ioctl = hpfs_compat_ioctl, > > +#endif > ... > > +#ifdef

[PATCH] um: Fix out-of-tree build

2015-06-28 Thread Richard Weinberger
Commit 30b11ee9a (um: Remove copy&paste code from init.h) uncovered an issue wrt. out-of-tree builds. For out-of-tree builds, we must not rely on relative paths. Before 30b11ee9a it worked by chance as no host code included generated header files. Signed-off-by: Richard Weinberger --- arch/um/Ma

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Sergei Zviagintsev
Hi, Some comments below. On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > 1. add registered uart_ports to a search list > 2. provide a function to search an uart_port by phandle. This copies the >mechanism how devm_usb_get_phy_by_phandle() wo

Re: [PATCH] hpfs: add fstrim support

2015-06-28 Thread Linus Torvalds
On Sun, Jun 28, 2015 at 1:59 PM, Al Viro wrote: > > More to the point, why bother with ->ioctl() at all? Why not make > ->fitrim() a super_block method and let do_vfs_ioctl() handle all > marshalling? As in > (int *)fitrim(struct super_block *, struct fstrim_range *); > guaranteed to be

[PATCH RESEND] Bluetooth: btusb: Modify entry to support misc devices with BT interface

2015-06-28 Thread Xi Ruoyao
In the USB device table in btusb driver, the code specify a generic Bluetooth device by matching Device Descriptor. However, some devices with BT interface are classified as "Miscellaneous Device" and have different Device Descriptor, such as Realtek RTL8723AU. Then btusb wouldn't probe them. To r

Re: [PATCH RFC v2 2/3] tty: serial_core: Add hooks for uart slave drivers

2015-06-28 Thread Sergei Zviagintsev
Hi, Some minor comments below. On Sun, Jun 28, 2015 at 09:46:25PM +0200, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > 1. allow drivers to get notified in mctrl changes > 2. allow drivers to get notified on rx data (indicating to the driver that >the connected chip is active) > >

Re: LIBCFS_ALLOC

2015-06-28 Thread Dan Carpenter
Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even a tiny sliver of RAM isn't going to work. It's easier to use libcfs_kvzalloc() everywhere, but it's probably the wrong thing. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control

2015-06-28 Thread Paul Gortmaker
[Re: [Intel-gfx] [v3 0/7] Crystalcove (CRC) PMIC based panel and pwm control] On 26/06/2015 (Fri 20:47) Ville Syrjälä wrote: > On Fri, Jun 26, 2015 at 06:31:37PM +0200, Daniel Vetter wrote: > > On Fri, Jun 26, 2015 at 02:32:03PM +0530, Shobhit Kumar wrote: > > > Hi, > > > Next update of the serie

Re: [PATCH RESEND] Bluetooth: btusb: Modify entry to support misc devices with BT interface

2015-06-28 Thread Larry Finger
On 06/28/2015 04:49 PM, Xi Ruoyao wrote: In the USB device table in btusb driver, the code specify a generic Bluetooth device by matching Device Descriptor. However, some devices with BT interface are classified as "Miscellaneous Device" and have different Device Descriptor, such as Realtek RTL87

  1   2   >