Re: [lkp] [xfs] ad68972acb: xfstests.time.file_system_outputs -6.0% improvement

2016-04-06 Thread Ye Xiaolong
Please ignore this report, we just found that it was tested on a virtual machine, its result is not so reliable. Sorry for that. On Thu, Apr 07, 2016 at 09:12:45AM +0800, kernel test robot wrote: >FYI, we noticed that xfstests.time.file_system_outputs -6.0% improvement on >

Re: [lkp] [xfs] ad68972acb: xfstests.time.file_system_outputs -6.0% improvement

2016-04-06 Thread Ye Xiaolong
Please ignore this report, we just found that it was tested on a virtual machine, its result is not so reliable. Sorry for that. On Thu, Apr 07, 2016 at 09:12:45AM +0800, kernel test robot wrote: >FYI, we noticed that xfstests.time.file_system_outputs -6.0% improvement on >

Re: [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio

2016-04-06 Thread Shannon Zhao
On 2016/4/6 20:16, Julien Grall wrote: >> +gpfns[j] = XEN_PFN_DOWN(r->start) + j; >> +idxs[j] = XEN_PFN_DOWN(r->start) + j; >> +} >> + >> +xatp.domid = DOMID_SELF; >> +xatp.size = nr; >> +xatp.space = XENMAPSPACE_dev_mmio; >> + >> +

Re: [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio

2016-04-06 Thread Shannon Zhao
On 2016/4/6 20:16, Julien Grall wrote: >> +gpfns[j] = XEN_PFN_DOWN(r->start) + j; >> +idxs[j] = XEN_PFN_DOWN(r->start) + j; >> +} >> + >> +xatp.domid = DOMID_SELF; >> +xatp.size = nr; >> +xatp.space = XENMAPSPACE_dev_mmio; >> + >> +

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the following kernel crash: >

Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs

2016-04-06 Thread Eric Wheeler
On Wed, 6 Apr 2016, Ming Lei wrote: > After arbitrary bio size is supported, the incoming bio may > be very big. We have to split the bio into small bios so that > each holds at most BIO_MAX_PAGES bvecs for safety reason, such > as bio_clone(). > > This patch fixes the following kernel crash: >

[PATCH] cpufreq: Rearrange cpufreq_add_dev()

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Reorganize the code in cpufreq_add_dev() to avoid using the ret variable and reduce the indentation level in it. No functional changes. Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c | 26

[PATCH] cpufreq: Rearrange cpufreq_add_dev()

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Reorganize the code in cpufreq_add_dev() to avoid using the ret variable and reduce the indentation level in it. No functional changes. Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c | 26 -- 1 file changed, 12 insertions(+),

[PATCH] cpufreq: Simplify switch () in cpufreq_cpu_callback()

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Merge two switch entries that do the same thing in cpufreq_cpu_callback(). No functional changes. Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c |5 + 1 file changed, 1 insertion(+), 4

[PATCH] cpufreq: Simplify switch () in cpufreq_cpu_callback()

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Merge two switch entries that do the same thing in cpufreq_cpu_callback(). No functional changes. Signed-off-by: Rafael J. Wysocki --- drivers/cpufreq/cpufreq.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: linux-pm/drivers/cpufreq/cpufreq.c

[PATCH] cpufreq: Skip all governor-related actions for cpufreq_suspended set

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since governor operations are generally skipped if cpufreq_suspended is set, do nothing at all in cpufreq_start_governor() and cpufreq_exit_governor() in that case. In particular, this prevents fast frequency switching from being disabled

Re: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular

2016-04-06 Thread Brian Norris
On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config BRCMSTB_GISB_ARB > bool "Broadcom STB GISB bus arbiter" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove all modular references,

[PATCH] cpufreq: Skip all governor-related actions for cpufreq_suspended set

2016-04-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Since governor operations are generally skipped if cpufreq_suspended is set, do nothing at all in cpufreq_start_governor() and cpufreq_exit_governor() in that case. In particular, this prevents fast frequency switching from being disabled after a suspend-to-RAM cycle on

Re: [PATCH 1/4] drivers/bus: make brcmstb_gisb.c driver explicitly non-modular

2016-04-06 Thread Brian Norris
On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config BRCMSTB_GISB_ARB > bool "Broadcom STB GISB bus arbiter" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove all modular references,

Re: [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute

2016-04-06 Thread Yang Jie
On 2016年04月06日 21:44, Alan wrote: From: Alan Now we correctly error an attempt to execute an unsupported operation. The current code does something else random. Signed-off-by: Alan Cox I think this is nice fix. + Vinod who is the owner of

Re: [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute

2016-04-06 Thread Yang Jie
On 2016年04月06日 21:44, Alan wrote: From: Alan Now we correctly error an attempt to execute an unsupported operation. The current code does something else random. Signed-off-by: Alan Cox I think this is nice fix. + Vinod who is the owner of the atom sound driver. Thanks, ~Keyon ---

Re: [alsa-devel] [patch] ASoC: Intel: sst: fix a loop timeout in sst_hsw_stream_reset()

2016-04-06 Thread Yang Jie
On 2016年04月06日 19:36, Dan Carpenter wrote: In the original code we ended the loop with tries set to -1 instead of zero. Signed-off-by: Dan Carpenter Acked-by: Jie Yang Dan, thanks for finding and correcting it. Thanks, ~Keyon --- Not

[lkp] [xfs] ad68972acb: xfstests.time.file_system_outputs -6.0% improvement

2016-04-06 Thread kernel test robot
FYI, we noticed that xfstests.time.file_system_outputs -6.0% improvement on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit ad68972acb82c3e8bba316d542ab204984cb1f1c ("xfs: xfs_cluster_write is redundant")

Re: [alsa-devel] [patch] ASoC: Intel: sst: fix a loop timeout in sst_hsw_stream_reset()

2016-04-06 Thread Yang Jie
On 2016年04月06日 19:36, Dan Carpenter wrote: In the original code we ended the loop with tries set to -1 instead of zero. Signed-off-by: Dan Carpenter Acked-by: Jie Yang Dan, thanks for finding and correcting it. Thanks, ~Keyon --- Not tested. diff --git

[lkp] [xfs] ad68972acb: xfstests.time.file_system_outputs -6.0% improvement

2016-04-06 Thread kernel test robot
FYI, we noticed that xfstests.time.file_system_outputs -6.0% improvement on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit ad68972acb82c3e8bba316d542ab204984cb1f1c ("xfs: xfs_cluster_write is redundant")

btrfs BUGs

2016-04-06 Thread Norbert Preining
Dear all, (please Cc) since 4.6.0-rc I see regular BUG in btrfs_destroy_inode: Variant 1: [47093.775175] [ cut here ] [47093.775187] WARNING: CPU: 3 PID: 19909 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0xad/0x224 [47093.775189] Modules linked in: hmac drbg ansi_cprng

btrfs BUGs

2016-04-06 Thread Norbert Preining
Dear all, (please Cc) since 4.6.0-rc I see regular BUG in btrfs_destroy_inode: Variant 1: [47093.775175] [ cut here ] [47093.775187] WARNING: CPU: 3 PID: 19909 at fs/btrfs/inode.c:9261 btrfs_destroy_inode+0xad/0x224 [47093.775189] Modules linked in: hmac drbg ansi_cprng

Re: [PATCH v2 10/14] USB: ch341: fix coding style

2016-04-06 Thread Grigori Goronzy
On 04/06/2016 08:10 PM, Johan Hovold wrote: > As Joe already said, we generally don't want indentation-only changes to > existing code. Just try to stick to the style of the driver (even if > it's inconsistent at times). > Hm, I don't get it. I understand that white-space-only changes are

Re: [PATCH v2 10/14] USB: ch341: fix coding style

2016-04-06 Thread Grigori Goronzy
On 04/06/2016 08:10 PM, Johan Hovold wrote: > As Joe already said, we generally don't want indentation-only changes to > existing code. Just try to stick to the style of the driver (even if > it's inconsistent at times). > Hm, I don't get it. I understand that white-space-only changes are

[lkp] [mm] 6f25a14a70: will-it-scale.scalability -4.0% regression

2016-04-06 Thread kernel test robot
FYI, we noticed that will-it-scale.scalability -4.0% regression on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 6f25a14a7053b69917e2ebea0d31dd444cd31fd5 ("mm: fix invalid node in alloc_migrate_target()")

[lkp] [mm] 6f25a14a70: will-it-scale.scalability -4.0% regression

2016-04-06 Thread kernel test robot
FYI, we noticed that will-it-scale.scalability -4.0% regression on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 6f25a14a7053b69917e2ebea0d31dd444cd31fd5 ("mm: fix invalid node in alloc_migrate_target()")

[PATCH] libnvdimm: fix smart data retrieval

2016-04-06 Thread Dan Williams
It appears that smart data retrieval has been broken the since the initial implementation. Fix the payload size to be 128-bytes per the specification. Cc: Signed-off-by: Dan Williams --- drivers/nvdimm/bus.c |2 +- 1 file changed, 1

[PATCH] libnvdimm: fix smart data retrieval

2016-04-06 Thread Dan Williams
It appears that smart data retrieval has been broken the since the initial implementation. Fix the payload size to be 128-bytes per the specification. Cc: Signed-off-by: Dan Williams --- drivers/nvdimm/bus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] libnvdimm, test: add mock SMART data payload

2016-04-06 Thread Dan Williams
Provide simulated SMART data to enable the ndctl implementation of SMART data retrieval and parsing. The payload is defined here, "Section 4.1 SMART and Health Info (Function Index 1)": http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf Signed-off-by: Dan Williams

[PATCH] libnvdimm, test: add mock SMART data payload

2016-04-06 Thread Dan Williams
Provide simulated SMART data to enable the ndctl implementation of SMART data retrieval and parsing. The payload is defined here, "Section 4.1 SMART and Health Info (Function Index 1)": http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf Signed-off-by: Dan Williams ---

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > [...] > > One of the weak points is the final jump, because it has to be done to the > physical location of the image kernel's entry point even though the virtual > addresses of it may differ between the boot and the image kernels. The seed >

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > [...] > > One of the weak points is the final jump, because it has to be done to the > physical location of the image kernel's entry point even though the virtual > addresses of it may differ between the boot and the image kernels. The seed > is > not needed

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Minchan Kim
Hello Chulmin, On Wed, Apr 06, 2016 at 10:01:14PM +0900, Chulmin Kim wrote: > On 2016년 03월 30일 16:12, Minchan Kim wrote: > >This patch introduces run-time migration feature for zspage. > >To begin with, it supports only head page migration for > >easy review(later patches will support tail page

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Minchan Kim
Hello Chulmin, On Wed, Apr 06, 2016 at 10:01:14PM +0900, Chulmin Kim wrote: > On 2016년 03월 30일 16:12, Minchan Kim wrote: > >This patch introduces run-time migration feature for zspage. > >To begin with, it supports only head page migration for > >easy review(later patches will support tail page

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Chulmin Kim
On 2016년 04월 06일 22:01, Chulmin Kim wrote: On 2016년 03월 30일 16:12, Minchan Kim wrote: This patch introduces run-time migration feature for zspage. To begin with, it supports only head page migration for easy review(later patches will support tail page migration). For migration, it supports

Re: [PATCH v3 13/16] zsmalloc: migrate head page of zspage

2016-04-06 Thread Chulmin Kim
On 2016년 04월 06일 22:01, Chulmin Kim wrote: On 2016년 03월 30일 16:12, Minchan Kim wrote: This patch introduces run-time migration feature for zspage. To begin with, it supports only head page migration for easy review(later patches will support tail page migration). For migration, it supports

Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup

2016-04-06 Thread Thor Thayer
Hi Boris, On 04/05/2016 12:31 AM, Borislav Petkov wrote: On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote: I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in the next revision with a goto. I'm assuming nothing else changes. Because I've applied 1-4

Re: [PATCHv2 6/7] ARM: socfpga: Enable Arria10 OCRAM ECC on startup

2016-04-06 Thread Thor Thayer
Hi Boris, On 04/05/2016 12:31 AM, Borislav Petkov wrote: On Tue, Apr 05, 2016 at 12:25:33AM -0500, Thor Thayer wrote: I realize that I'm not calling iounmap(ecc_block_base) and I'll fix that in the next revision with a goto. I'm assuming nothing else changes. Because I've applied 1-4

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote: > On Wed, 2016-04-06 at 22:13:59 +, Koul, Vinod wrote: > > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > >

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote: > On Wed, 2016-04-06 at 22:13:59 +, Koul, Vinod wrote: > > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > >

[PATCH v3 6/6] LSM: LoadPin for kernel file loading restrictions

2016-04-06 Thread Kees Cook
This LSM enforces that kernel-loaded files (modules, firmware, etc) must all come from the same filesystem, with the expectation that such a filesystem is backed by a read-only device such as dm-verity or CDROM. This allows systems that have a verified and/or unchangeable filesystem to enforce

[PATCH v3 2/6] string_helpers: add kstrdup_quotable_cmdline

2016-04-06 Thread Kees Cook
Provide an escaped (but readable: no inter-argument NULLs) commandline safe for logging. Signed-off-by: Kees Cook --- v3: - clean up loops, andriy.shevchenko - add gfp_t, joe --- include/linux/string_helpers.h | 1 + lib/string_helpers.c | 34

[PATCH v3 4/6] Yama: consolidate error reporting

2016-04-06 Thread Kees Cook
Use a common error reporting function for Yama violation reports, and give more detail into the process command lines. Signed-off-by: Kees Cook --- security/yama/yama_lsm.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git

[PATCH v3 3/6] string_helpers: add kstrdup_quotable_file

2016-04-06 Thread Kees Cook
Allocate a NULL-terminated file path with special characters escaped, safe for logging. Signed-off-by: Kees Cook --- v3: - add gfp_t, joe --- include/linux/string_helpers.h | 3 +++ lib/string_helpers.c | 30 ++ 2 files changed, 33

[PATCH v3 6/6] LSM: LoadPin for kernel file loading restrictions

2016-04-06 Thread Kees Cook
This LSM enforces that kernel-loaded files (modules, firmware, etc) must all come from the same filesystem, with the expectation that such a filesystem is backed by a read-only device such as dm-verity or CDROM. This allows systems that have a verified and/or unchangeable filesystem to enforce

[PATCH v3 2/6] string_helpers: add kstrdup_quotable_cmdline

2016-04-06 Thread Kees Cook
Provide an escaped (but readable: no inter-argument NULLs) commandline safe for logging. Signed-off-by: Kees Cook --- v3: - clean up loops, andriy.shevchenko - add gfp_t, joe --- include/linux/string_helpers.h | 1 + lib/string_helpers.c | 34 ++ 2

[PATCH v3 4/6] Yama: consolidate error reporting

2016-04-06 Thread Kees Cook
Use a common error reporting function for Yama violation reports, and give more detail into the process command lines. Signed-off-by: Kees Cook --- security/yama/yama_lsm.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git

[PATCH v3 3/6] string_helpers: add kstrdup_quotable_file

2016-04-06 Thread Kees Cook
Allocate a NULL-terminated file path with special characters escaped, safe for logging. Signed-off-by: Kees Cook --- v3: - add gfp_t, joe --- include/linux/string_helpers.h | 3 +++ lib/string_helpers.c | 30 ++ 2 files changed, 33 insertions(+) diff

[PATCH v3 0/6] LSM: LoadPin for kernel file loading restrictions

2016-04-06 Thread Kees Cook
This provides the mini-LSM "loadpin" that intercepts the now consolidated kernel_file_read LSM hook so that a system can keep all loads coming from a single trusted filesystem. This is what Chrome OS uses to pin kernel module and firmware loading to the read-only crypto-verified dm-verity

[PATCH v3 0/6] LSM: LoadPin for kernel file loading restrictions

2016-04-06 Thread Kees Cook
This provides the mini-LSM "loadpin" that intercepts the now consolidated kernel_file_read LSM hook so that a system can keep all loads coming from a single trusted filesystem. This is what Chrome OS uses to pin kernel module and firmware loading to the read-only crypto-verified dm-verity

[PATCH v3 5/6] fs: provide function to report enum strings

2016-04-06 Thread Kees Cook
Providing human-readable (and audit-parsable) strings for the READING_* enums is needed by some LSMs. Signed-off-by: Kees Cook --- v3: - add general use function, zohar --- fs/exec.c | 19 +++ include/linux/fs.h | 1 + 2 files changed, 20

[PATCH v3 1/6] string_helpers: add kstrdup_quotable

2016-04-06 Thread Kees Cook
Handle allocating and escaping a string safe for logging. Signed-off-by: Kees Cook --- v3: - add gfp_t, joe - reduce BUG_ON to WARN_ON, joe --- include/linux/string_helpers.h | 2 ++ lib/string_helpers.c | 28 2 files changed, 30

[PATCH v3 5/6] fs: provide function to report enum strings

2016-04-06 Thread Kees Cook
Providing human-readable (and audit-parsable) strings for the READING_* enums is needed by some LSMs. Signed-off-by: Kees Cook --- v3: - add general use function, zohar --- fs/exec.c | 19 +++ include/linux/fs.h | 1 + 2 files changed, 20 insertions(+) diff --git

[PATCH v3 1/6] string_helpers: add kstrdup_quotable

2016-04-06 Thread Kees Cook
Handle allocating and escaping a string safe for logging. Signed-off-by: Kees Cook --- v3: - add gfp_t, joe - reduce BUG_ON to WARN_ON, joe --- include/linux/string_helpers.h | 2 ++ lib/string_helpers.c | 28 2 files changed, 30 insertions(+) diff --git

Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 03:27:20PM -0600, Al Stone wrote: > On arm64 systems, using /dev/port does not really make sense; this is > historically used for other architectures to access ISA IO ports, which > with any luck do not exist on arm64 platforms. With the following snippet > of perl code

Re: [PATCH] arm64: CONFIG_DEVPORT should not be used when PCI is being used

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 03:27:20PM -0600, Al Stone wrote: > On arm64 systems, using /dev/port does not really make sense; this is > historically used for other architectures to access ISA IO ports, which > with any luck do not exist on arm64 platforms. With the following snippet > of perl code

[PATCH v4 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots

2016-04-06 Thread Luis R. Rodriguez
The use of subarch should have no current effect on Xen PV guests, as such this should have no current functional effects. Signed-off-by: Luis R. Rodriguez --- arch/x86/xen/enlighten.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/xen/enlighten.c

[PATCH v4 00/14] x86: remove paravirt_enabled

2016-04-06 Thread Luis R. Rodriguez
Now that Andy's ASM paravirt_enabled() use is merged all we need is to address the rest of the C code uses. This completes that work by providing proper semantics for platform legacy settings and quirks as suggested by Ingo, this in turn can also be extended later for benefit of further processing

[PATCH v4 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots

2016-04-06 Thread Luis R. Rodriguez
The use of subarch should have no current effect on Xen PV guests, as such this should have no current functional effects. Signed-off-by: Luis R. Rodriguez --- arch/x86/xen/enlighten.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index

[PATCH v4 00/14] x86: remove paravirt_enabled

2016-04-06 Thread Luis R. Rodriguez
Now that Andy's ASM paravirt_enabled() use is merged all we need is to address the rest of the C code uses. This completes that work by providing proper semantics for platform legacy settings and quirks as suggested by Ingo, this in turn can also be extended later for benefit of further processing

[PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-06 Thread Luis R. Rodriguez
We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific legacy quirk set early in boot through

[PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-06 Thread Luis R. Rodriguez
We have 4 types of x86 platforms that disable RTC: * Intel MID * Lguest - uses paravirt * Xen dom-U - uses paravirt * x86 on legacy systems annotated with an ACPI legacy flag We can consolidate all of these into a platform specific legacy quirk set early in boot through

[PATCH v4 06/14] x86/init: use a platform legacy quirk for ebda

2016-04-06 Thread Luis R. Rodriguez
This replaces the paravirt_enabled() check with a proper x86 legacy platform quirk. Signed-off-by: Luis R. Rodriguez --- arch/x86/include/asm/x86_init.h | 3 +++ arch/x86/kernel/head.c| 2 +- arch/x86/kernel/platform-quirks.c | 4 3 files changed, 8

[PATCH v4 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code

2016-04-06 Thread Luis R. Rodriguez
This moves the ACPI specific check into the ACPI boot code, it also takes advantage of the x86_platform.legacy.rtc which is checked for already on the RTC initialization code. This lets us remove the nasty #ifdefery and consolidate the checks to use only one toggle to disable the RTC init code.

[PATCH v4 06/14] x86/init: use a platform legacy quirk for ebda

2016-04-06 Thread Luis R. Rodriguez
This replaces the paravirt_enabled() check with a proper x86 legacy platform quirk. Signed-off-by: Luis R. Rodriguez --- arch/x86/include/asm/x86_init.h | 3 +++ arch/x86/kernel/head.c| 2 +- arch/x86/kernel/platform-quirks.c | 4 3 files changed, 8 insertions(+), 1

[PATCH v4 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code

2016-04-06 Thread Luis R. Rodriguez
This moves the ACPI specific check into the ACPI boot code, it also takes advantage of the x86_platform.legacy.rtc which is checked for already on the RTC initialization code. This lets us remove the nasty #ifdefery and consolidate the checks to use only one toggle to disable the RTC init code.

[PATCH v4 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around

2016-04-06 Thread Luis R. Rodriguez
The X86_BUG_F00F work around is responsible for fixing up the error generated on attempted F00F exploitation from an OOPS to a SIGILL. There is no reason why this code should not be allowed to run on PV guest on a F00F-affected CPU -- it would simply never trigger. The pv_enabled() check was there

[PATCH v4 08/14] apm32: remove paravirt_enabled() use

2016-04-06 Thread Luis R. Rodriguez
There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the apm_bios.info. The Xen folks are sure force disable to 0 is not needed, we recently

[PATCH v4 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around

2016-04-06 Thread Luis R. Rodriguez
The X86_BUG_F00F work around is responsible for fixing up the error generated on attempted F00F exploitation from an OOPS to a SIGILL. There is no reason why this code should not be allowed to run on PV guest on a F00F-affected CPU -- it would simply never trigger. The pv_enabled() check was there

[PATCH v4 08/14] apm32: remove paravirt_enabled() use

2016-04-06 Thread Luis R. Rodriguez
There is already a check for apm_info.bios == 0, the apm_info.bios is set from the boot_params.apm_bios_info. Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the apm_bios.info. The Xen folks are sure force disable to 0 is not needed, we recently

[PATCH v4 13/14] x86/init: rename ebda code file

2016-04-06 Thread Luis R. Rodriguez
This makes it clearer what this is. Signed-off-by: Luis R. Rodriguez --- arch/x86/Makefile | 2 +- arch/x86/kernel/Makefile | 2 +- arch/x86/kernel/{head.c => ebda.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename

[PATCH v4 07/14] tools/lguest: force disable tboot and apm

2016-04-06 Thread Luis R. Rodriguez
The paravirt_enabled() check is going away, the area tossed to the kernel on lguest is not zerored out, so ensure lguest force disables tboot and apm just in case the kernel file being read might have this set for whatever reason. Signed-off-by: Luis R. Rodriguez ---

[PATCH v4 13/14] x86/init: rename ebda code file

2016-04-06 Thread Luis R. Rodriguez
This makes it clearer what this is. Signed-off-by: Luis R. Rodriguez --- arch/x86/Makefile | 2 +- arch/x86/kernel/Makefile | 2 +- arch/x86/kernel/{head.c => ebda.c} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename arch/x86/kernel/{head.c => ebda.c}

[PATCH v4 07/14] tools/lguest: force disable tboot and apm

2016-04-06 Thread Luis R. Rodriguez
The paravirt_enabled() check is going away, the area tossed to the kernel on lguest is not zerored out, so ensure lguest force disables tboot and apm just in case the kernel file being read might have this set for whatever reason. Signed-off-by: Luis R. Rodriguez --- tools/lguest/lguest.c | 6

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Greg Kroah-Hartman
On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

[PATCH v4 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES

2016-04-06 Thread Luis R. Rodriguez
ACPI 5.2.9.3 IA-PC Boot Architecture flag ACPI_FADT_LEGACY_DEVICES can be used to determine if a system has legacy devices LPC or ISA devices. The x86 platform already has a struct which lists known associated legacy devices, we start off careful only by disabling root devices we should not

[PATCH v4 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES

2016-04-06 Thread Luis R. Rodriguez
ACPI 5.2.9.3 IA-PC Boot Architecture flag ACPI_FADT_LEGACY_DEVICES can be used to determine if a system has legacy devices LPC or ISA devices. The x86 platform already has a struct which lists known associated legacy devices, we start off careful only by disabling root devices we should not

[PATCH v4 14/14] x86/paravirt: remove paravirt_enabled()

2016-04-06 Thread Luis R. Rodriguez
That that paravirt_enabled() is replaced with proper x86 semantics we can remove it. Signed-off-by: Luis R. Rodriguez --- arch/x86/include/asm/paravirt.h | 5 - arch/x86/include/asm/paravirt_types.h | 1 - arch/x86/include/asm/processor.h | 1 -

[PATCH v4 14/14] x86/paravirt: remove paravirt_enabled()

2016-04-06 Thread Luis R. Rodriguez
That that paravirt_enabled() is replaced with proper x86 semantics we can remove it. Signed-off-by: Luis R. Rodriguez --- arch/x86/include/asm/paravirt.h | 5 - arch/x86/include/asm/paravirt_types.h | 1 - arch/x86/include/asm/processor.h | 1 - arch/x86/kernel/kvm.c

[PATCH v4 09/14] x86/tboot: remove paravirt_enabled()

2016-04-06 Thread Luis R. Rodriguez
There is already a check for boot_params.tboot_addr prior to paravirt_enabled(). Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the boot_params.tboot_addr. The Xen folks are sure a force disable to 0 is not needed, we recently forced disabled this on

[PATCH v4 09/14] x86/tboot: remove paravirt_enabled()

2016-04-06 Thread Luis R. Rodriguez
There is already a check for boot_params.tboot_addr prior to paravirt_enabled(). Both Xen and lguest, which are also the only ones that set paravirt_enabled to true, never set the boot_params.tboot_addr. The Xen folks are sure a force disable to 0 is not needed, we recently forced disabled this on

[PATCH v4 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly

2016-04-06 Thread Luis R. Rodriguez
Be explicit and make use of X86_SUBARCH_LGUEST directly. Signed-off-by: Luis R. Rodriguez --- tools/lguest/lguest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lguest/lguest.c b/tools/lguest/lguest.c index 80159e6811c2..ff0aa580c6e1 100644

[PATCH v4 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch

2016-04-06 Thread Luis R. Rodriguez
Although hardware_subarch has been in place since the x86 boot protocol 2.07 it hasn't been used much. Enumerate current possible values to avoid misuses and help with semantics later at boot time should this be used further. These enums should only ever be used by architecture x86 code, and all

[PATCH v4 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly

2016-04-06 Thread Luis R. Rodriguez
Be explicit and make use of X86_SUBARCH_LGUEST directly. Signed-off-by: Luis R. Rodriguez --- tools/lguest/lguest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/lguest/lguest.c b/tools/lguest/lguest.c index 80159e6811c2..ff0aa580c6e1 100644 ---

[PATCH v4 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch

2016-04-06 Thread Luis R. Rodriguez
Although hardware_subarch has been in place since the x86 boot protocol 2.07 it hasn't been used much. Enumerate current possible values to avoid misuses and help with semantics later at boot time should this be used further. These enums should only ever be used by architecture x86 code, and all

[PATCH v4 11/14] pnpbios: replace paravirt_enabled() check with legacy device check

2016-04-06 Thread Luis R. Rodriguez
Since we are removing paravirt_enabled() replace it with a logical equivalent. Even though PNPBIOS is x86 specific we add an arch-specific type call, which can be implemented by any architecture to show how other legacy attribute devices can later be also checked for with other ACPI legacy

[PATCH v4 11/14] pnpbios: replace paravirt_enabled() check with legacy device check

2016-04-06 Thread Luis R. Rodriguez
Since we are removing paravirt_enabled() replace it with a logical equivalent. Even though PNPBIOS is x86 specific we add an arch-specific type call, which can be implemented by any architecture to show how other legacy attribute devices can later be also checked for with other ACPI legacy

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > >> I don't think this is a good idea, as it turns off emergency hibernation > >> of > >> laptops - many desktop distros support it by default. > > > > Right, I forgot about this one. > > When I last checked Ubuntu doesn't enable hibernation by

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > >> I don't think this is a good idea, as it turns off emergency hibernation > >> of > >> laptops - many desktop distros support it by default. > > > > Right, I forgot about this one. > > When I last checked Ubuntu doesn't enable hibernation by default any more: >

Re: [PATCHSET RFC cgroup/for-4.6] cgroup, sched: implement resource group and PRIO_RGRP

2016-04-06 Thread Tejun Heo
Hello, Mike. On Sun, Mar 13, 2016 at 06:40:35PM +0100, Mike Galbraith wrote: > On Sun, 2016-03-13 at 11:00 -0400, Tejun Heo wrote: > > Let's say there is an application which wants to manage resource > > distributions across its multiple threadpools in a hierarchical way. > > With cgroupfs

Re: [PATCHSET RFC cgroup/for-4.6] cgroup, sched: implement resource group and PRIO_RGRP

2016-04-06 Thread Tejun Heo
Hello, Mike. On Sun, Mar 13, 2016 at 06:40:35PM +0100, Mike Galbraith wrote: > On Sun, 2016-03-13 at 11:00 -0400, Tejun Heo wrote: > > Let's say there is an application which wants to manage resource > > distributions across its multiple threadpools in a hierarchical way. > > With cgroupfs

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread Stefano Stabellini
On Wed, 6 Apr 2016, David Vrabel wrote: > On 04/04/16 13:32, Anna-Maria Gleixner wrote: > > Xen guests do not offline/online CPUs during suspend/resume and > > therefore FROZEN notifier transitions are not required. Add this > > explanation as a comment in the code to get not confused why > >

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread Stefano Stabellini
On Wed, 6 Apr 2016, David Vrabel wrote: > On 04/04/16 13:32, Anna-Maria Gleixner wrote: > > Xen guests do not offline/online CPUs during suspend/resume and > > therefore FROZEN notifier transitions are not required. Add this > > explanation as a comment in the code to get not confused why > >

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread Stefano Stabellini
On Tue, 5 Apr 2016, Juergen Gross wrote: > On 04/04/16 18:48, Boris Ostrovsky wrote: > > On 04/04/2016 12:30 PM, David Vrabel wrote: > >> On 04/04/16 17:21, Julien Grall wrote: > >>> (CC Stefano new e-mail address) > >>> > >>> Hello Anna-Maria, > >>> > >>> On 04/04/2016 13:32, Anna-Maria Gleixner

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread Stefano Stabellini
On Tue, 5 Apr 2016, Juergen Gross wrote: > On 04/04/16 18:48, Boris Ostrovsky wrote: > > On 04/04/2016 12:30 PM, David Vrabel wrote: > >> On 04/04/16 17:21, Julien Grall wrote: > >>> (CC Stefano new e-mail address) > >>> > >>> Hello Anna-Maria, > >>> > >>> On 04/04/2016 13:32, Anna-Maria Gleixner

Re: [PATCH v2 1/5] string_helpers: add kstrdup_quotable

2016-04-06 Thread Kees Cook
On Mon, Mar 28, 2016 at 4:30 PM, Joe Perches wrote: > On Mon, 2016-03-28 at 14:14 -0700, Kees Cook wrote: >> Handle allocating and escaping a string safe for logging. > [] >> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h > [] >> @@ -68,4 +68,6 @@

Re: [PATCH v2 1/5] string_helpers: add kstrdup_quotable

2016-04-06 Thread Kees Cook
On Mon, Mar 28, 2016 at 4:30 PM, Joe Perches wrote: > On Mon, 2016-03-28 at 14:14 -0700, Kees Cook wrote: >> Handle allocating and escaping a string safe for logging. > [] >> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h > [] >> @@ -68,4 +68,6 @@ static inline int

[PATCH 1/4] mailbox/omap: store mailbox interrupt type in omap_mbox_device

2016-04-06 Thread Suman Anna
The interrupt type used for identifying the layout of the interrupt configuration registers between OMAP4+ SoCs and older SoCs is stored only in the sub-mailbox structures for easier access. Store this type in the the omap_mbox_device structure as well along with the other global variables. This

Re: [PATCH v2 2/5] string_helpers: add kstrdup_quotable_cmdline

2016-04-06 Thread Kees Cook
On Wed, Mar 30, 2016 at 4:11 AM, Andy Shevchenko wrote: > On Wed, 2016-03-30 at 14:07 +0300, Andy Shevchenko wrote: >> On Mon, 2016-03-28 at 14:14 -0700, Kees Cook wrote: > > >> > + res = get_cmdline(task, buffer, PAGE_SIZE - 1); >> > + buffer[res] = '\0';

<    1   2   3   4   5   6   7   8   9   10   >