[PATCH] IB/hfi1: Delete an unnecessary check before the function call "sc_return_credits"

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 08:30:52 +0200 The sc_return_credits() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

RE: [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-07-23 Thread Winkler, Tomas
> > Few storage technologies such is EMMC, UFS, and NVMe support RPMB > hardware partition with common protocol and frame layout. > The RPMB partition cannot be accessed via standard block layer, but by a set > of specific commands: WRITE, READ, GET_WRITE_COUNTER, and > PROGRAM_KEY. > Such a part

[tip:x86/mm] x86/mm/cpa: Fix populate_pgd(): Stop trying to deallocate failed PUDs

2016-07-23 Thread tip-bot for Andy Lutomirski
Commit-ID: e959c4cb39feebe85e2b1191f5f666c79807631a Gitweb: http://git.kernel.org/tip/e959c4cb39feebe85e2b1191f5f666c79807631a Author: Andy Lutomirski AuthorDate: Fri, 22 Jul 2016 21:58:08 -0700 Committer: Ingo Molnar CommitDate: Sat, 23 Jul 2016 09:43:42 +0200 x86/mm/cpa: Fix populate

Re: [PATCH v2 16/17] x86/insn: remove pcommit

2016-07-23 Thread Ingo Molnar
* Dan Williams wrote: > On Fri, Jul 22, 2016 at 9:52 AM, Ingo Molnar wrote: > > > > * Dan Williams wrote: > > > >> On Tue, Jul 12, 2016 at 3:12 PM, Dan Williams > >> wrote: > >> > On Tue, Jul 12, 2016 at 7:57 AM, Peter Zijlstra > >> > wrote: > >> >> On Sat, Jul 09, 2016 at 08:25:54PM -0700

[PATCH] sched/core: make "Preemption disabled at" message more useful

2016-07-23 Thread Vegard Nossum
This message is currently really useless since it always prints a value that comes from the printk() we just did, e.g.: BUG: sleeping function called from invalid context at mm/slab.h:388 in_atomic(): 0, irqs_disabled(): 0, pid: 31996, name: trinity-c1 Preemption disabled at:[] down_tr

Re: [PATCH 0/3] ARM: fix three implicit module use cases fed via gpio

2016-07-23 Thread Robert Jarzmik
Paul Gortmaker writes: > While working on some for-4.9 cleanups of linux/gpio/driver.h it was > found that changes there caused build failures when walking all the > ARM defconfigs, in ARM specific mach-* files. > > The proposed GPIO header change is just this: > > --

Re: [tip:x86/mm] x86/mm/cpa: Fix populate_pgd(): Stop trying to deallocate failed PUDs

2016-07-23 Thread Linus Torvalds
On Sat, Jul 23, 2016 at 4:46 PM, tip-bot for Andy Lutomirski wrote: > > Fixing this directly is difficult or impossible because of the awful > state of Linux's page table accessors. Quite frankly, this part of the message is misleading and wrong. The "awful state" is purely "Andy didn't understa

Re: [PATCH V2 1/2] mmc: sdhci: Request regulators before reading capabilities

2016-07-23 Thread Ulf Hansson
On 12 July 2016 at 15:53, Jon Hunter wrote: > The capabilities of the SDHCI host controller are read early during the > SDHCI host initialisation in sdhci_setup_host() and before any > regulators for the host have been requested. This means that if the host > supports some high-speed modes (accord

Re: [PATCH] mmc: sdhci-msm: Do not reset the controller if no card in the slot

2016-07-23 Thread Ulf Hansson
On 24 June 2016 at 18:24, Georgi Djakov wrote: > The controller does not clear the "reset bit" when it is reset without > a card in the slot. Because of this, the following error message is seen > while booting with no plugged SD card. > > mmc1: Reset 0x1 never completed. > > Add the SDHCI_QUIRK_N

Re: [PATCH V2 2/2] mmc: tegra: Only advertise UHS modes if IO regulator is present

2016-07-23 Thread Ulf Hansson
On 12 July 2016 at 15:53, Jon Hunter wrote: > To support UHS modes for Tegra an external regulator must be present > to adjust the IO voltage accordingly. Even if the regulator is not > present but the host supports the UHS modes and the device supports the > UHS modes, then we will attempt to swi

Re: [PATCH] mmc: sdhci-msm: Add support for UHS cards

2016-07-23 Thread Ulf Hansson
On 24 June 2016 at 17:07, Georgi Djakov wrote: > Enabling support for ultra high speed mode cards requires some > voltage switching and interaction with the PMIC via a special > power IRQ. Add support for this. > > Signed-off-by: Georgi Djakov Thanks, applied for next! Kind regards Uffe > ---

Re: [PATCH 2/3] phy: rockchip-emmc: Be tolerant to card clock of 0 in power on

2016-07-23 Thread Ulf Hansson
On 29 June 2016 at 17:18, Doug Anderson wrote: > Kishon, > > On Wed, Jun 29, 2016 at 6:49 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Monday 27 June 2016 11:09 PM, Douglas Anderson wrote: >>> It's possible that there are some reasons to turn the PHY on while the >>> clock is 0. In this cas

Re: [PATCH] mmc: sdhci-msm: Add set_uhs_signaling() implementation

2016-07-23 Thread Ulf Hansson
On 19 July 2016 at 16:52, Georgi Djakov wrote: > From: Ritesh Harjani > > To allow UHS mode to work properly, we need to implement a Qualcomm > specific set_uhs_signaling() callback function. This function differs > from the sdhci_set_uhs_signaling() in that we need check the clock > rate and ena

RE: [PATCH] tipc: fix NULL pointer dereference in shutdown()

2016-07-23 Thread Xue, Ying
Acked-by: Ying Xue -Original Message- From: Vegard Nossum [mailto:vegard.nos...@oracle.com] Sent: Saturday, July 23, 2016 2:15 PM To: Jon Maloy; Xue, Ying Cc: net...@vger.kernel.org; David S. Miller; Michael Kerrisk; linux-kernel@vger.kernel.org; Vegard Nossum; sta...@vger.kernel.org Su

[PATCH 4/6] spi: octeon: Move include file from arch/mips to drivers/spi

2016-07-23 Thread Jan Glauber
Move the register definitions to the drivers directory because they are only used there. Signed-off-by: Jan Glauber Tested-by: Steven J. Hill --- .../cvmx-mpi-defs.h => drivers/spi/spi-cavium.h| 32 +- drivers/spi/spi-octeon.c | 3 +- 2 files c

[PATCH 0/6] SPI ThunderX driver

2016-07-23 Thread Jan Glauber
Hi Mark, This series adds support for SPI on Cavium's ThunderX (arm64). The SPI hardware is the same as on MIPS Octeon, the only difference is that the device appears as a PCI device. To avoid copy and paste of the Octeon driver I've moved the common parts into a shared file. Patches #1-5 prepare

[PATCH 3/6] spi: octeon: Put register offsets into a struct

2016-07-23 Thread Jan Glauber
Instead of hard-coding the register offsets put them into a struct and set them in the probe function. Signed-off-by: Jan Glauber Tested-by: Steven J. Hill --- drivers/spi/spi-octeon.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git

[PATCH 6/6] spi: octeon: Add thunderx driver

2016-07-23 Thread Jan Glauber
Add ThunderX SPI driver using the shared part from the Octeon driver. The main difference of the ThunderX driver is that it is a PCI device so probing is different. The system clock settings can be specified in device tree. Signed-off-by: Jan Glauber --- drivers/spi/Kconfig | 7 +

[PATCH 2/6] spi: octeon: Store system clock freqency in struct octeon_spi

2016-07-23 Thread Jan Glauber
Storing the system clock frequency in struct octeon_spi avoids calling the MIPS specific octeon_get_io_clock_rate() for every transfer. Signed-off-by: Jan Glauber Tested-by: Steven J. Hill --- drivers/spi/spi-octeon.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 1/6] spi: octeon: Convert driver to use readq()/writeq() functions

2016-07-23 Thread Jan Glauber
From: "Steven J. Hill" Remove all calls to cvmx_read_csr()/cvmx_write_csr() and use the portable readq()/writeq() functions. Signed-off-by: Steven J. Hill Signed-off-by: Jan Glauber --- drivers/spi/spi-octeon.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) d

[PATCH 5/6] spi: octeon: Split driver into Octeon specific and common parts

2016-07-23 Thread Jan Glauber
Separate driver probing from SPI transfer functions. Signed-off-by: Jan Glauber Tested-by: Steven J. Hill --- drivers/spi/Makefile | 1 + drivers/spi/spi-cavium-octeon.c| 104 + drivers/spi/{spi-octeon.c => spi-cavium.c} | 120 +---

Re: [PATCH RFC] coccinelle: tests: if and else branch should probably not be identical

2016-07-23 Thread Julia Lawall
On Fri, 22 Jul 2016, Nicholas Mc Guire wrote: > On Fri, Jul 22, 2016 at 06:56:47PM +0200, Julia Lawall wrote: > > > +virtual context > > > +virtual org > > > +virtual report > > > + > > > +@cond@ > > > +statement S1; > > > +position p; > > > +@@ > > > + > > > +<+... > > > +* if@p (...) S1 else S

[PATCH 0/3] IB/mthca: Fine-tuning for mthca_reset()

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 12:50:12 +0200 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete an unnecessary check before the function call "pci_dev_put" Less function calls after error det

Re: [PATCH v2 3/4] mfd: add support for Allwinner SoCs ADC

2016-07-23 Thread Jonathan Cameron
On 22/07/16 15:55, Lee Jones wrote: > On Thu, 21 Jul 2016, Maxime Ripard wrote: > >> 1;4205;0c >> On Thu, Jul 21, 2016 at 01:12:53PM +0100, Lee Jones wrote: >>> On Wed, 20 Jul 2016, Jonathan Cameron wrote: >>> On 19/07/16 08:31, Lee Jones wrote: > On Mon, 18 Jul 2016, Jonathan Cameron wro

Re: [RCF 1/3] hwmon: Add ads1118 driver

2016-07-23 Thread Jonathan Cameron
On 22/07/16 16:39, Joshua Clayton wrote: > Greetings Guenter, > > Thank you for reviewing my submission. > > On 07/15/2016 06:40 PM, Guenter Roeck wrote: >> On 07/15/2016 05:18 PM, Joshua Clayton wrote: >>> Add new driver for Texas Instruments ADS1118 and and ADS1018. >>> This driver works with A

Re: [PATCH v2] iio: humidity: hdc100x: add triggered buffer support for HDC100X

2016-07-23 Thread Jonathan Cameron
On 22/07/16 07:31, Alison Schofield wrote: > Triggered buffer support uses the HDC100X's dual acquisition mode > to read both humidity and temperature in one shot. > > Signed-off-by: Alison Schofield > Cc: Daniel Baluta Few bits and pieces. Didn't read your own review email closely enough to kn

Re: [PATCH v2 2/4] iio: adc: add support for Allwinner SoCs ADC

2016-07-23 Thread Jonathan Cameron
On 21/07/16 14:15, Quentin Schulz wrote: > On 20/07/2016 16:57, Jonathan Cameron wrote: >> On 19/07/16 09:33, Quentin Schulz wrote: >>> On 18/07/2016 15:18, Jonathan Cameron wrote: On 15/07/16 10:59, Quentin Schulz wrote: > [...] > + enable_irq(info->temp_data_irq); Is this hardware s

[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 10:05:12 +0200 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

Re: [PATCH 2/2] iio: accel: Add support for Domintech DMARD06 accelerometer

2016-07-23 Thread Jonathan Cameron
On 22/07/16 00:41, Peter Meerwald-Stadler wrote: > >> This patch add support for Domintech DMARD06 accelerometer. > > comments below > >> Domintech DMARD06 is a low-g tri-axial digital accelerometer for >> cost-sensitive consumer application. >> >> Signed-off-by: Aleksei Mamlin I don't have an

Re: ADS1118: hwmon or iio ? [was: Re: [RCF 1/3] hwmon: Add ads1118 driver]

2016-07-23 Thread Jonathan Cameron
On 23/07/16 03:20, Guenter Roeck wrote: > On 07/22/2016 07:39 AM, Joshua Clayton wrote: >> Greetings Guenter, >> >> Thank you for reviewing my submission. >> >> On 07/15/2016 06:40 PM, Guenter Roeck wrote: >>> On 07/15/2016 05:18 PM, Joshua Clayton wrote: Add new driver for Texas Instruments A

Re: [PATCH 1/1] iio: vcnl4000: Add IR current adjust support

2016-07-23 Thread Jonathan Cameron
On 19/07/16 08:21, Peter Meerwald-Stadler wrote: > >>> comments below; nice addition >>> >>> it seems this patch clashes with the recent changes to this driver in >>> iio-testing; can you rebase on top please? >> >> Where is iio-testing? I couldn't found it in linux. > > https://git.kernel.org/cg

Re: [PATCH 1/1] iio: vcnl4000: Add IR current adjust support

2016-07-23 Thread Jonathan Cameron
On 22/07/16 00:14, Peter Meerwald-Stadler wrote: > > comments below; nice addition > > it seems this patch clashes with the recent changes to this driver in > iio-testing; can you rebase on top please? Where is iio-testing? I couldn't found it in linux. >>> >>> https://gi

Re: [PATCH v5 2/3] iio: adc: mt2701: Add Mediatek auxadc driver for mt2701.

2016-07-23 Thread Jonathan Cameron
On 21/07/16 09:17, Zhiyong Tao wrote: > Add Mediatek auxadc driver based on iio. > It will register a device in iio and support iio. > So thermal can read auxadc channel to sample data by iio device. > It is tested successfully on mt2701 platform. > Mt8173 and mt6577 platforms are not tested. > But

[PATCH 2/3] IB/mthca: Less function calls in mthca_reset() after error detection

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 11:28:30 +0200 The kfree() function was called in a few cases by the mthca_reset() function during error handling even if the passed variables "bridge_header" and "hca_header" contained a null pointer. Adjust jump targets according to the Linux coding

[PATCH 3/3] IB/mthca: Delete unnecessary variable initialisations in mthca_reset()

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 11:54:06 +0200 Three local variables will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mthca/mthca_reset.c | 6 +++--- 1 file changed, 3 in

Why do we need reset_control_get_optional() ?

2016-07-23 Thread Masahiro Yamada
Hi. Now the reset subsystem provides a bunch of reset_control_get variants. I am still wondering why we need to have _optional ones. As far as I see, the difference is WARN_ON(1) when CONFIG_RESET_CONTROLLER is not defined. [1] When the reset is mandatory, the code of the reset consumer is p

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-23 Thread Chunhui He
On Sat, 23 Jul 2016 09:17:59 +0300 (EEST), Julian Anastasov wrote: > > In my case, the gateway refuses to send unicast packets to me, before it sees > my ARP request. So it's critical to enter REACHABLE state by sending ARP > request, but not by external confirmation. > > > What kind of

Re: [fs] bdd20132c6: BUG: sleeping function called from invalid context at fs/proc/proc_sysctl.c:1569

2016-07-23 Thread Eric W. Biederman
kernel test robot writes: > FYI, we noticed the following commit: > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git > for-testing > commit bdd20132c624a976f88b108ff37c7481c6f33e70 ("fs: Set s_user_ns to > &init_user_ns in sget when MS_KERNMOUNT") > > in testcase: b

RE: [PATCH v4 2/2] ACPI / button: Add document for ACPI control method lid device restrictions

2016-07-23 Thread Zheng, Lv
Hi, Dmitry > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Dmitry Torokhov > Subject: Re: [PATCH v4 2/2] ACPI / button: Add document for ACPI control > method lid device restrictions > > On Fri, Jul 22, 2016 at 08:37:50AM +, Zheng, Lv wrote:

Re: PM-wakeup: Delete unnecessary checks before two function calls

2016-07-23 Thread Rafael J. Wysocki
On Saturday, July 23, 2016 07:32:22 AM SF Markus Elfring wrote: > >> How do you think about to integrate this update suggestion > >> into another source code repository? > > > > I'm not really sure what you mean. > > Do you find the suggested source code change acceptable? > > http://article.gma

RE: [PATCH v4 2/2] ACPI / button: Add document for ACPI control method lid device restrictions

2016-07-23 Thread Zheng, Lv
Hi, Dmitry > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Dmitry Torokhov > Subject: Re: [PATCH v4 2/2] ACPI / button: Add document for ACPI control > method lid device restrictions > > On Fri, Jul 22, 2016 at 08:55:00AM +0200, Benjamin Tissoire

Re: [PATCH v5 1/3] ACPI / button: Add missing event to keep SW_LID running without additional event loss

2016-07-23 Thread Rafael J. Wysocki
On Friday, July 22, 2016 02:24:42 PM Lv Zheng wrote: > There are several possibilities that a lid event can be lost. For example, > EC event queue full, or the resume order of the underlying drivers. > > When the event loss happens, new event may also be lost due to the type of > the SW_LID (switc

Re: [PATCH] intel_pstate: Update cpu_frequency tracepoint every time

2016-07-23 Thread Rafael J. Wysocki
On Tuesday, July 19, 2016 08:14:53 PM Doug Smythies wrote: > On 2016.07.19 15:10 Srinivas Pandruvada wrote: > > On Tue, 2016-07-19 at 15:10 +0200, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> Currently, intel_pstate only updates the cpu_frequency tracepoint > >> if the new P-st

Re: [PATCH 00/19] x86/dumpstack: rewrite x86 stack dump code

2016-07-23 Thread Josh Poimboeuf
On Sat, Jul 23, 2016 at 02:39:52PM +0900, Linus Torvalds wrote: > On Sat, Jul 23, 2016 at 2:35 PM, Josh Poimboeuf wrote: > > > > While doing the scanning and printing, it does call the frame pointer > > unwinder in parallel, but like before, that's *only* used to determine > > whether a found addr

[PATCH] power: generic-adc-battery: Delete unnecessary checks before the function call "iio_channel_release"

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 14:50:47 +0200 The iio_channel_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring -

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-23 Thread Josh Poimboeuf
On Fri, Jul 22, 2016 at 04:52:10PM -0700, Andy Lutomirski wrote: > On Fri, Jul 22, 2016 at 4:26 PM, Andy Lutomirski wrote: > > On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf wrote: > >> valid_stack_ptr() is buggy: it assumes that all stacks are of size > >> THREAD_SIZE, which is not true for exc

Re: [PATCH] add u64 number parser

2016-07-23 Thread Alexey Dobriyan
> + ret = kstrtoull(buf, base, &val); > + if (!ret) > + *result = val; Simply pass "result" directly to kstrtoull(). It will not write the result in case of error.

Open the attachment and read through..then respond. No Virus

2016-07-23 Thread Alyce
Please view the attached file and respond back to us urgently. BAWDEN MICHAEL PHILIP.pdf Description: Adobe PDF document

How to support multiple chips in single driver

2016-07-23 Thread Pratik Prajapati
Hi, I want to add the threshold, event handling and interrupts support in vcnl4000 driver but those functionalities are not supported in vcnl4000, but supported in vcnl4010 . Do we have an example (IIO driver) of supporting multiple chips in a single driver? Note* - vcnl4010 is superset of vcnl4

Re: [PATCH] pinctrl: fix pincontrol definition for marvell

2016-07-23 Thread Sebastian Hesselbarth
On July 23, 2016 12:45:23 AM Andreas Klinger wrote: Sebastian Hesselbarth schrieb am Fri, 22. Jul 18:59: On 16.07.2016 17:07, Andreas Klinger wrote: >On Marvell mv88f6180 with pin control driver one can not use multi >purpose pins 35 through 44. >I'm using this controller on an embedded board

[usb] 25111da692: trinity-c0 invoked oom-killer: gfp_mask=0x24002c2(GFP_KERNEL|__GFP_HIGHMEM|__GFP_NOWARN), order=0, oom_score_adj=500

2016-07-23 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux Jaewon-Kim/usb-host-max3421-hcd-fix-mask-of-IO-control-register/20160723-192544 commit 25111da692292f56cb3917536c1405e2624f103d ("usb: host: max3421-hcd: fix mask of IO control register") in testcase: boo

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-23 Thread Josh Poimboeuf
On Fri, Jul 22, 2016 at 05:15:03PM -0700, Andy Lutomirski wrote: > On Fri, Jul 22, 2016 at 4:54 PM, Josh Poimboeuf wrote: > >> > +static bool in_hardirq_stack(unsigned long *stack, struct stack_info > >> > *info, > >> > +unsigned long *visit_mask) > >> > +{ > >> > +

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-23 Thread Julian Anastasov
Hello, On Sat, 23 Jul 2016, Chunhui He wrote: > On Sat, 23 Jul 2016 09:17:59 +0300 (EEST), Julian Anastasov > wrote: > > > > What kind of problem is this? Remote host wants to > > see a recent probe from us, otherwise it refuses to resolve > > our address before its traffic to us

Re: [PATCH 0/3] ARM: fix three implicit module use cases fed via gpio

2016-07-23 Thread Paul Gortmaker
[Re: [PATCH 0/3] ARM: fix three implicit module use cases fed via gpio] On 23/07/2016 (Sat 10:09) Robert Jarzmik wrote: > Paul Gortmaker writes: > [...] > > > > But with ARM and GPIO being different subsystems, we'll need to get > > this in ARM 1st, and then wait a release before changing the

Re: [PATCH 1/3] ARM: mach-omap2: remove bogus "or_module" from rx51-peripherals

2016-07-23 Thread Paul Gortmaker
[Re: [PATCH 1/3] ARM: mach-omap2: remove bogus "or_module" from rx51-peripherals] On 22/07/2016 (Fri 22:55) Tony Lindgren wrote: > * Paul Gortmaker [160722 07:02]: [...] > > Having the patch present, or having the file deleted both take care of > > my concern -- which was was introducing build

is_err checking

2016-07-23 Thread Julia Lawall
Code like the following looks a bit clunky to me: if (IS_ERR(data->clk) && PTR_ERR(data->clk) != -EPROBE_DEFER) Is there any reason not to always use eg data->clk == ERR_PTR(-EPROBE_DEFER) Code of the latter form is a bit more popular. Perhaps one could want something like: IS_ERR_VALUE(data-

Re: [kernel-hardening] [PATCH v5 03/32] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated

2016-07-23 Thread Nicolai Stange
valdis.kletni...@vt.edu writes: > On Thu, 21 Jul 2016 22:34:33 -0700, Andy Lutomirski said: > >> How much memory do you have and what's your config? My code is >> obviously buggy, but I'm wondering why neither I nor the 0day bot caught >> this. > > Probably because your devel box and the 0day bot

Re: How to support multiple chips in single driver

2016-07-23 Thread Jonathan Cameron
On 23 July 2016 14:36:39 BST, Pratik Prajapati wrote: >Hi, > >I want to add the threshold, event handling and interrupts support in >vcnl4000 driver but those functionalities are not supported in >vcnl4000, but supported in vcnl4010 . > >Do we have an example (IIO driver) of supporting multiple

[PATCH] PM-wakeup: Delete unnecessary checks before three function calls

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 17:04:00 +0200 The following functions test whether their argument is NULL and then return immediately. * dev_pm_arm_wake_irq * dev_pm_disarm_wake_irq * wakeup_source_unregister Thus the test around the calls is not needed. This issue was detected by

Re: [PATCH v2] iio: dac: ad5380: Fix probe failure when no external reference is supplied

2016-07-23 Thread kbuild test robot
-when-no-external-reference-is-supplied/20160723-221946 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: x86_64-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 reproduce: # save the attached .config to linux build tree

PROBLEM: Intel I210AT NIC resets while using PCI passthrough on ESXi (regression)

2016-07-23 Thread Foster Snowhill
[1.] One line summary of the problem: Intel I210AT NIC resets while using PCI passthrough on ESXi (regression) [2.] Full description of the problem/report: Intel I210AT NIC running on the latest (4.7-rc7) kernel revision suffers a "transmit queue 0 timed out" issue, which makes the NIC unusabl

Ceph fix for 4.7-rc8

2016-07-23 Thread Ilya Dryomov
Hi Linus, The following changes since commit 92d21ac74a9e3c09b0b01c764e530657e4c85c49: Linux 4.7-rc7 (2016-07-10 20:24:59 -0700) are available in the git repository at: https://github.com/ceph/ceph-client.git tags/ceph-for-4.7-rc8 for you to fetch changes up to 930c532869774ebf8af9efe9484c

[PATCH] tools: add fixdep to objtool/.gitignore

2016-07-23 Thread Paul Gortmaker
To fix: Untracked files: (use "git add ..." to include in what will be committed) tools/objtool/fixdep Cc: Josh Poimboeuf Signed-off-by: Paul Gortmaker --- tools/objtool/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/objtool/.gitignore b/tools/objtool/

Re: [PATCH] add u64 number parser

2016-07-23 Thread James Smart
On 7/22/2016 6:32 PM, Bart Van Assche wrote: On 07/22/16 17:23, James Smart wrote: +buf = kmalloc(len + 1, GFP_KERNEL); +if (!buf) +return -ENOMEM; +memcpy(buf, s->from, len); +buf[len] = '\0'; Hello James, Have you considered to combine the above kmalloc() and memcpy

[PATCH] printk: Initialize devkmsg_user->prev field.

2016-07-23 Thread Tetsuo Handa
kmemcheck complains that devkmsg_user->prev field is not initialized. Although it is type of enum log_flags where 0 is not defined, it will be OK to initialize with 0 as with syslog_prev and console_prev. [ 1168.537263] WARNING: kmemcheck: Caught 32-bit read from uninitialized memory (880136b

Re: How to support multiple chips in single driver

2016-07-23 Thread Pratik Prajapati
On Sat, Jul 23, 2016 at 8:37 PM, Jonathan Cameron wrote: > > > On 23 July 2016 14:36:39 BST, Pratik Prajapati > wrote: >>Hi, >> >>I want to add the threshold, event handling and interrupts support in >>vcnl4000 driver but those functionalities are not supported in >>vcnl4000, but supported in vc

[PATCH net-next 1/2] e1000e: factor out systim sanitization

2016-07-23 Thread Jarod Wilson
This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to a switch statement, rather than using an if. CC: Jeff Kirsher CC: intel-wired-...@lists.osuosl.org CC: net...@vge

[PATCH net-next 2/2] e1000e: fix PTP on e1000_pch_lpt variants

2016-07-23 Thread Jarod Wilson
I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed. Reported-by: Rupesh Patel CC: Jeff Kirsher CC: intel-wired-...@lists.osuosl.org CC: ne

[PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

2016-07-23 Thread Jarod Wilson
This little series factors out the systim sanitization code first, then adds e1000_pch_lpt as a new case in the switch that calls the sanitize function, fixing PTP clock issues I've had reported against an Intel I-218V NIC in an Intel NUC5ik5RYH system. Jarod Wilson (2): e1000e: factor out systi

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-23 Thread Chunhui He
Hello, Julian. My case is special, so I think the detail(provided below, if you are intresting) is not very important. *It only trigers the real problem*. The neigh system is to reduce ARP traffic, that is good. The problem is it fails to handle some coner cases. The coner case is (let's forget

[PATCH] x86/mm/cpa: Add missing comment in populate_pdg()

2016-07-23 Thread Andy Lutomirski
In commit 21cbc2822aa1 ("x86/mm/cpa: Unbreak populate_pgd(): stop trying to deallocate failed PUDs"), I intended to add this comment, but I failed at using git. Signed-off-by: Andy Lutomirski --- arch/x86/mm/pageattr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/mm/pageattr

[PATCH v3 0/9] adv7180 subdev fixes, v3

2016-07-23 Thread Steve Longerbeam
Steve Longerbeam (9): media: adv7180: Fix broken interrupt register access media: adv7180: define more registers media: adv7180: add support for NEWAVMODE media: adv7180: add power pin control media: adv7180: implement g_parm media: adv7180: change mbus format to UYVY v4l: Add signal

[PATCH v3 3/9] media: adv7180: add support for NEWAVMODE

2016-07-23 Thread Steve Longerbeam
Parse the optional v4l2 endpoint DT node. If the bus type is V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", configure the BT.656 bus in NEWAVMODE. Signed-off-by: Steve Longerbeam --- v3: - the newavmode endpoint property is now private to adv7180. --- .../devicetree/bindings/medi

[PATCH v3 2/9] media: adv7180: define more registers

2016-07-23 Thread Steve Longerbeam
Replace hard-coded addresses with new register macro defines. No functional changes. Signed-off-by: Steve Longerbeam Acked-by: Lars-Peter Clausen v3: no changes --- drivers/media/i2c/adv7180.c | 73 ++--- 1 file changed, 49 insertions(+), 24 deletions(-)

[PATCH v3 8/9] media: adv7180: enable lock/unlock interrupts

2016-07-23 Thread Steve Longerbeam
Enable the SD lock/unlock interrupts and send V4L2_EVENT_SRC_CH_LOCK_STATUS in the interrupt handler on a detected lock/unlock. Signed-off-by: Steve Longerbeam --- v3: no changes v2: - last version of this patch was based on the old reverted autodetect code. This version now only enables the

[PATCH v3 7/9] v4l: Add signal lock status to source change events

2016-07-23 Thread Steve Longerbeam
Add a signal lock status change to the source changes bitmask. This indicates there was a signal lock or unlock event detected at the input of a video decoder. Signed-off-by: Steve Longerbeam Cc: Mauro Carvalho Chehab --- v3: no changes v2: no changes --- Documentation/DocBook/media/v4l/vidioc

[PATCH v3 9/9] media: adv7180: fix field type

2016-07-23 Thread Steve Longerbeam
The ADV7180 and ADV7182 transmit whole fields, bottom field followed by top (or vice-versa, depending on detected video standard). So for chips that do not have support for explicitly setting the field mode, set the field mode to SEQ_BT for PAL, and SEQ_TB for NTSC (there seems to be conflicting in

[PATCH v3 1/9] media: adv7180: Fix broken interrupt register access

2016-07-23 Thread Steve Longerbeam
Access to the interrupt page registers has been broken since at least commit 3999e5d01da7 ("[media] adv7180: Do implicit register paging"). That commit forgot to add the interrupt page number to the register defines. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey Ack

[PATCH v3 5/9] media: adv7180: implement g_parm

2016-07-23 Thread Steve Longerbeam
Implement g_parm to return the current standard's frame period. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey --- v3: no changes v2: no changes --- drivers/media/i2c/adv7180.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/medi

[PATCH v3 4/9] media: adv7180: add power pin control

2016-07-23 Thread Steve Longerbeam
Some targets control the ADV7180 power pin via a gpio, so add optional support for "powerdown" pin control. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey Acked-by: Lars-Peter Clausen --- v3: no changes v2: - placed call to gpiod_get inline in adv7180_probe(). -

[PATCH v3 6/9] media: adv7180: change mbus format to UYVY

2016-07-23 Thread Steve Longerbeam
Change the media bus format from YUYV8_2X8 to UYVY8_2X8. Colors now look correct when capturing with the i.mx6 backend. Signed-off-by: Steve Longerbeam Tested-by: Tim Harvey Acked-by: Tim Harvey Acked-by: Lars-Peter Clausen Acked-by: Niklas Söderlund --- v3: no changes v2: no changes --- dr

Re: [PATCH] vfs:Fix memory leak on error path in get_empty_file

2016-07-23 Thread Theodore Ts'o
On Fri, Jul 22, 2016 at 11:47:35AM +0100, Catalin Marinas wrote: > I can't find the original post (probably it only went to the > linux-fsdevel list), so replying to Nicholas here: You couldn't find the original post because there is a *reason* why Nick has been banned from bugzilla.kernel.org, an

[PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc"

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 18:54:02 +0200 The gpiochip_free_own_desc() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: How to support multiple chips in single driver

2016-07-23 Thread Jonathan Cameron
On 23 July 2016 17:38:07 BST, Pratik Prajapati wrote: >On Sat, Jul 23, 2016 at 8:37 PM, Jonathan Cameron > wrote: >> >> >> On 23 July 2016 14:36:39 BST, Pratik Prajapati > wrote: >>>Hi, >>> >>>I want to add the threshold, event handling and interrupts support in >>>vcnl4000 driver but those fun

Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<

2016-07-23 Thread Joe Perches
On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: > From: Emoly Liu unrelated trivial notes: > diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h > b/drivers/staging/lustre/lustre/obdecho/echo_internal.h [] > @@ -33,9 +33,9 @@ >   >  /* The persistent object (i.e. actually s

[PATCH] omapfb: panel-dsi-cm: Delete an unnecessary check before backlight_device_unregister()

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 19:29:28 +0200 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elf

Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<

2016-07-23 Thread Oleg Drokin
On Jul 23, 2016, at 1:31 PM, Joe Perches wrote: > On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: >> From: Emoly Liu > > unrelated trivial notes: > >> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h >> b/drivers/staging/lustre/lustre/obdecho/echo_internal.h > [] >> @@

[GIT PULL] KVM bonus fix for 4.7

2016-07-23 Thread Radim Krčmář
Linus, it is possible that you read this pull request before the reverty one from last Saturday that was asking to pull tags/for-linus ("[GIT PULL] KVM fixes for 4.7-rc8") and therefore could pull uncommented changes with this one. I am sorry for the inconvenience. The following changes since co

[PATCH] coresight: tmc: Delete an unnecessary check before the function call "kfree"

2016-07-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 23 Jul 2016 20:04:09 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hwt

Re: [PATCH] mfd: arizona: Remove pointless switch case

2016-07-23 Thread Bernd Petrovitsch
Hi all! On Fri, 2016-07-22 at 16:58 +0100, Charles Keepax wrote: [...] >   case IRQF_TRIGGER_RISING: >   case IRQF_TRIGGER_FALLING: >   break; > - > - case IRQ_TYPE_NONE: >   default: Don't know about the kernels coding rule in t

[PATCH] list: Expand list_first_entry_or_null()

2016-07-23 Thread Chris Wilson
Due to the use of READ_ONCE() in list_empty() the compiler cannot optimise !list_empty() ? list_first_entry() : NULL very well. By manually expanding list_first_entry_or_null() we can take advantage of the READ_ONCE() to avoid the list element changing under the test while the compiler can generate

Re: [RFC PATCH 1/2] mempool: do not consume memory reserves from the reclaim path

2016-07-23 Thread Vlastimil Babka
On 07/22/2016 09:44 PM, Andrew Morton wrote: > On Fri, 22 Jul 2016 14:26:19 +0200 Vlastimil Babka wrote: > >> On 07/22/2016 08:37 AM, Michal Hocko wrote: >>> On Thu 21-07-16 16:53:09, Michal Hocko wrote: From d64815758c212643cc1750774e2751721685059a Mon Sep 17 00:00:00 2001 From: Michal

[PATCH] staging: sm750fb: Fix block comment style

2016-07-23 Thread Edward Lipinsky
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Edward Lipinsky --- drivers/staging/sm750fb/ddk750_dvi.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/stagi

[PATCH] spi: pic32-sqi: fixup wait_for_completion_timeout return handling

2016-07-23 Thread Nicholas Mc Guire
wait_for_completion_timeout returns unsigned long not int so the check for <= 0 should be == 0 here, and the type unsigned long. The function return is set to -ETIMEDOUT to reflect the actual problem. Signed-off-by: Nicholas Mc Guire --- the only call site of pic32_sqi_one_messag() is in drivers

Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-23 Thread Julian Anastasov
Hello, On Sat, 23 Jul 2016, Chunhui He wrote: > The neigh system is to reduce ARP traffic, that is good. The problem is it > fails > to handle some coner cases. > > The coner case is (let's forget my case above): > In NUD_DELAY, the neigh system is waiting for a proof of reachablity. I

Re: [tip:x86/mm] x86/mm/cpa: Fix populate_pgd(): Stop trying to deallocate failed PUDs

2016-07-23 Thread Ingo Molnar
* Linus Torvalds wrote: > On Sat, Jul 23, 2016 at 4:46 PM, tip-bot for Andy Lutomirski > wrote: > > > > Fixing this directly is difficult or impossible because of the awful > > state of Linux's page table accessors. > > Quite frankly, this part of the message is misleading and wrong. Fair eno

[tip:x86/mm] x86/mm/cpa: Fix populate_pgd(): Stop trying to deallocate failed PUDs

2016-07-23 Thread tip-bot for Andy Lutomirski
Commit-ID: 530dd8d4b9daf77e3e5d145a26210d91ced954c7 Gitweb: http://git.kernel.org/tip/530dd8d4b9daf77e3e5d145a26210d91ced954c7 Author: Andy Lutomirski AuthorDate: Fri, 22 Jul 2016 21:58:08 -0700 Committer: Ingo Molnar CommitDate: Sat, 23 Jul 2016 21:13:25 +0200 x86/mm/cpa: Fix populate

[tip:x86/mm] x86/mm/cpa: Add missing comment in populate_pdg()

2016-07-23 Thread tip-bot for Andy Lutomirski
Commit-ID: 55920d31f1e3fea06702c74271dd56c4fc9b70ca Gitweb: http://git.kernel.org/tip/55920d31f1e3fea06702c74271dd56c4fc9b70ca Author: Andy Lutomirski AuthorDate: Sat, 23 Jul 2016 09:59:28 -0700 Committer: Ingo Molnar CommitDate: Sat, 23 Jul 2016 21:17:10 +0200 x86/mm/cpa: Add missing

[PATCH] spi: pic32: fixup wait_for_completion_timeout return handling

2016-07-23 Thread Nicholas Mc Guire
wait_for_completion_timeout returns unsigned long not int so the check for <= 0 should be == 0 here. Signed-off-by: Nicholas Mc Guire --- API non-compliance was located by coccinelle Compile tested with: pic32mzda_defconfig + CONFIG_SPI=y, CONFIG_SPI_PIC32=m Patch is against 4.7.0-rc7 (localve

Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)

2016-07-23 Thread Alexei Starovoitov
On Fri, Jul 22, 2016 at 05:05:27PM -0700, Sargun Dhillon wrote: > It was tested with the tracex7 program on x86-64. it's my fault to start tracexN tradition that turned out to be cumbersome, let's not continue it. Instead could you rename it to something meaningful? Like test_probe_write_user ? Ri

  1   2   >