[PATCH 4.4 37/73] tipc: fix NULL pointer dereference in shutdown()

2016-09-28 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Vegard Nossum [ Upstream commit d2fbdf76b85bcdfe57b8ef2ba09d20e8ada79abd ] tipc_msg_create() can return a NULL skb and if so, we shouldn't try to call tipc_node_xmit_skb() on it. general

[PATCH 4.4 17/73] tools: Support relative directory path for O=

2016-09-28 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Josh Poimboeuf commit e17cf3a80d4ba0c4e40bf1a89deb1354c2e10e14 upstream. Running "make O=foo" (with a relative directory path) fails with: scripts/Makefile.include:3: *** O=foo does not exis

Re: UFS API in the kernel

2016-09-28 Thread Joao Pinto
Hi Subhash, On 9/28/2016 12:05 AM, subha...@codeaurora.org wrote: > Hi Joao, > > > On 2016-09-26 18:10, Kiwoong Kim wrote: >> Hi. >> >> If you want to declare some things for user interface, >> is it be better to put those thing include/uapi/linux/ than include/linux? >> >> Agreed with Mr. Pint

[PATCH 4.4 16/73] Makefile: revert "Makefile: Document ability to make file.lst and file.S" partially

2016-09-28 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Wang YanQing commit 40ab87a4003c7952976ce901a2b9ece5ed833168 upstream. Commit 627189797807 ("Makefile: Document ability to make file.lst and file.S") document ability to make file.S, but there

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
--- drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index e9f25dd..0883715 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft

Re: BUG: scheduling while atomic in f_fs when gadget remove driver

2016-09-28 Thread Chen Yu
Hi, 在 2016/9/27 18:01, Felipe Balbi 写道: > > Hi, > > Chen Yu writes: >> Hi All, >> >> I'm working on Hikey board based around the HiSilicon Kirin 620, with >> linaro kernel version 4.8.rc1 and I get below BUG error while >> extracting USB cable from PC. > > which peripheral controller does this

RE: [PATCH v6 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system

2016-09-28 Thread Tan, Jui Nee
> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Tuesday, August 9, 2016 3:16 PM > To: Tan, Jui Nee > Cc: mika.westerb...@linux.intel.com; heikki.kroge...@linux.intel.com; > andriy.shevche...@linux.intel.com; t...@linutronix.de; > mi...@redhat.com; h...@zytor.

[PATCH v7 0/6] pinctrl/broxton: enable platform device in the absent of ACPI enumeration

2016-09-28 Thread Tan Jui Nee
Hi, The patches are to cater the need for non-ACPI system whereby a platform device has to be created in order to bind with Apollo Lake Pinctrl GPIO platform driver. The MMIO BAR is accessed over the Primary to Sideband bridge (P2SB). Since the BIOS prevents the P2SB device from being enumerated b

[PATCH v7 3/6] x86/intel-ivi: Add Intel In-Vehicle Infotainment (IVI) systems used in cars support

2016-09-28 Thread Tan Jui Nee
Add support for non ACPI system, such as system that uses Advanced Boot Loader (ABL) whereby a platform device has to be created in order to bind with PINCTRL/GPIO. At the moment, Intel Apollo Lake SoC requires P2SB driver to hide and unhide P2SB to lookup P2SB BAR and pass the PCI BAR address to

[PATCH v7 4/6] mfd: move enum lpc_chipsets into lpc_ich.h

2016-09-28 Thread Tan Jui Nee
Move the enum's definition into a standalone header file which can be used wherever its definition is needed. Signed-off-by: Tan Jui Nee --- drivers/mfd/lpc_ich-core.c | 71 - include/linux/mfd/lpc_ich.h | 71 ++

[PATCH v7 6/6] mfd: lpc_ich: Add support for Intel Apollo Lake GPIO pinctrl in non-ACPI system

2016-09-28 Thread Tan Jui Nee
This driver uses the P2SB hide/unhide mechanism cooperatively to pass the PCI BAR address to the gpio platform driver. Signed-off-by: Tan Jui Nee --- Changes in V7: - Add author information and rewrite description of source file lpc_ich-apl.c and lpc_ich_apl.h. - Sort t

[PATCH v7 2/6] mfd: lpc_ich: Rename lpc-ich driver

2016-09-28 Thread Tan Jui Nee
This patch follows the example of mfd/wm831x to rename the driver from "lpc_ich" to "lpc_ich-core". Signed-off-by: Tan Jui Nee --- Changes in V7: - No change Changes in V6: - none, just a subject line and commit message change. drivers/mfd/Makefile | 1 + d

[PATCH v7 1/6] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-09-28 Thread Tan Jui Nee
From: Andy Shevchenko There is already one and at least one more user coming which require an access to Primary to Sideband bridge (P2SB) in order to get IO or MMIO bar hidden by BIOS. Create a driver to access P2SB for x86 devices. Signed-off-by: Yong, Jonathan Signed-off-by: Andy Shevchenko

[PATCH v7 5/6] mfd: lpc_ich: Add Device IDs for Intel Apollo Lake PCH

2016-09-28 Thread Tan Jui Nee
Adding Intel codename Apollo Lake platform device IDs for PCH. Signed-off-by: Tan Jui Nee --- drivers/mfd/lpc_ich-core.c | 6 ++ include/linux/mfd/lpc_ich.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/mfd/lpc_ich-core.c b/drivers/mfd/lpc_ich-core.c index 05ed985..589155c 1

Re: UFS API in the kernel

2016-09-28 Thread Joao Pinto
I was able to get the 7 patches to have the UFS IOCTL features from your repo. BTW, why weren't these features submitted to the kernel? I checked lots of tweaks that you have been making to the UFS... do you synchronize them periodically with the mainline? Thanks! On 9/28/2016 10:19 AM, Joao Pint

[PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Carlos Palminha
Improve code readability. Signed-off-by: Carlos Palminha --- Changes v1->v2: - Added signed-off-by and comment. drivers/staging/fbtft/fbtft_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_devi

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hi Pavel, Le 24. 09. 16 à 13:58, Pavel Machek a écrit : > Hi! > >> +Example >> +=== >> + >> +led1: ncp5623@38 { >> +#address-cells = <1>; >> +#size-cells = <0>; >> +compatible = "onnn,ncp5623"; >> +reg = <0x38>; >> +onnn,led-iref-microamp = <10>; >> + >> +led1r@0 { >>

RE: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Wu, Feng
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Wednesday, September 28, 2016 5:20 AM > To: linux-kernel@vger.kernel.org; k...@vger.kernel.org > Cc: yang.zhang...@gmail.com; Wu, Feng ; > m...@redhat.com; rkrc...@redhat.com >

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hello Jacek, Le 24. 09. 16 à 21:06, Jacek Anaszewski a écrit : > On 09/24/2016 01:58 PM, Pavel Machek wrote: >> Hi! >> >>> +Example >>> +=== >>> + >>> +led1: ncp5623@38 { >>> +#address-cells = <1>; >>> +#size-cells = <0>; >>> +compatible = "onnn,ncp5623"; >>> +reg = <0x38>; >>>

Re: [PATCH] staging: fbtft: Fix checkpatch warning

2016-09-28 Thread Greg KH
On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote: > Improve code readability. You are doing multiple things in the same patch, and you don't really tell us what you are doing, or why you are doing it... Please take a step back, relax, and wait a day before resending a patch series

Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event

2016-09-28 Thread Prarit Bhargava
On 09/28/2016 02:48 AM, Peter Zijlstra wrote: > On Tue, Sep 27, 2016 at 11:26:14AM -0400, Prarit Bhargava wrote: >> I see now that the issue is not understanding the difference between physical >> and soft thread removal. I will write that up and get back to everyone. > > You don't seem to unde

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 05:03 AM, Cyrill Gorcunov wrote: In criu we are actively using diag interface to collect sockets present in the system when dumping applications. And while for unix, tcp, udp[lite], packet, netlink it works as expected, the raw sockets do not have. Thus add it. v2: - add missing soc

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Peter Zijlstra
On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 8fb4d1942c14..4a2d3ff772f8 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3142,7 +3142,7 @@ enqueue_entity_load_avg(struct cfs_rq *cfs_rq, struct > s

Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Paolo Bonzini
On 28/09/2016 12:04, Wu, Feng wrote: > > >> -Original Message- >> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo >> Bonzini >> Sent: Wednesday, September 28, 2016 5:20 AM >> To: linux-kernel@vger.kernel.org; k...@vger.kernel.org >> Cc: yang.zhang...@gmail.com; W

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... > > @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { > > __u8sdiag_family; > > __u8sdiag_protocol; > > __u8idiag_ext; > > - __u8pad; > > + union { > > + __u8pad; > > + __u8s

Re: [PATCH 3/4] autofs - make mountpoint checks namespace aware

2016-09-28 Thread Ian Kent
On Fri, 2016-09-23 at 20:00 +0800, Ian Kent wrote: > On Fri, 2016-09-23 at 12:26 +0800, Ian Kent wrote: > > On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote: > > > Ian Kent writes: > > > > > > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote: > > > > > Ian Kent writes: > >

Re: Regression in mobility grouping?

2016-09-28 Thread Mel Gorman
On Tue, Sep 27, 2016 at 09:41:48PM -0400, Johannes Weiner wrote: > Hi guys, > > we noticed what looks like a regression in page mobility grouping > during an upgrade from 3.10 to 4.0. Identical machines, workloads, and > uptime, but /proc/pagetypeinfo on 3.10 looks like this: > > Number of blocks

[PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

2016-09-28 Thread shyam saini
Remove the explicit NULL comparison and rewrite in a compact form and fixed switch case indentation issue. Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/io

Re: [PATCH V2] checkpatch: Improve the octal permissions tests

2016-09-28 Thread Ramiro Oliveira
On 9/28/2016 4:05 AM, Joe Perches wrote: > Signed-off-by: Joe Perches > --- > > V2: Move the SYMBOLIC_PERMS test. > > scripts/checkpatch.pl | 60 > +-- > 1 file changed, 44 insertions(+), 16 deletions(-) Tested-by: Ramiro Oliveira

[PATCH] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE.

2016-09-28 Thread ming.ling
Non-lru pages don't belong to any lru, so accounting them to NR_ISOLATED_ANON or NR_ISOLATED_FILE doesn't make any sense. It may misguide functions such as pgdat_reclaimable_pages and too_many_isolated. This patch adds NR_ISOLATED_NONLRU to vmstat and moves isolated non-lru pages from NR_ISOLATED_

[PATCH] ramoops: add pdata NULL check to ramoops_probe

2016-09-28 Thread Geliang Tang
When the pdata is NULL, ramoops_probe() segfaults. So this patch adds a NULL check to it. Signed-off-by: Geliang Tang --- fs/pstore/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 6ad831b..dd9832d 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/r

[PATCH] crypto/caam/jr : Unmap region obtained by of_iomap

2016-09-28 Thread Arvind Yadav
From: Arvind Yadav Free memory mapping, if probe is not successful. Signed-off-by: Arvind Yadav --- drivers/crypto/caam/jr.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index a81f551..9e7f281 100644 --- a/drivers/crypto/caam/jr.c +

[PATCH 2/4] ARM: davinci: devices: Remove DMA resources for MMC

2016-09-28 Thread Peter Ujfalusi
The driver is converted to not use the DMA resource. Signed-off-by: Peter Ujfalusi --- arch/arm/mach-davinci/devices.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-davinci/devices.c b/arch/arm/mach-davinci/devices.c index 67d26c5bda0b..3ae70f2909b0 100644 --- a/arch/arm/ma

[PATCH 0/4] ARM: davinci: Remove DMA resources for MMC/SPI

2016-09-28 Thread Peter Ujfalusi
Hi, The drivers for davinci MMC and SPI have been converted to the new DMAengine API and no longer rely on the IORESOURCE_DMA. This is the case for at least one release cycle so now we can remove the IORESOURCE_DMA for these devices. Regards, Peter --- Peter Ujfalusi (4): ARM: davinci: devices-

[PATCH 4/4] ARM: davinci: dm365: Remove DMA resources for SPI

2016-09-28 Thread Peter Ujfalusi
The driver is converted to not use the DMA resource. Signed-off-by: Peter Ujfalusi --- arch/arm/mach-davinci/dm365.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index ef3add999263..8be04ec95adf 100644 --- a/arch/arm/mac

[PATCH 3/4] ARM: davinci: dm355: Remove DMA resources for SPI

2016-09-28 Thread Peter Ujfalusi
The driver is converted to not use the DMA resource. Signed-off-by: Peter Ujfalusi --- arch/arm/mach-davinci/dm355.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/arm/mach-davinci/dm355.c b/arch/arm/mach-davinci/dm355.c index d33322ddedab..bd50367f654e 100644 --- a/arch/arm/mac

[PATCH 1/4] ARM: davinci: devices-da8xx: Remove DMA resources for MMC and SPI

2016-09-28 Thread Peter Ujfalusi
The drivers are now converted to not use the DMA resource. Signed-off-by: Peter Ujfalusi --- arch/arm/mach-davinci/devices-da8xx.c | 29 - 1 file changed, 29 deletions(-) diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c inde

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:17 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote: ... @@ -38,7 +38,10 @@ struct inet_diag_req_v2 { __u8sdiag_family; __u8sdiag_protocol; __u8idiag_ext; - __u8pad; + union { +

[PATCH] firmware: qcom: scm: Fix interrupted SCM calls fully

2016-09-28 Thread Sricharan R
Patch [1] fixes the issues with interrupted SCM64 calls by returning the register r6 (Session ID) on the next try, but register r0 also needs to be preserved for the retry. r0 contains the result of the previous try. Without this i see that the SCM calls hang when retried. [1] https://patchwork.ke

Re: [Update][RFC/RFT][PATCH v3 2/5] driver core: Functional dependencies tracking support

2016-09-28 Thread Lukas Wunner
On Tue, Sep 27, 2016 at 01:52:48PM +0200, Rafael J. Wysocki wrote: > On Tue, Sep 27, 2016 at 10:54 AM, Lukas Wunner wrote: > > On Fri, Sep 16, 2016 at 02:33:55PM +0200, Rafael J. Wysocki wrote: > >> +void device_links_unbind_consumers(struct device *dev) > >> +{ > >> + struct device_link *link

[PATCH] dma/fsldma : Unmap region obtained by of_iomap

2016-09-28 Thread Arvind Yadav
Free memory mapping, if probe is not successful. Signed-off-by: Arvind Yadav --- drivers/dma/fsldma.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 911b717..7ba8944 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/f

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: ... > > > > Someone may have set it to zero explicitly on source level, and the > > compilation will fail on new kernel then. So no, keeping the name > > is reasonable. > > > > I dont know how compilation will fail but you may be

Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()

2016-09-28 Thread Jyri Sarha
On 09/27/16 18:29, Bartosz Golaszewski wrote: > Some architectures don't use the common clock framework and don't > implement all the clk interfaces for every clock. This is the case > for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1. > > Trying to set the clock rate for the LCDC c

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Pavel Machek
On Wed 2016-09-28 12:02:41, Florian Vaussard wrote: > Hi Pavel, > > Le 24. 09. 16 à 13:58, Pavel Machek a écrit : > > Hi! > > > >> +Example > >> +=== > >> + > >> +led1: ncp5623@38 { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + compatible = "onnn,ncp5623"; > >> + reg = <0x

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Dietmar Eggemann
On 28/09/16 11:14, Peter Zijlstra wrote: > On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 8fb4d1942c14..4a2d3ff772f8 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -3142,7 +3142,7 @@ enqueue_en

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 06:51 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 06:43:01AM -0400, Jamal Hadi Salim wrote: [..] I dont know how compilation will fail but you may be right with note: that is not how pads have been used in the past. They are supposed to cosmetic annotation which indicates "h

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Peter Zijlstra
On Wed, Sep 28, 2016 at 12:06:43PM +0100, Dietmar Eggemann wrote: > On 28/09/16 11:14, Peter Zijlstra wrote: > > On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: > >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > >> index 8fb4d1942c14..4a2d3ff772f8 100644 > >> --- a/kernel/s

Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()

2016-09-28 Thread Tomi Valkeinen
Hi, On 27/09/16 18:29, Bartosz Golaszewski wrote: > Some architectures don't use the common clock framework and don't > implement all the clk interfaces for every clock. This is the case > for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1. > > Trying to set the clock rate for the L

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: > > > > This structure is uapi, so anyone has complete rights to reference > > @pad in the userspace programs. Sure it would be more clear to remove > > the @pad completely, but if we choose so I think it's better to do > > on top i

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Dietmar Eggemann
On 28/09/16 12:19, Peter Zijlstra wrote: > On Wed, Sep 28, 2016 at 12:06:43PM +0100, Dietmar Eggemann wrote: >> On 28/09/16 11:14, Peter Zijlstra wrote: >>> On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: [...] >> Not sure what you mean by 'after fixing' but the se is initialized wi

Re: [Update][RFC/RFT][PATCH v3 2/5] driver core: Functional dependencies tracking support

2016-09-28 Thread Rafael J. Wysocki
On Wed, Sep 28, 2016 at 12:43 PM, Lukas Wunner wrote: > On Tue, Sep 27, 2016 at 01:52:48PM +0200, Rafael J. Wysocki wrote: >> On Tue, Sep 27, 2016 at 10:54 AM, Lukas Wunner wrote: >> > On Fri, Sep 16, 2016 at 02:33:55PM +0200, Rafael J. Wysocki wrote: >> >> +void device_links_unbind_consumers(str

Re: [PATCH 1/5] ISDN-Gigaset: Use kmalloc_array() in two functions

2016-09-28 Thread Paul Bolle
On Mon, 2016-09-26 at 17:38 +0200, SF Markus Elfring wrote: > * Multiplications for the size determination of memory allocations >   indicated that array data structures should be processed. >   Thus use the corresponding function "kmalloc_array". Was the current code incorrect? What makes kmalloc

RE: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Wu, Feng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, September 28, 2016 4:22 PM > To: Michael S. Tsirkin > Cc: linux-kernel@vger.kernel.org; k...@vger.kernel.org; > yang.zhang...@gmail.com; Wu, Feng ; > rkrc...@redhat.com > Subject: Re: [PATCH 2/3] k

Re: [RFC/RFT][PATCH v3 0/5] Functional dependencies between devices

2016-09-28 Thread Lukas Wunner
On Wed, Sep 28, 2016 at 02:33:21AM +0200, Rafael J. Wysocki wrote: > On Tuesday, September 27, 2016 02:34:29 PM Lukas Wunner wrote: > > I made some notes while reviewing the state machine in patch 2 of this > > series and thought, why not rework it into something that could eventually > > go into t

Re: [PATCH 3/5] ISDN-Gigaset: Delete an error message for a failed memory allocation

2016-09-28 Thread Paul Bolle
On Tue, 2016-09-27 at 12:57 +0200, Tilman Schmidt wrote: > On Mon, Sep 26, 2016, at 17:42, SF Markus Elfring wrote: > > Omit an extra message for a memory allocation failure in this > > function. > > > > Link: > > http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-R > > efactor_Stri

Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()

2016-09-28 Thread Bartosz Golaszewski
+ Sekhar 2016-09-28 13:19 GMT+02:00 Tomi Valkeinen : > Hi, > > On 27/09/16 18:29, Bartosz Golaszewski wrote: >> Some architectures don't use the common clock framework and don't >> implement all the clk interfaces for every clock. This is the case >> for da850-lcdk where clk_set_rate() only works

Re: [PATCH 1/2] PM / sleep: Return RPM_SUSPENDED to keep devices in runtime-suspended

2016-09-28 Thread Rafael J. Wysocki
On Wed, Sep 28, 2016 at 5:26 AM, Chen Yu wrote: > Currently if the ->prepare() callback of a device returns a positive number, > the PM core will regard that as an indication that it may leave the > device runtime-suspended. However it would be more convenient to define > this positive number then

[PATCH 1/2] perf intel-pt: Fix estimated timestamps for cycle-accurate mode

2016-09-28 Thread Adrian Hunter
In cycle-accurate mode, timestamps can be calculated from CYC packets. The decoder also estimates timestamps based on the number of instructions since the last timestamp. For that to work in cycle-accurate mode, the instruction count needs to be reset to zero when a timestamp is calculated from a C

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Vincent Guittot
On 28 September 2016 at 04:31, Dietmar Eggemann wrote: > On 28/09/16 12:19, Peter Zijlstra wrote: >> On Wed, Sep 28, 2016 at 12:06:43PM +0100, Dietmar Eggemann wrote: >>> On 28/09/16 11:14, Peter Zijlstra wrote: On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: > > [...] > >>> Not

[PATCH 2/2] perf intel-pt: Fix MTC timestamp calculation for large MTC periods

2016-09-28 Thread Adrian Hunter
The MTC packet provides a 8-bit slice of CTC which is related to TSC by the TMA packet, however the TMA packet only provides the lower 16 bits of CTC. If mtc_shift > 8 then some of the MTC bits are not in the CTC provided by the TMA packet. Fix-up the last_mtc calculated from the TMA packet by copy

Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Paolo Bonzini
On 28/09/2016 13:40, Wu, Feng wrote: > IIUIC, the issue you describe above is that IPI for posted-interrupts may be > issued between > > vcpu->mode = IN_GUEST_MODE; > > and > > local_irq_disable(); > > But if that really happens, we will call kvm_vcpu_kick() in > vmx_deliver_posted_interrupt(

RE: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Wu, Feng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, September 28, 2016 6:17 PM > To: Wu, Feng ; linux-kernel@vger.kernel.org; > k...@vger.kernel.org > Cc: yang.zhang...@gmail.com; m...@redhat.com; rkrc...@redhat.com > Subject: Re: [PATCH 2/3] kvm: x8

Re: [PATCH] drm: tilcdc: add a workaround for failed clk_set_rate()

2016-09-28 Thread Tomi Valkeinen
On 28/09/16 14:43, Bartosz Golaszewski wrote: > how far is far enough to emit a warning? On da850 the requested rate > is 22800 Hz, while the calculated divider is 6, which results in > the real rate of 22500 Hz. This is less than 1% difference - > should we take this value as reference?

Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Paolo Bonzini
On 28/09/2016 13:53, Wu, Feng wrote: >> > - update_cr8_intercept is disabled if APICv, see vmx.c: >> > >> > if (enable_apicv) >> > kvm_x86_ops->update_cr8_intercept = NULL; > Which tree are you using, I am using linux kernel tree with Linux 4.8-rc7, > and I only see the f

Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-28 Thread Paul Bolle
On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): >   Use kmalloc_array() in two functions >   Improve another size determination in gigaset_initcs() >   Delete an error message

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Vincent Guittot
On 28 September 2016 at 04:46, Vincent Guittot wrote: > On 28 September 2016 at 04:31, Dietmar Eggemann > wrote: >> On 28/09/16 12:19, Peter Zijlstra wrote: >>> On Wed, Sep 28, 2016 at 12:06:43PM +0100, Dietmar Eggemann wrote: On 28/09/16 11:14, Peter Zijlstra wrote: > On Fri, Sep 23, 20

Re: [PATCH 2/2] hid: input: add HID_QUIRK_REUSE_AXES and fix dragonrise

2016-09-28 Thread Ioan-Adrian Ratiu
On Wed, 28 Sep 2016, Vladislav Naumov wrote: > On Tue, Sep 27, 2016 at 10:44 PM, Ioan-Adrian Ratiu wrote: >> Can you please wait a little until I post v2 later today and test v2 >> directly? Because the change in it's current form has no effect on >> 0079:0011 (the current quirk is enabled only f

RE: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Wu, Feng
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, September 28, 2016 7:50 PM > To: Wu, Feng ; Michael S. Tsirkin > Cc: linux-kernel@vger.kernel.org; k...@vger.kernel.org; > yang.zhang...@gmail.com; rkrc...@redhat.com > Subject: Re: [PATCH 2/3] kvm

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 07:27 AM, Cyrill Gorcunov wrote: On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: This structure is uapi, so anyone has complete rights to reference @pad in the userspace programs. Sure it would be more clear to remove the @pad completely, but if we choose so I thin

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Cyrill Gorcunov Date: Wed, 28 Sep 2016 14:27:03 +0300 > On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: >> > >> > This structure is uapi, so anyone has complete rights to reference >> > @pad in the userspace programs. Sure it would be more clear to remove >> > the @pad co

RE: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Wu, Feng
> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Paolo Bonzini > Sent: Wednesday, September 28, 2016 7:55 PM > To: Wu, Feng ; linux-kernel@vger.kernel.org; > k...@vger.kernel.org > Cc: yang.zhang...@gmail.com; m...@redhat.com; rkrc..

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

2016-09-28 Thread Vladimir Zapolskiy
On 09/28/2016 06:38 AM, Stefan Agner wrote: On 2016-09-27 19:00, Viresh Kumar wrote: On 27-09-16, 12:34, Stefan Agner wrote: Added Viresh Kumar to the discussion, he implemented the I2C recovery functions. Yes, reordering the pinctrl/gpio_free calls would fix the problem too. However, I gue

Re: [PATCH 1/1] Staging: android: ion : Remove explicit NULL comparison and Fixed coding style

2016-09-28 Thread Greg KH
On Wed, Sep 28, 2016 at 03:55:32PM +0530, shyam saini wrote: > Remove the explicit NULL comparison and rewrite in a compact form and > fixed switch case indentation issue. If you need "and" in a subject: line for a patch, that's a huge hint that this needs to be at least 2 patches. Please only ev

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'. So we have to keep that member around, at a minimum, for their sake. I think we need to start labelling any new pad

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:06:51 -0400 > I understood well your point;-> Maybe my response was not clear: > _nobody should be fscking fondling pad fields_ setting them or > otherwise. Especially considering potential future uses of the field, existing users absolutely must

Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv interrupt injection

2016-09-28 Thread Paolo Bonzini
On 28/09/2016 14:06, Wu, Feng wrote: >> Then the >> > guest is entered with PIR.ON, but the PI interrupt is not pending and >> > hence the interrupt is never delivered to the guest. > Why "never", at least, the interrupt should be delivered to the guest in the > next > vm-entry, right? I mean

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread David Miller
From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 > On 16-09-28 08:07 AM, David Miller wrote: > >> Right, it would be legal for an existing user to have code that >> explicitly initializes every member of the structure, including 'pad'. >> So we have to keep that member around, at a m

[BUG] checkpatch hangs at value annotation

2016-09-28 Thread Jan Höppner
Hi Andy, when I check the following patch example with checkpatch it will hang forever. diff --git a/test.c b/test.c index 88c2eb0cb608..583625fdb715 100644 --- a/test.c +++ b/test.c @@ -1 +1,3 @@ uint## BITS ##_t foobar; + +printk(KERN_WARNING "DEBUG: FOOBAR\n"); The hang is due to the spaces

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:07:01AM -0400, David Miller wrote: ... > > > > I think you miss the point what I'm trying to say: currently end-user > > may have reference to this member (for any reason) and his program > > will compile and run. If we change the name the compilation procedure > > fails

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:06:51AM -0400, Jamal Hadi Salim wrote: > > I understood well your point;-> Maybe my response was not clear: > _nobody should be fscking fondling pad fields_ setting them or > otherwise. > Maybe let these programs fail. I asked if you knew any such app which > did anythin

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member of the structure, including 'pad'. So we have t

Re: [PATCH] sched/fair: Do not decay new task load on first enqueue

2016-09-28 Thread Vincent Guittot
On 28 September 2016 at 04:31, Dietmar Eggemann wrote: > On 28/09/16 12:19, Peter Zijlstra wrote: >> On Wed, Sep 28, 2016 at 12:06:43PM +0100, Dietmar Eggemann wrote: >>> On 28/09/16 11:14, Peter Zijlstra wrote: On Fri, Sep 23, 2016 at 12:58:08PM +0100, Matt Fleming wrote: > > [...] > >>> Not

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Marcelo Cerri
Hi Herbert, On Wed, Sep 28, 2016 at 10:45:49AM +0800, Herbert Xu wrote: > On Tue, Sep 27, 2016 at 04:46:44PM -0300, Marcelo Cerri wrote: > > > > Can you check if the problem occurs with this patch? > > In light of the fact that padlock-sha is the correct example > to follow, you only need to add o

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Herbert Xu
On Wed, Sep 28, 2016 at 03:40:51AM -0400, Jan Stancek wrote: > > Thanks for clearing up how this works in padlock-sha, but > we are not exactly in same situation with p8_ghash. > > p8_ghash_init_tfm() already updates descsize. Problem in original report > is that without custom export/import/stat

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Herbert Xu
On Wed, Sep 28, 2016 at 09:28:44AM -0300, Marcelo Cerri wrote: > > The big difference between p8_ghash and padlock_sha1 is that > padlock_sha1 defines alg->statesize as sizeof(struct sha1_state), which > is the descsize value used by sha1_generic. This probably works but > it's also wrong because t

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote: On 16-09-28 08:16 AM, David Miller wrote: From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 On 16-09-28 08:07 AM, David Miller wrote: Right, it would be legal for an existing user to have code that explicitly initializes every member

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Marcelo Cerri
Hi Hebert, On Wed, Sep 28, 2016 at 08:29:35PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 03:40:51AM -0400, Jan Stancek wrote: > > > > Thanks for clearing up how this works in padlock-sha, but > > we are not exactly in same situation with p8_ghash. > > > > p8_ghash_init_tfm() already upda

[PATCH v2] drm: tilcdc: add a workaround for failed clk_set_rate()

2016-09-28 Thread Bartosz Golaszewski
Some architectures don't use the common clock framework and don't implement all the clk interfaces for every clock. This is the case for da850-lcdk where clk_set_rate() only works for PLL0 and PLL1. Trying to set the clock rate for the LCDC clock results in -EINVAL being returned. As a workaround

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Herbert Xu
On Wed, Sep 28, 2016 at 09:38:41AM -0300, Marcelo Cerri wrote: > > The patch forces ghash-generic as the fallback. And I don't think that > is a big problem if we decide to go by this path. Right it should work but could break for example if we ever decide to change the exported state structure f

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:27:24AM -0400, Jamal Hadi Salim wrote: > > > > They must initialize it to zero. > > > > What if in the future actually meant to use 0 for > something?;-> For example in Cyrill's case it means PROTO_IP > Not sure if it useful to interpret or not but it is part of the >

[PATCH v1] ARM: decompressor: reset ttbcr fields to use TTBR0 on ARMv7

2016-09-28 Thread Srinivas Ramana
If the bootloader uses the long descriptor format and jumps to kernel decompressor code, TTBCR may not be in a right state. Before enabling the MMU, it is required to clear the TTBCR.PD0 field to use TTBR0 for translation table walks. The commit dbece45894d3a ("ARM: 7501/1: decompressor: reset ttb

RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver

2016-09-28 Thread Vadim Pasternak
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, September 22, 2016 4:53 PM > To: Vadim Pasternak > Cc: dvh...@infradead.org; da...@davemloft.net; ge...@linux-m68k.org; > a...@linux-foundation.org; kv...@codeaurora.org; mche...@kernel.org; > li..

Re: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro

2016-09-28 Thread Will Deacon
On Fri, Sep 23, 2016 at 05:07:10PM +0100, Will Deacon wrote: > On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote: > > From: Mark Rutland > > > > As with dsb() and isb(), add a __tlbi() helper so that we can avoid > > distracting asm boilerplate every time we want a TLBI. As some TLBI

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Jamal Hadi Salim
On 16-09-28 08:45 AM, Cyrill Gorcunov wrote: Note: inet_diag somewhere has a netlink structure that has a hole. I pointed it out to Eric D. and he said we cant add it now because it would break ABI. Naming holes generated by a compiler for alignment sake should not break abi (because alignment

Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

2016-09-28 Thread Marcelo Cerri
On Wed, Sep 28, 2016 at 08:44:52PM +0800, Herbert Xu wrote: > On Wed, Sep 28, 2016 at 09:38:41AM -0300, Marcelo Cerri wrote: > > > > The patch forces ghash-generic as the fallback. And I don't think that > > is a big problem if we decide to go by this path. > > Right it should work but could brea

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 14:27 +0300, Cyrill Gorcunov wrote: > On Wed, Sep 28, 2016 at 07:06:26AM -0400, Jamal Hadi Salim wrote: > > > > > > This structure is uapi, so anyone has complete rights to reference > > > @pad in the userspace programs. Sure it would be more clear to remove > > > the @pad co

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 08:50:31AM -0400, Jamal Hadi Salim wrote: > > struct tcp_info. Yeah I see. As I said naming pads will be safe but to do so we will have to compile on every arch we support and make sure the implicit pad remains here. > Sorry - i didnt mean to drag this for long; but the m

Re: [PATCH v5 5/8] iommu/amd: copy old trans table from old kernel

2016-09-28 Thread Baoquan He
On 09/28/16 at 09:37am, Baoquan He wrote: > Hi Joerg, > > On 09/20/16 at 02:40pm, Joerg Roedel wrote: > > > + if ( !is_pre_enabled) { > > > + for_each_iommu(iommu) > > > + early_enable_iommu(iommu); > > > + } else { > > > + if (copy_dev_tables()) { > > > +

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Cyrill Gorcunov
On Wed, Sep 28, 2016 at 05:57:12AM -0700, Eric Dumazet wrote: ... > Note that some programs could fail to compile with the added union > anyway. > > Some gcc versions are unable to compile a static init with an union > > struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, }; > > Wh

Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets

2016-09-28 Thread Eric Dumazet
On Wed, 2016-09-28 at 05:57 -0700, Eric Dumazet wrote: > Note that some programs could fail to compile with the added union > anyway. > > Some gcc versions are unable to compile a static init with an union > > struct inet_diag_req_v2 foo = { .pad = 0, sdiag_family = AF_INET, }; > > When I cooke

<    1   2   3   4   5   6   7   8   9   10   >