RE: igb driver can cause cache invalidation of non-owned memory?

2016-10-13 Thread David Laight
From: Alexander Duyck > Sent: 12 October 2016 19:30 > On Wed, Oct 12, 2016 at 11:12 AM, Nikita Yushchenko > wrote: > >> It would make more sense to update the DMA API for > >> __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if > >> the direction is DMA_FROM_DEVICE. > > > > No,

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 17:49, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 1783406..ca2ae5b 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -241,6

Re: MPOL_BIND on memory only nodes

2016-10-13 Thread Mel Gorman
On Wed, Oct 12, 2016 at 03:16:27PM +0200, Michal Hocko wrote: > On Wed 12-10-16 11:43:37, Michal Hocko wrote: > > On Wed 12-10-16 14:55:24, Anshuman Khandual wrote: > [...] > > > Why we insist on __GFP_THISNODE ? > > > > AFAIU __GFP_THISNODE just overrides the given node to the policy > > nodemask

RE: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Mintz, Yuval
> > > > While I don't mind, you could have argued is that we're not > > > > removing enough, not too much. > > > > I.e., perhaps the rdma_msix_* fields should also have been > > > > ifdef-ed instead. [in which case this solution would not have > > > > worked] > > > > > > That would add even more #i

Re: [PATCH 1/2] debugfs: improve DEFINE_DEBUGFS_ATTRIBUTE for !CONFIG_DEBUGFS_FS

2016-10-13 Thread Nicolai Stange
Arnd Bergmann writes: > On Thursday, October 13, 2016 11:59:54 AM CEST Nicolai Stange wrote: >> > >> > +ssize_t debugfs_attr_read(struct file *file, char __user *buf, >> > + size_t len, loff_t *ppos); >> > +ssize_t debugfs_attr_write(struct file *file, const char __user *buf

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

2016-10-13 Thread Steffen Maier
Dan, many thanks for catching this! Sparse did not notice, is there other tooling that would find such things? James, Martin, could you please queue this as fix for one of my patches that went into the 4.9 merge window, so for 4.9-rc I guess? https://lkml.kernel.org/r/20161013085358.GH16198@mw

Re: [PATCH V3 08/10] ras: acpi / apei: generate trace event for unrecognized CPER section

2016-10-13 Thread Punit Agrawal
Hi Tyler, One last comment... Tyler Baicar writes: > UEFI spec allows for non-standard section in Common Platform Error > Record. This is defined in section N.2.3 of UEFI version 2.5. > > Currently if the CPER section's type (UUID) does not match with > any section type that the kernel knows ho

[PATCH] irqchip/gic: Enable gic_set_affinity set more than one cpu

2016-10-13 Thread Cheng Chao
GIC can distribute an interrupt to more than one cpu, but now, gic_set_affinity sets only one cpu to handle interrupt. Signed-off-by: Cheng Chao --- drivers/irqchip/irq-gic.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-gic

Re: [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq

2016-10-13 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Hi, > > Baolin Wang writes: > I'm thinking this is a bug in configfs interface of Gadget API, not > dwc3. The only reason for this to happen would be if we get to > ->udc_stop() with endpoints still enabled. > > Can you check if that's the case? i.

[PATCH 0/9] perf/jit: various improvements

2016-10-13 Thread Stephane Eranian
From: Stephane Eranian This patch series provides several important enhancements to the perf jit code profiling support. The following is changed: - enable building pref jitdump support without DWARF (Maciej) - Add Exception Handling (EH) Frame record type to support unwinding - remove useless

[PATCH 2/9] perf/jit: enable jitdump support without dwarf

2016-10-13 Thread Stephane Eranian
From: Maciej Debski This patch modifies the build dependencies on the jitdump support in perf. As it stands jitdump was wrongfully made dependent 100% on using DWARF. However, the dwarf dependency, only exist if generating the source line table in genelf_debug.c. The rest of the support does not

[PATCH 3/9] perf/jit: remove unecessary padding in jitdump file

2016-10-13 Thread Stephane Eranian
This patch removes all the string padding generated in the jitdump file. There are nonecessary and were adding unecessary complexity. Modern processors can handle unaligned accesses quite well. The perf.data/jitdump file are always postp-processed, no need to add extra complexity for no real gain.

[PATCH 6/9] perf/jit: add unwinding support

2016-10-13 Thread Stephane Eranian
From: Stefano Sanfilippo This record is intended to provide unwinding information in the eh_frame format. This is required to unwind JITed code which does not maintain the frame pointer register during function calls. The eh_frame unwinding information can be emitted by V8 / Chromium when the --

[PATCH 5/9] perf/jit: do not assume pgoff is zero

2016-10-13 Thread Stephane Eranian
From: Stefano Sanfilippo When calculating .eh_frame_hdr base and LUT offsets do not always assume that pgoff is zero. The assumption is false for DSOs built from the jitdump by perf inject, because the ELF header did not exist in memory at sampling time. Signed-off-by: Stefano Sanfilippo Signe

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-13 Thread Nikita Yushchenko
>>> It would make more sense to update the DMA API for >>> __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if >>> the direction is DMA_FROM_DEVICE. >> >> No, in generic case it's unsafe. >> >> If CPU issued a write to a location, and sometime later that location is >> used as DM

[PATCH 4/9] perf/jit: make perf skip unknown records

2016-10-13 Thread Stephane Eranian
From: Stefano Sanfilippo The behaviour before this commit was to skip the remaining portion of the jitdump in case an unknown record was found, including those records that perf could handle. With this change, parsing a record with an unknown id will cause a warning to be emitted, the record wil

[PATCH 7/9] perf/jit: generate .eh_frame/.eh_frame_hdr in DSO

2016-10-13 Thread Stephane Eranian
From: Stefano Sanfilippo When the jit_buf_desc contains unwinding information, it is emitted as eh_frame unwinding sections in the DSOs generated by perf inject. The unwinding information is required to unwind of JITed code which do not maintain the frame pointer register during function calls.

[PATCH 9/9] perf/jit: add jitdump format specification document

2016-10-13 Thread Stephane Eranian
This patch adds a formal specification of the jitdump format. The goal is to help jit runtime developers implement the jitdump support without having to read the jvmti code. Signed-off-by: Stephane Eranian --- tools/perf/Documentation/jitdump-specification.txt | 170 + 1 file

[PATCH 8/9] perf/jit: Check JITHEADER_VERSION

2016-10-13 Thread Stephane Eranian
From: Stefano Sanfilippo Check the version number when opening a jitdump file. Accept older versions, but not newer ones. Signed-off-by: Stefano Sanfilippo Signed-off-by: Ross McIlroy Reviewed-by: Stephane Eranian --- tools/perf/util/jitdump.c | 6 ++ 1 file changed, 6 insertions(+) dif

[PATCH 1/9] perf/jit: improve error messages from JVMTI

2016-10-13 Thread Stephane Eranian
This patch improves the usefulness of error messages generated by the JVMTI interfac.e This can help identify the root cause of a problem by printing the actual error code. The patch adds a new helper function called print_error(). Signed-off-by: Stephane Eranian --- tools/perf/jvmti/libjvmti.c

Re: [v4.8-rc1 Regression] sched/fair: Apply more PELT fixes

2016-10-13 Thread Vincent Guittot
Hi, On 12 October 2016 at 18:21, Joseph Salisbury wrote: > On 10/12/2016 08:20 AM, Vincent Guittot wrote: >> On 8 October 2016 at 13:49, Mike Galbraith wrote: >>> On Sat, 2016-10-08 at 13:37 +0200, Vincent Guittot wrote: On 8 October 2016 at 10:39, Ingo Molnar wrote: > * Peter Zijlstra

Re: [RFC PATCH 5/5] mm/page_alloc: support fixed migratetype pageblock

2016-10-13 Thread Vlastimil Babka
On 10/13/2016 10:08 AM, js1...@gmail.com wrote: From: Joonsoo Kim We have migratetype facility to minimise fragmentation. It dynamically changes migratetype of pageblock based on some criterias but it never be perfect. Some migratetype pages are often placed in the other migratetype pageblock.

Re: [RFC PATCH] mm, compaction: allow compaction for GFP_NOFS requests

2016-10-13 Thread Michal Hocko
On Thu 13-10-16 09:39:47, Michal Hocko wrote: > On Thu 13-10-16 11:29:24, Dave Chinner wrote: > > On Fri, Oct 07, 2016 at 03:18:14PM +0200, Michal Hocko wrote: > [...] > > > Unpatched kernel: > > > # Version 3.3, 16 thread(s) starting at Fri Oct 7 09:55:05 2016 > > > # Sync method: NO

Re: linux.git: printk() problem

2016-10-13 Thread Michal Hocko
On Thu 13-10-16 03:20:50, Joe Perches wrote: > On Thu, 2016-10-13 at 12:04 +0200, Michal Hocko wrote: [...] > > I would be really surprised if we really had that many continuation > > lines. They should be avoided as much as possible. Hundreds of thousands > > just sounds more than over exaggerated

Re: tty, fbcon: use-after-free in fbcon_invert_region

2016-10-13 Thread Dmitry Vyukov
On Wed, Oct 12, 2016 at 12:48 AM, Scot Doyle wrote: >> On Tue, Oct 11, 2016 at 3:43 AM, Scot Doyle wrote: >> > I wonder if the text selection is outside the newly resized vc? >> > Does this patch help? >> > >> > --- vt.c2016-10-11 00:32:43.079605599 - >> > +++ vt.c.new2016-10-11 0

Re: [PATCH 2/2] power/reset: at91-poweroff: timely shitdown LPDDR memories

2016-10-13 Thread Alexandre Belloni
On 12/10/2016 at 14:48:27 +0200, Jean-Jacques Hiblot wrote : > > +static void at91_lpddr_poweroff(void) > > +{ > > + asm volatile( > > + /* Align to cache lines */ > > + ".balign 32\n\t" > > + > > + " ldr r6, [%2, #" __stringify(AT91_SHDW_CR

[PATCH] KVM: document lock orders

2016-10-13 Thread Paolo Bonzini
This is long overdue, and not really hard. Signed-off-by: Paolo Bonzini --- Documentation/virtual/kvm/locking.txt | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Documentation/virtual/kvm/locking.txt b/Documentation/virtual/kvm/locking.txt index f2491a8c68b4..e5

Re: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Arnd Bergmann
On Thursday, October 13, 2016 10:44:36 AM CEST Mintz, Yuval wrote: > > > > > While I don't mind, you could have argued is that we're not > > > > > removing enough, not too much. > > > > > I.e., perhaps the rdma_msix_* fields should also have been > > > > > ifdef-ed instead. [in which case this solu

Re: [PATCH] irqchip/gic: Enable gic_set_affinity set more than one cpu

2016-10-13 Thread Cheng Chao
Hi, This patch has been tested on the SOC: ti AM572x and hisilicon hi35xx, it works. Please review this patch. Any suggestions will be welcome,thanks. Cheng on 10/13/2016 06:57 PM, Cheng Chao wrote: > GIC can distribute an interrupt to more than one cpu, > but now, gic_set_affinity sets only one

Re: [RFC] arm64: Enforce observed order for spinlock and data

2016-10-13 Thread Will Deacon
Brent, On Wed, Oct 12, 2016 at 04:01:06PM -0400, bdegr...@codeaurora.org wrote: > I am still working through some additional analyses for mixed accesses, > but I thought I'd send along some sample commit text for the fix as it > currently stands. Please feel free to comment if you see something t

Re: [RFC PATCH 3/5] mm/page_alloc: stop instantly reusing freed page

2016-10-13 Thread Vlastimil Babka
On 10/13/2016 10:08 AM, js1...@gmail.com wrote: From: Joonsoo Kim Allocation/free pattern is usually sequantial. If they are freed to the buddy list, they can be coalesced. However, we first keep these freed pages at the pcp list and try to reuse them until threshold is reached so we don't have

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Janusz Dziedzic
On 13 October 2016 at 12:41, Baolin Wang wrote: > On 13 October 2016 at 17:49, Felipe Balbi wrote: >> >> Hi, >> >> Baolin Wang writes: > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 1783406..ca2ae5b 100644 > --- a/drivers/usb/dwc3/gadget.c >>

Re: [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 18:56, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: >> Hi, >> >> Baolin Wang writes: >> I'm thinking this is a bug in configfs interface of Gadget API, not >> dwc3. The only reason for this to happen would be if we get to >> ->udc_stop() with endpoints s

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Janusz Dziedzic writes: >>> Baolin Wang writes: >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 1783406..ca2ae5b 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c >> @@ -241,6 +241,9 @@ int dwc

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use > helper variables bsg_request and bsg_reply. This will be helpfull when > transitioning to bsg-lib. > > Signed-off-by: Johannes Thumshirn > --- > drivers/s390/scsi/zfcp_fc.

Re: [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq

2016-10-13 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> Baolin Wang writes: >>> I'm thinking this is a bug in configfs interface of Gadget API, not >>> dwc3. The only reason for this to happen would be if we get to >>> ->udc_stop() with endpoints still enabled. >>> >>> Can you check if that's the case?

RE: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-10-13 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, September 30, 2016 6:34 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Zhuangyuzeng (Yisen); Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > net...@vger.kernel.org; li

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

2016-10-13 Thread Dan Carpenter
On Thu, Oct 13, 2016 at 12:49:18PM +0200, Steffen Maier wrote: > Dan, many thanks for catching this! Sparse did not notice, is there > other tooling that would find such things? This was a Smatch warning. regards, dan carpenter

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle Not that this test was worth a lot: it builds cleanly (on top of 4.8.1), the error at b

Re: [PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Export fc_bsg_jobdone so drivers can use it directly instead of doing > the round-trip via struct fc_bsg_job::job_done() and use it in the LLDDs. > > As we've converted all LLDDs over to use fc_bsg_jobdone() directly, > we can remove the function

Re: [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines

2016-10-13 Thread Jean Delvare
On Tue, 11 Oct 2016 19:03:56 -0700, Joe Perches wrote: > On Tue, 2016-10-11 at 18:34 +0100, Carlos Palminha wrote: > [] > > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c > [] > > @@ -260,7 +260,8 @@ static int piix4_setup(struct pci_dev *PIIX4_dev, > > else if ((t

[PATCH RFC V3 3/6] KVM: LAPIC: introduce set_target_expiration() to set target expiration time

2016-10-13 Thread Wanpeng Li
From: Wanpeng Li Introduce set_target_expiration() to set target expiration time which is when LVTT current-count register counts down to zero and a timer interrupt is generated. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Yunhong Jiang Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 47 +

[PATCH RFC V3 2/6] KVM: LAPIC: guarantee the timer is in tsc-deadline mode when rdmsr MSR_IA32_TSCDEADLINE

2016-10-13 Thread Wanpeng Li
From: Wanpeng Li Check apic_lvtt_tscdeadline() mode directly instead of apic_lvtt_oneshot() and apic_lvtt_period() to guarantee the timer is in tsc-deadline mode when rdmsr MSR_IA32_TSCDEADLINE. Suggsted-by: Radim Krčmář Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Yunhong Jiang Signed-off-by: W

[PATCH RFC V3 4/6] KVM: LAPIC: introduce kvm_get_lapic_target_expiration_tsc() to get APIC Timer target deadline tsc

2016-10-13 Thread Wanpeng Li
From: Wanpeng Li Introdce kvm_get_lapic_target_expiration_tsc() to get APIC Timer target deadline tsc. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Yunhong Jiang Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 9 + arch/x86/kvm/lapic.h | 1 + arch/x86/kvm/x86.c | 2 +- 3 files cha

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi, On 13 October 2016 at 19:22, Felipe Balbi wrote: > > Hi, > > Janusz Dziedzic writes: Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index 1783406..ca2ae5b 100644 >>> --- a/drivers/usb/dwc3/gadget.c >>> +++

[PATCH RFC V3 5/6] KVM: LAPIC: rename start/cancel_hv_tscdeadline to start/cancel_hv_timer

2016-10-13 Thread Wanpeng Li
From: Wanpeng Li Rename start/cancel_hv_tscdeadline to start/cancel_hv_timer since they will handle both APIC Timer periodic/oneshot mode and tsc-deadline mode. Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Yunhong Jiang Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 16 1

Re: [PATCH v2 06/16] scsi: fc: provide fc_bsg_to_rport() helper

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Provide fc_bsg_to_rport() helper that will become handy when we're moving > from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use > the new helper. > > Signed-off-by: Johannes Thumshirn > --- > drivers/s390/scsi/zfcp_fc.c

[PATCH RFC V3 6/6] KVM: LAPIC: Add APIC Timer periodic/oneshot mode VMX preemption timer support

2016-10-13 Thread Wanpeng Li
From: Wanpeng Li Most windows guests still utilize APIC Timer periodic/oneshot mode instead of tsc-deadline mode, and the APIC Timer periodic/oneshot mode are still emulated by high overhead hrtimer on host. This patch converts the expected expire time of the periodic/oneshot mode to guest dea

[PATCH 2/6] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led

2016-10-13 Thread Ulf Hansson
Accesses of the rtsx sdmmc's parent device, which is the rtsx usb device, must be done when it's runtime resumed. Currently this isn't case when changing the led, so let's fix this by adding a pm_runtime_get_sync() and a pm_runtime_put() around those operations. Reported-by: Ritesh Raj Sarraf Tes

[PATCH 1/6] mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused

2016-10-13 Thread Ulf Hansson
The rtsx_usb_sdmmc driver may bail out in its ->set_ios() callback when no SD card is inserted. This is wrong, as it could cause the device to remain runtime resumed when it's unused. Fix this behaviour. Tested-by: Ritesh Raj Sarraf Cc: Cc: Alan Stern Signed-off-by: Ulf Hansson --- drivers/mm

[PATCH 4/6] memstick: rtsx_usb_ms: Manage runtime PM when accessing the device

2016-10-13 Thread Ulf Hansson
Accesses to the rtsx usb device, which is the parent of the rtsx memstick device, must not be done unless it's runtime resumed. This is currently not the case and it could trigger various errors. Fix this by properly deal with runtime PM in this regards. This means making sure the device is runtim

[PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues

2016-10-13 Thread Ulf Hansson
The rtsx_usb_sdmmc (mmc/sd) and rtsx_usb_ms (memstick) devices are interfacing an rtsx_usb device (managed by an mfd driver) while communicating with the cards. The mmc/sd and memstick devices are children of the usb device. Issues has been reported [1] for rtsx, which have been investigated, disc

Re: [PATCH RFC V2 2/2] KVM: x86: Support using the VMX preemption timer for APIC Timer periodic/oneshot mode

2016-10-13 Thread Wanpeng Li
2016-10-13 1:41 GMT+08:00 Radim Krčmář : > 2016-10-12 14:52+0800, Wanpeng Li: >> From: Wanpeng Li >> >> Most windows guests still utilize APIC Timer periodic/oneshot mode >> instead of tsc-deadline mode, and the APIC Timer periodic/oneshot >> mode are still emulated by high overhead hrtimer on hos

Re: [PATCH v2 07/16] scsi: libfc: don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone()

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as > fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that > ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the > FC_RQST_STATE_DONE flag. > > Sign

[PATCH 6/6] mmc: core: Don't power off the card when starting the host

2016-10-13 Thread Ulf Hansson
The MMC_CAP2_NO_PRESCAN_POWERUP was invented to avoid running the power up sequence, mmc_power_up(), during ->probe() of the mmc host driver, but instead defer this to the mmc detect work. This is especially useful for those hosts that suffers from a long initialization time, as this time would oth

[PATCH 5/6] mmc: rtsx_usb_sdmmc: Enable runtime PM autosuspend

2016-10-13 Thread Ulf Hansson
Enable runtime PM autosuspend for the rtsx_usb_sdmmc driver to avoid the device being runtime suspended and runtime resumed between each request. Let's use a default timeout of 50ms, to be consistent with other mmc hosts. Cc: Ritesh Raj Sarraf Cc: Alan Stern Signed-off-by: Ulf Hansson --- driv

[PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards

2016-10-13 Thread Ulf Hansson
From: Alan Stern Accesses to the rtsx usb device, which is the parent of the rtsx memstick device, must not be done unless it's runtime resumed. Therefore when the rtsx_usb_ms driver polls for inserted memstick cards, let's add pm_runtime_get|put*() to make sure accesses is done when the rtsx us

Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes

2016-10-13 Thread Jean Delvare
Hi Carlos, On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote: > This patchset fixes several coding style issues. > > Carlos Palminha (5): > i2c: i2c-piix4: coding style fix - '*' adjacent to data name > i2c: i2c-piix4: coding style fix - assignment in if condition > i2c: i2c-piix4:

Re: [PATCH 2/2] perf, tools: Add documentation for perf user event parameters

2016-10-13 Thread Jiri Olsa
On Wed, Oct 12, 2016 at 02:02:07PM -0700, Andi Kleen wrote: > From: Andi Kleen > > There was no proper documention for the user parameters for > events that the perf parser implements. Document them all > in the perf list manpage. > > Signed-off-by: Andi Kleen > --- > tools/perf/Documentation/

Re: [PATCH 1/2] perf, tools: Implement branch_type event parameter

2016-10-13 Thread Jiri Olsa
On Wed, Oct 12, 2016 at 02:02:06PM -0700, Andi Kleen wrote: > From: Andi Kleen > > It can be useful to specify branch type state per event, for example > if we want to collect both software trace points and last branch PMU > events in a single collection. Currently this doesn't work because > the

Re: [PATCH v2 08/16] scsi: fc: implement kref backed reference counting

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Implement kref backed reference counting instead of rolling our own. This > elimnates the need of the following fields in 'struct fc_bsg_job': > * ref_cnt > * state_flags > * job_lock > bringing us close to unification of 'struct fc_bsg_job' and '

Re: [PATCH v2 09/16] block: add reference counting for struct bsg_job

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Add reference counting to 'struct bsg_job' so we can implement a reuqest > timeout handler for bsg_jobs, which is needed for Fibre Channel. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 7 +-- > include/linux/bsg-l

Re: [PATCHv3 17/41] filemap: handle huge pages in filemap_fdatawait_range()

2016-10-13 Thread Jan Kara
On Thu 15-09-16 14:54:59, Kirill A. Shutemov wrote: > We writeback whole huge page a time. This is one of the things I don't understand. Firstly I didn't see where changes of writeback like this would happen (maybe they come later). Secondly I'm not sure why e.g. writeback should behave atomically

Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks

2016-10-13 Thread Jean Delvare
Hi Carlos, On Tue, 11 Oct 2016 18:24:39 +0100, Carlos Palminha wrote: > Signed-off-by: Carlos Palminha > --- > drivers/i2c/busses/i2c-piix4.c | 94 > -- > 1 file changed, 54 insertions(+), 40 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-piix4.c b

Re: [PATCH v2 10/16] scsi: change FC drivers to use 'struct bsg_job'

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct > fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'. > > Signed-off-by: Johannes Thumshirn > --- > drivers/s390/scsi/zfcp_ext.h | 4 +-- > driver

Re: [PATCH v2 11/16] scsi: fc: Use bsg_destroy_job

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > fc_destroy_bsgjob() and bsg_destroy_job() are now 1:1 copies, so use the > later. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 3 ++- > drivers/scsi/scsi_transport_fc.c | 20 ++-- > include/l

Re: [RFC 4/4] mm, page_alloc: disallow migratetype fallback in fastpath

2016-10-13 Thread Vlastimil Babka
On 10/13/2016 09:58 AM, Joonsoo Kim wrote: On Thu, Sep 29, 2016 at 11:05:48PM +0200, Vlastimil Babka wrote: The previous patch has adjusted async compaction so that it helps against longterm fragmentation when compacting for a non-MOVABLE high-order allocation. The goal of this patch is to force

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
Hi Felipe, On 13 October 2016 at 19:22, Felipe Balbi wrote: > > Hi, > > Janusz Dziedzic writes: Baolin Wang writes: >>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >>> index 1783406..ca2ae5b 100644 >>> --- a/drivers/usb/dwc3/gadget.c >

[PATCH v2] Input: elan_i2c - always output the device information

2016-10-13 Thread Benjamin Tissoires
it's always easier to retrieve these information in bug reports when it is always printed in the dmesg. Signed-off-by: Benjamin Tissoires --- changes in v2: - split the version information message and the touchpad characteristics - keep sending the versions as info (on one line) - send the char

Re: [PATCH v2 14/16] block: add bsg_job_put() and bsg_job_get()

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Add bsg_job_put() and bsg_job_get() so don't need to export > bsg_destroy_job() any more. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 17 ++--- > drivers/scsi/scsi_transport_fc.c | 4 ++-- > inc

Re: [PATCH v2 13/16] scsi: fc: use bsg_job_done

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one > instead of the FC private implementation. > > Signed-off-by: Johannes Thumshirn > --- > drivers/s390/scsi/zfcp_fc.c | 2 +- > drivers/scsi/bfa/bfad_bsg.c

Re: [PATCH RFC V2 2/2] KVM: x86: Support using the VMX preemption timer for APIC Timer periodic/oneshot mode

2016-10-13 Thread Wanpeng Li
2016-10-13 19:38 GMT+08:00 Wanpeng Li : > 2016-10-13 1:41 GMT+08:00 Radim Krčmář : >> 2016-10-12 14:52+0800, Wanpeng Li: [...] >>> @@ -1711,8 +1753,7 @@ u64 kvm_get_lapic_tscdeadline_msr(struct kvm_vcpu >>> *vcpu) >>> { >>> struct kvm_lapic *apic = vcpu->arch.apic; >>> >>> - if (!lapi

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 13:27 +0200, Paul Bolle wrote: > Luca, > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Paul Bolle > > Not that this

[PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Mikhail Golubev
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Mikhail Golubev --- drivers/staging/vt6656/baseband.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vt6656/baseband.h b/d

[PATCH] virtio-gpu: fix vblank events

2016-10-13 Thread Gerd Hoffmann
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-10-13 Thread Doug Ledford
On 10/13/2016 7:26 AM, Salil Mehta wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Friday, September 30, 2016 6:34 AM >> To: Salil Mehta >> Cc: dledf...@redhat.com; Zhuangyuzeng (Yisen); Huwei (Xavier); oulijun; >> mehta.salil@gmail.com; linux-r.

Re: [PATCHv3 17/41] filemap: handle huge pages in filemap_fdatawait_range()

2016-10-13 Thread Kirill A. Shutemov
On Thu, Oct 13, 2016 at 11:44:41AM +0200, Jan Kara wrote: > On Thu 15-09-16 14:54:59, Kirill A. Shutemov wrote: > > We writeback whole huge page a time. > > This is one of the things I don't understand. Firstly I didn't see where > changes of writeback like this would happen (maybe they come later

[PATCH v5 3/6] i2c: i801: use BIT() macro for bits definition

2016-10-13 Thread Benjamin Tissoires
i801 mixes hexadecimal and decimal values for defining bits. However, we have a nice BIT() macro for this exact purpose. No functional changes, cleanup only. Reviewed-by: Jean Delvare Signed-off-by: Benjamin Tissoires --- no changes in v5 no changes in v4 no changes in v3 no changes in v2

[PATCH v5 5/6] i2c: i801: remove SMBNTFDDAT reads as they always seem to return 0

2016-10-13 Thread Benjamin Tissoires
On the platform tested, reading SMBNTFDDAT always returns 0 (using 1 read of a word or 2 of 2 bytes). Given that we are not sure why and that we don't need to rely on the data parameter in the current users of Host Notify, remove this part of the code. If someone wants to re-enable it, just revert

[PATCH v5 4/6] i2c: i801: use the BIT() macro for FEATURES_* also

2016-10-13 Thread Benjamin Tissoires
no functional changes Signed-off-by: Benjamin Tissoires --- no changes in v5 no changes in v4 no changes in v3 new in v2 --- drivers/i2c/busses/i2c-i801.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/

[PATCH v5 6/6] i2c: use an IRQ to report Host Notify events, not alert

2016-10-13 Thread Benjamin Tissoires
The current SMBus Host Notify implementation relies on .alert() to relay its notifications. However, the use cases where SMBus Host Notify is needed currently is to signal data ready on touchpads. This is closer to an IRQ than a custom API through .alert(). Given that the 2 touchpad manufacturers

[PATCH v5 0/6] i2c: Host Notify / i801 fixes

2016-10-13 Thread Benjamin Tissoires
Hi Wolfram and Dmitry, 5th revision of the series, hopefully this time it will be OK. The changes were requested by Dmitry: now, SMBus Host Notify is transparent for clients drivers. The IRQ is attributed if the adapter has the capability and if nobody claimed an IRQ before. That means that addin

[PATCH v5 1/6] i2c: i801: store and restore the SLVCMD register at load and unload

2016-10-13 Thread Benjamin Tissoires
Also do not override any other configuration in this register. Signed-off-by: Benjamin Tissoires --- no changes in v5 changes in v4: - add the i801_disable_host_notify function here as this gets the first in the series no changes in v3 new in v2 --- drivers/i2c/busses/i2c-i801.c | 17

[PATCH v5 2/6] i2c: i801: minor formatting issues

2016-10-13 Thread Benjamin Tissoires
No functional changes, just typos and remove unused #define. Reviewed-by: Jean Delvare Signed-off-by: Benjamin Tissoires --- no changes in v5 no changes in v4 no changes in v3 no changes in v2 --- drivers/i2c/busses/i2c-i801.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) di

Re: [PATCH v2 2/9] mtd: spi-nor: add an alternative method to support memory >16MiB

2016-10-13 Thread Vignesh R
On Wednesday 05 October 2016 05:30 PM, Cyrille Pitchen wrote: > This patch provides an alternative mean to support memory above 16MiB > (128Mib) by replacing 3byte address op codes by their associated 4byte > address versions. > > Using the dedicated 4byte address op codes doesn't change the int

Re: [patch] drm/i915: fix a read size argument

2016-10-13 Thread Jani Nikula
On Thu, 13 Oct 2016, walter harms wrote: > Am 13.10.2016 10:55, schrieb Dan Carpenter: >> We want to read 3 bytes here, but because the parenthesis are in the >> wrong place we instead read: >> >> sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd) >> >> which is one byte. >> >> Fixes

Re: [PATCH v2] Input: elan_i2c - always output the device information

2016-10-13 Thread Benjamin Tissoires
On Oct 13 2016 or thereabouts, Michel Hermier wrote: > Le 13 oct. 2016 13:49, "Benjamin Tissoires" > a écrit : > > > > it's always easier to retrieve these information in bug reports when > > it is always printed in the dmesg. > > > > Signed-off-by: Benjamin Tissoires > > > > --- > > > > changes

Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > Function definitions arguments should also have an identifier name as > reported by checkpatch.pl. Please wrap your changelog comments at 72 columns. > > Signed-off-by: Mikhail Golubev > --- > drivers/staging/vt6656/baseband.h

Re: [PATCH RESEND] ARM: dts: keystone-k2*: Increase SPI Flash partition size for U-Boot

2016-10-13 Thread Vignesh R
On Wednesday 12 October 2016 05:27 PM, Russell King - ARM Linux wrote: > On Wed, Oct 12, 2016 at 04:30:28PM +0530, Vignesh R wrote: [...] >>> >>> - What is this "misc" partition? >>> >> >> This partition seems to exists from the very beginning. I believe, this >> is just a spare area of flash th

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Felipe Balbi
Hi, Baolin Wang writes: @@ -241,6 +241,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd, int susphy = false; int ret = -EINVAL; + if (!dwc->pul

Re: [PATCH] x86/apic: Fix suspicious RCU usage in smp_trace_call_function_interrupt

2016-10-13 Thread Wanpeng Li
2016-10-12 21:17 GMT+08:00 Thomas Gleixner : > On Wed, 12 Oct 2016, Wanpeng Li wrote: >> irq_enter() which is called in scheduler_ipi() is too late to tell RCU >> susbstems to end the extended quiescent state before ack_APIC_irq(), >> any ideas? > > You can call irq_enter/exit() in __smp_reschedule

RE: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Mintz, Yuval
> config INFINIBAND_QEDR > - tristate "QLogic qede RoCE sources [debug]" > + bool "QLogic qede RoCE sources [debug]" Given that the qedr submission is going to turn this back into a tristate, are you certain this is a good thing [from compilation coverage perspective]? > - if

[bug/regression] libhugetlbfs testsuite failures and OOMs eventually kill my system

2016-10-13 Thread Jan Stancek
Hi, I'm running into ENOMEM failures with libhugetlbfs testsuite [1] on a power8 lpar system running 4.8 or latest git [2]. Repeated runs of this suite trigger multiple OOMs, that eventually kill entire system, it usually takes 3-5 runs: * Total System Memory..: 18024 MB * Shared Mem Max M

Re: MPOL_BIND on memory only nodes

2016-10-13 Thread Anshuman Khandual
On 10/13/2016 03:37 PM, Michal Hocko wrote: > On Thu 13-10-16 15:24:54, Anshuman Khandual wrote: > [...] >> Which makes the function look like this. Even with these changes, MPOL_BIND >> is >> still going to pick up the local node's zonelist instead of the first node in >> policy->v.nodes nodemask

Re: [RESEND PATCH v3 1/2] usb: dwc3: gadget: Add disconnect checking when changing function dynamically

2016-10-13 Thread Baolin Wang
On 13 October 2016 at 20:17, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: > @@ -241,6 +241,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep > *dep, unsigned cmd, > int susphy = false; > int

Re: [PATCH v2 12/16] scsi: fc: use bsg_softirq_done

2016-10-13 Thread Hannes Reinecke
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > bsg_softirq_done() and fc_bsg_softirq_done() are copies of each other, so > ditch the fc specific one. > > Signed-off-by: Johannes Thumshirn > --- > block/bsg-lib.c | 3 ++- > drivers/scsi/scsi_transport_fc.c | 16 ++--

Re: [PATCH RFC V3 6/6] KVM: LAPIC: Add APIC Timer periodic/oneshot mode VMX preemption timer support

2016-10-13 Thread Paolo Bonzini
On 13/10/2016 13:34, Wanpeng Li wrote: > From: Wanpeng Li > > Most windows guests still utilize APIC Timer periodic/oneshot mode > instead of tsc-deadline mode, and the APIC Timer periodic/oneshot > mode are still emulated by high overhead hrtimer on host. This patch > converts the expected

Re: [GIT PULL REQUEST] watchdog - v4.9 merge window

2016-10-13 Thread Guenter Roeck
On 10/12/2016 10:54 PM, Wim Van Sebroeck wrote: Hi Linus, It's an old server with only 512Mb RAM. I'm in the progress off replacing it (in another datacenter). Meanwhile I'll restart git-daemon. Linus, if it still doesn't work, I pulled it, verified it, and pushed it into my repository at

Re: [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr

2016-10-13 Thread Radim Krčmář
2016-10-13 10:34+0800, Longpeng(Mike): > Since Paolo has removed irq-enable-operation in vmx_handle_external_intr > (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit > in rflags is incorrect and stale now, so remove it. > > Signed-off-by: Longpeng(Mike) > --- > Hi Radim, >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > I forgot to say... could you load the iwlwifi module with debug=0x01 > (module parameter), so we can see the messages the driver is printing > when it doesn't find a proper structure? That makes a lot of noise! Here's the first 100 lines or s

<    1   2   3   4   5   6   7   8   >