Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Greg Kroah-Hartman
On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: > +struct switchtec_dev { > + struct pci_dev *pdev; > + struct msix_entry *msix; > + struct device *dev; > + struct kref kref; Why do you have a pointer to a device, yet a kref as well? Just have this structure embed

Re: [PATCH v2] x86/floppy: use designated initializers

2016-12-18 Thread Ingo Molnar
* Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees

Re: [PATCH 0/2] z3fold fixes

2016-12-18 Thread Vitaly Wool
On Tue, Nov 29, 2016 at 11:39 PM, Andrew Morton wrote: > On Tue, 29 Nov 2016 17:33:19 -0500 Dan Streetman wrote: > >> On Sat, Nov 26, 2016 at 2:15 PM, Vitaly Wool wrote: >> > Here come 2 patches with z3fold fixes for chunks counting and locking. As >> > commit 50a50d2 ("z3fold: don't fail kerne

[tip:x86/urgent] x86/floppy: Use designated initializers

2016-12-18 Thread tip-bot for Kees Cook
Commit-ID: ffc7dc8d838c6403a550021e4f28a737334d80a7 Gitweb: http://git.kernel.org/tip/ffc7dc8d838c6403a550021e4f28a737334d80a7 Author: Kees Cook AuthorDate: Sat, 17 Dec 2016 13:37:05 -0800 Committer: Ingo Molnar CommitDate: Sun, 18 Dec 2016 09:25:38 +0100 x86/floppy: Use designated ini

Re: [PATCH] x86/head: Refactor 32-bit pgtable setup

2016-12-18 Thread Ingo Molnar
* Boris Ostrovsky wrote: > On 12/08/2016 11:33 PM, Ingo Molnar wrote: > > * Boris Ostrovsky wrote: > > > >> The new Xen PVH entry point requires page tables to be setup by the > >> kernel since it is entered with paging disabled. > >> > >> Pull the common code out of head_32.S so that mk_early_

Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

2016-12-18 Thread Andi Shyti
Hi Sean, > On Fri, Dec 16, 2016 at 12:10:26PM +, Sean Young wrote: > > Sorry to add to your woes, but there are some checkpatch warnings and > > errors. Please can you correct these. One is below. > > Actually, the changes are pretty minor, I can fix them up before sending > them to Mauro. So

[PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-18 Thread Geert Uytterhoeven
With gcc 4.1.2: drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: drivers/usb/serial/f81534.c:1250: warning: comparison is always false due to limited range of data type f81534_logic_to_phy_port() may return a negative error value, which is ignored by assigning it to u8 f8153

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-18 Thread Christoph Hellwig
On Fri, Dec 16, 2016 at 04:25:14PM +0530, Yury Norov wrote: > 1 leave things as is. 32-bit architectures will have no option to >mmap big offsets, and no one cares - as usual. And that's the only sensible option.

[PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings

2016-12-18 Thread Devendra Sharma
From: devendra sharma Signed-off-by Devendra Sharma --- drivers/staging/comedi/drivers/cb_pcidas64.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c index cb9c2

Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings

2016-12-18 Thread Joe Perches
On Sun, 2016-12-18 at 15:06 +0530, Devendra Sharma wrote: > From: devendra sharma [] > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c > b/drivers/staging/comedi/drivers/cb_pcidas64.c [] > @@ -1500,10 +1500,9 @@ static int alloc_and_init_dma_members(struct > comedi_device *dev) >

Linux 3.12.69

2016-12-18 Thread Jiri Slaby
I'm announcing the release of the 3.12.69 kernel. All users of the 3.12 kernel series must upgrade. The updated 3.12.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.12.y and can be browsed at the normal kernel.org git web browser:

Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed checkpatch warnings

2016-12-18 Thread Greg KH
On Sun, Dec 18, 2016 at 03:06:18PM +0530, Devendra Sharma wrote: > From: devendra sharma > > Signed-off-by Devendra Sharma I can't take patches without any changelog text :(

[PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings

2016-12-18 Thread devendra sharma
Fixed check patch warnings about multiple line dereferencing Signed-off-by: Devendra Sharma --- drivers/staging/comedi/drivers/cb_pcidas64.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/c

Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings

2016-12-18 Thread Greg KH
On Sun, Dec 18, 2016 at 03:43:15PM +0530, devendra sharma wrote: > Fixed check patch warnings about multiple line dereferencing What does that mean? > > Signed-off-by: Devendra Sharma > --- > drivers/staging/comedi/drivers/cb_pcidas64.c | 20 > 1 file changed, 8 insertions

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Jiri Slaby
On 12/18/2016, 12:59 AM, Linus Torvalds wrote: > On Sat, Dec 17, 2016 at 12:57 AM, Jiri Slaby wrote: >> >> Yes, disk drivers won't load: >> [2.141973] virtio_pci: disagrees about version of symbol mcount >> [2.144415] virtio_pci: Unknown symbol mcount (err -22) > > This makes no sense. >

Re: wl1251 & mac address & calibration data

2016-12-18 Thread Arend Van Spriel
On 16-12-2016 11:40, Pali Rohár wrote: > On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: >> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote: >>> For the new API a solution for "fallback mechanisms" should be >>> clean though and I am looking to stay as far as possible from the >>> existing

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Arend Van Spriel
On 18-12-2016 11:49, Jiri Slaby wrote: > On 12/18/2016, 12:59 AM, Linus Torvalds wrote: >> On Sat, Dec 17, 2016 at 12:57 AM, Jiri Slaby wrote: >>> >>> Yes, disk drivers won't load: >>> [2.141973] virtio_pci: disagrees about version of symbol mcount >>> [2.144415] virtio_pci: Unknown symbol

Re: wl1251 & mac address & calibration data

2016-12-18 Thread Pali Rohár
On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: > On 16-12-2016 11:40, Pali Rohár wrote: > > On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: > >> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote: > >>> For the new API a solution for "fallback mechanisms" should be > >>> clean th

[PATCH v6 6/6] [media] rc: add support for IR LEDs driven through SPI

2016-12-18 Thread Andi Shyti
The ir-spi is a simple device driver which supports the connection between an IR LED and the MOSI line of an SPI device. The driver, indeed, uses the SPI framework to stream the raw data provided by userspace through an rc character device. The chardev is handled by the LIRC framework and its func

[PATCH v6 2/6] [media] rc-main: split setup and unregister functions

2016-12-18 Thread Andi Shyti
Move the input device allocation, map and protocol handling to different functions. This patch fixes the following checkpatch error as well: ERROR: do not initialise statics to false #1438: FILE: drivers/media/rc/rc-main.c:1438: + static bool raw_init = false; /* raw decoders loaded?

[PATCH v6 4/6] [media] rc-ir-raw: do not generate any receiving thread for raw transmitters

2016-12-18 Thread Andi Shyti
Raw IR transmitters do not need any thread listening for occurring events. Check the driver type before running the thread. Signed-off-by: Andi Shyti Reviewed-by: Sean Young --- drivers/media/rc/rc-ir-raw.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v6 3/6] [media] rc-core: add support for IR raw transmitters

2016-12-18 Thread Andi Shyti
IR raw transmitter driver type is specified in the enum rc_driver_type as RC_DRIVER_IR_RAW_TX which includes all those devices that transmit raw stream of bit to a receiver. The data are provided by userspace applications, therefore they don't need any input device allocation, but still they need

[PATCH v6 5/6] Documentation: bindings: add documentation for ir-spi device driver

2016-12-18 Thread Andi Shyti
Document the ir-spi driver's binding which is a IR led driven through the SPI line. Signed-off-by: Andi Shyti Reviewed-by: Sean Young --- .../devicetree/bindings/leds/irled/spi-ir-led.txt | 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v6 1/6] [media] rc-main: assign driver type during allocation

2016-12-18 Thread Andi Shyti
The driver type can be assigned immediately when an RC device requests to the framework to allocate the device. This is an 'enum rc_driver_type' data type and specifies whether the device is a raw receiver or scancode receiver. The type will be given as parameter to the rc_allocate_device device.

[PATCH v6 0/6] Add support for IR transmitters

2016-12-18 Thread Andi Shyti
board which support is currently ongoing. The last patch adds support for an IR transmitter driven by the MOSI line of an SPI controller, it's the case of the Samsung TM2(e) board which support is currently ongoing. The patchset is based on next-20161218, while the media directory is a bit mor

Re: wl1251 & mac address & calibration data

2016-12-18 Thread Arend Van Spriel
On 18-12-2016 12:04, Pali Rohár wrote: > On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: >> On 16-12-2016 11:40, Pali Rohár wrote: >>> On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote: > For the new API a solution for "fal

Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds

2016-12-18 Thread Ard Biesheuvel
On 16 December 2016 at 21:51, Arnd Bergmann wrote: > On Friday, December 16, 2016 5:20:22 PM CET Ard Biesheuvel wrote: >> >> Can't we use the old >> >> tst lr, #1 >> moveq pc, lr >> bx lr >> >> trick? (where bx lr needs to be emitted as a plain opcode to hide it >> from the assembler) >> > > Yes,

[PATCH] lib/Kconfig.debug: fix frv build failure

2016-12-18 Thread Sudip Mukherjee
The build of frv allmodconfig was failing with the errors like: /tmp/cc0JSPc3.s: Assembler messages: /tmp/cc0JSPc3.s:1839: Error: symbol `.LSLT0' is already defined /tmp/cc0JSPc3.s:1842: Error: symbol `.LASLTP0' is already defined /tmp/cc0JSPc3.s:1969: Error: symbol `.LELTP0' is already defined /tm

Re: wl1251 & mac address & calibration data

2016-12-18 Thread Pali Rohár
On Sunday 18 December 2016 12:54:00 Arend Van Spriel wrote: > On 18-12-2016 12:04, Pali Rohár wrote: > > On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: > >> On 16-12-2016 11:40, Pali Rohár wrote: > >>> On Friday 16 December 2016 08:25:44 Daniel Wagner wrote: > On 12/16/2016 03:03

Re: [PATCH v3 0/7] power: supply: tps65217: Support USB charger feature

2016-12-18 Thread Sebastian Reichel
Hi, On Sun, Dec 18, 2016 at 11:54:25AM +0900, Milo Kim wrote: > TPS65217 device supports two charger inputs - AC and USB. > Currently, only AC charger is supported. This patch-set > adds USB charger feature. Tested on Beaglebone black. Thanks for your patchset. We are currently in the merge windo

[PATCH 2/4] mm: add new mmget() helper

2016-12-18 Thread Vegard Nossum
Apart from adding the helper function itself, the rest of the kernel is converted mechanically using: git grep -l 'atomic_inc.*mm_users' | xargs sed -i 's/atomic_inc(&\(.*\)->mm_users);/mmget\(\1\);/' git grep -l 'atomic_inc.*mm_users' | xargs sed -i 's/atomic_inc(&\(.*\)\.mm_users);/mmget\(

[PATCH 4/4] mm: clarify mm_struct.mm_{users,count} documentation

2016-12-18 Thread Vegard Nossum
Clarify documentation relating to mm_users and mm_count, and switch to kernel-doc syntax. Signed-off-by: Vegard Nossum --- include/linux/mm_types.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h ind

[PATCH 3/4] mm: use mmget_not_zero() helper

2016-12-18 Thread Vegard Nossum
We already have the helper, we can convert the rest of the kernel mechanically using: git grep -l 'atomic_inc_not_zero.*mm_users' | xargs sed -i 's/atomic_inc_not_zero(&\(.*\)->mm_users)/mmget_not_zero\(\1\)/' This is needed for a later patch that hooks into the helper, but might be a worthwhi

[PATCH 1/4] mm: add new mmgrab() helper

2016-12-18 Thread Vegard Nossum
Apart from adding the helper function itself, the rest of the kernel is converted mechanically using: git grep -l 'atomic_inc.*mm_count' | xargs sed -i 's/atomic_inc(&\(.*\)->mm_count);/mmgrab\(\1\);/' git grep -l 'atomic_inc.*mm_count' | xargs sed -i 's/atomic_inc(&\(.*\)\.mm_count);/mmgrab

[PATCH] scripts: checkincludes: add exit message for no duplicates found

2016-12-18 Thread Cheah Kok Cheong
If no duplicates found, inform user. Signed-off-by: Cheah Kok Cheong --- scripts/checkincludes.pl | 13 + 1 file changed, 13 insertions(+) diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl index 97b2c61..2bf234c 100755 --- a/scripts/checkincludes.pl +++ b/scripts/chec

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Nikolay Borisov
On 18.12.2016 13:03, Arend Van Spriel wrote: > On 18-12-2016 11:49, Jiri Slaby wrote: >> On 12/18/2016, 12:59 AM, Linus Torvalds wrote: >>> On Sat, Dec 17, 2016 at 12:57 AM, Jiri Slaby wrote: Yes, disk drivers won't load: [2.141973] virtio_pci: disagrees about version of symbo

Re: [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue

2016-12-18 Thread Martin Blumenstingl
Hi Florian, Hi Jerome, On Wed, Nov 30, 2016 at 2:15 AM, Florian Fainelli wrote: > On 11/29/2016 05:13 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 29 Nov 2016 16:43:20 -0800 >> >>> On 11/29/2016 04:38 PM, David Miller wrote: From: Jerome Brunet Date: Mon, 28 Nov 201

Re: [PATCH] drm/nouveau: use designated initializers

2016-12-18 Thread Daniel Vetter
On Fri, Dec 16, 2016 at 05:04:42PM -0800, Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from

[GIT pull] irq fix for 4.10

2016-12-18 Thread Thomas Gleixner
Linus, please pull the latest irq-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-urgent-for-linus A fix for the irq affinity spread algorithm so it handles non linear node numbering nicely. Thanks, tglx --> Guilherme

Re: crash during oom reaper

2016-12-18 Thread Tetsuo Handa
On 2016/12/16 22:14, Michal Hocko wrote: > On Fri 16-12-16 16:07:30, Kirill A. Shutemov wrote: >> On Fri, Dec 16, 2016 at 01:56:50PM +0100, Michal Hocko wrote: >>> On Fri 16-12-16 15:35:55, Kirill A. Shutemov wrote: On Fri, Dec 16, 2016 at 12:42:43PM +0100, Michal Hocko wrote: > On Fri 16-

[GIT pull] smp/hotplug fixes for 4.10

2016-12-18 Thread Thomas Gleixner
Linus, please pull the latest smp-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus Two fixlets for cpu hotplug: - Fix a subtle ordering problem with the dummy timer. This happened to work before the conversion by chance due t

[PATCH] media: dvb: dmx: fixed coding style issues of spacing

2016-12-18 Thread devendra sharma
Fixed coding style issues of spacing Signed-off-by: Devendra Sharma --- drivers/media/dvb-core/dmxdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c index efe55a3..cd240a2 100644 --- a/drivers/m

[GIT pull] timer fix for 4.10

2016-12-18 Thread Thomas Gleixner
Linus, please pull the latest timers-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers-urgent-for-linus Prevent NULL pointer dereferencing in the tick broadcast code. Old bug, which got unearthed by the hotplug ordering problem. Thanks,

regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Gabriel C
Hello, while testing kernel 4.9 I run into a weird issue with the ath9k driver. I can boot the box in console mode and it stay up sometime but is not usable. from dmesg : === [ INFO: suspicious RCU usage. ] 4.9-fw1 #1 Tainted: G I -

Re: [PATCH v6 4/5] PM / runtime: Use device links

2016-12-18 Thread Lukas Wunner
Hi Rafael, spotted what looks like a bug in the device links runtime PM code: When resuming a device, __rpm_callback() calls rpm_get_suppliers(dev): > + retval = rpm_get_suppliers(dev); > + if (retval) > + goto fail; This will

[GIT pull] x86 fixes and cleanups for 4.10

2016-12-18 Thread Thomas Gleixner
Linus, please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus This set of updates contains: - Robustification for the logical package managment. Cures the AMD and virtualization issues. - Put the

Re: [PATCH] kbuild: disable -ffunction-sections on gcc-4.7 with ftrace

2016-12-18 Thread Namhyung Kim
Hi, On Fri, Dec 16, 2016 at 6:24 PM, Arnd Bergmann wrote: > When ftrace is enabled and we build with gcc-4.7 or older, we > get a warning for each file on architectures that select > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION: > > warning: -ffunction-sections disabled; it makes profiling impossible [en

Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds

2016-12-18 Thread Russell King - ARM Linux
On Sun, Dec 18, 2016 at 11:57:00AM +, Ard Biesheuvel wrote: > On 16 December 2016 at 21:51, Arnd Bergmann wrote: > > On Friday, December 16, 2016 5:20:22 PM CET Ard Biesheuvel wrote: > >> > >> Can't we use the old > >> > >> tst lr, #1 > >> moveq pc, lr > >> bx lr > >> > >> trick? (where bx lr

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Jiri Slaby
On 12/18/2016, 02:27 PM, Nikolay Borisov wrote: > This is the likely problem here. No, it is not. How could a rpm be built with two compilers? Moreover, with some modules, __put_user_1 and others are reported instead of mcount. -- js suse labs

[PATCH V2 0/2] mm/memblock.c: fix potential bug and code refine

2016-12-18 Thread Wei Yang
Here are two patch of mm/memblock.c. [1]. A trivial code refine in memblock_is_region_memory(), which removes an unnecessary check on base address. [2]. The original code forgets to check the return value of memblock_reserve(), which may lead to potential problem. The patch fix this. --- v2: remov

[PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-18 Thread Wei Yang
The base address is already guaranteed to be in the region by memblock_search(). This patch removes the check on base. Signed-off-by: Wei Yang --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index 7608bc3..cd85303 100644 --- a/

[PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-18 Thread Wei Yang
memblock_reserve() may fail in case there is not enough regions. This patch checks the return value. Signed-off-by: Wei Yang --- mm/memblock.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index cd85303..93fa687 100644 --- a/mm/memblock.

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Nikolay Borisov
On 18.12.2016 16:45, Jiri Slaby wrote: > Moreover, with some modules, __put_user_1 and others are reported > instead of mcount. nm vmlinux | grep __fentry__ nm vmlinux | grep mcount What do these report ? I bet you that in your vmlinux the first one would return something like : 822f1

Re: [PATCH] ARM: disallow ARM_THUMB for ARMv4 builds

2016-12-18 Thread Ard Biesheuvel
On 18 December 2016 at 14:16, Russell King - ARM Linux wrote: > On Sun, Dec 18, 2016 at 11:57:00AM +, Ard Biesheuvel wrote: >> On 16 December 2016 at 21:51, Arnd Bergmann wrote: >> > On Friday, December 16, 2016 5:20:22 PM CET Ard Biesheuvel wrote: >> >> >> >> Can't we use the old >> >> >> >>

Re: [GIT PULL] kbuild changes for v4.9-rc1

2016-12-18 Thread Jiri Slaby
On 12/18/2016, 03:54 PM, Nikolay Borisov wrote: > > > On 18.12.2016 16:45, Jiri Slaby wrote: >> Moreover, with some modules, __put_user_1 and others are reported >> instead of mcount. > > > nm vmlinux | grep __fentry__ > nm vmlinux | grep mcount > > What do these report ? I bet you that in you

Re: [PATCH] qed: fix memory leak of a qed_spq_entry on error failure paths

2016-12-18 Thread David Miller
From: "Mintz, Yuval" Date: Sun, 18 Dec 2016 06:33:50 + >> From: Colin Ian King >> >> A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd >> if an error occurs, causing a memory leak. Fix this by kfree'ing it and also >> setting *pp_ent to NULL to be safe. >> >> Fou

Re: [PATCH v6 4/5] PM / runtime: Use device links

2016-12-18 Thread Rafael J. Wysocki
On Sun, Dec 18, 2016 at 3:01 PM, Lukas Wunner wrote: > Hi Rafael, > > spotted what looks like a bug in the device links runtime PM code: > > When resuming a device, __rpm_callback() calls rpm_get_suppliers(dev): > >> + retval = rpm_get_suppliers(dev); >> + i

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Paul E. McKenney
On Sun, Dec 18, 2016 at 02:52:48PM +0100, Gabriel C wrote: > Hello, > > while testing kernel 4.9 I run into a weird issue with the ath9k driver. > > I can boot the box in console mode and it stay up sometime but is not usable. Looks to me like someone forgot an rcu_read_unlock() somewhere. Give

Re: crash during oom reaper

2016-12-18 Thread Michal Hocko
On Sun 18-12-16 22:47:07, Tetsuo Handa wrote: > On 2016/12/16 22:14, Michal Hocko wrote: [...] > > I would have to rememeber all the details. This is mostly off-topic for > > this particular thread so I think it would be better if you could send a > > full patch separatelly and we can discuss it th

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-18 Thread Lino Sanfilippo
Hi, On 18.12.2016 01:15, Francois Romieu wrote: > Pavel Machek : > [...] >> Won't this up/down the interface, in a way userspace can observe? > > It won't up/down the interface as it doesn't exactly mimic what the > network code does (there's more than rtnl_lock). > Right. Userspace wont see l

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Tobias Klausmann
Hi, A patch for this is already floating on the ML for a while now latest: (ath9k: do not return early to fix rcu unlocking) Hopefully Kalle will include it in one of his upcoming pull requests. Greetings, Tobias On 18.12.2016 16:59, Paul E. McKenney wrote: On Sun, Dec 18, 2016 at 02:52:4

Re: [PATCH 2/5] dmaengine: Add support for custom data mapping

2016-12-18 Thread Vinod Koul
On Thu, Dec 15, 2016 at 03:25:52PM +0530, Abhishek Sahu wrote: > The current DMA APIs only support SGL or data in generic format. > The QCA BAM DMA engine data cannot be mapped with already > available APIs due to following reasons. > > 1. The QCA BAM DMA engine uses custom flags which cannot be >

Re: ipc: BUG: sem_unlock unlocks non-locked lock

2016-12-18 Thread Davidlohr Bueso
On Fri, 16 Dec 2016, Dmitry Vyukov wrote: [ BUG: bad unlock balance detected! ] 4.9.0+ #89 Not tainted Thanks for the report, I can reproduce the issue as of (which I obviously should have tested with lockdep): 370b262c896 (ipc/sem: avoid idr tree lookup for interrupted semop) I need to thin

Re: ipc: BUG: sem_unlock unlocks non-locked lock

2016-12-18 Thread Davidlohr Bueso
On Sun, 18 Dec 2016, Bueso wrote: On Fri, 16 Dec 2016, Dmitry Vyukov wrote: [ BUG: bad unlock balance detected! ] 4.9.0+ #89 Not tainted Thanks for the report, I can reproduce the issue as of (which I obviously should have tested with lockdep): 370b262c896 (ipc/sem: avoid idr tree lookup fo

Re: [BUG] kernel freeze, rcu_sched self-detected stall on CPU

2016-12-18 Thread Davidlohr Bueso
On Sat, 17 Dec 2016, Johanna Abrahamsson wrote: I will try to investigate this further but as I have limited knowledge of RCU and how the kernel works with semaphores don't expect any miracles :) Please see if this helps: https://lkml.org/lkml/2016/12/18/79 Thanks, Davidlohr

Re: [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

2016-12-18 Thread Michal Hocko
On Sat 17-12-16 20:17:07, Tetsuo Handa wrote: [...] > I feel that allowing access to memory reserves based on __GFP_NOFAIL might not > make sense. My understanding is that actual I/O operation triggered by I/O > requests by filesystem code are processed by other threads. Even if we grant > access t

Re: [PATCH v6 4/5] PM / runtime: Use device links

2016-12-18 Thread Lukas Wunner
On Sun, Dec 18, 2016 at 04:53:26PM +0100, Rafael J. Wysocki wrote: > On Sun, Dec 18, 2016 at 3:01 PM, Lukas Wunner wrote: > > Hi Rafael, > > > > spotted what looks like a bug in the device links runtime PM code: > > > > When resuming a device, __rpm_callback() calls rpm_get_suppliers(dev): > > > >

Re: [PATCH 3/3] iio: cros_ec_activity: add ChromeOS EC Activity Sensors

2016-12-18 Thread kbuild test robot
Hi Gwendal, [auto build test ERROR on iio/togreg] [also build test ERROR on next-20161216] [cannot apply to v4.9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Thierry-Escande/mfd-cros_ec-Add-a

[PATCH 4/4] x86/microcode/AMD: Use native_cpuid() in load_ucode_amd_bsp()

2016-12-18 Thread Borislav Petkov
From: Boris Ostrovsky When CONFIG_PARAVIRT is selected, cpuid() becomes a call. Since for 32-bit kernels load_ucode_amd_bsp() is executed before paging is enabled the call cannot be completed (as kernel virtual addresses are not reachable yet). Use native_cpuid() instead which is an asm wrapper

[PATCH 0/4] x86/microcode: Some 4.10 fixes

2016-12-18 Thread Borislav Petkov
From: Borislav Petkov Hi, here are 4 fixes for tip/urgent which address issues Boris and Jürgen reported while testing latest upstream on xen. As a result, let's just not load it at all when running on a hypervisor and be done with the d*icking around. Please apply, thanks. Boris Ostrovsky (1

[PATCH 2/4] x86/microcode/AMD: Sanitize apply_microcode_early_amd()

2016-12-18 Thread Borislav Petkov
From: Borislav Petkov Make it simply return bool to denote whether it found a container or not and return the pointer to the container and its size in the handed-in container pointer instead, as returning a struct was just silly. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/microcode

[PATCH 1/4] x86/microcode/AMD: Make find_proper_container() sane again

2016-12-18 Thread Borislav Petkov
From: Borislav Petkov Fixup signature and retvals, return the container struct through the passed in pointer, not as a function return value. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/microcode/amd.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff

[PATCH 3/4] x86/microcode/AMD: Do not load when running on a hypervisor

2016-12-18 Thread Borislav Petkov
From: Borislav Petkov Doing so is completely void of sense for multiple reasons so prevent it. Set dis_ucode_ldr to true and thus disable the microcode loader by default to address xen pv guests which execute the AP path but not the BSP path. By having it turned off by default, the APs won't run

[PATCH] staging: emxx_udc: Fix CamelCase styling issue

2016-12-18 Thread Afonso Bordado
Converts from CamelCase to the recommended style. Signed-off-by: Afonso Bordado --- drivers/staging/emxx_udc/emxx_udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index 3f42fa8..

Re: [RFC 1/1] MicroSemi Switchtec management interface driver

2016-12-18 Thread Logan Gunthorpe
Hi Greg, Thanks for the quick review! On 18/12/16 12:51 AM, Greg Kroah-Hartman wrote: On Sat, Dec 17, 2016 at 10:09:22AM -0700, Logan Gunthorpe wrote: +struct switchtec_dev { + struct pci_dev *pdev; + struct msix_entry *msix; + struct device *dev; + struct kref kref;

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-18 Thread Pavel Machek
Hi! > > - e1efa87241272104d6a12c8b9fcdc4f62634d447 > > Yep, a sync of the dma descriptors before the hardware gets ownership of the > tx tail > idx is missing in the stmmac, too. Thanks for the hint. Actually, the driver uses smp_wmb() which is completely crazy, and probably misses rmb() in cl

Re: [PATCH] Staging:comedi:cb_pcidas64=>Fixed check patch warnings

2016-12-18 Thread Joe Perches
On Sun, 2016-12-18 at 15:43 +0530, devendra sharma wrote: > Fixed check patch warnings about multiple line dereferencing []. > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c > b/drivers/staging/comedi/drivers/cb_pcidas64.c [] > @@ -2476,18 +2475,15 @@ static int setup_channel_queue(stru

Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

2016-12-18 Thread Joe Perches
On Sun, 2016-12-18 at 16:46 +, Afonso Bordado wrote: > Converts from CamelCase to the recommended style. > > Signed-off-by: Afonso Bordado > --- > drivers/staging/emxx_udc/emxx_udc.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/

Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

2016-12-18 Thread Scott Matheina
On 12/18/2016 01:46 AM, Greg KH wrote: On Sat, Dec 17, 2016 at 08:42:53PM -0600, Scott Matheina wrote: Signed-off-by: Scott Matheina I can't take patches without any changelog text :( Yah. Forgot to add the description. Added for v2. --- drivers/staging/fbtft/fb_agm1264k-fl.c | 17 ++

[PATCH v2] fix code alignment with open parenthesis

2016-12-18 Thread Scott Matheina
These changes where identified by checkpatch.pl as needed changes to align the code with the linux development coding style. The several lines of text where aligned with the precending parenthesis. Signed-off-by: Scott Matheina Changes to be committed: modified: drivers/staging/fbtft/

Re: [PATCH v6] soc: qcom: Add SoC info driver

2016-12-18 Thread Imran Khan
On 12/17/2016 6:56 AM, Stephen Boyd wrote: > On 12/15, Imran Khan wrote: >> On 12/14/2016 5:56 AM, Stephen Boyd wrote: >>> On 12/12, Imran Khan wrote: The SoC info driver provides information such as Chip ID, Chip family, serial number and other such details about Qualcomm SoCs. >>>

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-18 Thread Pavel Machek
Hi! > > - e1efa87241272104d6a12c8b9fcdc4f62634d447 > > Yep, a sync of the dma descriptors before the hardware gets ownership of the > tx tail > idx is missing in the stmmac, too. I can reproduce failure with 4.4 fairly easily. I tried with dma_ variant of barriers, and it failed, too [ 1018.41

Re: ipc: BUG: sem_unlock unlocks non-locked lock

2016-12-18 Thread Manfred Spraul
On 12/18/2016 05:29 PM, Davidlohr Bueso wrote: On Sun, 18 Dec 2016, Bueso wrote: On Fri, 16 Dec 2016, Dmitry Vyukov wrote: [ BUG: bad unlock balance detected! ] 4.9.0+ #89 Not tainted Thanks for the report, I can reproduce the issue as of (which I obviously should have tested with lockdep

[PATCH] ipc/sem.c: fix semop()/semop() locking failure

2016-12-18 Thread Manfred Spraul
Based on the syzcaller test case from dvyukov: https://gist.githubusercontent.com/dvyukov/d0e5efefe4d7d6daed829f5c3ca26a40/raw/08d0a261fe3c987bed04fbf267e08ba04bd533ea/gistfile1.txt The slow (i.e.: failure to acquire) syscall exit from semtimedop() incorrectly assumed that the the same lock is acq

[PATCH] vfs: return EOPNOTSUPP when ioctl_fsthaw() is not supported

2016-12-18 Thread Sami Kerola
An attempt to freeze a filesystem that does not support such operation is reported as EOPNOTSUPP to user. Running unfreeze to the same filesystem returns EINVAL. Later is a little misleading, users can mix that message with return value from unfreezing when filesystem is not frozen. Signed-off-b

Re: [PATCH v10 3/3] fpga: Add support for Lattice iCE40 FPGAs

2016-12-18 Thread Vladimir Zapolskiy
Hi Joel, On 12/18/2016 07:33 AM, Joel Holdsworth wrote: > This patch adds support to the FPGA manager for configuring the SRAM of > iCE40LM, iCE40LP, iCE40HX, iCE40 Ultra, iCE40 UltraLite and iCE40 > UltraPlus devices, through slave SPI. > > Signed-off-by: Joel Holdsworth > Reviewed-by: Marek Va

Re: [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges

2016-12-18 Thread Hans de Goede
Hi, On 17-12-16 16:12, Chen-Yu Tsai wrote: On Sat, Dec 17, 2016 at 4:09 AM, Hans de Goede wrote: The axp288 pmic has a lot more volatile registers then we were listing in axp288_volatile_ranges, fix this. Signed-off-by: Hans de Goede Acked-by: Chen-Yu Tsai Thank you. FYI, if you're go

Re: [PATCH] staging: emxx_udc: Fix CamelCase styling issue

2016-12-18 Thread Afonso Bordado
> Instead of merely converting Hungarian CamelCase to lowercase > with underscores where word transitions occurred, try reading > the code and making sense of what it does to perhaps find a > better variable name instead. Maybe eliminate the variable > altogether. > > iWordLength could be reads or

Re: [PATCH] printk: Remove no longer used second struct cont

2016-12-18 Thread Scott Matheina
On 12/15/2016 07:50 PM, Linus Torvalds wrote: On Thu, Dec 15, 2016 at 5:37 PM, Sergey Senozhatsky wrote: basically I'm talking about a bunch of 80-cols fixups. Please don't. Nobody uses a vt100 terminal any more. The 80-column wrapping is excessive, and makes things like "grep" not work as

Re: [PATCH] fix code alignment with open parenthesis in drivers/staging/fbtft/fb_agm1264k-fl.c

2016-12-18 Thread Scott Matheina
I just read an email from Linus saying keep the line length shorter than 100, so my patch isn't necessary. I sent the v2 out today, but wasn't aware of 100 being the new limit checkpatch.pl still has 80 as the limit. Sorry to bother. Please disregard my patch. On 12/18/2016 11:43 AM, Scott Mat

Re: thermal zones break with patch "Reimplement IDR and IDA using the radix tree" (mainline+next)

2016-12-18 Thread Andy Shevchenko
On Fri, Dec 16, 2016 at 11:19 PM, Matthew Wilcox wrote: > From: Heiko Stuebner [mailto:he...@sntech.de] >> commit b05bbe3ea2db ("Reimplement IDR and IDA using the radix tree") >> seems to >> break thermal zone allocation. This happens both on todays mainline and >> linux-next-20161216 and produces

[PATCH v3 1/1] x86, relocs: add printf attribute to die()

2016-12-18 Thread Nicolas Iooss
Adding such an attribute helps to detect errors in the format string at build time. After doing this, the compiler complains about such issues: arch/x86/tools/relocs.c:460:5: error: format specifies type 'int' but the argument has type 'Elf64_Xword' (aka 'unsigned long') [-Werror,-Wfor

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Valo, Kalle
Tobias Klausmann writes: > A patch for this is already floating on the ML for a while now latest: > (ath9k: do not return early to fix rcu unlocking) It's here: https://patchwork.kernel.org/patch/9472709/ > Hopefully Kalle will include it in one of his upcoming pull requests. Yes, I'll try to

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Tobias Klausmann
On 18.12.2016 20:57, Valo, Kalle wrote: Tobias Klausmann writes: A patch for this is already floating on the ML for a while now latest: (ath9k: do not return early to fix rcu unlocking) It's here: https://patchwork.kernel.org/patch/9472709/ Good to know! Hopefully Kalle will include it

Re: wl1251 & mac address & calibration data

2016-12-18 Thread Arend Van Spriel
On 18-12-2016 13:09, Pali Rohár wrote: > On Sunday 18 December 2016 12:54:00 Arend Van Spriel wrote: >> On 18-12-2016 12:04, Pali Rohár wrote: >>> On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote: On 16-12-2016 11:40, Pali Rohár wrote: > On Friday 16 December 2016 08:25:44 Daniel

[GIT pull] x86/timers for 4.10

2016-12-18 Thread Thomas Gleixner
Linus, please pull the latest x86-timers-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-timers-for-linus This is the last functional update from the tip tree for 4.10. It got delayed due to a newly reported and anlyzed variant of BIOS bug and the resul

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

2016-12-18 Thread Paul E. McKenney
On Sun, Dec 18, 2016 at 07:57:42PM +, Valo, Kalle wrote: > Tobias Klausmann writes: > > > A patch for this is already floating on the ML for a while now latest: > > (ath9k: do not return early to fix rcu unlocking) > > It's here: > > https://patchwork.kernel.org/patch/9472709/ Feel free to

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-18 Thread Pavel Machek
Hi! > > For the same reason it's broken if it races with the transmit path: it > > can release driver resources while the transmit path uses these. > > > > Btw the points below may not matter/hurt much for a proof a concept > > but they would need to be addressed as well: > > 1) unchecked (and av

[PATCH v4 1/2] FPGA: Add TS-7300 FPGA manager

2016-12-18 Thread Florian Fainelli
Add support for loading bitstreams on the Altera Cyclone II FPGA populated on the TS-7300 board. This is done through the configuration and data registers offered through a memory interface between the EP93xx SoC and the FPGA via an intermediate CPLD device. The EP93xx SoC on the TS-7300 does not

[PATCH v4 2/2] ARM: ep93xx: Register ts73xx-fpga manager driver for TS-7300

2016-12-18 Thread Florian Fainelli
Register the TS-7300 FPGA manager device drivers which allows us to load bitstreams into the on-board Altera Cyclone II FPGA. Acked-by: H Hartley Sweeten Signed-off-by: Florian Fainelli --- arch/arm/mach-ep93xx/ts72xx.c | 26 ++ 1 file changed, 26 insertions(+) diff --g

  1   2   3   >