Re: [PATCH] vfio/pci: Virtualize Maximum Payload Size

2017-09-20 Thread Sinan Kaya
On 9/20/2017 3:59 AM, Auger Eric wrote: >> My impression is that MRRS is predominantly device and driver >> dependent, not topology dependent. A device can send a read request >> with a size larger than MPS, which implies that the device supplying >> the read data would split it into multiple TLPs

[PATCH v3] kbuild: (bin)rpm-pkg: fix version number handling

2017-09-20 Thread Masahiro Yamada
The "Release:" field of the spec file is determined based on the .version file. However, the .version file is not copied to the source tar file. So, when we build the kernel from the source package, the UTS_VERSION always indicates #1. This does not match with "rpm -q". The kernel UTS_VERSION an

Re: [PATCH] vfio/pci: Virtualize Maximum Payload Size

2017-09-20 Thread Sinan Kaya
On 9/20/2017 9:01 AM, Sinan Kaya wrote: > The only valid criteria is that MRRS needs to be a multiple of MPS. > > https://linuxplumbersconf.org/2017/ocw//system/presentations/4732/original/crs.pdf > Apologies for sending the wrong link. Correcting it. https://linuxplumbersconf.org/2017/ocw//sys

[PATCH] ASoC: Intel: Skylake: fix swapped order of function arguments dir and pin_index

2017-09-20 Thread Colin King
From: Colin Ian King The call to slk_tplg_fill_res_tkn is passing dir and pin_index in the wrong order, they need to be in pin_index, dir order to match the function slk_tplg_fill_res_tkn correctly. Detected by CoveritScan, CID#1454992 ("Arguments in wrong order") Fixes: f6fa56e22559 ("ASoC: I

Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()

2017-09-20 Thread Oleg Nesterov
On 09/20, Oleg Nesterov wrote: > > @@ -908,13 +912,13 @@ long seccomp_get_filter(struct task_struct *task, > unsigned long filter_off, > if (!data) > goto out; > > - get_seccomp_filter(task); > + refcount_inc(&filter->usage); > spin_unlock_irq(&task->sighand->sigl

Re: [RESEND PATCH 0/4] EDAC: support reduce bus width on 98dx3236

2017-09-20 Thread Gregory CLEMENT
Hi Chris, On lun., août 07 2017, Chris Packham wrote: > (sorry I messed up sending this earlier, there is one additional patch and > I'll > actually include the linux-arm and linux-edac mailing lists) > > This series applies on top of Jan Lubbe's "EDAC drivers for Armada XP L2 and > DDR" seri

Re: linux-next: error while fetching the microblaze tree

2017-09-20 Thread Michal Simek
On 20.9.2017 07:36, Michal Simek wrote: > Hi Stephen, > > On 20.9.2017 01:26, Stephen Rothwell wrote: >> Hi Michal, >> >> On Thu, 7 Jan 2016 09:38:56 +1100 Stephen Rothwell >> wrote: >>> >>> Fetching the microblaze tree >>> (git://git.monstr.eu/linux-2.6-microblaze.git#next) produces this error.

[PATCH] scsi: libfc: fix potential null lport dereference

2017-09-20 Thread Colin King
From: Colin Ian King Don't pass a null lport to FC_LPORT_DBG as this causes a null pointer dereference when accessing lport->host and lport->port_id. Instead use the FC_CHECK_LOGGING macro to print the kernel message via pr_info. Detected by CoverityScan, CID#113198 ("Dereference after null chec

Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()

2017-09-20 Thread Tycho Andersen
On Wed, Sep 20, 2017 at 02:56:21PM +0200, Oleg Nesterov wrote: > As Chris explains, get_seccomp_filter() and put_seccomp_filter() can > use the different filters, once we drop ->siglock task->seccomp.filter > can be replaced by SECCOMP_FILTER_FLAG_TSYNC. > > Fixes: f8e529ed941b ("seccomp, ptrace:

[PATCH 1/3] tracing: Erase irqsoff trace with empty write

2017-09-20 Thread Steven Rostedt
From: Bo Yan One convenient way to erase trace is "echo > trace". However, this is currently broken if the current tracer is irqsoff tracer. This is because irqsoff tracer use max_buffer as the default trace buffer. Set the max_buffer as the one to be cleared when it's the trace buffer currently

[PATCH 2/3] tracing: Ignore mmiotrace from kernel commandline

2017-09-20 Thread Steven Rostedt
From: "Ziqian SUN (Zamir)" The mmiotrace tracer cannot be enabled with ftrace=mmiotrace in kernel commandline. With this patch, noboot is added to the tracer struct, and when system boot with a tracer that has noboot=true, it will print out a warning message and continue booting. Link: http://lk

[PATCH 0/3] [GIT PULL] tracing: Minor fixes for 4.14 (and stable)

2017-09-20 Thread Steven Rostedt
Linus, This includes 3 minor fixes. - Have writing to trace file clear the irqsoff (and friends) tracer - trace_pipe behavior for instance buffers was different than top buffer - Show a message of why mmiotrace doesn't start from commandline Please pull the latest trace-v4.14-rc1 tree, whi

[PATCH 3/3] tracing: Fix trace_pipe behavior for instance traces

2017-09-20 Thread Steven Rostedt
From: Tahsin Erdogan When reading data from trace_pipe, tracing_wait_pipe() performs a check to see if tracing has been turned off after some data was read. Currently, this check always looks at global trace state, but it should be checking the trace instance where trace_pipe is located at. Beca

Re: [PATCH v3 1/3] arm64/ras: support sea error recovery

2017-09-20 Thread Xie XiuQi
Hi James, I try to explain some of following questions. On 2017/9/16 2:33, James Morse wrote: > Hi Xie XiuQi, > > On 11/09/17 15:11, Xie XiuQi wrote: >> I first describe the approach of this patchset: >> >> A memory access error on the execution path usually triggers SEA. >> According to the exi

Re: [PATCH] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()

2017-09-20 Thread Tycho Andersen
On Wed, Sep 20, 2017 at 03:04:43PM +0200, Oleg Nesterov wrote: > On 09/20, Oleg Nesterov wrote: > > > > @@ -908,13 +912,13 @@ long seccomp_get_filter(struct task_struct *task, > > unsigned long filter_off, > > if (!data) > > goto out; > > > > - get_seccomp_filter(task); > > + r

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-20 Thread Arnd Bergmann
On Wed, Sep 20, 2017 at 12:24 PM, Martijn Coenen wrote: > On Wed, Sep 20, 2017 at 11:58 AM, Arnd Bergmann wrote: >> >> - Since you say there are existing users of recent 32-bit Android >> including Oreo, I also think that removing support for the v7 ABI >> is no longer an option. I only made

[PATCH 3/8] pinctrl: meson: remove offset continued - gxl

2017-09-20 Thread Jerome Brunet
Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxl.c | 814 +++--- 1 file changed, 402 insertions(+), 412 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c index 36c14b85fc7c..32e35ba9c04

[PATCH 7/8] pinctrl: meson-gx: TEST_N belongs to the AO controller

2017-09-20 Thread Jerome Brunet
On meson-gx platforms, TEST_N has been incorrectly declared in the EE controller while it belongs to AO controller. Move the pin to the appropriate controller Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 8 drivers/pinctrl/meson/pinctrl-meson-gxl.c | 8

[PATCH 8/8] pinctrl: meson-gxbb: add missing GPIOX_22 pin

2017-09-20 Thread Jerome Brunet
GPIOX_22 is declared as a gpio but the id is no present in the pin table. This hole trigger an error while reading the pingroup debugfs entry GPIOX_22 is no routed externally. For all we know, it could an internal pin of SoC Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-g

[PATCH 2/8] pinctrl: meson: remove offset continued - gxbb

2017-09-20 Thread Jerome Brunet
Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 854 ++--- 1 file changed, 425 insertions(+), 429 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 7bbc0d3cddcf..6d52842d3

[PATCH 0/8] pinctrl: meson: clean pin offsets

2017-09-20 Thread Jerome Brunet
The initial goal of this series was move to TEST_N pin from the EE controller to AO controller, where it belongs. This meant modify the EE_OFF value. This offset is a quirk we brought from the vendor driver when it was initially merged. There no reason to keep this around and we could simply let p

[PATCH 4/8] pinctrl: meson: remove offset continued - meson8

2017-09-20 Thread Jerome Brunet
Tested-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson8.c | 964 - 1 file changed, 476 insertions(+), 488 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8.c b/drivers/pinctrl/meson/pinctrl-meson8.c index

[PATCH 5/8] pinctrl: meson: remove offset continued - meson8b

2017-09-20 Thread Jerome Brunet
Tested-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson8b.c | 780 1 file changed, 388 insertions(+), 392 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c ind

[PATCH 6/8] pinctrl: meson: get rid of pin_base

2017-09-20 Thread Jerome Brunet
pin_base was used with the manually set pin offset in meson pinctrl. This is no longer the case, pin_base is 0 on every meson pinctrl controllers and should go away. Tested-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 2 -- drivers/pinct

[PATCH 1/8] pinctrl: meson: remove offset from pinctrl

2017-09-20 Thread Jerome Brunet
Offset on meson pinctrl and gpios is something that was carried from the vendor driver, where there is a weird link between the 2 controllers. Since these 2 controllers are independent, this offset adds an unnecessary complexity. This patch remove this manually set offset and rely on pinctrl to fi

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Stephan Mueller
Am Mittwoch, 20. September 2017, 12:52:21 CEST schrieb Jason A. Donenfeld: Hi Jason, > > This sounds incorrect to me. Choosing a fresh, random, one-time-use > 256-bit key and rolling with a zero nonce is a totally legitimate way > of using GCM. There's no possible reuse of the key stream this w

Re: [PATCH] [media] Siano: Use common error handling code in smsusb_init_device()

2017-09-20 Thread Dan Carpenter
On Wed, Sep 20, 2017 at 02:40:28PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 20 Sep 2017 14:30:55 +0200 > > Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This refactoring might fix also an error situation w

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Jason A. Donenfeld
On Wed, Sep 20, 2017 at 3:45 PM, Stephan Mueller wrote: > http://csrc.nist.gov/groups/ST/toolkit/BCM/documents/Joux_comments.pdf Section 3 shows an attack with repeated nonces, which we don't do here. Section 4 shows an attack using a non-96-bit nonce, which we also don't do here.

Re: [PATCH] PM: Document rules on using pm_runtime_resume() in system suspend callbacks

2017-09-20 Thread Rafael J. Wysocki
On Wed, Sep 20, 2017 at 2:28 PM, Ulf Hansson wrote: > On 20 September 2017 at 02:26, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> It quite often is necessary to resume devices from runtime suspend >> during system suspend for various reasons (for example, if their >> wakeup settings

Re: [PATCH] openrisc: dts: or1ksim: Add stdout-path

2017-09-20 Thread Stafford Horne
Hi Geert, On Tue, Sep 19, 2017 at 06:49:48PM +0200, Geert Uytterhoeven wrote: > Hi Stafford, > > On Tue, Sep 19, 2017 at 4:00 PM, Stafford Horne wrote: > > During reviews of the OpenRISC SMP patch series it was suggested to add > > stdout-path to the SMP dts file. Add stdout-path to our other d

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Stephan Mueller
Am Mittwoch, 20. September 2017, 16:01:21 CEST schrieb Jason A. Donenfeld: Hi Jason, > > Section 3 shows an attack with repeated nonces, which we don't do here. Maybe I miss a point here, but zero IVs is no repetition of nonces? Ciao Stephan

Re: [PATCH v1] usb: host: Implement workaround for Erratum A-007463

2017-09-20 Thread Alan Stern
The Subject: line should specify which type of USB host controller the patch is for. The kernel contains lots of different USB host controller drivers. How are we supposed to know that Erratum A-007463 applies to dwc3 xHCI controllers? The Subject: line should say something like: [PATCH v1] USB

[PATCH] pinctrl: meson: fix incorrect usage of ENOSYS

2017-09-20 Thread Jerome Brunet
ENOSYS is special and should only be used for incorrect syscall number. It is not the case here. let's use ENOTSUPP instead. Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-me

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Jason A. Donenfeld
On Wed, Sep 20, 2017 at 4:06 PM, Stephan Mueller wrote: >> Section 3 shows an attack with repeated nonces, which we don't do here. > > Maybe I miss a point here, but zero IVs is no repetition of nonces? If there's a fresh key each time, then no, it's not a repetition. This patch uses a fresh ran

Re: [PATCHv2 0/3] arm64: dts: ls1012a: add the DTS node for DSPI support

2017-09-20 Thread Shawn Guo
On Wed, Aug 30, 2017 at 06:12:35PM +0800, Zhiqiang Hou wrote: > From: Hou Zhiqiang > > Corrected the subject for 3/5 patch v1. > > Yuan Yao (3): > arm64: dts: ls1012a: add the DTS node for DSPI support > Documentation: fsl: dspi: Add fsl,ls1012a-dspi compatible string > Documentation: dt:

[PATCH v2] iommu/ipmmu-vmsa: Do not replace bus IOMMU ops on driver init.

2017-09-20 Thread Liviu Dudau
If the IPMMU driver is compiled in the kernel it will replace the platform bus IOMMU ops on running the ipmmu_init() function, regardless if there is any IPMMU hardware present or not. This screws up systems that just want to build a generic kernel that runs on multiple platforms and use a differen

Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup

2017-09-20 Thread Jan Kara
On Tue 19-09-17 13:53:02, Jens Axboe wrote: > This whole function is... interesting. Change the wakeup call > to the flusher threads to pass in nr_pages == 0, instead of > some random number of pages. This matches more closely what > similar cases do for memory shortage/reclaim. > > Signed-off-by:

Re: [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi()

2017-09-20 Thread Jan Kara
On Tue 19-09-17 13:53:03, Jens Axboe wrote: > Similar to wakeup_flusher_threads(), except that we only wake > up the flusher threads on the specified backing device. > > No functional changes in this patch. > > Signed-off-by: Jens Axboe Looks good. You can add: Reviewed-by: Jan Kara

Re: [PATCH net-next] net: dsa: Utilize dsa_slave_dev_check()

2017-09-20 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: > Instead of open coding the check. > > Signed-off-by: Florian Fainelli If we do need to use it outside one day, we may think about renaming netdev_uses_dsa() to netdev_is_dsa_master() and renaming dsa_slave_dev_check() to netdev_is_dsa_slave(). In the mea

Re: [PATCH] vfio/pci: Virtualize Maximum Payload Size

2017-09-20 Thread Auger Eric
Hi Sinan, On 20/09/2017 15:01, Sinan Kaya wrote: > On 9/20/2017 3:59 AM, Auger Eric wrote: >>> My impression is that MRRS is predominantly device and driver >>> dependent, not topology dependent. A device can send a read request >>> with a size larger than MPS, which implies that the device suppl

Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode

2017-09-20 Thread Jan Kara
On Tue 19-09-17 13:53:04, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our

Re: [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend

2017-09-20 Thread Richard Genoud
On 15/09/2017 16:04, Romain Izard wrote: > The atmel serial port driver reported the following warning on suspend: > atmel_usart f802.serial: ttyS1: Unable to drain transmitter > > As the ATMEL_US_TXEMPTY status bit in ATMEL_US_CSR is always cleared > when the transmitter is disabled, we need

Re: [PATCH 4/6] fs-writeback: make wb_start_writeback() static

2017-09-20 Thread Jan Kara
On Tue 19-09-17 13:53:05, Jens Axboe wrote: > We don't have any callers outside of fs-writeback.c anymore, > make it private. > > Signed-off-by: Jens Axboe You can add: Reviewed-by: Jan Kara Honza > --- > fs/fs-writeback.c

Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location

2017-09-20 Thread Jan Kara
On Tue 19-09-17 13:53:06, Jens Axboe wrote: > Now that we have no external callers of wb_start_writeback(), > we can move the nr_pages == 0 logic into that function. > > Signed-off-by: Jens Axboe ... > +static unsigned long get_nr_dirty_pages(void) > +{ > + return global_node_page_state(NR_

Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush

2017-09-20 Thread Jan Kara
On Tue 19-09-17 22:13:25, Jens Axboe wrote: > On 09/19/2017 09:10 PM, Amir Goldstein wrote: > New version: > > http://git.kernel.dk/cgit/linux-block/commit/?h=writeback-fixup&id=338a69c217cdaaffda93f3cc9a364a347f782adb This looks good to me. You can add: Reviewed-by: Jan Kara

Re: [PATCH v2 37/40] tracing: Add inter-event hist trigger Documentation

2017-09-20 Thread Julia Cartwright
On Tue, Sep 05, 2017 at 04:57:49PM -0500, Tom Zanussi wrote: > Add background and details on inter-event hist triggers, including > hist variables, synthetic events, and actions. > > Signed-off-by: Tom Zanussi > Signed-off-by: Baohong Liu > --- > Documentation/trace/events.txt | 385 >

usb/core: slab-out-of-bounds read in cdc_parse_cdc_header

2017-09-20 Thread Andrey Konovalov
Hi! I've got the following crash while fuzzing the kernel with syzkaller. On commit ebb2c2437d8008d46796902ff390653822af6cc4 (Sep 18). It looks like cdc_parse_cdc_header() doesn't validate buflen before accessing buffer[1], buffer[2] and so on. The only check present is while (buflen > 0).

Re: [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL

2017-09-20 Thread Viresh Kumar
On 20-09-17, 15:04, Dong Aisheng wrote: > On Tue, Sep 19, 2017 at 04:10:07PM -0700, Viresh Kumar wrote: > > On 24-08-17, 00:10, Dong Aisheng wrote: > > > If no valid transition_latency specified, let's make it default to > > > CPUFREQ_ETERNAL which is consistent with its definition. > > > > > > Th

4.13 breaks suspend to ram wakeup

2017-09-20 Thread Norbert Preining
Hi, (please Cc) I recently upgraded my Lenovo X260 from 4.12 to 4.13 and with the very same software (Debian/sid) 4.13 does not properly wake up from suspend to ram. It wakes up, shows X very quickly, but it seems that the hard disk is sleeping and not reacting. I can move the mouse, but the u

Re: [PATCH] PM / OPP: Handle return value of kasprintf

2017-09-20 Thread Viresh Kumar
On 20-09-17, 04:17, Joe Perches wrote: > On Wed, 2017-09-20 at 12:29 +0530, Arvind Yadav wrote: > > kasprintf() can fail here and we must check its return value. > [] > > diff --git a/drivers/base/power/opp/debugfs.c > > b/drivers/base/power/opp/debugfs.c > [] > > @@ -45,7 +45,8 @@ static bool opp

[PATCH v3 0/2] stm32 clocksource driver rework

2017-09-20 Thread Benjamin Gaignard
version 3: - fix comments done by Daniel - use timer_of helper functions version 2: - fix uninitialized variable These patch implements clocksource and clockevent by using only one hardware block. Getting both clock source and events on the same hardware lead to change quite a lot driver code. I

[PATCH v3 1/2] clocksource: stm32: add clocksource support

2017-09-20 Thread Benjamin Gaignard
Rework driver code to be able to implement clocksource and clockevent on the same hardware block. Before this patch only the counter of the hardware block was used to generate clock events. Now counter will be used to provide a 32 bits clock source and a comparator will provide clock events. In a

[PATCH v3 2/2] arm: dts: stm32: remove useless clocksource nodes

2017-09-20 Thread Benjamin Gaignard
16 bits timers aren't accurate enough to be used as clocksource, remove them from stm32f4 and stm32f7 devicetree. Signed-off-by: Benjamin Gaignard --- arch/arm/boot/dts/stm32f429.dtsi | 32 arch/arm/boot/dts/stm32f746.dtsi | 32 2

Re: [PATCH] rwsem: fix missed wakeup due to reordering of load

2017-09-20 Thread Davidlohr Bueso
On Thu, 07 Sep 2017, Prateek Sood wrote: /* + * __rwsem_down_write_failed_common(sem) + * rwsem_optimistic_spin(sem) + * osq_unlock(sem->osq) + * ... + * atomic_long_add_return(&sem->count) + * + * - VS - + * + *

Re: [PATCH v2 0/2] ARM: Actions Semi S500 SMP cleanups

2017-09-20 Thread Andreas Färber
Am 05.09.2017 um 23:19 schrieb Andreas Färber: > Hello, > > This mini-series further cleans up the SMP code for Actions Semi S500 SoC. > > @David, can you please reply with an Acked-by for the second patch? Thanks! > > Work branch for testing: > https://github.com/afaerber/linux/commits/bg96-nex

Re: [PATCH v6] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Jason A. Donenfeld
On Tue, Sep 19, 2017 at 5:38 PM, David Howells wrote: > Jason A. Donenfeld wrote: > >> And, some error paths forgot to zero out sensitive >> material, so this patch changes a kfree into a kzfree. > > Can you split that out into a separate preparatory patch? > > Also, I recommend limiting the line

[PATCH v7 2/2] security/keys: rewrite all of big_key crypto

2017-09-20 Thread Jason A. Donenfeld
This started out as just replacing the use of crypto/rng with get_random_bytes_wait, so that we wouldn't use bad randomness at boot time. But, upon looking further, it appears that there were even deeper underlying cryptographic problems, and that this seems to have been committed with very little

[PATCH v7 1/2] security/keys: properly zero out sensitive key material in big_key

2017-09-20 Thread Jason A. Donenfeld
Error paths forgot to zero out sensitive material, so this patch changes some kfrees into a kzfrees. Signed-off-by: Jason A. Donenfeld Reviewed-by: Eric Biggers Cc: David Howells Cc: Herbert Xu Cc: Kirill Marinushkin Cc: secur...@kernel.org Cc: sta...@vger.kernel.org --- security/keys/big_ke

Re: [PATCH] nvme: make controller 'state' sysfs attribute pollable

2017-09-20 Thread Christoph Hellwig
On Wed, Sep 20, 2017 at 12:40:32PM +0200, Johannes Thumshirn wrote: > Notify sysfs about changes of a nvme controller so user-space can watch the > file via poll() or select() in order to react to a state change. Userspace has no business polling for the state.

Re: [PATCH] mpt3sas: downgrade full copy_from_user to access_ok check

2017-09-20 Thread Christoph Hellwig
On Tue, Sep 19, 2017 at 11:11:11PM -0400, Meng Xu wrote: > Since right after the user copy, we are going to > memset(&karg, 0, sizeof(karg)), I guess an access_ok check is enough? The right thing is to remove it entirely.

Re: [PATCH] vfio/pci: Virtualize Maximum Payload Size

2017-09-20 Thread Sinan Kaya
On 9/20/2017 10:26 AM, Auger Eric wrote: >> Because completions are required to be a minimum of MPS size. If MRRS > MPS, >> read response is sent as multiple completions. > With that patch, you can end up with MRRS < MPS. Do I understand > correctly this is an issue? To give the right context, I t

Re: [kernel-hardening] [PATCH v2 0/5] stackprotector: ascii armor the stack canary

2017-09-20 Thread Solar Designer
On Wed, Sep 20, 2017 at 01:18:04PM +0200, Yann Droneaud wrote: > Le mardi 19 septembre 2017 ?? 19:16 +0200, Solar Designer a ??crit : > > > > We could put/require a NUL in the middle of the canary, > > but with the full canary being only 64-bit at most that would also > > make some attacks easier.

Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location

2017-09-20 Thread Jens Axboe
On 09/20/2017 08:41 AM, Jan Kara wrote: > On Tue 19-09-17 13:53:06, Jens Axboe wrote: >> Now that we have no external callers of wb_start_writeback(), >> we can move the nr_pages == 0 logic into that function. >> >> Signed-off-by: Jens Axboe > > ... > >> +static unsigned long get_nr_dirty_pages(

[PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

2017-09-20 Thread Meng Xu
Since right after the user copy, we are going to memset(&karg, 0, sizeof(karg)), the copy_from_user is redundant Signed-off-by: Meng Xu --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3s

Re: [PATCH 0/3] Add and enable DSP device on OMAPL138 LCDK board

2017-09-20 Thread Sekhar Nori
Hi Suman, On Tuesday 19 September 2017 05:58 AM, Suman Anna wrote: > Hi Sekhar, > > The following series adds the DT node for the DSP device present on > on DA850/OMAPL138 SoCs. The node is disabled in the base dts file, and > enabled in the corresponding LCDK board file alongside the reserved >

Re: [PATCH] ARM: dts: am43xx-epos-evm: Enable SGX on EPOS boards

2017-09-20 Thread Andrew F. Davis
On 09/18/2017 12:31 PM, Andrew F. Davis wrote: > From: Yogesh Siraswar > > The SGX IP is valid and usable on AM438x devices, enable this > here. > > Signed-off-by: Yogesh Siraswar > Signed-off-by: Andrew F. Davis > --- > arch/arm/boot/dts/am43x-epos-evm.dts | 4 > 1 file changed, 4 inser

Re: [RFC] livepatch: unpatch all klp_objects if klp_module_coming fails

2017-09-20 Thread Joe Lawrence
On Wed, Sep 20, 2017 at 01:19:05PM +0200, Miroslav Benes wrote: > On Wed, 13 Sep 2017, Joe Lawrence wrote: > > > Hi Miroslav, > > Hi, > > sorry for the late response. I'm also travelling now and we have SUSECon > conference next week, so just a quick answer. It looks ok at first glance, > but

[PATCH] ARM: unaligned.h: Use an arch-specific version

2017-09-20 Thread Romain Izard
For the 32-bit ARM architecture, unaligned access support is variable. On a chip without a MMU, an unaligned access returns a rotated data word and must be avoided. When a MMU is available, it can be trapped. On ARMv6 or ARMv7, it can also be handled by the hardware, depending on the type of acces

[RFC PATCH 0/7] AXP803 AC/Battery support

2017-09-20 Thread Icenowy Zheng
The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power inputs: AC, USB and Battery. This patchset adds support for the AC and Battery supplies, which is useful for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, Pinebook). The USB supply is not yet supported in this pat

[RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies

2017-09-20 Thread Icenowy Zheng
The AXP803 PMIC has different Battery and USB power supplies than the AXP series PMICs already supported by the kernel, but the AC power supply is the same as AXP22x (as it can only detect the present/online state of the AC power supply on both AXP22x and AXP803). Add compatible strings for the AX

[RFC PATCH 2/7] iio: adc: axp20x-adc: allow to skip ADC rate setup now

2017-09-20 Thread Icenowy Zheng
The ADC rate setup on AXP803 is more complex than AXP20x/22x. As it's not a necessary setup, allow it to be skipped, to allow simpler AXP803 support now. Signed-off-by: Icenowy Zheng --- drivers/iio/adc/axp20x_adc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

[RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803

2017-09-20 Thread Icenowy Zheng
AXP803 SoC features an ADC part including these channels: GPADC (GPIO0) and TS pins, PMIC internal temperature sensor, battery voltage, battery charge/discharge current. Add support for the battery-related channels and internal temperature channel in order to allow battery monitoring. The TS and G

[RFC PATCH 4/7] power: supply: axp20x-battery: support AXP803

2017-09-20 Thread Icenowy Zheng
The AXP803 PMIC has battery support like other AXP PMICs, but with different definition of max target charging voltage and constant charging current. Add support for AXP803 battery in axp20x-battery driver. Signed-off-by: Icenowy Zheng --- drivers/power/supply/axp20x_battery.c | 88

Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup

2017-09-20 Thread Jens Axboe
On 09/20/2017 08:17 AM, Jan Kara wrote: > On Tue 19-09-17 13:53:02, Jens Axboe wrote: >> This whole function is... interesting. Change the wakeup call >> to the flusher threads to pass in nr_pages == 0, instead of >> some random number of pages. This matches more closely what >> similar cases do fo

[RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery

2017-09-20 Thread Icenowy Zheng
As we have now support for AXP803 ADC/Battery, and the AC Power part of AXP803 is the same as AXP22x, add MFD cells for these drivers. Signed-off-by: Icenowy Zheng --- drivers/mfd/axp20x.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.

[PATCH] hexagon: get rid of #include

2017-09-20 Thread Masahiro Yamada
is created (or updated) when Kbuild descends into the init/ directory. In parallel building from a pristine source tree, there is no guarantee exists when arch/hexagon/kernel/ptrace.c is compiled. For hexagon architecture, we know UTS_MACHINE is a fixed string "hexagon", so let's hard-code it,

Re: [PATCH] mpt3sas: remove redundant copy_from_user in _ctl_getiocinfo

2017-09-20 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64

2017-09-20 Thread Icenowy Zheng
The Pine64 boards (including the Plus variant) have a Micro-USB jack with it's 5V connected to the ACIN of the AXP803 PMIC and a battery connector connected to the battery pins of the AXP803 PMIC. Enable AC and Battery power supplies for Pine64, in order to monitor them in the system. Signed-off-

[RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI

2017-09-20 Thread Icenowy Zheng
AXP803 PMIC features AC/USB/Battery power supplies. As we have now the device tree bindings for them, add device tree nodes for them. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/d

Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode

2017-09-20 Thread Jens Axboe
On 09/20/2017 08:35 AM, Jan Kara wrote: > On Tue 19-09-17 13:53:04, Jens Axboe wrote: >> Laptop mode really wants to writeback the number of dirty >> pages and inodes. Instead of calculating this in the caller, >> just pass in 0 and let wakeup_flusher_threads() handle it. >> >> Use the new wakeup_f

[PATCH] init/version: include instead of

2017-09-20 Thread Masahiro Yamada
init/version.c has nothing to do with module, so remove the . Instead, include for EXPORT_SYMBOL_GPL. This cuts off a lot of unnecessary header parsing. Signed-off-by: Masahiro Yamada --- init/version.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/version.c b/init

[PATCH] reset: socfpga: build the reset-socfpga for Stratix10 SOC

2017-09-20 Thread Dinh Nguyen
Enable the reset driver to get built for the Stratix10 platform. Signed-off-by: Dinh Nguyen --- drivers/reset/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 608c071..ab8895b 100644 --- a/drivers/reset/Kconfig +++ b/

Re: 7898f79654 ("x86/mm/64: Fix an incorrect warning with CONFIG_DEBUG_VM=y, !PCID"): WARNING: CPU: 0 PID: 0 at arch/x86/mm/tlb.c:245 initialize_tlbstate_and_flush

2017-09-20 Thread Andy Lutomirski
> On Sep 20, 2017, at 4:22 AM, Fengguang Wu wrote: > > Hi Andy, > > Your patch triggers the warning (not 100% reproducible) with the > attached kconfig and KVM reproduce script. It may be relevant to an > old bug though, since the dmesg is not clean and contains another BUG > trace dump. This

Re: [PATCH] ARM: unaligned.h: Use an arch-specific version

2017-09-20 Thread Ard Biesheuvel
Hi Romain, On 20 September 2017 at 08:18, Romain Izard wrote: > For the 32-bit ARM architecture, unaligned access support is variable. > On a chip without a MMU, an unaligned access returns a rotated data word > and must be avoided. > > When a MMU is available, it can be trapped. On ARMv6 or ARMv

[PATCH] iommu/iova: Improve alloc_iova performance

2017-09-20 Thread David Woods
When allocating pages with alloc_iova() where limit_pfn > dma_32bit_pfn __alloc_and_insert_iova_range does a linear traversal of the tree to find a free block. In the worst case it makes the alloc O(n) for each page, where n is the number of pages allocated so far. The worst case turns out to be

[PATCH] x86/boot: remove bogus #include

2017-09-20 Thread Masahiro Yamada
The defines UTS_RELEASE, but I do not see any reference to it in arch/x86/boot/header.S . Signed-off-by: Masahiro Yamada --- arch/x86/boot/header.S | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S index 1bb08ec..16c516b 100644 --- a/arch/x86/bo

[PATCH 0/7 v2] More graceful flusher thread memory reclaim wakeup

2017-09-20 Thread Jens Axboe
We've had some issues with writeback in presence of memory reclaim at Facebook, and this patch set attempts to fix it up. The real functional change is the last patch in the series, the first 5 are prep and cleanup patches. The basic idea is that we have callers that call wakeup_flusher_threads()

[PATCH 6/7] fs-writeback: move nr_pages == 0 logic to one location

2017-09-20 Thread Jens Axboe
Now that we have no external callers of wb_start_writeback(), we can shuffle the passing in of 'nr_pages'. Everybody passes in 0 at this point, so just kill the argument and move the dirty count retrieval to that function. Acked-by: Johannes Weiner Tested-by: Chris Mason Signed-off-by: Jens Axbo

[PATCH 7/7] fs-writeback: only allow one inflight and pending full flush

2017-09-20 Thread Jens Axboe
When someone calls wakeup_flusher_threads() or wakeup_flusher_threads_bdi(), they schedule writeback of all dirty pages in the system (or on that bdi). If we are tight on memory, we can get tons of these queued from kswapd/vmscan. This causes (at least) two problems: 1) We consume a ton of memory

[PATCH 5/7] fs-writeback: make wb_start_writeback() static

2017-09-20 Thread Jens Axboe
We don't have any callers outside of fs-writeback.c anymore, make it private. Acked-by: Johannes Weiner Tested-by: Chris Mason Reviewed-by: Jan Kara Signed-off-by: Jens Axboe --- fs/fs-writeback.c | 4 ++-- include/linux/backing-dev.h | 2 -- 2 files changed, 2 insertions(+), 4 dele

[PATCH 2/7] fs: kill 'nr_pages' argument from wakeup_flusher_threads()

2017-09-20 Thread Jens Axboe
Everybody is passing in 0 now, let's get rid of the argument. Signed-off-by: Jens Axboe --- fs/buffer.c | 2 +- fs/fs-writeback.c | 9 - fs/sync.c | 2 +- include/linux/writeback.h | 2 +- mm/vmscan.c | 2 +- 5 files changed, 8 insertio

[PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode

2017-09-20 Thread Jens Axboe
Laptop mode really wants to writeback the number of dirty pages and inodes. Instead of calculating this in the caller, just pass in 0 and let wakeup_flusher_threads() handle it. Use the new wakeup_flusher_threads_bdi() instead of rolling our own. This changes the writeback to not be range cyclic,

Re: [PATCH v2] mm: introduce validity check on vm dirtiness settings

2017-09-20 Thread Jan Kara
On Tue 19-09-17 19:48:00, Yafang Shao wrote: > 2017-09-19 16:35 GMT+08:00 Jan Kara : > > On Tue 19-09-17 06:53:00, Yafang Shao wrote: > >> + if (vm_dirty_bytes == 0 && vm_dirty_ratio == 0 && > >> + (dirty_background_bytes != 0 || dirty_background_ratio != 0)) > >> + ret

[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup

2017-09-20 Thread Jens Axboe
This whole function is... interesting. Change the wakeup call to the flusher threads to pass in nr_pages == 0, instead of some random number of pages. This matches more closely what similar cases do for memory shortage/reclaim. Acked-by: Johannes Weiner Tested-by: Chris Mason Reviewed-by: Jan Ka

[PATCH] PM / OPP: Call notifier without holding opp_table->lock

2017-09-20 Thread Viresh Kumar
The notifier callbacks may want to call some OPP helper routines which may try to take the same opp_table->lock again and cause a deadlock. One such usecase was reported by Chanwoo Choi, where calling dev_pm_opp_disable() leads us to the devfreq's OPP notifier handler, which further calls dev_pm_op

[PATCH 3/7] fs-writeback: provide a wakeup_flusher_threads_bdi()

2017-09-20 Thread Jens Axboe
Similar to wakeup_flusher_threads(), except that we only wake up the flusher threads on the specified backing device. No functional changes in this patch. Acked-by: Johannes Weiner Tested-by: Chris Mason Reviewed-by: Jan Kara Signed-off-by: Jens Axboe --- fs/fs-writeback.c | 39 +

Attention; please

2017-09-20 Thread Mr Richard Kwadwo
-- Dear friend, I hope this letter meets you in good health. I am writing to solicit your assistance in the Transfer of US$14,000,000.00 Dollars. I am willing to transfer the fund and, invest in your country through your assistance only if you will be willing work with me. I am in Ghana present

Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location

2017-09-20 Thread Jan Kara
On Wed 20-09-17 09:05:51, Jens Axboe wrote: > On 09/20/2017 08:41 AM, Jan Kara wrote: > > On Tue 19-09-17 13:53:06, Jens Axboe wrote: > >> Now that we have no external callers of wb_start_writeback(), > >> we can move the nr_pages == 0 logic into that function. > >> > >> Signed-off-by: Jens Axboe

Applied "ASoC: rl6231: make arrays div and pd static const, reduces object code size" to the asoc tree

2017-09-20 Thread Mark Brown
The patch ASoC: rl6231: make arrays div and pd static const, reduces object code size has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in th

Re: 4.13 breaks suspend to ram wakeup

2017-09-20 Thread Ming Lei
On Wed, Sep 20, 2017 at 10:36 PM, Norbert Preining wrote: > Hi, > > (please Cc) > > I recently upgraded my Lenovo X260 from 4.12 to 4.13 and with the very > same software (Debian/sid) 4.13 does not properly wake up from > suspend to ram. > > It wakes up, shows X very quickly, but it seems that the

<    1   2   3   4   5   6   7   8   9   >