Re: Linux 4.16-rc4

2018-03-05 Thread Peter Zijlstra
On Mon, Mar 05, 2018 at 07:38:49AM -0600, Josh Poimboeuf wrote: > It looks like read_retpoline_hints() is "special" compared to the other > annotation reading functions. I copied the pattern from read_unwind_hints.. which might not have been the best choice it appears ;-) > The easiest fix would

[PATCH] MIPS: Fix build with DEBUG_ZBOOT and MACH_JZ4770

2018-03-05 Thread Paul Cercueil
The debug definitions were missing for MACH_JZ4770, resulting in a build failure when DEBUG_ZBOOT was set. Since the UART addresses are the same across all Ingenic SoCs, we just use a #ifdef CONFIG_MACH_INGENIC instead of checking for indifidual Ingenic SoCs. Additionally, I added a #define for t

Re: C tricks for efficient stack zeroing

2018-03-05 Thread Laura Abbott
On 03/02/2018 11:50 AM, Jason A. Donenfeld wrote: Hi list, I'm writing this email to solicit tricks for efficiently zeroing out the stack upon returning from a function. The reason this is often desirable is if the stack contains intermediate values that could assist in some form of cryptographi

[PATCH] leds: fix wrong dmi_match on PC Engines APU LEDs

2018-03-05 Thread Hans Ulli Kroll
APU has compared to APU2 no DMI_BOARD_NAME. Use DMI_PRODUCT_NAME instead. Signed-off-by: Hans Ulli Kroll --- drivers/leds/leds-apu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c index 74820aab9497..5bbf5c31413e 100644 --- a

Re: [PATCH] arm64: KVM: Use SMCCC_ARCH_WORKAROUND_1 for Falkor BP hardening

2018-03-05 Thread Will Deacon
On Mon, Mar 05, 2018 at 10:57:58AM -0600, Shanker Donthineni wrote: > Hi Will, > > On 03/05/2018 09:56 AM, Will Deacon wrote: > > Hi Shanker, > > > > On Fri, Mar 02, 2018 at 03:50:18PM -0600, Shanker Donthineni wrote: > >> The function SMCCC_ARCH_WORKAROUND_1 was introduced as part of SMC > >> V1

Applied "ASoC: Intel: Skylake: Fix typo" to the asoc tree

2018-03-05 Thread Mark Brown
The patch ASoC: Intel: Skylake: Fix typo has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during t

Applied "regulator: core: Fix build errors" to the regulator tree

2018-03-05 Thread Mark Brown
The patch regulator: core: Fix build errors has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Li

Applied "regulator: core: use NULL rather than 0 for cells_name argument" to the regulator tree

2018-03-05 Thread Mark Brown
The patch regulator: core: use NULL rather than 0 for cells_name argument has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Re: [PATCH v8 0/5] iommu/arm-smmu: Add runtime pm/sleep support

2018-03-05 Thread Vivek Gautam
Hi Tomasz, On 3/5/2018 6:55 PM, Tomasz Figa wrote: Hi Vivek, On Fri, Mar 2, 2018 at 7:10 PM, Vivek Gautam wrote: This series provides the support for turning on the arm-smmu's clocks/power domains using runtime pm. This is done using the recently introduced device links patches, which lets t

Re: [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing

2018-03-05 Thread Heiko Stübner
Hi Daniel, Am Montag, 5. März 2018, 16:57:13 CET schrieb Daniel Schultz: > On 03/05/2018 03:15 PM, Heiko Stuebner wrote: > > Am Montag, 5. März 2018, 13:45:11 CET schrieb Daniel Schultz: > >> The CLK_O_SEL default is synchronous to XI input clock, which is 25 MHz. > >> Set CLK_O_SEL to channel A t

Re: Linux 4.16-rc4

2018-03-05 Thread Sven Joachim
On 2018-03-05 07:38 -0600, Josh Poimboeuf wrote: > On Mon, Mar 05, 2018 at 11:17:48AM +0100, Peter Zijlstra wrote: >> On Mon, Mar 05, 2018 at 09:09:31AM +0100, Sven Joachim wrote: >> > On 2018-03-04 15:15 -0800, Linus Torvalds wrote: >> > >> > > Hmm. A reasonably calm week - the biggest change is

Re: [PATCH 07/34] x86/entry/32: Restore segments before int registers

2018-03-05 Thread Brian Gerst
On Mon, Mar 5, 2018 at 11:44 AM, Joerg Roedel wrote: > On Mon, Mar 05, 2018 at 09:51:29AM -0500, Brian Gerst wrote: >> For the IRET fault case you will still need to catch it in the >> exception code. See the 64-bit code (.Lerror_bad_iret) for example. >> For 32-bit, you could just expand that ch

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-05 Thread Benjamin Tissoires
Hi Florent, On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado wrote: > Hello Florent, > > In my view, this driver may not be a good idea. The default behaviour > of K290 is 'send multimedia keycodes' with the user given the choice > to change that behaviour via vendor commands. Putting a drive

Re: lost interrupts when running sabrelite images (v4.15+) in qemu

2018-03-05 Thread Troy Kisky
On 3/3/2018 1:12 PM, Guenter Roeck wrote: > On 03/03/2018 12:48 PM, Guenter Roeck wrote: >> On 03/03/2018 11:07 AM, Troy Kisky wrote: >>> On 3/3/2018 8:32 AM, Guenter Roeck wrote: Hi, since v4.15, I get the following runtime warning when running sabrelite images in qemu. >

Re: [RFC/PATCH RT] Revert "rt,ntp: Move call to schedule_delayed_work() to helper thread"

2018-03-05 Thread Steven Rostedt
On Fri, 2 Mar 2018 12:26:03 +0100 (CET) Thomas Gleixner wrote: > On Fri, 2 Mar 2018, Sebastian Andrzej Siewior wrote: > > > I've been looking at this in v3.10-RT where it got in. The patch > > description says > > > > |The ntp code for notify_cmos_timer() is called from a hard interrupt > > |co

[ANNOUNCE] v4.14.24-rt19

2018-03-05 Thread Sebastian Andrzej Siewior
Dear RT folks! I'm pleased to announce the v4.14.24-rt19 patch set. Changes since v4.14.24-rt18: - Some adjtimex related code has been moved to a helper thread after it has been claimed that it is called from hard interrupt context. I was not able to find that hard interrupt context a

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Bin Liu
On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > * Merlijn Wajer [180227 22:29]: > > Without pm_runtime_{get,put}_sync calls in place, reading > > vbus status via /sys causes the following error: > > > > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 > > p

Re: [PATCH] drm/bridge/synopsys: dw-hdmi: Fix memleak in __dw_hdmi_remove

2018-03-05 Thread Russell King - ARM Linux
On Mon, Mar 05, 2018 at 03:45:55PM +0800, Jeffy Chen wrote: > The platform_device_register_full() will allocate dma_mask for > hdmi->audio, so we should free before platform_device_unregister(). > > Reported by kmemleak: > unreferenced object 0xffc0ef70ff00 (size 128): > comm "kworker/4:1",

[PATCH 13/13] swiotlb: remove swiotlb_{alloc,free}_coherent

2018-03-05 Thread Christoph Hellwig
Unused now that everyone uses swiotlb_{alloc,free}. Signed-off-by: Christoph Hellwig --- include/linux/swiotlb.h | 8 lib/swiotlb.c | 38 -- 2 files changed, 46 deletions(-) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h in

[PATCH 10/13] set_memory.h: provide set_memory_{en,de}crypted stubs

2018-03-05 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/linux/set_memory.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/set_memory.h b/include/linux/set_memory.h index e5140648f638..da5178216da5 100644 --- a/include/linux/set_memory.h +++ b/include/linux/set_memory.h @@ -1

use generic dma-direct and swiotlb code for x86

2018-03-05 Thread Christoph Hellwig
Hi all, this series switches the x86 code the the dma-direct implementation for direct (non-iommu) dma and the generic swiotlb ops. This includes getting rid of the special ops for the AMD memory encryption case and the STA2x11 SOC. The generic implementations are based on the x86 code, so they

[PATCH 11/13] dma-direct: handle the memory encryption bit in common code

2018-03-05 Thread Christoph Hellwig
Give the basic phys_to_dma and dma_to_phys helpers a __-prefix and add the memory encryption mask to the non-prefixed versions. Use the __-prefixed versions directly instead of clearing the mask again in various places. With that in place the generic dma-direct routines can be used to allocate no

Re: [PATCH v7 10/42] clk: davinci: New driver for davinci PSC clocks

2018-03-05 Thread David Lechner
On 03/05/2018 10:23 AM, David Lechner wrote: On 03/05/2018 07:02 AM, Bartosz Golaszewski wrote: 2018-03-01 17:44 GMT+01:00 David Lechner : On 03/01/2018 02:36 AM, Bartosz Golaszewski wrote: 2018-02-28 22:40 GMT+01:00 David Lechner : On 02/28/2018 06:38 AM, Bartosz Golaszewski wrote: I t

[PATCH 08/13] iommu/intel-iommu: cleanup intel_{alloc,free}_coherent

2018-03-05 Thread Christoph Hellwig
Use the dma_direct_* helpers and cleanup the code flow. Signed-off-by: Christoph Hellwig --- drivers/iommu/Kconfig | 1 + drivers/iommu/intel-iommu.c | 62 - 2 files changed, 17 insertions(+), 46 deletions(-) diff --git a/drivers/iommu/Kconfig

[PATCH 09/13] x86: remove dma_alloc_coherent_gfp_flags

2018-03-05 Thread Christoph Hellwig
All dma_ops implementations used on x86 now take care of setting their own required GFP_ masks for the allocation. And given that the common code now clears harmful flags itself that means we can stop the flags in all the iommu implementations as well. Signed-off-by: Christoph Hellwig --- arch/

[PATCH 12/13] swiotlb: remove swiotlb_set_mem_attributes

2018-03-05 Thread Christoph Hellwig
Now that set_memory_decrypted is always available we can just call it directly. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/mem_encrypt.h | 2 -- arch/x86/mm/mem_encrypt.c | 9 - lib/swiotlb.c | 12 ++-- 3 files changed, 6 insertions(

[PATCH 04/13] x86: use generic swiotlb_ops

2018-03-05 Thread Christoph Hellwig
The generic swiotlb dma ops were based on the x86 ones and provide equivalent functionality, so use them. Also fix the sta2x11 case. For that SOC the dma map ops need an additional physical to dma address translations. For swiotlb buffers that is done throught the phys_to_dma helper, but the sta

[PATCH 07/13] iommu/amd_iommu: use dma_direct_{alloc,free}

2018-03-05 Thread Christoph Hellwig
This cleans up the code a lot by removing duplicate logic. Signed-off-by: Christoph Hellwig --- drivers/iommu/Kconfig | 1 + drivers/iommu/amd_iommu.c | 68 +++ 2 files changed, 22 insertions(+), 47 deletions(-) diff --git a/drivers/iommu/Kconfig

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > Dynamic debug can be instructed to add the function name to the debug > output using the +f switch, so there is no need for the nfit module to > do it again. If a user decides to add the +f switch for nfit's dynamic > debug this

[PATCH 02/13] x86: remove dma_alloc_coherent_mask

2018-03-05 Thread Christoph Hellwig
These days all devices (including the ISA fallback device) have a coherent DMA mask set, so remove the workaround. Signed-off-by: Christoph Hellwig --- arch/x86/include/asm/dma-mapping.h | 18 ++ arch/x86/kernel/pci-dma.c | 10 -- arch/x86/mm/mem_encrypt.c

[PATCH 05/13] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA

2018-03-05 Thread Christoph Hellwig
We want to phase out looking at the magic GFP_DMA flag in the dma mapping routines, so switch the gart driver to use the coherent_dma_mask instead, which is used to select the GFP_DMA flag in the caller. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/amd_gart_64.c | 2 +- 1 file changed, 1

[PATCH 01/13] x86: remove X86_PPRO_FENCE

2018-03-05 Thread Christoph Hellwig
There were only a few Pentium Pro multiprocessors systems where this errata applied. They are more than 20 years old now, and we've slowly dropped places where put the workarounds in and discouraged anyone from enabling the workaround. Get rid of it for good. Signed-off-by: Christoph Hellwig ---

[PATCH 03/13] x86: use dma-direct

2018-03-05 Thread Christoph Hellwig
The generic dma-direct implementation is now functionally equivalent to the x86 nommu dma_map implementation, so switch over to using it. Note that the various iommu drivers are switched from x86_dma_supported to dma_direct_supported to provide identical functionality, although the checks looks fa

Re: [PATCH v5 4/4] arm64: dts: sdm845: Add serial console support

2018-03-05 Thread Karthik Ramasubramanian
On 3/5/2018 3:43 AM, Rajendra Nayak wrote: On 03/05/2018 01:29 AM, Bjorn Andersson wrote: On Wed 21 Feb 22:12 PST 2018, Rajendra Nayak wrote: diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi [..] + qup_uart2: serial@a84000 { +

[PATCH 06/13] x86/amd_gart: use dma_direct_{alloc,free}

2018-03-05 Thread Christoph Hellwig
This gains support for CMA allocations for the force_iommu case, and cleans up the code a bit. Signed-off-by: Christoph Hellwig --- arch/x86/kernel/amd_gart_64.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/arch/x86/kernel/amd_gart_64

Re: [PATCH v7] tpm: cmd_ready command can be issued only after granting locality

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 01:34:49PM +0200, Tomas Winkler wrote: > The correct sequence is to first request locality and only after > that perform cmd_ready handshake, otherwise the hardware will drop > the subsequent message as from the device point of view the cmd_ready > handshake wasn't performed

Re: [PATCH 3/3] net: core: dst: Add kernel-doc for 'net' parameter

2018-03-05 Thread David Miller
From: Jonathan Neuschäfer Date: Sun, 4 Mar 2018 03:29:53 +0100 > This fixes the following kernel-doc warning: > > ./include/net/dst.h:366: warning: Function parameter or member 'net' not > described in 'skb_tunnel_rx' > > Fixes: ea23192e8e57 ("tunnels: harmonize cleanup done on skb on rx path

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Dan Williams
On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler wrote: > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> Dynamic debug can be instructed to add the function name to the debug >> output using the +f switch, so there is no need for the nfit module to >> do it again. If a user dec

Re: [PATCH 2/3] net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency

2018-03-05 Thread David Miller
From: Jonathan Neuschäfer Date: Sun, 4 Mar 2018 03:29:52 +0100 > The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for > dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename > the parameter to increase consistency. > > This fixes the following kernel-doc w

Re: [PATCH 1/3] net: core: dst_cache: Fix a typo in a comment

2018-03-05 Thread David Miller
From: Jonathan Neuschäfer Date: Sun, 4 Mar 2018 03:29:51 +0100 > Signed-off-by: Jonathan Neuschäfer Applied to net-next.

Re: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

2018-03-05 Thread Andi Kleen
Agustin Vega-Frias writes: > > An option to keep backward compatibility and consistency would be > to wrap the pattern/string passed in *'s, that way we can just use > fnmatch and have all the examples Jiri brought up work the same. > With that in place we can actually also drop the explicit ignor

Linux 4.16: Reported regressions as of Monday, 2018-03-05 (Was: Linux 4.16-rc4)

2018-03-05 Thread Thorsten Leemhuis
On 05.03.2018 00:15, Linus Torvalds wrote: > Hmm. A reasonably calm week - the biggest change is to the 'kvm-stat' > tool, not any actual kernel files. Hi! Find below my third regression report for Linux 4.16. It lists 7 regressions I'm currently aware of. 3 were fixed since last weeks report. To

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > enum tpm_duration { > > TPM_DURATION_DEFAULT = 2000, > > TPM_DURATION_LONG = 30, > > }; > > > How is this aligned with the spec PTP spec? For TPM 2.0 that spec only partially defines durations for CCs and thus our loo

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Ross Zwisler
On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler > wrote: > > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: > >> Dynamic debug can be instructed to add the function name to the debug > >> output using the +f switch,

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 12:56:33PM +0200, Jarkko Sakkinen wrote: > On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > > > > On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: > > > On Wed, Feb 28, 2018 at 02:18:27PM -0500, Nayna Jain wrote: > > > > In tpm_transmit, after send(), the co

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

2018-03-05 Thread Sinan Kaya
On 3/5/2018 12:10 PM, Logan Gunthorpe wrote: > > > On 05/03/18 09:00 AM, Keith Busch wrote: >> On Mon, Mar 05, 2018 at 12:33:29PM +1100, Oliver wrote: >>> On Thu, Mar 1, 2018 at 10:40 AM, Logan Gunthorpe >>> wrote: @@ -429,10 +429,7 @@ static void __nvme_submit_cmd(struct nvme_queue

[PATCH v3] drm/mali-dp: Fix malidp_atomic_commit_hw_done() for event sending.

2018-03-05 Thread Liviu Dudau
Mali DP hardware has a 'go' bit (config_valid) for making the new scene parameters active at the next page flip. The problem with the current code is that the driver first sets this bit and then proceeds to wait for confirmation from the hardware that the configuration has been updated before armin

Re: [PATCH] arm64: KVM: Use SMCCC_ARCH_WORKAROUND_1 for Falkor BP hardening

2018-03-05 Thread Shanker Donthineni
Hi Will, On 03/05/2018 11:15 AM, Will Deacon wrote: > On Mon, Mar 05, 2018 at 10:57:58AM -0600, Shanker Donthineni wrote: >> Hi Will, >> >> On 03/05/2018 09:56 AM, Will Deacon wrote: >>> Hi Shanker, >>> >>> On Fri, Mar 02, 2018 at 03:50:18PM -0600, Shanker Donthineni wrote: The function SMCCC

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Winkler, Tomas
> > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > enum tpm_duration { > > > TPM_DURATION_DEFAULT = 2000, > > > TPM_DURATION_LONG = 30, > > > }; > > > > > How is this aligned with the spec PTP spec? > > For TPM 2.0 that spec only partially defines durations for CCs

Re: [PATCH v7] tpm: cmd_ready command can be issued only after granting locality

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 07:51:28PM +0200, Jarkko Sakkinen wrote: > On Mon, Mar 05, 2018 at 01:34:49PM +0200, Tomas Winkler wrote: > > The correct sequence is to first request locality and only after > > that perform cmd_ready handshake, otherwise the hardware will drop > > the subsequent message as

RE: [PATCH v7] tpm: cmd_ready command can be issued only after granting locality

2018-03-05 Thread Winkler, Tomas
> > On Mon, Mar 05, 2018 at 07:51:28PM +0200, Jarkko Sakkinen wrote: > > On Mon, Mar 05, 2018 at 01:34:49PM +0200, Tomas Winkler wrote: > > > The correct sequence is to first request locality and only after > > > that perform cmd_ready handshake, otherwise the hardware will drop > > > the subsequ

Re: [PATCH 2/2 v3] tpm: separate cmd_ready/go_idle from runtime_pm

2018-03-05 Thread Jarkko Sakkinen
On Tue, Feb 20, 2018 at 04:13:30PM +0200, Jarkko Sakkinen wrote: > On Mon, 2018-02-19 at 13:52 +0200, Jarkko Sakkinen wrote: > > On Wed, Feb 14, 2018 at 03:43:19PM +0200, Tomas Winkler wrote: > > > We cannot use go_idle cmd_ready commands via runtime_pm handles > > > as with the introduction of loc

Re: [PATCH v2 07/10] nvme-pci: Use PCI p2pmem subsystem to manage the CMB

2018-03-05 Thread Logan Gunthorpe
On 05/03/18 11:02 AM, Sinan Kaya wrote: writel has a barrier inside on ARM64. https://elixir.bootlin.com/linux/latest/source/arch/arm64/include/asm/io.h#L143 Yes, and no barrier inside memcpy_toio as it uses __raw_writes. This should be sufficient as we are only accessing addresses that loo

Re: [PATCH 1/2] tpm: tpm-interface: fix tpm_transmit/_cmd kdoc

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 02:48:25PM +0200, Tomas Winkler wrote: > Fix tmp_ -> tpm_ typo and add reference to 'space' parameter > in kdoc for tpm_transmit and tpm_transmit_cmd functions. > > Signed-off-by: Tomas Winkler > --- > drivers/char/tpm/tpm-interface.c | 6 -- > 1 file changed, 4 inser

Re: [PATCH 2/2] tpm: fix buffer type in tpm_transimt/_cmd

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 02:48:26PM +0200, Tomas Winkler wrote: > 1. The buffer cannot be const as it is used both for send and receive. > 2. Drop useless casting to u8 *, as this is already a > type of 'buf' parameter, it has just masked the 'const' issue. > > Signed-off-by: Tomas Winkler > --- >

Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

2018-03-05 Thread Dan Williams
On Mon, Mar 5, 2018 at 10:01 AM, Ross Zwisler wrote: > On Mon, Mar 05, 2018 at 09:53:47AM -0800, Dan Williams wrote: >> On Mon, Mar 5, 2018 at 9:49 AM, Ross Zwisler >> wrote: >> > On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote: >> >> Dynamic debug can be instructed to add the

Re: [PATCH 2/2] tpm: fix buffer type in tpm_transimt/_cmd

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 02:48:26PM +0200, Tomas Winkler wrote: > 1. The buffer cannot be const as it is used both for send and receive. > 2. Drop useless casting to u8 *, as this is already a > type of 'buf' parameter, it has just masked the 'const' issue. > > Signed-off-by: Tomas Winkler > --- >

Re: WARNING: kobject bug in netdev_queue_update_kobjects

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 09:59 -0800, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 661e50bc853209e41a5c14a290ca4decc43cbfd1 (Sun Mar 4 22:54:11 2018 > +) > Linux 4.16-rc4 > > So far this crash happened 2 times on upstream. > C reproducer is attached. > syzkaller

[RFC PATCH 0/2] riscv/spinlock,atomic: Miscellaneous fixes

2018-03-05 Thread Andrea Parri
Hi, This RFC is a follow-up on the discussion in [1], which led to the discovery of a few issues in the current implementations of RISC-V locking and atomic operations. In summary, this series proposes the following modifications: 1. Use lightweigth fences for acquire/release (locking, atomics

Re: [PATCH 07/34] x86/entry/32: Restore segments before int registers

2018-03-05 Thread Linus Torvalds
On Mon, Mar 5, 2018 at 5:12 AM, Joerg Roedel wrote: > >> The things is, we *know* that we will restore two segment registers with the >> user cr3 already loaded: CS and SS get restored with the final iret. > > Yeah, I know, but the iret-exception path is fine because it will > deliver a SIGILL and

[RFC PATCH 1/2] riscv/spinlock: Strengthen implementations with fences

2018-03-05 Thread Andrea Parri
Current implementations map locking operations using .rl and .aq annotations. However, this mapping is unsound w.r.t. the kernel memory consistency model (LKMM) [1]: Referring to the "unlock-lock-read-ordering" test reported below, Daniel wrote: "I think an RCpc interpretation of .aq and .rl w

[RFC PATCH 2/2] riscv/atomic: Strengthen implementations with fences

2018-03-05 Thread Andrea Parri
Atomics present the same issue with locking: release and acquire variants need to be strengthened to meet the constraints defined by the Linux-kernel memory consistency model [1]. Atomics present a further issue: implementations of atomics such as atomic_cmpxchg() and atomic_add_unless() rely on L

Re: [PATCH 11/34] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-03-05 Thread Joerg Roedel
Hi Brian, thanks for your review and helpful input. On Mon, Mar 05, 2018 at 11:41:01AM -0500, Brian Gerst wrote: > On Mon, Mar 5, 2018 at 5:25 AM, Joerg Roedel wrote: > > +.Lentry_from_kernel_\@: > > + > > + /* > > +* This handles the case when we enter the kernel from > > +

Re: [PATCH v2 6/8] MIPS: jz4780: dts: Fix watchdog node

2018-03-05 Thread James Hogan
On Sat, Dec 30, 2017 at 02:51:06PM +0100, Paul Cercueil wrote: > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi > b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index 9b5794667aee..a52f59bf58c7 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi >

Re: [PATCH] lightnvm: pblk: refactor init/exit sequences

2018-03-05 Thread Matias Bjørling
On 03/05/2018 03:18 PM, Javier González wrote: On 5 Mar 2018, at 15.16, Matias Bjørling wrote: On 03/05/2018 02:45 PM, Javier González wrote: On 5 Mar 2018, at 14.38, Matias Bjørling wrote: On 03/01/2018 08:29 PM, Javier González wrote: On 1 Mar 2018, at 19.49, Matias Bjørling wrote: On 0

Re: [PATCH v2 7/8] MIPS: qi_lb60: Enable the jz4740-wdt driver

2018-03-05 Thread James Hogan
On Sat, Dec 30, 2017 at 02:51:07PM +0100, Paul Cercueil wrote: > The watchdog is an useful piece of hardware, so there's no reason not to > enable it. Presumably this is important for restart to work after the change in the next patch? Probably worth mentioning that too if thats the case. > > Th

Re: [PATCH] regmap: debugfs: Do not print warning when no device is associated

2018-03-05 Thread Fabio Estevam
Hi Mark, On Mon, Mar 5, 2018 at 1:17 PM, Mark Brown wrote: > This then means that we will just randomly not create a debugfs for > anything except the first device that tries to do so with no device > which doesn't seem right. We should try harder to create a name here, > for example we could t

[PATCH v4 0/2] Directed kmem charging

2018-03-05 Thread Shakeel Butt
This patchset introduces memcg variant memory allocation functions. The caller can explicitly pass the memcg to charge for kmem allocations. Currently the kernel, for __GFP_ACCOUNT memory allocation requests, extract the memcg of the current task to charge for the kmem allocation. This patch series

[PATCH v4 1/2] mm: memcg: remote memcg charging for kmem allocations

2018-03-05 Thread Shakeel Butt
Introducing the memcg variant for kmalloc[_node] and kmem_cache_alloc[_node]. For kmem_cache_alloc, the kernel switches the root kmem cache with the memcg specific kmem cache for __GFP_ACCOUNT allocations to charge those allocations to the memcg. However, the memcg to charge is extracted from the c

[PATCH v4 2/2] fs: fsnotify: account fsnotify metadata to kmemcg

2018-03-05 Thread Shakeel Butt
A lot of memory can be consumed by the events generated for the huge or unlimited queues if there is either no or slow listener. This can cause system level memory pressure or OOMs. So, it's better to account the fsnotify kmem caches to the memcg of the listener. There are seven fsnotify kmem cach

Re: [RFC, PATCH 00/22] Partial MKTME enabling

2018-03-05 Thread Christoph Hellwig
On Mon, Mar 05, 2018 at 07:25:48PM +0300, Kirill A. Shutemov wrote: > Hi everybody, > > Here's updated version of my patchset that brings support of MKTME. It would really help if you'd explain what "MKTME" is..

Re: [PATCH v2 8/8] MIPS: jz4740: Drop old platform reset code

2018-03-05 Thread James Hogan
On Sat, Dec 30, 2017 at 02:51:08PM +0100, Paul Cercueil wrote: > This work is now performed by the watchdog driver directly. > > Signed-off-by: Paul Cercueil Acked-by: James Hogan Cheers James signature.asc Description: Digital signature

Re: [linux-sunxi] [PATCH v3 15/16] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-03-05 Thread Jernej Škrabec
Hi! Dne ponedeljek, 05. marec 2018 ob 16:27:00 CET je Joonas Kylmälä napisal(a): > Jernej Skrabec: > > +&hdmi_out { > > + hdmi_out_con: endpoint { > > + remote-endpoint = <&hdmi_con_in>; > > + }; > > +}; > > This node is added to all the DTS files you enabled HDMI on. Is it > someth

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Ivaylo Dimitrov
Hi, On 5.03.2018 19:38, Bin Liu wrote: On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: * Merlijn Wajer [180227 22:29]: Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external abort on non-linefetch (

Re: [PATCH 07/34] x86/entry/32: Restore segments before int registers

2018-03-05 Thread Joerg Roedel
On Mon, Mar 05, 2018 at 10:23:59AM -0800, Linus Torvalds wrote: > On Mon, Mar 5, 2018 at 5:12 AM, Joerg Roedel wrote: > > > >> The things is, we *know* that we will restore two segment registers with > >> the > >> user cr3 already loaded: CS and SS get restored with the final iret. > > > > Yeah,

Re: [PATCH 5/6] dma-mapping: support fsl-mc bus

2018-03-05 Thread Christoph Hellwig
On Mon, Mar 05, 2018 at 03:48:32PM +, Robin Murphy wrote: > Unfortunately for us, fsl-mc is conceptually rather like PCI in that it's > software-discoverable and the only thing described in DT is the bus "host", > thus we need the same sort of thing as for PCI to map from the child > devices

Re: [PATCH 1/3] nfit_test: improve structure offset handling

2018-03-05 Thread Ross Zwisler
On Tue, Feb 27, 2018 at 10:29:50AM -0700, Ross Zwisler wrote: > In nfit_test0_setup() and nfit_test1_setup() we keep an 'offset' value > which we use to calculate where in our 'nfit_buf' we will place our next > structure. The handling of 'offset' and the calculation of the placement > of the next

Re: [PATCH v4 1/2] drivers: qcom: add command DB driver

2018-03-05 Thread Stephen Boyd
Quoting Lina Iyer (2018-02-26 09:58:01) > diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c > new file mode 100644 > index ..0792a2a98fc9 > --- /dev/null > +++ b/drivers/soc/qcom/cmd-db.c > @@ -0,0 +1,319 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (c)

Re: [PATCH 5/6] dma-mapping: support fsl-mc bus

2018-03-05 Thread Robin Murphy
On 05/03/18 18:39, Christoph Hellwig wrote: On Mon, Mar 05, 2018 at 03:48:32PM +, Robin Murphy wrote: Unfortunately for us, fsl-mc is conceptually rather like PCI in that it's software-discoverable and the only thing described in DT is the bus "host", thus we need the same sort of thing as f

[PATCH v2] regmap: debugfs: Disambiguate dummy debugfs file name

2018-03-05 Thread Fabio Estevam
From: Fabio Estevam Since commit 9b947a13e7f6 ("regmap: use debugfs even when no device") allows the usage of regmap debugfs even when there is no device associated, which causes several warnings like this: (NULL device *): Failed to create debugfs directory This happens when the debugfs file n

Re: [PATCH] crypto: ccp: Use memdup_user() rather than duplicating its implementation

2018-03-05 Thread Brijesh Singh
On 3/5/18 7:10 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 5 Mar 2018 13:50:13 +0100 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfrin

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-05 Thread Darrick J. Wong
On Mon, Mar 05, 2018 at 11:19:46AM +0100, Vratislav Bendel wrote: > (In response to Luis' comment:) > > Can you add a respective Fixes: tag? > > It was apparently present since LRU was added to xfs buffer cache via: > commit 430cbeb86fdcbbdabea7d4aa65307de8de425350 > [xfs: add a lru to the XFS buf

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-03-05 Thread Bin Liu
On Mon, Mar 05, 2018 at 08:35:10PM +0200, Ivaylo Dimitrov wrote: > Hi, > > On 5.03.2018 19:38, Bin Liu wrote: > >On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > >>* Merlijn Wajer [180227 22:29]: > >>>Without pm_runtime_{get,put}_sync calls in place, reading > >>>vbus status via

Re: "x86/boot/compressed/64: Prepare trampoline memory" breaks boot on Zotac CI-321

2018-03-05 Thread Heiner Kallweit
Am 05.03.2018 um 09:19 schrieb Kirill A. Shutemov: > On Sat, Mar 03, 2018 at 12:46:28PM +0100, Heiner Kallweit wrote: >> Am 03.03.2018 um 11:02 schrieb Ingo Molnar: >>> >>> * Heiner Kallweit wrote: >>> Am 03.03.2018 um 00:50 schrieb Dexuan-Linux Cui: > On Fri, Mar 2, 2018 at 12:57 PM, Hei

Re: [RFC, PATCH 19/22] x86/mm: Implement free_encrypt_page()

2018-03-05 Thread Dave Hansen
On 03/05/2018 08:26 AM, Kirill A. Shutemov wrote: > +void free_encrypt_page(struct page *page, int keyid, unsigned int order) > +{ > + int i; > + void *v; > + > + for (i = 0; i < (1 << order); i++) { > + v = kmap_atomic_keyid(page, keyid + i); > + /* See comment

Re: [PATCH 1/7] genalloc: track beginning of allocations

2018-03-05 Thread J Freyensee
. . On 2/28/18 12:06 PM, Igor Stoppa wrote: + +/** + * gen_pool_dma_alloc() - allocate special memory from the pool for DMA usage + * @pool: pool to allocate from + * @size: number of bytes to allocate from the pool + * @dma: dma-view physical address return value. Use NULL if unneeded. + * +

Re: [RFC, PATCH 18/22] x86/mm: Handle allocation of encrypted pages

2018-03-05 Thread Dave Hansen
On 03/05/2018 08:26 AM, Kirill A. Shutemov wrote: > -#define __alloc_zeroed_user_highpage(movableflags, vma, vaddr) \ > - alloc_page_vma(GFP_HIGHUSER | __GFP_ZERO | movableflags, vma, vaddr) > #define __HAVE_ARCH_ALLOC_ZEROED_USER_HIGHPAGE > +#define __alloc_zeroed_user_highpage(movableflags,

[PATCH] thermal: of: Allow selection of thermal governor in DT

2018-03-05 Thread Amit Kucheria
From: Ram Chandrasekar There is currently no way for the governor to be selected for each thermal zone in devicetree. This results in the default governor being used for all thermal zones even though no such restriction exists in the core code. Add support for specifying the thermal governor to

Re: [RFC PATCH 2/2] riscv/atomic: Strengthen implementations with fences

2018-03-05 Thread Andrea Parri
On Mon, Mar 05, 2018 at 07:24:36PM +0100, Andrea Parri wrote: > Atomics present the same issue with locking: release and acquire > variants need to be strengthened to meet the constraints defined > by the Linux-kernel memory consistency model [1]. > > Atomics present a further issue: implementatio

Re: [PATCH] Support the nonstring variable attribute (gcc >= 8)

2018-03-05 Thread Martin Sebor
On 03/02/2018 10:36 AM, Miguel Ojeda wrote: On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote: On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda wrote: On Mon, Feb 19, 2018 at 12:20 AM, David Rientjes wrote: On Sat, 17 Feb 2018, Miguel Ojeda wrote: From the GCC manual: The nonstring varia

Re: [RFC, PATCH 00/22] Partial MKTME enabling

2018-03-05 Thread Matthew Wilcox
On Mon, Mar 05, 2018 at 10:30:50AM -0800, Christoph Hellwig wrote: > On Mon, Mar 05, 2018 at 07:25:48PM +0300, Kirill A. Shutemov wrote: > > Hi everybody, > > > > Here's updated version of my patchset that brings support of MKTME. > > It would really help if you'd explain what "MKTME" is.. You n

Re: [RFC, PATCH 19/22] x86/mm: Implement free_encrypt_page()

2018-03-05 Thread Dave Hansen
On 03/05/2018 08:26 AM, Kirill A. Shutemov wrote: > +void free_encrypt_page(struct page *page, int keyid, unsigned int order) > +{ > + int i; > + void *v; > + > + for (i = 0; i < (1 << order); i++) { > + v = kmap_atomic_keyid(page, keyid + i); > + /* See comment

Re: [RFC, PATCH 18/22] x86/mm: Handle allocation of encrypted pages

2018-03-05 Thread Dave Hansen
On 03/05/2018 08:26 AM, Kirill A. Shutemov wrote: > kmap_atomic_keyid() would map the page with the specified KeyID. > For now it's dummy implementation that would be replaced later. I think you need to explain the tradeoffs here. We could just change the linear map around, but you don't. Why?

Re: Regression in IPMI on 4.15.6

2018-03-05 Thread Laura Abbott
On 03/02/2018 05:46 AM, Corey Minyard wrote: On 02/28/2018 01:07 PM, Corey Minyard wrote: On 02/28/2018 08:17 AM, Corey Minyard wrote: On 02/28/2018 07:53 AM, Corey Minyard wrote: On 02/27/2018 05:55 PM, Laura Abbott wrote: Hi, Fedora got a bug report of a crash in IPMI on 4.15.6 https://bug

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-05 Thread Mimi Zohar
On Mon, 2018-03-05 at 20:01 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 05, 2018 at 12:56:33PM +0200, Jarkko Sakkinen wrote: > > On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > > > > > > > On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: > > > > On Wed, Feb 28, 2018 at 02:18:27PM

[PATCH v11 1/7] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs

2018-03-05 Thread Logan Gunthorpe
Subsequent patches in this series makes use of the readq and writeq defines in iomap.h. However, as is, they get missed on the powerpc platform seeing the include comes before the define. This patch moves the include down to fix this. Signed-off-by: Logan Gunthorpe Acked-by: Michael Ellerman Rev

[PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

2018-03-05 Thread Logan Gunthorpe
Clean up the ifdefs which conditionally defined the io{read|write}64 functions in favour of the new common io-64-nonatomic-lo-hi header. Signed-off-by: Logan Gunthorpe Cc: Jon Mason --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 30 +- 1 file changed, 1 insertion(+), 2

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

2018-03-05 Thread Eric Dumazet
On Mon, 2018-03-05 at 12:46 +0100, Oliver Neukum wrote: > On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote: > > Hi Oliver, > > > > On 2018-02-27 17:07, Oliver Neukum wrote: > > > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > > > > On Tue, 2018-02-27 at 07:09 -0800, Eric

Re: [RFC, PATCH 16/22] x86/mm: Preserve KeyID on pte_modify() and pgprot_modify()

2018-03-05 Thread Dave Hansen
On 03/05/2018 08:26 AM, Kirill A. Shutemov wrote: > + * It includes full range of PFN bits regardless if they were claimed for > KeyID > + * or not: we want to preserve KeyID on pte_modify() and pgprot_modify(). > */ > -#define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT |

Re: [RFC V2 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

2018-03-05 Thread Jiri Olsa
On Mon, Mar 05, 2018 at 10:08:18AM -0500, Agustin Vega-Frias wrote: > On 2018-03-04 13:10, Jiri Olsa wrote: > > On Sun, Mar 04, 2018 at 09:12:45AM -0800, Andi Kleen wrote: > > > > > +#include > > > > > #include > > > > > #include > > > > > #include > > > > > @@ -241,7 +242,7 @@ PE_NAME opt_e

<    1   2   3   4   5   6   7   8   9   10   >