Re: [PATCH] vhost: Fix vhost_copy_to_user()

2018-04-11 Thread Auger Eric
Hi Jason, On 11/04/18 15:44, Jason Wang wrote: > > > On 2018年04月11日 21:30, Eric Auger wrote: >> vhost_copy_to_user is used to copy vring used elements to userspace. >> We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. >> >> Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache")

[RFC tip/locking/lockdep v6 00/20] lockdep: Support deadlock detection for recursive read locks

2018-04-11 Thread Boqun Feng
Hi Ingo and Peter, This is V6 for recursive read lock support in lockdep. I moved the explanation about reasoning to patch #1, which will help understand this whole series. This patchset is based on v4.16. Other changes since V5: * Rewrite the the explanation of the reasoning, focus on the

[RFC tip/locking/lockdep v6 03/20] lockdep: Make __bfs() visit every dependency until a match

2018-04-11 Thread Boqun Feng
Currently, __bfs() will do a breadth-first search in the dependency graph and visit each lock class in the graph exactly once, so for example, in the following graph: A -> B |^ || +--> C a __bfs() call starts at A, will visit

[RFC tip/locking/lockdep v6 01/20] lockdep/Documention: Recursive read lock detection reasoning

2018-04-11 Thread Boqun Feng
This patch add the documentation piece for the reasoning of deadlock detection related to recursive read lock. The following sections are added: * Explain what is a recursive read lock, and what deadlock cases they could introduce. * Introduce the notations for different types

[RFC tip/locking/lockdep v6 08/20] lockdep: Make __bfs(.match) return bool

2018-04-11 Thread Boqun Feng
The "match" parameter of __bfs() is used for checking whether we hit a match in the search, therefore it should return a boolean value rather than an integer for better readability. This patch then changes the return type of the function parameter and the match functions to bool. Suggested-by: Pe

[RFC tip/locking/lockdep v6 15/20] lockdep/selftest: Unleash irq_read_recursion2 and add more

2018-04-11 Thread Boqun Feng
Now since we can handle recursive read related irq inversion deadlocks correctly, uncomment the irq_read_recursion2 and add more testcases. Signed-off-by: Boqun Feng --- lib/locking-selftest.c | 59 -- 1 file changed, 47 insertions(+), 12 deletions

[RFC tip/locking/lockdep v6 11/20] lockdep: Fix recursive read lock related safe->unsafe detection

2018-04-11 Thread Boqun Feng
irq-safe -> irq-unsafe lock dependency is illegal, because it could introduce the "irq inversion" problem, that is when a irq-unsafe lock is held, some one else interrupts and tries to acquire irq-safe lock. And that case adds a temporary from irq-unsafe to irq-safe, as a result, deadlock. There a

[RFC tip/locking/lockdep v6 17/20] Revert "locking/lockdep/selftests: Fix mixed read-write ABBA tests"

2018-04-11 Thread Boqun Feng
This reverts commit d82fed75294229abc9d757f08a4817febae6c4f4. Since we now could handle mixed read-write deadlock detection well, the self tests could be detected as expected, no need to use this work-around. Signed-off-by: Boqun Feng --- lib/locking-selftest.c | 8 1 file changed, 8 d

[RFC tip/locking/lockdep v6 10/20] lockdep: Adjust check_redundant() for recursive read change

2018-04-11 Thread Boqun Feng
check_redundant() will report redundancy if it finds a path could replace the about-to-add dependency in the BFS search. With recursive read lock changes, we certainly need to change the match function for the check_redundant(), because the path needs to match not only the lock class but also the d

[RFC tip/locking/lockdep v6 18/20] MAINTAINERS: Add myself as a LOCKING PRIMITIVES reviewer

2018-04-11 Thread Boqun Feng
Recursive read lock detection work touches most core part of lockdep, so add myself as a dedicated reviewer to help people find me if any of my code introduces problems or misunderstandings, also if they need my help on parsing logs related to recursive read locks. Besides, I'd like to provide any

[RFC tip/locking/lockdep v6 14/20] lockdep: Take read/write status in consideration when generate chainkey

2018-04-11 Thread Boqun Feng
Currently, the chainkey of a lock chain is a hash sum of the class_idx of all the held locks, the read/write status are not taken in to consideration while generating the chainkey. This could result into a problem, if we have: P1() { read_lock(B); lo

[RFC tip/locking/lockdep v6 16/20] lockdep/selftest: Add more recursive read related test cases

2018-04-11 Thread Boqun Feng
Add those four test cases: 1. X --(NR)--> Y --(NR)--> Z --(NR)--> X is deadlock. 2. X --(NN)--> Y --(RR)--> Z --(NR)--> X is deadlock. 3. X --(NN)--> Y --(RR)--> Z --(RN)--> X is not deadlock. 4. X --(NR)--> Y --(RR)--> Z --(NN)--> X is not deadlock. Those self testcases ar

[RFC tip/locking/lockdep v6 13/20] lockdep/selftest: Add a R-L/L-W test case specific to chain cache behavior

2018-04-11 Thread Boqun Feng
As our chain cache doesn't differ read/write locks, so even we can detect a read-lock/lock-write deadlock in check_noncircular(), we can still be fooled if a read-lock/lock-read case(which is not a deadlock) comes first. So introduce this test case to test specific to the chain cache behavior on d

[RFC tip/locking/lockdep v6 12/20] lockdep: Add recursive read locks into dependency graph

2018-04-11 Thread Boqun Feng
Since we have all the fundamental to handle recursive read locks, we now add them into the dependency graph. Signed-off-by: Boqun Feng --- kernel/locking/lockdep.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockd

[RFC tip/locking/lockdep v6 09/20] lockdep: Support deadlock detection for recursive read locks in check_noncircular()

2018-04-11 Thread Boqun Feng
Currently, lockdep only has limit support for deadlock detection for recursive read locks. This patch support deadlock detection for recursive read locks. The basic idea is: We are about to add dependency B -> A in to the dependency graph, we use check_noncircular() to find whether we have a stro

[RFC tip/locking/lockdep v6 07/20] lockdep: Extend __bfs() to work with multiple types of dependencies

2018-04-11 Thread Boqun Feng
Now we have four types of dependencies in the dependency graph, and not all the pathes carry real dependencies (the dependencies that may cause a deadlock), for example: Given lock A and B, if we have: CPU1CPU2 = ==

[RFC tip/locking/lockdep v6 06/20] lockdep: Introduce lock_list::dep

2018-04-11 Thread Boqun Feng
To add recursive read locks into the dependency graph, we need to store the types of dependencies for the BFS later. There are four types of dependencies: * Non-recursive -> Non-recursive dependencies: NN e.g. write_lock(prev) held and try to acquire write_lock(next), which c

[RFC tip/locking/lockdep v6 04/20] lockdep: Redefine LOCK_*_STATE* bits

2018-04-11 Thread Boqun Feng
There are three types of lock acquisitions: write, non-recursive read and recursive read, among which write locks and non-recursive read locks have no difference from a viewpoint for deadlock detections, because a write acquisition of the corresponding lock on an independent CPU or task makes a non

[RFC tip/locking/lockdep v6 05/20] lockdep: Reduce the size of lock_list::distance

2018-04-11 Thread Boqun Feng
lock_list::distance is always not greater than MAX_LOCKDEP_DEPTH (which is 48 right now), so a u16 will fit. This patch reduces the size of lock_list::distance to save space, so that we can introduce other fields to help detect recursive read lock deadlocks without increasing the size of lock_list

[RFC tip/locking/lockdep v6 02/20] lockdep: Demagic the return value of BFS

2018-04-11 Thread Boqun Feng
__bfs() could return four magic numbers: 1: search succeeds, but none match. 0: search succeeds, find one match. -1: search fails because of the cq is full. -2: search fails because a invalid node is found. This patch cleans things up by using a enum type for the r

Re: [PATCH] vhost: Fix vhost_copy_to_user()

2018-04-11 Thread Michael S. Tsirkin
On Wed, Apr 11, 2018 at 03:30:38PM +0200, Eric Auger wrote: > vhost_copy_to_user is used to copy vring used elements to userspace. > We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. > > Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache") > Signed-off-by: Eric Auger Acked-by:

Re: [PATCH] PCI: quirk HT1100 & HT2000 and one HT2100 Root Ports for Extended Tags

2018-04-11 Thread Bjorn Helgaas
On Tue, Apr 10, 2018 at 04:18:01PM -0400, Sinan Kaya wrote: > On 4/10/2018 3:50 PM, Bjorn Helgaas wrote: > > On Tue, Apr 10, 2018 at 02:41:44PM -0500, Bjorn Helgaas wrote: > >> On Wed, Apr 04, 2018 at 06:50:09PM -0400, Sinan Kaya wrote: > >>> Per PCIe r3.1, sec 2.2.6.2 and 7.8.4, a Requester may no

[RFC tip/locking/lockdep v6 19/20] rcu: Equip sleepable RCU with lockdep dependency graph checks

2018-04-11 Thread Boqun Feng
Although all flavors of RCU are annotated correctly with lockdep annotations as recursive read locks, the 'check' parameter for their calls to lock_acquire() is unset. Which means RCU read locks are not added into the lockdep dependency graph. This is fine for all flavors except sleepable RCU, beca

[RFC tip/locking/lockdep v6 20/20] lockdep/selftest: Add a test case for SRCU

2018-04-11 Thread Boqun Feng
Since we now could detect deadlock cases for sleepable RCU, a self test case is added. More other complex scenarios may be added later to srcu_tests(). Cc: Paul E. McKenney Signed-off-by: Boqun Feng --- lib/locking-selftest.c | 36 1 file changed, 36 inserti

[PATCH] gpio: zynq: Setup chip->base based on alias ID

2018-04-11 Thread Michal Simek
In past Xilinx gpio-zynq driver was setting up gpio chip->base as 0 which was chagned to autodetection when driver was upstreamed. Older systems, which were using this old version, setup SW stack which expects zynq gpio base as 0 and right now there is no way how to set this up. The patch is addin

Re: [PATCH] Revert mm/vmstat.c: fix vmstat_update() preemption BUG

2018-04-11 Thread Vlastimil Babka
On 04/11/2018 11:57 AM, Sebastian Andrzej Siewior wrote: > This patch reverts commit c7f26ccfb2c3 ("mm/vmstat.c: fix > vmstat_update() preemption BUG"). > Steven saw a "using smp_processor_id() in preemptible" message and > added a preempt_disable() section around it to keep it quiet. This is > not

Re: [PATCH 1/3] mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES

2018-04-11 Thread Roman Gushchin
On Wed, Apr 11, 2018 at 03:16:08PM +0200, Vlastimil Babka wrote: > [+CC linux-api] > > On 03/05/2018 02:37 PM, Roman Gushchin wrote: > > This patch introduces a concept of indirectly reclaimable memory > > and adds the corresponding memory counter and /proc/vmstat item. > > > > Indirectly reclaim

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

2018-04-11 Thread Wenhua Shi
> Note that TCP stack now works with GSO being always on. > 0a6b2a1dc2a2 ("tcp: switch to GSO being always on") I've tested on the latest net-next branch 17dec0a949153d9ac00760ba2f5b78cb583e995f. The problem still exists. My patch won't work. Reverting commit 0a6b2a1dc2a2 won't help.

Re: [PATCH] PCI: quirk HT1100 & HT2000 and one HT2100 Root Ports for Extended Tags

2018-04-11 Thread Sinan Kaya
+GregKH On 4/11/2018 9:51 AM, Bjorn Helgaas wrote: > On Tue, Apr 10, 2018 at 04:18:01PM -0400, Sinan Kaya wrote: >> On 4/10/2018 3:50 PM, Bjorn Helgaas wrote: >>> On Tue, Apr 10, 2018 at 02:41:44PM -0500, Bjorn Helgaas wrote: On Wed, Apr 04, 2018 at 06:50:09PM -0400, Sinan Kaya wrote: > P

BUG: unable to handle kernel paging request in vmx_vcpu_run

2018-04-11 Thread syzbot
Hello, syzbot hit the following crash on upstream commit b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) Merge tag 'ceph-for-4.17-rc1' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=ef99b30646419e80cae3 So far this

WARNING: possible recursive locking detected

2018-04-11 Thread syzbot
Hello, syzbot hit the following crash on upstream commit b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) Merge tag 'ceph-for-4.17-rc1' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=3c43eecd7745a5ce1640 So far this

Re: [PATCH] X86/KVM: Do not allow DISABLE_EXITS_MWAIT when LAPIC ARAT is not available

2018-04-11 Thread Sean Christopherson
On Wed, 2018-04-11 at 11:16 +0200, KarimAllah Ahmed wrote: > If the processor does not have an "Always Running APIC Timer" (aka ARAT), > we should not give guests direct access to MWAIT. The LAPIC timer would > stop ticking in deep C-states, so any host deadlines would not wakeup the > host kernel.

[PATCH v2] clk: imx: Set CLK_SET_RATE_GATE for gate and divider clocks

2018-04-11 Thread Abel Vesa
From: Shawn Guo Add flag CLK_SET_RATE_GATE for i.MX gate and divider clocks on which the client drivers usually make clk_set_rate() call, so that the call will fail when clock is still on instead of standing the risk of running into glitch issue. Rate cannot be changed when the clock is enabled d

Re: WARNING: possible recursive locking detected

2018-04-11 Thread Dmitry Vyukov
On Wed, Apr 11, 2018 at 4:02 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) > Merge tag 'ceph-for-4.17-rc1' of git://github.com/ceph/ceph-client > syzbot dashboard link: > https://syzkalle

Re: [PATCH v2] resource: Fix integer overflow at reallocation

2018-04-11 Thread Ram Pai
On Wed, Apr 11, 2018 at 08:16:33AM +0200, Takashi Iwai wrote: > On Wed, 11 Apr 2018 02:37:44 +0200, > Ram Pai wrote: > > > > On Tue, Apr 10, 2018 at 01:42:39PM -0700, Andrew Morton wrote: > > > On Tue, 10 Apr 2018 06:54:11 +0200 Takashi Iwai wrote: > > > > > > > On Tue, 10 Apr 2018 02:23:26 +020

Re: [PATCH] Revert mm/vmstat.c: fix vmstat_update() preemption BUG

2018-04-11 Thread Tejun Heo
Hello, On Wed, Apr 11, 2018 at 03:56:43PM +0200, Vlastimil Babka wrote: > > vmstat_update() is invoked by a kworker on a specific CPU. This worker > > it bound to this CPU. The name of the worker was "kworker/1:1" so it > > should have been a worker which was bound to CPU1. A worker which can > >

[PATCH] mfd: mc13xxx: Add mc34708 adc support

2018-04-11 Thread Lukasz Majewski
From: Sascha Hauer The mc34708 has an improved adc. The older variants will always convert a fixed order of channels. The mc34708 can do up to eight conversions in arbitrary channel order. Currently this extended feature is not supported. We only support touchscreen conversions now, which will be

Re: [PATCH][next] afs: fix integer overflow when shifting 1 more than 32 places

2018-04-11 Thread David Howells
Colin Ian King wrote: > >> - mask = (1 << nr_slots) - 1; > >> + mask = (1ULL << nr_slots) - 1; > > > > nr_slots cannot be larger than 9, so what I wrote is actually fine and is > > more efficient on a 32-bit machine. > > ok, sorry about the noise. It would be possible to cast the value to u6

Re: [PATCH] PCI: quirk HT1100 & HT2000 and one HT2100 Root Ports for Extended Tags

2018-04-11 Thread Greg Kroah-Hartman
On Wed, Apr 11, 2018 at 10:02:07AM -0400, Sinan Kaya wrote: > +GregKH Why? > On 4/11/2018 9:51 AM, Bjorn Helgaas wrote: > > On Tue, Apr 10, 2018 at 04:18:01PM -0400, Sinan Kaya wrote: > >> On 4/10/2018 3:50 PM, Bjorn Helgaas wrote: > >>> On Tue, Apr 10, 2018 at 02:41:44PM -0500, Bjorn Helgaas wro

Re: [PATCH] PCI: quirk HT1100 & HT2000 and one HT2100 Root Ports for Extended Tags

2018-04-11 Thread Sinan Kaya
On 4/11/2018 10:08 AM, Greg Kroah-Hartman wrote: >>> So I added these stable tags: >>> >>> CC: sta...@vger.kernel.org # v4.11: 62ce94a7a5a5 PCI: Mark Broadcom >>> HT2100 Root Port Extended Tags as broken >>> CC: sta...@vger.kernel.org # v4.11 >>> >>> I'm not sure I'm using the stable

[PATCH 2/2] input: touchscreen mc13xxx: Add mc34708 support

2018-04-11 Thread Lukasz Majewski
From: Sascha Hauer The mc34708 has a different bit to enable pen detection. This adds the driver data and devtype necessary to probe the device and to distinguish between the mc13783 and the mc34708. Signed-off-by: Sascha Hauer Signed-off-by: Lukasz Majewski --- Changes from the original patc

[PATCH 1/2] input: touchscreen mc13xxx: Make platform data optional

2018-04-11 Thread Lukasz Majewski
From: Sascha Hauer The platform data once was optional, make it optional again. This is a first step towards device tree support for the mc13xxx touchscreen driver. Signed-off-by: Sascha Hauer Signed-off-by: Lukasz Majewski --- Changes from the original patch: - Commit message typo fixes ---

Re: [PATCH v5 1/1] security: Add mechanism to safely (un)load LSMs after boot time

2018-04-11 Thread Stephen Smalley
On 04/10/2018 05:24 PM, Sargun Dhillon wrote: > On Sun, Apr 8, 2018 at 10:25 PM, Tetsuo Handa > wrote: >> Sargun Dhillon wrote: Remove SECURITY_HOOK_COUNT and "struct security_hook_list"->owner and the exception in randomize_layout_plugin.c because preventing module unloading

[PATCH 2/2] iio: afe: unit-converter: add support for adi,lt6106

2018-04-11 Thread Peter Rosin
This is a current sense amplifier from Analog Devices. Signed-off-by: Peter Rosin --- drivers/iio/afe/Kconfig | 3 +- drivers/iio/afe/iio-unit-converter.c | 54 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/drivers/iio/afe/Kconf

[PATCH v3 0/2] iio: add unit converter

2018-04-11 Thread Peter Rosin
Hi! I'm now following up with one more binding for the unit-converter. This time with a real IC, namely LT6106 from Analog Devices. It's a current sense amplifier. I was a but unsure if I should have the Rin and Rout resistors in the binding or if I instead should have used the "gain". In the end

[PATCH 1/2] dt-bindings: iio: afe: add binding for adi,lt6106

2018-04-11 Thread Peter Rosin
This is a current sense amplifier from Analog Devices. Signed-off-by: Peter Rosin --- .../devicetree/bindings/iio/afe/adi,lt6106.txt | 50 ++ MAINTAINERS| 1 + 2 files changed, 51 insertions(+) create mode 100644 Documentation/dev

Re: [PATCH v10 05/10] livepatch: Support separate list for replaced patches.

2018-04-11 Thread Petr Mladek
On Wed 2018-04-11 07:32:14, Josh Poimboeuf wrote: > On Wed, Apr 11, 2018 at 10:07:31AM +0200, Miroslav Benes wrote: > > > > I was confused by wording "in the middle". It suggested that there > > > > might had been enabled patches on the top and the bottom of the stack > > > > and some disabled patc

Re: [PATCH][next] afs: fix integer overflow when shifting 1 more than 32 places

2018-04-11 Thread Colin Ian King
On 11/04/18 15:10, David Howells wrote: > Colin Ian King wrote: > - mask = (1 << nr_slots) - 1; + mask = (1ULL << nr_slots) - 1; >>> >>> nr_slots cannot be larger than 9, so what I wrote is actually fine and is >>> more efficient on a 32-bit machine. >> >> ok, sorry about the noise. >

[PATCH 0/5] Add support in dwmac-sun8i for accessing EMAC clock

2018-04-11 Thread Icenowy Zheng
On some Allwinner SoCs, the EMAC clock register is in another device's emory space, e.g. on A64 it's in the memory space of SRAM controller. This patchset adds the possibility for the device to export the EMAC clock register as a single-register regmap. PATCH 1 adds the device tree binding for dw

[PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

2018-04-11 Thread Icenowy Zheng
On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i is in another device's memory space. In this situation dwmac-sun8i can use a regmap exported by the other device with only the EMAC clock register. Document this situation in the dwmac-sun8i device tree binding documentation. Si

Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

2018-04-11 Thread Tejun Heo
Hello, On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote: > > But we already do this through calling blkcg_exit_queue() from > > __blk_release_queue(). What's missing? > > Hi, > > It might be the jetlag but I can't see how you end up calling > blkcg_exit_queue() from __blk_release

[PATCH 2/5] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

2018-04-11 Thread Icenowy Zheng
From: Chen-Yu Tsai In several SoCs the EMAC register is in the range of another device, either the SRAM controller (e.g. A64) or the clock controlling unit (e.g. R40). In this situation we're going to let the device to export a regmap which contains only the EMAC register, for the dwmac-sun8i dri

[PATCH] fpga: use SPDX

2018-04-11 Thread Alan Tull
Replace GPLv2 boilerplate with SPDX in FPGA code that came from me or from Altera. Signed-off-by: Alan Tull --- drivers/fpga/altera-fpga2sdram.c | 13 + drivers/fpga/altera-freeze-bridge.c| 13 + drivers/fpga/altera-hps2fpga.c | 13 + drivers

[PATCH 3/5] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from device

2018-04-11 Thread Icenowy Zheng
From: Chen-Yu Tsai On the Allwinner R40 SoC, the "GMAC clock" register is in the CCU address space; on the A64 SoC this register is in the SRAM controller address space, and with a different offset. To access the register from another device and hide the internal difference between the device, l

[PATCH 4/5] drivers: soc: sunxi: export a regmap for EMAC clock reg on A64

2018-04-11 Thread Icenowy Zheng
The A64 SRAM controller memory zone has a EMAC clock register, which is needed by the Ethernet MAC driver (dwmac-sun8i). Export a regmap for this register on A64. Signed-off-by: Icenowy Zheng --- drivers/soc/sunxi/sunxi_sram.c | 48 -- 1 file changed, 46

[PATCH 5/5] arm64: allwinner: a64: add SRAM controller device tree node

2018-04-11 Thread Icenowy Zheng
Allwinner A64 has a SRAM controller, and in the device tree currently we have a syscon node to enable EMAC driver to access the EMAC clock register. As SRAM controller driver can now export regmap for this register, replace the syscon node to the SRAM controller device node, and let EMAC driver to

Re: [PATCH v5 1/3] locking/rwsem: Add DEBUG_RWSEMS to look for lock/unlock mismatches

2018-04-11 Thread Arnd Bergmann
On Fri, Mar 30, 2018 at 11:27 PM, Waiman Long wrote: > For a rwsem, locking can either be exclusive or shared. The corresponding > exclusive or shared unlock must be used. Otherwise, the protected data > structures may get corrupted or the lock may be in an inconsistent state. > > In order to dete

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

2018-04-11 Thread David Miller
From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 > Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Also, all of your networking submissions have been dropped because the net-next tree i

Re: [PATCH] crypto: DRBG - guard uninstantion by lock

2018-04-11 Thread Stephan Müller
Hi Dimitry, This fix prevents the kernel from crashing when injecting the fault. Stack traces are yet shown but I guess that is expected every time a fault is injected. As to why KASAN did not notice this one, I am not sure. Maybe it is because I use two buffer pointers to point to (almost) the

Re: [PATCH] uprobe: add support for overlayfs

2018-04-11 Thread Srikar Dronamraju
* Steven Rostedt [2018-04-10 20:00:59]: > On Tue, 10 Apr 2018 16:10:30 -0700 > Howard McLauchlan wrote: > > > uprobes cannot successfully attach to binaries located in a directory > > mounted with overlayfs. > > > > To verify, create directories for mounting overlayfs > > (upper,lower,work,mer

Re: AMD graphics performance regression in 4.15 and later

2018-04-11 Thread Gabriel C
2018-04-11 11:37 GMT+02:00 Christian König : > Am 11.04.2018 um 06:00 schrieb Gabriel C: >> >> 2018-04-09 11:42 GMT+02:00 Christian König >> : >>> >>> Am 07.04.2018 um 00:00 schrieb Jean-Marc Valin: Hi Christian, Thanks for the info. FYI, I've also opened a Firefox bug for that

Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

2018-04-11 Thread Alexandru Moise
On Wed, Apr 11, 2018 at 07:20:19AM -0700, Tejun Heo wrote: > Hello, > > On Wed, Apr 11, 2018 at 12:12:56PM +0200, Alexandru Moise wrote: > > > But we already do this through calling blkcg_exit_queue() from > > > __blk_release_queue(). What's missing? > > > > Hi, > > > > It might be the jetlag b

Re: [PATCH] net/tls: Remove VLA usage

2018-04-11 Thread Dave Watson
On 04/10/18 05:52 PM, Kees Cook wrote: > In the quest to remove VLAs from the kernel[1], this replaces the VLA > size with the only possible size used in the code, and adds a mechanism > to double-check future IV sizes. > > [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxyd

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

2018-04-11 Thread Jia-Ju Bai
On 2018/4/11 22:26, David Miller wrote: From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Okay, thanks for pointing it out. I will h

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 10:59:17 +0100 > lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP > content, but the value gets overwritten before it is returned and the > read goes ahead anyway. Make the read conditional as it should be > and preserve the error code.

[PATCH] crypto: drbg - set freed buffers to NULL

2018-04-11 Thread Stephan Müller
Sorry, this time with the proper subject line. ---8<--- During freeing of the internal buffers used by the DRBG, set the pointer to NULL. It is possible that the context with the freed buffers is reused. In case of an error during initialization where the pointers do not yet point to allocated me

Re: [PATCH] lan78xx: Avoid spurious kevent 4 "error"

2018-04-11 Thread David Miller
From: Phil Elwell Date: Wed, 11 Apr 2018 12:02:47 +0100 > lan78xx_defer_event generates an error message whenever the work item > is already scheduled. lan78xx_open defers three events - > EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware > of the likelihood (or certainty) of an

Re: [PATCH V2] drm/amdgpu: limit DMA size to PAGE_SIZE for scatter-gather buffers

2018-04-11 Thread Sinan Kaya
On 4/11/2018 8:03 AM, Robin Murphy wrote: > On 10/04/18 21:59, Sinan Kaya wrote: >> Code is expecing to observe the same number of buffers returned from >> dma_map_sg() function compared to sg_alloc_table_from_pages(). This >> doesn't hold true universally especially for systems with IOMMU. > > So

Re: [PATCH] sched/fair: schedutil: update only with all info available

2018-04-11 Thread Patrick Bellasi
On 11-Apr 13:56, Vincent Guittot wrote: > On 11 April 2018 at 12:15, Patrick Bellasi wrote: > > On 11-Apr 08:57, Vincent Guittot wrote: > >> On 10 April 2018 at 13:04, Patrick Bellasi wrote: > >> > On 09-Apr 10:51, Vincent Guittot wrote: > >> >> On 6 April 2018 at 19:28, Patrick Bellasi > >> >>

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

2018-04-11 Thread David Miller
From: Oliver Neukum Date: Wed, 11 Apr 2018 13:25:38 +0200 > Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >>     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >>     using cdc_ether as a driver. >> >>     The modem is  controlled via AT commands through t

Re: [PATCH 00/20] afs: Fixes and development

2018-04-11 Thread David Howells
Linus Torvalds wrote: > Now, the conflicts really do look entirely trivial, and that's not the > problem, but the fact that you *didn't* re-send the AFS pull request > makes me wonder if you perhaps didn't want me to pull it after all? Al's pulled it into his tree. I'm hoping he's going to send

RE: [PATCH] lan78xx: Don't reset the interface on open

2018-04-11 Thread Nisar.Sayed
Hi Phil, > Hi Nisar, > > On 10/04/2018 15:16, nisar.sa...@microchip.com wrote: > > Thanks Phil, for identifying the issues. > > > >> - ret = lan78xx_reset(dev); > >> - if (ret < 0) > >> - goto done; > >> - > >>phy_start(net->phydev); > >> > >>netif_dbg(dev, ifup, dev->net, "phy

[PATCH v2 2/3] eeprom: at24: provide and use a helper for releasing dummy i2c clients

2018-04-11 Thread Bartosz Golaszewski
This allows us to drop two opencoded for loops. We also don't need to check if the i2c client is NULL before calling i2c_unregister_device(). Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/

[PATCH v2 3/3] eeprom: at24: provide a separate routine for creating dummy i2c clients

2018-04-11 Thread Bartosz Golaszewski
Move the code responsible for creating the dummy i2c clients used by chips taking multiple slave addresses to a separate function. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 49 +++--- 1 file changed, 35 insertions(+), 14 deletions(-) dif

[PATCH v2 0/3] eeprom: at24: last bits of the big refactoring

2018-04-11 Thread Bartosz Golaszewski
This is a follow-up to the big series merged for 4.17. The patches contain some bits and pieces that were missing in the last submission or depend on some new features merged this merge window. v1 -> v2: - dropped patch 1/4 because id_table is still needed as pointed out by Peter Rosin - fixed p

Re: [PATCH v2] cpufreq/schedutil: Cleanup, document and fix iowait boost

2018-04-11 Thread Patrick Bellasi
On 11-Apr 12:58, Peter Zijlstra wrote: > On Wed, Apr 11, 2018 at 11:44:45AM +0100, Patrick Bellasi wrote: > > > > - sugov_set_iowait_boost: is now in charge only to set/increase the IO > > > > wait boost, every time a task wakes up from an IO wait. > > > > > > > > - sugov_iowait_boost: is now

[PATCH v2 1/3] eeprom: at24: use devm_nvmem_register()

2018-04-11 Thread Bartosz Golaszewski
We now have a managed variant of nvmem_register(). Use it in at24_probe(). Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 0c125f207aea..02c9dd83

Re: [PATCH] Revert mm/vmstat.c: fix vmstat_update() preemption BUG

2018-04-11 Thread Sebastian Andrzej Siewior
On 2018-04-11 07:09:13 [-0700], Tejun Heo wrote: > Hello, > > On Wed, Apr 11, 2018 at 03:56:43PM +0200, Vlastimil Babka wrote: > > > vmstat_update() is invoked by a kworker on a specific CPU. This worker > > > it bound to this CPU. The name of the worker was "kworker/1:1" so it > > > should have b

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Peter Rosin
Hi Nicolas, Boris asked for your input on this (the datasheet difference appears to have no bearing on the issue) elsewhere in the tree of messages. It's now been a week or so and I'm starting to wonder if you missed this altogether or if you are simply out of office or something? Cheers, Peter

Re: [PATCH 4.14 134/138] vhost: validate log when IOTLB is enabled

2018-04-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 11 Apr 2018 16:25:15 +0300 > On Wed, Apr 11, 2018 at 10:04:13AM +0200, Greg KH wrote: >> On Tue, Apr 10, 2018 at 08:55:53PM -0400, David Miller wrote: >> > From: "Michael S. Tsirkin" >> > Date: Wed, 11 Apr 2018 02:33:16 +0300 >> > >> > > That's a bug, davem

[PATCH v2 1/2] dmaengine: stm32-mdma: align TLEN and buffer length on burst

2018-04-11 Thread Pierre-Yves MORDRET
Both buffer Transfer Length (TLEN if any) and transfer size have to be aligned on burst size (burst beats*bus width). Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial v2: --- --- drivers/dma/stm32-mdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 0/2] Append some fixes and improvements

2018-04-11 Thread Pierre-Yves MORDRET
Fix an issue with FIFO Size and burst size. Fix an incomplete allocator for Hardware descriptors: memory badly allocated. --- Version history: v1: * Initial v2: * Fix kbuild warning format: /0x%08x/%pad/ --- Pierre-Yves MORDRET (2): dmaengine: stm32-mdma: align TLEN and b

[PATCH v2 2/2] dmaengine: stm32-mdma: Fix incomplete Hw descriptors allocator

2018-04-11 Thread Pierre-Yves MORDRET
Only 1 Hw Descriptor is allocated. Loop over required Hw descriptor for proper allocation. Signed-off-by: Pierre-Yves MORDRET --- Version history: v1: * Initial v2: * Fix kbuild warning format: /0x%08x/%pad/ --- --- drivers/dma/stm32-mdma.c | 90 ++

Re: [PATCH v2] cpufreq/schedutil: Cleanup, document and fix iowait boost

2018-04-11 Thread Viresh Kumar
On 11-04-18, 11:48, Patrick Bellasi wrote: > On 11-Apr 10:07, Viresh Kumar wrote: > > On 10-04-18, 16:59, Patrick Bellasi wrote: > > The above part should be a different patch with this: > > > > Fixes: a5a0809bc58e ("cpufreq: schedutil: Make iowait boost more energy > > efficient") > > You mean

Re: [linux-sunxi] [PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

2018-04-11 Thread Brüns , Stefan
On Mittwoch, 11. April 2018 16:16:37 CEST Icenowy Zheng wrote: > On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i is > in another device's memory space. In this situation dwmac-sun8i can use > a regmap exported by the other device with only the EMAC clock register. > > Document

Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

2018-04-11 Thread Tejun Heo
Hello, On Wed, Apr 11, 2018 at 04:28:59PM +0200, Alexandru Moise wrote: > > Ah, that changed recently. Can you please check out the current > > upstream git master? > > > Just did, without my patch I see this crash: lol I was looking at the old tree, so this is the fix for the new breakage intr

Re: KASAN: stack-out-of-bounds Read in __free_filter

2018-04-11 Thread Steven Rostedt
On Wed, 11 Apr 2018 05:02:02 -0700 syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) > Merge tag 'ceph-for-4.17-rc1' of git://github.com/ceph/ceph-client > syzbot dashboard link: > https://sy

Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

2018-04-11 Thread Tejun Heo
Hello, (cc'ing Bart) On Wed, Apr 11, 2018 at 07:46:16AM -0700, Tejun Heo wrote: > Hello, > > On Wed, Apr 11, 2018 at 04:28:59PM +0200, Alexandru Moise wrote: > > > Ah, that changed recently. Can you please check out the current > > > upstream git master? > > > > > Just did, without my patch I

Re: KASAN: stack-out-of-bounds Read in __free_filter

2018-04-11 Thread Dmitry Vyukov
On Wed, Apr 11, 2018 at 4:47 PM, Steven Rostedt wrote: > On Wed, 11 Apr 2018 05:02:02 -0700 > syzbot wrote: > >> Hello, >> >> syzbot hit the following crash on upstream commit >> b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) >> Merge tag 'ceph-for-4.17-rc1' of git://gi

Re: [PATCH] mmc: sdhci-pci: Only do AMD tuning for HS200

2018-04-11 Thread Ulf Hansson
On 7 April 2018 at 00:07, Daniel Kurtz wrote: > Commit c31165d7400b ("mmc: sdhci-pci: Add support for HS200 tuning mode > on AMD, eMMC-4.5.1") added a HS200 tuning method for use with AMD SDHCI > controllers. As described in the commit subject, this tuning is specific > for HS200. However, as im

Re: [PATCH 1/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4

2018-04-11 Thread Dennis Dalessandro
On 4/11/2018 3:32 AM, Jia-Ju Bai wrote: i40iw_add_mqh_4() is never called in atomic context, because it calls rtnl_lock() that can sleep. Despite never getting called from atomic context, i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not ne

Re: [PATCH] sched/fair: schedutil: update only with all info available

2018-04-11 Thread Peter Zijlstra
On Fri, Apr 06, 2018 at 06:28:35PM +0100, Patrick Bellasi wrote: > is maintained although there are not actual usages so far in mainline > for this hint... do we really need it? There were intel_pstate patches that I expected to have shown up already, and I meant to have a look at sugov, except I

Re: [PATCH v3] isofs compress: Remove VLA usage

2018-04-11 Thread Joe Perches
On Wed, 2018-04-11 at 07:39 +0100, Al Viro wrote: > Shit happens... > > Al, fully expecting to discover having made something spectacularly bonehead > 2 minutes after sending a patch out - happens often enough. I've done that. Again, no worries.

Re: [PATCH v2] cpufreq/schedutil: Cleanup, document and fix iowait boost

2018-04-11 Thread Viresh Kumar
On 11-04-18, 15:39, Patrick Bellasi wrote: > On 11-Apr 12:58, Peter Zijlstra wrote: > > On Wed, Apr 11, 2018 at 11:44:45AM +0100, Patrick Bellasi wrote: > > > > > - sugov_set_iowait_boost: is now in charge only to set/increase the IO > > > > > wait boost, every time a task wakes up from an IO

Re: [PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check

2018-04-11 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 11 Apr 2018 16:24:02 +0300 > On Wed, Apr 11, 2018 at 10:35:39AM +0800, Stefan Hajnoczi wrote: >> v3: >> * Rebased onto net/master and resolved conflict [DaveM] >> >> v2: >> * Rewrote the conditional to make the vq access check clearer [Linus] >> * Added P

Re: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release

2018-04-11 Thread Tejun Heo
Hello, again. On Wed, Apr 11, 2018 at 07:51:23AM -0700, Tejun Heo wrote: > Oh, it wasn't Joseph's change. It was Bart's fix for a problem > reported by Joseph. Bart, a063057d7c73 ("block: Fix a race between > request queue removal and the block cgroup controller") created a > regression where a

Re: WARNING in kobject_add_internal

2018-04-11 Thread Dmitry Vyukov
On Fri, Jan 5, 2018 at 10:41 PM, syzbot wrote: > syzkaller has found reproducer for the following crash on > 89876f275e8d562912d9c238cd888b52065cf25c > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: KASAN: stack-out-of-bounds Read in __free_filter

2018-04-11 Thread Steven Rostedt
On Wed, 11 Apr 2018 16:51:02 +0200 Dmitry Vyukov wrote: > Hi Steve, > > Instructions for asking syzbot to test a patch are here: > > https://github.com/google/syzkaller/blob/master/docs/syzbot.md#communication-with-syzbot I'll just add reported-by and add the patch. It does fix a bug, regardle

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 16:44:10 +0200 Peter Rosin wrote: > Hi Nicolas, > > Boris asked for your input on this (the datasheet difference appears to > have no bearing on the issue) elsewhere in the tree of messages. It's > now been a week or so and I'm starting to wonder if you missed this > altogeth

[PATCH] lib: micro-optimization for __bitmap_complement()

2018-04-11 Thread Yury Norov
Use BITS_TO_LONGS() macro to avoid calculation of reminder (bits % BITS_PER_LONG) On ARM64 it saves 5 instruction for function - 16 before and 11 after. Signed-off-by: Yury Norov --- lib/bitmap.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/bitmap.c b/lib/bitmap.c

<    1   2   3   4   5   6   7   8   9   10   >